bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2012 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
| 7 | |
| 8 | #include "GrConfigConversionEffect.h" |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 9 | #include "GrContext.h" |
bsalomon@google.com | 2eaaefd | 2012-10-29 19:51:22 +0000 | [diff] [blame] | 10 | #include "GrTBackendEffectFactory.h" |
bsalomon@google.com | d698f77 | 2012-10-25 13:22:00 +0000 | [diff] [blame] | 11 | #include "gl/GrGLEffect.h" |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 12 | #include "gl/GrGLEffectMatrix.h" |
| 13 | #include "SkMatrix.h" |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 14 | |
bsalomon@google.com | 22a800a | 2012-10-26 19:16:46 +0000 | [diff] [blame] | 15 | class GrGLConfigConversionEffect : public GrGLEffect { |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 16 | public: |
bsalomon@google.com | 396e61f | 2012-10-25 19:00:29 +0000 | [diff] [blame] | 17 | GrGLConfigConversionEffect(const GrBackendEffectFactory& factory, |
bsalomon@google.com | a469c28 | 2012-10-24 18:28:34 +0000 | [diff] [blame] | 18 | const GrEffect& s) : INHERITED (factory) { |
bsalomon@google.com | 021fc73 | 2012-10-25 12:47:42 +0000 | [diff] [blame] | 19 | const GrConfigConversionEffect& effect = static_cast<const GrConfigConversionEffect&>(s); |
| 20 | fSwapRedAndBlue = effect.swapsRedAndBlue(); |
| 21 | fPMConversion = effect.pmConversion(); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 22 | } |
| 23 | |
bsalomon@google.com | 22a800a | 2012-10-26 19:16:46 +0000 | [diff] [blame] | 24 | virtual void emitCode(GrGLShaderBuilder* builder, |
bsalomon@google.com | 2eaaefd | 2012-10-29 19:51:22 +0000 | [diff] [blame] | 25 | const GrEffectStage&, |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 26 | EffectKey key, |
bsalomon@google.com | 22a800a | 2012-10-26 19:16:46 +0000 | [diff] [blame] | 27 | const char* vertexCoords, |
| 28 | const char* outputColor, |
| 29 | const char* inputColor, |
| 30 | const TextureSamplerArray& samplers) SK_OVERRIDE { |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 31 | const char* coords; |
| 32 | GrSLType coordsType = fEffectMatrix.emitCode(builder, key, vertexCoords, &coords); |
bsalomon@google.com | 868a8e7 | 2012-08-30 19:11:34 +0000 | [diff] [blame] | 33 | builder->fFSCode.appendf("\t\t%s = ", outputColor); |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 34 | builder->appendTextureLookup(&builder->fFSCode, samplers[0], coords, coordsType); |
bsalomon@google.com | 2d8edaf | 2012-09-07 14:47:31 +0000 | [diff] [blame] | 35 | builder->fFSCode.append(";\n"); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 36 | if (GrConfigConversionEffect::kNone_PMConversion == fPMConversion) { |
| 37 | GrAssert(fSwapRedAndBlue); |
bsalomon@google.com | 868a8e7 | 2012-08-30 19:11:34 +0000 | [diff] [blame] | 38 | builder->fFSCode.appendf("\t%s = %s.bgra;\n", outputColor, outputColor); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 39 | } else { |
| 40 | const char* swiz = fSwapRedAndBlue ? "bgr" : "rgb"; |
| 41 | switch (fPMConversion) { |
| 42 | case GrConfigConversionEffect::kMulByAlpha_RoundUp_PMConversion: |
| 43 | builder->fFSCode.appendf( |
bsalomon@google.com | 868a8e7 | 2012-08-30 19:11:34 +0000 | [diff] [blame] | 44 | "\t\t%s = vec4(ceil(%s.%s * %s.a * 255.0) / 255.0, %s.a);\n", |
| 45 | outputColor, outputColor, swiz, outputColor, outputColor); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 46 | break; |
| 47 | case GrConfigConversionEffect::kMulByAlpha_RoundDown_PMConversion: |
| 48 | builder->fFSCode.appendf( |
bsalomon@google.com | 868a8e7 | 2012-08-30 19:11:34 +0000 | [diff] [blame] | 49 | "\t\t%s = vec4(floor(%s.%s * %s.a * 255.0) / 255.0, %s.a);\n", |
| 50 | outputColor, outputColor, swiz, outputColor, outputColor); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 51 | break; |
| 52 | case GrConfigConversionEffect::kDivByAlpha_RoundUp_PMConversion: |
bsalomon@google.com | 868a8e7 | 2012-08-30 19:11:34 +0000 | [diff] [blame] | 53 | builder->fFSCode.appendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(ceil(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n", |
| 54 | outputColor, outputColor, outputColor, swiz, outputColor, outputColor); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 55 | break; |
| 56 | case GrConfigConversionEffect::kDivByAlpha_RoundDown_PMConversion: |
bsalomon@google.com | 868a8e7 | 2012-08-30 19:11:34 +0000 | [diff] [blame] | 57 | builder->fFSCode.appendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(floor(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n", |
| 58 | outputColor, outputColor, outputColor, swiz, outputColor, outputColor); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 59 | break; |
robertphillips@google.com | 2af1b18 | 2012-08-28 11:23:09 +0000 | [diff] [blame] | 60 | default: |
| 61 | GrCrash("Unknown conversion op."); |
| 62 | break; |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 63 | } |
| 64 | } |
bsalomon@google.com | 868a8e7 | 2012-08-30 19:11:34 +0000 | [diff] [blame] | 65 | GrGLSLMulVarBy4f(&builder->fFSCode, 2, outputColor, inputColor); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 66 | } |
| 67 | |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 68 | void setData(const GrGLUniformManager& uman, const GrEffectStage& stage) { |
| 69 | const GrConfigConversionEffect& effect = |
| 70 | static_cast<const GrConfigConversionEffect&>(*stage.getEffect()); |
| 71 | fEffectMatrix.setData(uman, |
| 72 | effect.getMatrix(), |
| 73 | stage.getCoordChangeMatrix(), |
| 74 | effect.texture(0)); |
| 75 | } |
| 76 | |
bsalomon@google.com | 2eaaefd | 2012-10-29 19:51:22 +0000 | [diff] [blame] | 77 | static inline EffectKey GenKey(const GrEffectStage& s, const GrGLCaps&) { |
| 78 | const GrConfigConversionEffect& effect = |
| 79 | static_cast<const GrConfigConversionEffect&>(*s.getEffect()); |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 80 | EffectKey key = static_cast<EffectKey>(effect.swapsRedAndBlue()) | |
| 81 | (effect.pmConversion() << 1); |
| 82 | key <<= GrGLEffectMatrix::kKeyBits; |
| 83 | EffectKey matrixKey = GrGLEffectMatrix::GenKey(effect.getMatrix(), |
| 84 | s.getCoordChangeMatrix(), |
| 85 | effect.texture(0)); |
| 86 | GrAssert(!(matrixKey & key)); |
| 87 | return matrixKey | key; |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 88 | } |
| 89 | |
| 90 | private: |
| 91 | bool fSwapRedAndBlue; |
| 92 | GrConfigConversionEffect::PMConversion fPMConversion; |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 93 | GrGLEffectMatrix fEffectMatrix; |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 94 | |
bsalomon@google.com | 22a800a | 2012-10-26 19:16:46 +0000 | [diff] [blame] | 95 | typedef GrGLEffect INHERITED; |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 96 | |
| 97 | }; |
| 98 | |
| 99 | /////////////////////////////////////////////////////////////////////////////// |
| 100 | |
| 101 | GrConfigConversionEffect::GrConfigConversionEffect(GrTexture* texture, |
| 102 | bool swapRedAndBlue, |
bsalomon@google.com | b1456d7 | 2012-11-02 18:23:45 +0000 | [diff] [blame] | 103 | PMConversion pmConversion, |
| 104 | const SkMatrix& matrix) |
| 105 | : GrSingleTextureEffect(texture, matrix) |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 106 | , fSwapRedAndBlue(swapRedAndBlue) |
| 107 | , fPMConversion(pmConversion) { |
| 108 | GrAssert(kRGBA_8888_GrPixelConfig == texture->config() || |
| 109 | kBGRA_8888_GrPixelConfig == texture->config()); |
| 110 | // Why did we pollute our texture cache instead of using a GrSingleTextureEffect? |
| 111 | GrAssert(swapRedAndBlue || kNone_PMConversion != pmConversion); |
| 112 | } |
| 113 | |
bsalomon@google.com | 396e61f | 2012-10-25 19:00:29 +0000 | [diff] [blame] | 114 | const GrBackendEffectFactory& GrConfigConversionEffect::getFactory() const { |
| 115 | return GrTBackendEffectFactory<GrConfigConversionEffect>::getInstance(); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 116 | } |
| 117 | |
bsalomon@google.com | a469c28 | 2012-10-24 18:28:34 +0000 | [diff] [blame] | 118 | bool GrConfigConversionEffect::isEqual(const GrEffect& s) const { |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 119 | const GrConfigConversionEffect& other = static_cast<const GrConfigConversionEffect&>(s); |
| 120 | return other.fSwapRedAndBlue == fSwapRedAndBlue && other.fPMConversion == fPMConversion; |
| 121 | } |
| 122 | |
| 123 | /////////////////////////////////////////////////////////////////////////////// |
| 124 | |
bsalomon@google.com | f271cc7 | 2012-10-24 19:35:13 +0000 | [diff] [blame] | 125 | GR_DEFINE_EFFECT_TEST(GrConfigConversionEffect); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 126 | |
bsalomon@google.com | 0ac6af4 | 2013-01-16 15:16:18 +0000 | [diff] [blame] | 127 | GrEffectRef* GrConfigConversionEffect::TestCreate(SkRandom* random, |
| 128 | GrContext* context, |
| 129 | GrTexture* textures[]) { |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 130 | PMConversion pmConv = static_cast<PMConversion>(random->nextULessThan(kPMConversionCnt)); |
| 131 | bool swapRB; |
| 132 | if (kNone_PMConversion == pmConv) { |
| 133 | swapRB = true; |
| 134 | } else { |
| 135 | swapRB = random->nextBool(); |
| 136 | } |
bsalomon@google.com | 0ac6af4 | 2013-01-16 15:16:18 +0000 | [diff] [blame] | 137 | SkAutoTUnref<GrEffect> effect(SkNEW_ARGS(GrConfigConversionEffect, |
| 138 | (textures[GrEffectUnitTest::kSkiaPMTextureIdx], |
| 139 | swapRB, |
| 140 | pmConv, |
| 141 | GrEffectUnitTest::TestMatrix(random)))); |
bsalomon@google.com | a1ebbe4 | 2013-01-16 15:51:47 +0000 | [diff] [blame^] | 142 | return CreateEffectRef(effect); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 143 | } |
| 144 | |
| 145 | /////////////////////////////////////////////////////////////////////////////// |
| 146 | void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context, |
| 147 | PMConversion* pmToUPMRule, |
| 148 | PMConversion* upmToPMRule) { |
| 149 | *pmToUPMRule = kNone_PMConversion; |
| 150 | *upmToPMRule = kNone_PMConversion; |
| 151 | SkAutoTMalloc<uint32_t> data(256 * 256 * 3); |
| 152 | uint32_t* srcData = data.get(); |
| 153 | uint32_t* firstRead = data.get() + 256 * 256; |
| 154 | uint32_t* secondRead = data.get() + 2 * 256 * 256; |
| 155 | |
| 156 | // Fill with every possible premultiplied A, color channel value. There will be 256-y duplicate |
| 157 | // values in row y. We set r,g, and b to the same value since they are handled identically. |
| 158 | for (int y = 0; y < 256; ++y) { |
| 159 | for (int x = 0; x < 256; ++x) { |
| 160 | uint8_t* color = reinterpret_cast<uint8_t*>(&srcData[256*y + x]); |
| 161 | color[3] = y; |
| 162 | color[2] = GrMin(x, y); |
| 163 | color[1] = GrMin(x, y); |
| 164 | color[0] = GrMin(x, y); |
| 165 | } |
| 166 | } |
| 167 | |
| 168 | GrTextureDesc desc; |
| 169 | desc.fFlags = kRenderTarget_GrTextureFlagBit | |
| 170 | kNoStencil_GrTextureFlagBit; |
| 171 | desc.fWidth = 256; |
| 172 | desc.fHeight = 256; |
| 173 | desc.fConfig = kRGBA_8888_GrPixelConfig; |
| 174 | |
| 175 | SkAutoTUnref<GrTexture> readTex(context->createUncachedTexture(desc, NULL, 0)); |
| 176 | if (!readTex.get()) { |
| 177 | return; |
| 178 | } |
| 179 | SkAutoTUnref<GrTexture> tempTex(context->createUncachedTexture(desc, NULL, 0)); |
| 180 | if (!tempTex.get()) { |
| 181 | return; |
| 182 | } |
| 183 | desc.fFlags = kNone_GrTextureFlags; |
| 184 | SkAutoTUnref<GrTexture> dataTex(context->createUncachedTexture(desc, data, 0)); |
| 185 | if (!dataTex.get()) { |
| 186 | return; |
| 187 | } |
| 188 | |
| 189 | static const PMConversion kConversionRules[][2] = { |
| 190 | {kDivByAlpha_RoundDown_PMConversion, kMulByAlpha_RoundUp_PMConversion}, |
| 191 | {kDivByAlpha_RoundUp_PMConversion, kMulByAlpha_RoundDown_PMConversion}, |
| 192 | }; |
| 193 | |
| 194 | GrContext::AutoWideOpenIdentityDraw awoid(context, NULL); |
| 195 | |
| 196 | bool failed = true; |
| 197 | |
| 198 | for (size_t i = 0; i < GR_ARRAY_COUNT(kConversionRules) && failed; ++i) { |
| 199 | *pmToUPMRule = kConversionRules[i][0]; |
| 200 | *upmToPMRule = kConversionRules[i][1]; |
| 201 | |
bsalomon@google.com | 8171288 | 2012-11-01 17:12:34 +0000 | [diff] [blame] | 202 | static const GrRect kDstRect = GrRect::MakeWH(SkIntToScalar(256), SkIntToScalar(256)); |
| 203 | static const GrRect kSrcRect = GrRect::MakeWH(SK_Scalar1, SK_Scalar1); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 204 | // We do a PM->UPM draw from dataTex to readTex and read the data. Then we do a UPM->PM draw |
| 205 | // from readTex to tempTex followed by a PM->UPM draw to readTex and finally read the data. |
| 206 | // We then verify that two reads produced the same values. |
| 207 | |
| 208 | GrPaint paint; |
bsalomon@google.com | 0ac6af4 | 2013-01-16 15:16:18 +0000 | [diff] [blame] | 209 | SkAutoTUnref<GrEffect> pmToUPM1(SkNEW_ARGS(GrConfigConversionEffect, (dataTex, |
| 210 | false, |
| 211 | *pmToUPMRule, |
| 212 | SkMatrix::I()))); |
| 213 | SkAutoTUnref<GrEffect> upmToPM(SkNEW_ARGS(GrConfigConversionEffect, (readTex, |
| 214 | false, |
| 215 | *upmToPMRule, |
| 216 | SkMatrix::I()))); |
| 217 | SkAutoTUnref<GrEffect> pmToUPM2(SkNEW_ARGS(GrConfigConversionEffect, (tempTex, |
| 218 | false, |
| 219 | *pmToUPMRule, |
| 220 | SkMatrix::I()))); |
| 221 | |
bsalomon@google.com | a1ebbe4 | 2013-01-16 15:51:47 +0000 | [diff] [blame^] | 222 | SkAutoTUnref<GrEffectRef> pmToUPMEffect1(CreateEffectRef(pmToUPM1)); |
| 223 | SkAutoTUnref<GrEffectRef> upmToPMEffect(CreateEffectRef(upmToPM)); |
| 224 | SkAutoTUnref<GrEffectRef> pmToUPMEffect2(CreateEffectRef(pmToUPM2)); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 225 | |
| 226 | context->setRenderTarget(readTex->asRenderTarget()); |
bsalomon@google.com | 08283af | 2012-10-26 13:01:20 +0000 | [diff] [blame] | 227 | paint.colorStage(0)->setEffect(pmToUPMEffect1); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 228 | context->drawRectToRect(paint, kDstRect, kSrcRect); |
| 229 | |
| 230 | readTex->readPixels(0, 0, 256, 256, kRGBA_8888_GrPixelConfig, firstRead); |
| 231 | |
| 232 | context->setRenderTarget(tempTex->asRenderTarget()); |
bsalomon@google.com | 08283af | 2012-10-26 13:01:20 +0000 | [diff] [blame] | 233 | paint.colorStage(0)->setEffect(upmToPMEffect); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 234 | context->drawRectToRect(paint, kDstRect, kSrcRect); |
| 235 | context->setRenderTarget(readTex->asRenderTarget()); |
bsalomon@google.com | 08283af | 2012-10-26 13:01:20 +0000 | [diff] [blame] | 236 | paint.colorStage(0)->setEffect(pmToUPMEffect2); |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 237 | context->drawRectToRect(paint, kDstRect, kSrcRect); |
| 238 | |
| 239 | readTex->readPixels(0, 0, 256, 256, kRGBA_8888_GrPixelConfig, secondRead); |
| 240 | |
| 241 | failed = false; |
| 242 | for (int y = 0; y < 256 && !failed; ++y) { |
| 243 | for (int x = 0; x <= y; ++x) { |
| 244 | if (firstRead[256 * y + x] != secondRead[256 * y + x]) { |
| 245 | failed = true; |
| 246 | break; |
| 247 | } |
| 248 | } |
| 249 | } |
| 250 | } |
| 251 | if (failed) { |
| 252 | *pmToUPMRule = kNone_PMConversion; |
| 253 | *upmToPMRule = kNone_PMConversion; |
| 254 | } |
| 255 | } |
| 256 | |
bsalomon@google.com | d8b5fac | 2012-11-01 17:02:46 +0000 | [diff] [blame] | 257 | bool GrConfigConversionEffect::InstallEffect(GrTexture* texture, |
| 258 | bool swapRedAndBlue, |
| 259 | PMConversion pmConversion, |
bsalomon@google.com | b9086a0 | 2012-11-01 18:02:54 +0000 | [diff] [blame] | 260 | const SkMatrix& matrix, |
bsalomon@google.com | d8b5fac | 2012-11-01 17:02:46 +0000 | [diff] [blame] | 261 | GrEffectStage* stage) { |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 262 | if (!swapRedAndBlue && kNone_PMConversion == pmConversion) { |
| 263 | // If we returned a GrConfigConversionEffect that was equivalent to a GrSingleTextureEffect |
| 264 | // then we may pollute our texture cache with redundant shaders. So in the case that no |
| 265 | // conversions were requested we instead return a GrSingleTextureEffect. |
bsalomon@google.com | 0ac6af4 | 2013-01-16 15:16:18 +0000 | [diff] [blame] | 266 | stage->setEffect(GrSingleTextureEffect::Create(texture, matrix))->unref(); |
bsalomon@google.com | d8b5fac | 2012-11-01 17:02:46 +0000 | [diff] [blame] | 267 | return true; |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 268 | } else { |
| 269 | if (kRGBA_8888_GrPixelConfig != texture->config() && |
| 270 | kBGRA_8888_GrPixelConfig != texture->config() && |
| 271 | kNone_PMConversion != pmConversion) { |
| 272 | // The PM conversions assume colors are 0..255 |
bsalomon@google.com | d8b5fac | 2012-11-01 17:02:46 +0000 | [diff] [blame] | 273 | return false; |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 274 | } |
bsalomon@google.com | 0ac6af4 | 2013-01-16 15:16:18 +0000 | [diff] [blame] | 275 | SkAutoTUnref<GrEffect> effect(SkNEW_ARGS(GrConfigConversionEffect, (texture, |
| 276 | swapRedAndBlue, |
| 277 | pmConversion, |
| 278 | matrix))); |
bsalomon@google.com | a1ebbe4 | 2013-01-16 15:51:47 +0000 | [diff] [blame^] | 279 | stage->setEffect(CreateEffectRef(effect))->unref(); |
bsalomon@google.com | d8b5fac | 2012-11-01 17:02:46 +0000 | [diff] [blame] | 280 | return true; |
bsalomon@google.com | a04e8e8 | 2012-08-27 12:53:13 +0000 | [diff] [blame] | 281 | } |
| 282 | } |