commit d09bd1074f9d3b7f5dd842bd96bce7df07a18057
author Jon Ashburn <jon@lunarg.com> Wed Oct 22 21:15:26 2014 -0600
committer Courtney Goeltzenleuchter <courtney@LunarG.com> Wed Oct 29 18:02:01 2014 -0600
tree ed1e5d1a74c7212fa99833245cdda4a0b2532753
parent 6b4d70c968a911c4937e722bbae92b87a7bf5732

Fix memory leaks in loader  related to layers.

layers/README.md

diff --git a/layers/README.md b/layers/README.md
index 135c69e..75a0d28 100644
--- a/layers/README.md
+++ b/layers/README.md
@@ -18,11 +18,11 @@
 Using Layers::
 Build XGL loader  and i965 icd driver using normal steps (cmake and make)
 Place libXGLLayer<name>.so in the same directory as your XGL test or app:
-  cp build/layer/libXGLLayerBasic.so build/tests
+  cp build/layer/libXGLLayerBasic.so build/layer/libXGLLayerGeneric.so build/tests
 
 Specify which Layers to activate by using xglCreateDevice XGL_LAYER_CREATE_INFO struct or
 environment variable LIBXGL_LAYERS_LIB
-   export LIBXGL_LAYERS_LIB=libXGLLayerBasic.so
+   export LIBXGL_LAYERS_LIB=libXGLLayerBasic.so:LibXGLLayerGeneric.so
    cd build/tests; ./xglinfo
 
 
@@ -39,7 +39,6 @@
 -layer libraries can be LD_PRELOADed
 
 Current known issues:
--memory leak of gpu wrapped objects
 -layer libraries don't support multiple dispatch tables for multi-gpus
 -layers  with extension APIs  not yet tested or supported
 -layer libraries not yet include loader init functionality for full  LD_PRELOAD of

loader/loader.c

diff --git a/loader/loader.c b/loader/loader.c
index 01205f1..7dea427 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -53,6 +53,7 @@
     XGL_LAYER_DISPATCH_TABLE *loader_dispatch;
     XGL_UINT layer_count[XGL_MAX_PHYSICAL_GPUS];
     struct loader_layers layer_libs[XGL_MAX_PHYSICAL_GPUS][MAX_LAYER_LIBRARIES];
+    XGL_BASE_LAYER_OBJECT *wrappedGpus[XGL_MAX_PHYSICAL_GPUS];
     XGL_UINT gpu_count;
     XGL_BASE_LAYER_OBJECT *gpus;
 
@@ -615,7 +616,7 @@
             } else {
                 loader_log(XGL_DBG_MSG_UNKNOWN, 0, "Inserting layer lib %s", obj->lib_name);
             }
-
+            free(ppLayerNames[i]);
             icd->layer_count[gpu_index]++;
         }
     }
@@ -625,13 +626,14 @@
 {
     const char *layerEnv;
     XGL_UINT len, count = 0;
-    char *p, *next, *name;
+    char *p, *pOrig, *next, *name;
 
     layerEnv = getenv("LIBXGL_LAYER_LIBS");
     p = malloc(strlen(layerEnv) + 1);
     if (!p)
         return 0;
     strcpy(p, layerEnv);
+    pOrig = p;
 
     while (p && *p && count < MAX_LAYER_LIBRARIES) {
         bool foundScanned = false;
@@ -661,8 +663,10 @@
         //copy to convert any dir path differences between scanned and base names
         len = strlen(loader.scanned_layer_names[j]);
         ppLayerNames[count] = malloc(len + 1);
-        if (!ppLayerNames[count])
+        if (!ppLayerNames[count]) {
+            free(pOrig);
             return count;
+        }
         strncpy((char *) ppLayerNames[count], loader.scanned_layer_names[j], len);
         ppLayerNames[count][len] = '\0';
         count++;
@@ -670,6 +674,7 @@
 
     };
 
+    free(pOrig);
     return count;
 }
 
@@ -721,7 +726,6 @@
     struct loader_layers *libs;
 
     for (icd = loader.icds; icd; icd = icd->next) {
-        //TODO clean up the wrapped gpu structs malloced during layer activation
         if (icd->gpus)
             free(icd->gpus);
         icd->gpus = NULL;
@@ -737,6 +741,8 @@
                         dlclose(libs->lib_handle);
                     libs->lib_handle = NULL;
                 }
+                if (icd->wrappedGpus[j])
+                    free(icd->wrappedGpus[j]);
             }
             icd->layer_count[j] = 0;
         }
@@ -766,11 +772,11 @@
             return 0;
         loader_init_layer_libs(icd, gpu_index, ppLayerNames, count);
 
+        icd->wrappedGpus[gpu_index] = malloc(sizeof(XGL_BASE_LAYER_OBJECT) * icd->layer_count[gpu_index]);
+        if (! icd->wrappedGpus[gpu_index])
+                loader_log(XGL_DBG_MSG_ERROR, 0, "Failed to malloc Gpu objects for layer");
         for (XGL_INT i = icd->layer_count[gpu_index] - 1; i >= 0; i--) {
-            //create newly wrapped gpu object
-            nextGpuObj = malloc(sizeof(XGL_BASE_LAYER_OBJECT));
-            if (! nextGpuObj)
-                loader_log(XGL_DBG_MSG_ERROR, 0, "Failed to malloc Gpu object for layer");
+            nextGpuObj = (icd->wrappedGpus[gpu_index] + i);
             nextGpuObj->pGPA = nextGPA;
             nextGpuObj->baseObject = gpuObj->baseObject;
             nextGpuObj->nextObject = gpuObj;