blob: 4345154ee91aabdc1078c84d8d6728b008bb961c [file] [log] [blame]
Tobin Ehlis2d9deec2016-04-21 14:19:26 -06001/* Copyright (c) 2015-2016 The Khronos Group Inc.
2 * Copyright (c) 2015-2016 Valve Corporation
3 * Copyright (c) 2015-2016 LunarG, Inc.
4 * Copyright (C) 2015-2016 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Tobin Ehlis <tobine@google.com>
19 */
20#ifndef CORE_VALIDATION_DESCRIPTOR_SETS_H_
21#define CORE_VALIDATION_DESCRIPTOR_SETS_H_
22
23// Check for noexcept support
Mark Lobodzinskia5efa732016-10-10 14:05:59 -060024#ifndef NOEXCEPT
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060025#if defined(__clang__)
26#if __has_feature(cxx_noexcept)
27#define HAS_NOEXCEPT
28#endif
29#else
30#if defined(__GXX_EXPERIMENTAL_CXX0X__) && __GNUC__ * 10 + __GNUC_MINOR__ >= 46
31#define HAS_NOEXCEPT
32#else
33#if defined(_MSC_FULL_VER) && _MSC_FULL_VER >= 190023026 && defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS
34#define HAS_NOEXCEPT
35#endif
36#endif
37#endif
38
39#ifdef HAS_NOEXCEPT
40#define NOEXCEPT noexcept
41#else
42#define NOEXCEPT
43#endif
Mark Lobodzinskia5efa732016-10-10 14:05:59 -060044#endif
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060045
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060046#include "core_validation_error_enums.h"
Tobin Ehlisbf98b692016-10-06 12:58:06 -060047#include "vk_validation_error_messages.h"
Tobin Ehlis0a43bde2016-05-03 08:31:08 -060048#include "core_validation_types.h"
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060049#include "vk_layer_logging.h"
Tobin Ehlis0a43bde2016-05-03 08:31:08 -060050#include "vk_layer_utils.h"
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060051#include "vk_safe_struct.h"
52#include "vulkan/vk_layer.h"
Tobin Ehliscebc4c02016-08-22 10:10:43 -060053#include <map>
Tobin Ehlis0a43bde2016-05-03 08:31:08 -060054#include <memory>
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060055#include <unordered_map>
Tobin Ehlis0a43bde2016-05-03 08:31:08 -060056#include <unordered_set>
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060057#include <vector>
58
59// Descriptor Data structures
60
61/*
62 * DescriptorSetLayout class
63 *
64 * Overview - This class encapsulates the Vulkan VkDescriptorSetLayout data (layout).
65 * A layout consists of some number of bindings, each of which has a binding#, a
66 * type, descriptor count, stage flags, and pImmutableSamplers.
67 *
68 * Index vs Binding - A layout is created with an array of VkDescriptorSetLayoutBinding
69 * where each array index will have a corresponding binding# that is defined in that struct.
70 * This class, therefore, provides utility functions where you can retrieve data for
71 * layout bindings based on either the original index into the pBindings array, or based
72 * on the binding#.
73 * Typically if you want to cover all of the bindings in a layout, you can do that by
74 * iterating over GetBindingCount() bindings and using the Get*FromIndex() functions.
75 * Otherwise, you can use the Get*FromBinding() functions to just grab binding info
76 * for a particular binding#.
77 *
78 * Global Index - The "Index" referenced above is the index into the original pBindings
79 * array. So there are as many indices as there are bindings.
80 * This class also has the concept of a Global Index. For the global index functions,
81 * there are as many global indices as there are descriptors in the layout.
82 * For the global index, consider all of the bindings to be a flat array where
83 * descriptor 0 of pBinding[0] is index 0 and each descriptor in the layout increments
84 * from there. So if pBinding[0] in this example had descriptorCount of 10, then
85 * the GlobalStartIndex of pBinding[1] will be 10 where 0-9 are the global indices
86 * for pBinding[0].
87 */
Tobin Ehlis0a43bde2016-05-03 08:31:08 -060088namespace cvdescriptorset {
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060089class DescriptorSetLayout {
90 public:
91 // Constructors and destructor
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060092 DescriptorSetLayout(debug_report_data *report_data, const VkDescriptorSetLayoutCreateInfo *p_create_info,
93 const VkDescriptorSetLayout layout);
Tobin Ehlis2d9deec2016-04-21 14:19:26 -060094 // Straightforward Get functions
Tobin Ehlis0a43bde2016-05-03 08:31:08 -060095 VkDescriptorSetLayout GetDescriptorSetLayout() const { return layout_; };
96 uint32_t GetTotalDescriptorCount() const { return descriptor_count_; };
97 uint32_t GetDynamicDescriptorCount() const { return dynamic_descriptor_count_; };
98 uint32_t GetBindingCount() const { return binding_count_; };
99 // Fill passed-in set with bindings
100 void FillBindingSet(std::unordered_set<uint32_t> *) const;
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600101 // Return true if given binding is present in this layout
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600102 bool HasBinding(const uint32_t binding) const { return binding_to_index_map_.count(binding) > 0; };
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600103 // Return true if this layout is compatible with passed in layout,
104 // else return false and update error_msg with description of incompatibility
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600105 bool IsCompatible(const DescriptorSetLayout *, std::string *) const;
106 // Return true if binding 1 beyond given exists and has same type, stageFlags & immutable sampler use
107 bool IsNextBindingConsistent(const uint32_t) const;
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600108 // Various Get functions that can either be passed a binding#, which will
109 // be automatically translated into the appropriate index from the original
110 // pBindings array, or the index# can be passed in directly
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600111 VkDescriptorSetLayoutBinding const *GetDescriptorSetLayoutBindingPtrFromBinding(const uint32_t) const;
112 VkDescriptorSetLayoutBinding const *GetDescriptorSetLayoutBindingPtrFromIndex(const uint32_t) const;
113 uint32_t GetDescriptorCountFromBinding(const uint32_t) const;
114 uint32_t GetDescriptorCountFromIndex(const uint32_t) const;
115 VkDescriptorType GetTypeFromBinding(const uint32_t) const;
116 VkDescriptorType GetTypeFromIndex(const uint32_t) const;
117 VkDescriptorType GetTypeFromGlobalIndex(const uint32_t) const;
118 VkShaderStageFlags GetStageFlagsFromBinding(const uint32_t) const;
119 VkSampler const *GetImmutableSamplerPtrFromBinding(const uint32_t) const;
120 VkSampler const *GetImmutableSamplerPtrFromIndex(const uint32_t) const;
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600121 // For a particular binding, get the global index
Tobin Ehlis58c59582016-06-21 12:34:33 -0600122 // These calls should be guarded by a call to "HasBinding(binding)" to verify that the given binding exists
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600123 uint32_t GetGlobalStartIndexFromBinding(const uint32_t) const;
124 uint32_t GetGlobalEndIndexFromBinding(const uint32_t) const;
Tobin Ehlis1f946f82016-05-05 12:03:44 -0600125 // For a particular binding starting at offset and having update_count descriptors
126 // updated, verify that for any binding boundaries crossed, the update is consistent
127 bool VerifyUpdateConsistency(uint32_t, uint32_t, uint32_t, const char *, const VkDescriptorSet, std::string *) const;
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600128
129 private:
130 VkDescriptorSetLayout layout_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600131 std::unordered_map<uint32_t, uint32_t> binding_to_index_map_;
132 std::unordered_map<uint32_t, uint32_t> binding_to_global_start_index_map_;
133 std::unordered_map<uint32_t, uint32_t> binding_to_global_end_index_map_;
134 // VkDescriptorSetLayoutCreateFlags flags_;
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600135 uint32_t binding_count_; // # of bindings in this layout
Tobin Ehlis664e6012016-05-05 11:04:44 -0600136 std::vector<safe_VkDescriptorSetLayoutBinding> bindings_;
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600137 uint32_t descriptor_count_; // total # descriptors in this layout
138 uint32_t dynamic_descriptor_count_;
139};
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600140
141/*
142 * Descriptor classes
143 * Descriptor is an abstract base class from which 5 separate descriptor types are derived.
144 * This allows the WriteUpdate() and CopyUpdate() operations to be specialized per
145 * descriptor type, but all descriptors in a set can be accessed via the common Descriptor*.
146 */
147
148// Slightly broader than type, each c++ "class" will has a corresponding "DescriptorClass"
Mark Lobodzinski0978f5f2016-05-19 17:23:38 -0600149enum DescriptorClass { PlainSampler, ImageSampler, Image, TexelBuffer, GeneralBuffer };
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600150
151class Descriptor {
152 public:
153 virtual ~Descriptor(){};
Tobin Ehlis300888c2016-05-18 13:43:26 -0600154 virtual void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) = 0;
155 virtual void CopyUpdate(const Descriptor *) = 0;
Tobin Ehlis8020eea2016-08-17 11:10:41 -0600156 // Create binding between resources of this descriptor and given cb_node
157 virtual void BindCommandBuffer(const core_validation::layer_data *, GLOBAL_CB_NODE *) = 0;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600158 virtual DescriptorClass GetClass() const { return descriptor_class; };
159 // Special fast-path check for SamplerDescriptors that are immutable
160 virtual bool IsImmutableSampler() const { return false; };
161 // Check for dynamic descriptor type
162 virtual bool IsDynamic() const { return false; };
163 // Check for storage descriptor type
164 virtual bool IsStorage() const { return false; };
165 bool updated; // Has descriptor been updated?
166 DescriptorClass descriptor_class;
167};
168// Shared helper functions - These are useful because the shared sampler image descriptor type
169// performs common functions with both sampler and image descriptors so they can share their common functions
Tobin Ehlise2f80292016-06-02 10:08:53 -0600170bool ValidateSampler(const VkSampler, const core_validation::layer_data *);
Tobin Ehlis4e380592016-06-02 12:41:47 -0600171bool ValidateImageUpdate(VkImageView, VkImageLayout, VkDescriptorType, const core_validation::layer_data *, std::string *);
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600172
173class SamplerDescriptor : public Descriptor {
174 public:
Tobin Ehlis300888c2016-05-18 13:43:26 -0600175 SamplerDescriptor();
176 SamplerDescriptor(const VkSampler *);
177 void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
178 void CopyUpdate(const Descriptor *) override;
Tobin Ehlis8020eea2016-08-17 11:10:41 -0600179 void BindCommandBuffer(const core_validation::layer_data *, GLOBAL_CB_NODE *) override;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600180 virtual bool IsImmutableSampler() const override { return immutable_; };
Tobin Ehlis300888c2016-05-18 13:43:26 -0600181 VkSampler GetSampler() const { return sampler_; }
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600182
183 private:
184 // bool ValidateSampler(const VkSampler) const;
185 VkSampler sampler_;
186 bool immutable_;
Tobin Ehlis546326f2016-04-26 11:06:05 -0600187};
188
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600189class ImageSamplerDescriptor : public Descriptor {
190 public:
Tobin Ehlis300888c2016-05-18 13:43:26 -0600191 ImageSamplerDescriptor();
192 ImageSamplerDescriptor(const VkSampler *);
193 void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
194 void CopyUpdate(const Descriptor *) override;
Tobin Ehlis8020eea2016-08-17 11:10:41 -0600195 void BindCommandBuffer(const core_validation::layer_data *, GLOBAL_CB_NODE *) override;
Tobin Ehlisc9625152016-05-24 16:47:36 -0600196 virtual bool IsImmutableSampler() const override { return immutable_; };
Tobin Ehlis300888c2016-05-18 13:43:26 -0600197 VkSampler GetSampler() const { return sampler_; }
198 VkImageView GetImageView() const { return image_view_; }
199 VkImageLayout GetImageLayout() const { return image_layout_; }
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600200
201 private:
202 VkSampler sampler_;
203 bool immutable_;
204 VkImageView image_view_;
205 VkImageLayout image_layout_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600206};
207
208class ImageDescriptor : public Descriptor {
209 public:
Tobin Ehlis300888c2016-05-18 13:43:26 -0600210 ImageDescriptor(const VkDescriptorType);
211 void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
212 void CopyUpdate(const Descriptor *) override;
Tobin Ehlis8020eea2016-08-17 11:10:41 -0600213 void BindCommandBuffer(const core_validation::layer_data *, GLOBAL_CB_NODE *) override;
Norbert Nopper419a1092016-05-15 19:19:41 +0200214 virtual bool IsStorage() const override { return storage_; }
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600215 VkImageView GetImageView() const { return image_view_; }
216 VkImageLayout GetImageLayout() const { return image_layout_; }
217
218 private:
219 bool storage_;
220 VkImageView image_view_;
221 VkImageLayout image_layout_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600222};
223
224class TexelDescriptor : public Descriptor {
225 public:
Tobin Ehlis300888c2016-05-18 13:43:26 -0600226 TexelDescriptor(const VkDescriptorType);
227 void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
228 void CopyUpdate(const Descriptor *) override;
Tobin Ehlis8020eea2016-08-17 11:10:41 -0600229 void BindCommandBuffer(const core_validation::layer_data *, GLOBAL_CB_NODE *) override;
Tobin Ehlisf490f2e2016-05-17 06:43:48 -0600230 virtual bool IsStorage() const override { return storage_; }
231 VkBufferView GetBufferView() const { return buffer_view_; }
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600232
233 private:
234 VkBufferView buffer_view_;
235 bool storage_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600236};
237
238class BufferDescriptor : public Descriptor {
239 public:
Tobin Ehlis300888c2016-05-18 13:43:26 -0600240 BufferDescriptor(const VkDescriptorType);
241 void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
242 void CopyUpdate(const Descriptor *) override;
Tobin Ehlis8020eea2016-08-17 11:10:41 -0600243 void BindCommandBuffer(const core_validation::layer_data *, GLOBAL_CB_NODE *) override;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600244 virtual bool IsDynamic() const override { return dynamic_; }
245 virtual bool IsStorage() const override { return storage_; }
246 VkBuffer GetBuffer() const { return buffer_; }
247 VkDeviceSize GetOffset() const { return offset_; }
248 VkDeviceSize GetRange() const { return range_; }
249
250 private:
251 bool storage_;
252 bool dynamic_;
253 VkBuffer buffer_;
254 VkDeviceSize offset_;
255 VkDeviceSize range_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600256};
Tobin Ehlis68d0adf2016-06-01 11:33:50 -0600257// Structs to contain common elements that need to be shared between Validate* and Perform* calls below
258struct AllocateDescriptorSetsData {
259 uint32_t required_descriptors_by_type[VK_DESCRIPTOR_TYPE_RANGE_SIZE];
260 std::vector<cvdescriptorset::DescriptorSetLayout const *> layout_nodes;
261 AllocateDescriptorSetsData(uint32_t);
262};
Tobin Ehlisee471462016-05-26 11:21:59 -0600263// Helper functions for descriptor set functions that cross multiple sets
264// "Validate" will make sure an update is ok without actually performing it
Tobin Ehlis6a72dc72016-06-01 16:41:17 -0600265bool ValidateUpdateDescriptorSets(const debug_report_data *, const core_validation::layer_data *, uint32_t,
Tobin Ehlis56a30942016-05-19 08:00:00 -0600266 const VkWriteDescriptorSet *, uint32_t, const VkCopyDescriptorSet *);
Tobin Ehlisee471462016-05-26 11:21:59 -0600267// "Perform" does the update with the assumption that ValidateUpdateDescriptorSets() has passed for the given update
Tobin Ehlis6a72dc72016-06-01 16:41:17 -0600268void PerformUpdateDescriptorSets(const core_validation::layer_data *, uint32_t, const VkWriteDescriptorSet *, uint32_t,
269 const VkCopyDescriptorSet *);
Tobin Ehlisee471462016-05-26 11:21:59 -0600270// Validate that Allocation state is ok
271bool ValidateAllocateDescriptorSets(const debug_report_data *, const VkDescriptorSetAllocateInfo *,
Tobin Ehlis815e8132016-06-02 13:02:17 -0600272 const core_validation::layer_data *, AllocateDescriptorSetsData *);
Tobin Ehlisee471462016-05-26 11:21:59 -0600273// Update state based on allocating new descriptorsets
Tobin Ehlis997b2582016-06-02 08:43:37 -0600274void PerformAllocateDescriptorSets(const VkDescriptorSetAllocateInfo *, const VkDescriptorSet *, const AllocateDescriptorSetsData *,
275 std::unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> *,
276 std::unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> *,
Tobin Ehlis4e380592016-06-02 12:41:47 -0600277 const core_validation::layer_data *);
Tobin Ehlisee471462016-05-26 11:21:59 -0600278
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600279/*
280 * DescriptorSet class
281 *
282 * Overview - This class encapsulates the Vulkan VkDescriptorSet data (set).
283 * A set has an underlying layout which defines the bindings in the set and the
284 * types and numbers of descriptors in each descriptor slot. Most of the layout
285 * interfaces are exposed through identically-named functions in the set class.
286 * Please refer to the DescriptorSetLayout comment above for a description of
287 * index, binding, and global index.
288 *
289 * At construction a vector of Descriptor* is created with types corresponding to the
290 * layout. The primary operation performed on the descriptors is to update them
291 * via write or copy updates, and validate that the update contents are correct.
292 * In order to validate update contents, the DescriptorSet stores a bunch of ptrs
293 * to data maps where various Vulkan objects can be looked up. The management of
294 * those maps is performed externally. The set class relies on their contents to
295 * be correct at the time of update.
296 */
Tobin Ehlis05be5df2016-05-05 08:25:02 -0600297class DescriptorSet : public BASE_NODE {
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600298 public:
Tobin Ehlis4e380592016-06-02 12:41:47 -0600299 DescriptorSet(const VkDescriptorSet, const DescriptorSetLayout *, const core_validation::layer_data *);
Tobin Ehlis9906d9d2016-05-17 14:23:46 -0600300 ~DescriptorSet();
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600301 // A number of common Get* functions that return data based on layout from which this set was created
302 uint32_t GetTotalDescriptorCount() const { return p_layout_ ? p_layout_->GetTotalDescriptorCount() : 0; };
303 uint32_t GetDynamicDescriptorCount() const { return p_layout_ ? p_layout_->GetDynamicDescriptorCount() : 0; };
304 uint32_t GetBindingCount() const { return p_layout_ ? p_layout_->GetBindingCount() : 0; };
305 VkDescriptorType GetTypeFromIndex(const uint32_t index) const {
306 return p_layout_ ? p_layout_->GetTypeFromIndex(index) : VK_DESCRIPTOR_TYPE_MAX_ENUM;
307 };
308 VkDescriptorType GetTypeFromGlobalIndex(const uint32_t index) const {
309 return p_layout_ ? p_layout_->GetTypeFromGlobalIndex(index) : VK_DESCRIPTOR_TYPE_MAX_ENUM;
310 };
311 VkDescriptorType GetTypeFromBinding(const uint32_t binding) const {
312 return p_layout_ ? p_layout_->GetTypeFromBinding(binding) : VK_DESCRIPTOR_TYPE_MAX_ENUM;
313 };
314 uint32_t GetDescriptorCountFromIndex(const uint32_t index) const {
315 return p_layout_ ? p_layout_->GetDescriptorCountFromIndex(index) : 0;
316 };
317 uint32_t GetDescriptorCountFromBinding(const uint32_t binding) const {
318 return p_layout_ ? p_layout_->GetDescriptorCountFromBinding(binding) : 0;
319 };
320 // Return true if given binding is present in this set
321 bool HasBinding(const uint32_t binding) const { return p_layout_->HasBinding(binding); };
322 // Is this set compatible with the given layout?
323 bool IsCompatible(const DescriptorSetLayout *, std::string *) const;
324 // For given bindings validate state at time of draw is correct, returning false on error and writing error details into string*
Tobin Ehliscebc4c02016-08-22 10:10:43 -0600325 bool ValidateDrawState(const std::map<uint32_t, descriptor_req> &, const std::vector<uint32_t> &, std::string *) const;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600326 // For given set of bindings, add any buffers and images that will be updated to their respective unordered_sets & return number
327 // of objects inserted
Tobin Ehliscebc4c02016-08-22 10:10:43 -0600328 uint32_t GetStorageUpdates(const std::map<uint32_t, descriptor_req> &, std::unordered_set<VkBuffer> *,
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600329 std::unordered_set<VkImageView> *) const;
Tobin Ehlis300888c2016-05-18 13:43:26 -0600330
331 // Descriptor Update functions. These functions validate state and perform update separately
332 // Validate contents of a WriteUpdate
333 bool ValidateWriteUpdate(const debug_report_data *, const VkWriteDescriptorSet *, std::string *);
334 // Perform a WriteUpdate whose contents were just validated using ValidateWriteUpdate
335 void PerformWriteUpdate(const VkWriteDescriptorSet *);
336 // Validate contents of a CopyUpdate
337 bool ValidateCopyUpdate(const debug_report_data *, const VkCopyDescriptorSet *, const DescriptorSet *, std::string *);
338 // Perform a CopyUpdate whose contents were just validated using ValidateCopyUpdate
339 void PerformCopyUpdate(const VkCopyDescriptorSet *, const DescriptorSet *);
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600340
Tobin Ehlis1f946f82016-05-05 12:03:44 -0600341 const DescriptorSetLayout *GetLayout() const { return p_layout_; };
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600342 VkDescriptorSet GetSet() const { return set_; };
343 // Return unordered_set of all command buffers that this set is bound to
Tobin Ehlis2556f5b2016-06-24 17:22:16 -0600344 std::unordered_set<GLOBAL_CB_NODE *> GetBoundCmdBuffers() const { return cb_bindings; }
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600345 // Bind given cmd_buffer to this descriptor set
Tobin Ehlisf9519102016-08-17 09:49:13 -0600346 void BindCommandBuffer(GLOBAL_CB_NODE *, const std::unordered_set<uint32_t> &);
Tobin Ehlis2556f5b2016-06-24 17:22:16 -0600347 // If given cmd_buffer is in the cb_bindings set, remove it
348 void RemoveBoundCommandBuffer(GLOBAL_CB_NODE *cb_node) { cb_bindings.erase(cb_node); }
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600349 VkSampler const *GetImmutableSamplerPtrFromBinding(const uint32_t index) const {
350 return p_layout_->GetImmutableSamplerPtrFromBinding(index);
351 };
352 // For a particular binding, get the global index
353 uint32_t GetGlobalStartIndexFromBinding(const uint32_t binding) const {
354 return p_layout_->GetGlobalStartIndexFromBinding(binding);
355 };
356 uint32_t GetGlobalEndIndexFromBinding(const uint32_t binding) const {
357 return p_layout_->GetGlobalEndIndexFromBinding(binding);
358 };
359 // Return true if any part of set has ever been updated
360 bool IsUpdated() const { return some_update_; };
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600361
362 private:
Tobin Ehlis300888c2016-05-18 13:43:26 -0600363 bool VerifyWriteUpdateContents(const VkWriteDescriptorSet *, const uint32_t, std::string *) const;
Tobin Ehliscbcf2342016-05-24 13:07:12 -0600364 bool VerifyCopyUpdateContents(const VkCopyDescriptorSet *, const DescriptorSet *, VkDescriptorType, uint32_t,
365 std::string *) const;
Tobin Ehlis3d38f082016-07-01 17:36:48 -0600366 bool ValidateBufferUsage(BUFFER_NODE const *, VkDescriptorType, std::string *) const;
367 bool ValidateBufferUpdate(VkDescriptorBufferInfo const *, VkDescriptorType, std::string *) const;
Tobin Ehlis9906d9d2016-05-17 14:23:46 -0600368 // Private helper to set all bound cmd buffers to INVALID state
369 void InvalidateBoundCmdBuffers();
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600370 bool some_update_; // has any part of the set ever been updated?
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600371 VkDescriptorSet set_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600372 const DescriptorSetLayout *p_layout_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600373 std::vector<std::unique_ptr<Descriptor>> descriptors_;
Tobin Ehlis3d15c4a2016-06-02 13:04:47 -0600374 // Ptr to device data used for various data look-ups
Tobin Ehlis94bc5d22016-06-02 07:46:52 -0600375 const core_validation::layer_data *device_data_;
Tobin Ehlis0a43bde2016-05-03 08:31:08 -0600376};
Tobin Ehlis2d9deec2016-04-21 14:19:26 -0600377}
Chris Forbes6f6844a2016-04-27 14:00:44 +1200378#endif // CORE_VALIDATION_DESCRIPTOR_SETS_H_