Courtney Goeltzenleuchter | d8e229c | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 1 | #include <vulkan.h> |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2 | #include "vk_debug_report_lunarg.h" |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 3 | #include "gtest-1.7.0/include/gtest/gtest.h" |
Courtney Goeltzenleuchter | d8e229c | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 4 | #include "vkrenderframework.h" |
Tobin Ehlis | a0cb02e | 2015-07-03 10:15:26 -0600 | [diff] [blame] | 5 | #include "vk_layer_config.h" |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 6 | |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 7 | #define GLM_FORCE_RADIANS |
| 8 | #include "glm/glm.hpp" |
| 9 | #include <glm/gtc/matrix_transform.hpp> |
| 10 | |
Tobin Ehlis | 0788f52 | 2015-05-26 16:11:58 -0600 | [diff] [blame] | 11 | #define MEM_TRACKER_TESTS 1 |
| 12 | #define OBJ_TRACKER_TESTS 1 |
| 13 | #define DRAW_STATE_TESTS 1 |
| 14 | #define THREADING_TESTS 1 |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 15 | #define SHADER_CHECKER_TESTS 1 |
Tobin Ehlis | 0788f52 | 2015-05-26 16:11:58 -0600 | [diff] [blame] | 16 | |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 17 | //-------------------------------------------------------------------------------------- |
| 18 | // Mesh and VertexFormat Data |
| 19 | //-------------------------------------------------------------------------------------- |
| 20 | struct Vertex |
| 21 | { |
| 22 | float posX, posY, posZ, posW; // Position data |
| 23 | float r, g, b, a; // Color |
| 24 | }; |
| 25 | |
| 26 | #define XYZ1(_x_, _y_, _z_) (_x_), (_y_), (_z_), 1.f |
| 27 | |
| 28 | typedef enum _BsoFailSelect { |
| 29 | BsoFailNone = 0x00000000, |
| 30 | BsoFailRaster = 0x00000001, |
| 31 | BsoFailViewport = 0x00000002, |
| 32 | BsoFailColorBlend = 0x00000004, |
| 33 | BsoFailDepthStencil = 0x00000008, |
| 34 | } BsoFailSelect; |
| 35 | |
| 36 | struct vktriangle_vs_uniform { |
| 37 | // Must start with MVP |
| 38 | float mvp[4][4]; |
| 39 | float position[3][4]; |
| 40 | float color[3][4]; |
| 41 | }; |
| 42 | |
Mark Lobodzinski | 75a97e6 | 2015-06-02 09:41:30 -0500 | [diff] [blame] | 43 | static const char bindStateVertShaderText[] = |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 44 | "#version 130\n" |
| 45 | "vec2 vertices[3];\n" |
| 46 | "void main() {\n" |
| 47 | " vertices[0] = vec2(-1.0, -1.0);\n" |
| 48 | " vertices[1] = vec2( 1.0, -1.0);\n" |
| 49 | " vertices[2] = vec2( 0.0, 1.0);\n" |
| 50 | " gl_Position = vec4(vertices[gl_VertexID % 3], 0.0, 1.0);\n" |
| 51 | "}\n"; |
| 52 | |
Mark Lobodzinski | 75a97e6 | 2015-06-02 09:41:30 -0500 | [diff] [blame] | 53 | static const char bindStateFragShaderText[] = |
Cody Northrop | 8a3bb13 | 2015-06-16 17:32:04 -0600 | [diff] [blame] | 54 | "#version 140\n" |
| 55 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 56 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 57 | "\n" |
| 58 | "layout(location = 0) out vec4 uFragColor;\n" |
| 59 | "void main(){\n" |
| 60 | " uFragColor = vec4(0,1,0,1);\n" |
| 61 | "}\n"; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 62 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 63 | static void myDbgFunc( |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 64 | VkFlags msgFlags, |
| 65 | VkDbgObjectType objType, |
| 66 | uint64_t srcObject, |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 67 | size_t location, |
| 68 | int32_t msgCode, |
| 69 | const char* pLayerPrefix, |
| 70 | const char* pMsg, |
| 71 | void* pUserData); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 72 | |
| 73 | class ErrorMonitor { |
| 74 | public: |
Tony Barbour | 15524c3 | 2015-04-29 17:34:29 -0600 | [diff] [blame] | 75 | ErrorMonitor() |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 76 | { |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 77 | test_platform_thread_create_mutex(&m_mutex); |
| 78 | test_platform_thread_lock_mutex(&m_mutex); |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 79 | m_msgFlags = VK_DBG_REPORT_INFO_BIT; |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 80 | m_bailout = NULL; |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 81 | test_platform_thread_unlock_mutex(&m_mutex); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 82 | } |
| 83 | void ClearState() |
| 84 | { |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 85 | test_platform_thread_lock_mutex(&m_mutex); |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 86 | m_msgFlags = VK_DBG_REPORT_INFO_BIT; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 87 | m_msgString.clear(); |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 88 | test_platform_thread_unlock_mutex(&m_mutex); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 89 | } |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 90 | VkFlags GetState(std::string *msgString) |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 91 | { |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 92 | test_platform_thread_lock_mutex(&m_mutex); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 93 | *msgString = m_msgString; |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 94 | test_platform_thread_unlock_mutex(&m_mutex); |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 95 | return m_msgFlags; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 96 | } |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 97 | void SetState(VkFlags msgFlags, const char *msgString) |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 98 | { |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 99 | test_platform_thread_lock_mutex(&m_mutex); |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 100 | if (m_bailout != NULL) { |
| 101 | *m_bailout = true; |
| 102 | } |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 103 | m_msgFlags = msgFlags; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 104 | m_msgString.reserve(strlen(msgString)); |
| 105 | m_msgString = msgString; |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 106 | test_platform_thread_unlock_mutex(&m_mutex); |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 107 | } |
| 108 | void SetBailout(bool *bailout) |
| 109 | { |
| 110 | m_bailout = bailout; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 111 | } |
| 112 | |
| 113 | private: |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 114 | VkFlags m_msgFlags; |
| 115 | std::string m_msgString; |
| 116 | test_platform_thread_mutex m_mutex; |
| 117 | bool* m_bailout; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 118 | }; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 119 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 120 | static void myDbgFunc( |
| 121 | VkFlags msgFlags, |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 122 | VkDbgObjectType objType, |
| 123 | uint64_t srcObject, |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 124 | size_t location, |
| 125 | int32_t msgCode, |
| 126 | const char* pLayerPrefix, |
| 127 | const char* pMsg, |
| 128 | void* pUserData) |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 129 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 130 | if (msgFlags & (VK_DBG_REPORT_WARN_BIT | VK_DBG_REPORT_ERROR_BIT)) { |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 131 | ErrorMonitor *errMonitor = (ErrorMonitor *)pUserData; |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 132 | errMonitor->SetState(msgFlags, pMsg); |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 133 | } |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 134 | } |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 135 | |
Tony Barbour | 6918cd5 | 2015-04-09 12:58:51 -0600 | [diff] [blame] | 136 | class VkLayerTest : public VkRenderFramework |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 137 | { |
| 138 | public: |
Courtney Goeltzenleuchter | fb4efc6 | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 139 | VkResult BeginCommandBuffer(VkCommandBufferObj &cmdBuffer); |
| 140 | VkResult EndCommandBuffer(VkCommandBufferObj &cmdBuffer); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 141 | void VKTriangleTest(const char *vertShaderText, const char *fragShaderText, BsoFailSelect failMask); |
| 142 | void GenericDrawPreparation(VkCommandBufferObj *cmdBuffer, VkPipelineObj &pipelineobj, VkDescriptorSetObj &descriptorSet, BsoFailSelect failMask); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 143 | void GenericDrawPreparation(VkPipelineObj &pipelineobj, VkDescriptorSetObj &descriptorSet, BsoFailSelect failMask) |
| 144 | { GenericDrawPreparation(m_cmdBuffer, pipelineobj, descriptorSet, failMask); } |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 145 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 146 | /* Convenience functions that use built-in command buffer */ |
| 147 | VkResult BeginCommandBuffer() { return BeginCommandBuffer(*m_cmdBuffer); } |
| 148 | VkResult EndCommandBuffer() { return EndCommandBuffer(*m_cmdBuffer); } |
| 149 | void Draw(uint32_t firstVertex, uint32_t vertexCount, uint32_t firstInstance, uint32_t instanceCount) |
| 150 | { m_cmdBuffer->Draw(firstVertex, vertexCount, firstInstance, instanceCount); } |
| 151 | void DrawIndexed(uint32_t firstVertex, uint32_t vertexCount, int32_t vertexOffset, uint32_t firstInstance, uint32_t instanceCount) |
| 152 | { m_cmdBuffer->DrawIndexed(firstVertex, vertexCount, vertexOffset,firstInstance, instanceCount); } |
| 153 | void QueueCommandBuffer() { m_cmdBuffer->QueueCommandBuffer(); } |
| 154 | void QueueCommandBuffer(const VkFence& fence) { m_cmdBuffer->QueueCommandBuffer(fence); } |
| 155 | void BindVertexBuffer(VkConstantBufferObj *vertexBuffer, VkDeviceSize offset, uint32_t binding) |
| 156 | { m_cmdBuffer->BindVertexBuffer(vertexBuffer, offset, binding); } |
| 157 | void BindIndexBuffer(VkIndexBufferObj *indexBuffer, VkDeviceSize offset) |
| 158 | { m_cmdBuffer->BindIndexBuffer(indexBuffer, offset); } |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 159 | protected: |
Tony Barbour | 6918cd5 | 2015-04-09 12:58:51 -0600 | [diff] [blame] | 160 | ErrorMonitor *m_errorMonitor; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 161 | |
| 162 | virtual void SetUp() { |
Courtney Goeltzenleuchter | cd69eee | 2015-07-06 09:10:47 -0600 | [diff] [blame] | 163 | std::vector<const char *> instance_layer_names; |
| 164 | std::vector<const char *> device_layer_names; |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 165 | std::vector<const char *> instance_extension_names; |
| 166 | std::vector<const char *> device_extension_names; |
Tony Barbour | 3fdff9e | 2015-04-23 12:55:36 -0600 | [diff] [blame] | 167 | |
Courtney Goeltzenleuchter | 05159a9 | 2015-07-30 11:32:46 -0600 | [diff] [blame] | 168 | instance_extension_names.push_back(VK_DEBUG_REPORT_EXTENSION_NAME); |
Courtney Goeltzenleuchter | c2b06fe | 2015-06-16 15:59:11 -0600 | [diff] [blame] | 169 | /* |
| 170 | * Since CreateDbgMsgCallback is an instance level extension call |
| 171 | * any extension / layer that utilizes that feature also needs |
| 172 | * to be enabled at create instance time. |
| 173 | */ |
Mike Stroyan | 0daf78a | 2015-06-17 16:32:06 -0600 | [diff] [blame] | 174 | // Use Threading layer first to protect others from ThreadCmdBufferCollision test |
Courtney Goeltzenleuchter | cd69eee | 2015-07-06 09:10:47 -0600 | [diff] [blame] | 175 | instance_layer_names.push_back("Threading"); |
| 176 | instance_layer_names.push_back("ObjectTracker"); |
| 177 | instance_layer_names.push_back("MemTracker"); |
| 178 | instance_layer_names.push_back("DrawState"); |
| 179 | instance_layer_names.push_back("ShaderChecker"); |
Courtney Goeltzenleuchter | d971b61 | 2015-06-17 20:51:59 -0600 | [diff] [blame] | 180 | |
Courtney Goeltzenleuchter | cd69eee | 2015-07-06 09:10:47 -0600 | [diff] [blame] | 181 | device_layer_names.push_back("Threading"); |
| 182 | device_layer_names.push_back("ObjectTracker"); |
| 183 | device_layer_names.push_back("MemTracker"); |
| 184 | device_layer_names.push_back("DrawState"); |
| 185 | device_layer_names.push_back("ShaderChecker"); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 186 | |
Courtney Goeltzenleuchter | d8e229c | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 187 | this->app_info.sType = VK_STRUCTURE_TYPE_APPLICATION_INFO; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 188 | this->app_info.pNext = NULL; |
| 189 | this->app_info.pAppName = "layer_tests"; |
| 190 | this->app_info.appVersion = 1; |
| 191 | this->app_info.pEngineName = "unittest"; |
| 192 | this->app_info.engineVersion = 1; |
Courtney Goeltzenleuchter | d8e229c | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 193 | this->app_info.apiVersion = VK_API_VERSION; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 194 | |
Tony Barbour | 15524c3 | 2015-04-29 17:34:29 -0600 | [diff] [blame] | 195 | m_errorMonitor = new ErrorMonitor; |
Courtney Goeltzenleuchter | cd69eee | 2015-07-06 09:10:47 -0600 | [diff] [blame] | 196 | InitFramework(instance_layer_names, device_layer_names, |
| 197 | instance_extension_names, device_extension_names, |
| 198 | myDbgFunc, m_errorMonitor); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 199 | } |
| 200 | |
| 201 | virtual void TearDown() { |
| 202 | // Clean up resources before we reset |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 203 | ShutdownFramework(); |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 204 | delete m_errorMonitor; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 205 | } |
| 206 | }; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 207 | |
Courtney Goeltzenleuchter | fb4efc6 | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 208 | VkResult VkLayerTest::BeginCommandBuffer(VkCommandBufferObj &cmdBuffer) |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 209 | { |
Courtney Goeltzenleuchter | fb4efc6 | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 210 | VkResult result; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 211 | |
| 212 | result = cmdBuffer.BeginCommandBuffer(); |
| 213 | |
| 214 | /* |
| 215 | * For render test all drawing happens in a single render pass |
| 216 | * on a single command buffer. |
| 217 | */ |
Chris Forbes | 76a5eeb | 2015-06-16 14:05:59 +1200 | [diff] [blame] | 218 | if (VK_SUCCESS == result && renderPass()) { |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 219 | cmdBuffer.BeginRenderPass(renderPassBeginInfo()); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 220 | } |
| 221 | |
| 222 | return result; |
| 223 | } |
| 224 | |
Courtney Goeltzenleuchter | fb4efc6 | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 225 | VkResult VkLayerTest::EndCommandBuffer(VkCommandBufferObj &cmdBuffer) |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 226 | { |
Courtney Goeltzenleuchter | fb4efc6 | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 227 | VkResult result; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 228 | |
Chris Forbes | 76a5eeb | 2015-06-16 14:05:59 +1200 | [diff] [blame] | 229 | if (renderPass()) { |
Chia-I Wu | 0b50a1c | 2015-06-26 15:34:39 +0800 | [diff] [blame] | 230 | cmdBuffer.EndRenderPass(); |
Chris Forbes | 76a5eeb | 2015-06-16 14:05:59 +1200 | [diff] [blame] | 231 | } |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 232 | |
| 233 | result = cmdBuffer.EndCommandBuffer(); |
| 234 | |
| 235 | return result; |
| 236 | } |
| 237 | |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 238 | void VkLayerTest::VKTriangleTest(const char *vertShaderText, const char *fragShaderText, BsoFailSelect failMask) |
| 239 | { |
| 240 | // Create identity matrix |
| 241 | int i; |
| 242 | struct vktriangle_vs_uniform data; |
| 243 | |
| 244 | glm::mat4 Projection = glm::mat4(1.0f); |
| 245 | glm::mat4 View = glm::mat4(1.0f); |
| 246 | glm::mat4 Model = glm::mat4(1.0f); |
| 247 | glm::mat4 MVP = Projection * View * Model; |
| 248 | const int matrixSize = sizeof(MVP); |
| 249 | const int bufSize = sizeof(vktriangle_vs_uniform) / sizeof(float); |
| 250 | |
| 251 | memcpy(&data.mvp, &MVP[0][0], matrixSize); |
| 252 | |
| 253 | static const Vertex tri_data[] = |
| 254 | { |
| 255 | { XYZ1( -1, -1, 0 ), XYZ1( 1.f, 0.f, 0.f ) }, |
| 256 | { XYZ1( 1, -1, 0 ), XYZ1( 0.f, 1.f, 0.f ) }, |
| 257 | { XYZ1( 0, 1, 0 ), XYZ1( 0.f, 0.f, 1.f ) }, |
| 258 | }; |
| 259 | |
| 260 | for (i=0; i<3; i++) { |
| 261 | data.position[i][0] = tri_data[i].posX; |
| 262 | data.position[i][1] = tri_data[i].posY; |
| 263 | data.position[i][2] = tri_data[i].posZ; |
| 264 | data.position[i][3] = tri_data[i].posW; |
| 265 | data.color[i][0] = tri_data[i].r; |
| 266 | data.color[i][1] = tri_data[i].g; |
| 267 | data.color[i][2] = tri_data[i].b; |
| 268 | data.color[i][3] = tri_data[i].a; |
| 269 | } |
| 270 | |
| 271 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 272 | ASSERT_NO_FATAL_FAILURE(InitViewport()); |
| 273 | |
| 274 | VkConstantBufferObj constantBuffer(m_device, bufSize*2, sizeof(float), (const void*) &data); |
| 275 | |
| 276 | VkShaderObj vs(m_device,vertShaderText,VK_SHADER_STAGE_VERTEX, this); |
| 277 | VkShaderObj ps(m_device,fragShaderText, VK_SHADER_STAGE_FRAGMENT, this); |
| 278 | |
| 279 | VkPipelineObj pipelineobj(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 280 | pipelineobj.AddColorAttachment(); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 281 | pipelineobj.AddShader(&vs); |
| 282 | pipelineobj.AddShader(&ps); |
| 283 | |
| 284 | VkDescriptorSetObj descriptorSet(m_device); |
| 285 | descriptorSet.AppendBuffer(VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, constantBuffer); |
| 286 | |
| 287 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 288 | ASSERT_VK_SUCCESS(BeginCommandBuffer()); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 289 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 290 | GenericDrawPreparation(pipelineobj, descriptorSet, failMask); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 291 | |
| 292 | // render triangle |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 293 | Draw(0, 3, 0, 1); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 294 | |
| 295 | // finalize recording of the command buffer |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 296 | EndCommandBuffer(); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 297 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 298 | QueueCommandBuffer(); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 299 | } |
| 300 | |
| 301 | void VkLayerTest::GenericDrawPreparation(VkCommandBufferObj *cmdBuffer, VkPipelineObj &pipelineobj, VkDescriptorSetObj &descriptorSet, BsoFailSelect failMask) |
| 302 | { |
| 303 | if (m_depthStencil->Initialized()) { |
| 304 | cmdBuffer->ClearAllBuffers(m_clear_color, m_depth_clear_color, m_stencil_clear_color, m_depthStencil); |
| 305 | } else { |
| 306 | cmdBuffer->ClearAllBuffers(m_clear_color, m_depth_clear_color, m_stencil_clear_color, NULL); |
| 307 | } |
| 308 | |
| 309 | cmdBuffer->PrepareAttachments(); |
| 310 | if ((failMask & BsoFailRaster) != BsoFailRaster) { |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 311 | cmdBuffer->BindDynamicRasterState(m_stateRaster); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 312 | } |
| 313 | if ((failMask & BsoFailViewport) != BsoFailViewport) { |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 314 | cmdBuffer->BindDynamicViewportState(m_stateViewport); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 315 | } |
| 316 | if ((failMask & BsoFailColorBlend) != BsoFailColorBlend) { |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 317 | cmdBuffer->BindDynamicColorBlendState(m_colorBlend); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 318 | } |
| 319 | if ((failMask & BsoFailDepthStencil) != BsoFailDepthStencil) { |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 320 | cmdBuffer->BindDynamicDepthStencilState(m_stateDepthStencil); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 321 | } |
Tobin Ehlis | 4bf96d1 | 2015-06-25 11:58:41 -0600 | [diff] [blame] | 322 | // Make sure depthWriteEnable is set so that DepthStencil fail test will work correctly |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 323 | VkStencilOpState stencil = {}; |
| 324 | stencil.stencilFailOp = VK_STENCIL_OP_KEEP; |
| 325 | stencil.stencilPassOp = VK_STENCIL_OP_KEEP; |
| 326 | stencil.stencilDepthFailOp = VK_STENCIL_OP_KEEP; |
| 327 | stencil.stencilCompareOp = VK_COMPARE_OP_NEVER; |
| 328 | |
| 329 | VkPipelineDepthStencilStateCreateInfo ds_ci = {}; |
| 330 | ds_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO; |
| 331 | ds_ci.pNext = NULL; |
| 332 | ds_ci.depthTestEnable = VK_FALSE; |
| 333 | ds_ci.depthWriteEnable = VK_TRUE; |
| 334 | ds_ci.depthCompareOp = VK_COMPARE_OP_NEVER; |
| 335 | ds_ci.depthBoundsEnable = VK_FALSE; |
| 336 | ds_ci.stencilTestEnable = VK_FALSE; |
| 337 | ds_ci.front = stencil; |
| 338 | ds_ci.back = stencil; |
| 339 | |
Tobin Ehlis | 4bf96d1 | 2015-06-25 11:58:41 -0600 | [diff] [blame] | 340 | pipelineobj.SetDepthStencil(&ds_ci); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 341 | descriptorSet.CreateVKDescriptorSet(cmdBuffer); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 342 | pipelineobj.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 343 | cmdBuffer->BindPipeline(pipelineobj); |
| 344 | cmdBuffer->BindDescriptorSet(descriptorSet); |
| 345 | } |
| 346 | |
| 347 | // ******************************************************************************************************************** |
| 348 | // ******************************************************************************************************************** |
| 349 | // ******************************************************************************************************************** |
| 350 | // ******************************************************************************************************************** |
Tobin Ehlis | 0788f52 | 2015-05-26 16:11:58 -0600 | [diff] [blame] | 351 | #if MEM_TRACKER_TESTS |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 352 | TEST_F(VkLayerTest, CallResetCmdBufferBeforeCompletion) |
| 353 | { |
| 354 | vk_testing::Fence testFence; |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 355 | VkFlags msgFlags; |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 356 | std::string msgString; |
| 357 | |
| 358 | VkFenceCreateInfo fenceInfo = {}; |
| 359 | fenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO; |
| 360 | fenceInfo.pNext = NULL; |
| 361 | fenceInfo.flags = 0; |
| 362 | |
| 363 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Tony Barbour | c1eb1a5 | 2015-07-20 13:00:10 -0600 | [diff] [blame] | 364 | |
| 365 | VkMemoryPropertyFlags reqs = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT; |
| 366 | vk_testing::Buffer buffer; |
| 367 | buffer.init_as_dst(*m_device, (VkDeviceSize)20, reqs); |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 368 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 369 | BeginCommandBuffer(); |
| 370 | m_cmdBuffer->FillBuffer(buffer.handle(), 0, 4, 0x11111111); |
| 371 | EndCommandBuffer(); |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 372 | |
| 373 | testFence.init(*m_device, fenceInfo); |
| 374 | |
| 375 | // Bypass framework since it does the waits automatically |
| 376 | VkResult err = VK_SUCCESS; |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 377 | err = vkQueueSubmit( m_device->m_queue, 1, &m_cmdBuffer->handle(), testFence.handle()); |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 378 | ASSERT_VK_SUCCESS( err ); |
| 379 | |
| 380 | m_errorMonitor->ClearState(); |
| 381 | // Introduce failure by calling begin again before checking fence |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 382 | vkResetCommandBuffer(m_cmdBuffer->handle(), 0); |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 383 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 384 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 385 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an err after calling ResetCommandBuffer on an active Command Buffer"; |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 386 | if (!strstr(msgString.c_str(),"Resetting CB")) { |
| 387 | FAIL() << "Error received was not 'Resetting CB (0xaddress) before it has completed. You must check CB flag before'"; |
| 388 | } |
| 389 | } |
| 390 | |
| 391 | TEST_F(VkLayerTest, CallBeginCmdBufferBeforeCompletion) |
| 392 | { |
| 393 | vk_testing::Fence testFence; |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 394 | VkFlags msgFlags; |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 395 | std::string msgString; |
| 396 | |
| 397 | VkFenceCreateInfo fenceInfo = {}; |
| 398 | fenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO; |
| 399 | fenceInfo.pNext = NULL; |
| 400 | fenceInfo.flags = 0; |
| 401 | |
| 402 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 403 | ASSERT_NO_FATAL_FAILURE(InitViewport()); |
| 404 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 405 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 406 | BeginCommandBuffer(); |
| 407 | m_cmdBuffer->ClearAllBuffers(m_clear_color, m_depth_clear_color, m_stencil_clear_color, NULL); |
| 408 | EndCommandBuffer(); |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 409 | |
| 410 | testFence.init(*m_device, fenceInfo); |
| 411 | |
| 412 | // Bypass framework since it does the waits automatically |
| 413 | VkResult err = VK_SUCCESS; |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 414 | err = vkQueueSubmit( m_device->m_queue, 1, &m_cmdBuffer->handle(), testFence.handle()); |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 415 | ASSERT_VK_SUCCESS( err ); |
| 416 | |
| 417 | m_errorMonitor->ClearState(); |
| 418 | // Introduce failure by calling begin again before checking fence |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 419 | BeginCommandBuffer(); |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 420 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 421 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 422 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an err after calling BeginCommandBuffer on an active Command Buffer"; |
Mark Lobodzinski | ccb2b04 | 2015-05-19 10:28:29 -0500 | [diff] [blame] | 423 | if (!strstr(msgString.c_str(),"Calling vkBeginCommandBuffer() on active CB")) { |
| 424 | FAIL() << "Error received was not 'Calling vkBeginCommandBuffer() on an active CB (0xaddress) before it has completed'"; |
| 425 | } |
| 426 | } |
| 427 | |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 428 | TEST_F(VkLayerTest, MapMemWithoutHostVisibleBit) |
| 429 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 430 | VkFlags msgFlags; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 431 | std::string msgString; |
| 432 | VkResult err; |
| 433 | |
| 434 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 435 | m_errorMonitor->ClearState(); |
| 436 | |
| 437 | // Create an image, allocate memory, free it, and then try to bind it |
| 438 | VkImage image; |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 439 | VkDeviceMemory mem; |
| 440 | VkMemoryRequirements mem_reqs; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 441 | |
| 442 | const VkFormat tex_format = VK_FORMAT_B8G8R8A8_UNORM; |
| 443 | const int32_t tex_width = 32; |
| 444 | const int32_t tex_height = 32; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 445 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 446 | VkImageCreateInfo image_create_info = {}; |
| 447 | image_create_info.sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO; |
| 448 | image_create_info.pNext = NULL; |
| 449 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 450 | image_create_info.format = tex_format; |
| 451 | image_create_info.extent.width = tex_width; |
| 452 | image_create_info.extent.height = tex_height; |
| 453 | image_create_info.extent.depth = 1; |
| 454 | image_create_info.mipLevels = 1; |
| 455 | image_create_info.arraySize = 1; |
| 456 | image_create_info.samples = 1; |
| 457 | image_create_info.tiling = VK_IMAGE_TILING_LINEAR; |
| 458 | image_create_info.usage = VK_IMAGE_USAGE_SAMPLED_BIT; |
| 459 | image_create_info.flags = 0; |
| 460 | |
| 461 | VkMemoryAllocInfo mem_alloc = {}; |
| 462 | mem_alloc.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOC_INFO; |
| 463 | mem_alloc.pNext = NULL; |
| 464 | mem_alloc.allocationSize = 0; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 465 | // Introduce failure, do NOT set memProps to VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 466 | mem_alloc.memoryTypeIndex = 1; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 467 | |
| 468 | err = vkCreateImage(m_device->device(), &image_create_info, &image); |
| 469 | ASSERT_VK_SUCCESS(err); |
| 470 | |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 471 | err = vkGetImageMemoryRequirements(m_device->device(), |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 472 | image, |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 473 | &mem_reqs); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 474 | ASSERT_VK_SUCCESS(err); |
| 475 | |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 476 | mem_alloc.allocationSize = mem_reqs.size; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 477 | |
Mike Stroyan | 713b2d7 | 2015-08-04 10:49:29 -0600 | [diff] [blame] | 478 | err = m_device->phy().set_memory_type(mem_reqs.memoryTypeBits, &mem_alloc, 0, VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT); |
Tony Barbour | 02fdc7d | 2015-08-04 16:13:01 -0600 | [diff] [blame] | 479 | if(err != VK_SUCCESS) // If we can't find any unmappable memory this test doesn't make sense |
| 480 | return; |
Mike Stroyan | 713b2d7 | 2015-08-04 10:49:29 -0600 | [diff] [blame] | 481 | |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 482 | // allocate memory |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 483 | err = vkAllocMemory(m_device->device(), &mem_alloc, &mem); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 484 | ASSERT_VK_SUCCESS(err); |
| 485 | |
| 486 | // Try to bind free memory that has been freed |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 487 | err = vkBindImageMemory(m_device->device(), image, mem, 0); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 488 | ASSERT_VK_SUCCESS(err); |
| 489 | |
| 490 | // Map memory as if to initialize the image |
| 491 | void *mappedAddress = NULL; |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 492 | err = vkMapMemory(m_device->device(), mem, 0, 0, 0, &mappedAddress); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 493 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 494 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 495 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error while tring to map memory not visible to CPU"; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 496 | if (!strstr(msgString.c_str(),"Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT")) { |
| 497 | FAIL() << "Error received did not match expected error message from vkMapMemory in MemTracker"; |
| 498 | } |
| 499 | } |
| 500 | |
| 501 | TEST_F(VkLayerTest, BindInvalidMemory) |
| 502 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 503 | VkFlags msgFlags; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 504 | std::string msgString; |
| 505 | VkResult err; |
| 506 | |
| 507 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 508 | m_errorMonitor->ClearState(); |
| 509 | |
| 510 | // Create an image, allocate memory, free it, and then try to bind it |
| 511 | VkImage image; |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 512 | VkDeviceMemory mem; |
| 513 | VkMemoryRequirements mem_reqs; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 514 | |
| 515 | const VkFormat tex_format = VK_FORMAT_B8G8R8A8_UNORM; |
| 516 | const int32_t tex_width = 32; |
| 517 | const int32_t tex_height = 32; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 518 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 519 | VkImageCreateInfo image_create_info = {}; |
| 520 | image_create_info.sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO; |
| 521 | image_create_info.pNext = NULL; |
| 522 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 523 | image_create_info.format = tex_format; |
| 524 | image_create_info.extent.width = tex_width; |
| 525 | image_create_info.extent.height = tex_height; |
| 526 | image_create_info.extent.depth = 1; |
| 527 | image_create_info.mipLevels = 1; |
| 528 | image_create_info.arraySize = 1; |
| 529 | image_create_info.samples = 1; |
| 530 | image_create_info.tiling = VK_IMAGE_TILING_LINEAR; |
| 531 | image_create_info.usage = VK_IMAGE_USAGE_SAMPLED_BIT; |
| 532 | image_create_info.flags = 0; |
| 533 | |
| 534 | VkMemoryAllocInfo mem_alloc = {}; |
| 535 | mem_alloc.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOC_INFO; |
| 536 | mem_alloc.pNext = NULL; |
| 537 | mem_alloc.allocationSize = 0; |
| 538 | mem_alloc.memoryTypeIndex = 0; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 539 | |
| 540 | err = vkCreateImage(m_device->device(), &image_create_info, &image); |
| 541 | ASSERT_VK_SUCCESS(err); |
| 542 | |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 543 | err = vkGetImageMemoryRequirements(m_device->device(), |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 544 | image, |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 545 | &mem_reqs); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 546 | ASSERT_VK_SUCCESS(err); |
| 547 | |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 548 | mem_alloc.allocationSize = mem_reqs.size; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 549 | |
Chia-I Wu | 999f048 | 2015-07-03 10:32:05 +0800 | [diff] [blame] | 550 | err = m_device->phy().set_memory_type(mem_reqs.memoryTypeBits, &mem_alloc, 0); |
Mark Lobodzinski | b3fbcd9 | 2015-07-02 16:49:40 -0600 | [diff] [blame] | 551 | ASSERT_VK_SUCCESS(err); |
| 552 | |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 553 | // allocate memory |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 554 | err = vkAllocMemory(m_device->device(), &mem_alloc, &mem); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 555 | ASSERT_VK_SUCCESS(err); |
| 556 | |
| 557 | // Introduce validation failure, free memory before binding |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 558 | vkFreeMemory(m_device->device(), mem); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 559 | ASSERT_VK_SUCCESS(err); |
| 560 | |
| 561 | // Try to bind free memory that has been freed |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 562 | err = vkBindImageMemory(m_device->device(), image, mem, 0); |
Cody Northrop | b2f1d13 | 2015-08-06 12:40:01 -0600 | [diff] [blame] | 563 | // This may very well return an error. |
| 564 | (void)err; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 565 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 566 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 567 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error while tring to bind a freed memory object"; |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 568 | if (!strstr(msgString.c_str(),"couldn't find info for mem obj")) { |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 569 | FAIL() << "Error received did not match expected error message from BindObjectMemory in MemTracker"; |
| 570 | } |
| 571 | } |
| 572 | |
Tobin Ehlis | 2717d13 | 2015-07-10 18:25:07 -0600 | [diff] [blame] | 573 | // TODO : Is this test still valid. Not sure it is with updates to memory binding model |
| 574 | // Verify and delete the test of fix the check |
| 575 | //TEST_F(VkLayerTest, FreeBoundMemory) |
| 576 | //{ |
| 577 | // VkFlags msgFlags; |
| 578 | // std::string msgString; |
| 579 | // VkResult err; |
| 580 | // |
| 581 | // ASSERT_NO_FATAL_FAILURE(InitState()); |
| 582 | // m_errorMonitor->ClearState(); |
| 583 | // |
| 584 | // // Create an image, allocate memory, free it, and then try to bind it |
| 585 | // VkImage image; |
| 586 | // VkDeviceMemory mem; |
| 587 | // VkMemoryRequirements mem_reqs; |
| 588 | // |
| 589 | // const VkFormat tex_format = VK_FORMAT_B8G8R8A8_UNORM; |
| 590 | // const int32_t tex_width = 32; |
| 591 | // const int32_t tex_height = 32; |
| 592 | // |
| 593 | // const VkImageCreateInfo image_create_info = { |
| 594 | // .sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO, |
| 595 | // .pNext = NULL, |
| 596 | // .imageType = VK_IMAGE_TYPE_2D, |
| 597 | // .format = tex_format, |
| 598 | // .extent = { tex_width, tex_height, 1 }, |
| 599 | // .mipLevels = 1, |
| 600 | // .arraySize = 1, |
| 601 | // .samples = 1, |
| 602 | // .tiling = VK_IMAGE_TILING_LINEAR, |
| 603 | // .usage = VK_IMAGE_USAGE_SAMPLED_BIT, |
| 604 | // .flags = 0, |
| 605 | // }; |
| 606 | // VkMemoryAllocInfo mem_alloc = { |
| 607 | // .sType = VK_STRUCTURE_TYPE_MEMORY_ALLOC_INFO, |
| 608 | // .pNext = NULL, |
| 609 | // .allocationSize = 0, |
| 610 | // .memoryTypeIndex = 0, |
| 611 | // }; |
| 612 | // |
| 613 | // err = vkCreateImage(m_device->device(), &image_create_info, &image); |
| 614 | // ASSERT_VK_SUCCESS(err); |
| 615 | // |
| 616 | // err = vkGetImageMemoryRequirements(m_device->device(), |
| 617 | // image, |
| 618 | // &mem_reqs); |
| 619 | // ASSERT_VK_SUCCESS(err); |
| 620 | // |
| 621 | // mem_alloc.allocationSize = mem_reqs.size; |
| 622 | // |
| 623 | // err = m_device->phy().set_memory_type(mem_reqs.memoryTypeBits, &mem_alloc, 0); |
| 624 | // ASSERT_VK_SUCCESS(err); |
| 625 | // |
| 626 | // // allocate memory |
| 627 | // err = vkAllocMemory(m_device->device(), &mem_alloc, &mem); |
| 628 | // ASSERT_VK_SUCCESS(err); |
| 629 | // |
| 630 | // // Bind memory to Image object |
| 631 | // err = vkBindImageMemory(m_device->device(), image, mem, 0); |
| 632 | // ASSERT_VK_SUCCESS(err); |
| 633 | // |
| 634 | // // Introduce validation failure, free memory while still bound to object |
| 635 | // vkFreeMemory(m_device->device(), mem); |
| 636 | // ASSERT_VK_SUCCESS(err); |
| 637 | // |
| 638 | // msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 639 | // ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an warning while tring to free bound memory"; |
Tobin Ehlis | 2717d13 | 2015-07-10 18:25:07 -0600 | [diff] [blame] | 640 | // if (!strstr(msgString.c_str(),"Freeing memory object while it still has references")) { |
| 641 | // FAIL() << "Warning received did not match expected message from freeMemObjInfo in MemTracker"; |
| 642 | // } |
| 643 | //} |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 644 | |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 645 | TEST_F(VkLayerTest, RebindMemory) |
| 646 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 647 | VkFlags msgFlags; |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 648 | std::string msgString; |
| 649 | VkResult err; |
| 650 | |
| 651 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 652 | m_errorMonitor->ClearState(); |
| 653 | |
| 654 | // Create an image, allocate memory, free it, and then try to bind it |
| 655 | VkImage image; |
| 656 | VkDeviceMemory mem1; |
| 657 | VkDeviceMemory mem2; |
| 658 | VkMemoryRequirements mem_reqs; |
| 659 | |
| 660 | const VkFormat tex_format = VK_FORMAT_B8G8R8A8_UNORM; |
| 661 | const int32_t tex_width = 32; |
| 662 | const int32_t tex_height = 32; |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 663 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 664 | VkImageCreateInfo image_create_info = {}; |
| 665 | image_create_info.sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO; |
| 666 | image_create_info.pNext = NULL; |
| 667 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 668 | image_create_info.format = tex_format; |
| 669 | image_create_info.extent.width = tex_width; |
| 670 | image_create_info.extent.height = tex_height; |
| 671 | image_create_info.extent.depth = 1; |
| 672 | image_create_info.mipLevels = 1; |
| 673 | image_create_info.arraySize = 1; |
| 674 | image_create_info.samples = 1; |
| 675 | image_create_info.tiling = VK_IMAGE_TILING_LINEAR; |
| 676 | image_create_info.usage = VK_IMAGE_USAGE_SAMPLED_BIT; |
| 677 | image_create_info.flags = 0; |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 678 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 679 | VkMemoryAllocInfo mem_alloc = {}; |
| 680 | mem_alloc.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOC_INFO; |
| 681 | mem_alloc.pNext = NULL; |
| 682 | mem_alloc.allocationSize = 0; |
| 683 | mem_alloc.memoryTypeIndex = 0; |
| 684 | |
| 685 | // Introduce failure, do NOT set memProps to VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT |
| 686 | mem_alloc.memoryTypeIndex = 1; |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 687 | err = vkCreateImage(m_device->device(), &image_create_info, &image); |
| 688 | ASSERT_VK_SUCCESS(err); |
| 689 | |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 690 | err = vkGetImageMemoryRequirements(m_device->device(), |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 691 | image, |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 692 | &mem_reqs); |
| 693 | ASSERT_VK_SUCCESS(err); |
| 694 | |
| 695 | mem_alloc.allocationSize = mem_reqs.size; |
Chia-I Wu | 999f048 | 2015-07-03 10:32:05 +0800 | [diff] [blame] | 696 | err = m_device->phy().set_memory_type(mem_reqs.memoryTypeBits, &mem_alloc, 0); |
Mark Lobodzinski | b3fbcd9 | 2015-07-02 16:49:40 -0600 | [diff] [blame] | 697 | ASSERT_VK_SUCCESS(err); |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 698 | |
| 699 | // allocate 2 memory objects |
| 700 | err = vkAllocMemory(m_device->device(), &mem_alloc, &mem1); |
| 701 | ASSERT_VK_SUCCESS(err); |
| 702 | err = vkAllocMemory(m_device->device(), &mem_alloc, &mem2); |
| 703 | ASSERT_VK_SUCCESS(err); |
| 704 | |
| 705 | // Bind first memory object to Image object |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 706 | err = vkBindImageMemory(m_device->device(), image, mem1, 0); |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 707 | ASSERT_VK_SUCCESS(err); |
| 708 | |
| 709 | // Introduce validation failure, try to bind a different memory object to the same image object |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 710 | err = vkBindImageMemory(m_device->device(), image, mem2, 0); |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 711 | ASSERT_VK_SUCCESS(err); |
| 712 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 713 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 714 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error while tring to rebind an object"; |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 715 | if (!strstr(msgString.c_str(),"which has already been bound to mem object")) { |
| 716 | FAIL() << "Error received did not match expected message when rebinding memory to an object"; |
| 717 | } |
| 718 | } |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 719 | |
| 720 | TEST_F(VkLayerTest, BindMemoryToDestroyedObject) |
| 721 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 722 | VkFlags msgFlags; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 723 | std::string msgString; |
| 724 | VkResult err; |
| 725 | |
| 726 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 727 | m_errorMonitor->ClearState(); |
| 728 | |
| 729 | // Create an image object, allocate memory, destroy the object and then try to bind it |
| 730 | VkImage image; |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 731 | VkDeviceMemory mem; |
| 732 | VkMemoryRequirements mem_reqs; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 733 | |
| 734 | const VkFormat tex_format = VK_FORMAT_B8G8R8A8_UNORM; |
| 735 | const int32_t tex_width = 32; |
| 736 | const int32_t tex_height = 32; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 737 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 738 | VkImageCreateInfo image_create_info = {}; |
| 739 | image_create_info.sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO; |
| 740 | image_create_info.pNext = NULL; |
| 741 | image_create_info.imageType = VK_IMAGE_TYPE_2D; |
| 742 | image_create_info.format = tex_format; |
| 743 | image_create_info.extent.width = tex_width; |
| 744 | image_create_info.extent.height = tex_height; |
| 745 | image_create_info.extent.depth = 1; |
| 746 | image_create_info.mipLevels = 1; |
| 747 | image_create_info.arraySize = 1; |
| 748 | image_create_info.samples = 1; |
| 749 | image_create_info.tiling = VK_IMAGE_TILING_LINEAR; |
| 750 | image_create_info.usage = VK_IMAGE_USAGE_SAMPLED_BIT; |
| 751 | image_create_info.flags = 0; |
| 752 | |
| 753 | VkMemoryAllocInfo mem_alloc = {}; |
| 754 | mem_alloc.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOC_INFO; |
| 755 | mem_alloc.pNext = NULL; |
| 756 | mem_alloc.allocationSize = 0; |
| 757 | mem_alloc.memoryTypeIndex = 0; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 758 | |
| 759 | err = vkCreateImage(m_device->device(), &image_create_info, &image); |
| 760 | ASSERT_VK_SUCCESS(err); |
| 761 | |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 762 | err = vkGetImageMemoryRequirements(m_device->device(), |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 763 | image, |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 764 | &mem_reqs); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 765 | ASSERT_VK_SUCCESS(err); |
| 766 | |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 767 | mem_alloc.allocationSize = mem_reqs.size; |
Chia-I Wu | 999f048 | 2015-07-03 10:32:05 +0800 | [diff] [blame] | 768 | err = m_device->phy().set_memory_type(mem_reqs.memoryTypeBits, &mem_alloc, 0); |
Mark Lobodzinski | b3fbcd9 | 2015-07-02 16:49:40 -0600 | [diff] [blame] | 769 | ASSERT_VK_SUCCESS(err); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 770 | |
| 771 | // Allocate memory |
Mark Lobodzinski | 2306535 | 2015-05-29 09:32:35 -0500 | [diff] [blame] | 772 | err = vkAllocMemory(m_device->device(), &mem_alloc, &mem); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 773 | ASSERT_VK_SUCCESS(err); |
| 774 | |
| 775 | // Introduce validation failure, destroy Image object before binding |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 776 | vkDestroyImage(m_device->device(), image); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 777 | ASSERT_VK_SUCCESS(err); |
| 778 | |
Mike Stroyan | 713b2d7 | 2015-08-04 10:49:29 -0600 | [diff] [blame] | 779 | // Now Try to bind memory to this destroyed object |
Tony Barbour | 67e9915 | 2015-07-10 14:10:27 -0600 | [diff] [blame] | 780 | err = vkBindImageMemory(m_device->device(), image, mem, 0); |
Mike Stroyan | 713b2d7 | 2015-08-04 10:49:29 -0600 | [diff] [blame] | 781 | // This may very well return an error. |
| 782 | (void) err; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 783 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 784 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 785 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error while binding memory to a destroyed object"; |
Mark Lobodzinski | 944aab1 | 2015-06-05 13:59:04 -0500 | [diff] [blame] | 786 | if (!strstr(msgString.c_str(),"that's not in global list")) { |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 787 | FAIL() << "Error received did not match expected error message from updateObjectBinding in MemTracker"; |
| 788 | } |
| 789 | } |
| 790 | |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 791 | TEST_F(VkLayerTest, SubmitSignaledFence) |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 792 | { |
Courtney Goeltzenleuchter | d8e229c | 2015-04-08 15:36:08 -0600 | [diff] [blame] | 793 | vk_testing::Fence testFence; |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 794 | VkFlags msgFlags; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 795 | std::string msgString; |
Courtney Goeltzenleuchter | fb4efc6 | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 796 | |
| 797 | VkFenceCreateInfo fenceInfo = {}; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 798 | fenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO; |
| 799 | fenceInfo.pNext = NULL; |
| 800 | fenceInfo.flags = VK_FENCE_CREATE_SIGNALED_BIT; |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 801 | |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 802 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 803 | ASSERT_NO_FATAL_FAILURE(InitViewport()); |
| 804 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 805 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 806 | BeginCommandBuffer(); |
| 807 | m_cmdBuffer->ClearAllBuffers(m_clear_color, m_depth_clear_color, m_stencil_clear_color, NULL); |
| 808 | EndCommandBuffer(); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 809 | |
| 810 | testFence.init(*m_device, fenceInfo); |
| 811 | m_errorMonitor->ClearState(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 812 | QueueCommandBuffer(testFence.handle()); |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 813 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 814 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an err from using a fence in SIGNALED state in call to vkQueueSubmit"; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 815 | if (!strstr(msgString.c_str(),"submitted in SIGNALED state. Fences must be reset before being submitted")) { |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 816 | FAIL() << "Error received was not 'VkQueueSubmit with fence in SIGNALED_STATE'"; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 817 | } |
| 818 | |
| 819 | } |
| 820 | |
| 821 | TEST_F(VkLayerTest, ResetUnsignaledFence) |
| 822 | { |
| 823 | vk_testing::Fence testFence; |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 824 | VkFlags msgFlags; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 825 | std::string msgString; |
Courtney Goeltzenleuchter | fb4efc6 | 2015-04-10 08:34:15 -0600 | [diff] [blame] | 826 | VkFenceCreateInfo fenceInfo = {}; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 827 | fenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO; |
| 828 | fenceInfo.pNext = NULL; |
| 829 | |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 830 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 831 | testFence.init(*m_device, fenceInfo); |
| 832 | m_errorMonitor->ClearState(); |
Chia-I Wu | d9e8e82 | 2015-07-03 11:45:55 +0800 | [diff] [blame] | 833 | VkFence fences[1] = {testFence.handle()}; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 834 | vkResetFences(m_device->device(), 1, fences); |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 835 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 836 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error from submitting fence with UNSIGNALED state to vkResetFences"; |
Tony Barbour | 6918cd5 | 2015-04-09 12:58:51 -0600 | [diff] [blame] | 837 | if (!strstr(msgString.c_str(),"submitted to VkResetFences in UNSIGNALED STATE")) { |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 838 | FAIL() << "Error received was not 'VkResetFences with fence in UNSIGNALED_STATE'"; |
Tony Barbour | 0b4d956 | 2015-04-09 10:48:04 -0600 | [diff] [blame] | 839 | } |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 840 | |
| 841 | } |
Tobin Ehlis | 41376e1 | 2015-07-03 08:45:14 -0600 | [diff] [blame] | 842 | |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 843 | /* TODO: Update for changes due to bug-14075 tiling across render passes */ |
| 844 | #if 0 |
Tobin Ehlis | 41376e1 | 2015-07-03 08:45:14 -0600 | [diff] [blame] | 845 | TEST_F(VkLayerTest, InvalidUsageBits) |
| 846 | { |
| 847 | // Initiate Draw w/o a PSO bound |
| 848 | VkFlags msgFlags; |
| 849 | std::string msgString; |
| 850 | |
| 851 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 852 | m_errorMonitor->ClearState(); |
| 853 | VkCommandBufferObj cmdBuffer(m_device); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 854 | BeginCommandBuffer(); |
Tobin Ehlis | 41376e1 | 2015-07-03 08:45:14 -0600 | [diff] [blame] | 855 | |
| 856 | const VkExtent3D e3d = { |
| 857 | .width = 128, |
| 858 | .height = 128, |
| 859 | .depth = 1, |
| 860 | }; |
| 861 | const VkImageCreateInfo ici = { |
| 862 | .sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO, |
| 863 | .pNext = NULL, |
| 864 | .imageType = VK_IMAGE_TYPE_2D, |
| 865 | .format = VK_FORMAT_D32_SFLOAT_S8_UINT, |
| 866 | .extent = e3d, |
| 867 | .mipLevels = 1, |
| 868 | .arraySize = 1, |
| 869 | .samples = 1, |
| 870 | .tiling = VK_IMAGE_TILING_LINEAR, |
| 871 | .usage = 0, // Not setting VK_IMAGE_USAGE_DEPTH_STENCIL_BIT |
| 872 | .flags = 0, |
| 873 | }; |
| 874 | |
| 875 | VkImage dsi; |
| 876 | vkCreateImage(m_device->device(), &ici, &dsi); |
| 877 | VkDepthStencilView dsv; |
| 878 | const VkDepthStencilViewCreateInfo dsvci = { |
| 879 | .sType = VK_STRUCTURE_TYPE_DEPTH_STENCIL_VIEW_CREATE_INFO, |
| 880 | .pNext = NULL, |
| 881 | .image = dsi, |
| 882 | .mipLevel = 0, |
| 883 | .baseArraySlice = 0, |
| 884 | .arraySize = 1, |
| 885 | .flags = 0, |
| 886 | }; |
| 887 | vkCreateDepthStencilView(m_device->device(), &dsvci, &dsv); |
| 888 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 889 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after attempting to create DSView w/ image lacking USAGE_DS_BIT flag"; |
Tobin Ehlis | 41376e1 | 2015-07-03 08:45:14 -0600 | [diff] [blame] | 890 | if (!strstr(msgString.c_str(),"Invalid usage flag for image ")) { |
| 891 | FAIL() << "Error received was not 'Invalid usage flag for image...'"; |
| 892 | } |
| 893 | } |
Tobin Ehlis | 0788f52 | 2015-05-26 16:11:58 -0600 | [diff] [blame] | 894 | #endif |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 895 | #endif |
Tobin Ehlis | 4bf96d1 | 2015-06-25 11:58:41 -0600 | [diff] [blame] | 896 | #if OBJ_TRACKER_TESTS |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 897 | TEST_F(VkLayerTest, RasterStateNotBound) |
| 898 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 899 | VkFlags msgFlags; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 900 | std::string msgString; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 901 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 902 | m_errorMonitor->ClearState(); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 903 | TEST_DESCRIPTION("Simple Draw Call that validates failure when a raster state object is not bound beforehand"); |
| 904 | |
| 905 | VKTriangleTest(bindStateVertShaderText, bindStateFragShaderText, BsoFailRaster); |
| 906 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 907 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 908 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error from Not Binding a Raster State Object"; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 909 | if (!strstr(msgString.c_str(),"Raster object not bound to this command buffer")) { |
| 910 | FAIL() << "Error received was not 'Raster object not bound to this command buffer'"; |
| 911 | } |
| 912 | } |
| 913 | |
| 914 | TEST_F(VkLayerTest, ViewportStateNotBound) |
| 915 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 916 | VkFlags msgFlags; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 917 | std::string msgString; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 918 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 919 | m_errorMonitor->ClearState(); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 920 | TEST_DESCRIPTION("Simple Draw Call that validates failure when a viewport state object is not bound beforehand"); |
| 921 | |
| 922 | VKTriangleTest(bindStateVertShaderText, bindStateFragShaderText, BsoFailViewport); |
| 923 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 924 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 925 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error from Not Binding a Viewport State Object"; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 926 | if (!strstr(msgString.c_str(),"Viewport object not bound to this command buffer")) { |
| 927 | FAIL() << "Error received was not 'Viewport object not bound to this command buffer'"; |
| 928 | } |
| 929 | } |
| 930 | |
| 931 | TEST_F(VkLayerTest, ColorBlendStateNotBound) |
| 932 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 933 | VkFlags msgFlags; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 934 | std::string msgString; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 935 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 936 | m_errorMonitor->ClearState(); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 937 | TEST_DESCRIPTION("Simple Draw Call that validates failure when a color-blend state object is not bound beforehand"); |
| 938 | |
| 939 | VKTriangleTest(bindStateVertShaderText, bindStateFragShaderText, BsoFailColorBlend); |
| 940 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 941 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 942 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error from Not Binding a ColorBlend State Object"; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 943 | if (!strstr(msgString.c_str(),"Color-blend object not bound to this command buffer")) { |
| 944 | FAIL() << "Error received was not 'Color-blend object not bound to this command buffer'"; |
| 945 | } |
| 946 | } |
| 947 | |
| 948 | TEST_F(VkLayerTest, DepthStencilStateNotBound) |
| 949 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 950 | VkFlags msgFlags; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 951 | std::string msgString; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 952 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 953 | m_errorMonitor->ClearState(); |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 954 | TEST_DESCRIPTION("Simple Draw Call that validates failure when a depth-stencil state object is not bound beforehand"); |
| 955 | |
| 956 | VKTriangleTest(bindStateVertShaderText, bindStateFragShaderText, BsoFailDepthStencil); |
| 957 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 958 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 959 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error from Not Binding a DepthStencil State Object"; |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 960 | if (!strstr(msgString.c_str(),"Depth-stencil object not bound to this command buffer")) { |
| 961 | FAIL() << "Error received was not 'Depth-stencil object not bound to this command buffer'"; |
| 962 | } |
Tony Barbour | d866ad0 | 2015-05-06 09:35:56 -0600 | [diff] [blame] | 963 | } |
Tobin Ehlis | 0788f52 | 2015-05-26 16:11:58 -0600 | [diff] [blame] | 964 | #endif |
| 965 | #if DRAW_STATE_TESTS |
Tobin Ehlis | 59278bf | 2015-08-18 07:10:58 -0600 | [diff] [blame] | 966 | TEST_F(VkLayerTest, CmdBufferTwoSubmits) |
| 967 | { |
| 968 | vk_testing::Fence testFence; |
| 969 | VkFlags msgFlags; |
| 970 | std::string msgString; |
| 971 | |
| 972 | VkFenceCreateInfo fenceInfo = {}; |
| 973 | fenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO; |
| 974 | fenceInfo.pNext = NULL; |
| 975 | fenceInfo.flags = 0; |
| 976 | |
| 977 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 978 | ASSERT_NO_FATAL_FAILURE(InitViewport()); |
| 979 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 980 | |
| 981 | // We luck out b/c by default the framework creates CB w/ the VK_CMD_BUFFER_OPTIMIZE_ONE_TIME_SUBMIT_BIT set |
| 982 | BeginCommandBuffer(); |
| 983 | m_cmdBuffer->ClearAllBuffers(m_clear_color, m_depth_clear_color, m_stencil_clear_color, NULL); |
| 984 | EndCommandBuffer(); |
| 985 | |
| 986 | testFence.init(*m_device, fenceInfo); |
| 987 | |
| 988 | // Bypass framework since it does the waits automatically |
| 989 | VkResult err = VK_SUCCESS; |
| 990 | err = vkQueueSubmit( m_device->m_queue, 1, &m_cmdBuffer->handle(), testFence.handle()); |
| 991 | ASSERT_VK_SUCCESS( err ); |
| 992 | |
| 993 | m_errorMonitor->ClearState(); |
| 994 | // Cause validation error by re-submitting cmd buffer that should only be submitted once |
| 995 | err = vkQueueSubmit( m_device->m_queue, 1, &m_cmdBuffer->handle(), testFence.handle()); |
| 996 | ASSERT_VK_SUCCESS( err ); |
| 997 | |
| 998 | msgFlags = m_errorMonitor->GetState(&msgString); |
| 999 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an err after re-submitting Command Buffer that was created with one-time submit flag"; |
Tobin Ehlis | f1878c7 | 2015-08-18 14:24:32 -0600 | [diff] [blame] | 1000 | if (!strstr(msgString.c_str(),"was begun w/ VK_CMD_BUFFER_OPTIMIZE_ONE_TIME_SUBMIT_BIT set, but has been submitted")) { |
Tobin Ehlis | 59278bf | 2015-08-18 07:10:58 -0600 | [diff] [blame] | 1001 | FAIL() << "Error received was not 'CB (0xaddress) was created w/ VK_CMD_BUFFER_OPTIMIZE_ONE_TIME_SUBMIT_BIT set...'"; |
| 1002 | } |
| 1003 | } |
| 1004 | |
| 1005 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1006 | TEST_F(VkLayerTest, BindPipelineNoRenderPass) |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1007 | { |
| 1008 | // Initiate Draw w/o a PSO bound |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1009 | VkFlags msgFlags; |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1010 | std::string msgString; |
| 1011 | |
| 1012 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1013 | m_errorMonitor->ClearState(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1014 | BeginCommandBuffer(); |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1015 | VkPipeline badPipeline = (VkPipeline)0xbaadb1be; |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1016 | vkCmdBindPipeline(m_cmdBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, badPipeline); |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1017 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1018 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after binding pipeline to CmdBuffer w/o active RenderPass"; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1019 | if (!strstr(msgString.c_str(),"Incorrectly binding graphics pipeline ")) { |
| 1020 | FAIL() << "Error received was not 'Incorrectly binding graphics pipeline (0xbaadb1be) without an active RenderPass'"; |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1021 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1022 | } |
| 1023 | |
| 1024 | TEST_F(VkLayerTest, InvalidDescriptorPool) |
| 1025 | { |
| 1026 | // TODO : Simple check for bad object should be added to ObjectTracker to catch this case |
| 1027 | // The DS check for this is after driver has been called to validate DS internal data struct |
| 1028 | // Attempt to clear DS Pool with bad object |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1029 | /* VkFlags msgFlags; |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1030 | std::string msgString; |
| 1031 | VkDescriptorPool badPool = (VkDescriptorPool)0xbaad6001; |
| 1032 | vkResetDescriptorPool(device(), badPool); |
| 1033 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1034 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1035 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an error from Resetting an invalid DescriptorPool Object"; |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1036 | if (!strstr(msgString.c_str(),"Unable to find pool node for pool 0xbaad6001 specified in vkResetDescriptorPool() call")) { |
| 1037 | FAIL() << "Error received was note 'Unable to find pool node for pool 0xbaad6001 specified in vkResetDescriptorPool() call'"; |
| 1038 | }*/ |
| 1039 | } |
| 1040 | |
| 1041 | TEST_F(VkLayerTest, InvalidDescriptorSet) |
| 1042 | { |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1043 | // TODO : Simple check for bad object should be added to ObjectTracker to catch this case |
| 1044 | // The DS check for this is after driver has been called to validate DS internal data struct |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1045 | // Create a valid cmd buffer |
| 1046 | // call vkCmdBindDescriptorSets w/ false DS |
| 1047 | } |
| 1048 | |
| 1049 | TEST_F(VkLayerTest, InvalidDescriptorSetLayout) |
| 1050 | { |
| 1051 | // TODO : Simple check for bad object should be added to ObjectTracker to catch this case |
| 1052 | // The DS check for this is after driver has been called to validate DS internal data struct |
| 1053 | } |
| 1054 | |
| 1055 | TEST_F(VkLayerTest, InvalidPipeline) |
| 1056 | { |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1057 | // TODO : Simple check for bad object should be added to ObjectTracker to catch this case |
| 1058 | // The DS check for this is after driver has been called to validate DS internal data struct |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1059 | // Create a valid cmd buffer |
| 1060 | // call vkCmdBindPipeline w/ false Pipeline |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1061 | // VkFlags msgFlags; |
| 1062 | // std::string msgString; |
| 1063 | // |
| 1064 | // ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1065 | // m_errorMonitor->ClearState(); |
| 1066 | // VkCommandBufferObj cmdBuffer(m_device); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1067 | // BeginCommandBuffer(); |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1068 | // VkPipeline badPipeline = (VkPipeline)0xbaadb1be; |
| 1069 | // vkCmdBindPipeline(cmdBuffer.GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, badPipeline); |
| 1070 | // msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1071 | // ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after binding invalid pipeline to CmdBuffer"; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1072 | // if (!strstr(msgString.c_str(),"Attempt to bind Pipeline ")) { |
| 1073 | // FAIL() << "Error received was not 'Attempt to bind Pipeline 0xbaadb1be that doesn't exist!'"; |
| 1074 | // } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1075 | } |
| 1076 | |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1077 | TEST_F(VkLayerTest, DescriptorSetNotUpdated) |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1078 | { |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1079 | // Create and update CmdBuffer then call QueueSubmit w/o calling End on CmdBuffer |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1080 | VkFlags msgFlags; |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1081 | std::string msgString; |
| 1082 | VkResult err; |
| 1083 | |
| 1084 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Mike Stroyan | 713b2d7 | 2015-08-04 10:49:29 -0600 | [diff] [blame] | 1085 | ASSERT_NO_FATAL_FAILURE(InitViewport()); |
| 1086 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1087 | m_errorMonitor->ClearState(); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1088 | VkDescriptorTypeCount ds_type_count = {}; |
| 1089 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1090 | ds_type_count.count = 1; |
| 1091 | |
| 1092 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1093 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1094 | ds_pool_ci.pNext = NULL; |
| 1095 | ds_pool_ci.count = 1; |
| 1096 | ds_pool_ci.pTypeCount = &ds_type_count; |
Mike Stroyan | 713b2d7 | 2015-08-04 10:49:29 -0600 | [diff] [blame] | 1097 | |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1098 | VkDescriptorPool ds_pool; |
| 1099 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1100 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1101 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1102 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1103 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1104 | dsl_binding.arraySize = 1; |
| 1105 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1106 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1107 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1108 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1109 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1110 | ds_layout_ci.pNext = NULL; |
| 1111 | ds_layout_ci.count = 1; |
| 1112 | ds_layout_ci.pBinding = &dsl_binding; |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1113 | VkDescriptorSetLayout ds_layout; |
| 1114 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1115 | ASSERT_VK_SUCCESS(err); |
| 1116 | |
| 1117 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1118 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1119 | ASSERT_VK_SUCCESS(err); |
| 1120 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1121 | VkPipelineLayoutCreateInfo pipeline_layout_ci = {}; |
| 1122 | pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO; |
| 1123 | pipeline_layout_ci.pNext = NULL; |
| 1124 | pipeline_layout_ci.descriptorSetCount = 1; |
| 1125 | pipeline_layout_ci.pSetLayouts = &ds_layout; |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1126 | |
| 1127 | VkPipelineLayout pipeline_layout; |
| 1128 | err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, &pipeline_layout); |
| 1129 | ASSERT_VK_SUCCESS(err); |
| 1130 | |
Courtney Goeltzenleuchter | ee4027d | 2015-06-28 13:01:17 -0600 | [diff] [blame] | 1131 | VkShaderObj vs(m_device, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX, this); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 1132 | VkShaderObj fs(m_device, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT, this); // TODO - We shouldn't need a fragment shader |
| 1133 | // but add it to be able to run on more devices |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1134 | |
Tony Barbour | c95e4ac | 2015-08-04 17:05:26 -0600 | [diff] [blame] | 1135 | VkPipelineObj pipe(m_device); |
| 1136 | pipe.AddShader(&vs); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 1137 | pipe.AddShader(&fs); |
Tony Barbour | c95e4ac | 2015-08-04 17:05:26 -0600 | [diff] [blame] | 1138 | pipe.CreateVKPipeline(pipeline_layout, renderPass()); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1139 | |
| 1140 | BeginCommandBuffer(); |
Tony Barbour | c95e4ac | 2015-08-04 17:05:26 -0600 | [diff] [blame] | 1141 | vkCmdBindPipeline(m_cmdBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.handle()); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1142 | vkCmdBindDescriptorSets(m_cmdBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline_layout, 0, 1, &descriptorSet, 0, NULL); |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1143 | |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1144 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1145 | ASSERT_NE(0, msgFlags & VK_DBG_REPORT_WARN_BIT) << "Did not warn after binding a DescriptorSet that was never updated."; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1146 | if (!strstr(msgString.c_str()," bound but it was never updated. ")) { |
| 1147 | FAIL() << "Error received was not 'DS <blah> bound but it was never updated. You may want to either update it or not bind it.'"; |
| 1148 | } |
| 1149 | } |
| 1150 | |
| 1151 | TEST_F(VkLayerTest, NoBeginCmdBuffer) |
| 1152 | { |
| 1153 | VkFlags msgFlags; |
| 1154 | std::string msgString; |
| 1155 | |
| 1156 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1157 | m_errorMonitor->ClearState(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1158 | VkCommandBufferObj cmdBuffer(m_device, m_cmdPool); |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1159 | // Call EndCommandBuffer() w/o calling BeginCommandBuffer() |
| 1160 | vkEndCommandBuffer(cmdBuffer.GetBufferHandle()); |
| 1161 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1162 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after ending a CmdBuffer w/o calling BeginCommandBuffer()"; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1163 | if (!strstr(msgString.c_str(),"You must call vkBeginCommandBuffer() before this call to ")) { |
| 1164 | FAIL() << "Error received was not 'You must call vkBeginCommandBuffer() before this call to vkEndCommandBuffer()'"; |
| 1165 | } |
| 1166 | } |
| 1167 | |
Mark Lobodzinski | d9139a6 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 1168 | TEST_F(VkLayerTest, PrimaryCmdBufferFramebufferAndRenderpass) |
| 1169 | { |
| 1170 | VkFlags msgFlags; |
| 1171 | std::string msgString; |
| 1172 | |
| 1173 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1174 | m_errorMonitor->ClearState(); |
| 1175 | |
| 1176 | // Calls CreateCommandBuffer |
| 1177 | VkCommandBufferObj cmdBuffer(m_device, m_cmdPool); |
| 1178 | |
| 1179 | // Force the failure by setting the Renderpass and Framebuffer fields with (fake) data |
Cody Northrop | b456970 | 2015-08-04 17:35:57 -0600 | [diff] [blame] | 1180 | VkCmdBufferBeginInfo cmd_buf_info = {}; |
| 1181 | cmd_buf_info.sType = VK_STRUCTURE_TYPE_CMD_BUFFER_BEGIN_INFO; |
| 1182 | cmd_buf_info.pNext = NULL; |
| 1183 | cmd_buf_info.flags = VK_CMD_BUFFER_OPTIMIZE_SMALL_BATCH_BIT | |
| 1184 | VK_CMD_BUFFER_OPTIMIZE_ONE_TIME_SUBMIT_BIT; |
| 1185 | cmd_buf_info.renderPass = (VkRenderPass)0xcadecade; |
| 1186 | cmd_buf_info.framebuffer = (VkFramebuffer)0xcadecade; |
| 1187 | |
Mark Lobodzinski | d9139a6 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 1188 | |
| 1189 | // The error should be caught by validation of the BeginCommandBuffer call |
| 1190 | vkBeginCommandBuffer(cmdBuffer.GetBufferHandle(), &cmd_buf_info); |
| 1191 | |
| 1192 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1193 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error passing a non-NULL Framebuffer and Renderpass to BeginCommandBuffer()"; |
Mark Lobodzinski | d9139a6 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 1194 | if (!strstr(msgString.c_str(),"may not specify framebuffer or renderpass parameters")) { |
| 1195 | FAIL() << "Error received was not 'vkCreateCommandBuffer(): Primary Command Buffer may not specify framebuffer or renderpass parameters'"; |
| 1196 | } |
| 1197 | } |
| 1198 | |
| 1199 | TEST_F(VkLayerTest, SecondaryCmdBufferFramebufferAndRenderpass) |
| 1200 | { |
| 1201 | VkFlags msgFlags; |
| 1202 | std::string msgString; |
| 1203 | VkResult err; |
| 1204 | VkCmdBuffer draw_cmd; |
| 1205 | VkCmdPool cmd_pool; |
| 1206 | |
| 1207 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1208 | m_errorMonitor->ClearState(); |
| 1209 | |
Cody Northrop | b456970 | 2015-08-04 17:35:57 -0600 | [diff] [blame] | 1210 | VkCmdBufferCreateInfo cmd = {}; |
| 1211 | cmd.sType = VK_STRUCTURE_TYPE_CMD_BUFFER_CREATE_INFO; |
| 1212 | cmd.pNext = NULL; |
| 1213 | cmd.cmdPool = m_cmdPool; |
| 1214 | cmd.level = VK_CMD_BUFFER_LEVEL_SECONDARY; |
| 1215 | cmd.flags = 0; |
| 1216 | |
Mark Lobodzinski | d9139a6 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 1217 | err = vkCreateCommandBuffer(m_device->device(), &cmd, &draw_cmd); |
| 1218 | assert(!err); |
| 1219 | |
| 1220 | // Force the failure by not setting the Renderpass and Framebuffer fields |
Cody Northrop | b456970 | 2015-08-04 17:35:57 -0600 | [diff] [blame] | 1221 | VkCmdBufferBeginInfo cmd_buf_info = {}; |
| 1222 | cmd_buf_info.sType = VK_STRUCTURE_TYPE_CMD_BUFFER_BEGIN_INFO; |
| 1223 | cmd_buf_info.pNext = NULL; |
| 1224 | cmd_buf_info.flags = VK_CMD_BUFFER_OPTIMIZE_SMALL_BATCH_BIT | |
| 1225 | VK_CMD_BUFFER_OPTIMIZE_ONE_TIME_SUBMIT_BIT; |
Mark Lobodzinski | d9139a6 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 1226 | |
| 1227 | // The error should be caught by validation of the BeginCommandBuffer call |
| 1228 | vkBeginCommandBuffer(draw_cmd, &cmd_buf_info); |
| 1229 | |
| 1230 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1231 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error passing NULL Framebuffer/Renderpass to BeginCommandBuffer()"; |
Mark Lobodzinski | d9139a6 | 2015-08-04 16:24:20 -0600 | [diff] [blame] | 1232 | if (!strstr(msgString.c_str(),"must specify framebuffer and renderpass parameters")) { |
| 1233 | FAIL() << "Error received was not 'vkCreateCommandBuffer(): Secondary Command Buffer must specify framebuffer and renderpass parameters'"; |
| 1234 | } |
| 1235 | } |
| 1236 | |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1237 | TEST_F(VkLayerTest, InvalidPipelineCreateState) |
| 1238 | { |
| 1239 | // Attempt to Create Gfx Pipeline w/o a VS |
| 1240 | VkFlags msgFlags; |
| 1241 | std::string msgString; |
| 1242 | VkResult err; |
| 1243 | |
| 1244 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1245 | m_errorMonitor->ClearState(); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1246 | |
| 1247 | VkDescriptorTypeCount ds_type_count = {}; |
| 1248 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1249 | ds_type_count.count = 1; |
| 1250 | |
| 1251 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1252 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1253 | ds_pool_ci.pNext = NULL; |
| 1254 | ds_pool_ci.count = 1; |
| 1255 | ds_pool_ci.pTypeCount = &ds_type_count; |
| 1256 | |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1257 | VkDescriptorPool ds_pool; |
| 1258 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1259 | ASSERT_VK_SUCCESS(err); |
| 1260 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1261 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1262 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1263 | dsl_binding.arraySize = 1; |
| 1264 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1265 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1266 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1267 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1268 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1269 | ds_layout_ci.pNext = NULL; |
| 1270 | ds_layout_ci.count = 1; |
| 1271 | ds_layout_ci.pBinding = &dsl_binding; |
| 1272 | |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1273 | VkDescriptorSetLayout ds_layout; |
| 1274 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1275 | ASSERT_VK_SUCCESS(err); |
| 1276 | |
| 1277 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1278 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1279 | ASSERT_VK_SUCCESS(err); |
| 1280 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1281 | VkPipelineLayoutCreateInfo pipeline_layout_ci = {}; |
| 1282 | pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO; |
| 1283 | pipeline_layout_ci.pNext = NULL; |
| 1284 | pipeline_layout_ci.descriptorSetCount = 1; |
| 1285 | pipeline_layout_ci.pSetLayouts = &ds_layout; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1286 | |
| 1287 | VkPipelineLayout pipeline_layout; |
| 1288 | err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, &pipeline_layout); |
| 1289 | ASSERT_VK_SUCCESS(err); |
| 1290 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1291 | VkGraphicsPipelineCreateInfo gp_ci = {}; |
| 1292 | gp_ci.sType = VK_STRUCTURE_TYPE_GRAPHICS_PIPELINE_CREATE_INFO; |
| 1293 | gp_ci.pNext = NULL; |
| 1294 | gp_ci.stageCount = 0; |
| 1295 | gp_ci.pStages = NULL; |
| 1296 | gp_ci.pVertexInputState = NULL; |
| 1297 | gp_ci.pInputAssemblyState = NULL; |
| 1298 | gp_ci.pTessellationState = NULL; |
| 1299 | gp_ci.pViewportState = NULL; |
| 1300 | gp_ci.pRasterState = NULL; |
| 1301 | gp_ci.pMultisampleState = NULL; |
| 1302 | gp_ci.pDepthStencilState = NULL; |
| 1303 | gp_ci.pColorBlendState = NULL; |
| 1304 | gp_ci.flags = VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT; |
| 1305 | gp_ci.layout = pipeline_layout; |
| 1306 | |
| 1307 | VkPipelineCacheCreateInfo pc_ci = {}; |
| 1308 | pc_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_CACHE_CREATE_INFO; |
| 1309 | pc_ci.pNext = NULL; |
| 1310 | pc_ci.initialSize = 0; |
| 1311 | pc_ci.initialData = 0; |
| 1312 | pc_ci.maxSize = 0; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1313 | |
| 1314 | VkPipeline pipeline; |
Jon Ashburn | c669cc6 | 2015-07-09 15:02:25 -0600 | [diff] [blame] | 1315 | VkPipelineCache pipelineCache; |
| 1316 | |
| 1317 | err = vkCreatePipelineCache(m_device->device(), &pc_ci, &pipelineCache); |
| 1318 | ASSERT_VK_SUCCESS(err); |
| 1319 | err = vkCreateGraphicsPipelines(m_device->device(), pipelineCache, 1, &gp_ci, &pipeline); |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1320 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1321 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1322 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after creating Gfx Pipeline w/o VS."; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1323 | if (!strstr(msgString.c_str(),"Invalid Pipeline CreateInfo State: Vtx Shader required")) { |
| 1324 | FAIL() << "Error received was not 'Invalid Pipeline CreateInfo State: Vtx Shader required'"; |
| 1325 | } |
| 1326 | } |
| 1327 | |
Tobin Ehlis | 98aa0ed | 2015-06-25 16:27:19 -0600 | [diff] [blame] | 1328 | TEST_F(VkLayerTest, NullRenderPass) |
| 1329 | { |
| 1330 | // Bind a NULL RenderPass |
| 1331 | VkFlags msgFlags; |
| 1332 | std::string msgString; |
| 1333 | |
| 1334 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1335 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1336 | m_errorMonitor->ClearState(); |
Tobin Ehlis | 98aa0ed | 2015-06-25 16:27:19 -0600 | [diff] [blame] | 1337 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1338 | BeginCommandBuffer(); |
Tobin Ehlis | 98aa0ed | 2015-06-25 16:27:19 -0600 | [diff] [blame] | 1339 | // Don't care about RenderPass handle b/c error should be flagged before that |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1340 | vkCmdBeginRenderPass(m_cmdBuffer->GetBufferHandle(), NULL, VK_RENDER_PASS_CONTENTS_INLINE); |
Tobin Ehlis | 98aa0ed | 2015-06-25 16:27:19 -0600 | [diff] [blame] | 1341 | |
| 1342 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1343 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after binding NULL RenderPass."; |
Tobin Ehlis | 98aa0ed | 2015-06-25 16:27:19 -0600 | [diff] [blame] | 1344 | if (!strstr(msgString.c_str(),"You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()")) { |
| 1345 | FAIL() << "Error received was not 'You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()'"; |
| 1346 | } |
| 1347 | } |
| 1348 | |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1349 | TEST_F(VkLayerTest, RenderPassWithinRenderPass) |
| 1350 | { |
| 1351 | // Bind a BeginRenderPass within an active RenderPass |
| 1352 | VkFlags msgFlags; |
| 1353 | std::string msgString; |
| 1354 | |
| 1355 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1356 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1357 | m_errorMonitor->ClearState(); |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1358 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1359 | BeginCommandBuffer(); |
Tobin Ehlis | 98aa0ed | 2015-06-25 16:27:19 -0600 | [diff] [blame] | 1360 | // Just create a dummy Renderpass that's non-NULL so we can get to the proper error |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1361 | VkRenderPassBeginInfo rp_begin = {}; |
| 1362 | rp_begin.sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO; |
| 1363 | rp_begin.pNext = NULL; |
| 1364 | rp_begin.renderPass = (VkRenderPass)0xc001d00d; |
| 1365 | rp_begin.framebuffer = 0; |
| 1366 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1367 | vkCmdBeginRenderPass(m_cmdBuffer->GetBufferHandle(), &rp_begin, VK_RENDER_PASS_CONTENTS_INLINE); |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1368 | |
| 1369 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1370 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after binding RenderPass w/i an active RenderPass."; |
Tobin Ehlis | af1f3a4 | 2015-06-25 15:46:59 -0600 | [diff] [blame] | 1371 | if (!strstr(msgString.c_str(),"Cannot call vkCmdBeginRenderPass() during an active RenderPass ")) { |
| 1372 | FAIL() << "Error received was not 'Cannot call vkCmdBeginRenderPass() during an active RenderPass...'"; |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1373 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1374 | } |
| 1375 | |
| 1376 | TEST_F(VkLayerTest, InvalidDynamicStateObject) |
| 1377 | { |
| 1378 | // Create a valid cmd buffer |
| 1379 | // call vkCmdBindDynamicStateObject w/ false DS Obj |
Tobin Ehlis | 7d1a711 | 2015-05-27 14:32:28 -0600 | [diff] [blame] | 1380 | // TODO : Simple check for bad object should be added to ObjectTracker to catch this case |
| 1381 | // The DS check for this is after driver has been called to validate DS internal data struct |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1382 | } |
Tobin Ehlis | 1056d45 | 2015-05-27 14:55:35 -0600 | [diff] [blame] | 1383 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1384 | TEST_F(VkLayerTest, VtxBufferNoRenderPass) |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1385 | { |
| 1386 | // Bind VBO out-of-bounds for given PSO |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1387 | VkFlags msgFlags; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1388 | std::string msgString; |
| 1389 | VkResult err; |
| 1390 | |
| 1391 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1392 | m_errorMonitor->ClearState(); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1393 | |
| 1394 | VkDescriptorTypeCount ds_type_count = {}; |
| 1395 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1396 | ds_type_count.count = 1; |
| 1397 | |
| 1398 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1399 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1400 | ds_pool_ci.pNext = NULL; |
| 1401 | ds_pool_ci.count = 1; |
| 1402 | ds_pool_ci.pTypeCount = &ds_type_count; |
| 1403 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1404 | VkDescriptorPool ds_pool; |
| 1405 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1406 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1407 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1408 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1409 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1410 | dsl_binding.arraySize = 1; |
| 1411 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1412 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1413 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1414 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1415 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1416 | ds_layout_ci.pNext = NULL; |
| 1417 | ds_layout_ci.count = 1; |
| 1418 | ds_layout_ci.pBinding = &dsl_binding; |
| 1419 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1420 | VkDescriptorSetLayout ds_layout; |
| 1421 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1422 | ASSERT_VK_SUCCESS(err); |
| 1423 | |
| 1424 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1425 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1426 | ASSERT_VK_SUCCESS(err); |
| 1427 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1428 | VkPipelineLayoutCreateInfo pipeline_layout_ci = {}; |
| 1429 | pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO; |
| 1430 | pipeline_layout_ci.pNext = NULL; |
| 1431 | pipeline_layout_ci.descriptorSetCount = 1; |
| 1432 | pipeline_layout_ci.pSetLayouts = &ds_layout; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1433 | |
| 1434 | VkPipelineLayout pipeline_layout; |
| 1435 | err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, &pipeline_layout); |
| 1436 | ASSERT_VK_SUCCESS(err); |
| 1437 | |
Courtney Goeltzenleuchter | ee4027d | 2015-06-28 13:01:17 -0600 | [diff] [blame] | 1438 | VkShaderObj vs(m_device, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX, this); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 1439 | VkShaderObj fs(m_device, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT, this); // TODO - We shouldn't need a fragment shader |
| 1440 | // but add it to be able to run on more devices |
Tony Barbour | c95e4ac | 2015-08-04 17:05:26 -0600 | [diff] [blame] | 1441 | VkPipelineObj pipe(m_device); |
| 1442 | pipe.AddShader(&vs); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 1443 | pipe.AddShader(&fs); |
Tony Barbour | c95e4ac | 2015-08-04 17:05:26 -0600 | [diff] [blame] | 1444 | pipe.CreateVKPipeline(pipeline_layout, renderPass()); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1445 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1446 | BeginCommandBuffer(); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1447 | ASSERT_VK_SUCCESS(err); |
Tony Barbour | c95e4ac | 2015-08-04 17:05:26 -0600 | [diff] [blame] | 1448 | vkCmdBindPipeline(m_cmdBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.handle()); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1449 | // Should error before calling to driver so don't care about actual data |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1450 | vkCmdBindVertexBuffers(m_cmdBuffer->GetBufferHandle(), 0, 1, NULL, NULL); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1451 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1452 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1453 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after vkCmdBindVertexBuffers() w/o active RenderPass."; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1454 | if (!strstr(msgString.c_str(),"Incorrect call to vkCmdBindVertexBuffers() without an active RenderPass.")) { |
| 1455 | FAIL() << "Error received was not 'Incorrect call to vkCmdBindVertexBuffers() without an active RenderPass.'"; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1456 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1457 | } |
| 1458 | |
| 1459 | TEST_F(VkLayerTest, DSTypeMismatch) |
| 1460 | { |
| 1461 | // Create DS w/ layout of one type and attempt Update w/ mis-matched type |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1462 | VkFlags msgFlags; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1463 | std::string msgString; |
| 1464 | VkResult err; |
| 1465 | |
| 1466 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1467 | m_errorMonitor->ClearState(); |
| 1468 | //VkDescriptorSetObj descriptorSet(m_device); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1469 | VkDescriptorTypeCount ds_type_count = {}; |
| 1470 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1471 | ds_type_count.count = 1; |
| 1472 | |
| 1473 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1474 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1475 | ds_pool_ci.pNext = NULL; |
| 1476 | ds_pool_ci.count = 1; |
| 1477 | ds_pool_ci.pTypeCount = &ds_type_count; |
| 1478 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1479 | VkDescriptorPool ds_pool; |
| 1480 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1481 | ASSERT_VK_SUCCESS(err); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1482 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1483 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1484 | dsl_binding.arraySize = 1; |
| 1485 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1486 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1487 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1488 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1489 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1490 | ds_layout_ci.pNext = NULL; |
| 1491 | ds_layout_ci.count = 1; |
| 1492 | ds_layout_ci.pBinding = &dsl_binding; |
| 1493 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1494 | VkDescriptorSetLayout ds_layout; |
| 1495 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1496 | ASSERT_VK_SUCCESS(err); |
| 1497 | |
| 1498 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1499 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1500 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1501 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1502 | VkSamplerCreateInfo sampler_ci = {}; |
| 1503 | sampler_ci.sType = VK_STRUCTURE_TYPE_SAMPLER_CREATE_INFO; |
| 1504 | sampler_ci.pNext = NULL; |
| 1505 | sampler_ci.magFilter = VK_TEX_FILTER_NEAREST; |
| 1506 | sampler_ci.minFilter = VK_TEX_FILTER_NEAREST; |
| 1507 | sampler_ci.mipMode = VK_TEX_MIPMAP_MODE_BASE; |
| 1508 | sampler_ci.addressU = VK_TEX_ADDRESS_CLAMP; |
| 1509 | sampler_ci.addressV = VK_TEX_ADDRESS_CLAMP; |
| 1510 | sampler_ci.addressW = VK_TEX_ADDRESS_CLAMP; |
| 1511 | sampler_ci.mipLodBias = 1.0; |
| 1512 | sampler_ci.maxAnisotropy = 1; |
| 1513 | sampler_ci.compareEnable = VK_FALSE; |
| 1514 | sampler_ci.compareOp = VK_COMPARE_OP_NEVER; |
| 1515 | sampler_ci.minLod = 1.0; |
| 1516 | sampler_ci.maxLod = 1.0; |
| 1517 | sampler_ci.borderColor = VK_BORDER_COLOR_FLOAT_OPAQUE_WHITE; |
Cody Northrop | ab1f9e2 | 2015-08-11 15:50:55 -0600 | [diff] [blame] | 1518 | sampler_ci.texelCoords = VK_FALSE; |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1519 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1520 | VkSampler sampler; |
| 1521 | err = vkCreateSampler(m_device->device(), &sampler_ci, &sampler); |
| 1522 | ASSERT_VK_SUCCESS(err); |
| 1523 | |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1524 | VkDescriptorInfo descriptor_info; |
| 1525 | memset(&descriptor_info, 0, sizeof(descriptor_info)); |
| 1526 | descriptor_info.sampler = sampler; |
| 1527 | |
| 1528 | VkWriteDescriptorSet descriptor_write; |
| 1529 | memset(&descriptor_write, 0, sizeof(descriptor_write)); |
| 1530 | descriptor_write.sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET; |
| 1531 | descriptor_write.destSet = descriptorSet; |
| 1532 | descriptor_write.count = 1; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1533 | // This is a mismatched type for the layout which expects BUFFER |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1534 | descriptor_write.descriptorType = VK_DESCRIPTOR_TYPE_SAMPLER; |
| 1535 | descriptor_write.pDescriptors = &descriptor_info; |
| 1536 | |
| 1537 | vkUpdateDescriptorSets(m_device->device(), 1, &descriptor_write, 0, NULL); |
| 1538 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1539 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1540 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after updating BUFFER Descriptor w/ incorrect type of SAMPLER."; |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1541 | if (!strstr(msgString.c_str(),"Descriptor update type of VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET does not match ")) { |
| 1542 | FAIL() << "Error received was not 'Descriptor update type of VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET does not match overlapping binding type!'"; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1543 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1544 | } |
| 1545 | |
| 1546 | TEST_F(VkLayerTest, DSUpdateOutOfBounds) |
| 1547 | { |
| 1548 | // For overlapping Update, have arrayIndex exceed that of layout |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1549 | VkFlags msgFlags; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1550 | std::string msgString; |
| 1551 | VkResult err; |
| 1552 | |
| 1553 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1554 | m_errorMonitor->ClearState(); |
| 1555 | //VkDescriptorSetObj descriptorSet(m_device); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1556 | VkDescriptorTypeCount ds_type_count = {}; |
| 1557 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1558 | ds_type_count.count = 1; |
| 1559 | |
| 1560 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1561 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1562 | ds_pool_ci.pNext = NULL; |
| 1563 | ds_pool_ci.count = 1; |
| 1564 | ds_pool_ci.pTypeCount = &ds_type_count; |
| 1565 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1566 | VkDescriptorPool ds_pool; |
| 1567 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1568 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1569 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1570 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1571 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1572 | dsl_binding.arraySize = 1; |
| 1573 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1574 | dsl_binding.pImmutableSamplers = NULL; |
| 1575 | |
| 1576 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1577 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1578 | ds_layout_ci.pNext = NULL; |
| 1579 | ds_layout_ci.count = 1; |
| 1580 | ds_layout_ci.pBinding = &dsl_binding; |
| 1581 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1582 | VkDescriptorSetLayout ds_layout; |
| 1583 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1584 | ASSERT_VK_SUCCESS(err); |
| 1585 | |
| 1586 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1587 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1588 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1589 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1590 | VkSamplerCreateInfo sampler_ci = {}; |
| 1591 | sampler_ci.sType = VK_STRUCTURE_TYPE_SAMPLER_CREATE_INFO; |
| 1592 | sampler_ci.pNext = NULL; |
| 1593 | sampler_ci.magFilter = VK_TEX_FILTER_NEAREST; |
| 1594 | sampler_ci.minFilter = VK_TEX_FILTER_NEAREST; |
| 1595 | sampler_ci.mipMode = VK_TEX_MIPMAP_MODE_BASE; |
| 1596 | sampler_ci.addressU = VK_TEX_ADDRESS_CLAMP; |
| 1597 | sampler_ci.addressV = VK_TEX_ADDRESS_CLAMP; |
| 1598 | sampler_ci.addressW = VK_TEX_ADDRESS_CLAMP; |
| 1599 | sampler_ci.mipLodBias = 1.0; |
| 1600 | sampler_ci.maxAnisotropy = 1; |
| 1601 | sampler_ci.compareEnable = VK_FALSE; |
| 1602 | sampler_ci.compareOp = VK_COMPARE_OP_NEVER; |
| 1603 | sampler_ci.minLod = 1.0; |
| 1604 | sampler_ci.maxLod = 1.0; |
| 1605 | sampler_ci.borderColor = VK_BORDER_COLOR_FLOAT_OPAQUE_WHITE; |
Cody Northrop | ab1f9e2 | 2015-08-11 15:50:55 -0600 | [diff] [blame] | 1606 | sampler_ci.texelCoords = VK_FALSE; |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1607 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1608 | VkSampler sampler; |
| 1609 | err = vkCreateSampler(m_device->device(), &sampler_ci, &sampler); |
| 1610 | ASSERT_VK_SUCCESS(err); |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1611 | |
| 1612 | VkDescriptorInfo descriptor_info; |
| 1613 | memset(&descriptor_info, 0, sizeof(descriptor_info)); |
| 1614 | descriptor_info.sampler = sampler; |
| 1615 | |
| 1616 | VkWriteDescriptorSet descriptor_write; |
| 1617 | memset(&descriptor_write, 0, sizeof(descriptor_write)); |
| 1618 | descriptor_write.sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET; |
| 1619 | descriptor_write.destSet = descriptorSet; |
| 1620 | descriptor_write.destArrayElement = 1; /* This index out of bounds for the update */ |
| 1621 | descriptor_write.count = 1; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1622 | // This is the wrong type, but out of bounds will be flagged first |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1623 | descriptor_write.descriptorType = VK_DESCRIPTOR_TYPE_SAMPLER; |
| 1624 | descriptor_write.pDescriptors = &descriptor_info; |
| 1625 | |
| 1626 | vkUpdateDescriptorSets(m_device->device(), 1, &descriptor_write, 0, NULL); |
| 1627 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1628 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1629 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after updating Descriptor w/ index out of bounds."; |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1630 | if (!strstr(msgString.c_str(),"Descriptor update type of VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET is out of bounds for matching binding")) { |
| 1631 | FAIL() << "Error received was not 'Descriptor update type of VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET is out of bounds for matching binding...'"; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1632 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1633 | } |
| 1634 | |
| 1635 | TEST_F(VkLayerTest, InvalidDSUpdateIndex) |
| 1636 | { |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1637 | // Create layout w/ count of 1 and attempt update to that layout w/ binding index 2 |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1638 | VkFlags msgFlags; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1639 | std::string msgString; |
| 1640 | VkResult err; |
| 1641 | |
| 1642 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1643 | m_errorMonitor->ClearState(); |
| 1644 | //VkDescriptorSetObj descriptorSet(m_device); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1645 | VkDescriptorTypeCount ds_type_count = {}; |
| 1646 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1647 | ds_type_count.count = 1; |
| 1648 | |
| 1649 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1650 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1651 | ds_pool_ci.pNext = NULL; |
| 1652 | ds_pool_ci.count = 1; |
| 1653 | ds_pool_ci.pTypeCount = &ds_type_count; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1654 | VkDescriptorPool ds_pool; |
| 1655 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1656 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1657 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1658 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1659 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1660 | dsl_binding.arraySize = 1; |
| 1661 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1662 | dsl_binding.pImmutableSamplers = NULL; |
| 1663 | |
| 1664 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1665 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1666 | ds_layout_ci.pNext = NULL; |
| 1667 | ds_layout_ci.count = 1; |
| 1668 | ds_layout_ci.pBinding = &dsl_binding; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1669 | VkDescriptorSetLayout ds_layout; |
| 1670 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1671 | ASSERT_VK_SUCCESS(err); |
| 1672 | |
| 1673 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1674 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1675 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1676 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1677 | VkSamplerCreateInfo sampler_ci = {}; |
| 1678 | sampler_ci.sType = VK_STRUCTURE_TYPE_SAMPLER_CREATE_INFO; |
| 1679 | sampler_ci.pNext = NULL; |
| 1680 | sampler_ci.magFilter = VK_TEX_FILTER_NEAREST; |
| 1681 | sampler_ci.minFilter = VK_TEX_FILTER_NEAREST; |
| 1682 | sampler_ci.mipMode = VK_TEX_MIPMAP_MODE_BASE; |
| 1683 | sampler_ci.addressU = VK_TEX_ADDRESS_CLAMP; |
| 1684 | sampler_ci.addressV = VK_TEX_ADDRESS_CLAMP; |
| 1685 | sampler_ci.addressW = VK_TEX_ADDRESS_CLAMP; |
| 1686 | sampler_ci.mipLodBias = 1.0; |
| 1687 | sampler_ci.maxAnisotropy = 1; |
| 1688 | sampler_ci.compareEnable = VK_FALSE; |
| 1689 | sampler_ci.compareOp = VK_COMPARE_OP_NEVER; |
| 1690 | sampler_ci.minLod = 1.0; |
| 1691 | sampler_ci.maxLod = 1.0; |
| 1692 | sampler_ci.borderColor = VK_BORDER_COLOR_FLOAT_OPAQUE_WHITE; |
Cody Northrop | ab1f9e2 | 2015-08-11 15:50:55 -0600 | [diff] [blame] | 1693 | sampler_ci.texelCoords = VK_FALSE; |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1694 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1695 | VkSampler sampler; |
| 1696 | err = vkCreateSampler(m_device->device(), &sampler_ci, &sampler); |
| 1697 | ASSERT_VK_SUCCESS(err); |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1698 | |
| 1699 | VkDescriptorInfo descriptor_info; |
| 1700 | memset(&descriptor_info, 0, sizeof(descriptor_info)); |
| 1701 | descriptor_info.sampler = sampler; |
| 1702 | |
| 1703 | VkWriteDescriptorSet descriptor_write; |
| 1704 | memset(&descriptor_write, 0, sizeof(descriptor_write)); |
| 1705 | descriptor_write.sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET; |
| 1706 | descriptor_write.destSet = descriptorSet; |
| 1707 | descriptor_write.destBinding = 2; |
| 1708 | descriptor_write.count = 1; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1709 | // This is the wrong type, but out of bounds will be flagged first |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1710 | descriptor_write.descriptorType = VK_DESCRIPTOR_TYPE_SAMPLER; |
| 1711 | descriptor_write.pDescriptors = &descriptor_info; |
| 1712 | |
| 1713 | vkUpdateDescriptorSets(m_device->device(), 1, &descriptor_write, 0, NULL); |
| 1714 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1715 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1716 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after updating Descriptor w/ count too large for layout."; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1717 | if (!strstr(msgString.c_str()," does not have binding to match update binding ")) { |
| 1718 | FAIL() << "Error received was not 'Descriptor Set <blah> does not have binding to match update binding '"; |
| 1719 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1720 | } |
| 1721 | |
| 1722 | TEST_F(VkLayerTest, InvalidDSUpdateStruct) |
| 1723 | { |
| 1724 | // Call UpdateDS w/ struct type other than valid VK_STRUCTUR_TYPE_UPDATE_* types |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1725 | VkFlags msgFlags; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1726 | std::string msgString; |
| 1727 | VkResult err; |
| 1728 | |
| 1729 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1730 | m_errorMonitor->ClearState(); |
| 1731 | //VkDescriptorSetObj descriptorSet(m_device); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1732 | |
| 1733 | VkDescriptorTypeCount ds_type_count = {}; |
| 1734 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1735 | ds_type_count.count = 1; |
| 1736 | |
| 1737 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1738 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1739 | ds_pool_ci.pNext = NULL; |
| 1740 | ds_pool_ci.count = 1; |
| 1741 | ds_pool_ci.pTypeCount = &ds_type_count; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1742 | VkDescriptorPool ds_pool; |
| 1743 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1744 | ASSERT_VK_SUCCESS(err); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1745 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1746 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1747 | dsl_binding.arraySize = 1; |
| 1748 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1749 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1750 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1751 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1752 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1753 | ds_layout_ci.pNext = NULL; |
| 1754 | ds_layout_ci.count = 1; |
| 1755 | ds_layout_ci.pBinding = &dsl_binding; |
| 1756 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1757 | VkDescriptorSetLayout ds_layout; |
| 1758 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1759 | ASSERT_VK_SUCCESS(err); |
| 1760 | |
| 1761 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1762 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1763 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1764 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1765 | VkSamplerCreateInfo sampler_ci = {}; |
| 1766 | sampler_ci.sType = VK_STRUCTURE_TYPE_SAMPLER_CREATE_INFO; |
| 1767 | sampler_ci.pNext = NULL; |
| 1768 | sampler_ci.magFilter = VK_TEX_FILTER_NEAREST; |
| 1769 | sampler_ci.minFilter = VK_TEX_FILTER_NEAREST; |
| 1770 | sampler_ci.mipMode = VK_TEX_MIPMAP_MODE_BASE; |
| 1771 | sampler_ci.addressU = VK_TEX_ADDRESS_CLAMP; |
| 1772 | sampler_ci.addressV = VK_TEX_ADDRESS_CLAMP; |
| 1773 | sampler_ci.addressW = VK_TEX_ADDRESS_CLAMP; |
| 1774 | sampler_ci.mipLodBias = 1.0; |
| 1775 | sampler_ci.maxAnisotropy = 1; |
| 1776 | sampler_ci.compareEnable = VK_FALSE; |
| 1777 | sampler_ci.compareOp = VK_COMPARE_OP_NEVER; |
| 1778 | sampler_ci.minLod = 1.0; |
| 1779 | sampler_ci.maxLod = 1.0; |
| 1780 | sampler_ci.borderColor = VK_BORDER_COLOR_FLOAT_OPAQUE_WHITE; |
Cody Northrop | ab1f9e2 | 2015-08-11 15:50:55 -0600 | [diff] [blame] | 1781 | sampler_ci.texelCoords = VK_FALSE; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1782 | VkSampler sampler; |
| 1783 | err = vkCreateSampler(m_device->device(), &sampler_ci, &sampler); |
| 1784 | ASSERT_VK_SUCCESS(err); |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1785 | |
| 1786 | |
| 1787 | VkDescriptorInfo descriptor_info; |
| 1788 | memset(&descriptor_info, 0, sizeof(descriptor_info)); |
| 1789 | descriptor_info.sampler = sampler; |
| 1790 | |
| 1791 | VkWriteDescriptorSet descriptor_write; |
| 1792 | memset(&descriptor_write, 0, sizeof(descriptor_write)); |
| 1793 | descriptor_write.sType = (VkStructureType)0x99999999; /* Intentionally broken struct type */ |
| 1794 | descriptor_write.destSet = descriptorSet; |
| 1795 | descriptor_write.count = 1; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1796 | // This is the wrong type, but out of bounds will be flagged first |
Chia-I Wu | 9d00ed7 | 2015-05-25 16:27:55 +0800 | [diff] [blame] | 1797 | descriptor_write.descriptorType = VK_DESCRIPTOR_TYPE_SAMPLER; |
| 1798 | descriptor_write.pDescriptors = &descriptor_info; |
| 1799 | |
| 1800 | vkUpdateDescriptorSets(m_device->device(), 1, &descriptor_write, 0, NULL); |
| 1801 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1802 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1803 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after updating Descriptor w/ invalid struct type."; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1804 | if (!strstr(msgString.c_str(),"Unexpected UPDATE struct of type ")) { |
| 1805 | FAIL() << "Error received was not 'Unexpected UPDATE struct of type '"; |
| 1806 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1807 | } |
| 1808 | |
| 1809 | TEST_F(VkLayerTest, NumSamplesMismatch) |
| 1810 | { |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1811 | // Create CmdBuffer where MSAA samples doesn't match RenderPass sampleCount |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1812 | VkFlags msgFlags; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1813 | std::string msgString; |
| 1814 | VkResult err; |
| 1815 | |
| 1816 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1817 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1818 | m_errorMonitor->ClearState(); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1819 | VkDescriptorTypeCount ds_type_count = {}; |
| 1820 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1821 | ds_type_count.count = 1; |
| 1822 | |
| 1823 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1824 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1825 | ds_pool_ci.pNext = NULL; |
| 1826 | ds_pool_ci.count = 1; |
| 1827 | ds_pool_ci.pTypeCount = &ds_type_count; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1828 | VkDescriptorPool ds_pool; |
| 1829 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1830 | ASSERT_VK_SUCCESS(err); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1831 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1832 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1833 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1834 | dsl_binding.arraySize = 1; |
| 1835 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1836 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1837 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1838 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1839 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1840 | ds_layout_ci.pNext = NULL; |
| 1841 | ds_layout_ci.count = 1; |
| 1842 | ds_layout_ci.pBinding = &dsl_binding; |
| 1843 | |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1844 | VkDescriptorSetLayout ds_layout; |
| 1845 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1846 | ASSERT_VK_SUCCESS(err); |
| 1847 | |
| 1848 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1849 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1850 | ASSERT_VK_SUCCESS(err); |
| 1851 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1852 | VkPipelineMultisampleStateCreateInfo pipe_ms_state_ci = {}; |
| 1853 | pipe_ms_state_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO; |
| 1854 | pipe_ms_state_ci.pNext = NULL; |
| 1855 | pipe_ms_state_ci.rasterSamples = 4; |
| 1856 | pipe_ms_state_ci.sampleShadingEnable = 0; |
| 1857 | pipe_ms_state_ci.minSampleShading = 1.0; |
Cody Northrop | 02e61ed | 2015-08-04 14:34:54 -0600 | [diff] [blame] | 1858 | pipe_ms_state_ci.pSampleMask = NULL; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1859 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1860 | VkPipelineLayoutCreateInfo pipeline_layout_ci = {}; |
| 1861 | pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO; |
| 1862 | pipeline_layout_ci.pNext = NULL; |
| 1863 | pipeline_layout_ci.descriptorSetCount = 1; |
| 1864 | pipeline_layout_ci.pSetLayouts = &ds_layout; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1865 | |
| 1866 | VkPipelineLayout pipeline_layout; |
| 1867 | err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, &pipeline_layout); |
| 1868 | ASSERT_VK_SUCCESS(err); |
| 1869 | |
Courtney Goeltzenleuchter | ee4027d | 2015-06-28 13:01:17 -0600 | [diff] [blame] | 1870 | VkShaderObj vs(m_device, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX, this); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 1871 | VkShaderObj fs(m_device, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT, this); // TODO - We shouldn't need a fragment shader |
| 1872 | // but add it to be able to run on more devices |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 1873 | VkPipelineObj pipe(m_device); |
| 1874 | pipe.AddShader(&vs); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 1875 | pipe.AddShader(&fs); |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 1876 | pipe.SetMSAA(&pipe_ms_state_ci); |
| 1877 | pipe.CreateVKPipeline(pipeline_layout, renderPass()); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1878 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1879 | BeginCommandBuffer(); |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 1880 | vkCmdBindPipeline(m_cmdBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.handle()); |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1881 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 1882 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1883 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after binding RenderPass w/ mismatched MSAA from PSO."; |
Tobin Ehlis | 3b78066 | 2015-05-28 12:11:26 -0600 | [diff] [blame] | 1884 | if (!strstr(msgString.c_str(),"Num samples mismatch! ")) { |
| 1885 | FAIL() << "Error received was not 'Num samples mismatch!...'"; |
| 1886 | } |
Tobin Ehlis | 49eb23d | 2015-05-22 12:38:55 -0600 | [diff] [blame] | 1887 | } |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 1888 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1889 | TEST_F(VkLayerTest, PipelineNotBound) |
| 1890 | { |
| 1891 | VkFlags msgFlags; |
| 1892 | std::string msgString; |
| 1893 | VkResult err; |
| 1894 | |
| 1895 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1896 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1897 | m_errorMonitor->ClearState(); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1898 | |
| 1899 | VkDescriptorTypeCount ds_type_count = {}; |
| 1900 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1901 | ds_type_count.count = 1; |
| 1902 | |
| 1903 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1904 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1905 | ds_pool_ci.pNext = NULL; |
| 1906 | ds_pool_ci.count = 1; |
| 1907 | ds_pool_ci.pTypeCount = &ds_type_count; |
| 1908 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1909 | VkDescriptorPool ds_pool; |
| 1910 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1911 | ASSERT_VK_SUCCESS(err); |
| 1912 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1913 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1914 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1915 | dsl_binding.arraySize = 1; |
| 1916 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1917 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1918 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1919 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1920 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1921 | ds_layout_ci.pNext = NULL; |
| 1922 | ds_layout_ci.count = 1; |
| 1923 | ds_layout_ci.pBinding = &dsl_binding; |
| 1924 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1925 | VkDescriptorSetLayout ds_layout; |
| 1926 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1927 | ASSERT_VK_SUCCESS(err); |
| 1928 | |
| 1929 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1930 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1931 | ASSERT_VK_SUCCESS(err); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1932 | |
| 1933 | VkPipelineLayoutCreateInfo pipeline_layout_ci = {}; |
| 1934 | pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO; |
| 1935 | pipeline_layout_ci.pNext = NULL; |
| 1936 | pipeline_layout_ci.descriptorSetCount = 1; |
| 1937 | pipeline_layout_ci.pSetLayouts = &ds_layout; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1938 | |
| 1939 | VkPipelineLayout pipeline_layout; |
| 1940 | err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, &pipeline_layout); |
| 1941 | ASSERT_VK_SUCCESS(err); |
| 1942 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1943 | VkPipeline badPipeline = (VkPipeline)0xbaadb1be; |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 1944 | |
| 1945 | BeginCommandBuffer(); |
| 1946 | vkCmdBindPipeline(m_cmdBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, badPipeline); |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1947 | |
| 1948 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 1949 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after binding invalid pipeline to CmdBuffer"; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 1950 | if (!strstr(msgString.c_str(),"Attempt to bind Pipeline ")) { |
| 1951 | FAIL() << "Error received was not 'Attempt to bind Pipeline 0xbaadb1be that doesn't exist!'"; |
| 1952 | } |
| 1953 | } |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 1954 | |
| 1955 | TEST_F(VkLayerTest, ClearCmdNoDraw) |
| 1956 | { |
| 1957 | // Create CmdBuffer where we add ClearCmd for FB Color attachment prior to issuing a Draw |
| 1958 | VkFlags msgFlags; |
| 1959 | std::string msgString; |
| 1960 | VkResult err; |
| 1961 | |
| 1962 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 1963 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 1964 | m_errorMonitor->ClearState(); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1965 | |
| 1966 | VkDescriptorTypeCount ds_type_count = {}; |
| 1967 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1968 | ds_type_count.count = 1; |
| 1969 | |
| 1970 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 1971 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 1972 | ds_pool_ci.pNext = NULL; |
| 1973 | ds_pool_ci.count = 1; |
| 1974 | ds_pool_ci.pTypeCount = &ds_type_count; |
| 1975 | |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 1976 | VkDescriptorPool ds_pool; |
| 1977 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 1978 | ASSERT_VK_SUCCESS(err); |
| 1979 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1980 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 1981 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 1982 | dsl_binding.arraySize = 1; |
| 1983 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 1984 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 1985 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 1986 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 1987 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 1988 | ds_layout_ci.pNext = NULL; |
| 1989 | ds_layout_ci.count = 1; |
| 1990 | ds_layout_ci.pBinding = &dsl_binding; |
| 1991 | |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 1992 | VkDescriptorSetLayout ds_layout; |
| 1993 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 1994 | ASSERT_VK_SUCCESS(err); |
| 1995 | |
| 1996 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 1997 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 1998 | ASSERT_VK_SUCCESS(err); |
| 1999 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2000 | VkPipelineMultisampleStateCreateInfo pipe_ms_state_ci = {}; |
| 2001 | pipe_ms_state_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO; |
| 2002 | pipe_ms_state_ci.pNext = NULL; |
| 2003 | pipe_ms_state_ci.rasterSamples = 4; |
| 2004 | pipe_ms_state_ci.sampleShadingEnable = 0; |
| 2005 | pipe_ms_state_ci.minSampleShading = 1.0; |
Cody Northrop | 02e61ed | 2015-08-04 14:34:54 -0600 | [diff] [blame] | 2006 | pipe_ms_state_ci.pSampleMask = NULL; |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 2007 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2008 | VkPipelineLayoutCreateInfo pipeline_layout_ci = {}; |
| 2009 | pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO; |
| 2010 | pipeline_layout_ci.pNext = NULL; |
| 2011 | pipeline_layout_ci.descriptorSetCount = 1; |
| 2012 | pipeline_layout_ci.pSetLayouts = &ds_layout; |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 2013 | |
| 2014 | VkPipelineLayout pipeline_layout; |
| 2015 | err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, &pipeline_layout); |
| 2016 | ASSERT_VK_SUCCESS(err); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2017 | |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 2018 | VkShaderObj vs(m_device, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX, this); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 2019 | VkShaderObj fs(m_device, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT, this); // TODO - We shouldn't need a fragment shader |
| 2020 | // but add it to be able to run on more devices |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 2021 | VkPipelineObj pipe(m_device); |
| 2022 | pipe.AddShader(&vs); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 2023 | pipe.AddShader(&fs); |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 2024 | pipe.SetMSAA(&pipe_ms_state_ci); |
| 2025 | pipe.CreateVKPipeline(pipeline_layout, renderPass()); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2026 | |
| 2027 | BeginCommandBuffer(); |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 2028 | |
| 2029 | m_errorMonitor->ClearState(); |
| 2030 | // Main thing we care about for this test is that the VkImage obj we're clearing matches Color Attachment of FB |
| 2031 | // Also pass down other dummy params to keep driver and paramchecker happy |
| 2032 | VkClearColorValue cCV; |
| 2033 | cCV.f32[0] = 1.0; |
| 2034 | cCV.f32[1] = 1.0; |
| 2035 | cCV.f32[2] = 1.0; |
| 2036 | cCV.f32[3] = 1.0; |
| 2037 | |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2038 | vkCmdClearColorAttachment(m_cmdBuffer->GetBufferHandle(), 0, (VkImageLayout)NULL, &cCV, 0, NULL); |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 2039 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2040 | ASSERT_NE(0, msgFlags & VK_DBG_REPORT_WARN_BIT) << "Did not receive error after issuing Clear Cmd on FB color attachment prior to Draw Cmd."; |
Tobin Ehlis | 53eddda | 2015-07-01 16:46:13 -0600 | [diff] [blame] | 2041 | if (!strstr(msgString.c_str(),"vkCmdClearColorAttachment() issued on CB object ")) { |
| 2042 | FAIL() << "Error received was not 'vkCmdClearColorAttachment() issued on CB object...'"; |
| 2043 | } |
| 2044 | } |
| 2045 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2046 | TEST_F(VkLayerTest, VtxBufferBadIndex) |
| 2047 | { |
| 2048 | // Create CmdBuffer where MSAA samples doesn't match RenderPass sampleCount |
| 2049 | VkFlags msgFlags; |
| 2050 | std::string msgString; |
| 2051 | VkResult err; |
| 2052 | |
| 2053 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 2054 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2055 | m_errorMonitor->ClearState(); |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2056 | |
| 2057 | VkDescriptorTypeCount ds_type_count = {}; |
| 2058 | ds_type_count.type = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 2059 | ds_type_count.count = 1; |
| 2060 | |
| 2061 | VkDescriptorPoolCreateInfo ds_pool_ci = {}; |
| 2062 | ds_pool_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO; |
| 2063 | ds_pool_ci.pNext = NULL; |
| 2064 | ds_pool_ci.count = 1; |
| 2065 | ds_pool_ci.pTypeCount = &ds_type_count; |
| 2066 | |
| 2067 | VkDescriptorPool ds_pool; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2068 | err = vkCreateDescriptorPool(m_device->device(), VK_DESCRIPTOR_POOL_USAGE_ONE_SHOT, 1, &ds_pool_ci, &ds_pool); |
| 2069 | ASSERT_VK_SUCCESS(err); |
| 2070 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2071 | VkDescriptorSetLayoutBinding dsl_binding = {}; |
| 2072 | dsl_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER; |
| 2073 | dsl_binding.arraySize = 1; |
| 2074 | dsl_binding.stageFlags = VK_SHADER_STAGE_ALL; |
| 2075 | dsl_binding.pImmutableSamplers = NULL; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2076 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2077 | VkDescriptorSetLayoutCreateInfo ds_layout_ci = {}; |
| 2078 | ds_layout_ci.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO; |
| 2079 | ds_layout_ci.pNext = NULL; |
| 2080 | ds_layout_ci.count = 1; |
| 2081 | ds_layout_ci.pBinding = &dsl_binding; |
| 2082 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2083 | VkDescriptorSetLayout ds_layout; |
| 2084 | err = vkCreateDescriptorSetLayout(m_device->device(), &ds_layout_ci, &ds_layout); |
| 2085 | ASSERT_VK_SUCCESS(err); |
| 2086 | |
| 2087 | VkDescriptorSet descriptorSet; |
Cody Northrop | 1e4f802 | 2015-08-03 12:47:29 -0600 | [diff] [blame] | 2088 | err = vkAllocDescriptorSets(m_device->device(), ds_pool, VK_DESCRIPTOR_SET_USAGE_ONE_SHOT, 1, &ds_layout, &descriptorSet); |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2089 | ASSERT_VK_SUCCESS(err); |
| 2090 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2091 | VkPipelineMultisampleStateCreateInfo pipe_ms_state_ci = {}; |
| 2092 | pipe_ms_state_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO; |
| 2093 | pipe_ms_state_ci.pNext = NULL; |
| 2094 | pipe_ms_state_ci.rasterSamples = 1; |
| 2095 | pipe_ms_state_ci.sampleShadingEnable = 0; |
| 2096 | pipe_ms_state_ci.minSampleShading = 1.0; |
Cody Northrop | 02e61ed | 2015-08-04 14:34:54 -0600 | [diff] [blame] | 2097 | pipe_ms_state_ci.pSampleMask = NULL; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2098 | |
Tony Barbour | eb25490 | 2015-07-15 12:50:33 -0600 | [diff] [blame] | 2099 | VkPipelineLayoutCreateInfo pipeline_layout_ci = {}; |
| 2100 | pipeline_layout_ci.sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO; |
| 2101 | pipeline_layout_ci.pNext = NULL; |
| 2102 | pipeline_layout_ci.descriptorSetCount = 1; |
| 2103 | pipeline_layout_ci.pSetLayouts = &ds_layout; |
| 2104 | VkPipelineLayout pipeline_layout; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2105 | |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2106 | err = vkCreatePipelineLayout(m_device->device(), &pipeline_layout_ci, &pipeline_layout); |
| 2107 | ASSERT_VK_SUCCESS(err); |
| 2108 | |
Courtney Goeltzenleuchter | ee4027d | 2015-06-28 13:01:17 -0600 | [diff] [blame] | 2109 | VkShaderObj vs(m_device, bindStateVertShaderText, VK_SHADER_STAGE_VERTEX, this); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 2110 | VkShaderObj fs(m_device, bindStateFragShaderText, VK_SHADER_STAGE_FRAGMENT, this); // TODO - We shouldn't need a fragment shader |
| 2111 | // but add it to be able to run on more devices |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 2112 | VkPipelineObj pipe(m_device); |
| 2113 | pipe.AddShader(&vs); |
Tony Barbour | 1c94d37 | 2015-08-06 11:21:08 -0600 | [diff] [blame] | 2114 | pipe.AddShader(&fs); |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 2115 | pipe.SetMSAA(&pipe_ms_state_ci); |
| 2116 | pipe.CreateVKPipeline(pipeline_layout, renderPass()); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2117 | |
| 2118 | BeginCommandBuffer(); |
Tony Barbour | 62e1a5b | 2015-08-06 10:16:07 -0600 | [diff] [blame] | 2119 | vkCmdBindPipeline(m_cmdBuffer->GetBufferHandle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.handle()); |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2120 | // Should error before calling to driver so don't care about actual data |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2121 | vkCmdBindVertexBuffers(m_cmdBuffer->GetBufferHandle(), 0, 1, NULL, NULL); |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2122 | |
| 2123 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2124 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive error after binding Vtx Buffer w/o VBO attached to PSO."; |
Tobin Ehlis | 502480b | 2015-06-24 15:53:07 -0600 | [diff] [blame] | 2125 | if (!strstr(msgString.c_str(),"Vtx Buffer Index 0 was bound, but no vtx buffers are attached to PSO.")) { |
| 2126 | FAIL() << "Error received was not 'Vtx Buffer Index 0 was bound, but no vtx buffers are attached to PSO.'"; |
| 2127 | } |
| 2128 | } |
Tobin Ehlis | 0788f52 | 2015-05-26 16:11:58 -0600 | [diff] [blame] | 2129 | #endif |
| 2130 | #if THREADING_TESTS |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2131 | #if GTEST_IS_THREADSAFE |
| 2132 | struct thread_data_struct { |
| 2133 | VkCmdBuffer cmdBuffer; |
| 2134 | VkEvent event; |
| 2135 | bool bailout; |
| 2136 | }; |
| 2137 | |
| 2138 | extern "C" void *AddToCommandBuffer(void *arg) |
| 2139 | { |
| 2140 | struct thread_data_struct *data = (struct thread_data_struct *) arg; |
| 2141 | std::string msgString; |
| 2142 | |
| 2143 | for (int i = 0; i<10000; i++) { |
Tony Barbour | 0b2cfb2 | 2015-06-29 16:20:35 -0600 | [diff] [blame] | 2144 | vkCmdSetEvent(data->cmdBuffer, data->event, VK_PIPELINE_STAGE_ALL_GPU_COMMANDS); |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2145 | if (data->bailout) { |
| 2146 | break; |
| 2147 | } |
| 2148 | } |
| 2149 | return NULL; |
| 2150 | } |
| 2151 | |
| 2152 | TEST_F(VkLayerTest, ThreadCmdBufferCollision) |
| 2153 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2154 | VkFlags msgFlags; |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2155 | std::string msgString; |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 2156 | test_platform_thread thread; |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2157 | |
| 2158 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 2159 | ASSERT_NO_FATAL_FAILURE(InitViewport()); |
| 2160 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
| 2161 | |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2162 | m_errorMonitor->ClearState(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2163 | BeginCommandBuffer(); |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2164 | |
| 2165 | VkEventCreateInfo event_info; |
| 2166 | VkEvent event; |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2167 | VkResult err; |
| 2168 | |
| 2169 | memset(&event_info, 0, sizeof(event_info)); |
| 2170 | event_info.sType = VK_STRUCTURE_TYPE_EVENT_CREATE_INFO; |
| 2171 | |
| 2172 | err = vkCreateEvent(device(), &event_info, &event); |
| 2173 | ASSERT_VK_SUCCESS(err); |
| 2174 | |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2175 | err = vkResetEvent(device(), event); |
| 2176 | ASSERT_VK_SUCCESS(err); |
| 2177 | |
| 2178 | struct thread_data_struct data; |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2179 | data.cmdBuffer = m_cmdBuffer->handle(); |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2180 | data.event = event; |
| 2181 | data.bailout = false; |
| 2182 | m_errorMonitor->SetBailout(&data.bailout); |
| 2183 | // Add many entries to command buffer from another thread. |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 2184 | test_platform_thread_create(&thread, AddToCommandBuffer, (void *)&data); |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2185 | // Add many entries to command buffer from this thread at the same time. |
| 2186 | AddToCommandBuffer(&data); |
Mike Stroyan | 4268d1f | 2015-07-13 14:45:35 -0600 | [diff] [blame] | 2187 | test_platform_thread_join(thread, NULL); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2188 | EndCommandBuffer(); |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2189 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2190 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2191 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)) << "Did not receive an err from using one VkCommandBufferObj in two threads"; |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2192 | if (!strstr(msgString.c_str(),"THREADING ERROR")) { |
Mark Lobodzinski | 3780e14 | 2015-05-14 15:08:13 -0500 | [diff] [blame] | 2193 | FAIL() << "Error received was not 'THREADING ERROR'"; |
Mike Stroyan | accf769 | 2015-05-12 16:00:45 -0600 | [diff] [blame] | 2194 | } |
| 2195 | |
| 2196 | } |
| 2197 | #endif |
Tobin Ehlis | 0788f52 | 2015-05-26 16:11:58 -0600 | [diff] [blame] | 2198 | #endif |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2199 | #if SHADER_CHECKER_TESTS |
| 2200 | TEST_F(VkLayerTest, CreatePipelineVertexOutputNotConsumed) |
| 2201 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2202 | VkFlags msgFlags; |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2203 | std::string msgString; |
| 2204 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2205 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2206 | |
| 2207 | char const *vsSource = |
| 2208 | "#version 140\n" |
| 2209 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2210 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2211 | "\n" |
| 2212 | "layout(location=0) out float x;\n" |
| 2213 | "void main(){\n" |
| 2214 | " gl_Position = vec4(1);\n" |
| 2215 | " x = 0;\n" |
| 2216 | "}\n"; |
| 2217 | char const *fsSource = |
| 2218 | "#version 140\n" |
| 2219 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2220 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2221 | "\n" |
| 2222 | "layout(location=0) out vec4 color;\n" |
| 2223 | "void main(){\n" |
| 2224 | " color = vec4(1);\n" |
| 2225 | "}\n"; |
| 2226 | |
| 2227 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2228 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2229 | |
| 2230 | VkPipelineObj pipe(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2231 | pipe.AddColorAttachment(); |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2232 | pipe.AddShader(&vs); |
| 2233 | pipe.AddShader(&fs); |
| 2234 | |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2235 | VkDescriptorSetObj descriptorSet(m_device); |
| 2236 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2237 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2238 | |
| 2239 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2240 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2241 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2242 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2243 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2244 | ASSERT_NE(0, msgFlags & VK_DBG_REPORT_WARN_BIT); |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2245 | if (!strstr(msgString.c_str(),"not consumed by fragment shader")) { |
| 2246 | FAIL() << "Incorrect warning: " << msgString; |
| 2247 | } |
| 2248 | } |
Chris Forbes | 9f7ff63 | 2015-05-25 11:13:08 +1200 | [diff] [blame] | 2249 | |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2250 | TEST_F(VkLayerTest, CreatePipelineFragmentInputNotProvided) |
| 2251 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2252 | VkFlags msgFlags; |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2253 | std::string msgString; |
| 2254 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2255 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2256 | |
| 2257 | char const *vsSource = |
| 2258 | "#version 140\n" |
| 2259 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2260 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2261 | "\n" |
| 2262 | "void main(){\n" |
| 2263 | " gl_Position = vec4(1);\n" |
| 2264 | "}\n"; |
| 2265 | char const *fsSource = |
| 2266 | "#version 140\n" |
| 2267 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2268 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2269 | "\n" |
| 2270 | "layout(location=0) in float x;\n" |
| 2271 | "layout(location=0) out vec4 color;\n" |
| 2272 | "void main(){\n" |
| 2273 | " color = vec4(x);\n" |
| 2274 | "}\n"; |
| 2275 | |
| 2276 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2277 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2278 | |
| 2279 | VkPipelineObj pipe(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2280 | pipe.AddColorAttachment(); |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2281 | pipe.AddShader(&vs); |
| 2282 | pipe.AddShader(&fs); |
| 2283 | |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2284 | VkDescriptorSetObj descriptorSet(m_device); |
| 2285 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2286 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2287 | |
| 2288 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2289 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2290 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2291 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2292 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2293 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)); |
Chris Forbes | 59cb88d | 2015-05-25 11:13:13 +1200 | [diff] [blame] | 2294 | if (!strstr(msgString.c_str(),"not written by vertex shader")) { |
| 2295 | FAIL() << "Incorrect error: " << msgString; |
| 2296 | } |
| 2297 | } |
| 2298 | |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2299 | TEST_F(VkLayerTest, CreatePipelineVsFsTypeMismatch) |
| 2300 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2301 | VkFlags msgFlags; |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2302 | std::string msgString; |
| 2303 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2304 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2305 | |
| 2306 | char const *vsSource = |
| 2307 | "#version 140\n" |
| 2308 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2309 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2310 | "\n" |
| 2311 | "layout(location=0) out int x;\n" |
| 2312 | "void main(){\n" |
| 2313 | " x = 0;\n" |
| 2314 | " gl_Position = vec4(1);\n" |
| 2315 | "}\n"; |
| 2316 | char const *fsSource = |
| 2317 | "#version 140\n" |
| 2318 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2319 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2320 | "\n" |
| 2321 | "layout(location=0) in float x;\n" /* VS writes int */ |
| 2322 | "layout(location=0) out vec4 color;\n" |
| 2323 | "void main(){\n" |
| 2324 | " color = vec4(x);\n" |
| 2325 | "}\n"; |
| 2326 | |
| 2327 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2328 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2329 | |
| 2330 | VkPipelineObj pipe(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2331 | pipe.AddColorAttachment(); |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2332 | pipe.AddShader(&vs); |
| 2333 | pipe.AddShader(&fs); |
| 2334 | |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2335 | VkDescriptorSetObj descriptorSet(m_device); |
| 2336 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2337 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2338 | |
| 2339 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2340 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2341 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2342 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2343 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2344 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)); |
Chris Forbes | b56af56 | 2015-05-25 11:13:17 +1200 | [diff] [blame] | 2345 | if (!strstr(msgString.c_str(),"Type mismatch on location 0")) { |
| 2346 | FAIL() << "Incorrect error: " << msgString; |
| 2347 | } |
| 2348 | } |
| 2349 | |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2350 | TEST_F(VkLayerTest, CreatePipelineAttribNotConsumed) |
| 2351 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2352 | VkFlags msgFlags; |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2353 | std::string msgString; |
| 2354 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2355 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2356 | |
| 2357 | VkVertexInputBindingDescription input_binding; |
| 2358 | memset(&input_binding, 0, sizeof(input_binding)); |
| 2359 | |
| 2360 | VkVertexInputAttributeDescription input_attrib; |
| 2361 | memset(&input_attrib, 0, sizeof(input_attrib)); |
| 2362 | input_attrib.format = VK_FORMAT_R32_SFLOAT; |
| 2363 | |
| 2364 | char const *vsSource = |
| 2365 | "#version 140\n" |
| 2366 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2367 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2368 | "\n" |
| 2369 | "void main(){\n" |
| 2370 | " gl_Position = vec4(1);\n" |
| 2371 | "}\n"; |
| 2372 | char const *fsSource = |
| 2373 | "#version 140\n" |
| 2374 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2375 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2376 | "\n" |
| 2377 | "layout(location=0) out vec4 color;\n" |
| 2378 | "void main(){\n" |
| 2379 | " color = vec4(1);\n" |
| 2380 | "}\n"; |
| 2381 | |
| 2382 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2383 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2384 | |
| 2385 | VkPipelineObj pipe(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2386 | pipe.AddColorAttachment(); |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2387 | pipe.AddShader(&vs); |
| 2388 | pipe.AddShader(&fs); |
| 2389 | |
| 2390 | pipe.AddVertexInputBindings(&input_binding, 1); |
| 2391 | pipe.AddVertexInputAttribs(&input_attrib, 1); |
| 2392 | |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2393 | VkDescriptorSetObj descriptorSet(m_device); |
| 2394 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2395 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2396 | |
| 2397 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2398 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2399 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2400 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2401 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2402 | ASSERT_NE(0, msgFlags & VK_DBG_REPORT_WARN_BIT); |
Chris Forbes | de136e0 | 2015-05-25 11:13:28 +1200 | [diff] [blame] | 2403 | if (!strstr(msgString.c_str(),"location 0 not consumed by VS")) { |
| 2404 | FAIL() << "Incorrect warning: " << msgString; |
| 2405 | } |
| 2406 | } |
| 2407 | |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2408 | TEST_F(VkLayerTest, CreatePipelineAttribNotProvided) |
| 2409 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2410 | VkFlags msgFlags; |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2411 | std::string msgString; |
| 2412 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2413 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2414 | |
| 2415 | char const *vsSource = |
| 2416 | "#version 140\n" |
| 2417 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2418 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2419 | "\n" |
| 2420 | "layout(location=0) in vec4 x;\n" /* not provided */ |
| 2421 | "void main(){\n" |
| 2422 | " gl_Position = x;\n" |
| 2423 | "}\n"; |
| 2424 | char const *fsSource = |
| 2425 | "#version 140\n" |
| 2426 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2427 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2428 | "\n" |
| 2429 | "layout(location=0) out vec4 color;\n" |
| 2430 | "void main(){\n" |
| 2431 | " color = vec4(1);\n" |
| 2432 | "}\n"; |
| 2433 | |
| 2434 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2435 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2436 | |
| 2437 | VkPipelineObj pipe(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2438 | pipe.AddColorAttachment(); |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2439 | pipe.AddShader(&vs); |
| 2440 | pipe.AddShader(&fs); |
| 2441 | |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2442 | VkDescriptorSetObj descriptorSet(m_device); |
| 2443 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2444 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2445 | |
| 2446 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2447 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2448 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2449 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2450 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2451 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)); |
Chris Forbes | 62e8e50 | 2015-05-25 11:13:29 +1200 | [diff] [blame] | 2452 | if (!strstr(msgString.c_str(),"VS consumes input at location 0 but not provided")) { |
| 2453 | FAIL() << "Incorrect warning: " << msgString; |
| 2454 | } |
| 2455 | } |
| 2456 | |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2457 | TEST_F(VkLayerTest, CreatePipelineAttribTypeMismatch) |
| 2458 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2459 | VkFlags msgFlags; |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2460 | std::string msgString; |
| 2461 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2462 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2463 | |
| 2464 | VkVertexInputBindingDescription input_binding; |
| 2465 | memset(&input_binding, 0, sizeof(input_binding)); |
| 2466 | |
| 2467 | VkVertexInputAttributeDescription input_attrib; |
| 2468 | memset(&input_attrib, 0, sizeof(input_attrib)); |
| 2469 | input_attrib.format = VK_FORMAT_R32_SFLOAT; |
| 2470 | |
| 2471 | char const *vsSource = |
| 2472 | "#version 140\n" |
| 2473 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2474 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2475 | "\n" |
| 2476 | "layout(location=0) in int x;\n" /* attrib provided float */ |
| 2477 | "void main(){\n" |
| 2478 | " gl_Position = vec4(x);\n" |
| 2479 | "}\n"; |
| 2480 | char const *fsSource = |
| 2481 | "#version 140\n" |
| 2482 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2483 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2484 | "\n" |
| 2485 | "layout(location=0) out vec4 color;\n" |
| 2486 | "void main(){\n" |
| 2487 | " color = vec4(1);\n" |
| 2488 | "}\n"; |
| 2489 | |
| 2490 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2491 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2492 | |
| 2493 | VkPipelineObj pipe(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2494 | pipe.AddColorAttachment(); |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2495 | pipe.AddShader(&vs); |
| 2496 | pipe.AddShader(&fs); |
| 2497 | |
| 2498 | pipe.AddVertexInputBindings(&input_binding, 1); |
| 2499 | pipe.AddVertexInputAttribs(&input_attrib, 1); |
| 2500 | |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2501 | VkDescriptorSetObj descriptorSet(m_device); |
| 2502 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2503 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2504 | |
| 2505 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2506 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2507 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2508 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2509 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2510 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)); |
Chris Forbes | c97d98e | 2015-05-25 11:13:31 +1200 | [diff] [blame] | 2511 | if (!strstr(msgString.c_str(),"location 0 does not match VS input type")) { |
| 2512 | FAIL() << "Incorrect error: " << msgString; |
| 2513 | } |
| 2514 | } |
| 2515 | |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2516 | TEST_F(VkLayerTest, CreatePipelineAttribBindingConflict) |
| 2517 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2518 | VkFlags msgFlags; |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2519 | std::string msgString; |
| 2520 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2521 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2522 | |
| 2523 | /* Two binding descriptions for binding 0 */ |
| 2524 | VkVertexInputBindingDescription input_bindings[2]; |
| 2525 | memset(input_bindings, 0, sizeof(input_bindings)); |
| 2526 | |
| 2527 | VkVertexInputAttributeDescription input_attrib; |
| 2528 | memset(&input_attrib, 0, sizeof(input_attrib)); |
| 2529 | input_attrib.format = VK_FORMAT_R32_SFLOAT; |
| 2530 | |
| 2531 | char const *vsSource = |
| 2532 | "#version 140\n" |
| 2533 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2534 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2535 | "\n" |
| 2536 | "layout(location=0) in float x;\n" /* attrib provided float */ |
| 2537 | "void main(){\n" |
| 2538 | " gl_Position = vec4(x);\n" |
| 2539 | "}\n"; |
| 2540 | char const *fsSource = |
| 2541 | "#version 140\n" |
| 2542 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2543 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2544 | "\n" |
| 2545 | "layout(location=0) out vec4 color;\n" |
| 2546 | "void main(){\n" |
| 2547 | " color = vec4(1);\n" |
| 2548 | "}\n"; |
| 2549 | |
| 2550 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2551 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2552 | |
| 2553 | VkPipelineObj pipe(m_device); |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2554 | pipe.AddColorAttachment(); |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2555 | pipe.AddShader(&vs); |
| 2556 | pipe.AddShader(&fs); |
| 2557 | |
| 2558 | pipe.AddVertexInputBindings(input_bindings, 2); |
| 2559 | pipe.AddVertexInputAttribs(&input_attrib, 1); |
| 2560 | |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2561 | VkDescriptorSetObj descriptorSet(m_device); |
| 2562 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2563 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2564 | |
| 2565 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2566 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2567 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2568 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2569 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2570 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)); |
Chris Forbes | 280ba2c | 2015-06-12 11:16:41 +1200 | [diff] [blame] | 2571 | if (!strstr(msgString.c_str(),"Duplicate vertex input binding descriptions for binding 0")) { |
| 2572 | FAIL() << "Incorrect error: " << msgString; |
| 2573 | } |
| 2574 | } |
Chris Forbes | 8f68b56 | 2015-05-25 11:13:32 +1200 | [diff] [blame] | 2575 | |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2576 | /* TODO: would be nice to test the mixed broadcast & custom case, but the GLSL->SPV compiler |
| 2577 | * rejects it. */ |
| 2578 | |
| 2579 | TEST_F(VkLayerTest, CreatePipelineFragmentOutputNotWritten) |
| 2580 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2581 | VkFlags msgFlags; |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2582 | std::string msgString; |
| 2583 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2584 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2585 | |
| 2586 | char const *vsSource = |
| 2587 | "#version 140\n" |
| 2588 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2589 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2590 | "\n" |
| 2591 | "void main(){\n" |
| 2592 | " gl_Position = vec4(1);\n" |
| 2593 | "}\n"; |
| 2594 | char const *fsSource = |
| 2595 | "#version 140\n" |
| 2596 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2597 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2598 | "\n" |
| 2599 | "void main(){\n" |
| 2600 | "}\n"; |
| 2601 | |
| 2602 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2603 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2604 | |
| 2605 | VkPipelineObj pipe(m_device); |
| 2606 | pipe.AddShader(&vs); |
| 2607 | pipe.AddShader(&fs); |
| 2608 | |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2609 | /* set up CB 0, not written */ |
| 2610 | pipe.AddColorAttachment(); |
| 2611 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2612 | |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2613 | VkDescriptorSetObj descriptorSet(m_device); |
| 2614 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2615 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2616 | |
| 2617 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2618 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2619 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2620 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2621 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2622 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)); |
Chris Forbes | 4d6d1e5 | 2015-05-25 11:13:40 +1200 | [diff] [blame] | 2623 | if (!strstr(msgString.c_str(),"Attachment 0 not written by FS")) { |
| 2624 | FAIL() << "Incorrect error: " << msgString; |
| 2625 | } |
| 2626 | } |
| 2627 | |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2628 | TEST_F(VkLayerTest, CreatePipelineFragmentOutputNotConsumed) |
| 2629 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2630 | VkFlags msgFlags; |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2631 | std::string msgString; |
| 2632 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2633 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2634 | |
| 2635 | char const *vsSource = |
| 2636 | "#version 140\n" |
| 2637 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2638 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2639 | "\n" |
| 2640 | "void main(){\n" |
| 2641 | " gl_Position = vec4(1);\n" |
| 2642 | "}\n"; |
| 2643 | char const *fsSource = |
| 2644 | "#version 140\n" |
| 2645 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2646 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2647 | "\n" |
| 2648 | "layout(location=0) out vec4 x;\n" |
| 2649 | "layout(location=1) out vec4 y;\n" /* no matching attachment for this */ |
| 2650 | "void main(){\n" |
| 2651 | " x = vec4(1);\n" |
| 2652 | " y = vec4(1);\n" |
| 2653 | "}\n"; |
| 2654 | |
| 2655 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2656 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2657 | |
| 2658 | VkPipelineObj pipe(m_device); |
| 2659 | pipe.AddShader(&vs); |
| 2660 | pipe.AddShader(&fs); |
| 2661 | |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2662 | /* set up CB 0, not written */ |
| 2663 | pipe.AddColorAttachment(); |
| 2664 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2665 | /* FS writes CB 1, but we don't configure it */ |
| 2666 | |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2667 | VkDescriptorSetObj descriptorSet(m_device); |
| 2668 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2669 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2670 | |
| 2671 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2672 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2673 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2674 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2675 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2676 | ASSERT_NE(0, msgFlags & VK_DBG_REPORT_WARN_BIT); |
Chris Forbes | f3fffaa | 2015-05-25 11:13:43 +1200 | [diff] [blame] | 2677 | if (!strstr(msgString.c_str(),"FS writes to output location 1 with no matching attachment")) { |
| 2678 | FAIL() << "Incorrect warning: " << msgString; |
| 2679 | } |
| 2680 | } |
| 2681 | |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2682 | TEST_F(VkLayerTest, CreatePipelineFragmentOutputTypeMismatch) |
| 2683 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2684 | VkFlags msgFlags; |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2685 | std::string msgString; |
| 2686 | ASSERT_NO_FATAL_FAILURE(InitState()); |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2687 | ScopedUseGlsl useGlsl(false); |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2688 | |
| 2689 | char const *vsSource = |
| 2690 | "#version 140\n" |
| 2691 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2692 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2693 | "\n" |
| 2694 | "void main(){\n" |
| 2695 | " gl_Position = vec4(1);\n" |
| 2696 | "}\n"; |
| 2697 | char const *fsSource = |
| 2698 | "#version 140\n" |
| 2699 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2700 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2701 | "\n" |
| 2702 | "layout(location=0) out ivec4 x;\n" /* not UNORM */ |
| 2703 | "void main(){\n" |
| 2704 | " x = ivec4(1);\n" |
| 2705 | "}\n"; |
| 2706 | |
| 2707 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2708 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2709 | |
| 2710 | VkPipelineObj pipe(m_device); |
| 2711 | pipe.AddShader(&vs); |
| 2712 | pipe.AddShader(&fs); |
| 2713 | |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2714 | /* set up CB 0; type is UNORM by default */ |
| 2715 | pipe.AddColorAttachment(); |
| 2716 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2717 | |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2718 | VkDescriptorSetObj descriptorSet(m_device); |
| 2719 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2720 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2721 | |
| 2722 | m_errorMonitor->ClearState(); |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2723 | pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2724 | |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2725 | msgFlags = m_errorMonitor->GetState(&msgString); |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2726 | |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2727 | ASSERT_TRUE(0 != (msgFlags & VK_DBG_REPORT_ERROR_BIT)); |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2728 | if (!strstr(msgString.c_str(),"does not match FS output type")) { |
| 2729 | FAIL() << "Incorrect error: " << msgString; |
| 2730 | } |
| 2731 | } |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2732 | |
| 2733 | TEST_F(VkLayerTest, CreatePipelineNonSpirvShader) |
| 2734 | { |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2735 | VkFlags msgFlags; |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2736 | std::string msgString; |
| 2737 | ASSERT_NO_FATAL_FAILURE(InitState()); |
| 2738 | /* Intentionally provided GLSL rather than compiling to SPIRV first */ |
Cody Northrop | 50a2a4b | 2015-06-03 16:49:20 -0600 | [diff] [blame] | 2739 | ScopedUseGlsl useGlsl(true); |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2740 | |
| 2741 | char const *vsSource = |
| 2742 | "#version 140\n" |
| 2743 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2744 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2745 | "\n" |
| 2746 | "void main(){\n" |
| 2747 | " gl_Position = vec4(1);\n" |
| 2748 | "}\n"; |
| 2749 | char const *fsSource = |
| 2750 | "#version 140\n" |
| 2751 | "#extension GL_ARB_separate_shader_objects: require\n" |
| 2752 | "#extension GL_ARB_shading_language_420pack: require\n" |
| 2753 | "\n" |
| 2754 | "layout(location=0) out vec4 x;\n" |
| 2755 | "void main(){\n" |
| 2756 | " x = vec4(1);\n" |
| 2757 | "}\n"; |
| 2758 | |
| 2759 | m_errorMonitor->ClearState(); |
| 2760 | |
| 2761 | VkShaderObj vs(m_device, vsSource, VK_SHADER_STAGE_VERTEX, this); |
| 2762 | VkShaderObj fs(m_device, fsSource, VK_SHADER_STAGE_FRAGMENT, this); |
| 2763 | |
| 2764 | |
| 2765 | VkPipelineObj pipe(m_device); |
| 2766 | pipe.AddShader(&vs); |
| 2767 | pipe.AddShader(&fs); |
| 2768 | |
Chia-I Wu | 08accc6 | 2015-07-07 11:50:03 +0800 | [diff] [blame] | 2769 | /* set up CB 0; type is UNORM by default */ |
| 2770 | pipe.AddColorAttachment(); |
| 2771 | ASSERT_NO_FATAL_FAILURE(InitRenderTarget()); |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2772 | |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2773 | VkDescriptorSetObj descriptorSet(m_device); |
| 2774 | descriptorSet.AppendDummy(); |
Tony Barbour | fe3351b | 2015-07-28 10:17:20 -0600 | [diff] [blame] | 2775 | descriptorSet.CreateVKDescriptorSet(m_cmdBuffer); |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2776 | |
Tony Barbour | 5781e8f | 2015-08-04 16:23:11 -0600 | [diff] [blame] | 2777 | VkResult res = pipe.CreateVKPipeline(descriptorSet.GetPipelineLayout(), renderPass()); |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2778 | /* pipeline creation should have succeeded */ |
| 2779 | ASSERT_EQ(VK_SUCCESS, res); |
| 2780 | |
| 2781 | /* should have emitted a warning: the shader is not SPIRV, so we're |
| 2782 | * not going to be able to analyze it */ |
Courtney Goeltzenleuchter | f579fa6 | 2015-06-10 17:39:03 -0600 | [diff] [blame] | 2783 | msgFlags = m_errorMonitor->GetState(&msgString); |
Cody Northrop | d2ad034 | 2015-08-05 11:15:02 -0600 | [diff] [blame] | 2784 | ASSERT_NE(0, msgFlags & VK_DBG_REPORT_WARN_BIT); |
Chris Forbes | 7b1b893 | 2015-06-05 14:43:36 +1200 | [diff] [blame] | 2785 | if (!strstr(msgString.c_str(),"is not SPIR-V")) { |
| 2786 | FAIL() << "Incorrect warning: " << msgString; |
| 2787 | } |
| 2788 | } |
Chris Forbes | d9b20ca | 2015-06-04 09:25:25 +1200 | [diff] [blame] | 2789 | #endif |
Chris Forbes | a36d69e | 2015-05-25 11:13:44 +1200 | [diff] [blame] | 2790 | |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 2791 | int main(int argc, char **argv) { |
| 2792 | int result; |
| 2793 | |
| 2794 | ::testing::InitGoogleTest(&argc, argv); |
Tony Barbour | 6918cd5 | 2015-04-09 12:58:51 -0600 | [diff] [blame] | 2795 | VkTestFramework::InitArgs(&argc, argv); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 2796 | |
| 2797 | ::testing::AddGlobalTestEnvironment(new TestEnvironment); |
| 2798 | |
| 2799 | result = RUN_ALL_TESTS(); |
| 2800 | |
Tony Barbour | 6918cd5 | 2015-04-09 12:58:51 -0600 | [diff] [blame] | 2801 | VkTestFramework::Finish(); |
Tony Barbour | 300a608 | 2015-04-07 13:44:53 -0600 | [diff] [blame] | 2802 | return result; |
| 2803 | } |