stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame] | 11 | #include "call/bitrate_allocator.h" |
| 12 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 13 | #include <algorithm> |
kwiberg | b25345e | 2016-03-12 06:10:44 -0800 | [diff] [blame] | 14 | #include <memory> |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 15 | #include <vector> |
| 16 | |
Sebastian Jansson | 4ad51d8 | 2019-06-11 11:24:40 +0200 | [diff] [blame] | 17 | #include "system_wrappers/include/clock.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 18 | #include "test/gmock.h" |
| 19 | #include "test/gtest.h" |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 20 | |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 21 | using ::testing::_; |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 22 | using ::testing::AllOf; |
| 23 | using ::testing::Field; |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 24 | using ::testing::NiceMock; |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 25 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 26 | namespace webrtc { |
| 27 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 28 | namespace { |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 29 | auto AllocationLimitsEq(uint32_t min_allocatable_rate_bps, |
| 30 | uint32_t max_padding_rate_bps, |
| 31 | uint32_t max_allocatable_rate_bps) { |
| 32 | return AllOf(Field(&BitrateAllocationLimits::min_allocatable_rate, |
| 33 | DataRate::bps(min_allocatable_rate_bps)), |
| 34 | Field(&BitrateAllocationLimits::max_allocatable_rate, |
| 35 | DataRate::bps(max_allocatable_rate_bps)), |
| 36 | Field(&BitrateAllocationLimits::max_padding_rate, |
| 37 | DataRate::bps(max_padding_rate_bps))); |
| 38 | } |
| 39 | |
| 40 | auto AllocationLimitsEq(uint32_t min_allocatable_rate_bps, |
| 41 | uint32_t max_padding_rate_bps) { |
| 42 | return AllOf(Field(&BitrateAllocationLimits::min_allocatable_rate, |
| 43 | DataRate::bps(min_allocatable_rate_bps)), |
| 44 | Field(&BitrateAllocationLimits::max_padding_rate, |
| 45 | DataRate::bps(max_padding_rate_bps))); |
| 46 | } |
| 47 | |
| 48 | class MockLimitObserver : public BitrateAllocator::LimitObserver { |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 49 | public: |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 50 | MOCK_METHOD1(OnAllocationLimitsChanged, void(BitrateAllocationLimits)); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 51 | }; |
| 52 | |
mflodman | 86aabb2 | 2016-03-11 15:44:32 +0100 | [diff] [blame] | 53 | class TestBitrateObserver : public BitrateAllocatorObserver { |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 54 | public: |
| 55 | TestBitrateObserver() |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 56 | : last_bitrate_bps_(0), |
| 57 | last_fraction_loss_(0), |
| 58 | last_rtt_ms_(0), |
minyue | 78b4d56 | 2016-11-30 04:47:39 -0800 | [diff] [blame] | 59 | last_probing_interval_ms_(0), |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 60 | protection_ratio_(0.0) {} |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 61 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 62 | void SetBitrateProtectionRatio(double protection_ratio) { |
| 63 | protection_ratio_ = protection_ratio; |
| 64 | } |
| 65 | |
Sebastian Jansson | c0e4d45 | 2018-10-25 15:08:32 +0200 | [diff] [blame] | 66 | uint32_t OnBitrateUpdated(BitrateAllocationUpdate update) override { |
Sebastian Jansson | 13e5903 | 2018-11-21 19:13:07 +0100 | [diff] [blame] | 67 | last_bitrate_bps_ = update.target_bitrate.bps(); |
| 68 | last_fraction_loss_ = |
| 69 | rtc::dchecked_cast<uint8_t>(update.packet_loss_ratio * 256); |
| 70 | last_rtt_ms_ = update.round_trip_time.ms(); |
| 71 | last_probing_interval_ms_ = update.bwe_period.ms(); |
| 72 | return update.target_bitrate.bps() * protection_ratio_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 73 | } |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 74 | uint32_t last_bitrate_bps_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 75 | uint8_t last_fraction_loss_; |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 76 | int64_t last_rtt_ms_; |
minyue | 78b4d56 | 2016-11-30 04:47:39 -0800 | [diff] [blame] | 77 | int last_probing_interval_ms_; |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 78 | double protection_ratio_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 79 | }; |
| 80 | |
minyue | 78b4d56 | 2016-11-30 04:47:39 -0800 | [diff] [blame] | 81 | constexpr int64_t kDefaultProbingIntervalMs = 3000; |
Seth Hampson | 24722b3 | 2017-12-22 09:36:42 -0800 | [diff] [blame] | 82 | const double kDefaultBitratePriority = 1.0; |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 83 | |
| 84 | TargetTransferRate CreateTargetRateMessage(uint32_t target_bitrate_bps, |
| 85 | uint8_t fraction_loss, |
| 86 | int64_t rtt_ms, |
| 87 | int64_t bwe_period_ms) { |
| 88 | TargetTransferRate msg; |
| 89 | // The timestamp is just for log output, keeping it fixed just means fewer log |
| 90 | // messages in the test. |
| 91 | msg.at_time = Timestamp::seconds(10000); |
| 92 | msg.target_rate = DataRate::bps(target_bitrate_bps); |
| 93 | msg.stable_target_rate = msg.target_rate; |
| 94 | msg.network_estimate.bandwidth = msg.target_rate; |
| 95 | msg.network_estimate.loss_rate_ratio = fraction_loss / 255.0; |
| 96 | msg.network_estimate.round_trip_time = TimeDelta::ms(rtt_ms); |
| 97 | msg.network_estimate.bwe_period = TimeDelta::ms(bwe_period_ms); |
| 98 | return msg; |
| 99 | } |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 100 | } // namespace |
minyue | 78b4d56 | 2016-11-30 04:47:39 -0800 | [diff] [blame] | 101 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 102 | class BitrateAllocatorTest : public ::testing::Test { |
| 103 | protected: |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 104 | BitrateAllocatorTest() : allocator_(new BitrateAllocator(&limit_observer_)) { |
| 105 | allocator_->OnNetworkEstimateChanged( |
| 106 | CreateTargetRateMessage(300000u, 0, 0, kDefaultProbingIntervalMs)); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 107 | } |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 108 | ~BitrateAllocatorTest() {} |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 109 | void AddObserver(BitrateAllocatorObserver* observer, |
| 110 | uint32_t min_bitrate_bps, |
| 111 | uint32_t max_bitrate_bps, |
| 112 | uint32_t pad_up_bitrate_bps, |
| 113 | bool enforce_min_bitrate, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 114 | double bitrate_priority) { |
| 115 | allocator_->AddObserver( |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 116 | observer, |
| 117 | {min_bitrate_bps, max_bitrate_bps, pad_up_bitrate_bps, |
| 118 | /* priority_bitrate */ 0, enforce_min_bitrate, bitrate_priority}); |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 119 | } |
| 120 | MediaStreamAllocationConfig DefaultConfig() const { |
| 121 | MediaStreamAllocationConfig default_config; |
| 122 | default_config.min_bitrate_bps = 0; |
| 123 | default_config.max_bitrate_bps = 1500000; |
| 124 | default_config.pad_up_bitrate_bps = 0; |
| 125 | default_config.priority_bitrate_bps = 0; |
| 126 | default_config.enforce_min_bitrate = true; |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 127 | default_config.bitrate_priority = kDefaultBitratePriority; |
| 128 | return default_config; |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 129 | } |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 130 | |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 131 | NiceMock<MockLimitObserver> limit_observer_; |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 132 | std::unique_ptr<BitrateAllocator> allocator_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 133 | }; |
| 134 | |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 135 | TEST_F(BitrateAllocatorTest, RespectsPriorityBitrate) { |
| 136 | TestBitrateObserver stream_a; |
| 137 | auto config_a = DefaultConfig(); |
| 138 | config_a.min_bitrate_bps = 100000; |
| 139 | config_a.priority_bitrate_bps = 0; |
| 140 | allocator_->AddObserver(&stream_a, config_a); |
| 141 | |
| 142 | TestBitrateObserver stream_b; |
| 143 | auto config_b = DefaultConfig(); |
| 144 | config_b.min_bitrate_bps = 100000; |
| 145 | config_b.max_bitrate_bps = 300000; |
| 146 | config_b.priority_bitrate_bps = 300000; |
| 147 | allocator_->AddObserver(&stream_b, config_b); |
| 148 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 149 | allocator_->OnNetworkEstimateChanged( |
| 150 | CreateTargetRateMessage(100000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 151 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 152 | EXPECT_EQ(stream_b.last_bitrate_bps_, 100000u); |
| 153 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 154 | allocator_->OnNetworkEstimateChanged( |
| 155 | CreateTargetRateMessage(200000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 156 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 157 | EXPECT_EQ(stream_b.last_bitrate_bps_, 100000u); |
| 158 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 159 | allocator_->OnNetworkEstimateChanged( |
| 160 | CreateTargetRateMessage(300000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 161 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 162 | EXPECT_EQ(stream_b.last_bitrate_bps_, 200000u); |
| 163 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 164 | allocator_->OnNetworkEstimateChanged( |
| 165 | CreateTargetRateMessage(400000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 166 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 167 | EXPECT_EQ(stream_b.last_bitrate_bps_, 300000u); |
| 168 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 169 | allocator_->OnNetworkEstimateChanged( |
| 170 | CreateTargetRateMessage(800000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 171 | EXPECT_EQ(stream_a.last_bitrate_bps_, 500000u); |
| 172 | EXPECT_EQ(stream_b.last_bitrate_bps_, 300000u); |
| 173 | } |
| 174 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 175 | TEST_F(BitrateAllocatorTest, UpdatingBitrateObserver) { |
| 176 | TestBitrateObserver bitrate_observer; |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 177 | const uint32_t kMinSendBitrateBps = 100000; |
| 178 | const uint32_t kPadUpToBitrateBps = 50000; |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 179 | const uint32_t kMaxBitrateBps = 1500000; |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 180 | |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 181 | EXPECT_CALL(limit_observer_, |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 182 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 183 | kMinSendBitrateBps, kPadUpToBitrateBps, kMaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 184 | AddObserver(&bitrate_observer, kMinSendBitrateBps, kMaxBitrateBps, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 185 | kPadUpToBitrateBps, true, kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 186 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer)); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 187 | allocator_->OnNetworkEstimateChanged( |
| 188 | CreateTargetRateMessage(200000, 0, 0, kDefaultProbingIntervalMs)); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 189 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 190 | |
Peter Boström | 8e4e8b0 | 2015-09-15 15:08:03 +0200 | [diff] [blame] | 191 | // TODO(pbos): Expect capping to 1.5M instead of 3M when not boosting the max |
mflodman | 0e7e259 | 2015-11-12 21:02:42 -0800 | [diff] [blame] | 192 | // bitrate for FEC/retransmissions (see todo in BitrateAllocator). |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 193 | allocator_->OnNetworkEstimateChanged( |
| 194 | CreateTargetRateMessage(4000000, 0, 0, kDefaultProbingIntervalMs)); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 195 | EXPECT_EQ(3000000, allocator_->GetStartBitrate(&bitrate_observer)); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 196 | |
| 197 | // Expect |max_padding_bitrate_bps| to change to 0 if the observer is updated. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 198 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 199 | AllocationLimitsEq(kMinSendBitrateBps, 0))); |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 200 | AddObserver(&bitrate_observer, kMinSendBitrateBps, 4000000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 201 | kDefaultBitratePriority); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 202 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 203 | AllocationLimitsEq(kMinSendBitrateBps, 0))); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 204 | EXPECT_EQ(4000000, allocator_->GetStartBitrate(&bitrate_observer)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 205 | |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 206 | AddObserver(&bitrate_observer, kMinSendBitrateBps, kMaxBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 207 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 208 | EXPECT_EQ(3000000, allocator_->GetStartBitrate(&bitrate_observer)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 209 | EXPECT_EQ(3000000u, bitrate_observer.last_bitrate_bps_); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 210 | allocator_->OnNetworkEstimateChanged( |
| 211 | CreateTargetRateMessage(kMaxBitrateBps, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 212 | EXPECT_EQ(1500000u, bitrate_observer.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 213 | } |
| 214 | |
| 215 | TEST_F(BitrateAllocatorTest, TwoBitrateObserversOneRtcpObserver) { |
| 216 | TestBitrateObserver bitrate_observer_1; |
| 217 | TestBitrateObserver bitrate_observer_2; |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 218 | const uint32_t kObs1StartBitrateBps = 100000; |
| 219 | const uint32_t kObs2StartBitrateBps = 200000; |
| 220 | const uint32_t kObs1MaxBitrateBps = 300000; |
| 221 | const uint32_t kObs2MaxBitrateBps = 300000; |
| 222 | |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 223 | EXPECT_CALL(limit_observer_, |
| 224 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 225 | kObs1StartBitrateBps, 0, kObs1MaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 226 | AddObserver(&bitrate_observer_1, kObs1StartBitrateBps, kObs1MaxBitrateBps, 0, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 227 | true, kDefaultBitratePriority); |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 228 | EXPECT_EQ(static_cast<int>(kObs1MaxBitrateBps), |
| 229 | allocator_->GetStartBitrate(&bitrate_observer_1)); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 230 | EXPECT_CALL(limit_observer_, |
| 231 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 232 | kObs1StartBitrateBps + kObs2StartBitrateBps, 0, |
| 233 | kObs1MaxBitrateBps + kObs2MaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 234 | AddObserver(&bitrate_observer_2, kObs2StartBitrateBps, kObs2MaxBitrateBps, 0, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 235 | true, kDefaultBitratePriority); |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 236 | EXPECT_EQ(static_cast<int>(kObs2StartBitrateBps), |
| 237 | allocator_->GetStartBitrate(&bitrate_observer_2)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 238 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 239 | // Test too low start bitrate, hence lower than sum of min. Min bitrates |
| 240 | // will |
| 241 | // be allocated to all observers. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 242 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 243 | kObs2StartBitrateBps, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 244 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 245 | EXPECT_EQ(0, bitrate_observer_1.last_fraction_loss_); |
| 246 | EXPECT_EQ(50, bitrate_observer_1.last_rtt_ms_); |
| 247 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); |
| 248 | EXPECT_EQ(0, bitrate_observer_2.last_fraction_loss_); |
| 249 | EXPECT_EQ(50, bitrate_observer_2.last_rtt_ms_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 250 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 251 | // Test a bitrate which should be distributed equally. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 252 | allocator_->OnNetworkEstimateChanged( |
| 253 | CreateTargetRateMessage(500000, 0, 50, kDefaultProbingIntervalMs)); |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 254 | const uint32_t kBitrateToShare = |
| 255 | 500000 - kObs2StartBitrateBps - kObs1StartBitrateBps; |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 256 | EXPECT_EQ(100000u + kBitrateToShare / 2, |
| 257 | bitrate_observer_1.last_bitrate_bps_); |
| 258 | EXPECT_EQ(200000u + kBitrateToShare / 2, |
| 259 | bitrate_observer_2.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 260 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 261 | // Limited by 2x max bitrates since we leave room for FEC and |
| 262 | // retransmissions. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 263 | allocator_->OnNetworkEstimateChanged( |
| 264 | CreateTargetRateMessage(1500000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 265 | EXPECT_EQ(600000u, bitrate_observer_1.last_bitrate_bps_); |
| 266 | EXPECT_EQ(600000u, bitrate_observer_2.last_bitrate_bps_); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 267 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 268 | // Verify that if the bandwidth estimate is set to zero, the allocated |
| 269 | // rate is |
| 270 | // zero. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 271 | allocator_->OnNetworkEstimateChanged( |
| 272 | CreateTargetRateMessage(0, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 273 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 274 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 275 | } |
| 276 | |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 277 | TEST_F(BitrateAllocatorTest, RemoveObserverTriggersLimitObserver) { |
| 278 | TestBitrateObserver bitrate_observer; |
| 279 | const uint32_t kMinSendBitrateBps = 100000; |
| 280 | const uint32_t kPadUpToBitrateBps = 50000; |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 281 | const uint32_t kMaxBitrateBps = 1500000; |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 282 | |
philipel | f69e768 | 2018-02-28 13:06:28 +0100 | [diff] [blame] | 283 | EXPECT_CALL(limit_observer_, |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 284 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 285 | kMinSendBitrateBps, kPadUpToBitrateBps, kMaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 286 | AddObserver(&bitrate_observer, kMinSendBitrateBps, kMaxBitrateBps, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 287 | kPadUpToBitrateBps, true, kDefaultBitratePriority); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 288 | EXPECT_CALL(limit_observer_, |
| 289 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0))); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 290 | allocator_->RemoveObserver(&bitrate_observer); |
| 291 | } |
| 292 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 293 | class BitrateAllocatorTestNoEnforceMin : public ::testing::Test { |
| 294 | protected: |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 295 | BitrateAllocatorTestNoEnforceMin() |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 296 | : allocator_(new BitrateAllocator(&limit_observer_)) { |
| 297 | allocator_->OnNetworkEstimateChanged( |
| 298 | CreateTargetRateMessage(300000u, 0, 0, kDefaultProbingIntervalMs)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 299 | } |
| 300 | ~BitrateAllocatorTestNoEnforceMin() {} |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 301 | void AddObserver(BitrateAllocatorObserver* observer, |
| 302 | uint32_t min_bitrate_bps, |
| 303 | uint32_t max_bitrate_bps, |
| 304 | uint32_t pad_up_bitrate_bps, |
| 305 | bool enforce_min_bitrate, |
| 306 | std::string track_id, |
| 307 | double bitrate_priority) { |
| 308 | allocator_->AddObserver( |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 309 | observer, {min_bitrate_bps, max_bitrate_bps, pad_up_bitrate_bps, 0, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 310 | enforce_min_bitrate, bitrate_priority}); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 311 | } |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 312 | NiceMock<MockLimitObserver> limit_observer_; |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 313 | std::unique_ptr<BitrateAllocator> allocator_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 314 | }; |
| 315 | |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 316 | // The following three tests verify enforcing a minimum bitrate works as |
| 317 | // intended. |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 318 | TEST_F(BitrateAllocatorTestNoEnforceMin, OneBitrateObserver) { |
| 319 | TestBitrateObserver bitrate_observer_1; |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 320 | // Expect OnAllocationLimitsChanged with |min_send_bitrate_bps| = 0 since |
| 321 | // AddObserver is called with |enforce_min_bitrate| = false. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 322 | EXPECT_CALL(limit_observer_, |
| 323 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0))); |
| 324 | EXPECT_CALL(limit_observer_, |
| 325 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 120000))); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 326 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, false, "", |
| 327 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 328 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 329 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 330 | // High BWE. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 331 | allocator_->OnNetworkEstimateChanged( |
| 332 | CreateTargetRateMessage(150000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 333 | EXPECT_EQ(150000u, bitrate_observer_1.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 334 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 335 | // Low BWE. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 336 | allocator_->OnNetworkEstimateChanged( |
| 337 | CreateTargetRateMessage(10000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 338 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 339 | |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 340 | EXPECT_CALL(limit_observer_, |
| 341 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0))); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 342 | allocator_->RemoveObserver(&bitrate_observer_1); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 343 | } |
| 344 | |
| 345 | TEST_F(BitrateAllocatorTestNoEnforceMin, ThreeBitrateObservers) { |
| 346 | TestBitrateObserver bitrate_observer_1; |
| 347 | TestBitrateObserver bitrate_observer_2; |
| 348 | TestBitrateObserver bitrate_observer_3; |
| 349 | // Set up the observers with min bitrates at 100000, 200000, and 300000. |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 350 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, false, "", |
| 351 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 352 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 353 | |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 354 | AddObserver(&bitrate_observer_2, 200000, 400000, 0, false, "", |
| 355 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 356 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer_2)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 357 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 358 | |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 359 | AddObserver(&bitrate_observer_3, 300000, 400000, 0, false, "", |
| 360 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 361 | EXPECT_EQ(0, allocator_->GetStartBitrate(&bitrate_observer_3)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 362 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 363 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 364 | |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 365 | // High BWE. Make sure the controllers get a fair share of the surplus (i.e., |
| 366 | // what is left after each controller gets its min rate). |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 367 | allocator_->OnNetworkEstimateChanged( |
| 368 | CreateTargetRateMessage(690000, 0, 0, kDefaultProbingIntervalMs)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 369 | // Verify that each observer gets its min rate (sum of min rates is 600000), |
| 370 | // and that the remaining 90000 is divided equally among the three. |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 371 | uint32_t bitrate_to_share = 690000u - 100000u - 200000u - 300000u; |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 372 | EXPECT_EQ(100000u + bitrate_to_share / 3, |
| 373 | bitrate_observer_1.last_bitrate_bps_); |
| 374 | EXPECT_EQ(200000u + bitrate_to_share / 3, |
| 375 | bitrate_observer_2.last_bitrate_bps_); |
| 376 | EXPECT_EQ(300000u + bitrate_to_share / 3, |
| 377 | bitrate_observer_3.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 378 | |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 379 | // BWE below the sum of observer's min bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 380 | allocator_->OnNetworkEstimateChanged( |
| 381 | CreateTargetRateMessage(300000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 382 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); // Min bitrate. |
| 383 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); // Min bitrate. |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 384 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); // Nothing. |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 385 | |
| 386 | // Increased BWE, but still below the sum of configured min bitrates for all |
| 387 | // observers and too little for observer 3. 1 and 2 will share the rest. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 388 | allocator_->OnNetworkEstimateChanged( |
| 389 | CreateTargetRateMessage(500000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 390 | EXPECT_EQ(200000u, bitrate_observer_1.last_bitrate_bps_); // Min + split. |
| 391 | EXPECT_EQ(300000u, bitrate_observer_2.last_bitrate_bps_); // Min + split. |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 392 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); // Nothing. |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 393 | |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 394 | // Below min for all. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 395 | allocator_->OnNetworkEstimateChanged( |
| 396 | CreateTargetRateMessage(10000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 397 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 398 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 399 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 400 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 401 | // Verify that zero estimated bandwidth, means that that all gets zero, |
| 402 | // regardless of set min bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 403 | allocator_->OnNetworkEstimateChanged( |
| 404 | CreateTargetRateMessage(0, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 405 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 406 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 407 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 408 | |
mflodman | 86aabb2 | 2016-03-11 15:44:32 +0100 | [diff] [blame] | 409 | allocator_->RemoveObserver(&bitrate_observer_1); |
| 410 | allocator_->RemoveObserver(&bitrate_observer_2); |
| 411 | allocator_->RemoveObserver(&bitrate_observer_3); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 412 | } |
| 413 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 414 | TEST_F(BitrateAllocatorTestNoEnforceMin, OneBitrateObserverWithPacketLoss) { |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 415 | const uint32_t kMinBitrateBps = 100000; |
| 416 | const uint32_t kMaxBitrateBps = 400000; |
| 417 | // Hysteresis adds another 10% or 20kbps to min bitrate. |
| 418 | const uint32_t kMinStartBitrateBps = |
| 419 | kMinBitrateBps + std::max(20000u, kMinBitrateBps / 10); |
| 420 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 421 | // Expect OnAllocationLimitsChanged with |min_send_bitrate_bps| = 0 since |
| 422 | // AddObserver is called with |enforce_min_bitrate| = false. |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 423 | TestBitrateObserver bitrate_observer; |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 424 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 425 | AllocationLimitsEq(0, 0, kMaxBitrateBps))); |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 426 | AddObserver(&bitrate_observer, kMinBitrateBps, kMaxBitrateBps, 0, false, "", |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 427 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 428 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer)); |
| 429 | |
| 430 | // High BWE. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 431 | allocator_->OnNetworkEstimateChanged( |
| 432 | CreateTargetRateMessage(150000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 433 | EXPECT_EQ(150000u, bitrate_observer.last_bitrate_bps_); |
| 434 | |
| 435 | // Add loss and use a part of the bitrate for protection. |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 436 | const double kProtectionRatio = 0.4; |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 437 | const uint8_t fraction_loss = kProtectionRatio * 256; |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 438 | bitrate_observer.SetBitrateProtectionRatio(kProtectionRatio); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 439 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 440 | 200000, 0, fraction_loss, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 441 | EXPECT_EQ(200000u, bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 442 | |
| 443 | // Above the min threshold, but not enough given the protection used. |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 444 | // Limits changed, as we will video is now off and we need to pad up to the |
| 445 | // start bitrate. |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 446 | // Verify the hysteresis is added for the protection. |
| 447 | const uint32_t kMinStartBitrateWithProtectionBps = |
| 448 | static_cast<uint32_t>(kMinStartBitrateBps * (1 + kProtectionRatio)); |
| 449 | EXPECT_CALL(limit_observer_, |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 450 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 451 | 0, kMinStartBitrateWithProtectionBps, kMaxBitrateBps))); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 452 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 453 | kMinStartBitrateBps + 1000, 0, fraction_loss, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 454 | EXPECT_EQ(0u, bitrate_observer.last_bitrate_bps_); |
| 455 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 456 | allocator_->OnNetworkEstimateChanged( |
| 457 | CreateTargetRateMessage(kMinStartBitrateWithProtectionBps - 1000, 0, |
| 458 | fraction_loss, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 459 | EXPECT_EQ(0u, bitrate_observer.last_bitrate_bps_); |
| 460 | |
| 461 | // Just enough to enable video again. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 462 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 463 | AllocationLimitsEq(0, 0, kMaxBitrateBps))); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 464 | allocator_->OnNetworkEstimateChanged( |
| 465 | CreateTargetRateMessage(kMinStartBitrateWithProtectionBps, 0, |
| 466 | fraction_loss, kDefaultProbingIntervalMs)); |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 467 | EXPECT_EQ(kMinStartBitrateWithProtectionBps, |
| 468 | bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 469 | |
| 470 | // Remove all protection and make sure video is not paused as earlier. |
| 471 | bitrate_observer.SetBitrateProtectionRatio(0.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 472 | allocator_->OnNetworkEstimateChanged( |
| 473 | CreateTargetRateMessage(kMinStartBitrateWithProtectionBps - 1000, 0, 0, |
| 474 | kDefaultProbingIntervalMs)); |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 475 | EXPECT_EQ(kMinStartBitrateWithProtectionBps - 1000, |
| 476 | bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 477 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 478 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 479 | kMinStartBitrateBps, 0, 0, kDefaultProbingIntervalMs)); |
Erik Språng | d1d7b23 | 2018-12-06 17:31:25 +0100 | [diff] [blame] | 480 | EXPECT_EQ(kMinStartBitrateBps, bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 481 | |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 482 | EXPECT_CALL(limit_observer_, |
| 483 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0, 0))); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 484 | allocator_->RemoveObserver(&bitrate_observer); |
| 485 | } |
| 486 | |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 487 | TEST_F(BitrateAllocatorTest, |
| 488 | TotalAllocationLimitsAreUnaffectedByProtectionRatio) { |
| 489 | TestBitrateObserver bitrate_observer; |
| 490 | |
| 491 | const uint32_t kMinBitrateBps = 100000; |
| 492 | const uint32_t kMaxBitrateBps = 400000; |
| 493 | |
| 494 | // Register |bitrate_observer| and expect total allocation limits to change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 495 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(AllocationLimitsEq( |
| 496 | kMinBitrateBps, 0, kMaxBitrateBps))) |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 497 | .Times(1); |
Sebastian Jansson | 464a557 | 2019-02-12 13:32:32 +0100 | [diff] [blame] | 498 | MediaStreamAllocationConfig allocation_config = DefaultConfig(); |
| 499 | allocation_config.min_bitrate_bps = kMinBitrateBps; |
| 500 | allocation_config.max_bitrate_bps = kMaxBitrateBps; |
| 501 | allocator_->AddObserver(&bitrate_observer, allocation_config); |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 502 | |
| 503 | // Observer uses 20% of it's allocated bitrate for protection. |
| 504 | bitrate_observer.SetBitrateProtectionRatio(/*protection_ratio=*/0.2); |
| 505 | // Total allocation limits are unaffected by the protection rate change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 506 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(_)).Times(0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 507 | allocator_->OnNetworkEstimateChanged( |
| 508 | CreateTargetRateMessage(200000u, 0, 100, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 509 | |
| 510 | // Observer uses 0% of it's allocated bitrate for protection. |
| 511 | bitrate_observer.SetBitrateProtectionRatio(/*protection_ratio=*/0.0); |
| 512 | // Total allocation limits are unaffected by the protection rate change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 513 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(_)).Times(0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 514 | allocator_->OnNetworkEstimateChanged( |
| 515 | CreateTargetRateMessage(200000u, 0, 100, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 516 | |
| 517 | // Observer again uses 20% of it's allocated bitrate for protection. |
| 518 | bitrate_observer.SetBitrateProtectionRatio(/*protection_ratio=*/0.2); |
| 519 | // Total allocation limits are unaffected by the protection rate change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 520 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(_)).Times(0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 521 | allocator_->OnNetworkEstimateChanged( |
| 522 | CreateTargetRateMessage(200000u, 0, 100, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 15:09:34 +0100 | [diff] [blame] | 523 | } |
| 524 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 525 | TEST_F(BitrateAllocatorTestNoEnforceMin, TwoBitrateObserverWithPacketLoss) { |
| 526 | TestBitrateObserver bitrate_observer_1; |
| 527 | TestBitrateObserver bitrate_observer_2; |
| 528 | |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 529 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, false, "", |
| 530 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 531 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 532 | AddObserver(&bitrate_observer_2, 200000, 400000, 0, false, "", |
| 533 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 534 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer_2)); |
| 535 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 536 | |
| 537 | // Enough bitrate for both. |
| 538 | bitrate_observer_2.SetBitrateProtectionRatio(0.5); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 539 | allocator_->OnNetworkEstimateChanged( |
| 540 | CreateTargetRateMessage(300000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 541 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 542 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); |
| 543 | |
| 544 | // Above min for observer 2, but too little given the protection used. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 545 | allocator_->OnNetworkEstimateChanged( |
| 546 | CreateTargetRateMessage(330000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 547 | EXPECT_EQ(330000u, bitrate_observer_1.last_bitrate_bps_); |
| 548 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 549 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 550 | allocator_->OnNetworkEstimateChanged( |
| 551 | CreateTargetRateMessage(100000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 552 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 553 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 554 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 555 | allocator_->OnNetworkEstimateChanged( |
| 556 | CreateTargetRateMessage(99999, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 557 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 558 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 559 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 560 | allocator_->OnNetworkEstimateChanged( |
| 561 | CreateTargetRateMessage(119000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 562 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 563 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 564 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 565 | allocator_->OnNetworkEstimateChanged( |
| 566 | CreateTargetRateMessage(120000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 567 | EXPECT_EQ(120000u, bitrate_observer_1.last_bitrate_bps_); |
| 568 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 569 | |
| 570 | // Verify the protection is accounted for before resuming observer 2. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 571 | allocator_->OnNetworkEstimateChanged( |
| 572 | CreateTargetRateMessage(429000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 573 | EXPECT_EQ(400000u, bitrate_observer_1.last_bitrate_bps_); |
| 574 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 575 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 576 | allocator_->OnNetworkEstimateChanged( |
| 577 | CreateTargetRateMessage(430000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 578 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 579 | EXPECT_EQ(330000u, bitrate_observer_2.last_bitrate_bps_); |
| 580 | |
| 581 | allocator_->RemoveObserver(&bitrate_observer_1); |
| 582 | allocator_->RemoveObserver(&bitrate_observer_2); |
| 583 | } |
| 584 | |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 585 | TEST_F(BitrateAllocatorTest, ThreeBitrateObserversLowBweEnforceMin) { |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 586 | TestBitrateObserver bitrate_observer_1; |
| 587 | TestBitrateObserver bitrate_observer_2; |
| 588 | TestBitrateObserver bitrate_observer_3; |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 589 | |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 590 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 591 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 592 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
| 593 | |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 594 | AddObserver(&bitrate_observer_2, 200000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 595 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 596 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer_2)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 597 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 598 | |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 599 | AddObserver(&bitrate_observer_3, 300000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 600 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 601 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_3)); |
| 602 | EXPECT_EQ(100000, static_cast<int>(bitrate_observer_1.last_bitrate_bps_)); |
| 603 | EXPECT_EQ(200000, static_cast<int>(bitrate_observer_2.last_bitrate_bps_)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 604 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 605 | // Low BWE. Verify that all observers still get their respective min |
| 606 | // bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 607 | allocator_->OnNetworkEstimateChanged( |
| 608 | CreateTargetRateMessage(1000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 609 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); // Min cap. |
| 610 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); // Min cap. |
| 611 | EXPECT_EQ(300000u, bitrate_observer_3.last_bitrate_bps_); // Min cap. |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 612 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 613 | allocator_->RemoveObserver(&bitrate_observer_1); |
| 614 | allocator_->RemoveObserver(&bitrate_observer_2); |
| 615 | allocator_->RemoveObserver(&bitrate_observer_3); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 616 | } |
perkj | fea9309 | 2016-05-14 00:58:48 -0700 | [diff] [blame] | 617 | |
| 618 | TEST_F(BitrateAllocatorTest, AddObserverWhileNetworkDown) { |
| 619 | TestBitrateObserver bitrate_observer_1; |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 620 | EXPECT_CALL(limit_observer_, |
| 621 | OnAllocationLimitsChanged(AllocationLimitsEq(50000, 0))); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 622 | |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 623 | AddObserver(&bitrate_observer_1, 50000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 624 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 625 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
perkj | fea9309 | 2016-05-14 00:58:48 -0700 | [diff] [blame] | 626 | |
| 627 | // Set network down, ie, no available bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 628 | allocator_->OnNetworkEstimateChanged( |
| 629 | CreateTargetRateMessage(0, 0, 0, kDefaultProbingIntervalMs)); |
perkj | fea9309 | 2016-05-14 00:58:48 -0700 | [diff] [blame] | 630 | |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 631 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
perkj | fea9309 | 2016-05-14 00:58:48 -0700 | [diff] [blame] | 632 | |
| 633 | TestBitrateObserver bitrate_observer_2; |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 634 | // Adding an observer while the network is down should not affect the limits. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 18:31:52 +0200 | [diff] [blame] | 635 | EXPECT_CALL(limit_observer_, |
| 636 | OnAllocationLimitsChanged(AllocationLimitsEq(50000 + 50000, 0))); |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 637 | AddObserver(&bitrate_observer_2, 50000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 638 | kDefaultBitratePriority); |
perkj | fea9309 | 2016-05-14 00:58:48 -0700 | [diff] [blame] | 639 | |
| 640 | // Expect the start_bitrate to be set as if the network was still up but that |
| 641 | // the new observer have been notified that the network is down. |
perkj | 57c21f9 | 2016-06-17 07:27:16 -0700 | [diff] [blame] | 642 | EXPECT_EQ(300000 / 2, allocator_->GetStartBitrate(&bitrate_observer_2)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 643 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 644 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
perkj | fea9309 | 2016-05-14 00:58:48 -0700 | [diff] [blame] | 645 | |
| 646 | // Set network back up. |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 647 | allocator_->OnNetworkEstimateChanged( |
| 648 | CreateTargetRateMessage(1500000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 649 | EXPECT_EQ(750000u, bitrate_observer_1.last_bitrate_bps_); |
| 650 | EXPECT_EQ(750000u, bitrate_observer_2.last_bitrate_bps_); |
| 651 | } |
| 652 | |
| 653 | TEST_F(BitrateAllocatorTest, MixedEnforecedConfigs) { |
| 654 | TestBitrateObserver enforced_observer; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 655 | AddObserver(&enforced_observer, 6000, 30000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 656 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 657 | EXPECT_EQ(60000, allocator_->GetStartBitrate(&enforced_observer)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 658 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 659 | TestBitrateObserver not_enforced_observer; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 660 | AddObserver(¬_enforced_observer, 30000, 2500000, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 661 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 662 | EXPECT_EQ(270000, allocator_->GetStartBitrate(¬_enforced_observer)); |
| 663 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 664 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 665 | allocator_->OnNetworkEstimateChanged( |
| 666 | CreateTargetRateMessage(36000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 667 | EXPECT_EQ(6000u, enforced_observer.last_bitrate_bps_); |
| 668 | EXPECT_EQ(30000u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 669 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 670 | allocator_->OnNetworkEstimateChanged( |
| 671 | CreateTargetRateMessage(35000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 672 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
| 673 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 674 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 675 | allocator_->OnNetworkEstimateChanged( |
| 676 | CreateTargetRateMessage(5000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 677 | EXPECT_EQ(6000u, enforced_observer.last_bitrate_bps_); |
| 678 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 679 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 680 | allocator_->OnNetworkEstimateChanged( |
| 681 | CreateTargetRateMessage(36000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 682 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
| 683 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 684 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 685 | allocator_->OnNetworkEstimateChanged( |
| 686 | CreateTargetRateMessage(55000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 687 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
| 688 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 689 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 690 | allocator_->OnNetworkEstimateChanged( |
| 691 | CreateTargetRateMessage(56000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 692 | EXPECT_EQ(6000u, enforced_observer.last_bitrate_bps_); |
| 693 | EXPECT_EQ(50000u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 694 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 695 | allocator_->OnNetworkEstimateChanged( |
| 696 | CreateTargetRateMessage(56000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 697 | EXPECT_EQ(16000u, enforced_observer.last_bitrate_bps_); |
| 698 | EXPECT_EQ(40000u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 699 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 700 | allocator_->RemoveObserver(&enforced_observer); |
| 701 | allocator_->RemoveObserver(¬_enforced_observer); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 702 | } |
| 703 | |
| 704 | TEST_F(BitrateAllocatorTest, AvoidToggleAbsolute) { |
| 705 | TestBitrateObserver observer; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 706 | AddObserver(&observer, 30000, 300000, 0, false, kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 707 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&observer)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 708 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 709 | allocator_->OnNetworkEstimateChanged( |
| 710 | CreateTargetRateMessage(30000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 711 | EXPECT_EQ(30000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 712 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 713 | allocator_->OnNetworkEstimateChanged( |
| 714 | CreateTargetRateMessage(20000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 715 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 716 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 717 | allocator_->OnNetworkEstimateChanged( |
| 718 | CreateTargetRateMessage(30000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 719 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 720 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 721 | allocator_->OnNetworkEstimateChanged( |
| 722 | CreateTargetRateMessage(49000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 723 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 724 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 725 | allocator_->OnNetworkEstimateChanged( |
| 726 | CreateTargetRateMessage(50000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 727 | EXPECT_EQ(50000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 728 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 729 | allocator_->OnNetworkEstimateChanged( |
| 730 | CreateTargetRateMessage(30000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 731 | EXPECT_EQ(30000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 732 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 733 | allocator_->RemoveObserver(&observer); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 734 | } |
| 735 | |
| 736 | TEST_F(BitrateAllocatorTest, AvoidTogglePercent) { |
| 737 | TestBitrateObserver observer; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 738 | AddObserver(&observer, 300000, 600000, 0, false, kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 739 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&observer)); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 740 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 741 | allocator_->OnNetworkEstimateChanged( |
| 742 | CreateTargetRateMessage(300000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 743 | EXPECT_EQ(300000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 744 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 745 | allocator_->OnNetworkEstimateChanged( |
| 746 | CreateTargetRateMessage(200000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 747 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 748 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 749 | allocator_->OnNetworkEstimateChanged( |
| 750 | CreateTargetRateMessage(300000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 751 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 752 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 753 | allocator_->OnNetworkEstimateChanged( |
| 754 | CreateTargetRateMessage(329000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 755 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 756 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 757 | allocator_->OnNetworkEstimateChanged( |
| 758 | CreateTargetRateMessage(330000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 759 | EXPECT_EQ(330000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 760 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 761 | allocator_->OnNetworkEstimateChanged( |
| 762 | CreateTargetRateMessage(300000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 763 | EXPECT_EQ(300000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 17:21:19 +0200 | [diff] [blame] | 764 | |
mflodman | 48a4beb | 2016-07-01 13:03:59 +0200 | [diff] [blame] | 765 | allocator_->RemoveObserver(&observer); |
perkj | fea9309 | 2016-05-14 00:58:48 -0700 | [diff] [blame] | 766 | } |
| 767 | |
minyue | 78b4d56 | 2016-11-30 04:47:39 -0800 | [diff] [blame] | 768 | TEST_F(BitrateAllocatorTest, PassProbingInterval) { |
| 769 | TestBitrateObserver observer; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 770 | AddObserver(&observer, 300000, 600000, 0, false, kDefaultBitratePriority); |
minyue | 78b4d56 | 2016-11-30 04:47:39 -0800 | [diff] [blame] | 771 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&observer)); |
| 772 | |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 773 | allocator_->OnNetworkEstimateChanged( |
| 774 | CreateTargetRateMessage(300000, 0, 50, 5000)); |
minyue | 78b4d56 | 2016-11-30 04:47:39 -0800 | [diff] [blame] | 775 | EXPECT_EQ(5000, observer.last_probing_interval_ms_); |
| 776 | |
| 777 | allocator_->RemoveObserver(&observer); |
| 778 | } |
| 779 | |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 780 | TEST_F(BitrateAllocatorTest, PriorityRateOneObserverBasic) { |
| 781 | TestBitrateObserver observer; |
| 782 | const uint32_t kMinSendBitrateBps = 10; |
| 783 | const uint32_t kMaxSendBitrateBps = 60; |
| 784 | const uint32_t kNetworkBandwidthBps = 30; |
| 785 | |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 786 | AddObserver(&observer, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, 2.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 787 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 788 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 789 | |
| 790 | EXPECT_EQ(kNetworkBandwidthBps, observer.last_bitrate_bps_); |
| 791 | |
| 792 | allocator_->RemoveObserver(&observer); |
| 793 | } |
| 794 | |
| 795 | // Tests that two observers with the same bitrate priority are allocated |
| 796 | // their bitrate evenly. |
| 797 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversBasic) { |
| 798 | TestBitrateObserver observer_low_1; |
| 799 | TestBitrateObserver observer_low_2; |
| 800 | const uint32_t kMinSendBitrateBps = 10; |
| 801 | const uint32_t kMaxSendBitrateBps = 60; |
| 802 | const uint32_t kNetworkBandwidthBps = 60; |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 803 | AddObserver(&observer_low_1, kMinSendBitrateBps, kMaxSendBitrateBps, 0, false, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 804 | 2.0); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 805 | AddObserver(&observer_low_2, kMinSendBitrateBps, kMaxSendBitrateBps, 0, false, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 806 | 2.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 807 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 808 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 809 | |
| 810 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_1.last_bitrate_bps_); |
| 811 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_2.last_bitrate_bps_); |
| 812 | |
| 813 | allocator_->RemoveObserver(&observer_low_1); |
| 814 | allocator_->RemoveObserver(&observer_low_2); |
| 815 | } |
| 816 | |
| 817 | // Tests that there is no difference in functionality when the min bitrate is |
| 818 | // enforced. |
| 819 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversBasicMinEnforced) { |
| 820 | TestBitrateObserver observer_low_1; |
| 821 | TestBitrateObserver observer_low_2; |
| 822 | const uint32_t kMinSendBitrateBps = 0; |
| 823 | const uint32_t kMaxSendBitrateBps = 60; |
| 824 | const uint32_t kNetworkBandwidthBps = 60; |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 825 | AddObserver(&observer_low_1, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 826 | 2.0); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 827 | AddObserver(&observer_low_2, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 828 | 2.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 829 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 830 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 831 | |
| 832 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_1.last_bitrate_bps_); |
| 833 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_2.last_bitrate_bps_); |
| 834 | |
| 835 | allocator_->RemoveObserver(&observer_low_1); |
| 836 | allocator_->RemoveObserver(&observer_low_2); |
| 837 | } |
| 838 | |
| 839 | // Tests that if the available bandwidth is the sum of the max bitrate |
| 840 | // of all observers, they will be allocated their max. |
| 841 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversBothAllocatedMax) { |
| 842 | TestBitrateObserver observer_low; |
| 843 | TestBitrateObserver observer_mid; |
| 844 | const uint32_t kMinSendBitrateBps = 0; |
| 845 | const uint32_t kMaxSendBitrateBps = 60; |
| 846 | const uint32_t kNetworkBandwidthBps = kMaxSendBitrateBps * 2; |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 847 | AddObserver(&observer_low, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 848 | 2.0); |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 849 | AddObserver(&observer_mid, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 850 | 4.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 851 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 852 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 853 | |
| 854 | EXPECT_EQ(kMaxSendBitrateBps, observer_low.last_bitrate_bps_); |
| 855 | EXPECT_EQ(kMaxSendBitrateBps, observer_mid.last_bitrate_bps_); |
| 856 | |
| 857 | allocator_->RemoveObserver(&observer_low); |
| 858 | allocator_->RemoveObserver(&observer_mid); |
| 859 | } |
| 860 | |
| 861 | // Tests that after a higher bitrate priority observer has been allocated its |
| 862 | // max bitrate the lower priority observer will then be allocated the remaining |
| 863 | // bitrate. |
| 864 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversOneAllocatedToMax) { |
| 865 | TestBitrateObserver observer_low; |
| 866 | TestBitrateObserver observer_mid; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 867 | AddObserver(&observer_low, 10, 50, 0, false, 2.0); |
| 868 | AddObserver(&observer_mid, 10, 50, 0, false, 4.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 869 | allocator_->OnNetworkEstimateChanged( |
| 870 | CreateTargetRateMessage(90, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 871 | |
| 872 | EXPECT_EQ(40u, observer_low.last_bitrate_bps_); |
| 873 | EXPECT_EQ(50u, observer_mid.last_bitrate_bps_); |
| 874 | |
| 875 | allocator_->RemoveObserver(&observer_low); |
| 876 | allocator_->RemoveObserver(&observer_mid); |
| 877 | } |
| 878 | |
| 879 | // Tests that three observers with three different bitrate priorities will all |
| 880 | // be allocated bitrate according to their relative bitrate priority. |
| 881 | TEST_F(BitrateAllocatorTest, |
| 882 | PriorityRateThreeObserversAllocatedRelativeAmounts) { |
| 883 | TestBitrateObserver observer_low; |
| 884 | TestBitrateObserver observer_mid; |
| 885 | TestBitrateObserver observer_high; |
| 886 | const uint32_t kMaxBitrate = 100; |
| 887 | // Not enough bandwidth to fill any observer's max bitrate. |
| 888 | const uint32_t kNetworkBandwidthBps = 70; |
| 889 | const double kLowBitratePriority = 2.0; |
| 890 | const double kMidBitratePriority = 4.0; |
| 891 | const double kHighBitratePriority = 8.0; |
| 892 | const double kTotalBitratePriority = |
| 893 | kLowBitratePriority + kMidBitratePriority + kHighBitratePriority; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 894 | AddObserver(&observer_low, 0, kMaxBitrate, 0, false, kLowBitratePriority); |
| 895 | AddObserver(&observer_mid, 0, kMaxBitrate, 0, false, kMidBitratePriority); |
| 896 | AddObserver(&observer_high, 0, kMaxBitrate, 0, false, kHighBitratePriority); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 897 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 898 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 899 | |
| 900 | const double kLowFractionAllocated = |
| 901 | kLowBitratePriority / kTotalBitratePriority; |
| 902 | const double kMidFractionAllocated = |
| 903 | kMidBitratePriority / kTotalBitratePriority; |
| 904 | const double kHighFractionAllocated = |
| 905 | kHighBitratePriority / kTotalBitratePriority; |
| 906 | EXPECT_EQ(kLowFractionAllocated * kNetworkBandwidthBps, |
| 907 | observer_low.last_bitrate_bps_); |
| 908 | EXPECT_EQ(kMidFractionAllocated * kNetworkBandwidthBps, |
| 909 | observer_mid.last_bitrate_bps_); |
| 910 | EXPECT_EQ(kHighFractionAllocated * kNetworkBandwidthBps, |
| 911 | observer_high.last_bitrate_bps_); |
| 912 | |
| 913 | allocator_->RemoveObserver(&observer_low); |
| 914 | allocator_->RemoveObserver(&observer_mid); |
| 915 | allocator_->RemoveObserver(&observer_high); |
| 916 | } |
| 917 | |
| 918 | // Tests that after the high priority observer has been allocated its maximum |
| 919 | // bitrate, the other two observers are still allocated bitrate according to |
| 920 | // their relative bitrate priority. |
| 921 | TEST_F(BitrateAllocatorTest, PriorityRateThreeObserversHighAllocatedToMax) { |
| 922 | TestBitrateObserver observer_low; |
| 923 | const double kLowBitratePriority = 2.0; |
| 924 | TestBitrateObserver observer_mid; |
| 925 | const double kMidBitratePriority = 4.0; |
| 926 | TestBitrateObserver observer_high; |
| 927 | const double kHighBitratePriority = 8.0; |
| 928 | |
| 929 | const uint32_t kAvailableBitrate = 90; |
| 930 | const uint32_t kMaxBitrate = 40; |
| 931 | const uint32_t kMinBitrate = 10; |
| 932 | // Remaining bitrate after allocating to all mins and knowing that the high |
| 933 | // priority observer will have its max bitrate allocated. |
| 934 | const uint32_t kRemainingBitrate = |
| 935 | kAvailableBitrate - kMaxBitrate - (2 * kMinBitrate); |
| 936 | |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 937 | AddObserver(&observer_low, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 938 | kLowBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 939 | AddObserver(&observer_mid, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 940 | kMidBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 941 | AddObserver(&observer_high, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 942 | kHighBitratePriority); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 943 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 944 | kAvailableBitrate, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 945 | |
| 946 | const double kLowFractionAllocated = |
| 947 | kLowBitratePriority / (kLowBitratePriority + kMidBitratePriority); |
| 948 | const double kMidFractionAllocated = |
| 949 | kMidBitratePriority / (kLowBitratePriority + kMidBitratePriority); |
| 950 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kLowFractionAllocated), |
| 951 | observer_low.last_bitrate_bps_); |
| 952 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kMidFractionAllocated), |
| 953 | observer_mid.last_bitrate_bps_); |
| 954 | EXPECT_EQ(40u, observer_high.last_bitrate_bps_); |
| 955 | |
| 956 | allocator_->RemoveObserver(&observer_low); |
| 957 | allocator_->RemoveObserver(&observer_mid); |
| 958 | allocator_->RemoveObserver(&observer_high); |
| 959 | } |
| 960 | |
| 961 | // Tests that after the low priority observer has been allocated its maximum |
| 962 | // bitrate, the other two observers are still allocated bitrate according to |
| 963 | // their relative bitrate priority. |
| 964 | TEST_F(BitrateAllocatorTest, PriorityRateThreeObserversLowAllocatedToMax) { |
| 965 | TestBitrateObserver observer_low; |
| 966 | const double kLowBitratePriority = 2.0; |
| 967 | const uint32_t kLowMaxBitrate = 10; |
| 968 | TestBitrateObserver observer_mid; |
| 969 | const double kMidBitratePriority = 4.0; |
| 970 | TestBitrateObserver observer_high; |
| 971 | const double kHighBitratePriority = 8.0; |
| 972 | |
| 973 | const uint32_t kMinBitrate = 0; |
| 974 | const uint32_t kMaxBitrate = 60; |
| 975 | const uint32_t kAvailableBitrate = 100; |
| 976 | // Remaining bitrate knowing that the low priority observer is allocated its |
| 977 | // max bitrate. We know this because it is allocated 2.0/14.0 (1/7) of the |
| 978 | // available bitrate, so 70 bps would be sufficient network bandwidth. |
| 979 | const uint32_t kRemainingBitrate = kAvailableBitrate - kLowMaxBitrate; |
| 980 | |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 981 | AddObserver(&observer_low, kMinBitrate, kLowMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 982 | kLowBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 983 | AddObserver(&observer_mid, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 984 | kMidBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 985 | AddObserver(&observer_high, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 08:25:12 +0200 | [diff] [blame] | 986 | kHighBitratePriority); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 987 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 988 | kAvailableBitrate, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 989 | |
| 990 | const double kMidFractionAllocated = |
| 991 | kMidBitratePriority / (kMidBitratePriority + kHighBitratePriority); |
| 992 | const double kHighFractionAllocated = |
| 993 | kHighBitratePriority / (kMidBitratePriority + kHighBitratePriority); |
| 994 | EXPECT_EQ(kLowMaxBitrate, observer_low.last_bitrate_bps_); |
| 995 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kMidFractionAllocated), |
| 996 | observer_mid.last_bitrate_bps_); |
| 997 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kHighFractionAllocated), |
| 998 | observer_high.last_bitrate_bps_); |
| 999 | |
| 1000 | allocator_->RemoveObserver(&observer_low); |
| 1001 | allocator_->RemoveObserver(&observer_mid); |
| 1002 | allocator_->RemoveObserver(&observer_high); |
| 1003 | } |
| 1004 | |
| 1005 | // Tests that after two observers are allocated bitrate to their max, the |
| 1006 | // the remaining observer is allocated what's left appropriately. This test |
| 1007 | // handles an edge case where the medium and high observer reach their |
| 1008 | // "relative" max allocation at the same time. The high has 40 to allocate |
| 1009 | // above its min, and the mid has 20 to allocate above its min, which scaled |
| 1010 | // by their bitrate priority is the same for each. |
| 1011 | TEST_F(BitrateAllocatorTest, PriorityRateThreeObserversTwoAllocatedToMax) { |
| 1012 | TestBitrateObserver observer_low; |
| 1013 | TestBitrateObserver observer_mid; |
| 1014 | TestBitrateObserver observer_high; |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 1015 | AddObserver(&observer_low, 10, 40, 0, false, 2.0); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 1016 | // Scaled allocation above the min allocation is the same for these two, |
| 1017 | // meaning they will get allocated their max at the same time. |
| 1018 | // Scaled (target allocation) = (max - min) / bitrate priority |
Jonas Olsson | 0182a03 | 2019-07-09 12:31:20 +0200 | [diff] [blame] | 1019 | AddObserver(&observer_mid, 10, 30, 0, false, 4.0); |
| 1020 | AddObserver(&observer_high, 10, 50, 0, false, 8.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 14:54:43 +0200 | [diff] [blame] | 1021 | allocator_->OnNetworkEstimateChanged( |
| 1022 | CreateTargetRateMessage(110, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 10:49:06 -0800 | [diff] [blame] | 1023 | |
| 1024 | EXPECT_EQ(30u, observer_low.last_bitrate_bps_); |
| 1025 | EXPECT_EQ(30u, observer_mid.last_bitrate_bps_); |
| 1026 | EXPECT_EQ(50u, observer_high.last_bitrate_bps_); |
| 1027 | |
| 1028 | allocator_->RemoveObserver(&observer_low); |
| 1029 | allocator_->RemoveObserver(&observer_mid); |
| 1030 | allocator_->RemoveObserver(&observer_high); |
| 1031 | } |
| 1032 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 +0000 | [diff] [blame] | 1033 | } // namespace webrtc |