eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 11 | #include "call/rtcp_demuxer.h" |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 12 | |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 13 | #include <stddef.h> |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame] | 14 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 15 | #include <set> |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 16 | |
Patrik Höglund | 3e11343 | 2017-12-15 14:40:10 +0100 | [diff] [blame] | 17 | #include "api/rtp_headers.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 18 | #include "call/rtcp_packet_sink_interface.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "modules/rtp_rtcp/source/rtcp_packet/bye.h" |
Niels Möller | d57efc1 | 2019-03-22 14:02:11 +0100 | [diff] [blame] | 20 | #include "modules/rtp_rtcp/source/rtp_header_extensions.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 21 | #include "rtc_base/arraysize.h" |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 22 | #include "rtc_base/buffer.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 23 | #include "rtc_base/checks.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 24 | #include "test/gmock.h" |
| 25 | #include "test/gtest.h" |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 26 | |
| 27 | namespace webrtc { |
| 28 | |
| 29 | namespace { |
| 30 | |
| 31 | using ::testing::_; |
| 32 | using ::testing::AtLeast; |
| 33 | using ::testing::ElementsAreArray; |
| 34 | using ::testing::InSequence; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 35 | using ::testing::Matcher; |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 36 | using ::testing::NiceMock; |
| 37 | |
| 38 | class MockRtcpPacketSink : public RtcpPacketSinkInterface { |
| 39 | public: |
| 40 | MOCK_METHOD1(OnRtcpPacket, void(rtc::ArrayView<const uint8_t>)); |
| 41 | }; |
| 42 | |
Mirko Bonadei | 6a489f2 | 2019-04-09 15:11:12 +0200 | [diff] [blame] | 43 | class RtcpDemuxerTest : public ::testing::Test { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 44 | protected: |
| 45 | ~RtcpDemuxerTest() { |
| 46 | for (auto* sink : sinks_to_tear_down_) { |
| 47 | demuxer_.RemoveSink(sink); |
| 48 | } |
| 49 | for (auto* sink : broadcast_sinks_to_tear_down_) { |
| 50 | demuxer_.RemoveBroadcastSink(sink); |
| 51 | } |
| 52 | } |
| 53 | |
| 54 | void AddSsrcSink(uint32_t ssrc, RtcpPacketSinkInterface* sink) { |
| 55 | demuxer_.AddSink(ssrc, sink); |
| 56 | sinks_to_tear_down_.insert(sink); |
| 57 | } |
| 58 | |
| 59 | void AddRsidSink(const std::string& rsid, RtcpPacketSinkInterface* sink) { |
| 60 | demuxer_.AddSink(rsid, sink); |
| 61 | sinks_to_tear_down_.insert(sink); |
| 62 | } |
| 63 | |
| 64 | void RemoveSink(RtcpPacketSinkInterface* sink) { |
| 65 | sinks_to_tear_down_.erase(sink); |
| 66 | demuxer_.RemoveSink(sink); |
| 67 | } |
| 68 | |
| 69 | void AddBroadcastSink(RtcpPacketSinkInterface* sink) { |
| 70 | demuxer_.AddBroadcastSink(sink); |
| 71 | broadcast_sinks_to_tear_down_.insert(sink); |
| 72 | } |
| 73 | |
| 74 | void RemoveBroadcastSink(RtcpPacketSinkInterface* sink) { |
| 75 | broadcast_sinks_to_tear_down_.erase(sink); |
| 76 | demuxer_.RemoveBroadcastSink(sink); |
| 77 | } |
| 78 | |
| 79 | RtcpDemuxer demuxer_; |
| 80 | std::set<RtcpPacketSinkInterface*> sinks_to_tear_down_; |
| 81 | std::set<RtcpPacketSinkInterface*> broadcast_sinks_to_tear_down_; |
| 82 | }; |
| 83 | |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 84 | // Produces a packet buffer representing an RTCP packet with a given SSRC, |
| 85 | // as it would look when sent over the wire. |
| 86 | // |distinguishing_string| allows different RTCP packets with the same SSRC |
| 87 | // to be distinguished. How this is set into the actual packet is |
| 88 | // unimportant, and depends on which RTCP message we choose to use. |
| 89 | rtc::Buffer CreateRtcpPacket(uint32_t ssrc, |
| 90 | const std::string& distinguishing_string = "") { |
| 91 | rtcp::Bye packet; |
| 92 | packet.SetSenderSsrc(ssrc); |
| 93 | if (distinguishing_string != "") { |
| 94 | // Actual way we use |distinguishing_string| is unimportant, so long |
| 95 | // as it ends up in the packet. |
| 96 | packet.SetReason(distinguishing_string); |
| 97 | } |
| 98 | return packet.Build(); |
| 99 | } |
| 100 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 101 | static Matcher<rtc::ArrayView<const uint8_t>> SamePacketAs( |
| 102 | const rtc::Buffer& other) { |
| 103 | return ElementsAreArray(other.cbegin(), other.cend()); |
| 104 | } |
| 105 | |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 106 | } // namespace |
| 107 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 108 | TEST_F(RtcpDemuxerTest, OnRtcpPacketCalledOnCorrectSinkBySsrc) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 109 | constexpr uint32_t ssrcs[] = {101, 202, 303}; |
| 110 | MockRtcpPacketSink sinks[arraysize(ssrcs)]; |
| 111 | for (size_t i = 0; i < arraysize(ssrcs); i++) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 112 | AddSsrcSink(ssrcs[i], &sinks[i]); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 113 | } |
| 114 | |
| 115 | for (size_t i = 0; i < arraysize(ssrcs); i++) { |
| 116 | auto packet = CreateRtcpPacket(ssrcs[i]); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 117 | EXPECT_CALL(sinks[i], OnRtcpPacket(SamePacketAs(packet))).Times(1); |
| 118 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 119 | } |
| 120 | } |
| 121 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 122 | TEST_F(RtcpDemuxerTest, OnRtcpPacketCalledOnResolvedRsidSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 123 | // Set up some RSID sinks. |
| 124 | const std::string rsids[] = {"a", "b", "c"}; |
| 125 | MockRtcpPacketSink sinks[arraysize(rsids)]; |
| 126 | for (size_t i = 0; i < arraysize(rsids); i++) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 127 | AddRsidSink(rsids[i], &sinks[i]); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 128 | } |
| 129 | |
| 130 | // Only resolve one of the sinks. |
| 131 | constexpr size_t resolved_sink_index = 0; |
| 132 | constexpr uint32_t ssrc = 345; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 133 | demuxer_.OnSsrcBoundToRsid(rsids[resolved_sink_index], ssrc); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 134 | |
| 135 | // The resolved sink gets notifications of RTCP messages with its SSRC. |
| 136 | auto packet = CreateRtcpPacket(ssrc); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 137 | EXPECT_CALL(sinks[resolved_sink_index], OnRtcpPacket(SamePacketAs(packet))) |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 138 | .Times(1); |
| 139 | |
| 140 | // RTCP received; expected calls triggered. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 141 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 142 | } |
| 143 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 144 | TEST_F(RtcpDemuxerTest, |
| 145 | SingleCallbackAfterResolutionOfAnRsidToAlreadyRegisteredSsrc) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 146 | // Associate a sink with an SSRC. |
| 147 | MockRtcpPacketSink sink; |
| 148 | constexpr uint32_t ssrc = 999; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 149 | AddSsrcSink(ssrc, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 150 | |
| 151 | // Associate the same sink with an RSID. |
| 152 | const std::string rsid = "r"; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 153 | AddRsidSink(rsid, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 154 | |
| 155 | // Resolve the RSID to the aforementioned SSRC. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 156 | demuxer_.OnSsrcBoundToRsid(rsid, ssrc); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 157 | |
| 158 | // OnRtcpPacket still called only a single time for messages with this SSRC. |
| 159 | auto packet = CreateRtcpPacket(ssrc); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 160 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))).Times(1); |
| 161 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 162 | } |
| 163 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 164 | TEST_F(RtcpDemuxerTest, |
| 165 | OnRtcpPacketCalledOnAllBroadcastSinksForAllRtcpPackets) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 166 | MockRtcpPacketSink sinks[3]; |
| 167 | for (MockRtcpPacketSink& sink : sinks) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 168 | AddBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 169 | } |
| 170 | |
| 171 | constexpr uint32_t ssrc = 747; |
| 172 | auto packet = CreateRtcpPacket(ssrc); |
| 173 | |
| 174 | for (MockRtcpPacketSink& sink : sinks) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 175 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))).Times(1); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 176 | } |
| 177 | |
| 178 | // RTCP received; expected calls triggered. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 179 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 180 | } |
| 181 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 182 | TEST_F(RtcpDemuxerTest, PacketsDeliveredInRightOrderToNonBroadcastSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 183 | constexpr uint32_t ssrc = 101; |
| 184 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 185 | AddSsrcSink(ssrc, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 186 | |
| 187 | std::vector<rtc::Buffer> packets; |
| 188 | for (size_t i = 0; i < 5; i++) { |
| 189 | packets.push_back(CreateRtcpPacket(ssrc, std::to_string(i))); |
| 190 | } |
| 191 | |
| 192 | InSequence sequence; |
| 193 | for (const auto& packet : packets) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 194 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))).Times(1); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 195 | } |
| 196 | |
| 197 | for (const auto& packet : packets) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 198 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 199 | } |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 200 | } |
| 201 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 202 | TEST_F(RtcpDemuxerTest, PacketsDeliveredInRightOrderToBroadcastSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 203 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 204 | AddBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 205 | |
| 206 | std::vector<rtc::Buffer> packets; |
| 207 | for (size_t i = 0; i < 5; i++) { |
| 208 | constexpr uint32_t ssrc = 101; |
| 209 | packets.push_back(CreateRtcpPacket(ssrc, std::to_string(i))); |
| 210 | } |
| 211 | |
| 212 | InSequence sequence; |
| 213 | for (const auto& packet : packets) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 214 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))).Times(1); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 215 | } |
| 216 | |
| 217 | for (const auto& packet : packets) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 218 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 219 | } |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 220 | } |
| 221 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 222 | TEST_F(RtcpDemuxerTest, MultipleSinksMappedToSameSsrc) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 223 | MockRtcpPacketSink sinks[3]; |
| 224 | constexpr uint32_t ssrc = 404; |
| 225 | for (auto& sink : sinks) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 226 | AddSsrcSink(ssrc, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 227 | } |
| 228 | |
| 229 | // Reception of an RTCP packet associated with the shared SSRC triggers the |
| 230 | // callback on all of the sinks associated with it. |
| 231 | auto packet = CreateRtcpPacket(ssrc); |
| 232 | for (auto& sink : sinks) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 233 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 234 | } |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 235 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 236 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 237 | } |
| 238 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 239 | TEST_F(RtcpDemuxerTest, SinkMappedToMultipleSsrcs) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 240 | constexpr uint32_t ssrcs[] = {404, 505, 606}; |
| 241 | MockRtcpPacketSink sink; |
| 242 | for (uint32_t ssrc : ssrcs) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 243 | AddSsrcSink(ssrc, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 244 | } |
| 245 | |
| 246 | // The sink which is associated with multiple SSRCs gets the callback |
| 247 | // triggered for each of those SSRCs. |
| 248 | for (uint32_t ssrc : ssrcs) { |
| 249 | auto packet = CreateRtcpPacket(ssrc); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 250 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))); |
| 251 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 252 | } |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 253 | } |
| 254 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 255 | TEST_F(RtcpDemuxerTest, MultipleRsidsOnSameSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 256 | // Sink associated with multiple sinks. |
| 257 | MockRtcpPacketSink sink; |
| 258 | const std::string rsids[] = {"a", "b", "c"}; |
| 259 | for (const auto& rsid : rsids) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 260 | AddRsidSink(rsid, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 261 | } |
| 262 | |
| 263 | // RSIDs resolved to SSRCs. |
| 264 | uint32_t ssrcs[arraysize(rsids)]; |
| 265 | for (size_t i = 0; i < arraysize(rsids); i++) { |
| 266 | ssrcs[i] = 1000 + static_cast<uint32_t>(i); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 267 | demuxer_.OnSsrcBoundToRsid(rsids[i], ssrcs[i]); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 268 | } |
| 269 | |
| 270 | // Set up packets to match those RSIDs/SSRCs. |
| 271 | std::vector<rtc::Buffer> packets; |
| 272 | for (size_t i = 0; i < arraysize(rsids); i++) { |
| 273 | packets.push_back(CreateRtcpPacket(ssrcs[i])); |
| 274 | } |
| 275 | |
| 276 | // The sink expects to receive all of the packets. |
| 277 | for (const auto& packet : packets) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 278 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))).Times(1); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 279 | } |
| 280 | |
| 281 | // Packet demuxed correctly; OnRtcpPacket() triggered on sink. |
| 282 | for (const auto& packet : packets) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 283 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 284 | } |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 285 | } |
| 286 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 287 | TEST_F(RtcpDemuxerTest, RsidUsedByMultipleSinks) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 288 | MockRtcpPacketSink sinks[3]; |
| 289 | const std::string shared_rsid = "a"; |
| 290 | |
| 291 | for (MockRtcpPacketSink& sink : sinks) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 292 | AddRsidSink(shared_rsid, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 293 | } |
| 294 | |
| 295 | constexpr uint32_t shared_ssrc = 888; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 296 | demuxer_.OnSsrcBoundToRsid(shared_rsid, shared_ssrc); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 297 | |
| 298 | auto packet = CreateRtcpPacket(shared_ssrc); |
| 299 | |
| 300 | for (MockRtcpPacketSink& sink : sinks) { |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 301 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet))).Times(1); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 302 | } |
| 303 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 304 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 305 | } |
| 306 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 307 | TEST_F(RtcpDemuxerTest, NoCallbackOnSsrcSinkRemovedBeforeFirstPacket) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 308 | constexpr uint32_t ssrc = 404; |
| 309 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 310 | AddSsrcSink(ssrc, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 311 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 312 | RemoveSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 313 | |
| 314 | // The removed sink does not get callbacks. |
| 315 | auto packet = CreateRtcpPacket(ssrc); |
| 316 | EXPECT_CALL(sink, OnRtcpPacket(_)).Times(0); // Not called. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 317 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 318 | } |
| 319 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 320 | TEST_F(RtcpDemuxerTest, NoCallbackOnSsrcSinkRemovedAfterFirstPacket) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 321 | constexpr uint32_t ssrc = 404; |
| 322 | NiceMock<MockRtcpPacketSink> sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 323 | AddSsrcSink(ssrc, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 324 | |
| 325 | auto before_packet = CreateRtcpPacket(ssrc); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 326 | demuxer_.OnRtcpPacket(before_packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 327 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 328 | RemoveSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 329 | |
| 330 | // The removed sink does not get callbacks. |
| 331 | auto after_packet = CreateRtcpPacket(ssrc); |
| 332 | EXPECT_CALL(sink, OnRtcpPacket(_)).Times(0); // Not called. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 333 | demuxer_.OnRtcpPacket(after_packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 334 | } |
| 335 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 336 | TEST_F(RtcpDemuxerTest, NoCallbackOnRsidSinkRemovedBeforeRsidResolution) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 337 | const std::string rsid = "a"; |
| 338 | constexpr uint32_t ssrc = 404; |
| 339 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 340 | AddRsidSink(rsid, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 341 | |
| 342 | // Removal before resolution. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 343 | RemoveSink(&sink); |
| 344 | demuxer_.OnSsrcBoundToRsid(rsid, ssrc); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 345 | |
| 346 | // The removed sink does not get callbacks. |
| 347 | auto packet = CreateRtcpPacket(ssrc); |
| 348 | EXPECT_CALL(sink, OnRtcpPacket(_)).Times(0); // Not called. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 349 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 350 | } |
| 351 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 352 | TEST_F(RtcpDemuxerTest, NoCallbackOnRsidSinkRemovedAfterRsidResolution) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 353 | const std::string rsid = "a"; |
| 354 | constexpr uint32_t ssrc = 404; |
| 355 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 356 | AddRsidSink(rsid, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 357 | |
| 358 | // Removal after resolution. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 359 | demuxer_.OnSsrcBoundToRsid(rsid, ssrc); |
| 360 | RemoveSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 361 | |
| 362 | // The removed sink does not get callbacks. |
| 363 | auto packet = CreateRtcpPacket(ssrc); |
| 364 | EXPECT_CALL(sink, OnRtcpPacket(_)).Times(0); // Not called. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 365 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 366 | } |
| 367 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 368 | TEST_F(RtcpDemuxerTest, NoCallbackOnBroadcastSinkRemovedBeforeFirstPacket) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 369 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 370 | AddBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 371 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 372 | RemoveBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 373 | |
| 374 | // The removed sink does not get callbacks. |
| 375 | constexpr uint32_t ssrc = 404; |
| 376 | auto packet = CreateRtcpPacket(ssrc); |
| 377 | EXPECT_CALL(sink, OnRtcpPacket(_)).Times(0); // Not called. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 378 | demuxer_.OnRtcpPacket(packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 379 | } |
| 380 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 381 | TEST_F(RtcpDemuxerTest, NoCallbackOnBroadcastSinkRemovedAfterFirstPacket) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 382 | NiceMock<MockRtcpPacketSink> sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 383 | AddBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 384 | |
| 385 | constexpr uint32_t ssrc = 404; |
| 386 | auto before_packet = CreateRtcpPacket(ssrc); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 387 | demuxer_.OnRtcpPacket(before_packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 388 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 389 | RemoveBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 390 | |
| 391 | // The removed sink does not get callbacks. |
| 392 | auto after_packet = CreateRtcpPacket(ssrc); |
| 393 | EXPECT_CALL(sink, OnRtcpPacket(_)).Times(0); // Not called. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 394 | demuxer_.OnRtcpPacket(after_packet); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 395 | } |
| 396 | |
| 397 | // The RSID to SSRC mapping should be one-to-one. If we end up receiving |
| 398 | // two (or more) packets with the same SSRC, but different RSIDs, we guarantee |
| 399 | // remembering the first one; no guarantees are made about further associations. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 400 | TEST_F(RtcpDemuxerTest, FirstResolutionOfRsidNotForgotten) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 401 | MockRtcpPacketSink sink; |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 402 | const std::string rsid = "a"; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 403 | AddRsidSink(rsid, &sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 404 | |
| 405 | constexpr uint32_t ssrc_a = 111; // First resolution - guaranteed effective. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 406 | demuxer_.OnSsrcBoundToRsid(rsid, ssrc_a); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 407 | |
| 408 | constexpr uint32_t ssrc_b = 222; // Second resolution - no guarantees. |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 409 | demuxer_.OnSsrcBoundToRsid(rsid, ssrc_b); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 410 | |
| 411 | auto packet_a = CreateRtcpPacket(ssrc_a); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 412 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet_a))).Times(1); |
| 413 | demuxer_.OnRtcpPacket(packet_a); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 414 | |
| 415 | auto packet_b = CreateRtcpPacket(ssrc_b); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 416 | EXPECT_CALL(sink, OnRtcpPacket(SamePacketAs(packet_b))).Times(AtLeast(0)); |
| 417 | demuxer_.OnRtcpPacket(packet_b); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 418 | } |
| 419 | |
| 420 | #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 421 | |
| 422 | TEST_F(RtcpDemuxerTest, RepeatedSsrcToSinkAssociationsDisallowed) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 423 | MockRtcpPacketSink sink; |
| 424 | |
| 425 | constexpr uint32_t ssrc = 101; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 426 | AddSsrcSink(ssrc, &sink); |
| 427 | EXPECT_DEATH(AddSsrcSink(ssrc, &sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 428 | } |
| 429 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 430 | TEST_F(RtcpDemuxerTest, RepeatedRsidToSinkAssociationsDisallowed) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 431 | MockRtcpPacketSink sink; |
| 432 | |
| 433 | const std::string rsid = "z"; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 434 | AddRsidSink(rsid, &sink); |
| 435 | EXPECT_DEATH(AddRsidSink(rsid, &sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 436 | } |
| 437 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 438 | TEST_F(RtcpDemuxerTest, RepeatedBroadcastSinkRegistrationDisallowed) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 439 | MockRtcpPacketSink sink; |
| 440 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 441 | AddBroadcastSink(&sink); |
| 442 | EXPECT_DEATH(AddBroadcastSink(&sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 443 | } |
| 444 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 445 | TEST_F(RtcpDemuxerTest, SsrcSinkCannotAlsoBeRegisteredAsBroadcast) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 446 | MockRtcpPacketSink sink; |
| 447 | |
| 448 | constexpr uint32_t ssrc = 101; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 449 | AddSsrcSink(ssrc, &sink); |
| 450 | EXPECT_DEATH(AddBroadcastSink(&sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 451 | } |
| 452 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 453 | TEST_F(RtcpDemuxerTest, RsidSinkCannotAlsoBeRegisteredAsBroadcast) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 454 | MockRtcpPacketSink sink; |
| 455 | |
| 456 | const std::string rsid = "z"; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 457 | AddRsidSink(rsid, &sink); |
| 458 | EXPECT_DEATH(AddBroadcastSink(&sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 459 | } |
| 460 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 461 | TEST_F(RtcpDemuxerTest, BroadcastSinkCannotAlsoBeRegisteredAsSsrcSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 462 | MockRtcpPacketSink sink; |
| 463 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 464 | AddBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 465 | constexpr uint32_t ssrc = 101; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 466 | EXPECT_DEATH(AddSsrcSink(ssrc, &sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 467 | } |
| 468 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 469 | TEST_F(RtcpDemuxerTest, BroadcastSinkCannotAlsoBeRegisteredAsRsidSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 470 | MockRtcpPacketSink sink; |
| 471 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 472 | AddBroadcastSink(&sink); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 473 | const std::string rsid = "j"; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 474 | EXPECT_DEATH(AddRsidSink(rsid, &sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 475 | } |
| 476 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 477 | TEST_F(RtcpDemuxerTest, MayNotCallRemoveSinkOnNeverAddedSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 478 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 479 | EXPECT_DEATH(RemoveSink(&sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 480 | } |
| 481 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 482 | TEST_F(RtcpDemuxerTest, MayNotCallRemoveBroadcastSinkOnNeverAddedSink) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 483 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 484 | EXPECT_DEATH(RemoveBroadcastSink(&sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 485 | } |
| 486 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 487 | TEST_F(RtcpDemuxerTest, RsidMustBeNonEmpty) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 488 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 489 | EXPECT_DEATH(AddRsidSink("", &sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 490 | } |
| 491 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 492 | TEST_F(RtcpDemuxerTest, RsidMustBeAlphaNumeric) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 493 | MockRtcpPacketSink sink; |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 494 | EXPECT_DEATH(AddRsidSink("a_3", &sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 495 | } |
| 496 | |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 497 | TEST_F(RtcpDemuxerTest, RsidMustNotExceedMaximumLength) { |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 498 | MockRtcpPacketSink sink; |
Niels Möller | d57efc1 | 2019-03-22 14:02:11 +0100 | [diff] [blame] | 499 | std::string rsid(BaseRtpStringExtension::kMaxValueSizeBytes + 1, 'a'); |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 500 | EXPECT_DEATH(AddRsidSink(rsid, &sink), ""); |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 501 | } |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 502 | |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 503 | #endif |
Steve Anton | 8018306 | 2017-08-18 11:10:12 -0700 | [diff] [blame] | 504 | |
eladalon | a52722f | 2017-06-26 11:23:54 -0700 | [diff] [blame] | 505 | } // namespace webrtc |