Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <memory> |
| 12 | #include <vector> |
| 13 | |
Karl Wiberg | 1b0eae3 | 2017-10-17 14:48:54 +0200 | [diff] [blame] | 14 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 15 | #include "api/audio_codecs/builtin_audio_encoder_factory.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 16 | #include "api/jsep.h" |
| 17 | #include "api/mediastreaminterface.h" |
| 18 | #include "api/peerconnectioninterface.h" |
| 19 | #include "pc/mediastream.h" |
| 20 | #include "pc/mediastreamtrack.h" |
| 21 | #include "pc/peerconnectionwrapper.h" |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 22 | #include "pc/sdputils.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 23 | #include "pc/test/fakeaudiocapturemodule.h" |
| 24 | #include "pc/test/mockpeerconnectionobservers.h" |
| 25 | #include "rtc_base/checks.h" |
| 26 | #include "rtc_base/gunit.h" |
| 27 | #include "rtc_base/ptr_util.h" |
| 28 | #include "rtc_base/refcountedobject.h" |
| 29 | #include "rtc_base/scoped_ref_ptr.h" |
| 30 | #include "rtc_base/thread.h" |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 31 | #include "test/gmock.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 32 | |
| 33 | // This file contains tests for RTP Media API-related behavior of |
| 34 | // |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api. |
| 35 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 36 | namespace webrtc { |
| 37 | |
| 38 | using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; |
| 39 | using ::testing::ElementsAre; |
| 40 | using ::testing::UnorderedElementsAre; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 41 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 42 | const uint32_t kDefaultTimeout = 10000u; |
| 43 | |
| 44 | template <typename MethodFunctor> |
| 45 | class OnSuccessObserver : public rtc::RefCountedObject< |
| 46 | webrtc::SetRemoteDescriptionObserverInterface> { |
| 47 | public: |
| 48 | explicit OnSuccessObserver(MethodFunctor on_success) |
| 49 | : on_success_(std::move(on_success)) {} |
| 50 | |
| 51 | // webrtc::SetRemoteDescriptionObserverInterface implementation. |
| 52 | void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override { |
| 53 | RTC_CHECK(error.ok()); |
| 54 | on_success_(); |
| 55 | } |
| 56 | |
| 57 | private: |
| 58 | MethodFunctor on_success_; |
| 59 | }; |
| 60 | |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 61 | class PeerConnectionRtpTest : public testing::Test { |
| 62 | public: |
| 63 | PeerConnectionRtpTest() |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 64 | : pc_factory_( |
| 65 | CreatePeerConnectionFactory(rtc::Thread::Current(), |
| 66 | rtc::Thread::Current(), |
| 67 | rtc::Thread::Current(), |
| 68 | FakeAudioCaptureModule::Create(), |
| 69 | CreateBuiltinAudioEncoderFactory(), |
| 70 | CreateBuiltinAudioDecoderFactory(), |
| 71 | nullptr, |
| 72 | nullptr)) {} |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 73 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 74 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() { |
| 75 | return CreatePeerConnection(RTCConfiguration()); |
| 76 | } |
| 77 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 78 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() { |
| 79 | RTCConfiguration config; |
| 80 | config.sdp_semantics = SdpSemantics::kPlanB; |
| 81 | return CreatePeerConnection(config); |
| 82 | } |
| 83 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 84 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() { |
| 85 | RTCConfiguration config; |
| 86 | config.sdp_semantics = SdpSemantics::kUnifiedPlan; |
| 87 | return CreatePeerConnection(config); |
| 88 | } |
| 89 | |
| 90 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection( |
| 91 | const RTCConfiguration& config) { |
| 92 | auto observer = rtc::MakeUnique<MockPeerConnectionObserver>(); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 93 | auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr, |
| 94 | observer.get()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 95 | return rtc::MakeUnique<PeerConnectionWrapper>(pc_factory_, pc, |
| 96 | std::move(observer)); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 97 | } |
| 98 | |
| 99 | protected: |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 100 | rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 101 | }; |
| 102 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 103 | // These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon |
| 104 | // setting the remote description. |
| 105 | class PeerConnectionRtpCallbacksTest : public PeerConnectionRtpTest {}; |
| 106 | |
| 107 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithoutStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 108 | auto caller = CreatePeerConnection(); |
| 109 | auto callee = CreatePeerConnection(); |
| 110 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 111 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"))); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 112 | ASSERT_TRUE( |
| 113 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 114 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 115 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 116 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 117 | // TODO(hbos): When "no stream" is handled correctly we would expect |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 118 | // |add_track_events_[0].streams| to be empty. https://crbug.com/webrtc/7933 |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 119 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 120 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 121 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 122 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 123 | } |
| 124 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 125 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 126 | auto caller = CreatePeerConnection(); |
| 127 | auto callee = CreatePeerConnection(); |
| 128 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 129 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 130 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 131 | ASSERT_TRUE( |
| 132 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 133 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 134 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 135 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 136 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 137 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 138 | EXPECT_EQ("audio_stream", add_track_event.streams[0]->label()); |
| 139 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 140 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 141 | } |
| 142 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 143 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 144 | RemoveTrackWithoutStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 145 | auto caller = CreatePeerConnection(); |
| 146 | auto callee = CreatePeerConnection(); |
| 147 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 148 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 149 | ASSERT_TRUE( |
| 150 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 151 | static_cast<webrtc::RTCError*>(nullptr))); |
| 152 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 153 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 154 | ASSERT_TRUE( |
| 155 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 156 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 157 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 158 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 159 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 160 | callee->observer()->remove_track_events_); |
| 161 | } |
| 162 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 163 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 164 | RemoveTrackWithStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 165 | auto caller = CreatePeerConnection(); |
| 166 | auto callee = CreatePeerConnection(); |
| 167 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 168 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 169 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 170 | ASSERT_TRUE( |
| 171 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 172 | static_cast<webrtc::RTCError*>(nullptr))); |
| 173 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 174 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 175 | ASSERT_TRUE( |
| 176 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 177 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 178 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 179 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 180 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 181 | callee->observer()->remove_track_events_); |
| 182 | } |
| 183 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 184 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 185 | RemoveTrackWithSharedStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 186 | auto caller = CreatePeerConnection(); |
| 187 | auto callee = CreatePeerConnection(); |
| 188 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 189 | const char kSharedStreamLabel[] = "shared_audio_stream"; |
| 190 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
| 191 | {kSharedStreamLabel}); |
| 192 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
| 193 | {kSharedStreamLabel}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 194 | ASSERT_TRUE( |
| 195 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 196 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 197 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 198 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 199 | |
| 200 | // Remove "audio_track1". |
| 201 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 202 | ASSERT_TRUE( |
| 203 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 204 | static_cast<webrtc::RTCError*>(nullptr))); |
| 205 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 206 | EXPECT_EQ( |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 207 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 208 | callee->observer()->add_track_events_[0].receiver}, |
| 209 | callee->observer()->remove_track_events_); |
| 210 | |
| 211 | // Remove "audio_track2". |
| 212 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 213 | ASSERT_TRUE( |
| 214 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 215 | static_cast<webrtc::RTCError*>(nullptr))); |
| 216 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 217 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 218 | callee->observer()->remove_track_events_); |
| 219 | } |
| 220 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 221 | // These tests examine the state of the peer connection as a result of |
| 222 | // performing SetRemoteDescription(). |
| 223 | class PeerConnectionRtpObserverTest : public PeerConnectionRtpTest {}; |
| 224 | |
| 225 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithoutStreamAddsReceiver) { |
| 226 | auto caller = CreatePeerConnection(); |
| 227 | auto callee = CreatePeerConnection(); |
| 228 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 229 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), {})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 230 | ASSERT_TRUE( |
| 231 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 232 | static_cast<webrtc::RTCError*>(nullptr))); |
| 233 | |
| 234 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 235 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 236 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 237 | // TODO(hbos): When "no stream" is handled correctly we would expect |
| 238 | // |receiver_added->streams()| to be empty. https://crbug.com/webrtc/7933 |
| 239 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
| 240 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 241 | } |
| 242 | |
| 243 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithStreamAddsReceiver) { |
| 244 | auto caller = CreatePeerConnection(); |
| 245 | auto callee = CreatePeerConnection(); |
| 246 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 247 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 248 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 249 | ASSERT_TRUE( |
| 250 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 251 | static_cast<webrtc::RTCError*>(nullptr))); |
| 252 | |
| 253 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 254 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 255 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 256 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
| 257 | EXPECT_EQ("audio_stream", receiver_added->streams()[0]->label()); |
| 258 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 259 | } |
| 260 | |
| 261 | TEST_F(PeerConnectionRtpObserverTest, |
| 262 | RemoveSenderWithoutStreamRemovesReceiver) { |
| 263 | auto caller = CreatePeerConnection(); |
| 264 | auto callee = CreatePeerConnection(); |
| 265 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 266 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 267 | ASSERT_TRUE(sender); |
| 268 | ASSERT_TRUE( |
| 269 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 270 | static_cast<webrtc::RTCError*>(nullptr))); |
| 271 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 272 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 273 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 274 | ASSERT_TRUE( |
| 275 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 276 | static_cast<webrtc::RTCError*>(nullptr))); |
| 277 | |
| 278 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 279 | // Instead, the transceiver owning the receiver will become inactive. |
| 280 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 281 | } |
| 282 | |
| 283 | TEST_F(PeerConnectionRtpObserverTest, RemoveSenderWithStreamRemovesReceiver) { |
| 284 | auto caller = CreatePeerConnection(); |
| 285 | auto callee = CreatePeerConnection(); |
| 286 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 287 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 288 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 289 | ASSERT_TRUE(sender); |
| 290 | ASSERT_TRUE( |
| 291 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 292 | static_cast<webrtc::RTCError*>(nullptr))); |
| 293 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 294 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 295 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 296 | ASSERT_TRUE( |
| 297 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 298 | static_cast<webrtc::RTCError*>(nullptr))); |
| 299 | |
| 300 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 301 | // Instead, the transceiver owning the receiver will become inactive. |
| 302 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 303 | } |
| 304 | |
| 305 | TEST_F(PeerConnectionRtpObserverTest, |
| 306 | RemoveSenderWithSharedStreamRemovesReceiver) { |
| 307 | auto caller = CreatePeerConnection(); |
| 308 | auto callee = CreatePeerConnection(); |
| 309 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 310 | const char kSharedStreamLabel[] = "shared_audio_stream"; |
| 311 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
| 312 | {kSharedStreamLabel}); |
| 313 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
| 314 | {kSharedStreamLabel}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 315 | ASSERT_TRUE( |
| 316 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 317 | static_cast<webrtc::RTCError*>(nullptr))); |
| 318 | |
| 319 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 2u); |
| 320 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver1; |
| 321 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver2; |
| 322 | if (callee->pc()->GetReceivers()[0]->track()->id() == "audio_track1") { |
| 323 | receiver1 = callee->pc()->GetReceivers()[0]; |
| 324 | receiver2 = callee->pc()->GetReceivers()[1]; |
| 325 | } else { |
| 326 | receiver1 = callee->pc()->GetReceivers()[1]; |
| 327 | receiver2 = callee->pc()->GetReceivers()[0]; |
| 328 | } |
| 329 | EXPECT_EQ("audio_track1", receiver1->track()->id()); |
| 330 | EXPECT_EQ("audio_track2", receiver2->track()->id()); |
| 331 | |
| 332 | // Remove "audio_track1". |
| 333 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
| 334 | ASSERT_TRUE( |
| 335 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 336 | static_cast<webrtc::RTCError*>(nullptr))); |
| 337 | // Only |receiver2| should remain. |
| 338 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 339 | // Instead, the transceiver owning the receiver will become inactive. |
| 340 | EXPECT_EQ( |
| 341 | std::vector<rtc::scoped_refptr<webrtc::RtpReceiverInterface>>{receiver2}, |
| 342 | callee->pc()->GetReceivers()); |
| 343 | |
| 344 | // Remove "audio_track2". |
| 345 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
| 346 | ASSERT_TRUE( |
| 347 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 348 | static_cast<webrtc::RTCError*>(nullptr))); |
| 349 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 350 | // Instead, the transceiver owning the receiver will become inactive. |
| 351 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 352 | } |
| 353 | |
| 354 | // Invokes SetRemoteDescription() twice in a row without synchronizing the two |
| 355 | // calls and examine the state of the peer connection inside the callbacks to |
| 356 | // ensure that the second call does not occur prematurely, contaminating the |
| 357 | // state of the peer connection of the first callback. |
| 358 | TEST_F(PeerConnectionRtpObserverTest, |
| 359 | StatesCorrelateWithSetRemoteDescriptionCall) { |
| 360 | auto caller = CreatePeerConnection(); |
| 361 | auto callee = CreatePeerConnection(); |
| 362 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 363 | // Create SDP for adding a track and for removing it. This will be used in the |
| 364 | // first and second SetRemoteDescription() calls. |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 365 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 366 | auto srd1_sdp = caller->CreateOfferAndSetAsLocal(); |
| 367 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 368 | auto srd2_sdp = caller->CreateOfferAndSetAsLocal(); |
| 369 | |
| 370 | // In the first SetRemoteDescription() callback, check that we have a |
| 371 | // receiver for the track. |
| 372 | auto pc = callee->pc(); |
| 373 | bool srd1_callback_called = false; |
| 374 | auto srd1_callback = [&srd1_callback_called, &pc]() { |
| 375 | EXPECT_EQ(pc->GetReceivers().size(), 1u); |
| 376 | srd1_callback_called = true; |
| 377 | }; |
| 378 | |
| 379 | // In the second SetRemoteDescription() callback, check that the receiver has |
| 380 | // been removed. |
| 381 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 382 | // Instead, the transceiver owning the receiver will become inactive. |
| 383 | // https://crbug.com/webrtc/7600 |
| 384 | bool srd2_callback_called = false; |
| 385 | auto srd2_callback = [&srd2_callback_called, &pc]() { |
| 386 | EXPECT_TRUE(pc->GetReceivers().empty()); |
| 387 | srd2_callback_called = true; |
| 388 | }; |
| 389 | |
| 390 | // Invoke SetRemoteDescription() twice in a row without synchronizing the two |
| 391 | // calls. The callbacks verify that the two calls are synchronized, as in, the |
| 392 | // effects of the second SetRemoteDescription() call must not have happened by |
| 393 | // the time the first callback is invoked. If it has then the receiver that is |
| 394 | // added as a result of the first SetRemoteDescription() call will already |
| 395 | // have been removed as a result of the second SetRemoteDescription() call |
| 396 | // when the first callback is invoked. |
| 397 | callee->pc()->SetRemoteDescription( |
| 398 | std::move(srd1_sdp), |
| 399 | new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback)); |
| 400 | callee->pc()->SetRemoteDescription( |
| 401 | std::move(srd2_sdp), |
| 402 | new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback)); |
| 403 | EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout); |
| 404 | EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout); |
| 405 | } |
| 406 | |
| 407 | // Tests for the legacy SetRemoteDescription() function signature. |
| 408 | class PeerConnectionRtpLegacyObserverTest : public PeerConnectionRtpTest {}; |
| 409 | |
| 410 | // Sanity test making sure the callback is invoked. |
| 411 | TEST_F(PeerConnectionRtpLegacyObserverTest, OnSuccess) { |
| 412 | auto caller = CreatePeerConnection(); |
| 413 | auto callee = CreatePeerConnection(); |
| 414 | |
| 415 | std::string error; |
| 416 | ASSERT_TRUE( |
| 417 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error)); |
| 418 | } |
| 419 | |
| 420 | // Verifies legacy behavior: The observer is not called if if the peer |
| 421 | // connection is destroyed because the asynchronous callback is executed in the |
| 422 | // peer connection's message handler. |
| 423 | TEST_F(PeerConnectionRtpLegacyObserverTest, |
| 424 | ObserverNotCalledIfPeerConnectionDereferenced) { |
| 425 | auto caller = CreatePeerConnection(); |
| 426 | auto callee = CreatePeerConnection(); |
| 427 | |
| 428 | rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer = |
| 429 | new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>(); |
| 430 | |
| 431 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 432 | callee->pc()->SetRemoteDescription(observer, offer.release()); |
| 433 | callee = nullptr; |
| 434 | rtc::Thread::Current()->ProcessMessages(0); |
| 435 | EXPECT_FALSE(observer->called()); |
| 436 | } |
| 437 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 438 | // RtpTransceiver Tests. |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 439 | |
| 440 | // Test that by default there are no transceivers with Unified Plan. |
| 441 | TEST_F(PeerConnectionRtpTest, PeerConnectionHasNoTransceivers) { |
| 442 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 443 | EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre()); |
| 444 | } |
| 445 | |
| 446 | // Test that a transceiver created with the audio kind has the correct initial |
| 447 | // properties. |
| 448 | TEST_F(PeerConnectionRtpTest, AddTransceiverHasCorrectInitProperties) { |
| 449 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 450 | |
| 451 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 452 | EXPECT_EQ(rtc::nullopt, transceiver->mid()); |
| 453 | EXPECT_FALSE(transceiver->stopped()); |
| 454 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 455 | EXPECT_EQ(rtc::nullopt, transceiver->current_direction()); |
| 456 | } |
| 457 | |
| 458 | // Test that adding a transceiver with the audio kind creates an audio sender |
| 459 | // and audio receiver with the receiver having a live audio track. |
| 460 | TEST_F(PeerConnectionRtpTest, |
| 461 | AddAudioTransceiverCreatesAudioSenderAndReceiver) { |
| 462 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 463 | |
| 464 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame^] | 465 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 466 | |
| 467 | ASSERT_TRUE(transceiver->sender()); |
| 468 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type()); |
| 469 | |
| 470 | ASSERT_TRUE(transceiver->receiver()); |
| 471 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type()); |
| 472 | |
| 473 | auto track = transceiver->receiver()->track(); |
| 474 | ASSERT_TRUE(track); |
| 475 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind()); |
| 476 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 477 | } |
| 478 | |
| 479 | // Test that adding a transceiver with the video kind creates an video sender |
| 480 | // and video receiver with the receiver having a live video track. |
| 481 | TEST_F(PeerConnectionRtpTest, |
| 482 | AddAudioTransceiverCreatesVideoSenderAndReceiver) { |
| 483 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 484 | |
| 485 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame^] | 486 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 487 | |
| 488 | ASSERT_TRUE(transceiver->sender()); |
| 489 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type()); |
| 490 | |
| 491 | ASSERT_TRUE(transceiver->receiver()); |
| 492 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type()); |
| 493 | |
| 494 | auto track = transceiver->receiver()->track(); |
| 495 | ASSERT_TRUE(track); |
| 496 | EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind()); |
| 497 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 498 | } |
| 499 | |
| 500 | // Test that after a call to AddTransceiver, the transceiver shows in |
| 501 | // GetTransceivers(), the transceiver's sender shows in GetSenders(), and the |
| 502 | // transceiver's receiver shows in GetReceivers(). |
| 503 | TEST_F(PeerConnectionRtpTest, AddTransceiverShowsInLists) { |
| 504 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 505 | |
| 506 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 507 | EXPECT_EQ( |
| 508 | std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver}, |
| 509 | caller->pc()->GetTransceivers()); |
| 510 | EXPECT_EQ( |
| 511 | std::vector<rtc::scoped_refptr<RtpSenderInterface>>{ |
| 512 | transceiver->sender()}, |
| 513 | caller->pc()->GetSenders()); |
| 514 | EXPECT_EQ( |
| 515 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
| 516 | transceiver->receiver()}, |
| 517 | caller->pc()->GetReceivers()); |
| 518 | } |
| 519 | |
| 520 | // Test that the direction passed in through the AddTransceiver init parameter |
| 521 | // is set in the returned transceiver. |
| 522 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithDirectionIsReflected) { |
| 523 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 524 | |
| 525 | RtpTransceiverInit init; |
| 526 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 527 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 528 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 529 | } |
| 530 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 531 | // Test that calling AddTransceiver with a track creates a transceiver which has |
| 532 | // its sender's track set to the passed-in track. |
| 533 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithTrackCreatesSenderWithTrack) { |
| 534 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 535 | |
| 536 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 537 | auto transceiver = caller->AddTransceiver(audio_track); |
| 538 | |
| 539 | auto sender = transceiver->sender(); |
| 540 | ASSERT_TRUE(sender->track()); |
| 541 | EXPECT_EQ(audio_track, sender->track()); |
| 542 | |
| 543 | auto receiver = transceiver->receiver(); |
| 544 | ASSERT_TRUE(receiver->track()); |
| 545 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind()); |
| 546 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, |
| 547 | receiver->track()->state()); |
| 548 | } |
| 549 | |
| 550 | // Test that calling AddTransceiver twice with the same track creates distinct |
| 551 | // transceivers, senders with the same track. |
| 552 | TEST_F(PeerConnectionRtpTest, |
| 553 | AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) { |
| 554 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 555 | |
| 556 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 557 | |
| 558 | auto transceiver1 = caller->AddTransceiver(audio_track); |
| 559 | auto transceiver2 = caller->AddTransceiver(audio_track); |
| 560 | |
| 561 | EXPECT_NE(transceiver1, transceiver2); |
| 562 | |
| 563 | auto sender1 = transceiver1->sender(); |
| 564 | auto sender2 = transceiver2->sender(); |
| 565 | EXPECT_NE(sender1, sender2); |
| 566 | EXPECT_EQ(audio_track, sender1->track()); |
| 567 | EXPECT_EQ(audio_track, sender2->track()); |
| 568 | |
| 569 | EXPECT_THAT(caller->pc()->GetTransceivers(), |
| 570 | UnorderedElementsAre(transceiver1, transceiver2)); |
| 571 | EXPECT_THAT(caller->pc()->GetSenders(), |
| 572 | UnorderedElementsAre(sender1, sender2)); |
| 573 | } |
| 574 | |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 575 | // RtpTransceiver error handling tests. |
| 576 | |
| 577 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithInvalidKindReturnsError) { |
| 578 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 579 | |
| 580 | auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA); |
| 581 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
| 582 | } |
| 583 | |
| 584 | TEST_F(PeerConnectionRtpTest, UnifiedPlanCanClosePeerConnection) { |
| 585 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 586 | |
| 587 | caller->pc()->Close(); |
| 588 | } |
| 589 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 590 | // Unified Plan AddTrack tests. |
| 591 | |
| 592 | class PeerConnectionRtpUnifiedPlanTest : public PeerConnectionRtpTest {}; |
| 593 | |
| 594 | // Test that adding an audio track creates a new audio RtpSender with the given |
| 595 | // track. |
| 596 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddAudioTrackCreatesAudioSender) { |
| 597 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 598 | |
| 599 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 600 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 601 | ASSERT_TRUE(sender); |
| 602 | |
| 603 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type()); |
| 604 | EXPECT_EQ(audio_track, sender->track()); |
| 605 | } |
| 606 | |
| 607 | // Test that adding a video track creates a new video RtpSender with the given |
| 608 | // track. |
| 609 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddVideoTrackCreatesVideoSender) { |
| 610 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 611 | |
| 612 | auto video_track = caller->CreateVideoTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 613 | auto sender = caller->AddTrack(video_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 614 | ASSERT_TRUE(sender); |
| 615 | |
| 616 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type()); |
| 617 | EXPECT_EQ(video_track, sender->track()); |
| 618 | } |
| 619 | |
| 620 | // Test that adding a track to a new PeerConnection creates an RtpTransceiver |
| 621 | // with the sender that AddTrack returns and in the sendrecv direction. |
| 622 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddFirstTrackCreatesTransceiver) { |
| 623 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 624 | |
| 625 | auto sender = caller->AddAudioTrack("a"); |
| 626 | ASSERT_TRUE(sender); |
| 627 | |
| 628 | auto transceivers = caller->pc()->GetTransceivers(); |
| 629 | ASSERT_EQ(1u, transceivers.size()); |
| 630 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 631 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction()); |
| 632 | } |
| 633 | |
| 634 | // Test that if a transceiver of the same type but no track had been added to |
| 635 | // the PeerConnection and later a call to AddTrack is made, the resulting sender |
| 636 | // is the transceiver's sender and the sender's track is the newly-added track. |
| 637 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiver) { |
| 638 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 639 | |
| 640 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 641 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 642 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 643 | ASSERT_TRUE(sender); |
| 644 | |
| 645 | auto transceivers = caller->pc()->GetTransceivers(); |
| 646 | ASSERT_EQ(1u, transceivers.size()); |
| 647 | EXPECT_EQ(transceiver, transceivers[0]); |
| 648 | EXPECT_EQ(sender, transceiver->sender()); |
| 649 | EXPECT_EQ(audio_track, sender->track()); |
| 650 | } |
| 651 | |
| 652 | // Test that adding two tracks to a new PeerConnection creates two |
| 653 | // RtpTransceivers in the same order. |
| 654 | TEST_F(PeerConnectionRtpUnifiedPlanTest, TwoAddTrackCreatesTwoTransceivers) { |
| 655 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 656 | |
| 657 | auto sender1 = caller->AddAudioTrack("a"); |
| 658 | auto sender2 = caller->AddVideoTrack("v"); |
| 659 | ASSERT_TRUE(sender2); |
| 660 | |
| 661 | auto transceivers = caller->pc()->GetTransceivers(); |
| 662 | ASSERT_EQ(2u, transceivers.size()); |
| 663 | EXPECT_EQ(sender1, transceivers[0]->sender()); |
| 664 | EXPECT_EQ(sender2, transceivers[1]->sender()); |
| 665 | } |
| 666 | |
| 667 | // Test that if there are multiple transceivers with no sending track then a |
| 668 | // later call to AddTrack will use the one of the same type as the newly-added |
| 669 | // track. |
| 670 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiverOfType) { |
| 671 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 672 | |
| 673 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 674 | auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 675 | auto sender = caller->AddVideoTrack("v"); |
| 676 | |
| 677 | ASSERT_EQ(2u, caller->pc()->GetTransceivers().size()); |
| 678 | EXPECT_NE(sender, audio_transceiver->sender()); |
| 679 | EXPECT_EQ(sender, video_transceiver->sender()); |
| 680 | } |
| 681 | |
| 682 | // Test that if the only transceivers that do not have a sending track have a |
| 683 | // different type from the added track, then AddTrack will create a new |
| 684 | // transceiver for the track. |
| 685 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 686 | AddTrackDoesNotReuseTransceiverOfWrongType) { |
| 687 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 688 | |
| 689 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 690 | auto sender = caller->AddVideoTrack("v"); |
| 691 | |
| 692 | auto transceivers = caller->pc()->GetTransceivers(); |
| 693 | ASSERT_EQ(2u, transceivers.size()); |
| 694 | EXPECT_NE(sender, transceivers[0]->sender()); |
| 695 | EXPECT_EQ(sender, transceivers[1]->sender()); |
| 696 | } |
| 697 | |
| 698 | // Test that the first available transceiver is reused by AddTrack when multiple |
| 699 | // are available. |
| 700 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 701 | AddTrackReusesFirstMatchingTransceiver) { |
| 702 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 703 | |
| 704 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 705 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 706 | auto sender = caller->AddAudioTrack("a"); |
| 707 | |
| 708 | auto transceivers = caller->pc()->GetTransceivers(); |
| 709 | ASSERT_EQ(2u, transceivers.size()); |
| 710 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 711 | EXPECT_NE(sender, transceivers[1]->sender()); |
| 712 | } |
| 713 | |
| 714 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 715 | // direction from inactive to sendonly. |
| 716 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 717 | AddTrackChangesDirectionFromInactiveToSendOnly) { |
| 718 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 719 | |
| 720 | RtpTransceiverInit init; |
| 721 | init.direction = RtpTransceiverDirection::kInactive; |
| 722 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 723 | |
| 724 | caller->observer()->clear_negotiation_needed(); |
| 725 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 726 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 727 | |
| 728 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 729 | } |
| 730 | |
| 731 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 732 | // direction from recvonly to sendrecv. |
| 733 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 734 | AddTrackChangesDirectionFromRecvOnlyToSendRecv) { |
| 735 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 736 | |
| 737 | RtpTransceiverInit init; |
| 738 | init.direction = RtpTransceiverDirection::kRecvOnly; |
| 739 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 740 | |
| 741 | caller->observer()->clear_negotiation_needed(); |
| 742 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 743 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 744 | |
| 745 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 746 | } |
| 747 | |
Steve Anton | 02ee47c | 2018-01-10 16:26:06 -0800 | [diff] [blame] | 748 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackCreatesSenderWithTrackId) { |
| 749 | const std::string kTrackId = "audio_track"; |
| 750 | |
| 751 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 752 | |
| 753 | auto audio_track = caller->CreateAudioTrack(kTrackId); |
| 754 | auto sender = caller->AddTrack(audio_track); |
| 755 | |
| 756 | EXPECT_EQ(kTrackId, sender->id()); |
| 757 | } |
| 758 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 759 | // Unified Plan AddTrack error handling. |
| 760 | |
| 761 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfClosed) { |
| 762 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 763 | |
| 764 | auto audio_track = caller->CreateAudioTrack("a"); |
| 765 | caller->pc()->Close(); |
| 766 | |
| 767 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 768 | auto result = caller->pc() |
| 769 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 770 | EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 771 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 772 | } |
| 773 | |
| 774 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfTrackAlreadyHasSender) { |
| 775 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 776 | |
| 777 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 778 | ASSERT_TRUE(caller->AddTrack(audio_track)); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 779 | |
| 780 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 781 | auto result = caller->pc() |
| 782 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 783 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 784 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 785 | } |
| 786 | |
| 787 | // Unified Plan RemoveTrack tests. |
| 788 | |
| 789 | // Test that calling RemoveTrack on a sender with a previously-added track |
| 790 | // clears the sender's track. |
| 791 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackClearsSenderTrack) { |
| 792 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 793 | |
| 794 | auto sender = caller->AddAudioTrack("a"); |
| 795 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 796 | |
| 797 | EXPECT_FALSE(sender->track()); |
| 798 | } |
| 799 | |
| 800 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 801 | // in the sendrecv direction changes the transceiver's direction to recvonly. |
| 802 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 803 | RemoveTrackChangesDirectionFromSendRecvToRecvOnly) { |
| 804 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 805 | |
| 806 | RtpTransceiverInit init; |
| 807 | init.direction = RtpTransceiverDirection::kSendRecv; |
| 808 | auto transceiver = |
| 809 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 810 | |
| 811 | caller->observer()->clear_negotiation_needed(); |
| 812 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 813 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 814 | |
| 815 | EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction()); |
| 816 | EXPECT_TRUE(caller->observer()->renegotiation_needed_); |
| 817 | } |
| 818 | |
| 819 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 820 | // in the sendonly direction changes the transceiver's direction to inactive. |
| 821 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 822 | RemoveTrackChangesDirectionFromSendOnlyToInactive) { |
| 823 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 824 | |
| 825 | RtpTransceiverInit init; |
| 826 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 827 | auto transceiver = |
| 828 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 829 | |
| 830 | caller->observer()->clear_negotiation_needed(); |
| 831 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 832 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 833 | |
| 834 | EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction()); |
| 835 | } |
| 836 | |
| 837 | // Test that calling RemoveTrack with a sender that has a null track results in |
| 838 | // no change in state. |
| 839 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackWithNullSenderTrackIsNoOp) { |
| 840 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 841 | |
| 842 | auto sender = caller->AddAudioTrack("a"); |
| 843 | auto transceiver = caller->pc()->GetTransceivers()[0]; |
| 844 | ASSERT_TRUE(sender->SetTrack(nullptr)); |
| 845 | |
| 846 | caller->observer()->clear_negotiation_needed(); |
| 847 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 848 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 849 | |
| 850 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 851 | } |
| 852 | |
| 853 | // Unified Plan RemoveTrack error handling. |
| 854 | |
| 855 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackErrorIfClosed) { |
| 856 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 857 | |
| 858 | auto sender = caller->AddAudioTrack("a"); |
| 859 | caller->pc()->Close(); |
| 860 | |
| 861 | caller->observer()->clear_negotiation_needed(); |
| 862 | EXPECT_FALSE(caller->pc()->RemoveTrack(sender)); |
| 863 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 864 | } |
| 865 | |
| 866 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 867 | RemoveTrackNoErrorIfTrackAlreadyRemoved) { |
| 868 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 869 | |
| 870 | auto sender = caller->AddAudioTrack("a"); |
| 871 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 872 | |
| 873 | caller->observer()->clear_negotiation_needed(); |
| 874 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 875 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 876 | } |
| 877 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 878 | // Test MSID signaling between Unified Plan and Plan B endpoints. There are two |
| 879 | // options for this kind of signaling: media section based (a=msid) and ssrc |
| 880 | // based (a=ssrc MSID). While JSEP only specifies media section MSID signaling, |
| 881 | // we want to ensure compatibility with older Plan B endpoints that might expect |
| 882 | // ssrc based MSID signaling. Thus we test here that Unified Plan offers both |
| 883 | // types but answers with the same type as the offer. |
| 884 | |
| 885 | class PeerConnectionMsidSignalingTest : public PeerConnectionRtpTest {}; |
| 886 | |
| 887 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) { |
| 888 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 889 | caller->AddAudioTrack("caller_audio"); |
| 890 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 891 | callee->AddAudioTrack("callee_audio"); |
| 892 | |
| 893 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 894 | |
| 895 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 896 | auto* offer = callee->pc()->remote_description(); |
| 897 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 898 | cricket::kMsidSignalingSsrcAttribute), |
| 899 | offer->description()->msid_signaling()); |
| 900 | |
| 901 | // Answer should have had only a=msid lines. |
| 902 | auto* answer = caller->pc()->remote_description(); |
| 903 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 904 | answer->description()->msid_signaling()); |
| 905 | } |
| 906 | |
| 907 | TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) { |
| 908 | auto caller = CreatePeerConnectionWithPlanB(); |
| 909 | caller->AddAudioTrack("caller_audio"); |
| 910 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 911 | callee->AddAudioTrack("callee_audio"); |
| 912 | |
| 913 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 914 | |
| 915 | // Offer should have only a=ssrc MSID lines. |
| 916 | auto* offer = callee->pc()->remote_description(); |
| 917 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 918 | offer->description()->msid_signaling()); |
| 919 | |
| 920 | // Answer should have only a=ssrc MSID lines to match the offer. |
| 921 | auto* answer = caller->pc()->remote_description(); |
| 922 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 923 | answer->description()->msid_signaling()); |
| 924 | } |
| 925 | |
| 926 | TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) { |
| 927 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 928 | caller->AddAudioTrack("caller_audio"); |
| 929 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 930 | callee->AddAudioTrack("callee_audio"); |
| 931 | |
| 932 | auto offer = caller->CreateOffer(); |
| 933 | // Simulate a pure Unified Plan offerer by setting the MSID signaling to media |
| 934 | // section only. |
| 935 | offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection); |
| 936 | |
| 937 | ASSERT_TRUE( |
| 938 | caller->SetLocalDescription(CloneSessionDescription(offer.get()))); |
| 939 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
| 940 | |
| 941 | // Answer should have only a=msid to match the offer. |
| 942 | auto answer = callee->CreateAnswer(); |
| 943 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 944 | answer->description()->msid_signaling()); |
| 945 | } |
| 946 | |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 947 | // Sender setups in a call. |
| 948 | |
| 949 | class PeerConnectionSenderTest : public PeerConnectionRtpTest {}; |
| 950 | |
| 951 | TEST_F(PeerConnectionSenderTest, CreateTwoSendersWithSameTrack) { |
| 952 | auto caller = CreatePeerConnection(); |
| 953 | auto callee = CreatePeerConnection(); |
| 954 | |
| 955 | auto track = caller->CreateAudioTrack("audio_track"); |
| 956 | auto sender1 = caller->AddTrack(track); |
| 957 | ASSERT_TRUE(sender1); |
| 958 | // We need to temporarily reset the track for the subsequent AddTrack() to |
| 959 | // succeed. |
| 960 | EXPECT_TRUE(sender1->SetTrack(nullptr)); |
| 961 | auto sender2 = caller->AddTrack(track); |
| 962 | EXPECT_TRUE(sender2); |
| 963 | EXPECT_TRUE(sender1->SetTrack(track)); |
| 964 | |
| 965 | // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should |
| 966 | // return true, and doing |callee->SetRemoteDescription()| should work. |
| 967 | EXPECT_FALSE(caller->CreateOfferAndSetAsLocal()); |
| 968 | } |
| 969 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 970 | } // namespace webrtc |