blob: ecc0e176f518a4d2b603e3e2017b6dc2b0aae3a3 [file] [log] [blame]
philipelbe7a9e52016-05-19 12:19:35 +02001/*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/frame_buffer2.h"
philipelbe7a9e52016-05-19 12:19:35 +020012
13#include <algorithm>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <cstdlib>
15#include <iterator>
philipele0b2f152016-09-28 10:23:49 +020016#include <queue>
Yves Gerey3e707812018-11-28 16:47:49 +010017#include <utility>
philipel798b2822018-06-11 13:10:14 +020018#include <vector>
philipelbe7a9e52016-05-19 12:19:35 +020019
Yves Gerey3e707812018-11-28 16:47:49 +010020#include "api/video/encoded_image.h"
21#include "api/video/video_timing.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "modules/video_coding/include/video_coding_defines.h"
23#include "modules/video_coding/jitter_estimator.h"
24#include "modules/video_coding/timing.h"
25#include "rtc_base/checks.h"
Yves Gerey3e707812018-11-28 16:47:49 +010026#include "rtc_base/experiments/rtt_mult_experiment.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020027#include "rtc_base/logging.h"
Yves Gerey3e707812018-11-28 16:47:49 +010028#include "rtc_base/numerics/sequence_number_util.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020029#include "rtc_base/trace_event.h"
30#include "system_wrappers/include/clock.h"
philipel707f2782017-10-02 14:10:28 +020031#include "system_wrappers/include/field_trial.h"
philipelbe7a9e52016-05-19 12:19:35 +020032
33namespace webrtc {
34namespace video_coding {
35
36namespace {
philipele0b2f152016-09-28 10:23:49 +020037// Max number of frames the buffer will hold.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010038constexpr size_t kMaxFramesBuffered = 800;
philipelbe7a9e52016-05-19 12:19:35 +020039
philipele0b2f152016-09-28 10:23:49 +020040// Max number of decoded frame info that will be saved.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010041constexpr int kMaxFramesHistory = 1 << 13;
philipel65e1f942017-07-24 08:26:53 -070042
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010043// The time it's allowed for a frame to be late to its rendering prediction and
44// still be rendered.
Ilya Nikolaevskiy7eef0072018-02-28 09:59:26 +010045constexpr int kMaxAllowedFrameDelayMs = 5;
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010046
philipel65e1f942017-07-24 08:26:53 -070047constexpr int64_t kLogNonDecodedIntervalMs = 5000;
philipelbe7a9e52016-05-19 12:19:35 +020048} // namespace
49
philipelbe7a9e52016-05-19 12:19:35 +020050FrameBuffer::FrameBuffer(Clock* clock,
51 VCMJitterEstimator* jitter_estimator,
philipela45102f2017-02-22 05:30:39 -080052 VCMTiming* timing,
53 VCMReceiveStatisticsCallback* stats_callback)
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010054 : decoded_frames_history_(kMaxFramesHistory),
55 clock_(clock),
philipelbe7a9e52016-05-19 12:19:35 +020056 jitter_estimator_(jitter_estimator),
57 timing_(timing),
philipel4f6cd6a2016-08-03 10:59:32 +020058 inter_frame_delay_(clock_->TimeInMilliseconds()),
philipel29f730e2017-03-15 08:10:08 -070059 stopped_(false),
philipela45102f2017-02-22 05:30:39 -080060 protection_mode_(kProtectionNack),
philipel65e1f942017-07-24 08:26:53 -070061 stats_callback_(stats_callback),
Elad Alone4b50232019-01-14 18:56:14 +010062 last_log_non_decoded_ms_(-kLogNonDecodedIntervalMs),
63 add_rtt_to_playout_delay_(
Henrik Boströmc680c4a2019-04-03 10:27:36 +000064 webrtc::field_trial::IsEnabled("WebRTC-AddRttToPlayoutDelay")) {}
philipel266f0a42016-11-28 08:49:07 -080065
philipela45102f2017-02-22 05:30:39 -080066FrameBuffer::~FrameBuffer() {}
philipelbe7a9e52016-05-19 12:19:35 +020067
philipel75562822016-09-05 10:57:41 +020068FrameBuffer::ReturnReason FrameBuffer::NextFrame(
69 int64_t max_wait_time_ms,
philipele7c891f2018-02-22 14:35:06 +010070 std::unique_ptr<EncodedFrame>* frame_out,
philipel3042c2d2017-08-18 04:55:02 -070071 bool keyframe_required) {
tommidb23ea62017-03-03 07:21:18 -080072 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
philipel1c056252017-01-31 09:53:12 -080073 int64_t latest_return_time_ms =
74 clock_->TimeInMilliseconds() + max_wait_time_ms;
philipel504c47d2016-06-30 17:33:02 +020075 int64_t wait_ms = max_wait_time_ms;
philipel29f730e2017-03-15 08:10:08 -070076 int64_t now_ms = 0;
philipele0b2f152016-09-28 10:23:49 +020077
78 do {
philipel29f730e2017-03-15 08:10:08 -070079 now_ms = clock_->TimeInMilliseconds();
philipel504c47d2016-06-30 17:33:02 +020080 {
81 rtc::CritScope lock(&crit_);
tommi0a735642017-03-14 06:23:57 -070082 new_continuous_frame_event_.Reset();
philipel29f730e2017-03-15 08:10:08 -070083 if (stopped_)
84 return kStopped;
85
Henrik Boströmc680c4a2019-04-03 10:27:36 +000086 wait_ms = max_wait_time_ms;
87
88 // Need to hold |crit_| in order to access frames_to_decode_. therefore we
philipele0b2f152016-09-28 10:23:49 +020089 // set it here in the loop instead of outside the loop in order to not
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +010090 // acquire the lock unnecessarily.
Henrik Boströmc680c4a2019-04-03 10:27:36 +000091 frames_to_decode_.clear();
92
93 // |last_continuous_frame_| may be empty below, but nullopt is smaller
94 // than everything else and loop will immediately terminate as expected.
95 for (auto frame_it = frames_.begin();
96 frame_it != frames_.end() &&
97 frame_it->first <= last_continuous_frame_;
98 ++frame_it) {
99 if (!frame_it->second.continuous ||
100 frame_it->second.num_missing_decodable > 0) {
101 continue;
102 }
103
104 EncodedFrame* frame = frame_it->second.frame.get();
105
106 if (keyframe_required && !frame->is_keyframe())
107 continue;
108
109 auto last_decoded_frame_timestamp =
110 decoded_frames_history_.GetLastDecodedFrameTimestamp();
111
112 // TODO(https://bugs.webrtc.org/9974): consider removing this check
113 // as it may make a stream undecodable after a very long delay between
114 // frames.
115 if (last_decoded_frame_timestamp &&
116 AheadOf(*last_decoded_frame_timestamp, frame->Timestamp())) {
117 continue;
118 }
119
120 // Only ever return all parts of a superframe. Therefore skip this
121 // frame if it's not a beginning of a superframe.
122 if (frame->inter_layer_predicted) {
123 continue;
124 }
125
126 // Gather all remaining frames for the same superframe.
127 std::vector<FrameMap::iterator> current_superframe;
128 current_superframe.push_back(frame_it);
129 bool last_layer_completed =
130 frame_it->second.frame->is_last_spatial_layer;
131 FrameMap::iterator next_frame_it = frame_it;
132 while (true) {
133 ++next_frame_it;
134 if (next_frame_it == frames_.end() ||
135 next_frame_it->first.picture_id != frame->id.picture_id ||
136 !next_frame_it->second.continuous) {
137 break;
138 }
139 // Check if the next frame has some undecoded references other than
140 // the previous frame in the same superframe.
141 size_t num_allowed_undecoded_refs =
142 (next_frame_it->second.frame->inter_layer_predicted) ? 1 : 0;
143 if (next_frame_it->second.num_missing_decodable >
144 num_allowed_undecoded_refs) {
145 break;
146 }
147 // All frames in the superframe should have the same timestamp.
148 if (frame->Timestamp() != next_frame_it->second.frame->Timestamp()) {
149 RTC_LOG(LS_WARNING)
150 << "Frames in a single superframe have different"
151 " timestamps. Skipping undecodable superframe.";
152 break;
153 }
154 current_superframe.push_back(next_frame_it);
155 last_layer_completed =
156 next_frame_it->second.frame->is_last_spatial_layer;
157 }
158 // Check if the current superframe is complete.
159 // TODO(bugs.webrtc.org/10064): consider returning all available to
160 // decode frames even if the superframe is not complete yet.
161 if (!last_layer_completed) {
162 continue;
163 }
164
165 frames_to_decode_ = std::move(current_superframe);
166
167 if (frame->RenderTime() == -1) {
168 frame->SetRenderTime(
169 timing_->RenderTimeMs(frame->Timestamp(), now_ms));
170 }
171 wait_ms = timing_->MaxWaitingTime(frame->RenderTime(), now_ms);
172
173 // This will cause the frame buffer to prefer high framerate rather
174 // than high resolution in the case of the decoder not decoding fast
175 // enough and the stream has multiple spatial and temporal layers.
176 // For multiple temporal layers it may cause non-base layer frames to be
177 // skipped if they are late.
178 if (wait_ms < -kMaxAllowedFrameDelayMs)
179 continue;
180
181 break;
182 }
183 } // rtc::Critscope lock(&crit_);
184
185 wait_ms = std::min<int64_t>(wait_ms, latest_return_time_ms - now_ms);
186 wait_ms = std::max<int64_t>(wait_ms, 0);
tommi0a735642017-03-14 06:23:57 -0700187 } while (new_continuous_frame_event_.Wait(wait_ms));
philipele0b2f152016-09-28 10:23:49 +0200188
philipel29f730e2017-03-15 08:10:08 -0700189 {
190 rtc::CritScope lock(&crit_);
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000191 now_ms = clock_->TimeInMilliseconds();
192 // TODO(ilnik): remove |frames_out| use frames_to_decode_ directly.
193 std::vector<EncodedFrame*> frames_out;
philipele0b2f152016-09-28 10:23:49 +0200194
Ilya Nikolaevskiyfdfe1c92019-01-18 13:33:38 +0100195 if (!frames_to_decode_.empty()) {
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000196 bool superframe_delayed_by_retransmission = false;
197 size_t superframe_size = 0;
198 EncodedFrame* first_frame = frames_to_decode_[0]->second.frame.get();
199 int64_t render_time_ms = first_frame->RenderTime();
200 int64_t receive_time_ms = first_frame->ReceivedTime();
201 // Gracefully handle bad RTP timestamps and render time issues.
202 if (HasBadRenderTiming(*first_frame, now_ms)) {
203 jitter_estimator_->Reset();
204 timing_->Reset();
205 render_time_ms =
206 timing_->RenderTimeMs(first_frame->Timestamp(), now_ms);
207 }
208
209 for (FrameMap::iterator& frame_it : frames_to_decode_) {
210 RTC_DCHECK(frame_it != frames_.end());
211 EncodedFrame* frame = frame_it->second.frame.release();
212
213 frame->SetRenderTime(render_time_ms);
214
215 superframe_delayed_by_retransmission |=
216 frame->delayed_by_retransmission();
217 receive_time_ms = std::max(receive_time_ms, frame->ReceivedTime());
218 superframe_size += frame->size();
219
220 PropagateDecodability(frame_it->second);
221 decoded_frames_history_.InsertDecoded(frame_it->first,
222 frame->Timestamp());
223
224 // Remove decoded frame and all undecoded frames before it.
225 frames_.erase(frames_.begin(), ++frame_it);
226
227 frames_out.push_back(frame);
228 }
229
230 if (!superframe_delayed_by_retransmission) {
231 int64_t frame_delay;
232
233 if (inter_frame_delay_.CalculateDelay(first_frame->Timestamp(),
234 &frame_delay, receive_time_ms)) {
235 jitter_estimator_->UpdateEstimate(frame_delay, superframe_size);
236 }
237
238 float rtt_mult = protection_mode_ == kProtectionNackFEC ? 0.0 : 1.0;
239 if (RttMultExperiment::RttMultEnabled()) {
240 rtt_mult = RttMultExperiment::GetRttMultValue();
241 }
242 timing_->SetJitterDelay(jitter_estimator_->GetJitterEstimate(rtt_mult));
243 timing_->UpdateCurrentDelay(render_time_ms, now_ms);
244 } else {
245 if (RttMultExperiment::RttMultEnabled() || add_rtt_to_playout_delay_)
246 jitter_estimator_->FrameNacked();
247 }
248
249 UpdateJitterDelay();
250 UpdateTimingFrameInfo();
251 }
252 if (!frames_out.empty()) {
253 if (frames_out.size() == 1) {
254 frame_out->reset(frames_out[0]);
255 } else {
256 frame_out->reset(CombineAndDeleteFrames(frames_out));
257 }
philipel29f730e2017-03-15 08:10:08 -0700258 return kFrameFound;
philipelbe7a9e52016-05-19 12:19:35 +0200259 }
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000260 } // rtc::Critscope lock(&crit_)
tommi0a735642017-03-14 06:23:57 -0700261
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000262 if (latest_return_time_ms - now_ms > 0) {
philipel1c056252017-01-31 09:53:12 -0800263 // If |next_frame_it_ == frames_.end()| and there is still time left, it
264 // means that the frame buffer was cleared as the thread in this function
265 // was waiting to acquire |crit_| in order to return. Wait for the
266 // remaining time and then return.
267 return NextFrame(latest_return_time_ms - now_ms, frame_out);
philipelbe7a9e52016-05-19 12:19:35 +0200268 }
tommi0a735642017-03-14 06:23:57 -0700269 return kTimeout;
philipelbe7a9e52016-05-19 12:19:35 +0200270}
271
philipele7c891f2018-02-22 14:35:06 +0100272bool FrameBuffer::HasBadRenderTiming(const EncodedFrame& frame,
273 int64_t now_ms) {
stefan95e97542017-05-23 09:52:18 -0700274 // Assume that render timing errors are due to changes in the video stream.
275 int64_t render_time_ms = frame.RenderTimeMs();
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200276 // Zero render time means render immediately.
277 if (render_time_ms == 0) {
278 return false;
279 }
stefan95e97542017-05-23 09:52:18 -0700280 if (render_time_ms < 0) {
281 return true;
282 }
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200283 const int64_t kMaxVideoDelayMs = 10000;
stefan95e97542017-05-23 09:52:18 -0700284 if (std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
285 int frame_delay = static_cast<int>(std::abs(render_time_ms - now_ms));
Mirko Bonadei675513b2017-11-09 11:09:25 +0100286 RTC_LOG(LS_WARNING)
287 << "A frame about to be decoded is out of the configured "
288 << "delay bounds (" << frame_delay << " > " << kMaxVideoDelayMs
289 << "). Resetting the video jitter buffer.";
stefan95e97542017-05-23 09:52:18 -0700290 return true;
291 }
292 if (static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100293 RTC_LOG(LS_WARNING) << "The video target delay has grown larger than "
294 << kMaxVideoDelayMs << " ms.";
stefan95e97542017-05-23 09:52:18 -0700295 return true;
296 }
297 return false;
298}
299
philipel4f6cd6a2016-08-03 10:59:32 +0200300void FrameBuffer::SetProtectionMode(VCMVideoProtection mode) {
tommidb23ea62017-03-03 07:21:18 -0800301 TRACE_EVENT0("webrtc", "FrameBuffer::SetProtectionMode");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000302 rtc::CritScope lock(&crit_);
303 protection_mode_ = mode;
philipel4f6cd6a2016-08-03 10:59:32 +0200304}
305
philipel504c47d2016-06-30 17:33:02 +0200306void FrameBuffer::Start() {
tommidb23ea62017-03-03 07:21:18 -0800307 TRACE_EVENT0("webrtc", "FrameBuffer::Start");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000308 rtc::CritScope lock(&crit_);
309 stopped_ = false;
philipel504c47d2016-06-30 17:33:02 +0200310}
311
312void FrameBuffer::Stop() {
tommidb23ea62017-03-03 07:21:18 -0800313 TRACE_EVENT0("webrtc", "FrameBuffer::Stop");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000314 rtc::CritScope lock(&crit_);
315 stopped_ = true;
316 new_continuous_frame_event_.Set();
philipel504c47d2016-06-30 17:33:02 +0200317}
318
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100319void FrameBuffer::Clear() {
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000320 rtc::CritScope lock(&crit_);
321 ClearFramesAndHistory();
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100322}
323
philipele21be1d2017-09-25 06:37:12 -0700324void FrameBuffer::UpdateRtt(int64_t rtt_ms) {
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000325 rtc::CritScope lock(&crit_);
326 jitter_estimator_->UpdateRtt(rtt_ms);
philipele21be1d2017-09-25 06:37:12 -0700327}
328
philipele7c891f2018-02-22 14:35:06 +0100329bool FrameBuffer::ValidReferences(const EncodedFrame& frame) const {
philipel112adf92017-06-15 09:06:21 -0700330 for (size_t i = 0; i < frame.num_references; ++i) {
Philip Eliasson1f850a62019-03-19 12:15:00 +0000331 if (frame.references[i] >= frame.id.picture_id)
philipel112adf92017-06-15 09:06:21 -0700332 return false;
philipel3b3c9c42017-09-11 09:38:36 -0700333
philipel112adf92017-06-15 09:06:21 -0700334 for (size_t j = i + 1; j < frame.num_references; ++j) {
335 if (frame.references[i] == frame.references[j])
336 return false;
337 }
338 }
339
philipel0fa82a62018-03-19 15:34:53 +0100340 if (frame.inter_layer_predicted && frame.id.spatial_layer == 0)
philipel112adf92017-06-15 09:06:21 -0700341 return false;
342
343 return true;
344}
345
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100346bool FrameBuffer::IsCompleteSuperFrame(const EncodedFrame& frame) {
347 if (frame.inter_layer_predicted) {
348 // Check that all previous spatial layers are already inserted.
349 VideoLayerFrameId id = frame.id;
350 RTC_DCHECK_GT(id.spatial_layer, 0);
351 --id.spatial_layer;
352 FrameMap::iterator prev_frame = frames_.find(id);
353 if (prev_frame == frames_.end())
354 return false;
355 while (prev_frame->second.frame->inter_layer_predicted) {
356 --prev_frame;
357 --id.spatial_layer;
358 if (prev_frame == frames_.end() ||
359 prev_frame->first.picture_id != id.picture_id ||
360 prev_frame->first.spatial_layer != id.spatial_layer) {
361 return false;
362 }
363 }
364 }
365
366 if (!frame.is_last_spatial_layer) {
367 // Check that all following spatial layers are already inserted.
368 VideoLayerFrameId id = frame.id;
369 ++id.spatial_layer;
370 FrameMap::iterator next_frame = frames_.find(id);
371 if (next_frame == frames_.end())
372 return false;
373 while (!next_frame->second.frame->is_last_spatial_layer) {
374 ++next_frame;
375 ++id.spatial_layer;
376 if (next_frame == frames_.end() ||
377 next_frame->first.picture_id != id.picture_id ||
378 next_frame->first.spatial_layer != id.spatial_layer) {
379 return false;
380 }
381 }
382 }
383
384 return true;
385}
386
philipele7c891f2018-02-22 14:35:06 +0100387int64_t FrameBuffer::InsertFrame(std::unique_ptr<EncodedFrame> frame) {
tommidb23ea62017-03-03 07:21:18 -0800388 TRACE_EVENT0("webrtc", "FrameBuffer::InsertFrame");
philipel93e451b2016-10-06 12:25:13 +0200389 RTC_DCHECK(frame);
tommi0a735642017-03-14 06:23:57 -0700390
391 rtc::CritScope lock(&crit_);
philipel29f730e2017-03-15 08:10:08 -0700392
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100393 if (stats_callback_ && IsCompleteSuperFrame(*frame)) {
394 stats_callback_->OnCompleteFrame(frame->is_keyframe(), frame->size(),
395 frame->contentType());
396 }
397 const VideoLayerFrameId& id = frame->id;
398
philipel1610f942017-12-12 13:58:31 +0100399 int64_t last_continuous_picture_id =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100400 !last_continuous_frame_ ? -1 : last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200401
philipel112adf92017-06-15 09:06:21 -0700402 if (!ValidReferences(*frame)) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100403 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100404 << id.picture_id << ":"
405 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100406 << ") has invalid frame references, dropping frame.";
philipel112adf92017-06-15 09:06:21 -0700407 return last_continuous_picture_id;
408 }
409
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100410 if (frames_.size() >= kMaxFramesBuffered) {
philipel9771c502018-03-02 11:06:27 +0100411 if (frame->is_keyframe()) {
412 RTC_LOG(LS_WARNING) << "Inserting keyframe (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100413 << id.picture_id << ":"
414 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100415 << ") but buffer is full, clearing"
416 << " buffer and inserting the frame.";
417 ClearFramesAndHistory();
418 } else {
419 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100420 << id.picture_id << ":"
421 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100422 << ") could not be inserted due to the frame "
423 << "buffer being full, dropping frame.";
424 return last_continuous_picture_id;
425 }
philipele0b2f152016-09-28 10:23:49 +0200426 }
427
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100428 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
429 auto last_decoded_frame_timestamp =
430 decoded_frames_history_.GetLastDecodedFrameTimestamp();
431 if (last_decoded_frame && id <= *last_decoded_frame) {
432 if (AheadOf(frame->Timestamp(), *last_decoded_frame_timestamp) &&
philipel3042c2d2017-08-18 04:55:02 -0700433 frame->is_keyframe()) {
philipelfcc60062017-01-18 05:35:20 -0800434 // If this frame has a newer timestamp but an earlier picture id then we
435 // assume there has been a jump in the picture id due to some encoder
436 // reconfiguration or some other reason. Even though this is not according
437 // to spec we can still continue to decode from this frame if it is a
438 // keyframe.
Mirko Bonadei675513b2017-11-09 11:09:25 +0100439 RTC_LOG(LS_WARNING)
440 << "A jump in picture id was detected, clearing buffer.";
philipelfcc60062017-01-18 05:35:20 -0800441 ClearFramesAndHistory();
442 last_continuous_picture_id = -1;
443 } else {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100444 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100445 << id.picture_id << ":"
446 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100447 << ") inserted after frame ("
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100448 << last_decoded_frame->picture_id << ":"
449 << static_cast<int>(last_decoded_frame->spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100450 << ") was handed off for decoding, dropping frame.";
philipelfcc60062017-01-18 05:35:20 -0800451 return last_continuous_picture_id;
452 }
philipele0b2f152016-09-28 10:23:49 +0200453 }
454
philipel146a48b2017-04-20 04:04:38 -0700455 // Test if inserting this frame would cause the order of the frames to become
456 // ambiguous (covering more than half the interval of 2^16). This can happen
457 // when the picture id make large jumps mid stream.
philipel0fa82a62018-03-19 15:34:53 +0100458 if (!frames_.empty() && id < frames_.begin()->first &&
459 frames_.rbegin()->first < id) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100460 RTC_LOG(LS_WARNING)
461 << "A jump in picture id was detected, clearing buffer.";
philipel146a48b2017-04-20 04:04:38 -0700462 ClearFramesAndHistory();
463 last_continuous_picture_id = -1;
464 }
465
philipel0fa82a62018-03-19 15:34:53 +0100466 auto info = frames_.emplace(id, FrameInfo()).first;
philipele0b2f152016-09-28 10:23:49 +0200467
philipel93e451b2016-10-06 12:25:13 +0200468 if (info->second.frame) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100469 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100470 << id.picture_id << ":"
471 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100472 << ") already inserted, dropping frame.";
philipele0b2f152016-09-28 10:23:49 +0200473 return last_continuous_picture_id;
474 }
475
philipel93e451b2016-10-06 12:25:13 +0200476 if (!UpdateFrameInfoWithIncomingFrame(*frame, info))
477 return last_continuous_picture_id;
Ruslan Burakov493a6502019-02-27 15:32:48 +0100478
479 if (!frame->delayed_by_retransmission())
480 timing_->IncomingTimestamp(frame->Timestamp(), frame->ReceivedTime());
philipel0a9f6de2018-02-28 11:29:47 +0100481
philipele0b2f152016-09-28 10:23:49 +0200482 info->second.frame = std::move(frame);
philipele0b2f152016-09-28 10:23:49 +0200483
484 if (info->second.num_missing_continuous == 0) {
485 info->second.continuous = true;
486 PropagateContinuity(info);
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100487 last_continuous_picture_id = last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200488
489 // Since we now have new continuous frames there might be a better frame
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000490 // to return from NextFrame. Signal that thread so that it again can choose
491 // which frame to return.
492 new_continuous_frame_event_.Set();
philipele0b2f152016-09-28 10:23:49 +0200493 }
494
495 return last_continuous_picture_id;
philipelbe7a9e52016-05-19 12:19:35 +0200496}
497
philipele0b2f152016-09-28 10:23:49 +0200498void FrameBuffer::PropagateContinuity(FrameMap::iterator start) {
tommidb23ea62017-03-03 07:21:18 -0800499 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateContinuity");
philipele0b2f152016-09-28 10:23:49 +0200500 RTC_DCHECK(start->second.continuous);
philipele0b2f152016-09-28 10:23:49 +0200501
502 std::queue<FrameMap::iterator> continuous_frames;
503 continuous_frames.push(start);
504
505 // A simple BFS to traverse continuous frames.
506 while (!continuous_frames.empty()) {
507 auto frame = continuous_frames.front();
508 continuous_frames.pop();
509
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100510 if (!last_continuous_frame_ || *last_continuous_frame_ < frame->first) {
511 last_continuous_frame_ = frame->first;
512 }
philipele0b2f152016-09-28 10:23:49 +0200513
514 // Loop through all dependent frames, and if that frame no longer has
515 // any unfulfilled dependencies then that frame is continuous as well.
Elad Alon69321dd2019-01-10 15:02:54 +0100516 for (size_t d = 0; d < frame->second.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200517 auto frame_ref = frames_.find(frame->second.dependent_frames[d]);
philipel112adf92017-06-15 09:06:21 -0700518 RTC_DCHECK(frame_ref != frames_.end());
philipele0b2f152016-09-28 10:23:49 +0200519
philipel112adf92017-06-15 09:06:21 -0700520 // TODO(philipel): Look into why we've seen this happen.
521 if (frame_ref != frames_.end()) {
522 --frame_ref->second.num_missing_continuous;
523 if (frame_ref->second.num_missing_continuous == 0) {
524 frame_ref->second.continuous = true;
525 continuous_frames.push(frame_ref);
526 }
philipele0b2f152016-09-28 10:23:49 +0200527 }
528 }
529 }
530}
531
532void FrameBuffer::PropagateDecodability(const FrameInfo& info) {
tommidb23ea62017-03-03 07:21:18 -0800533 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateDecodability");
Elad Alon69321dd2019-01-10 15:02:54 +0100534 for (size_t d = 0; d < info.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200535 auto ref_info = frames_.find(info.dependent_frames[d]);
philipel93e451b2016-10-06 12:25:13 +0200536 RTC_DCHECK(ref_info != frames_.end());
tommie95b78b2017-05-14 07:23:11 -0700537 // TODO(philipel): Look into why we've seen this happen.
538 if (ref_info != frames_.end()) {
539 RTC_DCHECK_GT(ref_info->second.num_missing_decodable, 0U);
540 --ref_info->second.num_missing_decodable;
541 }
philipele0b2f152016-09-28 10:23:49 +0200542 }
543}
544
philipele7c891f2018-02-22 14:35:06 +0100545bool FrameBuffer::UpdateFrameInfoWithIncomingFrame(const EncodedFrame& frame,
philipele0b2f152016-09-28 10:23:49 +0200546 FrameMap::iterator info) {
tommidb23ea62017-03-03 07:21:18 -0800547 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateFrameInfoWithIncomingFrame");
philipel0fa82a62018-03-19 15:34:53 +0100548 const VideoLayerFrameId& id = frame.id;
philipele0b2f152016-09-28 10:23:49 +0200549
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100550 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
551 RTC_DCHECK(!last_decoded_frame || *last_decoded_frame < info->first);
philipele0b2f152016-09-28 10:23:49 +0200552
philipel798b2822018-06-11 13:10:14 +0200553 // In this function we determine how many missing dependencies this |frame|
554 // has to become continuous/decodable. If a frame that this |frame| depend
555 // on has already been decoded then we can ignore that dependency since it has
556 // already been fulfilled.
557 //
558 // For all other frames we will register a backwards reference to this |frame|
559 // so that |num_missing_continuous| and |num_missing_decodable| can be
560 // decremented as frames become continuous/are decoded.
561 struct Dependency {
562 VideoLayerFrameId id;
563 bool continuous;
564 };
565 std::vector<Dependency> not_yet_fulfilled_dependencies;
566
567 // Find all dependencies that have not yet been fulfilled.
philipele0b2f152016-09-28 10:23:49 +0200568 for (size_t i = 0; i < frame.num_references; ++i) {
philipel0fa82a62018-03-19 15:34:53 +0100569 VideoLayerFrameId ref_key(frame.references[i], frame.id.spatial_layer);
philipel798b2822018-06-11 13:10:14 +0200570 // Does |frame| depend on a frame earlier than the last decoded one?
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100571 if (last_decoded_frame && ref_key <= *last_decoded_frame) {
philipel798b2822018-06-11 13:10:14 +0200572 // Was that frame decoded? If not, this |frame| will never become
573 // decodable.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100574 if (!decoded_frames_history_.WasDecoded(ref_key)) {
philipel65e1f942017-07-24 08:26:53 -0700575 int64_t now_ms = clock_->TimeInMilliseconds();
576 if (last_log_non_decoded_ms_ + kLogNonDecodedIntervalMs < now_ms) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100577 RTC_LOG(LS_WARNING)
philipel0fa82a62018-03-19 15:34:53 +0100578 << "Frame with (picture_id:spatial_id) (" << id.picture_id << ":"
579 << static_cast<int>(id.spatial_layer)
philipel65e1f942017-07-24 08:26:53 -0700580 << ") depends on a non-decoded frame more previous than"
581 << " the last decoded frame, dropping frame.";
582 last_log_non_decoded_ms_ = now_ms;
583 }
philipele0b2f152016-09-28 10:23:49 +0200584 return false;
585 }
philipele0b2f152016-09-28 10:23:49 +0200586 } else {
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100587 auto ref_info = frames_.find(ref_key);
philipel798b2822018-06-11 13:10:14 +0200588 bool ref_continuous =
589 ref_info != frames_.end() && ref_info->second.continuous;
590 not_yet_fulfilled_dependencies.push_back({ref_key, ref_continuous});
philipele0b2f152016-09-28 10:23:49 +0200591 }
philipelbe7a9e52016-05-19 12:19:35 +0200592 }
593
philipel798b2822018-06-11 13:10:14 +0200594 // Does |frame| depend on the lower spatial layer?
philipelbe7a9e52016-05-19 12:19:35 +0200595 if (frame.inter_layer_predicted) {
philipel0fa82a62018-03-19 15:34:53 +0100596 VideoLayerFrameId ref_key(frame.id.picture_id, frame.id.spatial_layer - 1);
philipel798b2822018-06-11 13:10:14 +0200597 auto ref_info = frames_.find(ref_key);
philipele0b2f152016-09-28 10:23:49 +0200598
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100599 bool lower_layer_decoded =
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100600 last_decoded_frame && *last_decoded_frame == ref_key;
philipel798b2822018-06-11 13:10:14 +0200601 bool lower_layer_continuous =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100602 lower_layer_decoded ||
603 (ref_info != frames_.end() && ref_info->second.continuous);
philipel798b2822018-06-11 13:10:14 +0200604
605 if (!lower_layer_continuous || !lower_layer_decoded) {
606 not_yet_fulfilled_dependencies.push_back(
607 {ref_key, lower_layer_continuous});
philipele0b2f152016-09-28 10:23:49 +0200608 }
philipelbe7a9e52016-05-19 12:19:35 +0200609 }
610
philipel798b2822018-06-11 13:10:14 +0200611 info->second.num_missing_continuous = not_yet_fulfilled_dependencies.size();
612 info->second.num_missing_decodable = not_yet_fulfilled_dependencies.size();
613
614 for (const Dependency& dep : not_yet_fulfilled_dependencies) {
615 if (dep.continuous)
616 --info->second.num_missing_continuous;
617
Elad Alon69321dd2019-01-10 15:02:54 +0100618 frames_[dep.id].dependent_frames.push_back(id);
philipel798b2822018-06-11 13:10:14 +0200619 }
philipel93e451b2016-10-06 12:25:13 +0200620
philipelbe7a9e52016-05-19 12:19:35 +0200621 return true;
622}
623
philipelbe742702016-11-30 01:31:40 -0800624void FrameBuffer::UpdateJitterDelay() {
tommidb23ea62017-03-03 07:21:18 -0800625 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateJitterDelay");
philipela45102f2017-02-22 05:30:39 -0800626 if (!stats_callback_)
627 return;
philipelbe742702016-11-30 01:31:40 -0800628
philipela45102f2017-02-22 05:30:39 -0800629 int decode_ms;
630 int max_decode_ms;
631 int current_delay_ms;
632 int target_delay_ms;
633 int jitter_buffer_ms;
634 int min_playout_delay_ms;
635 int render_delay_ms;
636 if (timing_->GetTimings(&decode_ms, &max_decode_ms, &current_delay_ms,
637 &target_delay_ms, &jitter_buffer_ms,
638 &min_playout_delay_ms, &render_delay_ms)) {
639 stats_callback_->OnFrameBufferTimingsUpdated(
640 decode_ms, max_decode_ms, current_delay_ms, target_delay_ms,
641 jitter_buffer_ms, min_playout_delay_ms, render_delay_ms);
philipelbe742702016-11-30 01:31:40 -0800642 }
philipel266f0a42016-11-28 08:49:07 -0800643}
644
ilnik2edc6842017-07-06 03:06:50 -0700645void FrameBuffer::UpdateTimingFrameInfo() {
646 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateTimingFrameInfo");
Danil Chapovalov0040b662018-06-18 10:48:16 +0200647 absl::optional<TimingFrameInfo> info = timing_->GetTimingFrameInfo();
philipel97187112018-03-23 10:43:21 +0100648 if (info && stats_callback_)
ilnik2edc6842017-07-06 03:06:50 -0700649 stats_callback_->OnTimingFrameInfoUpdated(*info);
650}
651
philipelfcc60062017-01-18 05:35:20 -0800652void FrameBuffer::ClearFramesAndHistory() {
ilnik2edc6842017-07-06 03:06:50 -0700653 TRACE_EVENT0("webrtc", "FrameBuffer::ClearFramesAndHistory");
philipelfcc60062017-01-18 05:35:20 -0800654 frames_.clear();
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100655 last_continuous_frame_.reset();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100656 frames_to_decode_.clear();
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100657 decoded_frames_history_.Clear();
philipelfcc60062017-01-18 05:35:20 -0800658}
659
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100660EncodedFrame* FrameBuffer::CombineAndDeleteFrames(
661 const std::vector<EncodedFrame*>& frames) const {
662 RTC_DCHECK(!frames.empty());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100663 EncodedFrame* first_frame = frames[0];
664 EncodedFrame* last_frame = frames.back();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100665 size_t total_length = 0;
666 for (size_t i = 0; i < frames.size(); ++i) {
667 total_length += frames[i]->size();
668 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100669 first_frame->VerifyAndAllocate(total_length);
670
671 // Spatial index of combined frame is set equal to spatial index of its top
672 // spatial layer.
673 first_frame->SetSpatialIndex(last_frame->id.spatial_layer);
674 first_frame->id.spatial_layer = last_frame->id.spatial_layer;
675
676 first_frame->video_timing_mutable()->network2_timestamp_ms =
677 last_frame->video_timing().network2_timestamp_ms;
678 first_frame->video_timing_mutable()->receive_finish_ms =
679 last_frame->video_timing().receive_finish_ms;
680
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100681 // Append all remaining frames to the first one.
Niels Möller9c843902019-01-11 10:21:35 +0100682 uint8_t* buffer = first_frame->data() + first_frame->size();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100683 for (size_t i = 1; i < frames.size(); ++i) {
Sergey Silkin61832dd2018-12-20 14:32:14 +0100684 EncodedFrame* next_frame = frames[i];
Niels Möller9c843902019-01-11 10:21:35 +0100685 memcpy(buffer, next_frame->data(), next_frame->size());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100686 buffer += next_frame->size();
687 delete next_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100688 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100689 first_frame->set_size(total_length);
690 return first_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100691}
692
Niels Möllerbe682d42018-03-27 08:31:45 +0200693FrameBuffer::FrameInfo::FrameInfo() = default;
694FrameBuffer::FrameInfo::FrameInfo(FrameInfo&&) = default;
695FrameBuffer::FrameInfo::~FrameInfo() = default;
696
philipelbe7a9e52016-05-19 12:19:35 +0200697} // namespace video_coding
698} // namespace webrtc