pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 11 | #include <list> |
kwiberg | 22feaa3 | 2016-03-17 09:17:43 -0700 | [diff] [blame] | 12 | #include <memory> |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 13 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 14 | #include "modules/pacing/paced_sender.h" |
| 15 | #include "system_wrappers/include/clock.h" |
| 16 | #include "test/gmock.h" |
| 17 | #include "test/gtest.h" |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 18 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 19 | using testing::_; |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 20 | using testing::Field; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 21 | using testing::Return; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 22 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 23 | namespace { |
| 24 | constexpr unsigned kFirstClusterBps = 900000; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 25 | constexpr unsigned kSecondClusterBps = 1800000; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 26 | |
| 27 | // The error stems from truncating the time interval of probe packets to integer |
| 28 | // values. This results in probing slightly higher than the target bitrate. |
| 29 | // For 1.8 Mbps, this comes to be about 120 kbps with 1200 probe packets. |
| 30 | constexpr int kBitrateProbingError = 150000; |
| 31 | } // namespace |
| 32 | |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 33 | namespace webrtc { |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 34 | namespace test { |
| 35 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 36 | static const int kTargetBitrateBps = 800000; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 37 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 38 | class MockPacedSenderCallback : public PacedSender::PacketSender { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 39 | public: |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 40 | MOCK_METHOD5(TimeToSendPacket, |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 41 | bool(uint32_t ssrc, |
| 42 | uint16_t sequence_number, |
| 43 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 44 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 45 | const PacedPacketInfo& pacing_info)); |
| 46 | MOCK_METHOD2(TimeToSendPadding, |
| 47 | size_t(size_t bytes, const PacedPacketInfo& pacing_info)); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 48 | }; |
| 49 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 50 | class PacedSenderPadding : public PacedSender::PacketSender { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 51 | public: |
| 52 | PacedSenderPadding() : padding_sent_(0) {} |
| 53 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 54 | bool TimeToSendPacket(uint32_t ssrc, |
| 55 | uint16_t sequence_number, |
| 56 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 57 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 58 | const PacedPacketInfo& pacing_info) override { |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 59 | return true; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 60 | } |
| 61 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 62 | size_t TimeToSendPadding(size_t bytes, |
| 63 | const PacedPacketInfo& pacing_info) override { |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 64 | const size_t kPaddingPacketSize = 224; |
| 65 | size_t num_packets = (bytes + kPaddingPacketSize - 1) / kPaddingPacketSize; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 66 | padding_sent_ += kPaddingPacketSize * num_packets; |
| 67 | return kPaddingPacketSize * num_packets; |
| 68 | } |
| 69 | |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 70 | size_t padding_sent() { return padding_sent_; } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 71 | |
| 72 | private: |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 73 | size_t padding_sent_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 74 | }; |
| 75 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 76 | class PacedSenderProbing : public PacedSender::PacketSender { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 77 | public: |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 78 | PacedSenderProbing() : packets_sent_(0), padding_sent_(0) {} |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 79 | |
| 80 | bool TimeToSendPacket(uint32_t ssrc, |
| 81 | uint16_t sequence_number, |
| 82 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 83 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 84 | const PacedPacketInfo& pacing_info) override { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 85 | packets_sent_++; |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 86 | return true; |
| 87 | } |
| 88 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 89 | size_t TimeToSendPadding(size_t bytes, |
| 90 | const PacedPacketInfo& pacing_info) override { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 91 | padding_sent_ += bytes; |
| 92 | return padding_sent_; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 93 | } |
| 94 | |
| 95 | int packets_sent() const { return packets_sent_; } |
| 96 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 97 | int padding_sent() const { return padding_sent_; } |
| 98 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 99 | private: |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 100 | int packets_sent_; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 101 | int padding_sent_; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 102 | }; |
| 103 | |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 104 | class PacedSenderTest : public ::testing::Test { |
| 105 | protected: |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 106 | PacedSenderTest() : clock_(123456) { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 107 | srand(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 108 | // Need to initialize PacedSender after we initialize clock. |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 109 | send_bucket_.reset(new PacedSender(&clock_, &callback_, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 110 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
| 111 | send_bucket_->CreateProbeCluster(kSecondClusterBps); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 112 | // Default to bitrate probing disabled for testing purposes. Probing tests |
| 113 | // have to enable probing, either by creating a new PacedSender instance or |
| 114 | // by calling SetProbingEnabled(true). |
| 115 | send_bucket_->SetProbingEnabled(false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 116 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
| 117 | |
| 118 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 119 | } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 120 | |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 121 | void SendAndExpectPacket(PacedSender::Priority priority, |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 122 | uint32_t ssrc, |
| 123 | uint16_t sequence_number, |
| 124 | int64_t capture_time_ms, |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 125 | size_t size, |
stefan@webrtc.org | 9b82f5a | 2013-11-13 15:29:21 +0000 | [diff] [blame] | 126 | bool retransmission) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 127 | send_bucket_->InsertPacket(priority, ssrc, sequence_number, capture_time_ms, |
| 128 | size, retransmission); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 129 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
terelius | f39f7d9 | 2016-07-20 03:36:19 -0700 | [diff] [blame] | 130 | capture_time_ms, retransmission, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 131 | .Times(1) |
| 132 | .WillRepeatedly(Return(true)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 133 | } |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 134 | SimulatedClock clock_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 135 | MockPacedSenderCallback callback_; |
kwiberg | 22feaa3 | 2016-03-17 09:17:43 -0700 | [diff] [blame] | 136 | std::unique_ptr<PacedSender> send_bucket_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 137 | }; |
| 138 | |
asapersson | fc5e81c | 2017-04-19 23:28:53 -0700 | [diff] [blame] | 139 | TEST_F(PacedSenderTest, FirstSentPacketTimeIsSet) { |
| 140 | uint16_t sequence_number = 1234; |
| 141 | const uint32_t kSsrc = 12345; |
| 142 | const size_t kSizeBytes = 250; |
| 143 | const size_t kPacketToSend = 3; |
| 144 | const int64_t kStartMs = clock_.TimeInMilliseconds(); |
| 145 | |
| 146 | // No packet sent. |
| 147 | EXPECT_EQ(-1, send_bucket_->FirstSentPacketTimeMs()); |
| 148 | |
| 149 | for (size_t i = 0; i < kPacketToSend; ++i) { |
| 150 | SendAndExpectPacket(PacedSender::kNormalPriority, kSsrc, sequence_number++, |
| 151 | clock_.TimeInMilliseconds(), kSizeBytes, false); |
| 152 | send_bucket_->Process(); |
| 153 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 154 | } |
| 155 | EXPECT_EQ(kStartMs, send_bucket_->FirstSentPacketTimeMs()); |
| 156 | } |
| 157 | |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 158 | TEST_F(PacedSenderTest, QueuePacket) { |
| 159 | uint32_t ssrc = 12345; |
| 160 | uint16_t sequence_number = 1234; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 161 | // Due to the multiplicative factor we can send 5 packets during a send |
| 162 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 163 | // (packet size * #send intervals per second) |
| 164 | const size_t packets_to_send = |
| 165 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 166 | for (size_t i = 0; i < packets_to_send; ++i) { |
| 167 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 168 | clock_.TimeInMilliseconds(), 250, false); |
| 169 | } |
| 170 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 171 | int64_t queued_packet_timestamp = clock_.TimeInMilliseconds(); |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 172 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 173 | sequence_number, queued_packet_timestamp, 250, |
| 174 | false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 175 | EXPECT_EQ(packets_to_send + 1, send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 176 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 177 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 178 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 179 | clock_.AdvanceTimeMilliseconds(4); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 180 | EXPECT_EQ(1, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 181 | clock_.AdvanceTimeMilliseconds(1); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 182 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 183 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 184 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number++, |
| 185 | queued_packet_timestamp, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 186 | .Times(1) |
| 187 | .WillRepeatedly(Return(true)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 188 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 189 | sequence_number++; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 190 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 191 | |
| 192 | // We can send packets_to_send -1 packets of size 250 during the current |
| 193 | // interval since one packet has already been sent. |
| 194 | for (size_t i = 0; i < packets_to_send - 1; ++i) { |
| 195 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 196 | clock_.TimeInMilliseconds(), 250, false); |
| 197 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 198 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 199 | sequence_number++, clock_.TimeInMilliseconds(), |
| 200 | 250, false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 201 | EXPECT_EQ(packets_to_send, send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 202 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 203 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 204 | } |
| 205 | |
| 206 | TEST_F(PacedSenderTest, PaceQueuedPackets) { |
| 207 | uint32_t ssrc = 12345; |
| 208 | uint16_t sequence_number = 1234; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 209 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 210 | // Due to the multiplicative factor we can send 5 packets during a send |
| 211 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 212 | // (packet size * #send intervals per second) |
| 213 | const size_t packets_to_send_per_interval = |
| 214 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 215 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 216 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 217 | clock_.TimeInMilliseconds(), 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 218 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 219 | |
| 220 | for (size_t j = 0; j < packets_to_send_per_interval * 10; ++j) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 221 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 222 | sequence_number++, clock_.TimeInMilliseconds(), |
| 223 | 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 224 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 225 | EXPECT_EQ(packets_to_send_per_interval + packets_to_send_per_interval * 10, |
| 226 | send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 227 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 228 | EXPECT_EQ(packets_to_send_per_interval * 10, |
| 229 | send_bucket_->QueueSizePackets()); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 230 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 231 | for (int k = 0; k < 10; ++k) { |
| 232 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 233 | clock_.AdvanceTimeMilliseconds(5); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 234 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, _, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 235 | .Times(packets_to_send_per_interval) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 236 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 237 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 238 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 239 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 240 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 241 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 242 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 243 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 244 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 245 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 246 | |
| 247 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 248 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 249 | clock_.TimeInMilliseconds(), 250, false); |
| 250 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 251 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 252 | sequence_number, clock_.TimeInMilliseconds(), 250, |
| 253 | false); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 254 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 255 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 256 | } |
| 257 | |
philipel | 7dc719a | 2017-09-29 16:15:25 +0200 | [diff] [blame] | 258 | TEST_F(PacedSenderTest, RepeatedRetransmissionsAllowed) { |
| 259 | // Send one packet, then two retransmissions of that packet. |
| 260 | for (size_t i = 0; i < 3; i++) { |
| 261 | constexpr uint32_t ssrc = 333; |
| 262 | constexpr uint16_t sequence_number = 444; |
| 263 | constexpr size_t bytes = 250; |
| 264 | bool is_retransmission = (i != 0); // Original followed by retransmissions. |
| 265 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number, |
| 266 | clock_.TimeInMilliseconds(), bytes, is_retransmission); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 267 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | 52aa019 | 2013-04-25 17:35:56 +0000 | [diff] [blame] | 268 | } |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 269 | send_bucket_->Process(); |
pwestin@webrtc.org | 52aa019 | 2013-04-25 17:35:56 +0000 | [diff] [blame] | 270 | } |
| 271 | |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 272 | TEST_F(PacedSenderTest, CanQueuePacketsWithSameSequenceNumberOnDifferentSsrcs) { |
| 273 | uint32_t ssrc = 12345; |
| 274 | uint16_t sequence_number = 1234; |
| 275 | |
| 276 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 277 | ssrc, |
| 278 | sequence_number, |
| 279 | clock_.TimeInMilliseconds(), |
| 280 | 250, |
| 281 | false); |
| 282 | |
| 283 | // Expect packet on second ssrc to be queued and sent as well. |
| 284 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 285 | ssrc + 1, |
| 286 | sequence_number, |
| 287 | clock_.TimeInMilliseconds(), |
| 288 | 250, |
| 289 | false); |
| 290 | |
| 291 | clock_.AdvanceTimeMilliseconds(1000); |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 292 | send_bucket_->Process(); |
| 293 | } |
| 294 | |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 295 | TEST_F(PacedSenderTest, Padding) { |
| 296 | uint32_t ssrc = 12345; |
| 297 | uint16_t sequence_number = 1234; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 298 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 299 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 300 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 301 | |
| 302 | // Due to the multiplicative factor we can send 5 packets during a send |
| 303 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 304 | // (packet size * #send intervals per second) |
| 305 | const size_t packets_to_send_per_interval = |
| 306 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 307 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 308 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 309 | clock_.TimeInMilliseconds(), 250, false); |
| 310 | } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 311 | // No padding is expected since we have sent too much already. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 312 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 313 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 314 | send_bucket_->Process(); |
| 315 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 316 | |
| 317 | // 5 milliseconds later should not send padding since we filled the buffers |
| 318 | // initially. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 319 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)).Times(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 320 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 321 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 322 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 323 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 324 | |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 325 | // 5 milliseconds later we have enough budget to send some padding. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 326 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 327 | .Times(1) |
| 328 | .WillOnce(Return(250)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 329 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 330 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 331 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 332 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 333 | } |
| 334 | |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 335 | TEST_F(PacedSenderTest, NoPaddingBeforeNormalPacket) { |
| 336 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
| 337 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
| 338 | |
| 339 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 340 | send_bucket_->Process(); |
| 341 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 342 | |
| 343 | send_bucket_->Process(); |
| 344 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 345 | |
| 346 | uint32_t ssrc = 12345; |
| 347 | uint16_t sequence_number = 1234; |
| 348 | int64_t capture_time_ms = 56789; |
| 349 | |
| 350 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 351 | capture_time_ms, 250, false); |
| 352 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 353 | .Times(1) |
| 354 | .WillOnce(Return(250)); |
| 355 | send_bucket_->Process(); |
| 356 | } |
| 357 | |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 358 | TEST_F(PacedSenderTest, VerifyPaddingUpToBitrate) { |
| 359 | uint32_t ssrc = 12345; |
| 360 | uint16_t sequence_number = 1234; |
| 361 | int64_t capture_time_ms = 56789; |
| 362 | const int kTimeStep = 5; |
| 363 | const int64_t kBitrateWindow = 100; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 364 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 365 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 366 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 367 | int64_t start_time = clock_.TimeInMilliseconds(); |
| 368 | while (clock_.TimeInMilliseconds() - start_time < kBitrateWindow) { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 369 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 370 | ssrc, |
| 371 | sequence_number++, |
| 372 | capture_time_ms, |
| 373 | 250, |
| 374 | false); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 375 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 376 | .Times(1) |
| 377 | .WillOnce(Return(250)); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 378 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 379 | clock_.AdvanceTimeMilliseconds(kTimeStep); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 380 | } |
| 381 | } |
| 382 | |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 383 | TEST_F(PacedSenderTest, VerifyAverageBitrateVaryingMediaPayload) { |
| 384 | uint32_t ssrc = 12345; |
| 385 | uint16_t sequence_number = 1234; |
| 386 | int64_t capture_time_ms = 56789; |
| 387 | const int kTimeStep = 5; |
| 388 | const int64_t kBitrateWindow = 10000; |
| 389 | PacedSenderPadding callback; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 390 | send_bucket_.reset(new PacedSender(&clock_, &callback, nullptr)); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 391 | send_bucket_->SetProbingEnabled(false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 392 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 393 | |
| 394 | send_bucket_->SetSendBitrateLimits( |
| 395 | 0 /*allocated_bitrate_bps*/, |
| 396 | kTargetBitrateBps * 2 /* max_padding_bitrate_bps */); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 397 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 398 | int64_t start_time = clock_.TimeInMilliseconds(); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 399 | size_t media_bytes = 0; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 400 | while (clock_.TimeInMilliseconds() - start_time < kBitrateWindow) { |
jbauch | d2a2296 | 2016-02-08 23:18:25 -0800 | [diff] [blame] | 401 | int rand_value = rand(); // NOLINT (rand_r instead of rand) |
| 402 | size_t media_payload = rand_value % 100 + 200; // [200, 300] bytes. |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 403 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 404 | sequence_number++, capture_time_ms, |
| 405 | media_payload, false); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 406 | media_bytes += media_payload; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 407 | clock_.AdvanceTimeMilliseconds(kTimeStep); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 408 | send_bucket_->Process(); |
| 409 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 410 | EXPECT_NEAR(kTargetBitrateBps / 1000, |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 411 | static_cast<int>(8 * (media_bytes + callback.padding_sent()) / |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 412 | kBitrateWindow), |
| 413 | 1); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 414 | } |
| 415 | |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 416 | TEST_F(PacedSenderTest, Priority) { |
| 417 | uint32_t ssrc_low_priority = 12345; |
| 418 | uint32_t ssrc = 12346; |
| 419 | uint16_t sequence_number = 1234; |
| 420 | int64_t capture_time_ms = 56789; |
| 421 | int64_t capture_time_ms_low_priority = 1234567; |
| 422 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 423 | // Due to the multiplicative factor we can send 5 packets during a send |
| 424 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 425 | // (packet size * #send intervals per second) |
| 426 | const size_t packets_to_send_per_interval = |
| 427 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 428 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 429 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 430 | clock_.TimeInMilliseconds(), 250, false); |
| 431 | } |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 432 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 433 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 434 | |
| 435 | // Expect normal and low priority to be queued and high to pass through. |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 436 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 437 | sequence_number++, capture_time_ms_low_priority, |
| 438 | 250, false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 439 | |
| 440 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 441 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 442 | sequence_number++, capture_time_ms, 250, false); |
| 443 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 444 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc, |
| 445 | sequence_number++, capture_time_ms, 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 446 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 447 | // Expect all high and normal priority to be sent out first. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 448 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 449 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 450 | .Times(packets_to_send_per_interval + 1) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 451 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 452 | |
| 453 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 454 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 455 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 456 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 457 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 458 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 459 | EXPECT_CALL(callback_, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 460 | TimeToSendPacket(ssrc_low_priority, _, |
| 461 | capture_time_ms_low_priority, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 462 | .Times(1) |
| 463 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 464 | |
| 465 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 466 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 467 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 468 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 469 | } |
| 470 | |
terelius | f39f7d9 | 2016-07-20 03:36:19 -0700 | [diff] [blame] | 471 | TEST_F(PacedSenderTest, RetransmissionPriority) { |
| 472 | uint32_t ssrc = 12345; |
| 473 | uint16_t sequence_number = 1234; |
| 474 | int64_t capture_time_ms = 45678; |
| 475 | int64_t capture_time_ms_retransmission = 56789; |
| 476 | |
| 477 | // Due to the multiplicative factor we can send 5 packets during a send |
| 478 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 479 | // (packet size * #send intervals per second) |
| 480 | const size_t packets_to_send_per_interval = |
| 481 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 482 | send_bucket_->Process(); |
| 483 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 484 | |
| 485 | // Alternate retransmissions and normal packets. |
| 486 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 487 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 488 | sequence_number++, |
| 489 | capture_time_ms_retransmission, 250, true); |
| 490 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 491 | sequence_number++, capture_time_ms, 250, false); |
| 492 | } |
| 493 | EXPECT_EQ(2 * packets_to_send_per_interval, send_bucket_->QueueSizePackets()); |
| 494 | |
| 495 | // Expect all retransmissions to be sent out first despite having a later |
| 496 | // capture time. |
| 497 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 498 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, false, _)).Times(0); |
| 499 | EXPECT_CALL(callback_, TimeToSendPacket( |
| 500 | ssrc, _, capture_time_ms_retransmission, true, _)) |
| 501 | .Times(packets_to_send_per_interval) |
| 502 | .WillRepeatedly(Return(true)); |
| 503 | |
| 504 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 505 | clock_.AdvanceTimeMilliseconds(5); |
| 506 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 507 | send_bucket_->Process(); |
| 508 | EXPECT_EQ(packets_to_send_per_interval, send_bucket_->QueueSizePackets()); |
| 509 | |
| 510 | // Expect the remaining (non-retransmission) packets to be sent. |
| 511 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 512 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, true, _)).Times(0); |
| 513 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, false, _)) |
| 514 | .Times(packets_to_send_per_interval) |
| 515 | .WillRepeatedly(Return(true)); |
| 516 | |
| 517 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 518 | clock_.AdvanceTimeMilliseconds(5); |
| 519 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 520 | send_bucket_->Process(); |
| 521 | |
| 522 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 523 | } |
| 524 | |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 525 | TEST_F(PacedSenderTest, HighPrioDoesntAffectBudget) { |
| 526 | uint32_t ssrc = 12346; |
| 527 | uint16_t sequence_number = 1234; |
| 528 | int64_t capture_time_ms = 56789; |
| 529 | |
| 530 | // As high prio packets doesn't affect the budget, we should be able to send |
| 531 | // a high number of them at once. |
| 532 | for (int i = 0; i < 25; ++i) { |
| 533 | SendAndExpectPacket(PacedSender::kHighPriority, ssrc, sequence_number++, |
| 534 | capture_time_ms, 250, false); |
| 535 | } |
| 536 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 537 | // Low prio packets does affect the budget. |
| 538 | // Due to the multiplicative factor we can send 5 packets during a send |
| 539 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 540 | // (packet size * #send intervals per second) |
| 541 | const size_t packets_to_send_per_interval = |
| 542 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 543 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 544 | SendAndExpectPacket(PacedSender::kLowPriority, ssrc, sequence_number++, |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 545 | clock_.TimeInMilliseconds(), 250, false); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 546 | } |
| 547 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc, sequence_number, |
| 548 | capture_time_ms, 250, false); |
| 549 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 550 | clock_.AdvanceTimeMilliseconds(5); |
| 551 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 552 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 553 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number++, |
| 554 | capture_time_ms, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 555 | .Times(1) |
| 556 | .WillRepeatedly(Return(true)); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 557 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 558 | clock_.AdvanceTimeMilliseconds(5); |
| 559 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 560 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 561 | } |
| 562 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 563 | TEST_F(PacedSenderTest, Pause) { |
| 564 | uint32_t ssrc_low_priority = 12345; |
| 565 | uint32_t ssrc = 12346; |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 566 | uint32_t ssrc_high_priority = 12347; |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 567 | uint16_t sequence_number = 1234; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 568 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 569 | |
| 570 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 571 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 572 | // Due to the multiplicative factor we can send 5 packets during a send |
| 573 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 574 | // (packet size * #send intervals per second) |
| 575 | const size_t packets_to_send_per_interval = |
| 576 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 577 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 578 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 579 | clock_.TimeInMilliseconds(), 250, false); |
| 580 | } |
| 581 | |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 582 | send_bucket_->Process(); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 583 | |
| 584 | send_bucket_->Pause(); |
| 585 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 586 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 587 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 588 | sequence_number++, capture_time_ms, 250, false); |
| 589 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 590 | sequence_number++, capture_time_ms, 250, false); |
| 591 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc_high_priority, |
| 592 | sequence_number++, capture_time_ms, 250, false); |
| 593 | } |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 594 | clock_.AdvanceTimeMilliseconds(10000); |
| 595 | int64_t second_capture_time_ms = clock_.TimeInMilliseconds(); |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 596 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 597 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 598 | sequence_number++, second_capture_time_ms, 250, |
| 599 | false); |
| 600 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 601 | sequence_number++, second_capture_time_ms, 250, |
| 602 | false); |
| 603 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc_high_priority, |
| 604 | sequence_number++, second_capture_time_ms, 250, |
| 605 | false); |
| 606 | } |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 607 | |
| 608 | // Expect everything to be queued. |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 609 | EXPECT_EQ(second_capture_time_ms - capture_time_ms, |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 610 | send_bucket_->QueueInMs()); |
| 611 | |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 612 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 613 | EXPECT_CALL(callback_, TimeToSendPadding(1, _)).Times(1); |
| 614 | send_bucket_->Process(); |
| 615 | |
| 616 | int64_t expected_time_until_send = 500; |
| 617 | EXPECT_CALL(callback_, TimeToSendPadding(1, _)).Times(1); |
| 618 | while (expected_time_until_send >= 0) { |
tommi | 919dce2 | 2017-03-15 07:45:36 -0700 | [diff] [blame] | 619 | // TimeUntilNextProcess must not return 0 when paused. If it does, |
| 620 | // we risk running a busy loop, so ideally it should return a large value. |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 621 | EXPECT_EQ(expected_time_until_send, send_bucket_->TimeUntilNextProcess()); |
| 622 | if (expected_time_until_send == 0) |
| 623 | send_bucket_->Process(); |
| 624 | clock_.AdvanceTimeMilliseconds(5); |
| 625 | expected_time_until_send -= 5; |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 626 | } |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 627 | |
stefan | 099110c | 2017-02-01 03:57:42 -0800 | [diff] [blame] | 628 | // Expect high prio packets to come out first followed by normal |
| 629 | // prio packets and low prio packets (all in capture order). |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 630 | { |
| 631 | ::testing::InSequence sequence; |
stefan | 099110c | 2017-02-01 03:57:42 -0800 | [diff] [blame] | 632 | EXPECT_CALL(callback_, |
| 633 | TimeToSendPacket(ssrc_high_priority, _, capture_time_ms, _, _)) |
| 634 | .Times(packets_to_send_per_interval) |
| 635 | .WillRepeatedly(Return(true)); |
| 636 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc_high_priority, _, |
| 637 | second_capture_time_ms, _, _)) |
| 638 | .Times(packets_to_send_per_interval) |
| 639 | .WillRepeatedly(Return(true)); |
| 640 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 641 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 642 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, _, _)) |
| 643 | .Times(1) |
| 644 | .WillRepeatedly(Return(true)); |
| 645 | } |
| 646 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 647 | EXPECT_CALL(callback_, |
| 648 | TimeToSendPacket(ssrc, _, second_capture_time_ms, _, _)) |
| 649 | .Times(1) |
| 650 | .WillRepeatedly(Return(true)); |
| 651 | } |
| 652 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 653 | EXPECT_CALL(callback_, |
| 654 | TimeToSendPacket(ssrc_low_priority, _, capture_time_ms, _, _)) |
| 655 | .Times(1) |
| 656 | .WillRepeatedly(Return(true)); |
| 657 | } |
| 658 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 659 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc_low_priority, _, |
| 660 | second_capture_time_ms, _, _)) |
| 661 | .Times(1) |
| 662 | .WillRepeatedly(Return(true)); |
| 663 | } |
| 664 | } |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 665 | send_bucket_->Resume(); |
| 666 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 667 | for (size_t i = 0; i < 4; i++) { |
stefan | 64136af | 2017-08-14 08:03:17 -0700 | [diff] [blame] | 668 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 669 | send_bucket_->Process(); |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 670 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 671 | clock_.AdvanceTimeMilliseconds(5); |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 672 | } |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 673 | |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 674 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 675 | } |
| 676 | |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 677 | TEST_F(PacedSenderTest, ResendPacket) { |
| 678 | uint32_t ssrc = 12346; |
| 679 | uint16_t sequence_number = 1234; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 680 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 681 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 682 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 683 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 684 | sequence_number, capture_time_ms, 250, false); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 685 | clock_.AdvanceTimeMilliseconds(1); |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 686 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 687 | sequence_number + 1, capture_time_ms + 1, 250, |
| 688 | false); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 689 | clock_.AdvanceTimeMilliseconds(9999); |
| 690 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 691 | send_bucket_->QueueInMs()); |
| 692 | // Fails to send first packet so only one call. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 693 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
| 694 | capture_time_ms, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 695 | .Times(1) |
| 696 | .WillOnce(Return(false)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 697 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 698 | send_bucket_->Process(); |
| 699 | |
| 700 | // Queue remains unchanged. |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 701 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 702 | send_bucket_->QueueInMs()); |
| 703 | |
| 704 | // Fails to send second packet. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 705 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
| 706 | capture_time_ms, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 707 | .Times(1) |
| 708 | .WillOnce(Return(true)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 709 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
| 710 | capture_time_ms + 1, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 711 | .Times(1) |
| 712 | .WillOnce(Return(false)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 713 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 714 | send_bucket_->Process(); |
| 715 | |
| 716 | // Queue is reduced by 1 packet. |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 717 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms - 1, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 718 | send_bucket_->QueueInMs()); |
| 719 | |
| 720 | // Send second packet and queue becomes empty. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 721 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
| 722 | capture_time_ms + 1, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 723 | .Times(1) |
| 724 | .WillOnce(Return(true)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 725 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 726 | send_bucket_->Process(); |
| 727 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 728 | } |
| 729 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 730 | TEST_F(PacedSenderTest, ExpectedQueueTimeMs) { |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 731 | uint32_t ssrc = 12346; |
| 732 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 733 | const size_t kNumPackets = 60; |
| 734 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 735 | const int32_t kMaxBitrate = PacedSender::kDefaultPaceMultiplier * 30000; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 736 | EXPECT_EQ(0, send_bucket_->ExpectedQueueTimeMs()); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 737 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 738 | send_bucket_->SetEstimatedBitrate(30000); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 739 | for (size_t i = 0; i < kNumPackets; ++i) { |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 740 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 741 | clock_.TimeInMilliseconds(), kPacketSize, false); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 742 | } |
| 743 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 744 | // Queue in ms = 1000 * (bytes in queue) *8 / (bits per second) |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 745 | int64_t queue_in_ms = |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 746 | static_cast<int64_t>(1000 * kNumPackets * kPacketSize * 8 / kMaxBitrate); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 747 | EXPECT_EQ(queue_in_ms, send_bucket_->ExpectedQueueTimeMs()); |
stefan@webrtc.org | 168f23f | 2014-07-11 13:44:02 +0000 | [diff] [blame] | 748 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 749 | int64_t time_start = clock_.TimeInMilliseconds(); |
| 750 | while (send_bucket_->QueueSizePackets() > 0) { |
| 751 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 752 | if (time_until_process <= 0) { |
| 753 | send_bucket_->Process(); |
| 754 | } else { |
| 755 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 756 | } |
| 757 | } |
| 758 | int64_t duration = clock_.TimeInMilliseconds() - time_start; |
| 759 | |
| 760 | EXPECT_EQ(0, send_bucket_->ExpectedQueueTimeMs()); |
| 761 | |
sprang | 0a43fef | 2015-11-20 09:00:37 -0800 | [diff] [blame] | 762 | // Allow for aliasing, duration should be within one pack of max time limit. |
| 763 | EXPECT_NEAR(duration, PacedSender::kMaxQueueLengthMs, |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 764 | static_cast<int64_t>(1000 * kPacketSize * 8 / kMaxBitrate)); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 765 | } |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 766 | |
| 767 | TEST_F(PacedSenderTest, QueueTimeGrowsOverTime) { |
| 768 | uint32_t ssrc = 12346; |
| 769 | uint16_t sequence_number = 1234; |
| 770 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 771 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 772 | send_bucket_->SetEstimatedBitrate(30000); |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 773 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 774 | ssrc, |
| 775 | sequence_number, |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 776 | clock_.TimeInMilliseconds(), |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 777 | 1200, |
| 778 | false); |
| 779 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 780 | clock_.AdvanceTimeMilliseconds(500); |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 781 | EXPECT_EQ(500, send_bucket_->QueueInMs()); |
| 782 | send_bucket_->Process(); |
| 783 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 784 | } |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 785 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 786 | TEST_F(PacedSenderTest, ProbingWithInsertedPackets) { |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 787 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 788 | const int kInitialBitrateBps = 300000; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 789 | uint32_t ssrc = 12346; |
| 790 | uint16_t sequence_number = 1234; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 791 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 792 | PacedSenderProbing packet_sender; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 793 | send_bucket_.reset(new PacedSender(&clock_, &packet_sender, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 794 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
| 795 | send_bucket_->CreateProbeCluster(kSecondClusterBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 796 | send_bucket_->SetEstimatedBitrate(kInitialBitrateBps); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 797 | |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 798 | for (int i = 0; i < 10; ++i) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 799 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 800 | sequence_number++, clock_.TimeInMilliseconds(), |
| 801 | kPacketSize, false); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 802 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 803 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 804 | int64_t start = clock_.TimeInMilliseconds(); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 805 | while (packet_sender.packets_sent() < 5) { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 806 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 807 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 808 | send_bucket_->Process(); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 809 | } |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 810 | int packets_sent = packet_sender.packets_sent(); |
| 811 | // Validate first cluster bitrate. Note that we have to account for number |
| 812 | // of intervals and hence (packets_sent - 1) on the first cluster. |
| 813 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 814 | (clock_.TimeInMilliseconds() - start), |
| 815 | kFirstClusterBps, kBitrateProbingError); |
| 816 | EXPECT_EQ(0, packet_sender.padding_sent()); |
| 817 | |
sergeyu | 6dbbd89 | 2017-01-17 15:07:59 -0800 | [diff] [blame] | 818 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 819 | start = clock_.TimeInMilliseconds(); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 820 | while (packet_sender.packets_sent() < 10) { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 821 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 822 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 823 | send_bucket_->Process(); |
| 824 | } |
| 825 | packets_sent = packet_sender.packets_sent() - packets_sent; |
| 826 | // Validate second cluster bitrate. |
sergeyu | 6dbbd89 | 2017-01-17 15:07:59 -0800 | [diff] [blame] | 827 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 828 | (clock_.TimeInMilliseconds() - start), |
| 829 | kSecondClusterBps, kBitrateProbingError); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 830 | } |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 831 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 832 | TEST_F(PacedSenderTest, ProbingWithPaddingSupport) { |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 833 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 834 | const int kInitialBitrateBps = 300000; |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 835 | uint32_t ssrc = 12346; |
| 836 | uint16_t sequence_number = 1234; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 837 | |
| 838 | PacedSenderProbing packet_sender; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 839 | send_bucket_.reset(new PacedSender(&clock_, &packet_sender, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 840 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 841 | send_bucket_->SetEstimatedBitrate(kInitialBitrateBps); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 842 | |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 843 | for (int i = 0; i < 3; ++i) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 844 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 845 | sequence_number++, clock_.TimeInMilliseconds(), |
| 846 | kPacketSize, false); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 847 | } |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 848 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 849 | int64_t start = clock_.TimeInMilliseconds(); |
| 850 | int process_count = 0; |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 851 | while (process_count < 5) { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 852 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 853 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 854 | send_bucket_->Process(); |
| 855 | ++process_count; |
| 856 | } |
| 857 | int packets_sent = packet_sender.packets_sent(); |
| 858 | int padding_sent = packet_sender.padding_sent(); |
| 859 | EXPECT_GT(packets_sent, 0); |
| 860 | EXPECT_GT(padding_sent, 0); |
| 861 | // Note that the number of intervals here for kPacketSize is |
| 862 | // packets_sent due to padding in the same cluster. |
| 863 | EXPECT_NEAR((packets_sent * kPacketSize * 8000 + padding_sent) / |
| 864 | (clock_.TimeInMilliseconds() - start), |
| 865 | kFirstClusterBps, kBitrateProbingError); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 866 | } |
| 867 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 868 | TEST_F(PacedSenderTest, PriorityInversion) { |
| 869 | uint32_t ssrc = 12346; |
| 870 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 871 | const size_t kPacketSize = 1200; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 872 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 873 | send_bucket_->InsertPacket( |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 874 | PacedSender::kHighPriority, ssrc, sequence_number + 3, |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 875 | clock_.TimeInMilliseconds() + 33, kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 876 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 877 | send_bucket_->InsertPacket( |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 878 | PacedSender::kHighPriority, ssrc, sequence_number + 2, |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 879 | clock_.TimeInMilliseconds() + 33, kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 880 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 881 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc, sequence_number, |
| 882 | clock_.TimeInMilliseconds(), kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 883 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 884 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc, |
| 885 | sequence_number + 1, clock_.TimeInMilliseconds(), |
| 886 | kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 887 | |
| 888 | // Packets from earlier frames should be sent first. |
| 889 | { |
| 890 | ::testing::InSequence sequence; |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 891 | EXPECT_CALL(callback_, |
| 892 | TimeToSendPacket(ssrc, sequence_number, |
| 893 | clock_.TimeInMilliseconds(), true, _)) |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 894 | .WillOnce(Return(true)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 895 | EXPECT_CALL(callback_, |
| 896 | TimeToSendPacket(ssrc, sequence_number + 1, |
| 897 | clock_.TimeInMilliseconds(), true, _)) |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 898 | .WillOnce(Return(true)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 899 | EXPECT_CALL(callback_, |
| 900 | TimeToSendPacket(ssrc, sequence_number + 3, |
| 901 | clock_.TimeInMilliseconds() + 33, true, _)) |
| 902 | .WillOnce(Return(true)); |
| 903 | EXPECT_CALL(callback_, |
| 904 | TimeToSendPacket(ssrc, sequence_number + 2, |
| 905 | clock_.TimeInMilliseconds() + 33, true, _)) |
| 906 | .WillOnce(Return(true)); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 907 | |
| 908 | while (send_bucket_->QueueSizePackets() > 0) { |
| 909 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 910 | if (time_until_process <= 0) { |
| 911 | send_bucket_->Process(); |
| 912 | } else { |
| 913 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 914 | } |
| 915 | } |
| 916 | } |
| 917 | } |
| 918 | |
| 919 | TEST_F(PacedSenderTest, PaddingOveruse) { |
| 920 | uint32_t ssrc = 12346; |
| 921 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 922 | const size_t kPacketSize = 1200; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 923 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 924 | send_bucket_->Process(); |
| 925 | send_bucket_->SetEstimatedBitrate(60000); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 926 | send_bucket_->SetSendBitrateLimits(60000, 0); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 927 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 928 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 929 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 930 | send_bucket_->Process(); |
| 931 | |
| 932 | // Add 30kbit padding. When increasing budget, media budget will increase from |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 933 | // negative (overuse) while padding budget will increase from 0. |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 934 | clock_.AdvanceTimeMilliseconds(5); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 935 | send_bucket_->SetSendBitrateLimits(60000, 30000); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 936 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 937 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 938 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 939 | EXPECT_LT(5u, send_bucket_->ExpectedQueueTimeMs()); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 940 | // Don't send padding if queue is non-empty, even if padding budget > 0. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 941 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 942 | send_bucket_->Process(); |
| 943 | } |
| 944 | |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame^] | 945 | // TODO(philipel): Move to PacketQueue2 unittests. |
| 946 | #if 0 |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 947 | TEST_F(PacedSenderTest, AverageQueueTime) { |
| 948 | uint32_t ssrc = 12346; |
| 949 | uint16_t sequence_number = 1234; |
| 950 | const size_t kPacketSize = 1200; |
| 951 | const int kBitrateBps = 10 * kPacketSize * 8; // 10 packets per second. |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 952 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 953 | send_bucket_->SetEstimatedBitrate(kBitrateBps); |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 954 | |
| 955 | EXPECT_EQ(0, send_bucket_->AverageQueueTimeMs()); |
| 956 | |
| 957 | int64_t first_capture_time = clock_.TimeInMilliseconds(); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 958 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 959 | sequence_number, first_capture_time, kPacketSize, |
| 960 | false); |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 961 | clock_.AdvanceTimeMilliseconds(10); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 962 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 963 | sequence_number + 1, clock_.TimeInMilliseconds(), |
| 964 | kPacketSize, false); |
| 965 | clock_.AdvanceTimeMilliseconds(10); |
| 966 | |
| 967 | EXPECT_EQ((20 + 10) / 2, send_bucket_->AverageQueueTimeMs()); |
| 968 | |
| 969 | // Only first packet (queued for 20ms) should be removed, leave the second |
| 970 | // packet (queued for 10ms) alone in the queue. |
| 971 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 972 | first_capture_time, false, _)) |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 973 | .Times(1) |
| 974 | .WillRepeatedly(Return(true)); |
| 975 | send_bucket_->Process(); |
| 976 | |
| 977 | EXPECT_EQ(10, send_bucket_->AverageQueueTimeMs()); |
| 978 | |
| 979 | clock_.AdvanceTimeMilliseconds(10); |
| 980 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 981 | first_capture_time + 10, false, _)) |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 982 | .Times(1) |
| 983 | .WillRepeatedly(Return(true)); |
| 984 | for (int i = 0; i < 3; ++i) { |
| 985 | clock_.AdvanceTimeMilliseconds(30); // Max delta. |
| 986 | send_bucket_->Process(); |
| 987 | } |
| 988 | |
| 989 | EXPECT_EQ(0, send_bucket_->AverageQueueTimeMs()); |
| 990 | } |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame^] | 991 | #endif |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 992 | |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 993 | TEST_F(PacedSenderTest, ProbeClusterId) { |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 994 | uint32_t ssrc = 12346; |
| 995 | uint16_t sequence_number = 1234; |
| 996 | const size_t kPacketSize = 1200; |
| 997 | |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 998 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 999 | send_bucket_->SetProbingEnabled(true); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1000 | for (int i = 0; i < 10; ++i) { |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1001 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1002 | sequence_number + i, clock_.TimeInMilliseconds(), |
| 1003 | kPacketSize, false); |
| 1004 | } |
| 1005 | |
| 1006 | // First probing cluster. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1007 | EXPECT_CALL(callback_, |
| 1008 | TimeToSendPacket(_, _, _, _, |
| 1009 | Field(&PacedPacketInfo::probe_cluster_id, 0))) |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1010 | .Times(5) |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1011 | .WillRepeatedly(Return(true)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1012 | for (int i = 0; i < 5; ++i) { |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1013 | clock_.AdvanceTimeMilliseconds(20); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1014 | send_bucket_->Process(); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1015 | } |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1016 | |
| 1017 | // Second probing cluster. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1018 | EXPECT_CALL(callback_, |
| 1019 | TimeToSendPacket(_, _, _, _, |
| 1020 | Field(&PacedPacketInfo::probe_cluster_id, 1))) |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1021 | .Times(5) |
| 1022 | .WillRepeatedly(Return(true)); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1023 | for (int i = 0; i < 5; ++i) { |
| 1024 | clock_.AdvanceTimeMilliseconds(20); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1025 | send_bucket_->Process(); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1026 | } |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1027 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1028 | // Needed for the Field comparer below. |
| 1029 | const int kNotAProbe = PacedPacketInfo::kNotAProbe; |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1030 | // No more probing packets. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1031 | EXPECT_CALL(callback_, |
| 1032 | TimeToSendPadding( |
| 1033 | _, Field(&PacedPacketInfo::probe_cluster_id, kNotAProbe))) |
| 1034 | .Times(1) |
| 1035 | .WillRepeatedly(Return(500)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1036 | send_bucket_->Process(); |
| 1037 | } |
| 1038 | |
philipel | b61927c | 2017-02-28 07:05:23 -0800 | [diff] [blame] | 1039 | TEST_F(PacedSenderTest, AvoidBusyLoopOnSendFailure) { |
| 1040 | uint32_t ssrc = 12346; |
| 1041 | uint16_t sequence_number = 1234; |
| 1042 | const size_t kPacketSize = kFirstClusterBps / (8000 / 10); |
| 1043 | |
| 1044 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
| 1045 | send_bucket_->SetProbingEnabled(true); |
| 1046 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1047 | sequence_number, clock_.TimeInMilliseconds(), |
| 1048 | kPacketSize, false); |
| 1049 | |
| 1050 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, _, _)) |
| 1051 | .WillOnce(Return(true)); |
| 1052 | send_bucket_->Process(); |
| 1053 | EXPECT_EQ(10, send_bucket_->TimeUntilNextProcess()); |
| 1054 | clock_.AdvanceTimeMilliseconds(9); |
| 1055 | |
| 1056 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)) |
| 1057 | .Times(2) |
| 1058 | .WillRepeatedly(Return(0)); |
| 1059 | send_bucket_->Process(); |
| 1060 | EXPECT_EQ(1, send_bucket_->TimeUntilNextProcess()); |
| 1061 | clock_.AdvanceTimeMilliseconds(1); |
| 1062 | send_bucket_->Process(); |
| 1063 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 1064 | } |
| 1065 | |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame^] | 1066 | // TODO(philipel): Move to PacketQueue2 unittests. |
| 1067 | #if 0 |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1068 | TEST_F(PacedSenderTest, QueueTimeWithPause) { |
| 1069 | const size_t kPacketSize = 1200; |
| 1070 | const uint32_t kSsrc = 12346; |
| 1071 | uint16_t sequence_number = 1234; |
| 1072 | |
| 1073 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1074 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1075 | kPacketSize, false); |
| 1076 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1077 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1078 | kPacketSize, false); |
| 1079 | |
| 1080 | clock_.AdvanceTimeMilliseconds(100); |
| 1081 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1082 | |
| 1083 | send_bucket_->Pause(); |
| 1084 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1085 | |
| 1086 | // In paused state, queue time should not increase. |
| 1087 | clock_.AdvanceTimeMilliseconds(100); |
| 1088 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1089 | |
| 1090 | send_bucket_->Resume(); |
| 1091 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1092 | |
| 1093 | clock_.AdvanceTimeMilliseconds(100); |
| 1094 | EXPECT_EQ(200, send_bucket_->AverageQueueTimeMs()); |
| 1095 | } |
| 1096 | |
| 1097 | TEST_F(PacedSenderTest, QueueTimePausedDuringPush) { |
| 1098 | const size_t kPacketSize = 1200; |
| 1099 | const uint32_t kSsrc = 12346; |
| 1100 | uint16_t sequence_number = 1234; |
| 1101 | |
| 1102 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1103 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1104 | kPacketSize, false); |
| 1105 | clock_.AdvanceTimeMilliseconds(100); |
| 1106 | send_bucket_->Pause(); |
| 1107 | clock_.AdvanceTimeMilliseconds(100); |
| 1108 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1109 | |
| 1110 | // Add a new packet during paused phase. |
| 1111 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1112 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1113 | kPacketSize, false); |
| 1114 | // From a queue time perspective, packet inserted during pause will have zero |
| 1115 | // queue time. Average queue time will then be (0 + 100) / 2 = 50. |
| 1116 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1117 | |
| 1118 | clock_.AdvanceTimeMilliseconds(100); |
| 1119 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1120 | |
| 1121 | send_bucket_->Resume(); |
| 1122 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1123 | |
| 1124 | clock_.AdvanceTimeMilliseconds(100); |
| 1125 | EXPECT_EQ(150, send_bucket_->AverageQueueTimeMs()); |
| 1126 | } |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame^] | 1127 | #endif |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1128 | |
| 1129 | // TODO(sprang): Extract PacketQueue from PacedSender so that we can test |
| 1130 | // removing elements while paused. (This is possible, but only because of semi- |
| 1131 | // racy condition so can't easily be tested). |
| 1132 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 1133 | } // namespace test |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 1134 | } // namespace webrtc |