Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "link/ManifestFixer.h" |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 18 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 19 | #include "test/Test.h" |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 20 | |
Adam Lesinski | 87f1e0f | 2017-06-27 16:21:58 -0700 | [diff] [blame] | 21 | using ::android::StringPiece; |
| 22 | using ::testing::NotNull; |
Adam Lesinski | d5083f6 | 2017-01-16 15:07:21 -0800 | [diff] [blame] | 23 | |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 24 | namespace aapt { |
| 25 | |
| 26 | struct ManifestFixerTest : public ::testing::Test { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 27 | std::unique_ptr<IAaptContext> mContext; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 28 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 29 | void SetUp() override { |
| 30 | mContext = |
| 31 | test::ContextBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 32 | .SetCompilationPackage("android") |
| 33 | .SetPackageId(0x01) |
| 34 | .SetNameManglerPolicy(NameManglerPolicy{"android"}) |
| 35 | .AddSymbolSource( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 36 | test::StaticSymbolSourceBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 37 | .AddSymbol( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 38 | "android:attr/package", ResourceId(0x01010000), |
| 39 | test::AttributeBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 40 | .SetTypeMask(android::ResTable_map::TYPE_STRING) |
| 41 | .Build()) |
| 42 | .AddSymbol( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 43 | "android:attr/minSdkVersion", ResourceId(0x01010001), |
| 44 | test::AttributeBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 45 | .SetTypeMask(android::ResTable_map::TYPE_STRING | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 46 | android::ResTable_map::TYPE_INTEGER) |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 47 | .Build()) |
| 48 | .AddSymbol( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 49 | "android:attr/targetSdkVersion", ResourceId(0x01010002), |
| 50 | test::AttributeBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 51 | .SetTypeMask(android::ResTable_map::TYPE_STRING | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 52 | android::ResTable_map::TYPE_INTEGER) |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 53 | .Build()) |
| 54 | .AddSymbol("android:string/str", ResourceId(0x01060000)) |
| 55 | .Build()) |
| 56 | .Build(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 57 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 58 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 59 | std::unique_ptr<xml::XmlResource> Verify(const StringPiece& str) { |
| 60 | return VerifyWithOptions(str, {}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 61 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 62 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 63 | std::unique_ptr<xml::XmlResource> VerifyWithOptions( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 64 | const StringPiece& str, const ManifestFixerOptions& options) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 65 | std::unique_ptr<xml::XmlResource> doc = test::BuildXmlDom(str); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 66 | ManifestFixer fixer(options); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 67 | if (fixer.Consume(mContext.get(), doc.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 68 | return doc; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 69 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 70 | return {}; |
| 71 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 72 | }; |
| 73 | |
| 74 | TEST_F(ManifestFixerTest, EnsureManifestIsRootTag) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 75 | EXPECT_EQ(nullptr, Verify("<other-tag />")); |
| 76 | EXPECT_EQ(nullptr, Verify("<ns:manifest xmlns:ns=\"com\" />")); |
| 77 | EXPECT_NE(nullptr, Verify("<manifest package=\"android\"></manifest>")); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 78 | } |
| 79 | |
| 80 | TEST_F(ManifestFixerTest, EnsureManifestHasPackage) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 81 | EXPECT_NE(nullptr, Verify("<manifest package=\"android\" />")); |
| 82 | EXPECT_NE(nullptr, Verify("<manifest package=\"com.android\" />")); |
| 83 | EXPECT_NE(nullptr, Verify("<manifest package=\"com.android.google\" />")); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 84 | EXPECT_EQ(nullptr, |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 85 | Verify("<manifest package=\"com.android.google.Class$1\" />")); |
| 86 | EXPECT_EQ(nullptr, Verify("<manifest " |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 87 | "xmlns:android=\"http://schemas.android.com/apk/" |
| 88 | "res/android\" " |
| 89 | "android:package=\"com.android\" />")); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 90 | EXPECT_EQ(nullptr, Verify("<manifest package=\"@string/str\" />")); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 91 | } |
| 92 | |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 93 | TEST_F(ManifestFixerTest, AllowMetaData) { |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 94 | auto doc = Verify(R"EOF( |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 95 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 96 | package="android"> |
| 97 | <meta-data /> |
| 98 | <application> |
| 99 | <meta-data /> |
| 100 | <activity android:name=".Hi"><meta-data /></activity> |
| 101 | <activity-alias android:name=".Ho"><meta-data /></activity-alias> |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 102 | <receiver android:name=".OffTo"><meta-data /></receiver> |
| 103 | <provider android:name=".Work"><meta-data /></provider> |
| 104 | <service android:name=".We"><meta-data /></service> |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 105 | </application> |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 106 | <instrumentation android:name=".Go"><meta-data /></instrumentation> |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 107 | </manifest>)EOF"); |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 108 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 109 | } |
| 110 | |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 111 | TEST_F(ManifestFixerTest, UseDefaultSdkVersionsIfNonePresent) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 112 | ManifestFixerOptions options = {std::string("8"), std::string("22")}; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 113 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 114 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 115 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 116 | package="android"> |
| 117 | <uses-sdk android:minSdkVersion="7" android:targetSdkVersion="21" /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 118 | </manifest>)EOF", |
| 119 | options); |
| 120 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 121 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 122 | xml::Element* el; |
| 123 | xml::Attribute* attr; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 124 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 125 | el = doc->root.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 126 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 127 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 128 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 129 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 130 | ASSERT_NE(nullptr, attr); |
| 131 | EXPECT_EQ("7", attr->value); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 132 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 133 | ASSERT_NE(nullptr, attr); |
| 134 | EXPECT_EQ("21", attr->value); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 135 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 136 | doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 137 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 138 | package="android"> |
| 139 | <uses-sdk android:targetSdkVersion="21" /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 140 | </manifest>)EOF", |
| 141 | options); |
| 142 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 143 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 144 | el = doc->root.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 145 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 146 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 147 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 148 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 149 | ASSERT_NE(nullptr, attr); |
| 150 | EXPECT_EQ("8", attr->value); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 151 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 152 | ASSERT_NE(nullptr, attr); |
| 153 | EXPECT_EQ("21", attr->value); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 154 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 155 | doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 156 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 157 | package="android"> |
| 158 | <uses-sdk /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 159 | </manifest>)EOF", |
| 160 | options); |
| 161 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 162 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 163 | el = doc->root.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 164 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 165 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 166 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 167 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 168 | ASSERT_NE(nullptr, attr); |
| 169 | EXPECT_EQ("8", attr->value); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 170 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 171 | ASSERT_NE(nullptr, attr); |
| 172 | EXPECT_EQ("22", attr->value); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 173 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 174 | doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 175 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 176 | package="android" />)EOF", |
| 177 | options); |
| 178 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 179 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 180 | el = doc->root.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 181 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 182 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 183 | ASSERT_NE(nullptr, el); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 184 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 185 | ASSERT_NE(nullptr, attr); |
| 186 | EXPECT_EQ("8", attr->value); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 187 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 188 | ASSERT_NE(nullptr, attr); |
| 189 | EXPECT_EQ("22", attr->value); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 190 | } |
| 191 | |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 192 | TEST_F(ManifestFixerTest, UsesSdkMustComeBeforeApplication) { |
| 193 | ManifestFixerOptions options = {std::string("8"), std::string("22")}; |
| 194 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
| 195 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 196 | package="android"> |
| 197 | <application android:name=".MainApplication" /> |
| 198 | </manifest>)EOF", |
| 199 | options); |
| 200 | ASSERT_NE(nullptr, doc); |
| 201 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 202 | xml::Element* manifest_el = doc->root.get(); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 203 | ASSERT_NE(nullptr, manifest_el); |
| 204 | ASSERT_EQ("manifest", manifest_el->name); |
| 205 | |
| 206 | xml::Element* application_el = manifest_el->FindChild("", "application"); |
| 207 | ASSERT_NE(nullptr, application_el); |
| 208 | |
| 209 | xml::Element* uses_sdk_el = manifest_el->FindChild("", "uses-sdk"); |
| 210 | ASSERT_NE(nullptr, uses_sdk_el); |
| 211 | |
| 212 | // Check that the uses_sdk_el comes before application_el in the children |
| 213 | // vector. |
| 214 | // Since there are no namespaces here, these children are direct descendants |
| 215 | // of manifest. |
| 216 | auto uses_sdk_iter = |
| 217 | std::find_if(manifest_el->children.begin(), manifest_el->children.end(), |
| 218 | [&](const std::unique_ptr<xml::Node>& child) { |
| 219 | return child.get() == uses_sdk_el; |
| 220 | }); |
| 221 | |
| 222 | auto application_iter = |
| 223 | std::find_if(manifest_el->children.begin(), manifest_el->children.end(), |
| 224 | [&](const std::unique_ptr<xml::Node>& child) { |
| 225 | return child.get() == application_el; |
| 226 | }); |
| 227 | |
| 228 | ASSERT_NE(manifest_el->children.end(), uses_sdk_iter); |
| 229 | ASSERT_NE(manifest_el->children.end(), application_iter); |
| 230 | |
| 231 | // The distance should be positive, meaning uses_sdk_iter comes before |
| 232 | // application_iter. |
| 233 | EXPECT_GT(std::distance(uses_sdk_iter, application_iter), 0); |
| 234 | } |
| 235 | |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 236 | TEST_F(ManifestFixerTest, RenameManifestPackageAndFullyQualifyClasses) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 237 | ManifestFixerOptions options; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 238 | options.rename_manifest_package = std::string("com.android"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 239 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 240 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 241 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 242 | package="android"> |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 243 | <application android:name=".MainApplication" text="hello"> |
| 244 | <activity android:name=".activity.Start" /> |
| 245 | <receiver android:name="com.google.android.Receiver" /> |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 246 | </application> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 247 | </manifest>)EOF", |
| 248 | options); |
| 249 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 250 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 251 | xml::Element* manifestEl = doc->root.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 252 | ASSERT_NE(nullptr, manifestEl); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 253 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 254 | xml::Attribute* attr = nullptr; |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 255 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 256 | attr = manifestEl->FindAttribute({}, "package"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 257 | ASSERT_NE(nullptr, attr); |
| 258 | EXPECT_EQ(std::string("com.android"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 259 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 260 | xml::Element* applicationEl = manifestEl->FindChild({}, "application"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 261 | ASSERT_NE(nullptr, applicationEl); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 262 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 263 | attr = applicationEl->FindAttribute(xml::kSchemaAndroid, "name"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 264 | ASSERT_NE(nullptr, attr); |
| 265 | EXPECT_EQ(std::string("android.MainApplication"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 266 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 267 | attr = applicationEl->FindAttribute({}, "text"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 268 | ASSERT_NE(nullptr, attr); |
| 269 | EXPECT_EQ(std::string("hello"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 270 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 271 | xml::Element* el; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 272 | el = applicationEl->FindChild({}, "activity"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 273 | ASSERT_NE(nullptr, el); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 274 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 275 | attr = el->FindAttribute(xml::kSchemaAndroid, "name"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 276 | ASSERT_NE(nullptr, el); |
| 277 | EXPECT_EQ(std::string("android.activity.Start"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 278 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 279 | el = applicationEl->FindChild({}, "receiver"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 280 | ASSERT_NE(nullptr, el); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 281 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 282 | attr = el->FindAttribute(xml::kSchemaAndroid, "name"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 283 | ASSERT_NE(nullptr, el); |
| 284 | EXPECT_EQ(std::string("com.google.android.Receiver"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 285 | } |
| 286 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 287 | TEST_F(ManifestFixerTest, |
| 288 | RenameManifestInstrumentationPackageAndFullyQualifyTarget) { |
| 289 | ManifestFixerOptions options; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 290 | options.rename_instrumentation_target_package = std::string("com.android"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 291 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 292 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 293 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 294 | package="android"> |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 295 | <instrumentation android:name=".TestRunner" android:targetPackage="android" /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 296 | </manifest>)EOF", |
| 297 | options); |
| 298 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 299 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 300 | xml::Element* manifest_el = doc->root.get(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 301 | ASSERT_NE(nullptr, manifest_el); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 302 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 303 | xml::Element* instrumentation_el = |
| 304 | manifest_el->FindChild({}, "instrumentation"); |
| 305 | ASSERT_NE(nullptr, instrumentation_el); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 306 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 307 | xml::Attribute* attr = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 308 | instrumentation_el->FindAttribute(xml::kSchemaAndroid, "targetPackage"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 309 | ASSERT_NE(nullptr, attr); |
| 310 | EXPECT_EQ(std::string("com.android"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 311 | } |
| 312 | |
| 313 | TEST_F(ManifestFixerTest, UseDefaultVersionNameAndCode) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 314 | ManifestFixerOptions options; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 315 | options.version_name_default = std::string("Beta"); |
| 316 | options.version_code_default = std::string("0x10000000"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 317 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 318 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 319 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 320 | package="android" />)EOF", |
| 321 | options); |
| 322 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 323 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 324 | xml::Element* manifest_el = doc->root.get(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 325 | ASSERT_NE(nullptr, manifest_el); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 326 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 327 | xml::Attribute* attr = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 328 | manifest_el->FindAttribute(xml::kSchemaAndroid, "versionName"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 329 | ASSERT_NE(nullptr, attr); |
| 330 | EXPECT_EQ(std::string("Beta"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 331 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 332 | attr = manifest_el->FindAttribute(xml::kSchemaAndroid, "versionCode"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 333 | ASSERT_NE(nullptr, attr); |
| 334 | EXPECT_EQ(std::string("0x10000000"), attr->value); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 335 | } |
| 336 | |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 337 | TEST_F(ManifestFixerTest, EnsureManifestAttributesAreTyped) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 338 | EXPECT_EQ(nullptr, |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 339 | Verify("<manifest package=\"android\" coreApp=\"hello\" />")); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 340 | EXPECT_EQ(nullptr, |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 341 | Verify("<manifest package=\"android\" coreApp=\"1dp\" />")); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 342 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 343 | std::unique_ptr<xml::XmlResource> doc = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 344 | Verify("<manifest package=\"android\" coreApp=\"true\" />"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 345 | ASSERT_NE(nullptr, doc); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 346 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 347 | xml::Element* el = doc->root.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 348 | ASSERT_NE(nullptr, el); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 349 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 350 | EXPECT_EQ("manifest", el->name); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 351 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 352 | xml::Attribute* attr = el->FindAttribute("", "coreApp"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 353 | ASSERT_NE(nullptr, attr); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 354 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 355 | EXPECT_NE(nullptr, attr->compiled_value); |
| 356 | EXPECT_NE(nullptr, ValueCast<BinaryPrimitive>(attr->compiled_value.get())); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 357 | } |
| 358 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 359 | TEST_F(ManifestFixerTest, UsesFeatureMustHaveNameOrGlEsVersion) { |
| 360 | std::string input = R"EOF( |
| 361 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 362 | package="android"> |
| 363 | <uses-feature android:name="feature" /> |
| 364 | <uses-feature android:glEsVersion="1" /> |
| 365 | <feature-group /> |
| 366 | <feature-group> |
| 367 | <uses-feature android:name="feature_in_group" /> |
| 368 | <uses-feature android:glEsVersion="2" /> |
| 369 | </feature-group> |
| 370 | </manifest>)EOF"; |
| 371 | EXPECT_NE(nullptr, Verify(input)); |
| 372 | |
| 373 | input = R"EOF( |
| 374 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 375 | package="android"> |
| 376 | <uses-feature android:name="feature" android:glEsVersion="1" /> |
| 377 | </manifest>)EOF"; |
| 378 | EXPECT_EQ(nullptr, Verify(input)); |
| 379 | |
| 380 | input = R"EOF( |
| 381 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 382 | package="android"> |
| 383 | <uses-feature /> |
| 384 | </manifest>)EOF"; |
| 385 | EXPECT_EQ(nullptr, Verify(input)); |
| 386 | |
| 387 | input = R"EOF( |
| 388 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 389 | package="android"> |
| 390 | <feature-group> |
| 391 | <uses-feature android:name="feature" android:glEsVersion="1" /> |
| 392 | </feature-group> |
| 393 | </manifest>)EOF"; |
| 394 | EXPECT_EQ(nullptr, Verify(input)); |
| 395 | |
| 396 | input = R"EOF( |
| 397 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 398 | package="android"> |
| 399 | <feature-group> |
| 400 | <uses-feature /> |
| 401 | </feature-group> |
| 402 | </manifest>)EOF"; |
| 403 | EXPECT_EQ(nullptr, Verify(input)); |
| 404 | } |
| 405 | |
Adam Lesinski | 63699b1 | 2017-05-08 18:36:33 -0700 | [diff] [blame] | 406 | TEST_F(ManifestFixerTest, IgnoreNamespacedElements) { |
| 407 | std::string input = R"EOF( |
| 408 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 409 | package="android"> |
| 410 | <special:tag whoo="true" xmlns:special="http://google.com" /> |
| 411 | </manifest>)EOF"; |
| 412 | EXPECT_NE(nullptr, Verify(input)); |
| 413 | } |
| 414 | |
| 415 | TEST_F(ManifestFixerTest, DoNotIgnoreNonNamespacedElements) { |
| 416 | std::string input = R"EOF( |
| 417 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 418 | package="android"> |
| 419 | <tag whoo="true" /> |
| 420 | </manifest>)EOF"; |
| 421 | EXPECT_EQ(nullptr, Verify(input)); |
| 422 | } |
| 423 | |
Adam Lesinski | 87f1e0f | 2017-06-27 16:21:58 -0700 | [diff] [blame] | 424 | TEST_F(ManifestFixerTest, SupportKeySets) { |
| 425 | std::string input = R"( |
| 426 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 427 | package="android"> |
| 428 | <key-sets> |
| 429 | <key-set android:name="old-set"> |
| 430 | <public-key android:name="old-key" android:value="some+old+key" /> |
| 431 | </key-set> |
| 432 | <key-set android:name="new-set"> |
| 433 | <public-key android:name="new-key" android:value="some+new+key" /> |
| 434 | </key-set> |
| 435 | <upgrade-key-set android:name="old-set" /> |
| 436 | <upgrade-key-set android:name="new-set" /> |
| 437 | </key-sets> |
| 438 | </manifest>)"; |
| 439 | EXPECT_THAT(Verify(input), NotNull()); |
| 440 | } |
| 441 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 442 | } // namespace aapt |