Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License |
| 15 | */ |
| 16 | |
| 17 | package com.android.server.pm; |
| 18 | |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 19 | import android.annotation.Nullable; |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 20 | import android.content.Context; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 21 | import android.content.pm.ApplicationInfo; |
| 22 | import android.content.pm.PackageParser; |
Calin Juravle | adbadd5 | 2017-03-28 18:19:15 -0700 | [diff] [blame] | 23 | import android.os.FileUtils; |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 24 | import android.os.PowerManager; |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 25 | import android.os.SystemClock; |
Nicolas Geoffray | 20a894e | 2017-09-08 13:01:40 +0100 | [diff] [blame] | 26 | import android.os.SystemProperties; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 27 | import android.os.UserHandle; |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 28 | import android.os.WorkSource; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 29 | import android.util.Log; |
| 30 | import android.util.Slog; |
| 31 | |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 32 | import com.android.internal.annotations.GuardedBy; |
Narayan Kamath | 88eea9e | 2016-05-02 14:44:31 +0100 | [diff] [blame] | 33 | import com.android.internal.util.IndentingPrintWriter; |
Jeff Sharkey | 740f523 | 2016-12-09 14:31:26 -0700 | [diff] [blame] | 34 | import com.android.server.pm.Installer.InstallerException; |
Calin Juravle | fad6dc1 | 2017-08-03 19:48:37 -0700 | [diff] [blame] | 35 | import com.android.server.pm.dex.DexManager; |
Calin Juravle | dea3fd8 | 2017-07-17 15:12:01 -0700 | [diff] [blame] | 36 | import com.android.server.pm.dex.DexoptOptions; |
Calin Juravle | 0a267a8 | 2017-07-12 18:52:49 -0700 | [diff] [blame] | 37 | import com.android.server.pm.dex.DexoptUtils; |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 38 | import com.android.server.pm.dex.PackageDexUsage; |
Jeff Sharkey | fdeeeea | 2016-01-11 17:34:24 -0700 | [diff] [blame] | 39 | |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 40 | import java.io.File; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 41 | import java.io.IOException; |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 42 | import java.util.ArrayList; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 43 | import java.util.List; |
| 44 | |
| 45 | import dalvik.system.DexFile; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 46 | |
Todd Kennedy | fa54ab7 | 2015-09-25 07:46:12 -0700 | [diff] [blame] | 47 | import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE; |
| 48 | import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE; |
Andreas Gampe | bdd30d8 | 2016-03-20 11:32:11 -0700 | [diff] [blame] | 49 | import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED; |
Todd Kennedy | fa54ab7 | 2015-09-25 07:46:12 -0700 | [diff] [blame] | 50 | import static com.android.server.pm.Installer.DEXOPT_PUBLIC; |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 51 | import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX; |
| 52 | import static com.android.server.pm.Installer.DEXOPT_FORCE; |
| 53 | import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE; |
| 54 | import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 55 | import static com.android.server.pm.InstructionSets.getAppDexInstructionSets; |
| 56 | import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets; |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 57 | |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 58 | import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT; |
Nicolas Geoffray | b0818e8 | 2017-05-05 10:23:19 +0100 | [diff] [blame] | 59 | |
Nicolas Geoffray | d093b20 | 2017-05-03 13:11:58 +0100 | [diff] [blame] | 60 | import static dalvik.system.DexFile.getNonProfileGuidedCompilerFilter; |
| 61 | import static dalvik.system.DexFile.getSafeModeCompilerFilter; |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 62 | import static dalvik.system.DexFile.isProfileGuidedCompilerFilter; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 63 | |
| 64 | /** |
| 65 | * Helper class for running dexopt command on packages. |
| 66 | */ |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 67 | public class PackageDexOptimizer { |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 68 | private static final String TAG = "PackageManager.DexOptimizer"; |
| 69 | static final String OAT_DIR_NAME = "oat"; |
| 70 | // TODO b/19550105 Remove error codes and use exceptions |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 71 | public static final int DEX_OPT_SKIPPED = 0; |
| 72 | public static final int DEX_OPT_PERFORMED = 1; |
| 73 | public static final int DEX_OPT_FAILED = -1; |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 74 | // One minute over PM WATCHDOG_TIMEOUT |
| 75 | private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 76 | |
Calin Juravle | aae3576 | 2017-02-14 17:53:13 -0800 | [diff] [blame] | 77 | /** Special library name that skips shared libraries check during compilation. */ |
| 78 | public static final String SKIP_SHARED_LIBRARY_CHECK = "&"; |
| 79 | |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 80 | @GuardedBy("mInstallLock") |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 81 | private final Installer mInstaller; |
| 82 | private final Object mInstallLock; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 83 | |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 84 | @GuardedBy("mInstallLock") |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 85 | private final PowerManager.WakeLock mDexoptWakeLock; |
| 86 | private volatile boolean mSystemReady; |
| 87 | |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 88 | PackageDexOptimizer(Installer installer, Object installLock, Context context, |
| 89 | String wakeLockTag) { |
| 90 | this.mInstaller = installer; |
| 91 | this.mInstallLock = installLock; |
| 92 | |
| 93 | PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE); |
| 94 | mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag); |
| 95 | } |
| 96 | |
| 97 | protected PackageDexOptimizer(PackageDexOptimizer from) { |
| 98 | this.mInstaller = from.mInstaller; |
| 99 | this.mInstallLock = from.mInstallLock; |
| 100 | this.mDexoptWakeLock = from.mDexoptWakeLock; |
| 101 | this.mSystemReady = from.mSystemReady; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 102 | } |
| 103 | |
Calin Juravle | db4a79a | 2015-12-23 18:55:08 +0200 | [diff] [blame] | 104 | static boolean canOptimizePackage(PackageParser.Package pkg) { |
Nicolas Geoffray | 20a894e | 2017-09-08 13:01:40 +0100 | [diff] [blame] | 105 | // We do not dexopt a package with no code. |
| 106 | if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) { |
| 107 | return false; |
| 108 | } |
| 109 | |
| 110 | // We do not dexopt a priv-app package when pm.dexopt.priv-apps is false. |
| 111 | if (pkg.isPrivilegedApp()) { |
| 112 | return SystemProperties.getBoolean("pm.dexopt.priv-apps", true); |
| 113 | } |
| 114 | |
| 115 | return true; |
Calin Juravle | db4a79a | 2015-12-23 18:55:08 +0200 | [diff] [blame] | 116 | } |
| 117 | |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 118 | /** |
| 119 | * Performs dexopt on all code paths and libraries of the specified package for specified |
| 120 | * instruction sets. |
| 121 | * |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 122 | * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are |
| 123 | * synchronized on {@link #mInstallLock}. |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 124 | */ |
Jeff Hao | c7b9482 | 2016-03-16 15:56:07 -0700 | [diff] [blame] | 125 | int performDexOpt(PackageParser.Package pkg, String[] sharedLibraries, |
Calin Juravle | dea3fd8 | 2017-07-17 15:12:01 -0700 | [diff] [blame] | 126 | String[] instructionSets, CompilerStats.PackageStats packageStats, |
Calin Juravle | fad6dc1 | 2017-08-03 19:48:37 -0700 | [diff] [blame] | 127 | PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) { |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 128 | if (!canOptimizePackage(pkg)) { |
| 129 | return DEX_OPT_SKIPPED; |
| 130 | } |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 131 | synchronized (mInstallLock) { |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 132 | final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid); |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 133 | try { |
Calin Juravle | dea3fd8 | 2017-07-17 15:12:01 -0700 | [diff] [blame] | 134 | return performDexOptLI(pkg, sharedLibraries, instructionSets, |
Calin Juravle | fad6dc1 | 2017-08-03 19:48:37 -0700 | [diff] [blame] | 135 | packageStats, packageUseInfo, options); |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 136 | } finally { |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 137 | releaseWakeLockLI(acquireTime); |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 138 | } |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 139 | } |
| 140 | } |
| 141 | |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 142 | /** |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 143 | * Performs dexopt on all code paths of the given package. |
| 144 | * It assumes the install lock is held. |
| 145 | */ |
| 146 | @GuardedBy("mInstallLock") |
| 147 | private int performDexOptLI(PackageParser.Package pkg, String[] sharedLibraries, |
Calin Juravle | dea3fd8 | 2017-07-17 15:12:01 -0700 | [diff] [blame] | 148 | String[] targetInstructionSets, CompilerStats.PackageStats packageStats, |
Calin Juravle | fad6dc1 | 2017-08-03 19:48:37 -0700 | [diff] [blame] | 149 | PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) { |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 150 | final String[] instructionSets = targetInstructionSets != null ? |
| 151 | targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo); |
| 152 | final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets); |
Jeff Hao | 5def5e5 | 2017-04-19 14:42:16 -0700 | [diff] [blame] | 153 | final List<String> paths = pkg.getAllCodePaths(); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 154 | final int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid); |
| 155 | |
Calin Juravle | 0a267a8 | 2017-07-12 18:52:49 -0700 | [diff] [blame] | 156 | // Get the class loader context dependencies. |
| 157 | // For each code path in the package, this array contains the class loader context that |
| 158 | // needs to be passed to dexopt in order to ensure correct optimizations. |
| 159 | String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts( |
| 160 | pkg.applicationInfo, sharedLibraries); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 161 | |
| 162 | int result = DEX_OPT_SKIPPED; |
Jeff Hao | 5def5e5 | 2017-04-19 14:42:16 -0700 | [diff] [blame] | 163 | for (int i = 0; i < paths.size(); i++) { |
| 164 | // Skip paths that have no code. |
| 165 | if ((i == 0 && (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) || |
| 166 | (i != 0 && (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) == 0)) { |
| 167 | continue; |
| 168 | } |
| 169 | // Append shared libraries with split dependencies for this split. |
| 170 | String path = paths.get(i); |
Calin Juravle | caed600 | 2017-07-17 15:23:21 -0700 | [diff] [blame] | 171 | if (options.getSplitName() != null) { |
| 172 | // We are asked to compile only a specific split. Check that the current path is |
| 173 | // what we are looking for. |
| 174 | if (!options.getSplitName().equals(new File(path).getName())) { |
| 175 | continue; |
| 176 | } |
| 177 | } |
| 178 | |
Calin Juravle | fad6dc1 | 2017-08-03 19:48:37 -0700 | [diff] [blame] | 179 | final boolean isUsedByOtherApps = options.isDexoptAsSharedLibrary() |
Calin Juravle | 943d1e7 | 2017-08-04 01:42:17 -0700 | [diff] [blame^] | 180 | || packageUseInfo.isUsedByOtherApps(path); |
Calin Juravle | fad6dc1 | 2017-08-03 19:48:37 -0700 | [diff] [blame] | 181 | final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo, |
| 182 | options.getCompilerFilter(), isUsedByOtherApps); |
| 183 | final boolean profileUpdated = options.isCheckForProfileUpdates() && |
| 184 | isProfileUpdated(pkg, sharedGid, compilerFilter); |
| 185 | |
| 186 | // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct |
| 187 | // flags. |
| 188 | final int dexoptFlags = getDexFlags(pkg, compilerFilter, options.isBootComplete()); |
| 189 | |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 190 | for (String dexCodeIsa : dexCodeInstructionSets) { |
Calin Juravle | 0a267a8 | 2017-07-12 18:52:49 -0700 | [diff] [blame] | 191 | int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter, |
| 192 | profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid, |
| 193 | packageStats, options.isDowngrade()); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 194 | // The end result is: |
| 195 | // - FAILED if any path failed, |
| 196 | // - PERFORMED if at least one path needed compilation, |
| 197 | // - SKIPPED when all paths are up to date |
| 198 | if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) { |
| 199 | result = newResult; |
| 200 | } |
| 201 | } |
| 202 | } |
| 203 | return result; |
| 204 | } |
| 205 | |
| 206 | /** |
| 207 | * Performs dexopt on the {@code path} belonging to the package {@code pkg}. |
| 208 | * |
| 209 | * @return |
| 210 | * DEX_OPT_FAILED if there was any exception during dexopt |
| 211 | * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path. |
| 212 | * DEX_OPT_SKIPPED if the path does not need to be deopt-ed. |
| 213 | */ |
| 214 | @GuardedBy("mInstallLock") |
| 215 | private int dexOptPath(PackageParser.Package pkg, String path, String isa, |
Calin Juravle | 7ba73dd | 2017-09-12 00:58:33 -0700 | [diff] [blame] | 216 | String compilerFilter, boolean profileUpdated, String classLoaderContext, |
Shubham Ajmera | 3aeca17 | 2017-05-24 17:46:36 -0700 | [diff] [blame] | 217 | int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade) { |
Calin Juravle | 7ba73dd | 2017-09-12 00:58:33 -0700 | [diff] [blame] | 218 | int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext, |
| 219 | profileUpdated, downgrade); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 220 | if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) { |
| 221 | return DEX_OPT_SKIPPED; |
| 222 | } |
| 223 | |
| 224 | // TODO(calin): there's no need to try to create the oat dir over and over again, |
| 225 | // especially since it involve an extra installd call. We should create |
| 226 | // if (if supported) on the fly during the dexopt call. |
| 227 | String oatDir = createOatDirIfSupported(pkg, isa); |
| 228 | |
| 229 | Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path |
| 230 | + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa |
| 231 | + " dexoptFlags=" + printDexoptFlags(dexoptFlags) |
Calin Juravle | 7ba73dd | 2017-09-12 00:58:33 -0700 | [diff] [blame] | 232 | + " targetFilter=" + compilerFilter + " oatDir=" + oatDir |
| 233 | + " classLoaderContext=" + classLoaderContext); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 234 | |
| 235 | try { |
| 236 | long startTime = System.currentTimeMillis(); |
| 237 | |
Shubham Ajmera | 3aeca17 | 2017-05-24 17:46:36 -0700 | [diff] [blame] | 238 | // TODO: Consider adding 2 different APIs for primary and secondary dexopt. |
| 239 | // installd only uses downgrade flag for secondary dex files and ignores it for |
| 240 | // primary dex files. |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 241 | mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags, |
Calin Juravle | 7ba73dd | 2017-09-12 00:58:33 -0700 | [diff] [blame] | 242 | compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo, |
Shubham Ajmera | 3aeca17 | 2017-05-24 17:46:36 -0700 | [diff] [blame] | 243 | false /* downgrade*/); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 244 | |
| 245 | if (packageStats != null) { |
| 246 | long endTime = System.currentTimeMillis(); |
| 247 | packageStats.setCompileTime(path, (int)(endTime - startTime)); |
| 248 | } |
| 249 | return DEX_OPT_PERFORMED; |
| 250 | } catch (InstallerException e) { |
| 251 | Slog.w(TAG, "Failed to dexopt", e); |
| 252 | return DEX_OPT_FAILED; |
| 253 | } |
| 254 | } |
| 255 | |
| 256 | /** |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 257 | * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}. |
| 258 | * |
| 259 | * @return |
| 260 | * DEX_OPT_FAILED if there was any exception during dexopt |
| 261 | * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path. |
| 262 | * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file |
| 263 | * didn't need an update. That's because at the moment we don't get more than success/failure |
| 264 | * from installd. |
| 265 | * |
| 266 | * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than |
| 267 | * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though |
| 268 | * that seems wasteful. |
| 269 | */ |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 270 | public int dexOptSecondaryDexPath(ApplicationInfo info, String path, |
| 271 | PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) { |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 272 | synchronized (mInstallLock) { |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 273 | final long acquireTime = acquireWakeLockLI(info.uid); |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 274 | try { |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 275 | return dexOptSecondaryDexPathLI(info, path, dexUseInfo, options); |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 276 | } finally { |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 277 | releaseWakeLockLI(acquireTime); |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 278 | } |
| 279 | } |
| 280 | } |
| 281 | |
| 282 | @GuardedBy("mInstallLock") |
Fyodor Kupolov | 28f2855 | 2017-05-02 12:11:02 -0700 | [diff] [blame] | 283 | private long acquireWakeLockLI(final int uid) { |
| 284 | // During boot the system doesn't need to instantiate and obtain a wake lock. |
| 285 | // PowerManager might not be ready, but that doesn't mean that we can't proceed with |
| 286 | // dexopt. |
| 287 | if (!mSystemReady) { |
| 288 | return -1; |
| 289 | } |
| 290 | mDexoptWakeLock.setWorkSource(new WorkSource(uid)); |
| 291 | mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS); |
| 292 | return SystemClock.elapsedRealtime(); |
| 293 | } |
| 294 | |
| 295 | @GuardedBy("mInstallLock") |
| 296 | private void releaseWakeLockLI(final long acquireTime) { |
| 297 | if (acquireTime < 0) { |
| 298 | return; |
| 299 | } |
| 300 | try { |
| 301 | if (mDexoptWakeLock.isHeld()) { |
| 302 | mDexoptWakeLock.release(); |
| 303 | } |
| 304 | final long duration = SystemClock.elapsedRealtime() - acquireTime; |
| 305 | if (duration >= WAKELOCK_TIMEOUT_MS) { |
| 306 | Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag() |
| 307 | + " time out. Operation took " + duration + " ms. Thread: " |
| 308 | + Thread.currentThread().getName()); |
| 309 | } |
| 310 | } catch (Exception e) { |
| 311 | Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e); |
| 312 | } |
| 313 | } |
| 314 | |
| 315 | @GuardedBy("mInstallLock") |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 316 | private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path, |
| 317 | PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) { |
| 318 | if (options.isDexoptOnlySharedDex() && !dexUseInfo.isUsedByOtherApps()) { |
| 319 | // We are asked to optimize only the dex files used by other apps and this is not |
| 320 | // on of them: skip it. |
| 321 | return DEX_OPT_SKIPPED; |
| 322 | } |
| 323 | |
| 324 | String compilerFilter = getRealCompilerFilter(info, options.getCompilerFilter(), |
| 325 | dexUseInfo.isUsedByOtherApps()); |
Calin Juravle | efb1c94 | 2017-04-04 20:31:44 -0700 | [diff] [blame] | 326 | // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags. |
Nicolas Geoffray | 3b4359a | 2017-05-25 13:53:22 +0100 | [diff] [blame] | 327 | // Secondary dex files are currently not compiled at boot. |
| 328 | int dexoptFlags = getDexFlags(info, compilerFilter, /* bootComplete */ true) |
| 329 | | DEXOPT_SECONDARY_DEX; |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 330 | // Check the app storage and add the appropriate flags. |
Calin Juravle | adbadd5 | 2017-03-28 18:19:15 -0700 | [diff] [blame] | 331 | if (info.deviceProtectedDataDir != null && |
| 332 | FileUtils.contains(info.deviceProtectedDataDir, path)) { |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 333 | dexoptFlags |= DEXOPT_STORAGE_DE; |
Calin Juravle | adbadd5 | 2017-03-28 18:19:15 -0700 | [diff] [blame] | 334 | } else if (info.credentialProtectedDataDir != null && |
| 335 | FileUtils.contains(info.credentialProtectedDataDir, path)) { |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 336 | dexoptFlags |= DEXOPT_STORAGE_CE; |
| 337 | } else { |
| 338 | Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName); |
| 339 | return DEX_OPT_FAILED; |
| 340 | } |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 341 | Log.d(TAG, "Running dexopt on: " + path |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 342 | + " pkg=" + info.packageName + " isa=" + dexUseInfo.getLoaderIsas() |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 343 | + " dexoptFlags=" + printDexoptFlags(dexoptFlags) |
| 344 | + " target-filter=" + compilerFilter); |
| 345 | |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 346 | String classLoaderContext; |
| 347 | if (dexUseInfo.isUnknownClassLoaderContext() || |
| 348 | dexUseInfo.isUnsupportedClassLoaderContext() || |
| 349 | dexUseInfo.isVariableClassLoaderContext()) { |
| 350 | // If we have an unknown (not yet set), unsupported (custom class loaders), or a |
| 351 | // variable class loader chain, compile without a context and mark the oat file with |
| 352 | // SKIP_SHARED_LIBRARY_CHECK. Note that his might lead to a incorrect compilation. |
| 353 | // TODO(calin): We should just extract in this case. |
| 354 | classLoaderContext = SKIP_SHARED_LIBRARY_CHECK; |
| 355 | } else { |
| 356 | classLoaderContext = dexUseInfo.getClassLoaderContext(); |
| 357 | } |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 358 | try { |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 359 | for (String isa : dexUseInfo.getLoaderIsas()) { |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 360 | // Reuse the same dexopt path as for the primary apks. We don't need all the |
| 361 | // arguments as some (dexopNeeded and oatDir) will be computed by installd because |
| 362 | // system server cannot read untrusted app content. |
| 363 | // TODO(calin): maybe add a separate call. |
| 364 | mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0, |
| 365 | /*oatDir*/ null, dexoptFlags, |
Calin Juravle | a18e992 | 2017-07-22 12:33:41 -0700 | [diff] [blame] | 366 | compilerFilter, info.volumeUuid, classLoaderContext, info.seInfoUser, |
| 367 | options.isDowngrade()); |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 368 | } |
| 369 | |
| 370 | return DEX_OPT_PERFORMED; |
| 371 | } catch (InstallerException e) { |
| 372 | Slog.w(TAG, "Failed to dexopt", e); |
| 373 | return DEX_OPT_FAILED; |
| 374 | } |
| 375 | } |
| 376 | |
| 377 | /** |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 378 | * Adjust the given dexopt-needed value. Can be overridden to influence the decision to |
| 379 | * optimize or not (and in what way). |
| 380 | */ |
| 381 | protected int adjustDexoptNeeded(int dexoptNeeded) { |
| 382 | return dexoptNeeded; |
| 383 | } |
| 384 | |
| 385 | /** |
| 386 | * Adjust the given dexopt flags that will be passed to the installer. |
| 387 | */ |
| 388 | protected int adjustDexoptFlags(int dexoptFlags) { |
| 389 | return dexoptFlags; |
| 390 | } |
| 391 | |
Narayan Kamath | 88eea9e | 2016-05-02 14:44:31 +0100 | [diff] [blame] | 392 | /** |
| 393 | * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}. |
| 394 | */ |
| 395 | void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg) { |
| 396 | final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo); |
| 397 | final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets); |
| 398 | |
| 399 | final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly(); |
| 400 | |
| 401 | for (String instructionSet : dexCodeInstructionSets) { |
| 402 | pw.println("Instruction Set: " + instructionSet); |
| 403 | pw.increaseIndent(); |
| 404 | for (String path : paths) { |
| 405 | String status = null; |
| 406 | try { |
| 407 | status = DexFile.getDexFileStatus(path, instructionSet); |
| 408 | } catch (IOException ioe) { |
| 409 | status = "[Exception]: " + ioe.getMessage(); |
| 410 | } |
| 411 | pw.println("path: " + path); |
| 412 | pw.println("status: " + status); |
| 413 | } |
| 414 | pw.decreaseIndent(); |
| 415 | } |
| 416 | } |
| 417 | |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 418 | /** |
| 419 | * Returns the compiler filter that should be used to optimize the package code. |
| 420 | * The target filter will be updated if the package code is used by other apps |
| 421 | * or if it has the safe mode flag set. |
| 422 | */ |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 423 | private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter, |
| 424 | boolean isUsedByOtherApps) { |
| 425 | int flags = info.flags; |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 426 | boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0; |
Mathieu Chartier | 41e4a37 | 2016-09-02 16:36:42 -0700 | [diff] [blame] | 427 | if (vmSafeMode) { |
Nicolas Geoffray | d093b20 | 2017-05-03 13:11:58 +0100 | [diff] [blame] | 428 | return getSafeModeCompilerFilter(targetCompilerFilter); |
Mathieu Chartier | 41e4a37 | 2016-09-02 16:36:42 -0700 | [diff] [blame] | 429 | } |
| 430 | |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 431 | if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) { |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 432 | // If the dex files is used by other apps, we cannot use profile-guided compilation. |
| 433 | return getNonProfileGuidedCompilerFilter(targetCompilerFilter); |
Andreas Gampe | bdd30d8 | 2016-03-20 11:32:11 -0700 | [diff] [blame] | 434 | } |
| 435 | |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 436 | return targetCompilerFilter; |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 437 | } |
| 438 | |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 439 | /** |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 440 | * Computes the dex flags that needs to be pass to installd for the given package and compiler |
| 441 | * filter. |
| 442 | */ |
Nicolas Geoffray | 3b4359a | 2017-05-25 13:53:22 +0100 | [diff] [blame] | 443 | private int getDexFlags(PackageParser.Package pkg, String compilerFilter, |
| 444 | boolean bootComplete) { |
| 445 | return getDexFlags(pkg.applicationInfo, compilerFilter, bootComplete); |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 446 | } |
| 447 | |
Nicolas Geoffray | 3b4359a | 2017-05-25 13:53:22 +0100 | [diff] [blame] | 448 | private int getDexFlags(ApplicationInfo info, String compilerFilter, boolean bootComplete) { |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 449 | int flags = info.flags; |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 450 | boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0; |
| 451 | // Profile guide compiled oat files should not be public. |
| 452 | boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter); |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 453 | boolean isPublic = !info.isForwardLocked() && !isProfileGuidedFilter; |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 454 | int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0; |
| 455 | int dexFlags = |
| 456 | (isPublic ? DEXOPT_PUBLIC : 0) |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 457 | | (debuggable ? DEXOPT_DEBUGGABLE : 0) |
| 458 | | profileFlag |
Nicolas Geoffray | 3b4359a | 2017-05-25 13:53:22 +0100 | [diff] [blame] | 459 | | (bootComplete ? DEXOPT_BOOTCOMPLETE : 0); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 460 | return adjustDexoptFlags(dexFlags); |
| 461 | } |
| 462 | |
| 463 | /** |
| 464 | * Assesses if there's a need to perform dexopt on {@code path} for the given |
| 465 | * configuration (isa, compiler filter, profile). |
| 466 | */ |
| 467 | private int getDexoptNeeded(String path, String isa, String compilerFilter, |
Calin Juravle | 7ba73dd | 2017-09-12 00:58:33 -0700 | [diff] [blame] | 468 | String classLoaderContext, boolean newProfile, boolean downgrade) { |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 469 | int dexoptNeeded; |
| 470 | try { |
Calin Juravle | 7ba73dd | 2017-09-12 00:58:33 -0700 | [diff] [blame] | 471 | dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext, |
| 472 | newProfile, downgrade); |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 473 | } catch (IOException ioe) { |
| 474 | Slog.w(TAG, "IOException reading apk: " + path, ioe); |
| 475 | return DEX_OPT_FAILED; |
| 476 | } |
| 477 | return adjustDexoptNeeded(dexoptNeeded); |
| 478 | } |
| 479 | |
| 480 | /** |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 481 | * Checks if there is an update on the profile information of the {@code pkg}. |
| 482 | * If the compiler filter is not profile guided the method returns false. |
| 483 | * |
| 484 | * Note that this is a "destructive" operation with side effects. Under the hood the |
| 485 | * current profile and the reference profile will be merged and subsequent calls |
| 486 | * may return a different result. |
| 487 | */ |
| 488 | private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String compilerFilter) { |
| 489 | // Check if we are allowed to merge and if the compiler filter is profile guided. |
| 490 | if (!isProfileGuidedCompilerFilter(compilerFilter)) { |
| 491 | return false; |
| 492 | } |
| 493 | // Merge profiles. It returns whether or not there was an updated in the profile info. |
| 494 | try { |
| 495 | return mInstaller.mergeProfiles(uid, pkg.packageName); |
| 496 | } catch (InstallerException e) { |
| 497 | Slog.w(TAG, "Failed to merge profiles", e); |
| 498 | } |
| 499 | return false; |
| 500 | } |
| 501 | |
| 502 | /** |
| 503 | * Creates oat dir for the specified package if needed and supported. |
| 504 | * In certain cases oat directory |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 505 | * <strong>cannot</strong> be created: |
| 506 | * <ul> |
| 507 | * <li>{@code pkg} is a system app, which is not updated.</li> |
| 508 | * <li>Package location is not a directory, i.e. monolithic install.</li> |
| 509 | * </ul> |
| 510 | * |
Richard Uhler | 7b08b35 | 2015-03-25 16:25:57 -0700 | [diff] [blame] | 511 | * @return Absolute path to the oat directory or null, if oat directory |
| 512 | * cannot be created. |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 513 | */ |
| 514 | @Nullable |
Todd Kennedy | 27c24fb | 2015-09-17 16:49:25 -0700 | [diff] [blame] | 515 | private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) { |
Fyodor Kupolov | ebcac16 | 2015-09-09 15:56:45 -0700 | [diff] [blame] | 516 | if (!pkg.canHaveOatDir()) { |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 517 | return null; |
| 518 | } |
| 519 | File codePath = new File(pkg.codePath); |
| 520 | if (codePath.isDirectory()) { |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 521 | // TODO(calin): why do we create this only if the codePath is a directory? (i.e for |
| 522 | // cluster packages). It seems that the logic for the folder creation is |
| 523 | // split between installd and here. |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 524 | File oatDir = getOatDir(codePath); |
Jeff Sharkey | fdeeeea | 2016-01-11 17:34:24 -0700 | [diff] [blame] | 525 | try { |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 526 | mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet); |
Jeff Sharkey | fdeeeea | 2016-01-11 17:34:24 -0700 | [diff] [blame] | 527 | } catch (InstallerException e) { |
| 528 | Slog.w(TAG, "Failed to create oat dir", e); |
| 529 | return null; |
| 530 | } |
Richard Uhler | 7b08b35 | 2015-03-25 16:25:57 -0700 | [diff] [blame] | 531 | return oatDir.getAbsolutePath(); |
Fyodor Kupolov | b94c165 | 2015-03-03 12:25:30 -0800 | [diff] [blame] | 532 | } |
| 533 | return null; |
| 534 | } |
| 535 | |
| 536 | static File getOatDir(File codePath) { |
| 537 | return new File(codePath, OAT_DIR_NAME); |
| 538 | } |
| 539 | |
Fyodor Kupolov | a627c09 | 2015-05-05 18:44:39 -0700 | [diff] [blame] | 540 | void systemReady() { |
| 541 | mSystemReady = true; |
| 542 | } |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 543 | |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 544 | private String printDexoptFlags(int flags) { |
| 545 | ArrayList<String> flagsList = new ArrayList<>(); |
| 546 | |
| 547 | if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) { |
| 548 | flagsList.add("boot_complete"); |
| 549 | } |
| 550 | if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) { |
| 551 | flagsList.add("debuggable"); |
| 552 | } |
| 553 | if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) { |
| 554 | flagsList.add("profile_guided"); |
| 555 | } |
| 556 | if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) { |
| 557 | flagsList.add("public"); |
| 558 | } |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 559 | if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) { |
| 560 | flagsList.add("secondary"); |
| 561 | } |
| 562 | if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) { |
| 563 | flagsList.add("force"); |
| 564 | } |
| 565 | if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) { |
| 566 | flagsList.add("storage_ce"); |
| 567 | } |
| 568 | if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) { |
| 569 | flagsList.add("storage_de"); |
| 570 | } |
| 571 | |
Calin Juravle | 2d4b6ad7 | 2017-01-04 13:22:14 -0800 | [diff] [blame] | 572 | return String.join(",", flagsList); |
| 573 | } |
| 574 | |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 575 | /** |
| 576 | * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a |
| 577 | * dexopt path. |
| 578 | */ |
| 579 | public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer { |
| 580 | |
| 581 | public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock, |
| 582 | Context context, String wakeLockTag) { |
| 583 | super(installer, installLock, context, wakeLockTag); |
| 584 | } |
| 585 | |
| 586 | public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) { |
| 587 | super(from); |
| 588 | } |
| 589 | |
| 590 | @Override |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 591 | protected int adjustDexoptNeeded(int dexoptNeeded) { |
Nicolas Geoffray | 96d12a9 | 2017-05-03 11:51:53 +0100 | [diff] [blame] | 592 | if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) { |
| 593 | // Ensure compilation by pretending a compiler filter change on the |
| 594 | // apk/odex location (the reason for the '-'. A positive value means |
| 595 | // the 'oat' location). |
| 596 | return -DexFile.DEX2OAT_FOR_FILTER; |
| 597 | } |
| 598 | return dexoptNeeded; |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 599 | } |
Calin Juravle | c22c30e | 2017-01-16 19:18:48 -0800 | [diff] [blame] | 600 | |
| 601 | @Override |
| 602 | protected int adjustDexoptFlags(int flags) { |
| 603 | // Add DEXOPT_FORCE flag to signal installd that it should force compilation |
| 604 | // and discard dexoptanalyzer result. |
| 605 | return flags | DEXOPT_FORCE; |
| 606 | } |
Andreas Gampe | a890875 | 2015-11-10 08:58:14 -0800 | [diff] [blame] | 607 | } |
Fyodor Kupolov | 7487657 | 2015-02-23 17:14:45 -0800 | [diff] [blame] | 608 | } |