Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2017 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "link/XmlCompatVersioner.h" |
| 18 | |
| 19 | #include "Linkers.h" |
| 20 | #include "test/Test.h" |
| 21 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 22 | using ::aapt::test::ValueEq; |
| 23 | using ::testing::Eq; |
| 24 | using ::testing::IsNull; |
| 25 | using ::testing::NotNull; |
| 26 | using ::testing::SizeIs; |
| 27 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 28 | namespace aapt { |
| 29 | |
| 30 | constexpr auto TYPE_DIMENSION = android::ResTable_map::TYPE_DIMENSION; |
| 31 | constexpr auto TYPE_STRING = android::ResTable_map::TYPE_STRING; |
| 32 | |
| 33 | struct R { |
| 34 | struct attr { |
| 35 | enum : uint32_t { |
| 36 | paddingLeft = 0x010100d6u, // (API 1) |
| 37 | paddingRight = 0x010100d8u, // (API 1) |
| 38 | progressBarPadding = 0x01010319u, // (API 11) |
| 39 | paddingStart = 0x010103b3u, // (API 17) |
| 40 | paddingHorizontal = 0x0101053du, // (API 26) |
| 41 | }; |
| 42 | }; |
| 43 | }; |
| 44 | |
| 45 | class XmlCompatVersionerTest : public ::testing::Test { |
| 46 | public: |
| 47 | void SetUp() override { |
| 48 | context_ = |
| 49 | test::ContextBuilder() |
| 50 | .SetCompilationPackage("com.app") |
| 51 | .SetPackageId(0x7f) |
| 52 | .SetPackageType(PackageType::kApp) |
| 53 | .SetMinSdkVersion(SDK_GINGERBREAD) |
| 54 | .AddSymbolSource( |
| 55 | test::StaticSymbolSourceBuilder() |
| 56 | .AddPublicSymbol("android:attr/paddingLeft", R::attr::paddingLeft, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 57 | util::make_unique<Attribute>(TYPE_DIMENSION)) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 58 | .AddPublicSymbol("android:attr/paddingRight", R::attr::paddingRight, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 59 | util::make_unique<Attribute>(TYPE_DIMENSION)) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 60 | .AddPublicSymbol("android:attr/progressBarPadding", R::attr::progressBarPadding, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 61 | util::make_unique<Attribute>(TYPE_DIMENSION)) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 62 | .AddPublicSymbol("android:attr/paddingStart", R::attr::paddingStart, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 63 | util::make_unique<Attribute>(TYPE_DIMENSION)) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 64 | .AddPublicSymbol("android:attr/paddingHorizontal", R::attr::paddingHorizontal, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 65 | util::make_unique<Attribute>(TYPE_DIMENSION)) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 66 | .AddSymbol("com.app:attr/foo", ResourceId(0x7f010000), |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 67 | util::make_unique<Attribute>(TYPE_STRING)) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 68 | .Build()) |
| 69 | .Build(); |
| 70 | } |
| 71 | |
| 72 | protected: |
| 73 | std::unique_ptr<IAaptContext> context_; |
| 74 | }; |
| 75 | |
| 76 | TEST_F(XmlCompatVersionerTest, NoRulesOnlyStripsAndCopies) { |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 77 | auto doc = test::BuildXmlDomForPackageName(context_.get(), R"( |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 78 | <View xmlns:android="http://schemas.android.com/apk/res/android" |
| 79 | xmlns:app="http://schemas.android.com/apk/res-auto" |
| 80 | android:paddingHorizontal="24dp" |
| 81 | app:foo="16dp" |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 82 | foo="bar"/>)"); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 83 | |
| 84 | XmlReferenceLinker linker; |
| 85 | ASSERT_TRUE(linker.Consume(context_.get(), doc.get())); |
| 86 | |
| 87 | XmlCompatVersioner::Rules rules; |
| 88 | const util::Range<ApiVersion> api_range{SDK_GINGERBREAD, SDK_O + 1}; |
| 89 | |
| 90 | XmlCompatVersioner versioner(&rules); |
| 91 | std::vector<std::unique_ptr<xml::XmlResource>> versioned_docs = |
| 92 | versioner.Process(context_.get(), doc.get(), api_range); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 93 | ASSERT_THAT(versioned_docs, SizeIs(2u)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 94 | |
| 95 | xml::Element* el; |
| 96 | |
| 97 | // Source XML file's sdkVersion == 0, so the first one must also have the same sdkVersion. |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 98 | EXPECT_THAT(versioned_docs[0]->file.config.sdkVersion, Eq(0u)); |
| 99 | el = versioned_docs[0]->root.get(); |
| 100 | ASSERT_THAT(el, NotNull()); |
| 101 | EXPECT_THAT(el->attributes, SizeIs(2u)); |
| 102 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"), IsNull()); |
| 103 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAuto, "foo"), NotNull()); |
| 104 | EXPECT_THAT(el->FindAttribute({}, "foo"), NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 105 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 106 | EXPECT_THAT(versioned_docs[1]->file.config.sdkVersion, Eq(SDK_LOLLIPOP_MR1)); |
| 107 | el = versioned_docs[1]->root.get(); |
| 108 | ASSERT_THAT(el, NotNull()); |
| 109 | EXPECT_THAT(el->attributes, SizeIs(3u)); |
| 110 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"), NotNull()); |
| 111 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAuto, "foo"), NotNull()); |
| 112 | EXPECT_THAT(el->FindAttribute({}, "foo"), NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 113 | } |
| 114 | |
| 115 | TEST_F(XmlCompatVersionerTest, SingleRule) { |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 116 | auto doc = test::BuildXmlDomForPackageName(context_.get(), R"( |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 117 | <View xmlns:android="http://schemas.android.com/apk/res/android" |
| 118 | xmlns:app="http://schemas.android.com/apk/res-auto" |
| 119 | android:paddingHorizontal="24dp" |
| 120 | app:foo="16dp" |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 121 | foo="bar"/>)"); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 122 | |
| 123 | XmlReferenceLinker linker; |
| 124 | ASSERT_TRUE(linker.Consume(context_.get(), doc.get())); |
| 125 | |
| 126 | XmlCompatVersioner::Rules rules; |
| 127 | rules[R::attr::paddingHorizontal] = |
| 128 | util::make_unique<DegradeToManyRule>(std::vector<ReplacementAttr>( |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 129 | {ReplacementAttr{"paddingLeft", R::attr::paddingLeft, Attribute(TYPE_DIMENSION)}, |
| 130 | ReplacementAttr{"paddingRight", R::attr::paddingRight, Attribute(TYPE_DIMENSION)}})); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 131 | |
| 132 | const util::Range<ApiVersion> api_range{SDK_GINGERBREAD, SDK_O + 1}; |
| 133 | |
| 134 | XmlCompatVersioner versioner(&rules); |
| 135 | std::vector<std::unique_ptr<xml::XmlResource>> versioned_docs = |
| 136 | versioner.Process(context_.get(), doc.get(), api_range); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 137 | ASSERT_THAT(versioned_docs, SizeIs(2u)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 138 | |
| 139 | xml::Element* el; |
| 140 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 141 | EXPECT_THAT(versioned_docs[0]->file.config.sdkVersion, Eq(0u)); |
| 142 | el = versioned_docs[0]->root.get(); |
| 143 | ASSERT_THAT(el, NotNull()); |
| 144 | EXPECT_THAT(el->attributes, SizeIs(4u)); |
| 145 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"), IsNull()); |
| 146 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAuto, "foo"), NotNull()); |
| 147 | EXPECT_THAT(el->FindAttribute({}, "foo"), NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 148 | |
| 149 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "paddingLeft"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 150 | ASSERT_THAT(attr, NotNull()); |
| 151 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 152 | ASSERT_TRUE(attr->compiled_attribute); |
| 153 | |
| 154 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingRight"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 155 | ASSERT_THAT(attr, NotNull()); |
| 156 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 157 | ASSERT_TRUE(attr->compiled_attribute); |
| 158 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 159 | EXPECT_THAT(versioned_docs[1]->file.config.sdkVersion, Eq(SDK_LOLLIPOP_MR1)); |
| 160 | el = versioned_docs[1]->root.get(); |
| 161 | ASSERT_THAT(el, NotNull()); |
| 162 | EXPECT_THAT(el->attributes, SizeIs(5u)); |
| 163 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"), NotNull()); |
| 164 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAuto, "foo"), NotNull()); |
| 165 | EXPECT_THAT(el->FindAttribute({}, "foo"), NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 166 | |
| 167 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingLeft"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 168 | ASSERT_THAT(attr, NotNull()); |
| 169 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 170 | ASSERT_TRUE(attr->compiled_attribute); |
| 171 | |
| 172 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingRight"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 173 | ASSERT_THAT(attr, NotNull()); |
| 174 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 175 | ASSERT_TRUE(attr->compiled_attribute); |
| 176 | } |
| 177 | |
| 178 | TEST_F(XmlCompatVersionerTest, ChainedRule) { |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 179 | auto doc = test::BuildXmlDomForPackageName(context_.get(), R"( |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 180 | <View xmlns:android="http://schemas.android.com/apk/res/android" |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 181 | android:paddingHorizontal="24dp" />)"); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 182 | |
| 183 | XmlReferenceLinker linker; |
| 184 | ASSERT_TRUE(linker.Consume(context_.get(), doc.get())); |
| 185 | |
| 186 | XmlCompatVersioner::Rules rules; |
| 187 | rules[R::attr::progressBarPadding] = |
| 188 | util::make_unique<DegradeToManyRule>(std::vector<ReplacementAttr>( |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 189 | {ReplacementAttr{"paddingLeft", R::attr::paddingLeft, Attribute(TYPE_DIMENSION)}, |
| 190 | ReplacementAttr{"paddingRight", R::attr::paddingRight, Attribute(TYPE_DIMENSION)}})); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 191 | rules[R::attr::paddingHorizontal] = |
| 192 | util::make_unique<DegradeToManyRule>(std::vector<ReplacementAttr>({ReplacementAttr{ |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 193 | "progressBarPadding", R::attr::progressBarPadding, Attribute(TYPE_DIMENSION)}})); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 194 | |
| 195 | const util::Range<ApiVersion> api_range{SDK_GINGERBREAD, SDK_O + 1}; |
| 196 | |
| 197 | XmlCompatVersioner versioner(&rules); |
| 198 | std::vector<std::unique_ptr<xml::XmlResource>> versioned_docs = |
| 199 | versioner.Process(context_.get(), doc.get(), api_range); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 200 | ASSERT_THAT(versioned_docs, SizeIs(3u)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 201 | |
| 202 | xml::Element* el; |
| 203 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 204 | EXPECT_THAT(versioned_docs[0]->file.config.sdkVersion, Eq(0u)); |
| 205 | el = versioned_docs[0]->root.get(); |
| 206 | ASSERT_THAT(el, NotNull()); |
| 207 | EXPECT_THAT(el->attributes, SizeIs(2u)); |
| 208 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"), IsNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 209 | |
| 210 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "paddingLeft"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 211 | ASSERT_THAT(attr, NotNull()); |
| 212 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 213 | ASSERT_TRUE(attr->compiled_attribute); |
| 214 | |
| 215 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingRight"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 216 | ASSERT_THAT(attr, NotNull()); |
| 217 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 218 | ASSERT_TRUE(attr->compiled_attribute); |
| 219 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 220 | EXPECT_THAT(versioned_docs[1]->file.config.sdkVersion, Eq(SDK_HONEYCOMB)); |
| 221 | el = versioned_docs[1]->root.get(); |
| 222 | ASSERT_THAT(el, NotNull()); |
| 223 | EXPECT_THAT(el->attributes, SizeIs(1u)); |
| 224 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"), IsNull()); |
| 225 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingLeft"), IsNull()); |
| 226 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingRight"), IsNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 227 | |
| 228 | attr = el->FindAttribute(xml::kSchemaAndroid, "progressBarPadding"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 229 | ASSERT_THAT(attr, NotNull()); |
| 230 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 231 | ASSERT_TRUE(attr->compiled_attribute); |
| 232 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 233 | EXPECT_THAT(versioned_docs[2]->file.config.sdkVersion, Eq(SDK_LOLLIPOP_MR1)); |
| 234 | el = versioned_docs[2]->root.get(); |
| 235 | ASSERT_THAT(el, NotNull()); |
| 236 | EXPECT_THAT(el->attributes, SizeIs(2u)); |
| 237 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingLeft"), IsNull()); |
| 238 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingRight"), IsNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 239 | |
| 240 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 241 | ASSERT_THAT(attr, NotNull()); |
| 242 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 243 | ASSERT_TRUE(attr->compiled_attribute); |
| 244 | |
| 245 | attr = el->FindAttribute(xml::kSchemaAndroid, "progressBarPadding"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 246 | ASSERT_THAT(attr, NotNull()); |
| 247 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 248 | ASSERT_TRUE(attr->compiled_attribute); |
| 249 | } |
| 250 | |
| 251 | TEST_F(XmlCompatVersionerTest, DegradeRuleOverridesExistingAttribute) { |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 252 | auto doc = test::BuildXmlDomForPackageName(context_.get(), R"( |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 253 | <View xmlns:android="http://schemas.android.com/apk/res/android" |
| 254 | android:paddingHorizontal="24dp" |
| 255 | android:paddingLeft="16dp" |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 256 | android:paddingRight="16dp"/>)"); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 257 | |
| 258 | XmlReferenceLinker linker; |
| 259 | ASSERT_TRUE(linker.Consume(context_.get(), doc.get())); |
| 260 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 261 | Item* padding_horizontal_value = |
| 262 | doc->root->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal")->compiled_value.get(); |
| 263 | ASSERT_THAT(padding_horizontal_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 264 | |
| 265 | XmlCompatVersioner::Rules rules; |
| 266 | rules[R::attr::paddingHorizontal] = |
| 267 | util::make_unique<DegradeToManyRule>(std::vector<ReplacementAttr>( |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 268 | {ReplacementAttr{"paddingLeft", R::attr::paddingLeft, Attribute(TYPE_DIMENSION)}, |
| 269 | ReplacementAttr{"paddingRight", R::attr::paddingRight, Attribute(TYPE_DIMENSION)}})); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 270 | |
| 271 | const util::Range<ApiVersion> api_range{SDK_GINGERBREAD, SDK_O + 1}; |
| 272 | |
| 273 | XmlCompatVersioner versioner(&rules); |
| 274 | std::vector<std::unique_ptr<xml::XmlResource>> versioned_docs = |
| 275 | versioner.Process(context_.get(), doc.get(), api_range); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 276 | ASSERT_THAT(versioned_docs, SizeIs(2u)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 277 | |
| 278 | xml::Element* el; |
| 279 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 280 | EXPECT_THAT(versioned_docs[0]->file.config.sdkVersion, Eq(0u)); |
| 281 | el = versioned_docs[0]->root.get(); |
| 282 | ASSERT_THAT(el, NotNull()); |
| 283 | EXPECT_THAT(el->attributes, SizeIs(2u)); |
| 284 | EXPECT_THAT(el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"), IsNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 285 | |
| 286 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "paddingLeft"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 287 | ASSERT_THAT(attr, NotNull()); |
| 288 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 289 | ASSERT_TRUE(attr->compiled_attribute); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 290 | ASSERT_THAT(*attr->compiled_value, ValueEq(padding_horizontal_value)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 291 | |
| 292 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingRight"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 293 | ASSERT_THAT(attr, NotNull()); |
| 294 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 295 | ASSERT_TRUE(attr->compiled_attribute); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 296 | ASSERT_THAT(*attr->compiled_value, ValueEq(padding_horizontal_value)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 297 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 298 | EXPECT_THAT(versioned_docs[1]->file.config.sdkVersion, Eq(SDK_LOLLIPOP_MR1)); |
| 299 | el = versioned_docs[1]->root.get(); |
| 300 | ASSERT_THAT(el, NotNull()); |
| 301 | EXPECT_THAT(el->attributes, SizeIs(3u)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 302 | |
| 303 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingHorizontal"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 304 | ASSERT_THAT(attr, NotNull()); |
| 305 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 306 | ASSERT_TRUE(attr->compiled_attribute); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 307 | ASSERT_THAT(*attr->compiled_value, ValueEq(padding_horizontal_value)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 308 | |
| 309 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingLeft"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 310 | ASSERT_THAT(attr, NotNull()); |
| 311 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 312 | ASSERT_TRUE(attr->compiled_attribute); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 313 | ASSERT_THAT(*attr->compiled_value, ValueEq(padding_horizontal_value)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 314 | |
| 315 | attr = el->FindAttribute(xml::kSchemaAndroid, "paddingRight"); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 316 | ASSERT_THAT(attr, NotNull()); |
| 317 | ASSERT_THAT(attr->compiled_value, NotNull()); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 318 | ASSERT_TRUE(attr->compiled_attribute); |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 319 | ASSERT_THAT(*attr->compiled_value, ValueEq(padding_horizontal_value)); |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 320 | } |
| 321 | |
| 322 | } // namespace aapt |