Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "link/ManifestFixer.h" |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 18 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 19 | #include "test/Test.h" |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 20 | |
Adam Lesinski | 87f1e0f | 2017-06-27 16:21:58 -0700 | [diff] [blame] | 21 | using ::android::StringPiece; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 22 | using ::testing::Eq; |
| 23 | using ::testing::Gt; |
| 24 | using ::testing::IsNull; |
| 25 | using ::testing::Ne; |
Adam Lesinski | 87f1e0f | 2017-06-27 16:21:58 -0700 | [diff] [blame] | 26 | using ::testing::NotNull; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 27 | using ::testing::StrEq; |
Adam Lesinski | d5083f6 | 2017-01-16 15:07:21 -0800 | [diff] [blame] | 28 | |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 29 | namespace aapt { |
| 30 | |
| 31 | struct ManifestFixerTest : public ::testing::Test { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 32 | std::unique_ptr<IAaptContext> mContext; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 33 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 34 | void SetUp() override { |
| 35 | mContext = |
| 36 | test::ContextBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 37 | .SetCompilationPackage("android") |
| 38 | .SetPackageId(0x01) |
| 39 | .SetNameManglerPolicy(NameManglerPolicy{"android"}) |
| 40 | .AddSymbolSource( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 41 | test::StaticSymbolSourceBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 42 | .AddSymbol( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 43 | "android:attr/package", ResourceId(0x01010000), |
| 44 | test::AttributeBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 45 | .SetTypeMask(android::ResTable_map::TYPE_STRING) |
| 46 | .Build()) |
| 47 | .AddSymbol( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 48 | "android:attr/minSdkVersion", ResourceId(0x01010001), |
| 49 | test::AttributeBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 50 | .SetTypeMask(android::ResTable_map::TYPE_STRING | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 51 | android::ResTable_map::TYPE_INTEGER) |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 52 | .Build()) |
| 53 | .AddSymbol( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 54 | "android:attr/targetSdkVersion", ResourceId(0x01010002), |
| 55 | test::AttributeBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 56 | .SetTypeMask(android::ResTable_map::TYPE_STRING | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 57 | android::ResTable_map::TYPE_INTEGER) |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 58 | .Build()) |
| 59 | .AddSymbol("android:string/str", ResourceId(0x01060000)) |
| 60 | .Build()) |
| 61 | .Build(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 62 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 63 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 64 | std::unique_ptr<xml::XmlResource> Verify(const StringPiece& str) { |
| 65 | return VerifyWithOptions(str, {}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 66 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 67 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 68 | std::unique_ptr<xml::XmlResource> VerifyWithOptions( |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 69 | const StringPiece& str, const ManifestFixerOptions& options) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 70 | std::unique_ptr<xml::XmlResource> doc = test::BuildXmlDom(str); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 71 | ManifestFixer fixer(options); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 72 | if (fixer.Consume(mContext.get(), doc.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 73 | return doc; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 74 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 75 | return {}; |
| 76 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 77 | }; |
| 78 | |
| 79 | TEST_F(ManifestFixerTest, EnsureManifestIsRootTag) { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 80 | EXPECT_THAT(Verify("<other-tag />"), IsNull()); |
| 81 | EXPECT_THAT(Verify("<ns:manifest xmlns:ns=\"com\" />"), IsNull()); |
| 82 | EXPECT_THAT(Verify("<manifest package=\"android\"></manifest>"), NotNull()); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 83 | } |
| 84 | |
| 85 | TEST_F(ManifestFixerTest, EnsureManifestHasPackage) { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 86 | EXPECT_THAT(Verify("<manifest package=\"android\" />"), NotNull()); |
| 87 | EXPECT_THAT(Verify("<manifest package=\"com.android\" />"), NotNull()); |
| 88 | EXPECT_THAT(Verify("<manifest package=\"com.android.google\" />"), NotNull()); |
| 89 | EXPECT_THAT(Verify("<manifest package=\"com.android.google.Class$1\" />"), IsNull()); |
| 90 | EXPECT_THAT(Verify("<manifest xmlns:android=\"http://schemas.android.com/apk/res/android\" " |
| 91 | "android:package=\"com.android\" />"), |
| 92 | IsNull()); |
| 93 | EXPECT_THAT(Verify("<manifest package=\"@string/str\" />"), IsNull()); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 94 | } |
| 95 | |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 96 | TEST_F(ManifestFixerTest, AllowMetaData) { |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 97 | auto doc = Verify(R"EOF( |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 98 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 99 | package="android"> |
| 100 | <meta-data /> |
| 101 | <application> |
| 102 | <meta-data /> |
| 103 | <activity android:name=".Hi"><meta-data /></activity> |
| 104 | <activity-alias android:name=".Ho"><meta-data /></activity-alias> |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 105 | <receiver android:name=".OffTo"><meta-data /></receiver> |
| 106 | <provider android:name=".Work"><meta-data /></provider> |
| 107 | <service android:name=".We"><meta-data /></service> |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 108 | </application> |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 109 | <instrumentation android:name=".Go"><meta-data /></instrumentation> |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 110 | </manifest>)EOF"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 111 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 112 | } |
| 113 | |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 114 | TEST_F(ManifestFixerTest, UseDefaultSdkVersionsIfNonePresent) { |
Izabela Orlowska | ad9e132 | 2017-12-19 16:22:42 +0000 | [diff] [blame] | 115 | ManifestFixerOptions options; |
| 116 | options.min_sdk_version_default = std::string("8"); |
| 117 | options.target_sdk_version_default = std::string("22"); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 118 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 119 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 120 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 121 | package="android"> |
| 122 | <uses-sdk android:minSdkVersion="7" android:targetSdkVersion="21" /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 123 | </manifest>)EOF", |
| 124 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 125 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 126 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 127 | xml::Element* el; |
| 128 | xml::Attribute* attr; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 129 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 130 | el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 131 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 132 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 133 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 134 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 135 | ASSERT_THAT(attr, NotNull()); |
| 136 | EXPECT_THAT(attr->value, StrEq("7")); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 137 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 138 | ASSERT_THAT(attr, NotNull()); |
| 139 | EXPECT_THAT(attr->value, StrEq("21")); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 140 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 141 | doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 142 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 143 | package="android"> |
| 144 | <uses-sdk android:targetSdkVersion="21" /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 145 | </manifest>)EOF", |
| 146 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 147 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 148 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 149 | el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 150 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 151 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 152 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 153 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 154 | ASSERT_THAT(attr, NotNull()); |
| 155 | EXPECT_THAT(attr->value, StrEq("8")); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 156 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 157 | ASSERT_THAT(attr, NotNull()); |
| 158 | EXPECT_THAT(attr->value, StrEq("21")); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 159 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 160 | doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 161 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 162 | package="android"> |
| 163 | <uses-sdk /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 164 | </manifest>)EOF", |
| 165 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 166 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 167 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 168 | el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 169 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 170 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 171 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 172 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 173 | ASSERT_THAT(attr, NotNull()); |
| 174 | EXPECT_THAT(attr->value, StrEq("8")); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 175 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 176 | ASSERT_THAT(attr, NotNull()); |
| 177 | EXPECT_THAT(attr->value, StrEq("22")); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 178 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 179 | doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 180 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 181 | package="android" />)EOF", |
| 182 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 183 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 184 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 185 | el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 186 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 187 | el = el->FindChild({}, "uses-sdk"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 188 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 189 | attr = el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 190 | ASSERT_THAT(attr, NotNull()); |
| 191 | EXPECT_THAT(attr->value, StrEq("8")); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 192 | attr = el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 193 | ASSERT_THAT(attr, NotNull()); |
| 194 | EXPECT_THAT(attr->value, StrEq("22")); |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 195 | } |
| 196 | |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 197 | TEST_F(ManifestFixerTest, UsesSdkMustComeBeforeApplication) { |
Izabela Orlowska | ad9e132 | 2017-12-19 16:22:42 +0000 | [diff] [blame] | 198 | ManifestFixerOptions options; |
| 199 | options.min_sdk_version_default = std::string("8"); |
| 200 | options.target_sdk_version_default = std::string("22"); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 201 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
| 202 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 203 | package="android"> |
| 204 | <application android:name=".MainApplication" /> |
| 205 | </manifest>)EOF", |
| 206 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 207 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 208 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 209 | xml::Element* manifest_el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 210 | ASSERT_THAT(manifest_el, NotNull()); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 211 | ASSERT_EQ("manifest", manifest_el->name); |
| 212 | |
| 213 | xml::Element* application_el = manifest_el->FindChild("", "application"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 214 | ASSERT_THAT(application_el, NotNull()); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 215 | |
| 216 | xml::Element* uses_sdk_el = manifest_el->FindChild("", "uses-sdk"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 217 | ASSERT_THAT(uses_sdk_el, NotNull()); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 218 | |
| 219 | // Check that the uses_sdk_el comes before application_el in the children |
| 220 | // vector. |
| 221 | // Since there are no namespaces here, these children are direct descendants |
| 222 | // of manifest. |
| 223 | auto uses_sdk_iter = |
| 224 | std::find_if(manifest_el->children.begin(), manifest_el->children.end(), |
| 225 | [&](const std::unique_ptr<xml::Node>& child) { |
| 226 | return child.get() == uses_sdk_el; |
| 227 | }); |
| 228 | |
| 229 | auto application_iter = |
| 230 | std::find_if(manifest_el->children.begin(), manifest_el->children.end(), |
| 231 | [&](const std::unique_ptr<xml::Node>& child) { |
| 232 | return child.get() == application_el; |
| 233 | }); |
| 234 | |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 235 | ASSERT_THAT(uses_sdk_iter, Ne(manifest_el->children.end())); |
| 236 | ASSERT_THAT(application_iter, Ne(manifest_el->children.end())); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 237 | |
| 238 | // The distance should be positive, meaning uses_sdk_iter comes before |
| 239 | // application_iter. |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 240 | EXPECT_THAT(std::distance(uses_sdk_iter, application_iter), Gt(0)); |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 241 | } |
| 242 | |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 243 | TEST_F(ManifestFixerTest, RenameManifestPackageAndFullyQualifyClasses) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 244 | ManifestFixerOptions options; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 245 | options.rename_manifest_package = std::string("com.android"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 246 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 247 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 248 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 249 | package="android"> |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 250 | <uses-split android:name="feature_a" /> |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 251 | <application android:name=".MainApplication" text="hello"> |
| 252 | <activity android:name=".activity.Start" /> |
| 253 | <receiver android:name="com.google.android.Receiver" /> |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 254 | </application> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 255 | </manifest>)EOF", |
| 256 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 257 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 258 | |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 259 | xml::Element* manifest_el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 260 | ASSERT_THAT(manifest_el, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 261 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 262 | xml::Attribute* attr = nullptr; |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 263 | |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 264 | attr = manifest_el->FindAttribute({}, "package"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 265 | ASSERT_THAT(attr, NotNull()); |
| 266 | EXPECT_THAT(attr->value, StrEq("com.android")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 267 | |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 268 | xml::Element* uses_split_el = manifest_el->FindChild({}, "uses-split"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 269 | ASSERT_THAT(uses_split_el, NotNull()); |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 270 | attr = uses_split_el->FindAttribute(xml::kSchemaAndroid, "name"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 271 | ASSERT_THAT(attr, NotNull()); |
| 272 | // This should NOT have been affected. |
| 273 | EXPECT_THAT(attr->value, StrEq("feature_a")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 274 | |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 275 | xml::Element* application_el = manifest_el->FindChild({}, "application"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 276 | ASSERT_THAT(application_el, NotNull()); |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 277 | |
| 278 | attr = application_el->FindAttribute(xml::kSchemaAndroid, "name"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 279 | ASSERT_THAT(attr, NotNull()); |
| 280 | EXPECT_THAT(attr->value, StrEq("android.MainApplication")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 281 | |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 282 | attr = application_el->FindAttribute({}, "text"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 283 | ASSERT_THAT(attr, NotNull()); |
| 284 | EXPECT_THAT(attr->value, StrEq("hello")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 285 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 286 | xml::Element* el; |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 287 | el = application_el->FindChild({}, "activity"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 288 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 289 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 290 | attr = el->FindAttribute(xml::kSchemaAndroid, "name"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 291 | ASSERT_THAT(el, NotNull()); |
| 292 | EXPECT_THAT(attr->value, StrEq("android.activity.Start")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 293 | |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 294 | el = application_el->FindChild({}, "receiver"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 295 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 296 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 297 | attr = el->FindAttribute(xml::kSchemaAndroid, "name"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 298 | ASSERT_THAT(el, NotNull()); |
| 299 | EXPECT_THAT(attr->value, StrEq("com.google.android.Receiver")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 300 | } |
| 301 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 302 | TEST_F(ManifestFixerTest, |
| 303 | RenameManifestInstrumentationPackageAndFullyQualifyTarget) { |
| 304 | ManifestFixerOptions options; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 305 | options.rename_instrumentation_target_package = std::string("com.android"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 306 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 307 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 308 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 309 | package="android"> |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 310 | <instrumentation android:name=".TestRunner" android:targetPackage="android" /> |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 311 | </manifest>)EOF", |
| 312 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 313 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 314 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 315 | xml::Element* manifest_el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 316 | ASSERT_THAT(manifest_el, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 317 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 318 | xml::Element* instrumentation_el = |
| 319 | manifest_el->FindChild({}, "instrumentation"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 320 | ASSERT_THAT(instrumentation_el, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 321 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 322 | xml::Attribute* attr = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 323 | instrumentation_el->FindAttribute(xml::kSchemaAndroid, "targetPackage"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 324 | ASSERT_THAT(attr, NotNull()); |
| 325 | EXPECT_THAT(attr->value, StrEq("com.android")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 326 | } |
| 327 | |
| 328 | TEST_F(ManifestFixerTest, UseDefaultVersionNameAndCode) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 329 | ManifestFixerOptions options; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 330 | options.version_name_default = std::string("Beta"); |
| 331 | options.version_code_default = std::string("0x10000000"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 332 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 333 | std::unique_ptr<xml::XmlResource> doc = VerifyWithOptions(R"EOF( |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 334 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 335 | package="android" />)EOF", |
| 336 | options); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 337 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 338 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 339 | xml::Element* manifest_el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 340 | ASSERT_THAT(manifest_el, NotNull()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 341 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 342 | xml::Attribute* attr = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 343 | manifest_el->FindAttribute(xml::kSchemaAndroid, "versionName"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 344 | ASSERT_THAT(attr, NotNull()); |
| 345 | EXPECT_THAT(attr->value, StrEq("Beta")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 346 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 347 | attr = manifest_el->FindAttribute(xml::kSchemaAndroid, "versionCode"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 348 | ASSERT_THAT(attr, NotNull()); |
| 349 | EXPECT_THAT(attr->value, StrEq("0x10000000")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 350 | } |
| 351 | |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 352 | TEST_F(ManifestFixerTest, EnsureManifestAttributesAreTyped) { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 353 | EXPECT_THAT(Verify("<manifest package=\"android\" coreApp=\"hello\" />"), IsNull()); |
| 354 | EXPECT_THAT(Verify("<manifest package=\"android\" coreApp=\"1dp\" />"), IsNull()); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 355 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 356 | std::unique_ptr<xml::XmlResource> doc = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 357 | Verify("<manifest package=\"android\" coreApp=\"true\" />"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 358 | ASSERT_THAT(doc, NotNull()); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 359 | |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 360 | xml::Element* el = doc->root.get(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 361 | ASSERT_THAT(el, NotNull()); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 362 | |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 363 | EXPECT_THAT(el->name, StrEq("manifest")); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 364 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 365 | xml::Attribute* attr = el->FindAttribute("", "coreApp"); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 366 | ASSERT_THAT(attr, NotNull()); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 367 | |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 368 | EXPECT_THAT(attr->compiled_value, NotNull()); |
| 369 | EXPECT_THAT(ValueCast<BinaryPrimitive>(attr->compiled_value.get()), NotNull()); |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 370 | } |
| 371 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 372 | TEST_F(ManifestFixerTest, UsesFeatureMustHaveNameOrGlEsVersion) { |
| 373 | std::string input = R"EOF( |
| 374 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 375 | package="android"> |
| 376 | <uses-feature android:name="feature" /> |
| 377 | <uses-feature android:glEsVersion="1" /> |
| 378 | <feature-group /> |
| 379 | <feature-group> |
| 380 | <uses-feature android:name="feature_in_group" /> |
| 381 | <uses-feature android:glEsVersion="2" /> |
| 382 | </feature-group> |
| 383 | </manifest>)EOF"; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 384 | EXPECT_THAT(Verify(input), NotNull()); |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 385 | |
| 386 | input = R"EOF( |
| 387 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 388 | package="android"> |
| 389 | <uses-feature android:name="feature" android:glEsVersion="1" /> |
| 390 | </manifest>)EOF"; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 391 | EXPECT_THAT(Verify(input), IsNull()); |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 392 | |
| 393 | input = R"EOF( |
| 394 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 395 | package="android"> |
| 396 | <uses-feature /> |
| 397 | </manifest>)EOF"; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 398 | EXPECT_THAT(Verify(input), IsNull()); |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 399 | |
| 400 | input = R"EOF( |
| 401 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 402 | package="android"> |
| 403 | <feature-group> |
| 404 | <uses-feature android:name="feature" android:glEsVersion="1" /> |
| 405 | </feature-group> |
| 406 | </manifest>)EOF"; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 407 | EXPECT_THAT(Verify(input), IsNull()); |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 408 | |
| 409 | input = R"EOF( |
| 410 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 411 | package="android"> |
| 412 | <feature-group> |
| 413 | <uses-feature /> |
| 414 | </feature-group> |
| 415 | </manifest>)EOF"; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 416 | EXPECT_THAT(Verify(input), IsNull()); |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 417 | } |
| 418 | |
Adam Lesinski | 63699b1 | 2017-05-08 18:36:33 -0700 | [diff] [blame] | 419 | TEST_F(ManifestFixerTest, IgnoreNamespacedElements) { |
| 420 | std::string input = R"EOF( |
| 421 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 422 | package="android"> |
| 423 | <special:tag whoo="true" xmlns:special="http://google.com" /> |
| 424 | </manifest>)EOF"; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 425 | EXPECT_THAT(Verify(input), NotNull()); |
Adam Lesinski | 63699b1 | 2017-05-08 18:36:33 -0700 | [diff] [blame] | 426 | } |
| 427 | |
| 428 | TEST_F(ManifestFixerTest, DoNotIgnoreNonNamespacedElements) { |
| 429 | std::string input = R"EOF( |
| 430 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 431 | package="android"> |
| 432 | <tag whoo="true" /> |
| 433 | </manifest>)EOF"; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 434 | EXPECT_THAT(Verify(input), IsNull()); |
Adam Lesinski | 63699b1 | 2017-05-08 18:36:33 -0700 | [diff] [blame] | 435 | } |
| 436 | |
Adam Lesinski | 87f1e0f | 2017-06-27 16:21:58 -0700 | [diff] [blame] | 437 | TEST_F(ManifestFixerTest, SupportKeySets) { |
| 438 | std::string input = R"( |
| 439 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 440 | package="android"> |
| 441 | <key-sets> |
| 442 | <key-set android:name="old-set"> |
| 443 | <public-key android:name="old-key" android:value="some+old+key" /> |
| 444 | </key-set> |
| 445 | <key-set android:name="new-set"> |
| 446 | <public-key android:name="new-key" android:value="some+new+key" /> |
| 447 | </key-set> |
| 448 | <upgrade-key-set android:name="old-set" /> |
| 449 | <upgrade-key-set android:name="new-set" /> |
| 450 | </key-sets> |
| 451 | </manifest>)"; |
| 452 | EXPECT_THAT(Verify(input), NotNull()); |
| 453 | } |
| 454 | |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 455 | TEST_F(ManifestFixerTest, InsertCompileSdkVersions) { |
| 456 | std::string input = R"( |
| 457 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="android" />)"; |
| 458 | ManifestFixerOptions options; |
| 459 | options.compile_sdk_version = {"28"}; |
| 460 | options.compile_sdk_version_codename = {"P"}; |
| 461 | |
| 462 | std::unique_ptr<xml::XmlResource> manifest = VerifyWithOptions(input, options); |
| 463 | ASSERT_THAT(manifest, NotNull()); |
| 464 | |
| 465 | xml::Attribute* attr = manifest->root->FindAttribute(xml::kSchemaAndroid, "compileSdkVersion"); |
| 466 | ASSERT_THAT(attr, NotNull()); |
| 467 | EXPECT_THAT(attr->value, StrEq("28")); |
| 468 | |
| 469 | attr = manifest->root->FindAttribute(xml::kSchemaAndroid, "compileSdkVersionCodename"); |
| 470 | ASSERT_THAT(attr, NotNull()); |
| 471 | EXPECT_THAT(attr->value, StrEq("P")); |
| 472 | } |
| 473 | |
Izabela Orlowska | ad9e132 | 2017-12-19 16:22:42 +0000 | [diff] [blame] | 474 | TEST_F(ManifestFixerTest, UnexpectedElementsInManifest) { |
| 475 | std::string input = R"( |
| 476 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 477 | package="android"> |
| 478 | <beep/> |
| 479 | </manifest>)"; |
| 480 | ManifestFixerOptions options; |
| 481 | options.warn_validation = true; |
| 482 | |
| 483 | // Unexpected element should result in a warning if the flag is set to 'true'. |
| 484 | std::unique_ptr<xml::XmlResource> manifest = VerifyWithOptions(input, options); |
| 485 | ASSERT_THAT(manifest, NotNull()); |
| 486 | |
| 487 | // Unexpected element should result in an error if the flag is set to 'false'. |
| 488 | options.warn_validation = false; |
| 489 | manifest = VerifyWithOptions(input, options); |
| 490 | ASSERT_THAT(manifest, IsNull()); |
| 491 | |
| 492 | // By default the flag should be set to 'false'. |
| 493 | manifest = Verify(input); |
| 494 | ASSERT_THAT(manifest, IsNull()); |
| 495 | } |
| 496 | |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame^] | 497 | |
| 498 | TEST_F(ManifestFixerTest, UsesLibraryMustHaveNonEmptyName) { |
| 499 | std::string input = R"( |
| 500 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 501 | package="android"> |
| 502 | <application> |
| 503 | <uses-library android:name="" /> |
| 504 | </application> |
| 505 | </manifest>)"; |
| 506 | EXPECT_THAT(Verify(input), IsNull()); |
| 507 | |
| 508 | input = R"( |
| 509 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 510 | package="android"> |
| 511 | <application> |
| 512 | <uses-library /> |
| 513 | </application> |
| 514 | </manifest>)"; |
| 515 | EXPECT_THAT(Verify(input), IsNull()); |
| 516 | |
| 517 | input = R"( |
| 518 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 519 | package="android"> |
| 520 | <application> |
| 521 | <uses-library android:name="blahhh" /> |
| 522 | </application> |
| 523 | </manifest>)"; |
| 524 | EXPECT_THAT(Verify(input), NotNull()); |
| 525 | } |
| 526 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 527 | } // namespace aapt |