Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include <stdlib.h> |
| 18 | #include <string.h> |
| 19 | |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 20 | #include <android-base/logging.h> |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 21 | #include <gtest/gtest.h> |
| 22 | |
Jeff Sharkey | f3e30b9 | 2016-12-09 17:06:57 -0700 | [diff] [blame] | 23 | #include "InstalldNativeService.h" |
| 24 | #include "globals.h" |
| 25 | #include "utils.h" |
Jeff Sharkey | 1980380 | 2015-04-07 12:44:51 -0700 | [diff] [blame] | 26 | |
| 27 | #undef LOG_TAG |
| 28 | #define LOG_TAG "utils_test" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 29 | |
| 30 | #define TEST_DATA_DIR "/data/" |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 31 | #define TEST_ROOT_DIR "/system/" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 32 | #define TEST_APP_DIR "/data/app/" |
| 33 | #define TEST_APP_PRIVATE_DIR "/data/app-private/" |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 34 | #define TEST_APP_EPHEMERAL_DIR "/data/app-ephemeral/" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 35 | #define TEST_ASEC_DIR "/mnt/asec/" |
Jeff Sharkey | 1980380 | 2015-04-07 12:44:51 -0700 | [diff] [blame] | 36 | #define TEST_EXPAND_DIR "/mnt/expand/" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 37 | |
| 38 | #define TEST_SYSTEM_DIR1 "/system/app/" |
| 39 | #define TEST_SYSTEM_DIR2 "/vendor/app/" |
| 40 | |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 41 | #define TEST_PROFILE_DIR "/data/misc/profiles" |
| 42 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 43 | namespace android { |
Andreas Gampe | 02d0de5 | 2015-11-11 20:43:16 -0800 | [diff] [blame] | 44 | namespace installd { |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 45 | |
| 46 | class UtilsTest : public testing::Test { |
| 47 | protected: |
| 48 | virtual void SetUp() { |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 49 | setenv("ANDROID_LOG_TAGS", "*:v", 1); |
| 50 | android::base::InitLogging(nullptr); |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 51 | |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 52 | init_globals_from_data_and_root(TEST_DATA_DIR, TEST_ROOT_DIR); |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 53 | } |
| 54 | |
| 55 | virtual void TearDown() { |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 56 | } |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 57 | |
| 58 | std::string create_too_long_path(const std::string& seed) { |
| 59 | std::string result = seed; |
| 60 | for (size_t i = seed.size(); i < PKG_PATH_MAX; i++) { |
| 61 | result += "a"; |
| 62 | } |
| 63 | return result; |
| 64 | } |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 65 | }; |
| 66 | |
| 67 | TEST_F(UtilsTest, IsValidApkPath_BadPrefix) { |
| 68 | // Bad prefixes directories |
| 69 | const char *badprefix1 = "/etc/passwd"; |
| 70 | EXPECT_EQ(-1, validate_apk_path(badprefix1)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 71 | << badprefix1 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 72 | |
| 73 | const char *badprefix2 = "../.." TEST_APP_DIR "../../../blah"; |
| 74 | EXPECT_EQ(-1, validate_apk_path(badprefix2)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 75 | << badprefix2 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 76 | |
| 77 | const char *badprefix3 = "init.rc"; |
| 78 | EXPECT_EQ(-1, validate_apk_path(badprefix3)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 79 | << badprefix3 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 80 | |
| 81 | const char *badprefix4 = "/init.rc"; |
| 82 | EXPECT_EQ(-1, validate_apk_path(badprefix4)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 83 | << badprefix4 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 84 | } |
| 85 | |
| 86 | TEST_F(UtilsTest, IsValidApkPath_Internal) { |
| 87 | // Internal directories |
| 88 | const char *internal1 = TEST_APP_DIR "example.apk"; |
| 89 | EXPECT_EQ(0, validate_apk_path(internal1)) |
| 90 | << internal1 << " should be allowed as a valid path"; |
| 91 | |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 92 | // b/16888084 |
| 93 | const char *path2 = TEST_APP_DIR "example.com/example.apk"; |
| 94 | EXPECT_EQ(0, validate_apk_path(path2)) |
| 95 | << path2 << " should be allowed as a valid path"; |
| 96 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 97 | const char *badint1 = TEST_APP_DIR "../example.apk"; |
| 98 | EXPECT_EQ(-1, validate_apk_path(badint1)) |
| 99 | << badint1 << " should be rejected as a invalid path"; |
| 100 | |
| 101 | const char *badint2 = TEST_APP_DIR "/../example.apk"; |
| 102 | EXPECT_EQ(-1, validate_apk_path(badint2)) |
| 103 | << badint2 << " should be rejected as a invalid path"; |
| 104 | |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 105 | // Only one subdir should be allowed. |
| 106 | const char *bad_path3 = TEST_APP_DIR "example.com/subdir/pkg.apk"; |
| 107 | EXPECT_EQ(-1, validate_apk_path(bad_path3)) |
| 108 | << bad_path3 << " should be rejected as a invalid path"; |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 109 | |
| 110 | const char *bad_path4 = TEST_APP_DIR "example.com/subdir/../pkg.apk"; |
| 111 | EXPECT_EQ(-1, validate_apk_path(bad_path4)) |
| 112 | << bad_path4 << " should be rejected as a invalid path"; |
| 113 | |
| 114 | const char *bad_path5 = TEST_APP_DIR "example.com1/../example.com2/pkg.apk"; |
| 115 | EXPECT_EQ(-1, validate_apk_path(bad_path5)) |
| 116 | << bad_path5 << " should be rejected as a invalid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 117 | } |
| 118 | |
| 119 | TEST_F(UtilsTest, IsValidApkPath_Private) { |
| 120 | // Internal directories |
| 121 | const char *private1 = TEST_APP_PRIVATE_DIR "example.apk"; |
| 122 | EXPECT_EQ(0, validate_apk_path(private1)) |
| 123 | << private1 << " should be allowed as a valid path"; |
| 124 | |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 125 | // b/16888084 |
| 126 | const char *path2 = TEST_APP_DIR "example.com/example.apk"; |
| 127 | EXPECT_EQ(0, validate_apk_path(path2)) |
| 128 | << path2 << " should be allowed as a valid path"; |
| 129 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 130 | const char *badpriv1 = TEST_APP_PRIVATE_DIR "../example.apk"; |
| 131 | EXPECT_EQ(-1, validate_apk_path(badpriv1)) |
| 132 | << badpriv1 << " should be rejected as a invalid path"; |
| 133 | |
| 134 | const char *badpriv2 = TEST_APP_PRIVATE_DIR "/../example.apk"; |
| 135 | EXPECT_EQ(-1, validate_apk_path(badpriv2)) |
| 136 | << badpriv2 << " should be rejected as a invalid path"; |
| 137 | |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 138 | // Only one subdir should be allowed. |
| 139 | const char *bad_path3 = TEST_APP_PRIVATE_DIR "example.com/subdir/pkg.apk"; |
| 140 | EXPECT_EQ(-1, validate_apk_path(bad_path3)) |
| 141 | << bad_path3 << " should be rejected as a invalid path"; |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 142 | |
| 143 | const char *bad_path4 = TEST_APP_PRIVATE_DIR "example.com/subdir/../pkg.apk"; |
| 144 | EXPECT_EQ(-1, validate_apk_path(bad_path4)) |
| 145 | << bad_path4 << " should be rejected as a invalid path"; |
| 146 | |
| 147 | const char *bad_path5 = TEST_APP_PRIVATE_DIR "example.com1/../example.com2/pkg.apk"; |
| 148 | EXPECT_EQ(-1, validate_apk_path(bad_path5)) |
| 149 | << bad_path5 << " should be rejected as a invalid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 150 | } |
| 151 | |
| 152 | |
| 153 | TEST_F(UtilsTest, IsValidApkPath_AsecGood1) { |
| 154 | const char *asec1 = TEST_ASEC_DIR "example.apk"; |
| 155 | EXPECT_EQ(0, validate_apk_path(asec1)) |
| 156 | << asec1 << " should be allowed as a valid path"; |
| 157 | } |
| 158 | |
| 159 | TEST_F(UtilsTest, IsValidApkPath_AsecGood2) { |
| 160 | const char *asec2 = TEST_ASEC_DIR "com.example.asec/pkg.apk"; |
| 161 | EXPECT_EQ(0, validate_apk_path(asec2)) |
| 162 | << asec2 << " should be allowed as a valid path"; |
| 163 | } |
| 164 | |
| 165 | TEST_F(UtilsTest, IsValidApkPath_EscapeFail) { |
| 166 | const char *badasec1 = TEST_ASEC_DIR "../example.apk"; |
| 167 | EXPECT_EQ(-1, validate_apk_path(badasec1)) |
| 168 | << badasec1 << " should be rejected as a invalid path"; |
| 169 | } |
| 170 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 171 | TEST_F(UtilsTest, IsValidApkPath_SubdirEscapeFail) { |
| 172 | const char *badasec3 = TEST_ASEC_DIR "com.example.asec/../../../pkg.apk"; |
| 173 | EXPECT_EQ(-1, validate_apk_path(badasec3)) |
| 174 | << badasec3 << " should be rejected as a invalid path"; |
| 175 | } |
| 176 | |
| 177 | TEST_F(UtilsTest, IsValidApkPath_SlashEscapeFail) { |
| 178 | const char *badasec4 = TEST_ASEC_DIR "/../example.apk"; |
| 179 | EXPECT_EQ(-1, validate_apk_path(badasec4)) |
| 180 | << badasec4 << " should be rejected as a invalid path"; |
| 181 | } |
| 182 | |
| 183 | TEST_F(UtilsTest, IsValidApkPath_CrazyDirFail) { |
| 184 | const char *badasec5 = TEST_ASEC_DIR ".//../.."; |
| 185 | EXPECT_EQ(-1, validate_apk_path(badasec5)) |
| 186 | << badasec5 << " should be rejected as a invalid path"; |
| 187 | } |
| 188 | |
| 189 | TEST_F(UtilsTest, IsValidApkPath_SubdirEscapeSingleFail) { |
| 190 | const char *badasec6 = TEST_ASEC_DIR "com.example.asec/../pkg.apk"; |
| 191 | EXPECT_EQ(-1, validate_apk_path(badasec6)) |
| 192 | << badasec6 << " should be rejected as a invalid path"; |
| 193 | } |
| 194 | |
| 195 | TEST_F(UtilsTest, IsValidApkPath_TwoSubdirFail) { |
| 196 | const char *badasec7 = TEST_ASEC_DIR "com.example.asec/subdir1/pkg.apk"; |
| 197 | EXPECT_EQ(-1, validate_apk_path(badasec7)) |
| 198 | << badasec7 << " should be rejected as a invalid path"; |
| 199 | } |
| 200 | |
| 201 | TEST_F(UtilsTest, CheckSystemApp_Dir1) { |
| 202 | const char *sysapp1 = TEST_SYSTEM_DIR1 "Voice.apk"; |
| 203 | EXPECT_EQ(0, validate_system_app_path(sysapp1)) |
| 204 | << sysapp1 << " should be allowed as a system path"; |
| 205 | } |
| 206 | |
| 207 | TEST_F(UtilsTest, CheckSystemApp_Dir2) { |
| 208 | const char *sysapp2 = TEST_SYSTEM_DIR2 "com.example.myapp.apk"; |
| 209 | EXPECT_EQ(0, validate_system_app_path(sysapp2)) |
| 210 | << sysapp2 << " should be allowed as a system path"; |
| 211 | } |
| 212 | |
| 213 | TEST_F(UtilsTest, CheckSystemApp_EscapeFail) { |
| 214 | const char *badapp1 = TEST_SYSTEM_DIR1 "../com.example.apk"; |
| 215 | EXPECT_EQ(-1, validate_system_app_path(badapp1)) |
| 216 | << badapp1 << " should be rejected not a system path"; |
| 217 | } |
| 218 | |
| 219 | TEST_F(UtilsTest, CheckSystemApp_DoubleEscapeFail) { |
| 220 | const char *badapp2 = TEST_SYSTEM_DIR2 "/../../com.example.apk"; |
| 221 | EXPECT_EQ(-1, validate_system_app_path(badapp2)) |
| 222 | << badapp2 << " should be rejected not a system path"; |
| 223 | } |
| 224 | |
| 225 | TEST_F(UtilsTest, CheckSystemApp_BadPathEscapeFail) { |
| 226 | const char *badapp3 = TEST_APP_DIR "/../../com.example.apk"; |
| 227 | EXPECT_EQ(-1, validate_system_app_path(badapp3)) |
| 228 | << badapp3 << " should be rejected not a system path"; |
| 229 | } |
| 230 | |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 231 | TEST_F(UtilsTest, CheckSystemApp_Subdir) { |
| 232 | const char *sysapp = TEST_SYSTEM_DIR1 "com.example/com.example.apk"; |
| 233 | EXPECT_EQ(0, validate_system_app_path(sysapp)) |
| 234 | << sysapp << " should be allowed as a system path"; |
| 235 | |
| 236 | const char *badapp = TEST_SYSTEM_DIR1 "com.example/subdir/com.example.apk"; |
| 237 | EXPECT_EQ(-1, validate_system_app_path(badapp)) |
| 238 | << badapp << " should be rejected not a system path"; |
| 239 | |
| 240 | const char *badapp1 = TEST_SYSTEM_DIR1 "com.example/subdir/../com.example.apk"; |
| 241 | EXPECT_EQ(-1, validate_system_app_path(badapp1)) |
| 242 | << badapp1 << " should be rejected not a system path"; |
| 243 | |
| 244 | const char *badapp2 = TEST_SYSTEM_DIR1 "com.example1/../com.example2/com.example.apk"; |
| 245 | EXPECT_EQ(-1, validate_system_app_path(badapp2)) |
| 246 | << badapp2 << " should be rejected not a system path"; |
| 247 | } |
| 248 | |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 249 | TEST_F(UtilsTest, CreateDataPath) { |
| 250 | EXPECT_EQ("/data", create_data_path(nullptr)); |
| 251 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b", |
| 252 | create_data_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b")); |
| 253 | } |
| 254 | |
Jeff Sharkey | d792118 | 2015-04-30 15:58:19 -0700 | [diff] [blame] | 255 | TEST_F(UtilsTest, CreateDataAppPath) { |
| 256 | EXPECT_EQ("/data/app", create_data_app_path(nullptr)); |
| 257 | |
| 258 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/app", |
| 259 | create_data_app_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b")); |
| 260 | } |
| 261 | |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 262 | TEST_F(UtilsTest, CreateDataUserPath) { |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 263 | EXPECT_EQ("/data/data", create_data_user_ce_path(nullptr, 0)); |
| 264 | EXPECT_EQ("/data/user/10", create_data_user_ce_path(nullptr, 10)); |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 265 | |
| 266 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/0", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 267 | create_data_user_ce_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0)); |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 268 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/10", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 269 | create_data_user_ce_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10)); |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 270 | } |
| 271 | |
| 272 | TEST_F(UtilsTest, CreateDataMediaPath) { |
| 273 | EXPECT_EQ("/data/media/0", create_data_media_path(nullptr, 0)); |
| 274 | EXPECT_EQ("/data/media/10", create_data_media_path(nullptr, 10)); |
| 275 | |
| 276 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/media/0", |
| 277 | create_data_media_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0)); |
| 278 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/media/10", |
| 279 | create_data_media_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10)); |
| 280 | } |
| 281 | |
Jeff Sharkey | d792118 | 2015-04-30 15:58:19 -0700 | [diff] [blame] | 282 | TEST_F(UtilsTest, CreateDataAppPackagePath) { |
| 283 | EXPECT_EQ("/data/app/com.example", create_data_app_package_path(nullptr, "com.example")); |
| 284 | |
| 285 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/app/com.example", |
| 286 | create_data_app_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", "com.example")); |
| 287 | } |
| 288 | |
| 289 | TEST_F(UtilsTest, CreateDataUserPackagePath) { |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 290 | EXPECT_EQ("/data/data/com.example", create_data_user_ce_package_path(nullptr, 0, "com.example")); |
| 291 | EXPECT_EQ("/data/user/10/com.example", create_data_user_ce_package_path(nullptr, 10, "com.example")); |
Jeff Sharkey | c03de09 | 2015-04-07 18:14:05 -0700 | [diff] [blame] | 292 | |
| 293 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/0/com.example", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 294 | create_data_user_ce_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0, "com.example")); |
Jeff Sharkey | c03de09 | 2015-04-07 18:14:05 -0700 | [diff] [blame] | 295 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/10/com.example", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 296 | create_data_user_ce_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10, "com.example")); |
Jeff Sharkey | c03de09 | 2015-04-07 18:14:05 -0700 | [diff] [blame] | 297 | } |
| 298 | |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 299 | TEST_F(UtilsTest, IsValidPackageName) { |
Jeff Sharkey | ab7ac8d | 2017-03-08 12:39:46 -0700 | [diff] [blame] | 300 | EXPECT_EQ(true, is_valid_package_name("android")); |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 301 | EXPECT_EQ(true, is_valid_package_name("com.example")); |
| 302 | EXPECT_EQ(true, is_valid_package_name("com.example-1")); |
| 303 | EXPECT_EQ(true, is_valid_package_name("com.example-1024")); |
| 304 | EXPECT_EQ(true, is_valid_package_name("com.example.foo---KiJFj4a_tePVw95pSrjg==")); |
| 305 | EXPECT_EQ(true, is_valid_package_name("really_LONG.a1234.package_name")); |
| 306 | |
| 307 | EXPECT_EQ(false, is_valid_package_name("1234.package")); |
| 308 | EXPECT_EQ(false, is_valid_package_name("com.1234.package")); |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 309 | EXPECT_EQ(false, is_valid_package_name("")); |
| 310 | EXPECT_EQ(false, is_valid_package_name(".")); |
Jeff Sharkey | ab7ac8d | 2017-03-08 12:39:46 -0700 | [diff] [blame] | 311 | EXPECT_EQ(false, is_valid_package_name("..")); |
| 312 | EXPECT_EQ(false, is_valid_package_name("../")); |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 313 | EXPECT_EQ(false, is_valid_package_name("com.example/../com.evil/")); |
| 314 | EXPECT_EQ(false, is_valid_package_name("com.example-1/../com.evil/")); |
| 315 | EXPECT_EQ(false, is_valid_package_name("/com.evil")); |
| 316 | } |
| 317 | |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 318 | TEST_F(UtilsTest, CreateDataUserProfilePath) { |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 319 | EXPECT_EQ("/data/misc/profiles/cur/0", create_primary_cur_profile_dir_path(0)); |
| 320 | EXPECT_EQ("/data/misc/profiles/cur/1", create_primary_cur_profile_dir_path(1)); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 321 | } |
| 322 | |
| 323 | TEST_F(UtilsTest, CreateDataUserProfilePackagePath) { |
| 324 | EXPECT_EQ("/data/misc/profiles/cur/0/com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 325 | create_primary_current_profile_package_dir_path(0, "com.example")); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 326 | EXPECT_EQ("/data/misc/profiles/cur/1/com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 327 | create_primary_current_profile_package_dir_path(1, "com.example")); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 328 | } |
| 329 | |
| 330 | TEST_F(UtilsTest, CreateDataRefProfilePath) { |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 331 | EXPECT_EQ("/data/misc/profiles/ref", create_primary_ref_profile_dir_path()); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 332 | } |
| 333 | |
| 334 | TEST_F(UtilsTest, CreateDataRefProfilePackagePath) { |
| 335 | EXPECT_EQ("/data/misc/profiles/ref/com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 336 | create_primary_reference_profile_package_dir_path("com.example")); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 337 | } |
| 338 | |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 339 | TEST_F(UtilsTest, CreatePrimaryCurrentProfile) { |
| 340 | std::string expected = |
Calin Juravle | a40b6e3 | 2017-04-12 18:20:44 -0700 | [diff] [blame] | 341 | create_primary_current_profile_package_dir_path(0, "com.example") + "/primary.prof"; |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 342 | EXPECT_EQ(expected, |
| 343 | create_current_profile_path(/*user*/0, "com.example", /*is_secondary*/false)); |
| 344 | } |
| 345 | |
| 346 | TEST_F(UtilsTest, CreatePrimaryReferenceProfile) { |
| 347 | std::string expected = |
| 348 | create_primary_reference_profile_package_dir_path("com.example") + "/primary.prof"; |
| 349 | EXPECT_EQ(expected, |
| 350 | create_reference_profile_path("com.example", /*is_secondary*/false)); |
| 351 | } |
| 352 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame^] | 353 | TEST_F(UtilsTest, CreateProfileSnapshot) { |
| 354 | std::string expected = |
| 355 | create_primary_reference_profile_package_dir_path("com.example") + "/primary.prof.snapshot"; |
| 356 | EXPECT_EQ(expected, create_snapshot_profile_path("com.example", "base.apk")); |
| 357 | } |
| 358 | |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 359 | TEST_F(UtilsTest, CreateSecondaryCurrentProfile) { |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 360 | EXPECT_EQ("/data/user/0/com.example/oat/secondary.dex.cur.prof", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 361 | create_current_profile_path(/*user*/0, |
| 362 | "/data/user/0/com.example/secondary.dex", /*is_secondary*/true)); |
| 363 | } |
| 364 | |
| 365 | TEST_F(UtilsTest, CreateSecondaryReferenceProfile) { |
| 366 | EXPECT_EQ("/data/user/0/com.example/oat/secondary.dex.prof", |
| 367 | create_reference_profile_path( |
| 368 | "/data/user/0/com.example/secondary.dex", /*is_secondary*/true)); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 369 | } |
| 370 | |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 371 | static void pass_secondary_dex_validation(const std::string& package_name, |
| 372 | const std::string& dex_path, int uid, int storage_flag) { |
| 373 | EXPECT_TRUE(validate_secondary_dex_path(package_name, dex_path, /*volume_uuid*/ nullptr, uid, |
| 374 | storage_flag)) |
| 375 | << dex_path << " should be allowed as a valid secondary dex path"; |
| 376 | } |
| 377 | |
| 378 | static void fail_secondary_dex_validation(const std::string& package_name, |
| 379 | const std::string& dex_path, int uid, int storage_flag) { |
| 380 | EXPECT_FALSE(validate_secondary_dex_path(package_name, dex_path, /*volume_uuid*/ nullptr, uid, |
| 381 | storage_flag)) |
| 382 | << dex_path << " should not be allowed as a valid secondary dex path"; |
| 383 | } |
| 384 | |
| 385 | TEST_F(UtilsTest, ValidateSecondaryDexFilesPath) { |
| 386 | std::string package_name = "com.test.app"; |
| 387 | std::string app_dir_ce_user_0 = "/data/data/" + package_name; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 388 | std::string app_dir_ce_user_0_link = "/data/user/0/" + package_name; |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 389 | std::string app_dir_ce_user_10 = "/data/user/10/" + package_name; |
| 390 | |
| 391 | std::string app_dir_de_user_0 = "/data/user_de/0/" + package_name; |
| 392 | std::string app_dir_de_user_10 = "/data/user_de/10/" + package_name; |
| 393 | |
| 394 | EXPECT_EQ(app_dir_ce_user_0, |
| 395 | create_data_user_ce_package_path(nullptr, 0, package_name.c_str())); |
| 396 | EXPECT_EQ(app_dir_ce_user_10, |
| 397 | create_data_user_ce_package_path(nullptr, 10, package_name.c_str())); |
| 398 | |
| 399 | EXPECT_EQ(app_dir_de_user_0, |
| 400 | create_data_user_de_package_path(nullptr, 0, package_name.c_str())); |
| 401 | EXPECT_EQ(app_dir_de_user_10, |
| 402 | create_data_user_de_package_path(nullptr, 10, package_name.c_str())); |
| 403 | |
| 404 | uid_t app_uid_for_user_0 = multiuser_get_uid(/*user_id*/0, /*app_id*/ 1234); |
| 405 | uid_t app_uid_for_user_10 = multiuser_get_uid(/*user_id*/10, /*app_id*/ 1234); |
| 406 | |
| 407 | // Standard path for user 0 on CE storage. |
| 408 | pass_secondary_dex_validation( |
| 409 | package_name, app_dir_ce_user_0 + "/ce0.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 410 | pass_secondary_dex_validation( |
| 411 | package_name, app_dir_ce_user_0_link + "/ce0.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 412 | // Standard path for user 10 on CE storage. |
| 413 | pass_secondary_dex_validation( |
| 414 | package_name, app_dir_ce_user_10 + "/ce10.dex", app_uid_for_user_10, FLAG_STORAGE_CE); |
| 415 | |
| 416 | // Standard path for user 0 on DE storage. |
| 417 | pass_secondary_dex_validation( |
| 418 | package_name, app_dir_de_user_0 + "/de0.dex", app_uid_for_user_0, FLAG_STORAGE_DE); |
| 419 | // Standard path for user 10 on DE storage. |
| 420 | pass_secondary_dex_validation( |
| 421 | package_name, app_dir_de_user_10 + "/de0.dex", app_uid_for_user_10, FLAG_STORAGE_DE); |
| 422 | |
| 423 | // Dex path for user 0 accessed from user 10. |
| 424 | fail_secondary_dex_validation( |
| 425 | package_name, app_dir_ce_user_0 + "/path0_from10.dex", |
| 426 | app_uid_for_user_10, FLAG_STORAGE_CE); |
| 427 | |
| 428 | // Dex path for CE storage accessed with DE. |
| 429 | fail_secondary_dex_validation( |
| 430 | package_name, app_dir_ce_user_0 + "/ce_from_de.dex", app_uid_for_user_0, FLAG_STORAGE_DE); |
| 431 | |
| 432 | // Dex path for DE storage accessed with CE. |
| 433 | fail_secondary_dex_validation( |
| 434 | package_name, app_dir_de_user_0 + "/de_from_ce.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
| 435 | |
| 436 | // Location which does not start with '/'. |
| 437 | fail_secondary_dex_validation( |
| 438 | package_name, "without_slash.dex", app_uid_for_user_10, FLAG_STORAGE_DE); |
| 439 | |
| 440 | // The dex file is not in the specified package directory. |
| 441 | fail_secondary_dex_validation( |
| 442 | "another.package", app_dir_ce_user_0 + "/for_another_package.dex", |
| 443 | app_uid_for_user_0, FLAG_STORAGE_DE); |
| 444 | |
| 445 | // The dex path contains indirect directories. |
| 446 | fail_secondary_dex_validation( |
| 447 | package_name, app_dir_ce_user_0 + "/1/../foo.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
| 448 | fail_secondary_dex_validation( |
| 449 | package_name, app_dir_ce_user_0 + "/1/./foo.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
| 450 | |
| 451 | // Super long path. |
| 452 | std::string too_long = create_too_long_path("too_long_"); |
| 453 | fail_secondary_dex_validation( |
| 454 | package_name, app_dir_ce_user_10 + "/" + too_long, app_uid_for_user_10, FLAG_STORAGE_CE); |
| 455 | } |
| 456 | |
Jeff Sharkey | 172fac0 | 2017-10-06 13:09:46 -0600 | [diff] [blame] | 457 | TEST_F(UtilsTest, ValidateApkPath) { |
| 458 | EXPECT_EQ(0, validate_apk_path("/data/app/com.example")); |
| 459 | EXPECT_EQ(0, validate_apk_path("/data/app/com.example/file")); |
| 460 | EXPECT_EQ(0, validate_apk_path("/data/app/com.example//file")); |
| 461 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/")); |
| 462 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/file")); |
| 463 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/file")); |
| 464 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir//file")); |
| 465 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/dir/file")); |
| 466 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/dir//file")); |
| 467 | } |
| 468 | |
| 469 | TEST_F(UtilsTest, ValidateApkPathSubdirs) { |
| 470 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example")); |
| 471 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/file")); |
| 472 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example//file")); |
| 473 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/")); |
| 474 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/file")); |
| 475 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/file")); |
| 476 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir//file")); |
| 477 | EXPECT_NE(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir/file")); |
| 478 | EXPECT_NE(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir//file")); |
| 479 | } |
| 480 | |
Andreas Gampe | 02d0de5 | 2015-11-11 20:43:16 -0800 | [diff] [blame] | 481 | } // namespace installd |
| 482 | } // namespace android |