blob: 2b9fd5d4b67efebb5d7fc3f2637d55e528a5f4ca [file] [log] [blame]
Dan Stoza47730d62017-05-16 15:12:48 -07001/*
2 * Copyright 2017 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include <gui/BufferQueue.h>
18#include <gui/IProducerListener.h>
19#include <gui/Surface.h>
20
21#include <android/native_window.h>
22
23#include <gtest/gtest.h>
24
25namespace android {
26namespace test {
27
28class ProxyBQP : public BnGraphicBufferProducer {
29public:
30 ProxyBQP(const sp<IGraphicBufferProducer>& producer) : mProducer(producer) {}
31
32 // Pass through calls to mProducer
33 status_t requestBuffer(int slot, sp<GraphicBuffer>* buf) override {
34 return mProducer->requestBuffer(slot, buf);
35 }
36 status_t setMaxDequeuedBufferCount(int maxDequeuedBuffers) override {
37 return mProducer->setMaxDequeuedBufferCount(maxDequeuedBuffers);
38 }
39 status_t setAsyncMode(bool async) override { return mProducer->setAsyncMode(async); }
40 status_t dequeueBuffer(int* slot, sp<Fence>* fence, uint32_t w, uint32_t h, PixelFormat format,
Ian Elliotta2eb34c2017-07-18 11:05:49 -060041 uint64_t usage, uint64_t* outBufferAge,
42 FrameEventHistoryDelta* outTimestamps) override {
43 return mProducer->dequeueBuffer(slot, fence, w, h, format, usage, outBufferAge,
44 outTimestamps);
Dan Stoza47730d62017-05-16 15:12:48 -070045 }
46 status_t detachBuffer(int slot) override { return mProducer->detachBuffer(slot); }
47 status_t detachNextBuffer(sp<GraphicBuffer>* outBuffer, sp<Fence>* outFence) override {
48 return mProducer->detachNextBuffer(outBuffer, outFence);
49 }
50 status_t attachBuffer(int* outSlot, const sp<GraphicBuffer>& buffer) override {
51 return mProducer->attachBuffer(outSlot, buffer);
52 }
53 status_t queueBuffer(int slot, const QueueBufferInput& input,
54 QueueBufferOutput* output) override {
55 return mProducer->queueBuffer(slot, input, output);
56 }
57 status_t cancelBuffer(int slot, const sp<Fence>& fence) override {
58 return mProducer->cancelBuffer(slot, fence);
59 }
60 int query(int what, int* value) override { return mProducer->query(what, value); }
61 status_t connect(const sp<IProducerListener>& listener, int api, bool producerControlledByApp,
62 QueueBufferOutput* output) override {
63 return mProducer->connect(listener, api, producerControlledByApp, output);
64 }
65 status_t disconnect(int api, DisconnectMode mode) override {
66 return mProducer->disconnect(api, mode);
67 }
68 status_t setSidebandStream(const sp<NativeHandle>& stream) override {
69 return mProducer->setSidebandStream(stream);
70 }
71 void allocateBuffers(uint32_t width, uint32_t height, PixelFormat format,
Mathias Agopiancb496ac2017-05-22 14:21:00 -070072 uint64_t usage) override {
Dan Stoza47730d62017-05-16 15:12:48 -070073 mProducer->allocateBuffers(width, height, format, usage);
74 }
75 status_t allowAllocation(bool allow) override { return mProducer->allowAllocation(allow); }
76 status_t setGenerationNumber(uint32_t generationNumber) override {
77 return mProducer->setGenerationNumber(generationNumber);
78 }
79 String8 getConsumerName() const override { return mProducer->getConsumerName(); }
80 status_t setSharedBufferMode(bool sharedBufferMode) override {
81 return mProducer->setSharedBufferMode(sharedBufferMode);
82 }
83 status_t setAutoRefresh(bool autoRefresh) override {
84 return mProducer->setAutoRefresh(autoRefresh);
85 }
86 status_t setDequeueTimeout(nsecs_t timeout) override {
87 return mProducer->setDequeueTimeout(timeout);
88 }
89 status_t getLastQueuedBuffer(sp<GraphicBuffer>* outBuffer, sp<Fence>* outFence,
90 float outTransformMatrix[16]) override {
91 return mProducer->getLastQueuedBuffer(outBuffer, outFence, outTransformMatrix);
92 }
93 void getFrameTimestamps(FrameEventHistoryDelta*) override {}
94 status_t getUniqueId(uint64_t* outId) const override { return mProducer->getUniqueId(outId); }
95
96protected:
97 sp<IGraphicBufferProducer> mProducer;
98};
99
100class MaliciousBQP : public ProxyBQP {
101public:
102 MaliciousBQP(const sp<IGraphicBufferProducer>& producer) : ProxyBQP(producer) {}
103
104 void beMalicious(int32_t value) { mMaliciousValue = value; }
105
106 void setExpectedSlot(int32_t slot) { mExpectedSlot = slot; }
107
108 // Override dequeueBuffer, optionally corrupting the returned slot number
109 status_t dequeueBuffer(int* buf, sp<Fence>* fence, uint32_t width, uint32_t height,
Ian Elliotta2eb34c2017-07-18 11:05:49 -0600110 PixelFormat format, uint64_t usage, uint64_t* outBufferAge,
Dan Stoza47730d62017-05-16 15:12:48 -0700111 FrameEventHistoryDelta* outTimestamps) override {
112 EXPECT_EQ(BUFFER_NEEDS_REALLOCATION,
Ian Elliotta2eb34c2017-07-18 11:05:49 -0600113 mProducer->dequeueBuffer(buf, fence, width, height, format, usage, outBufferAge,
Dan Stoza47730d62017-05-16 15:12:48 -0700114 outTimestamps));
115 EXPECT_EQ(mExpectedSlot, *buf);
116 if (mMaliciousValue != 0) {
117 *buf = mMaliciousValue;
118 return NO_ERROR;
119 } else {
120 return BUFFER_NEEDS_REALLOCATION;
121 }
122 }
123
124private:
125 int32_t mMaliciousValue = 0;
126 int32_t mExpectedSlot = 0;
127};
128
129class DummyListener : public BnConsumerListener {
130public:
131 void onFrameAvailable(const BufferItem&) override {}
132 void onBuffersReleased() override {}
133 void onSidebandStreamChanged() override {}
134};
135
136sp<MaliciousBQP> getMaliciousBQP() {
137 sp<IGraphicBufferProducer> producer;
138 sp<IGraphicBufferConsumer> consumer;
139 BufferQueue::createBufferQueue(&producer, &consumer);
140 sp<IConsumerListener> listener = new DummyListener;
141 consumer->consumerConnect(listener, false);
142
143 sp<MaliciousBQP> malicious = new MaliciousBQP(producer);
144 return malicious;
145}
146
147TEST(Malicious, Bug36991414Max) {
148 sp<MaliciousBQP> malicious = getMaliciousBQP();
149 sp<Surface> surface = new Surface(malicious);
150
151 ASSERT_EQ(NO_ERROR, surface->connect(NATIVE_WINDOW_API_CPU, nullptr, false));
152 ANativeWindow_Buffer buffer;
153 ASSERT_EQ(NO_ERROR, surface->lock(&buffer, nullptr));
154 ASSERT_EQ(NO_ERROR, surface->unlockAndPost());
155
156 malicious->setExpectedSlot(1);
157 malicious->beMalicious(std::numeric_limits<int32_t>::max());
158 ASSERT_EQ(FAILED_TRANSACTION, surface->lock(&buffer, nullptr));
159}
160
161TEST(Malicious, Bug36991414Min) {
162 sp<MaliciousBQP> malicious = getMaliciousBQP();
163 sp<Surface> surface = new Surface(malicious);
164
165 ASSERT_EQ(NO_ERROR, surface->connect(NATIVE_WINDOW_API_CPU, nullptr, false));
166 ANativeWindow_Buffer buffer;
167 ASSERT_EQ(NO_ERROR, surface->lock(&buffer, nullptr));
168 ASSERT_EQ(NO_ERROR, surface->unlockAndPost());
169
170 malicious->setExpectedSlot(1);
171 malicious->beMalicious(std::numeric_limits<int32_t>::min());
172 ASSERT_EQ(FAILED_TRANSACTION, surface->lock(&buffer, nullptr));
173}
174
175TEST(Malicious, Bug36991414NegativeOne) {
176 sp<MaliciousBQP> malicious = getMaliciousBQP();
177 sp<Surface> surface = new Surface(malicious);
178
179 ASSERT_EQ(NO_ERROR, surface->connect(NATIVE_WINDOW_API_CPU, nullptr, false));
180 ANativeWindow_Buffer buffer;
181 ASSERT_EQ(NO_ERROR, surface->lock(&buffer, nullptr));
182 ASSERT_EQ(NO_ERROR, surface->unlockAndPost());
183
184 malicious->setExpectedSlot(1);
185 malicious->beMalicious(-1);
186 ASSERT_EQ(FAILED_TRANSACTION, surface->lock(&buffer, nullptr));
187}
188
189TEST(Malicious, Bug36991414NumSlots) {
190 sp<MaliciousBQP> malicious = getMaliciousBQP();
191 sp<Surface> surface = new Surface(malicious);
192
193 ASSERT_EQ(NO_ERROR, surface->connect(NATIVE_WINDOW_API_CPU, nullptr, false));
194 ANativeWindow_Buffer buffer;
195 ASSERT_EQ(NO_ERROR, surface->lock(&buffer, nullptr));
196 ASSERT_EQ(NO_ERROR, surface->unlockAndPost());
197
198 malicious->setExpectedSlot(1);
199 malicious->beMalicious(BufferQueueDefs::NUM_BUFFER_SLOTS);
200 ASSERT_EQ(FAILED_TRANSACTION, surface->lock(&buffer, nullptr));
201}
202
203} // namespace test
204} // namespace android