Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / frameworks / support / 88fc88b6544fad2a112361d66b2f21b2bcea77da / . / v17 / leanback / lint-baseline.xml
blob: 24cb762f5c1afc8cdcf6e09634f44ae3bf6fdb22 [file] [log] [blame]
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]1<?xml version="1.0" encoding="UTF-8"?>
2<issues format="4" by="lint 2.4.0-alpha6">
3
4 <issue
5 id="MissingSuperCall"
6 message="Overriding method should call `super.onAnimationEnd`"
7 errorLine1=" public void onAnimationEnd(Animation animation) {"
8 errorLine2=" ~~~~~~~~~~~~~~">
9 <location
10 file="java/android/support/v4/app/FragmentManager.java"
11 line="1604"
12 column="29"/>
13 </issue>
14
15 <issue
16 id="MissingSuperCall"
17 message="Overriding method should call `super.onAnimationEnd`"
18 errorLine1=" public void onAnimationEnd(Animation animation) {"
19 errorLine2=" ~~~~~~~~~~~~~~">
20 <location
21 file="java/android/support/v4/app/FragmentManager.java"
22 line="3935"
23 column="21"/>
24 </issue>
25
26 <issue
27 id="ResourceType"
28 message="Expected resource of type string"
29 errorLine1=" ? Float.parseFloat(res.getString(R.dimen.lb_browse_header_select_scale))"
30 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
31 <location
32 file="src/android/support/v17/leanback/widget/FocusHighlightHelper.java"
33 line="276"
34 column="58"/>
35 </issue>
36
37 <issue
38 id="ResourceType"
39 message="Expected resource of type string"
40 errorLine1=" Integer.parseInt(res.getString(R.dimen.lb_browse_header_select_duration));"
41 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
42 <location
43 file="src/android/support/v17/leanback/widget/FocusHighlightHelper.java"
44 line="279"
45 column="56"/>
46 </issue>
47
48 <issue
49 id="ResourceType"
50 message="Expected resource of type anim or interpolator"
51 errorLine1=" R.animator.lb_decelerator_4));"
52 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
53 <location
54 file="kitkat/android/support/v17/leanback/transition/LeanbackTransitionHelperKitKat.java"
55 line="38"
56 column="17"/>
57 </issue>
58
59 <issue
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]60 id="LongLogTag"
61 message="The logging tag can be at most 23 characters, was 27 (DetailsOverviewRowPresenter)"
62 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onLayoutChange &quot; + v);"
63 errorLine2=" ~~~">
64 <location
65 file="src/android/support/v17/leanback/widget/DetailsOverviewRowPresenter.java"
66 line="178"
67 column="34"/>
68 </issue>
69
70 <issue
71 id="LongLogTag"
72 message="The logging tag can be at most 23 characters, was 27 (DetailsOverviewRowPresenter)"
73 errorLine1=" Log.v(TAG, &quot;checkFirstAndLast fromScroll &quot; + fromScroll"
74 errorLine2=" ~~~">
75 <location
76 file="src/android/support/v17/leanback/widget/DetailsOverviewRowPresenter.java"
77 line="237"
78 column="23"/>
79 </issue>
80
81 <issue
82 id="LongLogTag"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]83 message="The logging tag can be at most 23 characters, was 36 (FullWidthDetailsOverviewRowPresenter)"
84 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onLayoutChange &quot; + v);"
85 errorLine2=" ~~~">
86 <location
87 file="src/android/support/v17/leanback/widget/FullWidthDetailsOverviewRowPresenter.java"
88 line="236"
89 column="34"/>
90 </issue>
91
92 <issue
93 id="LongLogTag"
94 message="The logging tag can be at most 23 characters, was 36 (FullWidthDetailsOverviewRowPresenter)"
95 errorLine1=" Log.v(TAG, &quot;checkFirstAndLast fromScroll &quot; + fromScroll"
96 errorLine2=" ~~~">
97 <location
98 file="src/android/support/v17/leanback/widget/FullWidthDetailsOverviewRowPresenter.java"
99 line="295"
100 column="23"/>
101 </issue>
102
103 <issue
104 id="LongLogTag"
105 message="The logging tag can be at most 23 characters, was 25 (GuidedStepSupportFragment)"
106 errorLine1=" Log.w(TAG, &quot;Fragment is already exists, likely calling &quot;"
107 errorLine2=" ~~~">
108 <location
109 file="src/android/support/v17/leanback/app/GuidedStepSupportFragment.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]110 line="642"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]111 column="19"/>
112 </issue>
113
114 <issue
115 id="LongLogTag"
116 message="The logging tag can be at most 23 characters, was 25 (GuidedStepSupportFragment)"
117 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onCreate&quot;);"
118 errorLine2=" ~~~">
119 <location
120 file="src/android/support/v17/leanback/app/GuidedStepSupportFragment.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]121 line="1000"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]122 column="26"/>
123 </issue>
124
125 <issue
126 id="LongLogTag"
127 message="The logging tag can be at most 23 characters, was 25 (GuidedStepSupportFragment)"
128 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onCreateView&quot;);"
129 errorLine2=" ~~~">
130 <location
131 file="src/android/support/v17/leanback/app/GuidedStepSupportFragment.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]132 line="1039"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]133 column="26"/>
134 </issue>
135
136 <issue
137 id="LongLogTag"
138 message="The logging tag can be at most 23 characters, was 25 (GuidedStepSupportFragment)"
139 errorLine1=" if (DEBUG) Log.v(TAG, &quot;Found guided step theme flag? &quot; + found);"
140 errorLine2=" ~~~">
141 <location
142 file="src/android/support/v17/leanback/app/GuidedStepSupportFragment.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]143 line="1239"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]144 column="26"/>
145 </issue>
146
147 <issue
148 id="LongLogTag"
149 message="The logging tag can be at most 23 characters, was 25 (GuidedStepSupportFragment)"
150 errorLine1=" if (DEBUG) Log.v(TAG, &quot;Found guided step theme reference? &quot; + found);"
151 errorLine2=" ~~~">
152 <location
153 file="src/android/support/v17/leanback/app/GuidedStepSupportFragment.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]154 line="1352"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]155 column="30"/>
156 </issue>
157
158 <issue
159 id="LongLogTag"
160 message="The logging tag can be at most 23 characters, was 25 (GuidedStepSupportFragment)"
161 errorLine1=" Log.e(TAG, &quot;GuidedStepSupportFragment does not have an appropriate theme set.&quot;);"
162 errorLine2=" ~~~">
163 <location
164 file="src/android/support/v17/leanback/app/GuidedStepSupportFragment.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]165 line="1364"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]166 column="23"/>
167 </issue>
168
169 <issue
170 id="LongLogTag"
171 message="The logging tag can be at most 23 characters, was 25 (OnboardingSupportFragment)"
172 errorLine1=" if (DEBUG) Log.v(TAG, &quot;Found onboarding theme reference? &quot; + found);"
173 errorLine2=" ~~~">
174 <location
175 file="src/android/support/v17/leanback/app/OnboardingSupportFragment.java"
176 line="552"
177 column="30"/>
178 </issue>
179
180 <issue
181 id="LongLogTag"
182 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
183 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onAnimationEnd &quot; + mBgAlpha);"
184 errorLine2=" ~~~">
185 <location
186 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
187 line="148"
188 column="30"/>
189 </issue>
190
191 <issue
192 id="LongLogTag"
193 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
194 errorLine1=" if (DEBUG) Log.v(TAG, &quot;setFadingEnabled &quot; + enabled);"
195 errorLine2=" ~~~">
196 <location
197 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
198 line="236"
199 column="26"/>
200 </issue>
201
202 <issue
203 id="LongLogTag"
204 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
205 errorLine1=" if (DEBUG) Log.v(TAG, &quot;tickle enabled &quot; + mFadingEnabled + &quot; isResumed &quot; + isResumed());"
206 errorLine2=" ~~~">
207 <location
208 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
209 line="313"
210 column="26"/>
211 </issue>
212
213 <issue
214 id="LongLogTag"
215 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
216 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onInterceptInputEvent hidden &quot; + controlsHidden + &quot; &quot; + event);"
217 errorLine2=" ~~~">
218 <location
219 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
220 line="363"
221 column="26"/>
222 </issue>
223
224 <issue
225 id="LongLogTag"
226 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
227 errorLine1=" if (DEBUG) Log.v(TAG, &quot;fraction &quot; + fraction);"
228 errorLine2=" ~~~">
229 <location
230 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
231 line="481"
232 column="38"/>
233 </issue>
234
235 <issue
236 id="LongLogTag"
237 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
238 errorLine1=" if (DEBUG) Log.v(TAG, &quot;fade &quot; + fadeIn);"
239 errorLine2=" ~~~">
240 <location
241 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
242 line="577"
243 column="26"/>
244 </issue>
245
246 <issue
247 id="LongLogTag"
248 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
249 errorLine1=" if (DEBUG) Log.v(TAG, &quot;requested fade in progress&quot;);"
250 errorLine2=" ~~~">
251 <location
252 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
253 line="582"
254 column="30"/>
255 </issue>
256
257 <issue
258 id="LongLogTag"
259 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
260 errorLine1=" if (DEBUG) Log.v(TAG, &quot;fade is no-op&quot;);"
261 errorLine2=" ~~~">
262 <location
263 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
264 line="586"
265 column="30"/>
266 </issue>
267
268 <issue
269 id="LongLogTag"
270 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
271 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onAttachedToWindow &quot; + vh.getViewHolder().view);"
272 errorLine2=" ~~~">
273 <location
274 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
275 line="770"
276 column="30"/>
277 </issue>
278
279 <issue
280 id="LongLogTag"
281 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
282 errorLine1=" if (DEBUG) Log.v(TAG, &quot;setting alpha to 0&quot;);"
283 errorLine2=" ~~~">
284 <location
285 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
286 line="772"
287 column="34"/>
288 </issue>
289
290 <issue
291 id="LongLogTag"
292 message="The logging tag can be at most 23 characters, was 30 (PlaybackOverlaySupportFragment)"
293 errorLine1=" if (DEBUG) Log.v(TAG, &quot;onDetachedFromWindow &quot; + vh.getViewHolder().view);"
294 errorLine2=" ~~~">
295 <location
296 file="src/android/support/v17/leanback/app/PlaybackOverlaySupportFragment.java"
297 line="781"
298 column="30"/>
299 </issue>
300
301 <issue
302 id="LongLogTag"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]303 message="The logging tag can be at most 23 characters, was 27 (VerticalGridSupportFragment)"
304 errorLine1=" if (DEBUG) Log.v(TAG, &quot;grid selected position &quot; + position);"
305 errorLine2=" ~~~">
306 <location
307 file="src/android/support/v17/leanback/app/VerticalGridSupportFragment.java"
308 line="120"
309 column="30"/>
310 </issue>
311
312 <issue
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]313 id="Orientation"
314 message="No orientation specified, and the default is horizontal. This is a common source of bugs when children are added dynamically."
315 errorLine1=" &lt;LinearLayout"
316 errorLine2=" ^">
317 <location
318 file="res/layout/lb_row_media_item.xml"
319 line="63"
320 column="13"/>
321 </issue>
322
323 <issue
324 id="WrongConstant"
325 message="Must be one of: ViewCompat.LAYOUT_DIRECTION_LTR, ViewCompat.LAYOUT_DIRECTION_RTL"
326 errorLine1=" boolean isRtl = ViewCompat.getLayoutDirection(focused) == View.LAYOUT_DIRECTION_RTL;"
327 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
328 <location
329 file="src/android/support/v17/leanback/app/BrowseFragment.java"
330 line="1029"
331 column="71"/>
332 </issue>
333
334 <issue
335 id="WrongConstant"
336 message="Must be one of: ViewCompat.LAYOUT_DIRECTION_LTR, ViewCompat.LAYOUT_DIRECTION_RTL"
337 errorLine1=" boolean isRtl = ViewCompat.getLayoutDirection(focused) == View.LAYOUT_DIRECTION_RTL;"
338 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
339 <location
340 file="src/android/support/v17/leanback/app/BrowseSupportFragment.java"
341 line="1032"
342 column="71"/>
343 </issue>
344
345 <issue
346 id="WrongConstant"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]347 message="Must be one or more of: Gravity.LEFT, Gravity.RIGHT, GravityCompat.START, GravityCompat.END"
348 errorLine1=" + gravityToString(childGravity) + &quot; but this &quot; + TAG + &quot; already has a &quot;"
349 errorLine2=" ~~~~~~~~~~~~">
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]350 <location
351 file="java/android/support/v4/widget/DrawerLayout.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]352 line="1075"
353 column="47"/>
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]354 </issue>
355
356 <issue
357 id="WrongConstant"
358 message="Must be one of: View.VISIBLE, View.INVISIBLE, View.GONE"
359 errorLine1=" v.setVisibility(mChildVisibility);"
360 errorLine2=" ~~~~~~~~~~~~~~~~">
361 <location
362 file="src/android/support/v17/leanback/widget/GridLayoutManager.java"
363 line="1566"
364 column="37"/>
365 </issue>
366
367 <issue
368 id="WrongConstant"
369 message="Must be one of: View.VISIBLE, View.INVISIBLE, View.GONE"
370 errorLine1=" getChildAt(i).setVisibility(mChildVisibility);"
371 errorLine2=" ~~~~~~~~~~~~~~~~">
372 <location
373 file="src/android/support/v17/leanback/widget/GridLayoutManager.java"
Aurimas Liutikasf74f1272017-06-27 09:32:05 -0700[diff] [blame]374 line="3476"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]375 column="45"/>
376 </issue>
377
378 <issue
379 id="WrongConstant"
380 message="Must be one of: ViewCompat.LAYOUT_DIRECTION_LTR, ViewCompat.LAYOUT_DIRECTION_RTL"
381 errorLine1=" boolean isRtl = ViewCompat.getLayoutDirection(view) == View.LAYOUT_DIRECTION_RTL;"
382 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
383 <location
384 file="src/android/support/v17/leanback/widget/HorizontalHoverCardSwitcher.java"
385 line="50"
386 column="64"/>
387 </issue>
388
389 <issue
390 id="WrongConstant"
Aurimas Liutikas624bd202017-06-15 10:44:13 -0700[diff] [blame]391 message="Must be one of: ViewCompat.LAYOUT_DIRECTION_LTR, ViewCompat.LAYOUT_DIRECTION_RTL"
392 errorLine1=" == View.LAYOUT_DIRECTION_RTL;"
393 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
394 <location
395 file="src/android/support/v17/leanback/widget/TitleHelper.java"
396 line="49"
397 column="24"/>
398 </issue>
399
400 <issue
401 id="RtlCompat"
402 message="Inconsistent alignment specification between `textAlignment` and `gravity` attributes: was `center_vertical|end`, expected `start`"
403 errorLine1=" android:textAlignment=&quot;viewStart&quot;"
404 errorLine2=" ~~~~~~~~~">
405 <location
406 file="res/layout/lb_search_bar.xml"
407 line="70"
408 column="44"/>
409 <location
410 file="res/layout/lb_search_bar.xml"
411 line="57"
412 column="45"/>
413 </issue>
414
415</issues>