Merge "Update voicemail donations strings"
am: 5959cb2ea8
Change-Id: I407f7f67b2c470d72b9c3f9c734f71696057a84b
diff --git a/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java b/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java
index 82c9815..1f27e5b 100644
--- a/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java
+++ b/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java
@@ -329,10 +329,8 @@
// Use a custom title to prevent truncation, sigh
TextView title = new TextView(context);
- title.setText(
- ratingValue == TranscriptionRatingValue.GOOD_TRANSCRIPTION
- ? R.string.voicemail_donation_promo_good_title
- : R.string.voicemail_donation_promo_bad_title);
+ title.setText(R.string.voicemail_donation_promo_title);
+
title.setTypeface(Typeface.create("sans-serif-medium", Typeface.NORMAL));
title.setTextSize(TypedValue.COMPLEX_UNIT_SP, 20);
title.setTextColor(ContextCompat.getColor(context, R.color.dialer_primary_text_color));
@@ -383,7 +381,7 @@
CharSequence content = context.getString(R.string.voicemail_donation_promo_content);
CharSequence learnMore = context.getString(R.string.voicemail_donation_promo_learn_more);
String learnMoreUrl = context.getString(R.string.voicemail_donation_promo_learn_more_url);
- SpannableString span = new SpannableString(content + "\n" + learnMore);
+ SpannableString span = new SpannableString(content + " " + learnMore);
int end = span.length();
int start = end - learnMore.length();
span.setSpan(new URLSpan(learnMoreUrl), start, end, Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
diff --git a/java/com/android/dialer/app/res/values/strings.xml b/java/com/android/dialer/app/res/values/strings.xml
index 5773a0c..5974f47 100644
--- a/java/com/android/dialer/app/res/values/strings.xml
+++ b/java/com/android/dialer/app/res/values/strings.xml
@@ -675,19 +675,15 @@
[CHAR LIMIT=64] -->
<string name="voicemail_transcription_failed_no_speech">Transcript not available. No speech detected.</string>
- <!-- Title of voicemail donation promo dialog, show after clicking a 'thumbs up' rating icon
- [CHAR LIMIT=64] -->
- <string name="voicemail_donation_promo_good_title">Thanks! Would you like to help us improve transcriptions?</string>
-
- <!-- Title of voicemail donation promo dialog, show after clicking a 'thumbs up' rating icon
- [CHAR LIMIT=64] -->
- <string name="voicemail_donation_promo_bad_title">Sorry. Would you like to help us improve transcriptions?</string>
+ <!-- Title of voicemail donation promo dialog
+ [CHAR LIMIT=64] -->
+ <string name="voicemail_donation_promo_title">Help improve transcription accuracy?</string>
<!-- Content of voicemail donation promo dialog
[CHAR LIMIT=NONE] -->
<string name="voicemail_donation_promo_content">
- Let Google review your voicemail messages to improve transcription quality.
- For voicemail transcription analysis, your voicemail messages are stored anonymously.
+ Let Google review this and future voicemail messages with transcripts.
+ They\'ll be stored anonymously. Change Settings any time.
</string>
<!-- Text for a 'learn more' link at the end of the voicemail donation promo dialog content -->
diff --git a/java/com/android/dialer/voicemail/settings/res/values/strings.xml b/java/com/android/dialer/voicemail/settings/res/values/strings.xml
index 47228b7..3056ef6 100644
--- a/java/com/android/dialer/voicemail/settings/res/values/strings.xml
+++ b/java/com/android/dialer/voicemail/settings/res/values/strings.xml
@@ -116,7 +116,7 @@
[CHAR LIMIT=NONE] -->
<string name="voicemail_donate_preference_summary_not_activated">Visual voicemail is not activated yet, please try again later</string>
<!-- Summary information for visual voicemail donation setting [CHAR LIMIT=NONE] -->
- <string name="voicemail_donate_preference_summary_info">Let Google review your voicemail messages to improve transcription quality</string>
+ <string name="voicemail_donate_preference_summary_info">Let Google review your voicemail messages to improve transcription accuracy</string>
<!-- Title for disable visual voicemail confirmation dialog [CHAR LIMIT=40] -->
<string name="confirm_disable_voicemail_dialog_title">Turn off visual voicemail</string>