| commit | f809b8673da2d29388dbaa2dd0c80f9c3881d431 | [log] [tgz] |
|---|---|---|
| author | Samuel Tan <samueltan@google.com> | Tue Sep 01 17:24:16 2015 -0700 |
| committer | chrome-bot <chrome-bot@chromium.org> | Wed Sep 02 11:26:53 2015 -0700 |
| tree | a2995f77023d87209189481cbda358eeffbd96c8 | |
| parent | 8631154ee15cf8e0b4b266bfa0ce689a7af2ebce [diff] |
shill: Fix event history formatting
Since our syslogger does not print non-printable characters
(e.g. newlines and tabs), remove these characters logged
messages in ConnectionDiagnostics events.
Remove ConnectionDiagnostics::EventsToString since it relies on
printing newline characters, and leave it to the user of
ConnectionDiagnostics to repeatedly call
ConnectionDiagnostics::EventToString to print all events to
logs.
While there, fix up log messages in IcmpSession and
ConnectionDiagnostics to be more readable and informative.
BUG=chromium:526318
TEST=Compile shill and run unit tests.
TEST=Manually trigger ConnectionDiagnostics by editing shill source code and
ensure that the results are printed properly (i.e. each event is a seperate
log message printed on its own line).
Change-Id: I8b5329bf7153867147d78a4ca16c6c4a4a85786b
Reviewed-on: https://chromium-review.googlesource.com/296529
Commit-Ready: Samuel Tan <samueltan@chromium.org>
Tested-by: Samuel Tan <samueltan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>