Darin Petkov | ac635a8 | 2012-01-10 16:51:58 +0100 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Ben Chan | c54afe5 | 2014-11-05 10:28:08 -0800 | [diff] [blame] | 5 | #include "shill/cellular/cellular_service.h" |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 6 | |
| 7 | #include <chromeos/dbus/service_constants.h> |
| 8 | #include <gtest/gtest.h> |
Christopher Wiley | 1582bdd | 2012-11-15 11:31:14 -0800 | [diff] [blame] | 9 | #include <mm/mm-modem.h> |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 10 | |
Ben Chan | c54afe5 | 2014-11-05 10:28:08 -0800 | [diff] [blame] | 11 | #include "shill/cellular/cellular_capability.h" |
| 12 | #include "shill/cellular/cellular_capability_cdma.h" |
| 13 | #include "shill/cellular/mock_cellular.h" |
| 14 | #include "shill/cellular/mock_modem_info.h" |
| 15 | #include "shill/cellular/mock_out_of_credits_detector.h" |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 16 | #include "shill/mock_adaptors.h" |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 17 | #include "shill/mock_manager.h" |
Thieu Le | 3426c8f | 2012-01-11 17:35:11 -0800 | [diff] [blame] | 18 | #include "shill/mock_metrics.h" |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 19 | #include "shill/mock_profile.h" |
Ben Chan | 19f8397 | 2012-10-03 23:25:56 -0700 | [diff] [blame] | 20 | #include "shill/mock_store.h" |
Ben Chan | 3ecdf82 | 2012-08-06 12:29:23 -0700 | [diff] [blame] | 21 | #include "shill/nice_mock_control.h" |
| 22 | #include "shill/proxy_factory.h" |
mukesh agrawal | cbfb34e | 2013-04-17 19:33:25 -0700 | [diff] [blame] | 23 | #include "shill/service_property_change_test.h" |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 24 | |
Darin Petkov | 3133241 | 2012-01-28 01:50:02 +0100 | [diff] [blame] | 25 | using std::string; |
Darin Petkov | 9cb0268 | 2012-01-28 00:17:38 +0100 | [diff] [blame] | 26 | using testing::_; |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 27 | using testing::InSequence; |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 28 | using testing::Mock; |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 29 | using testing::NiceMock; |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 30 | using testing::Return; |
mukesh agrawal | a70ec27 | 2013-08-19 16:08:31 -0700 | [diff] [blame] | 31 | using testing::SetArgumentPointee; |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 32 | |
| 33 | namespace shill { |
| 34 | |
| 35 | class CellularServiceTest : public testing::Test { |
| 36 | public: |
| 37 | CellularServiceTest() |
Ben Chan | ea18c6c | 2014-09-30 13:08:26 -0700 | [diff] [blame] | 38 | : modem_info_(nullptr, &dispatcher_, nullptr, nullptr, nullptr), |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 39 | device_(new MockCellular(&modem_info_, |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 40 | "usb0", |
| 41 | kAddress, |
| 42 | 3, |
| 43 | Cellular::kTypeCDMA, |
| 44 | "", |
| 45 | "", |
| 46 | "", |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 47 | ProxyFactory::GetInstance())), |
Prathmesh Prabhu | 0d36b4f | 2013-04-01 11:45:54 -0700 | [diff] [blame] | 48 | service_(new CellularService(&modem_info_, device_)), |
Ben Chan | ea18c6c | 2014-09-30 13:08:26 -0700 | [diff] [blame] | 49 | adaptor_(nullptr) {} |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 50 | |
| 51 | virtual ~CellularServiceTest() { |
Ben Chan | ea18c6c | 2014-09-30 13:08:26 -0700 | [diff] [blame] | 52 | adaptor_ = nullptr; |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 53 | } |
| 54 | |
| 55 | virtual void SetUp() { |
| 56 | adaptor_ = |
Paul Stewart | 2f6c789 | 2015-06-16 13:13:10 -0700 | [diff] [blame^] | 57 | dynamic_cast<ServiceMockAdaptor*>(service_->adaptor()); |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 58 | out_of_credits_detector_ = |
Alex Vakulenko | 0951ccb | 2014-12-10 12:52:31 -0800 | [diff] [blame] | 59 | new MockOutOfCreditsDetector(nullptr, nullptr, nullptr, service_.get()); |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 60 | // Passes ownership. |
| 61 | service_->set_out_of_credits_detector(out_of_credits_detector_); |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 62 | } |
| 63 | |
Paul Stewart | 2f6c789 | 2015-06-16 13:13:10 -0700 | [diff] [blame^] | 64 | CellularCapabilityCDMA* GetCapabilityCDMA() { |
| 65 | return dynamic_cast<CellularCapabilityCDMA*>(device_->capability_.get()); |
Jason Glasgow | 82f9ab3 | 2012-04-04 14:27:19 -0400 | [diff] [blame] | 66 | } |
| 67 | |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 68 | protected: |
Darin Petkov | 3133241 | 2012-01-28 01:50:02 +0100 | [diff] [blame] | 69 | static const char kAddress[]; |
| 70 | |
Darin Petkov | 457728b | 2013-01-09 09:49:08 +0100 | [diff] [blame] | 71 | string GetFriendlyName() const { return service_->friendly_name(); } |
| 72 | |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 73 | EventDispatcher dispatcher_; |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 74 | MockModemInfo modem_info_; |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 75 | scoped_refptr<MockCellular> device_; |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 76 | CellularServiceRefPtr service_; |
Paul Stewart | 2f6c789 | 2015-06-16 13:13:10 -0700 | [diff] [blame^] | 77 | ServiceMockAdaptor* adaptor_; // Owned by |service_|. |
| 78 | MockOutOfCreditsDetector* out_of_credits_detector_; // Owned by |service_|. |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 79 | }; |
| 80 | |
Darin Petkov | 3133241 | 2012-01-28 01:50:02 +0100 | [diff] [blame] | 81 | const char CellularServiceTest::kAddress[] = "000102030405"; |
| 82 | |
Thieu Le | 9fdf137 | 2012-05-14 15:20:48 -0700 | [diff] [blame] | 83 | TEST_F(CellularServiceTest, Constructor) { |
| 84 | EXPECT_TRUE(service_->connectable()); |
| 85 | } |
| 86 | |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 87 | TEST_F(CellularServiceTest, SetActivationState) { |
| 88 | { |
| 89 | InSequence call_sequence; |
| 90 | EXPECT_CALL(*adaptor_, EmitStringChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 91 | kActivationStateProperty, |
| 92 | kActivationStateNotActivated)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 93 | EXPECT_CALL(*adaptor_, EmitBoolChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 94 | kConnectableProperty, false)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 95 | EXPECT_CALL(*adaptor_, EmitStringChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 96 | kActivationStateProperty, |
| 97 | kActivationStateActivating)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 98 | EXPECT_CALL(*adaptor_, EmitBoolChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 99 | kConnectableProperty, true)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 100 | EXPECT_CALL(*adaptor_, EmitStringChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 101 | kActivationStateProperty, |
| 102 | kActivationStatePartiallyActivated)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 103 | EXPECT_CALL(*adaptor_, EmitStringChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 104 | kActivationStateProperty, |
| 105 | kActivationStateActivated)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 106 | EXPECT_CALL(*adaptor_, EmitStringChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 107 | kActivationStateProperty, |
| 108 | kActivationStateNotActivated)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 109 | EXPECT_CALL(*adaptor_, EmitBoolChanged( |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 110 | kConnectableProperty, false)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 111 | } |
Prathmesh Prabhu | 0d36b4f | 2013-04-01 11:45:54 -0700 | [diff] [blame] | 112 | EXPECT_CALL(*modem_info_.mock_manager(), HasService(_)) |
| 113 | .WillRepeatedly(Return(false)); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 114 | |
| 115 | EXPECT_TRUE(service_->activation_state().empty()); |
| 116 | EXPECT_TRUE(service_->connectable()); |
| 117 | |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 118 | service_->SetActivationState(kActivationStateNotActivated); |
| 119 | EXPECT_EQ(kActivationStateNotActivated, service_->activation_state()); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 120 | EXPECT_FALSE(service_->connectable()); |
| 121 | |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 122 | service_->SetActivationState(kActivationStateActivating); |
| 123 | EXPECT_EQ(kActivationStateActivating, service_->activation_state()); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 124 | EXPECT_TRUE(service_->connectable()); |
| 125 | |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 126 | service_->SetActivationState(kActivationStatePartiallyActivated); |
| 127 | EXPECT_EQ(kActivationStatePartiallyActivated, service_->activation_state()); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 128 | EXPECT_TRUE(service_->connectable()); |
| 129 | |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 130 | service_->SetActivationState(kActivationStateActivated); |
| 131 | EXPECT_EQ(kActivationStateActivated, service_->activation_state()); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 132 | EXPECT_TRUE(service_->connectable()); |
| 133 | |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 134 | service_->SetActivationState(kActivationStateNotActivated); |
| 135 | EXPECT_EQ(kActivationStateNotActivated, service_->activation_state()); |
Ben Chan | 9658044 | 2012-09-19 16:19:39 -0700 | [diff] [blame] | 136 | EXPECT_FALSE(service_->connectable()); |
| 137 | } |
| 138 | |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 139 | TEST_F(CellularServiceTest, SetNetworkTechnology) { |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 140 | EXPECT_CALL(*adaptor_, EmitStringChanged(kNetworkTechnologyProperty, |
| 141 | kNetworkTechnologyUmts)); |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 142 | EXPECT_TRUE(service_->network_technology().empty()); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 143 | service_->SetNetworkTechnology(kNetworkTechnologyUmts); |
| 144 | EXPECT_EQ(kNetworkTechnologyUmts, service_->network_technology()); |
| 145 | service_->SetNetworkTechnology(kNetworkTechnologyUmts); |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 146 | } |
| 147 | |
| 148 | TEST_F(CellularServiceTest, SetRoamingState) { |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 149 | EXPECT_CALL(*adaptor_, EmitStringChanged(kRoamingStateProperty, |
| 150 | kRoamingStateHome)); |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 151 | EXPECT_TRUE(service_->roaming_state().empty()); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 152 | service_->SetRoamingState(kRoamingStateHome); |
| 153 | EXPECT_EQ(kRoamingStateHome, service_->roaming_state()); |
| 154 | service_->SetRoamingState(kRoamingStateHome); |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 155 | } |
| 156 | |
Darin Petkov | 3133241 | 2012-01-28 01:50:02 +0100 | [diff] [blame] | 157 | TEST_F(CellularServiceTest, SetStorageIdentifier) { |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 158 | EXPECT_EQ(string(kTypeCellular) + "_" + |
Darin Petkov | 457728b | 2013-01-09 09:49:08 +0100 | [diff] [blame] | 159 | kAddress + "_" + GetFriendlyName(), |
Darin Petkov | 3133241 | 2012-01-28 01:50:02 +0100 | [diff] [blame] | 160 | service_->GetStorageIdentifier()); |
| 161 | service_->SetStorageIdentifier("a b c"); |
| 162 | EXPECT_EQ("a_b_c", service_->GetStorageIdentifier()); |
| 163 | } |
| 164 | |
Darin Petkov | 9cb0268 | 2012-01-28 00:17:38 +0100 | [diff] [blame] | 165 | TEST_F(CellularServiceTest, SetServingOperator) { |
Darin Petkov | 9cb0268 | 2012-01-28 00:17:38 +0100 | [diff] [blame] | 166 | static const char kCode[] = "123456"; |
| 167 | static const char kName[] = "Some Cellular Operator"; |
Roshan Pius | ec77f59 | 2014-10-29 15:07:38 -0700 | [diff] [blame] | 168 | Stringmap test_operator; |
| 169 | service_->set_serving_operator(test_operator); |
| 170 | test_operator[kOperatorCodeKey] = kCode; |
| 171 | test_operator[kOperatorNameKey] = kName; |
| 172 | EXPECT_CALL(*adaptor_, |
| 173 | EmitStringmapChanged(kServingOperatorProperty, _)); |
| 174 | service_->set_serving_operator(test_operator); |
Paul Stewart | 2f6c789 | 2015-06-16 13:13:10 -0700 | [diff] [blame^] | 175 | const Stringmap& serving_operator = service_->serving_operator(); |
Roshan Pius | ec77f59 | 2014-10-29 15:07:38 -0700 | [diff] [blame] | 176 | ASSERT_NE(serving_operator.end(), serving_operator.find(kOperatorCodeKey)); |
| 177 | ASSERT_NE(serving_operator.end(), serving_operator.find(kOperatorNameKey)); |
| 178 | EXPECT_EQ(kCode, serving_operator.find(kOperatorCodeKey)->second); |
| 179 | EXPECT_EQ(kName, serving_operator.find(kOperatorNameKey)->second); |
| 180 | Mock::VerifyAndClearExpectations(adaptor_); |
| 181 | EXPECT_CALL(*adaptor_, |
| 182 | EmitStringmapChanged(kServingOperatorProperty, _)).Times(0); |
| 183 | service_->set_serving_operator(serving_operator); |
Darin Petkov | 9cb0268 | 2012-01-28 00:17:38 +0100 | [diff] [blame] | 184 | } |
| 185 | |
Darin Petkov | 381928f | 2012-02-02 23:00:12 +0100 | [diff] [blame] | 186 | TEST_F(CellularServiceTest, SetOLP) { |
Prathmesh Prabhu | 92df619 | 2014-04-29 18:08:08 -0700 | [diff] [blame] | 187 | const char kMethod[] = "GET"; |
| 188 | const char kURL[] = "payment.url"; |
| 189 | const char kPostData[] = "post_man"; |
| 190 | Stringmap olp; |
| 191 | |
| 192 | service_->SetOLP("", "", ""); |
| 193 | olp = service_->olp(); // Copy to simplify assertions below. |
| 194 | EXPECT_EQ("", olp[kPaymentPortalURL]); |
| 195 | EXPECT_EQ("", olp[kPaymentPortalMethod]); |
| 196 | EXPECT_EQ("", olp[kPaymentPortalPostData]); |
| 197 | |
Darin Petkov | 381928f | 2012-02-02 23:00:12 +0100 | [diff] [blame] | 198 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 199 | EmitStringmapChanged(kPaymentPortalProperty, _)); |
Prathmesh Prabhu | 92df619 | 2014-04-29 18:08:08 -0700 | [diff] [blame] | 200 | service_->SetOLP(kURL, kMethod, kPostData); |
| 201 | olp = service_->olp(); // Copy to simplify assertions below. |
| 202 | EXPECT_EQ(kURL, olp[kPaymentPortalURL]); |
| 203 | EXPECT_EQ(kMethod, olp[kPaymentPortalMethod]); |
| 204 | EXPECT_EQ(kPostData, olp[kPaymentPortalPostData]); |
Darin Petkov | 381928f | 2012-02-02 23:00:12 +0100 | [diff] [blame] | 205 | } |
| 206 | |
| 207 | TEST_F(CellularServiceTest, SetUsageURL) { |
| 208 | static const char kUsageURL[] = "usage.url"; |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 209 | EXPECT_CALL(*adaptor_, EmitStringChanged(kUsageURLProperty, |
Darin Petkov | 381928f | 2012-02-02 23:00:12 +0100 | [diff] [blame] | 210 | kUsageURL)); |
| 211 | EXPECT_TRUE(service_->usage_url().empty()); |
| 212 | service_->SetUsageURL(kUsageURL); |
| 213 | EXPECT_EQ(kUsageURL, service_->usage_url()); |
| 214 | service_->SetUsageURL(kUsageURL); |
| 215 | } |
| 216 | |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 217 | TEST_F(CellularServiceTest, SetApn) { |
| 218 | static const char kApn[] = "TheAPN"; |
| 219 | static const char kUsername[] = "commander.data"; |
| 220 | ProfileRefPtr profile(new NiceMock<MockProfile>( |
Prathmesh Prabhu | 0d36b4f | 2013-04-01 11:45:54 -0700 | [diff] [blame] | 221 | modem_info_.control_interface(), modem_info_.metrics(), |
| 222 | modem_info_.manager())); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 223 | service_->set_profile(profile); |
| 224 | Error error; |
| 225 | Stringmap testapn; |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 226 | testapn[kApnProperty] = kApn; |
| 227 | testapn[kApnUsernameProperty] = kUsername; |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 228 | { |
| 229 | InSequence seq; |
| 230 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 231 | EmitStringmapChanged(kCellularLastGoodApnProperty, |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 232 | _)); |
| 233 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 234 | EmitStringmapChanged(kCellularApnProperty, _)); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 235 | } |
| 236 | service_->SetApn(testapn, &error); |
| 237 | EXPECT_TRUE(error.IsSuccess()); |
| 238 | Stringmap resultapn = service_->GetApn(&error); |
| 239 | EXPECT_TRUE(error.IsSuccess()); |
| 240 | EXPECT_EQ(2, resultapn.size()); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 241 | Stringmap::const_iterator it = resultapn.find(kApnProperty); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 242 | EXPECT_TRUE(it != resultapn.end() && it->second == kApn); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 243 | it = resultapn.find(kApnUsernameProperty); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 244 | EXPECT_TRUE(it != resultapn.end() && it->second == kUsername); |
Ben Chan | ea18c6c | 2014-09-30 13:08:26 -0700 | [diff] [blame] | 245 | EXPECT_NE(nullptr, service_->GetUserSpecifiedApn()); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 246 | } |
| 247 | |
| 248 | TEST_F(CellularServiceTest, ClearApn) { |
| 249 | static const char kApn[] = "TheAPN"; |
| 250 | static const char kUsername[] = "commander.data"; |
| 251 | ProfileRefPtr profile(new NiceMock<MockProfile>( |
Prathmesh Prabhu | 0d36b4f | 2013-04-01 11:45:54 -0700 | [diff] [blame] | 252 | modem_info_.control_interface(), modem_info_.metrics(), |
| 253 | modem_info_.manager())); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 254 | service_->set_profile(profile); |
| 255 | Error error; |
| 256 | // Set up an APN to make sure that it later gets cleared. |
| 257 | Stringmap testapn; |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 258 | testapn[kApnProperty] = kApn; |
| 259 | testapn[kApnUsernameProperty] = kUsername; |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 260 | { |
| 261 | InSequence seq; |
| 262 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 263 | EmitStringmapChanged(kCellularLastGoodApnProperty, |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 264 | _)); |
| 265 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 266 | EmitStringmapChanged(kCellularApnProperty, _)); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 267 | } |
| 268 | service_->SetApn(testapn, &error); |
| 269 | Stringmap resultapn = service_->GetApn(&error); |
| 270 | ASSERT_TRUE(error.IsSuccess()); |
| 271 | ASSERT_EQ(2, service_->GetApn(&error).size()); |
| 272 | |
| 273 | Stringmap emptyapn; |
| 274 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 275 | EmitStringmapChanged(kCellularLastGoodApnProperty, |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 276 | _)).Times(0); |
| 277 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 278 | EmitStringmapChanged(kCellularApnProperty, _)).Times(1); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 279 | service_->SetApn(emptyapn, &error); |
| 280 | EXPECT_TRUE(error.IsSuccess()); |
| 281 | resultapn = service_->GetApn(&error); |
| 282 | EXPECT_TRUE(resultapn.empty()); |
Ben Chan | ea18c6c | 2014-09-30 13:08:26 -0700 | [diff] [blame] | 283 | EXPECT_EQ(nullptr, service_->GetUserSpecifiedApn());; |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 284 | } |
| 285 | |
| 286 | TEST_F(CellularServiceTest, LastGoodApn) { |
| 287 | static const char kApn[] = "TheAPN"; |
| 288 | static const char kUsername[] = "commander.data"; |
| 289 | ProfileRefPtr profile(new NiceMock<MockProfile>( |
Prathmesh Prabhu | 0d36b4f | 2013-04-01 11:45:54 -0700 | [diff] [blame] | 290 | modem_info_.control_interface(), modem_info_.metrics(), |
| 291 | modem_info_.manager())); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 292 | service_->set_profile(profile); |
| 293 | Stringmap testapn; |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 294 | testapn[kApnProperty] = kApn; |
| 295 | testapn[kApnUsernameProperty] = kUsername; |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 296 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 297 | EmitStringmapChanged(kCellularLastGoodApnProperty, _)); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 298 | service_->SetLastGoodApn(testapn); |
Paul Stewart | 2f6c789 | 2015-06-16 13:13:10 -0700 | [diff] [blame^] | 299 | Stringmap* resultapn = service_->GetLastGoodApn(); |
Ben Chan | ea18c6c | 2014-09-30 13:08:26 -0700 | [diff] [blame] | 300 | EXPECT_NE(nullptr, resultapn); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 301 | EXPECT_EQ(2, resultapn->size()); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 302 | Stringmap::const_iterator it = resultapn->find(kApnProperty); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 303 | EXPECT_TRUE(it != resultapn->end() && it->second == kApn); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 304 | it = resultapn->find(kApnUsernameProperty); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 305 | EXPECT_TRUE(it != resultapn->end() && it->second == kUsername); |
| 306 | // Now set the user-specified APN, and check that LastGoodApn got |
| 307 | // cleared. |
| 308 | Stringmap userapn; |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 309 | userapn[kApnProperty] = kApn; |
| 310 | userapn[kApnUsernameProperty] = kUsername; |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 311 | { |
| 312 | InSequence seq; |
| 313 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 314 | EmitStringmapChanged(kCellularLastGoodApnProperty, |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 315 | _)); |
| 316 | EXPECT_CALL(*adaptor_, |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 317 | EmitStringmapChanged(kCellularApnProperty, _)); |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 318 | } |
| 319 | Error error; |
| 320 | service_->SetApn(userapn, &error); |
Ben Chan | ea18c6c | 2014-09-30 13:08:26 -0700 | [diff] [blame] | 321 | EXPECT_EQ(nullptr, service_->GetLastGoodApn());; |
Eric Shienbrood | c707330 | 2012-04-03 14:41:44 -0400 | [diff] [blame] | 322 | } |
| 323 | |
Ben Chan | 19f8397 | 2012-10-03 23:25:56 -0700 | [diff] [blame] | 324 | TEST_F(CellularServiceTest, IsAutoConnectable) { |
Paul Stewart | 2f6c789 | 2015-06-16 13:13:10 -0700 | [diff] [blame^] | 325 | const char* reason = nullptr; |
Ben Chan | 19f8397 | 2012-10-03 23:25:56 -0700 | [diff] [blame] | 326 | |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 327 | ON_CALL(*out_of_credits_detector_, IsDetecting()) |
| 328 | .WillByDefault(Return(false)); |
| 329 | |
Ben Chan | 19f8397 | 2012-10-03 23:25:56 -0700 | [diff] [blame] | 330 | // Auto-connect should be suppressed if the device is not running. |
| 331 | device_->running_ = false; |
| 332 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 333 | EXPECT_STREQ(CellularService::kAutoConnDeviceDisabled, reason); |
| 334 | |
| 335 | device_->running_ = true; |
| 336 | |
Christopher Wiley | 1582bdd | 2012-11-15 11:31:14 -0800 | [diff] [blame] | 337 | // If we're waiting on a disconnect before an activation, don't auto-connect. |
| 338 | GetCapabilityCDMA()->activation_starting_ = true; |
| 339 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 340 | |
| 341 | // If we're waiting on an activation, also don't auto-connect. |
| 342 | GetCapabilityCDMA()->activation_starting_ = false; |
| 343 | GetCapabilityCDMA()->activation_state_ = |
| 344 | MM_MODEM_CDMA_ACTIVATION_STATE_ACTIVATING; |
| 345 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 346 | |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 347 | GetCapabilityCDMA()->activation_state_ = |
| 348 | MM_MODEM_CDMA_ACTIVATION_STATE_ACTIVATED; |
| 349 | |
| 350 | // Auto-connect should be suppressed if the we're undergoing an |
| 351 | // out-of-credits detection. |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 352 | EXPECT_CALL(*out_of_credits_detector_, IsDetecting()) |
| 353 | .WillOnce(Return(true)); |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 354 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 355 | EXPECT_STREQ(CellularService::kAutoConnOutOfCreditsDetectionInProgress, |
| 356 | reason); |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 357 | Mock::VerifyAndClearExpectations(out_of_credits_detector_); |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 358 | |
| 359 | // Auto-connect should be suppressed if we're out of credits. |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 360 | EXPECT_CALL(*out_of_credits_detector_, IsDetecting()) |
| 361 | .WillOnce(Return(false)); |
| 362 | EXPECT_CALL(*out_of_credits_detector_, out_of_credits()) |
| 363 | .WillOnce(Return(true)); |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 364 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 365 | EXPECT_STREQ(CellularService::kAutoConnOutOfCredits, reason); |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 366 | Mock::VerifyAndClearExpectations(out_of_credits_detector_); |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 367 | |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 368 | EXPECT_CALL(*out_of_credits_detector_, out_of_credits()) |
| 369 | .WillRepeatedly(Return(false)); |
Thieu Le | 398b1da | 2013-03-11 17:31:10 -0700 | [diff] [blame] | 370 | |
Christopher Wiley | 1582bdd | 2012-11-15 11:31:14 -0800 | [diff] [blame] | 371 | // But other activation states are fine. |
| 372 | GetCapabilityCDMA()->activation_state_ = |
| 373 | MM_MODEM_CDMA_ACTIVATION_STATE_ACTIVATED; |
| 374 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 375 | GetCapabilityCDMA()->activation_state_ = |
| 376 | MM_MODEM_CDMA_ACTIVATION_STATE_NOT_ACTIVATED; |
| 377 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 378 | GetCapabilityCDMA()->activation_state_ = |
| 379 | MM_MODEM_CDMA_ACTIVATION_STATE_PARTIALLY_ACTIVATED; |
| 380 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 381 | |
mukesh agrawal | d477388 | 2013-08-14 17:21:14 -0700 | [diff] [blame] | 382 | // A PPP authentication failure means the Service is not auto-connectable. |
| 383 | service_->SetFailure(Service::kFailurePPPAuth); |
| 384 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 385 | |
| 386 | // Reset failure state, to make the Service auto-connectable again. |
| 387 | service_->SetState(Service::kStateIdle); |
| 388 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 389 | |
Ben Chan | 19f8397 | 2012-10-03 23:25:56 -0700 | [diff] [blame] | 390 | // The following test cases are copied from ServiceTest.IsAutoConnectable |
| 391 | |
mukesh agrawal | cbfb34e | 2013-04-17 19:33:25 -0700 | [diff] [blame] | 392 | service_->SetConnectable(true); |
Ben Chan | 19f8397 | 2012-10-03 23:25:56 -0700 | [diff] [blame] | 393 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 394 | |
| 395 | // We should not auto-connect to a Service that a user has |
| 396 | // deliberately disconnected. |
| 397 | Error error; |
| 398 | service_->UserInitiatedDisconnect(&error); |
| 399 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 400 | EXPECT_STREQ(Service::kAutoConnExplicitDisconnect, reason); |
| 401 | |
| 402 | // But if the Service is reloaded, it is eligible for auto-connect |
| 403 | // again. |
| 404 | NiceMock<MockStore> storage; |
| 405 | EXPECT_CALL(storage, ContainsGroup(service_->GetStorageIdentifier())) |
| 406 | .WillOnce(Return(true)); |
| 407 | EXPECT_TRUE(service_->Load(&storage)); |
| 408 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 409 | |
| 410 | // A non-user initiated Disconnect doesn't change anything. |
Samuel Tan | 0d06119 | 2014-07-07 15:45:15 -0700 | [diff] [blame] | 411 | service_->Disconnect(&error, "in test"); |
Ben Chan | 19f8397 | 2012-10-03 23:25:56 -0700 | [diff] [blame] | 412 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 413 | |
| 414 | // A resume also re-enables auto-connect. |
| 415 | service_->UserInitiatedDisconnect(&error); |
| 416 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 417 | service_->OnAfterResume(); |
| 418 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
| 419 | |
| 420 | service_->SetState(Service::kStateConnected); |
| 421 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 422 | EXPECT_STREQ(Service::kAutoConnConnected, reason); |
| 423 | |
| 424 | service_->SetState(Service::kStateAssociating); |
| 425 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 426 | EXPECT_STREQ(Service::kAutoConnConnecting, reason); |
| 427 | } |
| 428 | |
mukesh agrawal | a70ec27 | 2013-08-19 16:08:31 -0700 | [diff] [blame] | 429 | TEST_F(CellularServiceTest, LoadResetsPPPAuthFailure) { |
| 430 | NiceMock<MockStore> storage; |
| 431 | EXPECT_CALL(storage, ContainsGroup(_)).WillRepeatedly(Return(true)); |
| 432 | EXPECT_CALL(storage, GetString(_, _, _)).WillRepeatedly(Return(true)); |
| 433 | |
| 434 | const string kDefaultUser; |
| 435 | const string kDefaultPass; |
| 436 | const string kNewUser("new-username"); |
| 437 | const string kNewPass("new-password"); |
| 438 | for (const auto change_username : { false, true }) { |
| 439 | for (const auto change_password : { false, true }) { |
| 440 | service_->ppp_username_ = kDefaultUser; |
| 441 | service_->ppp_password_ = kDefaultPass; |
| 442 | service_->SetFailure(Service::kFailurePPPAuth); |
| 443 | EXPECT_TRUE(service_->IsFailed()); |
| 444 | EXPECT_EQ(Service::kFailurePPPAuth, service_->failure()); |
| 445 | if (change_username) { |
| 446 | EXPECT_CALL(storage, |
| 447 | GetString(_, CellularService::kStoragePPPUsername, _)) |
| 448 | .WillOnce(DoAll(SetArgumentPointee<2>(kNewUser), Return(true))) |
| 449 | .RetiresOnSaturation(); |
| 450 | } |
| 451 | if (change_password) { |
| 452 | EXPECT_CALL(storage, |
| 453 | GetString(_, CellularService::kStoragePPPPassword, _)) |
| 454 | .WillOnce(DoAll(SetArgumentPointee<2>(kNewPass), Return(true))) |
| 455 | .RetiresOnSaturation(); |
| 456 | } |
| 457 | EXPECT_TRUE(service_->Load(&storage)); |
| 458 | if (change_username || change_password) { |
| 459 | EXPECT_NE(Service::kFailurePPPAuth, service_->failure()); |
| 460 | } else { |
| 461 | EXPECT_EQ(Service::kFailurePPPAuth, service_->failure()); |
| 462 | } |
| 463 | } |
| 464 | } |
| 465 | } |
| 466 | |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 467 | // Some of these tests duplicate signals tested above. However, it's |
| 468 | // convenient to have all the property change notifications documented |
| 469 | // (and tested) in one place. |
mukesh agrawal | cbfb34e | 2013-04-17 19:33:25 -0700 | [diff] [blame] | 470 | TEST_F(CellularServiceTest, PropertyChanges) { |
| 471 | TestCommonPropertyChanges(service_, adaptor_); |
| 472 | TestAutoConnectPropertyChange(service_, adaptor_); |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 473 | |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 474 | EXPECT_CALL(*adaptor_, |
Thieu Le | 71f81a6 | 2014-07-11 15:17:47 -0700 | [diff] [blame] | 475 | EmitStringChanged(kActivationTypeProperty, _)); |
| 476 | service_->SetActivationType(CellularService::kActivationTypeOTA); |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 477 | Mock::VerifyAndClearExpectations(adaptor_); |
| 478 | |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 479 | EXPECT_NE(kActivationStateNotActivated, service_->activation_state()); |
| 480 | EXPECT_CALL(*adaptor_, EmitStringChanged(kActivationStateProperty, _)); |
| 481 | service_->SetActivationState(kActivationStateNotActivated); |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 482 | Mock::VerifyAndClearExpectations(adaptor_); |
| 483 | |
| 484 | string network_technology = service_->network_technology(); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 485 | EXPECT_CALL(*adaptor_, EmitStringChanged(kNetworkTechnologyProperty, _)); |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 486 | service_->SetNetworkTechnology(network_technology + "and some new stuff"); |
| 487 | Mock::VerifyAndClearExpectations(adaptor_); |
| 488 | |
Thieu Le | 43ce4d4 | 2013-10-04 16:08:55 -0700 | [diff] [blame] | 489 | bool out_of_credits = true; |
| 490 | EXPECT_CALL(*adaptor_, |
| 491 | EmitBoolChanged(kOutOfCreditsProperty, out_of_credits)); |
| 492 | service_->SignalOutOfCreditsChanged(out_of_credits); |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 493 | Mock::VerifyAndClearExpectations(adaptor_); |
| 494 | |
| 495 | string roaming_state = service_->roaming_state(); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 496 | EXPECT_CALL(*adaptor_, EmitStringChanged(kRoamingStateProperty, _)); |
mukesh agrawal | 81599e0 | 2013-04-22 16:40:00 -0700 | [diff] [blame] | 497 | service_->SetRoamingState(roaming_state + "and some new stuff"); |
| 498 | Mock::VerifyAndClearExpectations(adaptor_); |
mukesh agrawal | cbfb34e | 2013-04-17 19:33:25 -0700 | [diff] [blame] | 499 | } |
| 500 | |
mukesh agrawal | bebf1b8 | 2013-04-23 15:06:33 -0700 | [diff] [blame] | 501 | // Custom property setters should return false, and make no changes, if |
| 502 | // the new value is the same as the old value. |
| 503 | TEST_F(CellularServiceTest, CustomSetterNoopChange) { |
| 504 | // Test that we didn't break any setters provided by the base class. |
| 505 | TestCustomSetterNoopChange(service_, modem_info_.mock_manager()); |
| 506 | |
| 507 | // Test the new setter we added. |
| 508 | // First set up our environment... |
| 509 | static const char kApn[] = "TheAPN"; |
| 510 | static const char kUsername[] = "commander.data"; |
| 511 | Error error; |
| 512 | Stringmap testapn; |
| 513 | ProfileRefPtr profile(new NiceMock<MockProfile>(nullptr, nullptr, nullptr)); |
| 514 | service_->set_profile(profile); |
Ben Chan | 7ea768e | 2013-09-20 15:08:40 -0700 | [diff] [blame] | 515 | testapn[kApnProperty] = kApn; |
| 516 | testapn[kApnUsernameProperty] = kUsername; |
mukesh agrawal | bebf1b8 | 2013-04-23 15:06:33 -0700 | [diff] [blame] | 517 | // ... then set to a known value ... |
| 518 | EXPECT_TRUE(service_->SetApn(testapn, &error)); |
| 519 | EXPECT_TRUE(error.IsSuccess()); |
| 520 | // ... then set to same value. |
| 521 | EXPECT_FALSE(service_->SetApn(testapn, &error)); |
| 522 | EXPECT_TRUE(error.IsSuccess()); |
| 523 | } |
| 524 | |
Darin Petkov | b72cf40 | 2011-11-22 14:51:39 +0100 | [diff] [blame] | 525 | } // namespace shill |