Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "shill/wimax.h" |
| 6 | |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 7 | #include <base/bind.h> |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 8 | #include <base/string_util.h> |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 9 | #include <base/stringprintf.h> |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 10 | |
Darin Petkov | 25665aa | 2012-05-21 14:08:12 +0200 | [diff] [blame] | 11 | #include "shill/key_value_store.h" |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 12 | #include "shill/manager.h" |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 13 | #include "shill/proxy_factory.h" |
| 14 | #include "shill/scope_logger.h" |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 15 | #include "shill/store_interface.h" |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 16 | #include "shill/wimax_device_proxy_interface.h" |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 17 | #include "shill/wimax_service.h" |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 18 | |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 19 | using base::Bind; |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 20 | using std::set; |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 21 | using std::string; |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 22 | using std::vector; |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 23 | |
| 24 | namespace shill { |
| 25 | |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 26 | const int WiMax::kTimeoutDefault = 30000; |
| 27 | |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 28 | WiMax::WiMax(ControlInterface *control, |
| 29 | EventDispatcher *dispatcher, |
| 30 | Metrics *metrics, |
| 31 | Manager *manager, |
| 32 | const string &link_name, |
Ben Chan | 4e64d2d | 2012-05-16 00:02:25 -0700 | [diff] [blame] | 33 | const string &address, |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 34 | int interface_index, |
| 35 | const RpcIdentifier &path) |
Ben Chan | 4e64d2d | 2012-05-16 00:02:25 -0700 | [diff] [blame] | 36 | : Device(control, dispatcher, metrics, manager, link_name, address, |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 37 | interface_index, Technology::kWiMax), |
| 38 | path_(path), |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 39 | scanning_(false), |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 40 | proxy_factory_(ProxyFactory::GetInstance()) { |
| 41 | SLOG(WiMax, 2) << __func__ << "(" << link_name << ", " << path << ")"; |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 42 | PropertyStore *store = mutable_store(); |
| 43 | store->RegisterConstBool(flimflam::kScanningProperty, &scanning_); |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 44 | } |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 45 | |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 46 | WiMax::~WiMax() { |
| 47 | SLOG(WiMax, 2) << __func__ << "(" << link_name() << ", " << path_ << ")"; |
| 48 | } |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 49 | |
| 50 | void WiMax::Start(Error *error, const EnabledStateChangedCallback &callback) { |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 51 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 52 | scanning_ = false; |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 53 | proxy_.reset(proxy_factory_->CreateWiMaxDeviceProxy(path_)); |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 54 | proxy_->set_networks_changed_callback( |
| 55 | Bind(&WiMax::OnNetworksChanged, Unretained(this))); |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 56 | proxy_->Enable( |
| 57 | error, Bind(&WiMax::OnEnableComplete, this, callback), kTimeoutDefault); |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 58 | } |
| 59 | |
| 60 | void WiMax::Stop(Error *error, const EnabledStateChangedCallback &callback) { |
Darin Petkov | b72b62e | 2012-05-15 16:55:36 +0200 | [diff] [blame] | 61 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 62 | networks_.clear(); |
| 63 | StopDeadServices(); |
| 64 | DestroyAllServices(); |
| 65 | services_.clear(); |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 66 | proxy_->Disable( |
| 67 | error, Bind(&WiMax::OnDisableComplete, this, callback), kTimeoutDefault); |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 68 | } |
| 69 | |
| 70 | bool WiMax::TechnologyIs(const Technology::Identifier type) const { |
| 71 | return type == Technology::kWiMax; |
| 72 | } |
| 73 | |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 74 | void WiMax::Scan(Error *error) { |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 75 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 76 | if (scanning_) { |
| 77 | Error::PopulateAndLog( |
| 78 | error, Error::kInProgress, "Scan already in progress."); |
| 79 | return; |
| 80 | } |
| 81 | scanning_ = true; |
| 82 | proxy_->ScanNetworks( |
| 83 | error, Bind(&WiMax::OnScanNetworksComplete, this), kTimeoutDefault); |
| 84 | if (error->IsFailure()) { |
| 85 | OnScanNetworksComplete(*error); |
| 86 | } |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 87 | } |
| 88 | |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 89 | void WiMax::ConnectTo(const WiMaxServiceRefPtr &service, Error *error) { |
| 90 | SLOG(WiMax, 2) << __func__ << "(" << service->friendly_name() << ")"; |
| 91 | if (pending_service_) { |
| 92 | Error::PopulateAndLog( |
| 93 | error, Error::kInProgress, |
| 94 | base::StringPrintf( |
| 95 | "Pending connect to %s, ignoring connect request to %s.", |
| 96 | pending_service_->friendly_name().c_str(), |
| 97 | service->friendly_name().c_str())); |
| 98 | return; |
| 99 | } |
| 100 | service->SetState(Service::kStateAssociating); |
| 101 | pending_service_ = service; |
Ben Chan | 4e5c131 | 2012-05-18 18:45:38 -0700 | [diff] [blame] | 102 | |
Darin Petkov | 25665aa | 2012-05-21 14:08:12 +0200 | [diff] [blame] | 103 | KeyValueStore parameters; |
Ben Chan | 4e5c131 | 2012-05-18 18:45:38 -0700 | [diff] [blame] | 104 | service->GetConnectParameters(¶meters); |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 105 | proxy_->Connect( |
Ben Chan | 4e5c131 | 2012-05-18 18:45:38 -0700 | [diff] [blame] | 106 | service->GetNetworkObjectPath(), parameters, |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 107 | error, Bind(&WiMax::OnConnectComplete, this), kTimeoutDefault); |
| 108 | if (error->IsFailure()) { |
| 109 | OnConnectComplete(*error); |
| 110 | } |
| 111 | } |
| 112 | |
| 113 | void WiMax::DisconnectFrom(const WiMaxServiceRefPtr &service, Error *error) { |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 114 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 115 | if (pending_service_) { |
| 116 | Error::PopulateAndLog( |
| 117 | error, Error::kInProgress, |
| 118 | base::StringPrintf( |
| 119 | "Pending connect to %s, ignoring disconnect request from %s.", |
| 120 | pending_service_->friendly_name().c_str(), |
| 121 | service->friendly_name().c_str())); |
| 122 | return; |
| 123 | } |
| 124 | if (selected_service() && service != selected_service()) { |
| 125 | Error::PopulateAndLog( |
| 126 | error, Error::kNotConnected, |
| 127 | base::StringPrintf( |
| 128 | "Curent service is %s, ignoring disconnect request from %s.", |
| 129 | selected_service()->friendly_name().c_str(), |
| 130 | service->friendly_name().c_str())); |
| 131 | return; |
| 132 | } |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 133 | proxy_->Disconnect( |
| 134 | error, Bind(&WiMax::OnDisconnectComplete, this), kTimeoutDefault); |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 135 | if (error->IsFailure()) { |
| 136 | OnDisconnectComplete(Error()); |
| 137 | } |
| 138 | } |
| 139 | |
| 140 | void WiMax::OnScanNetworksComplete(const Error &/*error*/) { |
| 141 | SLOG(WiMax, 2) << __func__; |
| 142 | scanning_ = false; |
| 143 | // The networks are updated when the NetworksChanged signal is received. |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 144 | } |
| 145 | |
| 146 | void WiMax::OnConnectComplete(const Error &error) { |
| 147 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 148 | if (!pending_service_) { |
| 149 | LOG(ERROR) << "Unexpected OnConnectComplete callback."; |
| 150 | return; |
| 151 | } |
Darin Petkov | 126d586 | 2012-05-17 14:39:11 +0200 | [diff] [blame] | 152 | if (error.IsSuccess() && AcquireIPConfig()) { |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 153 | LOG(INFO) << "Connected to " << pending_service_->friendly_name(); |
| 154 | SelectService(pending_service_); |
Darin Petkov | 126d586 | 2012-05-17 14:39:11 +0200 | [diff] [blame] | 155 | SetServiceState(Service::kStateConfiguring); |
| 156 | } else { |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 157 | LOG(ERROR) << "Unable to connect to " << pending_service_->friendly_name(); |
| 158 | pending_service_->SetState(Service::kStateFailure); |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 159 | } |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 160 | pending_service_ = NULL; |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 161 | } |
| 162 | |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 163 | void WiMax::OnDisconnectComplete(const Error &/*error*/) { |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 164 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | 126d586 | 2012-05-17 14:39:11 +0200 | [diff] [blame] | 165 | DestroyIPConfig(); |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 166 | SelectService(NULL); |
| 167 | } |
| 168 | |
| 169 | void WiMax::OnEnableComplete(const EnabledStateChangedCallback &callback, |
| 170 | const Error &error) { |
| 171 | SLOG(WiMax, 2) << __func__; |
| 172 | if (error.IsFailure()) { |
| 173 | proxy_.reset(); |
| 174 | } else { |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 175 | // Scan for networks to allow service creation when the network list becomes |
| 176 | // available. |
| 177 | Error e; |
| 178 | Scan(&e); |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 179 | } |
| 180 | callback.Run(error); |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 181 | } |
| 182 | |
| 183 | void WiMax::OnDisableComplete(const EnabledStateChangedCallback &callback, |
| 184 | const Error &error) { |
| 185 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 186 | proxy_.reset(); |
Darin Petkov | 912f0de | 2012-05-16 14:12:14 +0200 | [diff] [blame] | 187 | callback.Run(error); |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 188 | } |
| 189 | |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 190 | void WiMax::OnNetworksChanged(const RpcIdentifiers &networks) { |
| 191 | SLOG(WiMax, 2) << __func__; |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 192 | networks_ = networks; |
| 193 | StopDeadServices(); |
| 194 | StartLiveServices(); |
| 195 | } |
| 196 | |
| 197 | void WiMax::StartLiveServices() { |
| 198 | for (RpcIdentifiers::const_iterator it = networks_.begin(); |
| 199 | it != networks_.end(); ++it) { |
| 200 | StartLiveServicesForNetwork(*it); |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 201 | } |
| 202 | } |
| 203 | |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 204 | void WiMax::StartLiveServicesForNetwork(const RpcIdentifier &network) { |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 205 | SLOG(WiMax, 2) << __func__ << "(" << network << ")"; |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 206 | WiMaxServiceRefPtr default_service = GetDefaultService(network); |
| 207 | if (!default_service) { |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 208 | return; |
| 209 | } |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 210 | // Start services for this live network identifier. |
| 211 | for (vector<WiMaxServiceRefPtr>::iterator it = services_.begin(); |
| 212 | it != services_.end(); ++it) { |
| 213 | WiMaxServiceRefPtr service = *it; |
| 214 | if (service->network_id() != default_service->network_id()) { |
| 215 | continue; |
| 216 | } |
| 217 | if (service->IsStarted()) { |
| 218 | continue; |
| 219 | } |
| 220 | if (service->Start(proxy_factory_->CreateWiMaxNetworkProxy(network))) { |
| 221 | LOG(INFO) << "WiMAX service started: " |
| 222 | << service->GetStorageIdentifier(); |
| 223 | } else { |
| 224 | LOG(ERROR) << "Unable to start service: " |
| 225 | << service->GetStorageIdentifier(); |
| 226 | } |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 227 | } |
| 228 | } |
| 229 | |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 230 | void WiMax::StopDeadServices() { |
| 231 | SLOG(WiMax, 2) << __func__ << "(" << networks_.size() << ")"; |
| 232 | for (vector<WiMaxServiceRefPtr>::iterator it = services_.begin(); |
| 233 | it != services_.end(); ++it) { |
| 234 | WiMaxServiceRefPtr service = *it; |
| 235 | if (!service->IsStarted()) { |
| 236 | continue; |
| 237 | } |
| 238 | if (find(networks_.begin(), networks_.end(), |
| 239 | service->GetNetworkObjectPath()) == networks_.end()) { |
| 240 | LOG(INFO) << "Stopping WiMAX service: " |
| 241 | << service->GetStorageIdentifier(); |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 242 | if (service == selected_service()) { |
| 243 | DestroyIPConfig(); |
| 244 | SelectService(NULL); |
| 245 | } |
| 246 | if (pending_service_ == service) { |
| 247 | pending_service_ = NULL; |
| 248 | } |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 249 | service->Stop(); |
Darin Petkov | 9893d9c | 2012-05-17 15:27:31 -0700 | [diff] [blame] | 250 | } |
| 251 | } |
| 252 | } |
| 253 | |
Darin Petkov | d1cd797 | 2012-05-22 15:26:15 +0200 | [diff] [blame^] | 254 | void WiMax::DestroyAllServices() { |
| 255 | SLOG(WiMax, 2) << __func__; |
| 256 | while (!services_.empty()) { |
| 257 | const WiMaxServiceRefPtr &service = services_.back(); |
| 258 | manager()->DeregisterService(service); |
| 259 | LOG(INFO) << "Deregistered WiMAX service: " |
| 260 | << service->GetStorageIdentifier(); |
| 261 | services_.pop_back(); |
| 262 | } |
| 263 | } |
| 264 | |
| 265 | WiMaxServiceRefPtr WiMax::GetService(const WiMaxNetworkId &id, |
| 266 | const string &name) { |
| 267 | SLOG(WiMax, 2) << __func__ << "(" << id << ", " << name << ")"; |
| 268 | string storage_id = WiMaxService::CreateStorageIdentifier(id, name); |
| 269 | WiMaxServiceRefPtr service = FindService(storage_id); |
| 270 | if (service) { |
| 271 | SLOG(WiMax, 2) << "Service already exists."; |
| 272 | return service; |
| 273 | } |
| 274 | service = new WiMaxService(control_interface(), |
| 275 | dispatcher(), |
| 276 | metrics(), |
| 277 | manager(), |
| 278 | this); |
| 279 | service->set_network_id(id); |
| 280 | service->set_friendly_name(name); |
| 281 | service->InitStorageIdentifier(); |
| 282 | services_.push_back(service); |
| 283 | manager()->RegisterService(service); |
| 284 | LOG(INFO) << "Registered WiMAX service: " << service->GetStorageIdentifier(); |
| 285 | return service; |
| 286 | } |
| 287 | |
| 288 | WiMaxServiceRefPtr WiMax::GetDefaultService(const RpcIdentifier &network) { |
| 289 | SLOG(WiMax, 2) << __func__ << "(" << network << ")"; |
| 290 | scoped_ptr<WiMaxNetworkProxyInterface> proxy( |
| 291 | proxy_factory_->CreateWiMaxNetworkProxy(network)); |
| 292 | Error error; |
| 293 | uint32 identifier = proxy->Identifier(&error); |
| 294 | if (error.IsFailure()) { |
| 295 | return NULL; |
| 296 | } |
| 297 | string name = proxy->Name(&error); |
| 298 | if (error.IsFailure()) { |
| 299 | return NULL; |
| 300 | } |
| 301 | return GetService(WiMaxService::ConvertIdentifierToNetworkId(identifier), |
| 302 | name); |
| 303 | } |
| 304 | |
| 305 | WiMaxServiceRefPtr WiMax::FindService(const string &storage_id) { |
| 306 | SLOG(WiMax, 2) << __func__ << "(" << storage_id << ")"; |
| 307 | for (vector<WiMaxServiceRefPtr>::const_iterator it = services_.begin(); |
| 308 | it != services_.end(); ++it) { |
| 309 | if ((*it)->GetStorageIdentifier() == storage_id) { |
| 310 | return *it; |
| 311 | } |
| 312 | } |
| 313 | return NULL; |
| 314 | } |
| 315 | |
| 316 | bool WiMax::Load(StoreInterface *storage) { |
| 317 | bool loaded = Device::Load(storage); |
| 318 | if (LoadServices(storage)) { |
| 319 | StartLiveServices(); |
| 320 | } |
| 321 | return loaded; |
| 322 | } |
| 323 | |
| 324 | bool WiMax::LoadServices(StoreInterface *storage) { |
| 325 | SLOG(WiMax, 2) << __func__; |
| 326 | bool loaded = false; |
| 327 | set<string> groups = storage->GetGroupsWithKey(Service::kStorageType); |
| 328 | for (set<string>::iterator it = groups.begin(); it != groups.end(); ++it) { |
| 329 | string type; |
| 330 | if (!storage->GetString(*it, Service::kStorageType, &type) || |
| 331 | type != GetTechnologyString(NULL)) { |
| 332 | continue; |
| 333 | } |
| 334 | if (FindService(*it)) { |
| 335 | continue; |
| 336 | } |
| 337 | WiMaxNetworkId id; |
| 338 | if (!storage->GetString(*it, WiMaxService::kStorageNetworkId, &id) || |
| 339 | id.empty()) { |
| 340 | LOG(ERROR) << "Unable to load network id."; |
| 341 | continue; |
| 342 | } |
| 343 | string name; |
| 344 | if (!storage->GetString(*it, Service::kStorageName, &name) || |
| 345 | name.empty()) { |
| 346 | LOG(ERROR) << "Unable to load service name."; |
| 347 | continue; |
| 348 | } |
| 349 | GetService(id, name); |
| 350 | loaded = true; |
| 351 | } |
| 352 | return loaded; |
| 353 | } |
| 354 | |
Ben Chan | 99c8a4d | 2012-05-01 08:11:53 -0700 | [diff] [blame] | 355 | } // namespace shill |