Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "shill/vpn_driver.h" |
| 6 | |
| 7 | #include <base/stl_util.h> |
| 8 | #include <base/string_number_conversions.h> |
| 9 | #include <chromeos/dbus/service_constants.h> |
| 10 | #include <gmock/gmock.h> |
| 11 | #include <gtest/gtest.h> |
| 12 | |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 13 | #include "shill/event_dispatcher.h" |
| 14 | #include "shill/glib.h" |
| 15 | #include "shill/mock_connection.h" |
| 16 | #include "shill/mock_device_info.h" |
| 17 | #include "shill/mock_glib.h" |
| 18 | #include "shill/mock_manager.h" |
| 19 | #include "shill/mock_metrics.h" |
| 20 | #include "shill/mock_service.h" |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 21 | #include "shill/mock_store.h" |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 22 | #include "shill/nice_mock_control.h" |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 23 | #include "shill/property_store.h" |
| 24 | |
| 25 | using std::string; |
| 26 | using testing::_; |
| 27 | using testing::AnyNumber; |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 28 | using testing::NiceMock; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 29 | using testing::Return; |
| 30 | using testing::SetArgumentPointee; |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 31 | using testing::StrictMock; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 32 | using testing::Test; |
| 33 | |
| 34 | namespace shill { |
| 35 | |
| 36 | namespace { |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 37 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 38 | const char kHostProperty[] = "VPN.Host"; |
| 39 | const char kOTPProperty[] = "VPN.OTP"; |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 40 | const char kPINProperty[] = "VPN.PIN"; |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 41 | const char kPSKProperty[] = "VPN.PSK"; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 42 | const char kPasswordProperty[] = "VPN.Password"; |
| 43 | const char kPortProperty[] = "VPN.Port"; |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 44 | |
| 45 | const char kPIN[] = "5555"; |
| 46 | const char kPassword[] = "random-password"; |
| 47 | const char kPort[] = "1234"; |
| 48 | const char kStorageID[] = "vpn_service_id"; |
| 49 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 50 | } // namespace |
| 51 | |
| 52 | class VPNDriverUnderTest : public VPNDriver { |
| 53 | public: |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 54 | VPNDriverUnderTest(EventDispatcher *dispatcher, Manager *manager); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 55 | virtual ~VPNDriverUnderTest() {} |
| 56 | |
| 57 | // Inherited from VPNDriver. |
| 58 | MOCK_METHOD2(ClaimInterface, bool(const string &link_name, |
| 59 | int interface_index)); |
| 60 | MOCK_METHOD2(Connect, void(const VPNServiceRefPtr &service, Error *error)); |
| 61 | MOCK_METHOD0(Disconnect, void()); |
Darin Petkov | 5eb0542 | 2012-05-11 15:45:25 +0200 | [diff] [blame] | 62 | MOCK_METHOD0(OnConnectionDisconnected, void()); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 63 | MOCK_CONST_METHOD0(GetProviderType, string()); |
| 64 | |
| 65 | private: |
| 66 | static const Property kProperties[]; |
| 67 | |
| 68 | DISALLOW_COPY_AND_ASSIGN(VPNDriverUnderTest); |
| 69 | }; |
| 70 | |
| 71 | // static |
| 72 | const VPNDriverUnderTest::Property VPNDriverUnderTest::kProperties[] = { |
| 73 | { kHostProperty, 0 }, |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 74 | { kOTPProperty, Property::kEphemeral }, |
| 75 | { kPINProperty, Property::kWriteOnly }, |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 76 | { kPSKProperty, Property::kCredential }, |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 77 | { kPasswordProperty, Property::kCredential }, |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 78 | { kPortProperty, 0 }, |
| 79 | { flimflam::kProviderNameProperty, 0 }, |
| 80 | }; |
| 81 | |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 82 | VPNDriverUnderTest::VPNDriverUnderTest( |
| 83 | EventDispatcher *dispatcher, Manager *manager) |
| 84 | : VPNDriver(dispatcher, manager, kProperties, arraysize(kProperties)) {} |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 85 | |
| 86 | class VPNDriverTest : public Test { |
| 87 | public: |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 88 | VPNDriverTest() |
| 89 | : device_info_(&control_, &dispatcher_, &metrics_, &manager_), |
| 90 | manager_(&control_, &dispatcher_, &metrics_, &glib_), |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 91 | driver_(&dispatcher_, &manager_) {} |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 92 | |
| 93 | virtual ~VPNDriverTest() {} |
| 94 | |
| 95 | protected: |
| 96 | void SetArg(const string &arg, const string &value) { |
| 97 | driver_.args()->SetString(arg, value); |
| 98 | } |
| 99 | |
| 100 | KeyValueStore *GetArgs() { return driver_.args(); } |
| 101 | |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 102 | bool GetProviderProperty(const PropertyStore &store, |
| 103 | const string &key, |
| 104 | string *value); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 105 | |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 106 | NiceMockControl control_; |
| 107 | NiceMock<MockDeviceInfo> device_info_; |
| 108 | EventDispatcher dispatcher_; |
| 109 | MockMetrics metrics_; |
| 110 | MockGLib glib_; |
| 111 | MockManager manager_; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 112 | VPNDriverUnderTest driver_; |
| 113 | }; |
| 114 | |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 115 | bool VPNDriverTest::GetProviderProperty(const PropertyStore &store, |
| 116 | const string &key, |
| 117 | string *value) { |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 118 | KeyValueStore provider_properties; |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame^] | 119 | Error error; |
| 120 | EXPECT_TRUE(store.GetKeyValueStoreProperty( |
| 121 | flimflam::kProviderProperty, &provider_properties, &error)); |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 122 | if (!provider_properties.ContainsString(key)) { |
| 123 | return false; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 124 | } |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 125 | if (value != NULL) { |
| 126 | *value = provider_properties.GetString(key); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 127 | } |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 128 | return true; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 129 | } |
| 130 | |
| 131 | TEST_F(VPNDriverTest, Load) { |
| 132 | MockStore storage; |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 133 | GetArgs()->SetString(kHostProperty, "1.2.3.4"); |
| 134 | GetArgs()->SetString(kPSKProperty, "1234"); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 135 | EXPECT_CALL(storage, GetString(kStorageID, _, _)) |
| 136 | .WillRepeatedly(Return(false)); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 137 | EXPECT_CALL(storage, GetString(_, kOTPProperty, _)).Times(0); |
| 138 | EXPECT_CALL(storage, GetCryptedString(_, kOTPProperty, _)).Times(0); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 139 | EXPECT_CALL(storage, GetString(kStorageID, kPortProperty, _)) |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 140 | .WillOnce(DoAll(SetArgumentPointee<2>(string(kPort)), Return(true))); |
| 141 | EXPECT_CALL(storage, GetString(kStorageID, kPINProperty, _)) |
| 142 | .WillOnce(DoAll(SetArgumentPointee<2>(string(kPIN)), Return(true))); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 143 | EXPECT_CALL(storage, GetCryptedString(kStorageID, kPSKProperty, _)) |
| 144 | .WillOnce(Return(false)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 145 | EXPECT_CALL(storage, GetCryptedString(kStorageID, kPasswordProperty, _)) |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 146 | .WillOnce(DoAll(SetArgumentPointee<2>(string(kPassword)), Return(true))); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 147 | EXPECT_TRUE(driver_.Load(&storage, kStorageID)); |
| 148 | EXPECT_EQ(kPort, GetArgs()->LookupString(kPortProperty, "")); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 149 | EXPECT_EQ(kPIN, GetArgs()->LookupString(kPINProperty, "")); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 150 | EXPECT_EQ(kPassword, GetArgs()->LookupString(kPasswordProperty, "")); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 151 | |
| 152 | // Properties missing from the persistent store should be deleted. |
| 153 | EXPECT_FALSE(GetArgs()->ContainsString(kHostProperty)); |
| 154 | EXPECT_FALSE(GetArgs()->ContainsString(kPSKProperty)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 155 | } |
| 156 | |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 157 | TEST_F(VPNDriverTest, Save) { |
| 158 | SetArg(flimflam::kProviderNameProperty, ""); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 159 | SetArg(kPINProperty, kPIN); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 160 | SetArg(kPortProperty, kPort); |
| 161 | SetArg(kPasswordProperty, kPassword); |
| 162 | SetArg(kOTPProperty, "987654"); |
| 163 | MockStore storage; |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 164 | EXPECT_CALL(storage, |
| 165 | SetString(kStorageID, flimflam::kProviderNameProperty, "")) |
| 166 | .WillOnce(Return(true)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 167 | EXPECT_CALL(storage, SetString(kStorageID, kPortProperty, kPort)) |
| 168 | .WillOnce(Return(true)); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 169 | EXPECT_CALL(storage, SetString(kStorageID, kPINProperty, kPIN)) |
| 170 | .WillOnce(Return(true)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 171 | EXPECT_CALL(storage, |
| 172 | SetCryptedString(kStorageID, kPasswordProperty, kPassword)) |
| 173 | .WillOnce(Return(true)); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 174 | EXPECT_CALL(storage, SetCryptedString(_, kOTPProperty, _)).Times(0); |
| 175 | EXPECT_CALL(storage, SetString(_, kOTPProperty, _)).Times(0); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 176 | EXPECT_CALL(storage, DeleteKey(kStorageID, flimflam::kProviderNameProperty)) |
| 177 | .Times(0); |
| 178 | EXPECT_CALL(storage, DeleteKey(kStorageID, kPSKProperty)).Times(1); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 179 | EXPECT_CALL(storage, DeleteKey(kStorageID, kHostProperty)).Times(1); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 180 | EXPECT_TRUE(driver_.Save(&storage, kStorageID, true)); |
| 181 | } |
| 182 | |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 183 | TEST_F(VPNDriverTest, SaveNoCredentials) { |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 184 | SetArg(kPasswordProperty, kPassword); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 185 | SetArg(kPSKProperty, ""); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 186 | MockStore storage; |
| 187 | EXPECT_CALL(storage, SetString(_, kPasswordProperty, _)).Times(0); |
| 188 | EXPECT_CALL(storage, SetCryptedString(_, kPasswordProperty, _)).Times(0); |
| 189 | EXPECT_CALL(storage, DeleteKey(kStorageID, _)).Times(AnyNumber()); |
| 190 | EXPECT_CALL(storage, DeleteKey(kStorageID, kPasswordProperty)).Times(1); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 191 | EXPECT_CALL(storage, DeleteKey(kStorageID, kPSKProperty)).Times(1); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 192 | EXPECT_TRUE(driver_.Save(&storage, kStorageID, false)); |
| 193 | } |
| 194 | |
| 195 | TEST_F(VPNDriverTest, UnloadCredentials) { |
| 196 | SetArg(kOTPProperty, "654321"); |
| 197 | SetArg(kPasswordProperty, kPassword); |
| 198 | SetArg(kPortProperty, kPort); |
| 199 | driver_.UnloadCredentials(); |
| 200 | EXPECT_FALSE(GetArgs()->ContainsString(kOTPProperty)); |
| 201 | EXPECT_FALSE(GetArgs()->ContainsString(kPasswordProperty)); |
| 202 | EXPECT_EQ(kPort, GetArgs()->LookupString(kPortProperty, "")); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 203 | } |
| 204 | |
| 205 | TEST_F(VPNDriverTest, InitPropertyStore) { |
| 206 | // Figure out if the store is actually hooked up to the driver argument |
| 207 | // KeyValueStore. |
| 208 | PropertyStore store; |
| 209 | driver_.InitPropertyStore(&store); |
| 210 | |
| 211 | // An un-set property should not be readable. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame^] | 212 | { |
| 213 | Error error; |
| 214 | EXPECT_FALSE(store.GetStringProperty(kPortProperty, NULL, &error)); |
| 215 | EXPECT_EQ(Error::kInvalidArguments, error.type()); |
| 216 | } |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 217 | EXPECT_FALSE(GetProviderProperty(store, kPortProperty, NULL)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 218 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 219 | const string kProviderName = "boo"; |
| 220 | SetArg(kPortProperty, kPort); |
| 221 | SetArg(kPasswordProperty, kPassword); |
| 222 | SetArg(flimflam::kProviderNameProperty, kProviderName); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 223 | SetArg(kHostProperty, ""); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 224 | |
| 225 | // We should not be able to read a property out of the driver args using the |
| 226 | // key to the args directly. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame^] | 227 | { |
| 228 | Error error; |
| 229 | EXPECT_FALSE(store.GetStringProperty(kPortProperty, NULL, &error)); |
| 230 | EXPECT_EQ(Error::kInvalidArguments, error.type()); |
| 231 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 232 | |
| 233 | // We should instead be able to find it within the "Provider" stringmap. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame^] | 234 | { |
| 235 | string value; |
| 236 | EXPECT_TRUE(GetProviderProperty(store, kPortProperty, &value)); |
| 237 | EXPECT_EQ(kPort, value); |
| 238 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 239 | |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 240 | // We should be able to read empty properties from the "Provider" stringmap. |
| 241 | { |
| 242 | string value; |
| 243 | EXPECT_TRUE(GetProviderProperty(store, kHostProperty, &value)); |
| 244 | EXPECT_TRUE(value.empty()); |
| 245 | } |
| 246 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 247 | // Properties that start with the prefix "Provider." should be mapped to the |
| 248 | // name in the Properties dict with the prefix removed. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame^] | 249 | { |
| 250 | string value; |
| 251 | EXPECT_TRUE(GetProviderProperty(store, flimflam::kNameProperty, &value)); |
| 252 | EXPECT_EQ(kProviderName, value); |
| 253 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 254 | |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 255 | // If we clear a property, we should no longer be able to find it. |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 256 | { |
| 257 | Error error; |
| 258 | EXPECT_TRUE(store.ClearProperty(kPortProperty, &error)); |
| 259 | EXPECT_TRUE(error.IsSuccess()); |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 260 | EXPECT_FALSE(GetProviderProperty(store, kPortProperty, NULL)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 261 | } |
| 262 | |
| 263 | // A second attempt to clear this property should return an error. |
| 264 | { |
| 265 | Error error; |
| 266 | EXPECT_FALSE(store.ClearProperty(kPortProperty, &error)); |
| 267 | EXPECT_EQ(Error::kNotFound, error.type()); |
| 268 | } |
| 269 | |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 270 | // Test write only properties. |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 271 | EXPECT_FALSE(GetProviderProperty(store, kPINProperty, NULL)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 272 | |
| 273 | // Write properties to the driver args using the PropertyStore interface. |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 274 | { |
| 275 | const string kValue = "some-value"; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 276 | Error error; |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 277 | EXPECT_TRUE(store.SetStringProperty(kPINProperty, kValue, &error)); |
| 278 | EXPECT_EQ(kValue, GetArgs()->GetString(kPINProperty)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 279 | } |
| 280 | } |
| 281 | |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 282 | TEST_F(VPNDriverTest, ConnectTimeout) { |
| 283 | EXPECT_EQ(&dispatcher_, driver_.dispatcher_); |
| 284 | EXPECT_TRUE(driver_.connect_timeout_callback_.IsCancelled()); |
| 285 | EXPECT_FALSE(driver_.IsConnectTimeoutStarted()); |
| 286 | EXPECT_EQ(VPNDriver::kDefaultConnectTimeoutSeconds, |
| 287 | driver_.connect_timeout_seconds_); |
| 288 | driver_.connect_timeout_seconds_ = 0; |
| 289 | driver_.StartConnectTimeout(); |
| 290 | EXPECT_FALSE(driver_.connect_timeout_callback_.IsCancelled()); |
| 291 | EXPECT_TRUE(driver_.IsConnectTimeoutStarted()); |
| 292 | driver_.dispatcher_ = NULL; |
| 293 | driver_.StartConnectTimeout(); // Expect no crash. |
| 294 | EXPECT_CALL(driver_, OnConnectionDisconnected()); |
| 295 | dispatcher_.DispatchPendingEvents(); |
| 296 | EXPECT_TRUE(driver_.connect_timeout_callback_.IsCancelled()); |
| 297 | EXPECT_FALSE(driver_.IsConnectTimeoutStarted()); |
| 298 | } |
| 299 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 300 | } // namespace shill |