Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / libbase / 306a22c073f2107d59f74654d02492963d066247
commit306a22c073f2107d59f74654d02492963d066247[log] [tgz]
authorKrzysztof Kosiński <krzysio@google.com>Wed Jun 24 01:55:26 2020 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>Wed Jun 24 01:55:26 2020 +0000
treea66dddab2881a43e03e5a1a8b688fddbcfcd28c3
parente8f7c841322bc1f8dd3cf5171897f4255f005596 [diff]
parent8bf300a9331df6a07dfd60ada4c1d8741de29043 [diff]
Improve the implementation of CHECK() macro. am: 6216488884 am: b8f83d2177 am: 0b15ffde25 am: 8bf300a933

Original change: https://android-review.googlesource.com/c/platform/system/libbase/+/1346564

Change-Id: I04e88d6c82d8b031465e595725c0e1e92f66f400
tree: a66dddab2881a43e03e5a1a8b688fddbcfcd28c3
  1. include/
  2. tidy/
  3. .clang-format ⇨ ../.clang-format-2
  4. abi_compatibility.cpp
  5. Android.bp
  6. chrono_utils.cpp
  7. chrono_utils_test.cpp
  8. cmsg.cpp
  9. cmsg_test.cpp
  10. CPPLINT.cfg
  11. endian_test.cpp
  12. errors_test.cpp
  13. errors_unix.cpp
  14. errors_windows.cpp
  15. expected_test.cpp
  16. file.cpp
  17. file_test.cpp
  18. format_benchmark.cpp
  19. liblog_symbols.cpp
  20. liblog_symbols.h
  21. logging.cpp
  22. logging_splitters.h
  23. logging_splitters_test.cpp
  24. logging_test.cpp
  25. macros_test.cpp
  26. mapped_file.cpp
  27. mapped_file_test.cpp
  28. no_destructor_test.cpp
  29. OWNERS
  30. parsebool.cpp
  31. parsebool_test.cpp
  32. parsedouble_test.cpp
  33. parseint_test.cpp
  34. parsenetaddress.cpp
  35. parsenetaddress_test.cpp
  36. process.cpp
  37. process_test.cpp
  38. properties.cpp
  39. properties_test.cpp
  40. README.md
  41. result_test.cpp
  42. scopeguard_test.cpp
  43. stringprintf.cpp
  44. stringprintf_test.cpp
  45. strings.cpp
  46. strings_test.cpp
  47. test_main.cpp
  48. TEST_MAPPING
  49. test_utils.cpp
  50. test_utils_test.cpp
  51. threads.cpp
  52. utf8.cpp
  53. utf8_test.cpp
README.md

libbase

Who is this library for?

This library is a collection of convenience functions to make common tasks easier and less error-prone.

In this context, "error-prone" covers both "hard to do correctly" and "hard to do with good performance", but as a general purpose library, libbase's primary focus is on making it easier to do things easily and correctly when a compromise has to be made between "simplest API" on the one hand and "fastest implementation" on the other. Though obviously the ideal is to have both.

Should my routine be added?

The intention is to cover the 80% use cases, not be all things to all users.

If you have a routine that's really useful in your project, congratulations. But that doesn't mean it should be here rather than just in your project.

The question for libbase is "should everyone be doing this?"/"does this make everyone's code cleaner/safer?". Historically we've considered the bar for inclusion to be "are there at least three unrelated projects that would be cleaned up by doing so".

If your routine is actually something from a future C++ standard (that isn't yet in libc++), or it's widely used in another library, that helps show that there's precedent. Being able to say "so-and-so has used this API for n years" is a good way to reduce concerns about API choices.

Any other restrictions?

Unlike most Android code, code in libbase has to build for Mac and Windows too.

Code here is also expected to have good test coverage.

By its nature, it's difficult to change libbase API. It's often best to start using your routine just in your project, and let it "graduate" after you're certain that the API is solid.