blob: 393640443781d88effeed05c7fcc627f86de5be1 [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkovf42cc1c2010-09-01 09:03:02 -070016
Alex Deymo2c0db7b2014-11-04 12:23:39 -080017#include "update_engine/update_attempter.h"
18
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Ben Chan02f7c1d2014-10-18 15:18:02 -070021#include <memory>
22
Ben Chan06c76a42014-09-05 08:21:06 -070023#include <base/files/file_util.h>
Alex Deymo0b3db6b2015-08-10 15:19:37 -070024#include <base/message_loop/message_loop.h>
Amin Hassani71818c82018-03-06 13:25:40 -080025#include <brillo/bind_lambda.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070026#include <brillo/message_loops/base_message_loop.h>
27#include <brillo/message_loops/message_loop.h>
28#include <brillo/message_loops/message_loop_utils.h>
Darin Petkovf42cc1c2010-09-01 09:03:02 -070029#include <gtest/gtest.h>
Patrick Dubroy7fbbe8a2011-08-01 17:28:22 +020030#include <policy/libpolicy.h>
31#include <policy/mock_device_policy.h>
Marton Hunyadye58bddb2018-04-10 20:27:26 +020032#include <policy/mock_libpolicy.h>
Darin Petkovf42cc1c2010-09-01 09:03:02 -070033
Alex Deymo39910dc2015-11-09 17:04:30 -080034#include "update_engine/common/fake_clock.h"
35#include "update_engine/common/fake_prefs.h"
Alex Deymo14fd1ec2016-02-24 22:03:57 -080036#include "update_engine/common/mock_action.h"
37#include "update_engine/common/mock_action_processor.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080038#include "update_engine/common/mock_http_fetcher.h"
39#include "update_engine/common/mock_prefs.h"
40#include "update_engine/common/platform_constants.h"
41#include "update_engine/common/prefs.h"
42#include "update_engine/common/test_utils.h"
43#include "update_engine/common/utils.h"
Gilad Arnold5bb4c902014-04-10 12:32:13 -070044#include "update_engine/fake_system_state.h"
David Zeuthen8f191b22013-08-06 12:27:50 -070045#include "update_engine/mock_p2p_manager.h"
Jay Srinivasan6f6ea002012-12-14 11:26:28 -080046#include "update_engine/mock_payload_state.h"
Aaron Wood9321f502017-09-07 11:18:54 -070047#include "update_engine/mock_service_observer.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080048#include "update_engine/payload_consumer/filesystem_verifier_action.h"
49#include "update_engine/payload_consumer/install_plan.h"
50#include "update_engine/payload_consumer/payload_constants.h"
51#include "update_engine/payload_consumer/postinstall_runner_action.h"
Darin Petkovf42cc1c2010-09-01 09:03:02 -070052
David Zeuthen985b1122013-10-09 12:13:15 -070053using base::Time;
54using base::TimeDelta;
Aaron Woodbf5a2522017-10-04 10:58:36 -070055using chromeos_update_manager::EvalStatus;
56using chromeos_update_manager::UpdateCheckParams;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070057using std::string;
Ben Chan02f7c1d2014-10-18 15:18:02 -070058using std::unique_ptr;
Aaron Woodbf5a2522017-10-04 10:58:36 -070059using testing::_;
Darin Petkov36275772010-10-01 11:40:57 -070060using testing::DoAll;
Aaron Wood7f92e2b2017-08-28 14:51:21 -070061using testing::Field;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070062using testing::InSequence;
Darin Petkov2dd01092010-10-08 15:43:05 -070063using testing::Ne;
Darin Petkov9c096d62010-11-17 14:49:04 -080064using testing::NiceMock;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070065using testing::Property;
66using testing::Return;
Gilad Arnold74b5f552014-10-07 08:17:16 -070067using testing::ReturnPointee;
Marton Hunyadye58bddb2018-04-10 20:27:26 +020068using testing::ReturnRef;
Alex Deymo2c0db7b2014-11-04 12:23:39 -080069using testing::SaveArg;
Ben Chan672c1f52017-10-23 15:41:39 -070070using testing::SetArgPointee;
Aaron Woodbf5a2522017-10-04 10:58:36 -070071using update_engine::UpdateAttemptFlags;
Aaron Wood7f92e2b2017-08-28 14:51:21 -070072using update_engine::UpdateEngineStatus;
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -070073using update_engine::UpdateStatus;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070074
75namespace chromeos_update_engine {
76
77// Test a subclass rather than the main class directly so that we can mock out
Darin Petkovcd1666f2010-09-23 09:53:44 -070078// methods within the class. There're explicit unit tests for the mocked out
Darin Petkovf42cc1c2010-09-01 09:03:02 -070079// methods.
80class UpdateAttempterUnderTest : public UpdateAttempter {
81 public:
Jeffrey Kardatzkecf5f1f12017-10-02 16:08:44 -070082 explicit UpdateAttempterUnderTest(SystemState* system_state)
83 : UpdateAttempter(system_state, nullptr) {}
Gilad Arnoldec7f9162014-07-15 13:24:46 -070084
85 // Wrap the update scheduling method, allowing us to opt out of scheduled
86 // updates for testing purposes.
87 void ScheduleUpdates() override {
88 schedule_updates_called_ = true;
89 if (do_schedule_updates_) {
90 UpdateAttempter::ScheduleUpdates();
91 } else {
92 LOG(INFO) << "[TEST] Update scheduling disabled.";
93 }
94 }
95 void EnableScheduleUpdates() { do_schedule_updates_ = true; }
96 void DisableScheduleUpdates() { do_schedule_updates_ = false; }
97
98 // Indicates whether ScheduleUpdates() was called.
99 bool schedule_updates_called() const { return schedule_updates_called_; }
100
David Pursell02c18642014-11-06 11:26:11 -0800101 // Need to expose forced_omaha_url_ so we can test it.
Alex Deymo60ca1a72015-06-18 18:19:15 -0700102 const string& forced_omaha_url() const { return forced_omaha_url_; }
David Pursell02c18642014-11-06 11:26:11 -0800103
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700104 private:
105 bool schedule_updates_called_ = false;
106 bool do_schedule_updates_ = true;
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700107};
108
109class UpdateAttempterTest : public ::testing::Test {
110 protected:
Jay Srinivasan43488792012-06-19 00:25:31 -0700111 UpdateAttempterTest()
Daniel Erate5f6f252017-04-20 12:09:58 -0600112 : certificate_checker_(fake_system_state_.mock_prefs(),
Alex Deymo33e91e72015-12-01 18:26:08 -0300113 &openssl_wrapper_) {
Gilad Arnold1f847232014-04-07 12:07:49 -0700114 // Override system state members.
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700115 fake_system_state_.set_connection_manager(&mock_connection_manager);
116 fake_system_state_.set_update_attempter(&attempter_);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700117 loop_.SetAsCurrent();
Gilad Arnold1f847232014-04-07 12:07:49 -0700118
Alex Deymo33e91e72015-12-01 18:26:08 -0300119 certificate_checker_.Init();
120
Sen Jiange67bb5b2016-06-20 15:53:56 -0700121 // Finish initializing the attempter.
Gilad Arnold1f847232014-04-07 12:07:49 -0700122 attempter_.Init();
Jay Srinivasan43488792012-06-19 00:25:31 -0700123 }
Gilad Arnoldeff87cc2013-07-22 18:32:09 -0700124
Alex Deymo610277e2014-11-11 21:18:11 -0800125 void SetUp() override {
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700126 EXPECT_NE(nullptr, attempter_.system_state_);
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700127 EXPECT_EQ(0, attempter_.http_response_code_);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700128 EXPECT_EQ(UpdateStatus::IDLE, attempter_.status_);
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700129 EXPECT_EQ(0.0, attempter_.download_progress_);
130 EXPECT_EQ(0, attempter_.last_checked_time_);
131 EXPECT_EQ("0.0.0.0", attempter_.new_version_);
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700132 EXPECT_EQ(0ULL, attempter_.new_payload_size_);
Alex Deymo8427b4a2014-11-05 14:00:32 -0800133 processor_ = new NiceMock<MockActionProcessor>();
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700134 attempter_.processor_.reset(processor_); // Transfers ownership.
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700135 prefs_ = fake_system_state_.mock_prefs();
Gilad Arnold74b5f552014-10-07 08:17:16 -0700136
137 // Set up store/load semantics of P2P properties via the mock PayloadState.
138 actual_using_p2p_for_downloading_ = false;
139 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
140 SetUsingP2PForDownloading(_))
141 .WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_downloading_));
142 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
143 GetUsingP2PForDownloading())
144 .WillRepeatedly(ReturnPointee(&actual_using_p2p_for_downloading_));
145 actual_using_p2p_for_sharing_ = false;
146 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
147 SetUsingP2PForSharing(_))
148 .WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_sharing_));
149 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
150 GetUsingP2PForDownloading())
151 .WillRepeatedly(ReturnPointee(&actual_using_p2p_for_sharing_));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700152 }
153
Alex Deymo60ca1a72015-06-18 18:19:15 -0700154 public:
155 void ScheduleQuitMainLoop();
Patrick Dubroy7fbbe8a2011-08-01 17:28:22 +0200156
Alex Deymo60ca1a72015-06-18 18:19:15 -0700157 // Callbacks to run the different tests from the main loop.
Darin Petkove6ef2f82011-03-07 17:31:11 -0800158 void UpdateTestStart();
159 void UpdateTestVerify();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700160 void RollbackTestStart(bool enterprise_rollback, bool valid_slot);
Chris Sosa76a29ae2013-07-11 17:59:24 -0700161 void RollbackTestVerify();
Thieu Le116fda32011-04-19 11:01:54 -0700162 void PingOmahaTestStart();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700163 void ReadScatterFactorFromPolicyTestStart();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700164 void DecrementUpdateCheckCountTestStart();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700165 void NoScatteringDoneDuringManualUpdateTestStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700166 void P2PNotEnabledStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700167 void P2PEnabledStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700168 void P2PEnabledInteractiveStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700169 void P2PEnabledStartingFailsStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700170 void P2PEnabledHousekeepingFailsStart();
Marton Hunyadye58bddb2018-04-10 20:27:26 +0200171 void ResetRollbackHappenedStart(bool is_consumer,
172 bool is_policy_available,
173 bool expected_reset);
David Zeuthen8f191b22013-08-06 12:27:50 -0700174
Gilad Arnold74b5f552014-10-07 08:17:16 -0700175 bool actual_using_p2p_for_downloading() {
176 return actual_using_p2p_for_downloading_;
177 }
178 bool actual_using_p2p_for_sharing() {
179 return actual_using_p2p_for_sharing_;
180 }
181
Alex Deymo0b3db6b2015-08-10 15:19:37 -0700182 base::MessageLoopForIO base_loop_;
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700183 brillo::BaseMessageLoop loop_{&base_loop_};
Alex Deymo60ca1a72015-06-18 18:19:15 -0700184
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700185 FakeSystemState fake_system_state_;
Jeffrey Kardatzkecf5f1f12017-10-02 16:08:44 -0700186 UpdateAttempterUnderTest attempter_{&fake_system_state_};
Alex Deymo33e91e72015-12-01 18:26:08 -0300187 OpenSSLWrapper openssl_wrapper_;
188 CertificateChecker certificate_checker_;
Alex Deymo30534502015-07-20 15:06:33 -0700189
Alex Deymo8427b4a2014-11-05 14:00:32 -0800190 NiceMock<MockActionProcessor>* processor_;
191 NiceMock<MockPrefs>* prefs_; // Shortcut to fake_system_state_->mock_prefs().
Jay Srinivasan55f50c22013-01-10 19:24:35 -0800192 NiceMock<MockConnectionManager> mock_connection_manager;
Gilad Arnoldeff87cc2013-07-22 18:32:09 -0700193
Gilad Arnold74b5f552014-10-07 08:17:16 -0700194 bool actual_using_p2p_for_downloading_;
195 bool actual_using_p2p_for_sharing_;
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700196};
197
Alex Deymo60ca1a72015-06-18 18:19:15 -0700198void UpdateAttempterTest::ScheduleQuitMainLoop() {
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700199 loop_.PostTask(
200 FROM_HERE,
201 base::Bind([](brillo::BaseMessageLoop* loop) { loop->BreakLoop(); },
202 base::Unretained(&loop_)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700203}
204
Darin Petkov1b003102010-11-30 10:18:36 -0800205TEST_F(UpdateAttempterTest, ActionCompletedDownloadTest) {
Ben Chan02f7c1d2014-10-18 15:18:02 -0700206 unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
Darin Petkov1b003102010-11-30 10:18:36 -0800207 fetcher->FailTransfer(503); // Sets the HTTP response code.
Amin Hassani7ecda262017-07-11 17:10:50 -0700208 DownloadAction action(prefs_,
209 nullptr,
210 nullptr,
211 nullptr,
212 fetcher.release(),
213 false /* is_interactive */);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800214 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _)).Times(0);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700215 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700216 EXPECT_EQ(UpdateStatus::FINALIZING, attempter_.status());
Aaron Wood9321f502017-09-07 11:18:54 -0700217 EXPECT_EQ(0.0, attempter_.download_progress_);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700218 ASSERT_EQ(nullptr, attempter_.error_event_.get());
Darin Petkov1b003102010-11-30 10:18:36 -0800219}
220
221TEST_F(UpdateAttempterTest, ActionCompletedErrorTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -0800222 MockAction action;
223 EXPECT_CALL(action, Type()).WillRepeatedly(Return("MockAction"));
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700224 attempter_.status_ = UpdateStatus::DOWNLOADING;
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800225 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov1b003102010-11-30 10:18:36 -0800226 .WillOnce(Return(false));
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700227 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kError);
228 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov1b003102010-11-30 10:18:36 -0800229}
230
Aaron Wood9321f502017-09-07 11:18:54 -0700231TEST_F(UpdateAttempterTest, DownloadProgressAccumulationTest) {
232 // Simple test case, where all the values match (nothing was skipped)
233 uint64_t bytes_progressed_1 = 1024 * 1024; // 1MB
234 uint64_t bytes_progressed_2 = 1024 * 1024; // 1MB
235 uint64_t bytes_received_1 = bytes_progressed_1;
236 uint64_t bytes_received_2 = bytes_received_1 + bytes_progressed_2;
237 uint64_t bytes_total = 20 * 1024 * 1024; // 20MB
238
239 double progress_1 =
240 static_cast<double>(bytes_received_1) / static_cast<double>(bytes_total);
241 double progress_2 =
242 static_cast<double>(bytes_received_2) / static_cast<double>(bytes_total);
243
244 EXPECT_EQ(0.0, attempter_.download_progress_);
245 // This is set via inspecting the InstallPlan payloads when the
246 // OmahaResponseAction is completed
247 attempter_.new_payload_size_ = bytes_total;
248 NiceMock<MockServiceObserver> observer;
249 EXPECT_CALL(observer,
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700250 SendStatusUpdate(AllOf(
251 Field(&UpdateEngineStatus::progress, progress_1),
252 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
253 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700254 EXPECT_CALL(observer,
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700255 SendStatusUpdate(AllOf(
256 Field(&UpdateEngineStatus::progress, progress_2),
257 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
258 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700259 attempter_.AddObserver(&observer);
260 attempter_.BytesReceived(bytes_progressed_1, bytes_received_1, bytes_total);
261 EXPECT_EQ(progress_1, attempter_.download_progress_);
262 // This iteration validates that a later set of updates to the variables are
263 // properly handled (so that |getStatus()| will return the same progress info
264 // as the callback is receiving.
265 attempter_.BytesReceived(bytes_progressed_2, bytes_received_2, bytes_total);
266 EXPECT_EQ(progress_2, attempter_.download_progress_);
267}
268
269TEST_F(UpdateAttempterTest, ChangeToDownloadingOnReceivedBytesTest) {
270 // The transition into UpdateStatus::DOWNLOADING happens when the
271 // first bytes are received.
272 uint64_t bytes_progressed = 1024 * 1024; // 1MB
273 uint64_t bytes_received = 2 * 1024 * 1024; // 2MB
274 uint64_t bytes_total = 20 * 1024 * 1024; // 300MB
275 attempter_.status_ = UpdateStatus::CHECKING_FOR_UPDATE;
276 // This is set via inspecting the InstallPlan payloads when the
277 // OmahaResponseAction is completed
278 attempter_.new_payload_size_ = bytes_total;
279 EXPECT_EQ(0.0, attempter_.download_progress_);
280 NiceMock<MockServiceObserver> observer;
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700281 EXPECT_CALL(observer,
282 SendStatusUpdate(AllOf(
283 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
284 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700285 attempter_.AddObserver(&observer);
286 attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
287 EXPECT_EQ(UpdateStatus::DOWNLOADING, attempter_.status_);
288}
289
290TEST_F(UpdateAttempterTest, BroadcastCompleteDownloadTest) {
291 // There is a special case to ensure that at 100% downloaded,
292 // download_progress_ is updated and that value broadcast. This test confirms
293 // that.
294 uint64_t bytes_progressed = 0; // ignored
295 uint64_t bytes_received = 5 * 1024 * 1024; // ignored
296 uint64_t bytes_total = 5 * 1024 * 1024; // 300MB
297 attempter_.status_ = UpdateStatus::DOWNLOADING;
298 attempter_.new_payload_size_ = bytes_total;
299 EXPECT_EQ(0.0, attempter_.download_progress_);
300 NiceMock<MockServiceObserver> observer;
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700301 EXPECT_CALL(observer,
302 SendStatusUpdate(AllOf(
303 Field(&UpdateEngineStatus::progress, 1.0),
304 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
305 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700306 attempter_.AddObserver(&observer);
307 attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
308 EXPECT_EQ(1.0, attempter_.download_progress_);
309}
310
Darin Petkov1b003102010-11-30 10:18:36 -0800311TEST_F(UpdateAttempterTest, ActionCompletedOmahaRequestTest) {
Ben Chan02f7c1d2014-10-18 15:18:02 -0700312 unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
Darin Petkov1b003102010-11-30 10:18:36 -0800313 fetcher->FailTransfer(500); // Sets the HTTP response code.
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700314 OmahaRequestAction action(&fake_system_state_, nullptr,
Alex Deymoc1c17b42015-11-23 03:53:15 -0300315 std::move(fetcher), false);
Darin Petkov1b003102010-11-30 10:18:36 -0800316 ObjectCollectorAction<OmahaResponse> collector_action;
317 BondActions(&action, &collector_action);
318 OmahaResponse response;
319 response.poll_interval = 234;
320 action.SetOutputObject(response);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800321 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _)).Times(0);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700322 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
Darin Petkov1b003102010-11-30 10:18:36 -0800323 EXPECT_EQ(500, attempter_.http_response_code());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700324 EXPECT_EQ(UpdateStatus::IDLE, attempter_.status());
Alex Deymo80f70ff2016-02-10 16:08:11 -0800325 EXPECT_EQ(234U, attempter_.server_dictated_poll_interval_);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700326 ASSERT_TRUE(attempter_.error_event_.get() == nullptr);
Darin Petkov1b003102010-11-30 10:18:36 -0800327}
328
Alex Deymo30534502015-07-20 15:06:33 -0700329TEST_F(UpdateAttempterTest, ConstructWithUpdatedMarkerTest) {
Alex Deymo906191f2015-10-12 12:22:44 -0700330 FakePrefs fake_prefs;
331 string boot_id;
332 EXPECT_TRUE(utils::GetBootId(&boot_id));
333 fake_prefs.SetString(kPrefsUpdateCompletedOnBootId, boot_id);
334 fake_system_state_.set_prefs(&fake_prefs);
Sen Jiangaeeb2e02016-06-09 15:00:16 -0700335 attempter_.Init();
336 EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700337}
338
339TEST_F(UpdateAttempterTest, GetErrorCodeForActionTest) {
David Zeuthena99981f2013-04-29 13:42:47 -0700340 extern ErrorCode GetErrorCodeForAction(AbstractAction* action,
341 ErrorCode code);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700342 EXPECT_EQ(ErrorCode::kSuccess,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700343 GetErrorCodeForAction(nullptr, ErrorCode::kSuccess));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700344
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700345 FakeSystemState fake_system_state;
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700346 OmahaRequestAction omaha_request_action(&fake_system_state, nullptr,
347 nullptr, false);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700348 EXPECT_EQ(ErrorCode::kOmahaRequestError,
349 GetErrorCodeForAction(&omaha_request_action, ErrorCode::kError));
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700350 OmahaResponseHandlerAction omaha_response_handler_action(&fake_system_state_);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700351 EXPECT_EQ(ErrorCode::kOmahaResponseHandlerError,
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700352 GetErrorCodeForAction(&omaha_response_handler_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700353 ErrorCode::kError));
Sen Jiange6e4bb92016-04-05 14:59:12 -0700354 FilesystemVerifierAction filesystem_verifier_action;
Allie Woodeb9e6d82015-04-17 13:55:30 -0700355 EXPECT_EQ(ErrorCode::kFilesystemVerifierError,
356 GetErrorCodeForAction(&filesystem_verifier_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700357 ErrorCode::kError));
Alex Deymob15a0b82015-11-25 20:30:40 -0300358 PostinstallRunnerAction postinstall_runner_action(
Alex Deymofb905d92016-06-03 19:26:58 -0700359 fake_system_state.fake_boot_control(), fake_system_state.fake_hardware());
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700360 EXPECT_EQ(ErrorCode::kPostinstallRunnerError,
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700361 GetErrorCodeForAction(&postinstall_runner_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700362 ErrorCode::kError));
Alex Deymo8427b4a2014-11-05 14:00:32 -0800363 MockAction action_mock;
364 EXPECT_CALL(action_mock, Type()).WillOnce(Return("MockAction"));
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700365 EXPECT_EQ(ErrorCode::kError,
366 GetErrorCodeForAction(&action_mock, ErrorCode::kError));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700367}
368
Darin Petkov36275772010-10-01 11:40:57 -0700369TEST_F(UpdateAttempterTest, DisableDeltaUpdateIfNeededTest) {
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700370 attempter_.omaha_request_params_->set_delta_okay(true);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800371 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700372 .WillOnce(Return(false));
373 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700374 EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800375 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700376 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700377 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures - 1),
Darin Petkov36275772010-10-01 11:40:57 -0700378 Return(true)));
379 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700380 EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800381 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700382 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700383 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures),
Darin Petkov36275772010-10-01 11:40:57 -0700384 Return(true)));
385 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700386 EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800387 EXPECT_CALL(*prefs_, GetInt64(_, _)).Times(0);
Darin Petkov36275772010-10-01 11:40:57 -0700388 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700389 EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
Darin Petkov36275772010-10-01 11:40:57 -0700390}
391
392TEST_F(UpdateAttempterTest, MarkDeltaUpdateFailureTest) {
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800393 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700394 .WillOnce(Return(false))
Ben Chan672c1f52017-10-23 15:41:39 -0700395 .WillOnce(DoAll(SetArgPointee<1>(-1), Return(true)))
396 .WillOnce(DoAll(SetArgPointee<1>(1), Return(true)))
Darin Petkov36275772010-10-01 11:40:57 -0700397 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700398 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures),
Darin Petkov36275772010-10-01 11:40:57 -0700399 Return(true)));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800400 EXPECT_CALL(*prefs_, SetInt64(Ne(kPrefsDeltaUpdateFailures), _))
Darin Petkov2dd01092010-10-08 15:43:05 -0700401 .WillRepeatedly(Return(true));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800402 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures, 1)).Times(2);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700403 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures, 2));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800404 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures,
Gilad Arnold74b5f552014-10-07 08:17:16 -0700405 UpdateAttempter::kMaxDeltaUpdateFailures + 1));
Darin Petkov36275772010-10-01 11:40:57 -0700406 for (int i = 0; i < 4; i ++)
407 attempter_.MarkDeltaUpdateFailure();
408}
409
Darin Petkov1b003102010-11-30 10:18:36 -0800410TEST_F(UpdateAttempterTest, ScheduleErrorEventActionNoEventTest) {
411 EXPECT_CALL(*processor_, EnqueueAction(_)).Times(0);
412 EXPECT_CALL(*processor_, StartProcessing()).Times(0);
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700413 EXPECT_CALL(*fake_system_state_.mock_payload_state(), UpdateFailed(_))
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800414 .Times(0);
415 OmahaResponse response;
Jay Srinivasan53173b92013-05-17 17:13:01 -0700416 string url1 = "http://url1";
Sen Jiang0affc2c2017-02-10 15:55:05 -0800417 response.packages.push_back({.payload_urls = {url1, "https://url"}});
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700418 EXPECT_CALL(*(fake_system_state_.mock_payload_state()), GetCurrentUrl())
Jay Srinivasan53173b92013-05-17 17:13:01 -0700419 .WillRepeatedly(Return(url1));
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700420 fake_system_state_.mock_payload_state()->SetResponse(response);
Darin Petkov1b003102010-11-30 10:18:36 -0800421 attempter_.ScheduleErrorEventAction();
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700422 EXPECT_EQ(url1, fake_system_state_.mock_payload_state()->GetCurrentUrl());
Darin Petkov1b003102010-11-30 10:18:36 -0800423}
424
425TEST_F(UpdateAttempterTest, ScheduleErrorEventActionTest) {
426 EXPECT_CALL(*processor_,
427 EnqueueAction(Property(&AbstractAction::Type,
Gilad Arnold74b5f552014-10-07 08:17:16 -0700428 OmahaRequestAction::StaticType())));
429 EXPECT_CALL(*processor_, StartProcessing());
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700430 ErrorCode err = ErrorCode::kError;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700431 EXPECT_CALL(*fake_system_state_.mock_payload_state(), UpdateFailed(err));
Darin Petkov1b003102010-11-30 10:18:36 -0800432 attempter_.error_event_.reset(new OmahaEvent(OmahaEvent::kTypeUpdateComplete,
433 OmahaEvent::kResultError,
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800434 err));
Darin Petkov1b003102010-11-30 10:18:36 -0800435 attempter_.ScheduleErrorEventAction();
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700436 EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, attempter_.status());
Darin Petkov1b003102010-11-30 10:18:36 -0800437}
438
Darin Petkove6ef2f82011-03-07 17:31:11 -0800439namespace {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700440// Actions that will be built as part of an update check.
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700441const string kUpdateActionTypes[] = { // NOLINT(runtime/string)
Darin Petkove6ef2f82011-03-07 17:31:11 -0800442 OmahaRequestAction::StaticType(),
443 OmahaResponseHandlerAction::StaticType(),
Darin Petkove6ef2f82011-03-07 17:31:11 -0800444 OmahaRequestAction::StaticType(),
445 DownloadAction::StaticType(),
446 OmahaRequestAction::StaticType(),
Allie Woodeb9e6d82015-04-17 13:55:30 -0700447 FilesystemVerifierAction::StaticType(),
Darin Petkove6ef2f82011-03-07 17:31:11 -0800448 PostinstallRunnerAction::StaticType(),
449 OmahaRequestAction::StaticType()
450};
Chris Sosa76a29ae2013-07-11 17:59:24 -0700451
452// Actions that will be built as part of a user-initiated rollback.
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700453const string kRollbackActionTypes[] = { // NOLINT(runtime/string)
Chris Sosa76a29ae2013-07-11 17:59:24 -0700454 InstallPlanAction::StaticType(),
455 PostinstallRunnerAction::StaticType(),
456};
457
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700458} // namespace
Darin Petkove6ef2f82011-03-07 17:31:11 -0800459
460void UpdateAttempterTest::UpdateTestStart() {
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700461 attempter_.set_http_response_code(200);
Alex Deymo749ecf12014-10-21 20:06:57 -0700462
463 // Expect that the device policy is loaded by the UpdateAttempter at some
464 // point by calling RefreshDevicePolicy.
Igor9fd76b62017-12-11 15:24:18 +0100465 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Alex Deymo749ecf12014-10-21 20:06:57 -0700466 EXPECT_CALL(*device_policy, LoadPolicy())
467 .Times(testing::AtLeast(1)).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100468 attempter_.policy_provider_.reset(
469 new policy::PolicyProvider(std::move(device_policy)));
Alex Deymo749ecf12014-10-21 20:06:57 -0700470
471 {
472 InSequence s;
473 for (size_t i = 0; i < arraysize(kUpdateActionTypes); ++i) {
474 EXPECT_CALL(*processor_,
475 EnqueueAction(Property(&AbstractAction::Type,
Gilad Arnold74b5f552014-10-07 08:17:16 -0700476 kUpdateActionTypes[i])));
Alex Deymo749ecf12014-10-21 20:06:57 -0700477 }
Gilad Arnold74b5f552014-10-07 08:17:16 -0700478 EXPECT_CALL(*processor_, StartProcessing());
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700479 }
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700480
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200481 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700482 loop_.PostTask(FROM_HERE,
483 base::Bind(&UpdateAttempterTest::UpdateTestVerify,
484 base::Unretained(this)));
Darin Petkove6ef2f82011-03-07 17:31:11 -0800485}
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700486
Darin Petkove6ef2f82011-03-07 17:31:11 -0800487void UpdateAttempterTest::UpdateTestVerify() {
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700488 EXPECT_EQ(0, attempter_.http_response_code());
489 EXPECT_EQ(&attempter_, processor_->delegate());
Chris Sosa76a29ae2013-07-11 17:59:24 -0700490 EXPECT_EQ(arraysize(kUpdateActionTypes), attempter_.actions_.size());
491 for (size_t i = 0; i < arraysize(kUpdateActionTypes); ++i) {
492 EXPECT_EQ(kUpdateActionTypes[i], attempter_.actions_[i]->Type());
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700493 }
494 EXPECT_EQ(attempter_.response_handler_action_.get(),
495 attempter_.actions_[1].get());
Sen Jiangfef85fd2016-03-25 15:32:49 -0700496 AbstractAction* action_3 = attempter_.actions_[3].get();
497 ASSERT_NE(nullptr, action_3);
498 ASSERT_EQ(DownloadAction::StaticType(), action_3->Type());
499 DownloadAction* download_action = static_cast<DownloadAction*>(action_3);
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700500 EXPECT_EQ(&attempter_, download_action->delegate());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700501 EXPECT_EQ(UpdateStatus::CHECKING_FOR_UPDATE, attempter_.status());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700502 loop_.BreakLoop();
Darin Petkove6ef2f82011-03-07 17:31:11 -0800503}
504
Chris Sosa28e479c2013-07-12 11:39:53 -0700505void UpdateAttempterTest::RollbackTestStart(
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700506 bool enterprise_rollback, bool valid_slot) {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700507 // Create a device policy so that we can change settings.
Igor9fd76b62017-12-11 15:24:18 +0100508 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700509 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100510 fake_system_state_.set_device_policy(device_policy.get());
511 if (enterprise_rollback) {
512 // We return an empty owner as this is an enterprise.
513 EXPECT_CALL(*device_policy, GetOwner(_)).WillRepeatedly(
514 DoAll(SetArgPointee<0>(string("")),
515 Return(true)));
516 } else {
517 // We return a fake owner as this is an owned consumer device.
518 EXPECT_CALL(*device_policy, GetOwner(_)).WillRepeatedly(
519 DoAll(SetArgPointee<0>(string("fake.mail@fake.com")),
520 Return(true)));
521 }
522
523 attempter_.policy_provider_.reset(
524 new policy::PolicyProvider(std::move(device_policy)));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700525
Alex Deymo763e7db2015-08-27 21:08:08 -0700526 if (valid_slot) {
527 BootControlInterface::Slot rollback_slot = 1;
528 LOG(INFO) << "Test Mark Bootable: "
529 << BootControlInterface::SlotName(rollback_slot);
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700530 fake_system_state_.fake_boot_control()->SetSlotBootable(rollback_slot,
531 true);
Don Garrett6646b442013-11-13 15:29:11 -0800532 }
533
Chris Sosa28e479c2013-07-12 11:39:53 -0700534 bool is_rollback_allowed = false;
Chris Sosa76a29ae2013-07-11 17:59:24 -0700535
Chris Sosad38b1132014-03-25 10:43:59 -0700536 // We only allow rollback on devices that are not enterprise enrolled and
537 // which have a valid slot to rollback to.
538 if (!enterprise_rollback && valid_slot) {
Chris Sosa28e479c2013-07-12 11:39:53 -0700539 is_rollback_allowed = true;
540 }
541
Chris Sosa28e479c2013-07-12 11:39:53 -0700542 if (is_rollback_allowed) {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700543 InSequence s;
544 for (size_t i = 0; i < arraysize(kRollbackActionTypes); ++i) {
545 EXPECT_CALL(*processor_,
546 EnqueueAction(Property(&AbstractAction::Type,
Gilad Arnold74b5f552014-10-07 08:17:16 -0700547 kRollbackActionTypes[i])));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700548 }
Gilad Arnold74b5f552014-10-07 08:17:16 -0700549 EXPECT_CALL(*processor_, StartProcessing());
Chris Sosa76a29ae2013-07-11 17:59:24 -0700550
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700551 EXPECT_TRUE(attempter_.Rollback(true));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700552 loop_.PostTask(FROM_HERE,
553 base::Bind(&UpdateAttempterTest::RollbackTestVerify,
554 base::Unretained(this)));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700555 } else {
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700556 EXPECT_FALSE(attempter_.Rollback(true));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700557 loop_.BreakLoop();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700558 }
559}
560
561void UpdateAttempterTest::RollbackTestVerify() {
562 // Verifies the actions that were enqueued.
563 EXPECT_EQ(&attempter_, processor_->delegate());
564 EXPECT_EQ(arraysize(kRollbackActionTypes), attempter_.actions_.size());
565 for (size_t i = 0; i < arraysize(kRollbackActionTypes); ++i) {
566 EXPECT_EQ(kRollbackActionTypes[i], attempter_.actions_[i]->Type());
567 }
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700568 EXPECT_EQ(UpdateStatus::ATTEMPTING_ROLLBACK, attempter_.status());
Alex Deymo80f70ff2016-02-10 16:08:11 -0800569 AbstractAction* action_0 = attempter_.actions_[0].get();
570 ASSERT_NE(nullptr, action_0);
571 ASSERT_EQ(InstallPlanAction::StaticType(), action_0->Type());
Chris Sosa76a29ae2013-07-11 17:59:24 -0700572 InstallPlanAction* install_plan_action =
Alex Deymo80f70ff2016-02-10 16:08:11 -0800573 static_cast<InstallPlanAction*>(action_0);
Chris Sosa76a29ae2013-07-11 17:59:24 -0700574 InstallPlan* install_plan = install_plan_action->install_plan();
Alex Deymo80f70ff2016-02-10 16:08:11 -0800575 EXPECT_EQ(0U, install_plan->partitions.size());
Chris Sosa76a29ae2013-07-11 17:59:24 -0700576 EXPECT_EQ(install_plan->powerwash_required, true);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700577 loop_.BreakLoop();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700578}
579
Darin Petkove6ef2f82011-03-07 17:31:11 -0800580TEST_F(UpdateAttempterTest, UpdateTest) {
Alex Deymo461b2592015-07-24 20:10:52 -0700581 UpdateTestStart();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700582 loop_.Run();
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700583}
584
Chris Sosa76a29ae2013-07-11 17:59:24 -0700585TEST_F(UpdateAttempterTest, RollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700586 loop_.PostTask(FROM_HERE,
587 base::Bind(&UpdateAttempterTest::RollbackTestStart,
588 base::Unretained(this),
589 false, true));
590 loop_.Run();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700591}
592
Don Garrett6646b442013-11-13 15:29:11 -0800593TEST_F(UpdateAttempterTest, InvalidSlotRollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700594 loop_.PostTask(FROM_HERE,
595 base::Bind(&UpdateAttempterTest::RollbackTestStart,
596 base::Unretained(this),
597 false, false));
598 loop_.Run();
Don Garrett6646b442013-11-13 15:29:11 -0800599}
600
Chris Sosa76a29ae2013-07-11 17:59:24 -0700601TEST_F(UpdateAttempterTest, EnterpriseRollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700602 loop_.PostTask(FROM_HERE,
603 base::Bind(&UpdateAttempterTest::RollbackTestStart,
604 base::Unretained(this),
605 true, true));
606 loop_.Run();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700607}
608
Thieu Le116fda32011-04-19 11:01:54 -0700609void UpdateAttempterTest::PingOmahaTestStart() {
610 EXPECT_CALL(*processor_,
611 EnqueueAction(Property(&AbstractAction::Type,
Gilad Arnold74b5f552014-10-07 08:17:16 -0700612 OmahaRequestAction::StaticType())));
613 EXPECT_CALL(*processor_, StartProcessing());
Thieu Le116fda32011-04-19 11:01:54 -0700614 attempter_.PingOmaha();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700615 ScheduleQuitMainLoop();
Thieu Le116fda32011-04-19 11:01:54 -0700616}
617
618TEST_F(UpdateAttempterTest, PingOmahaTest) {
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700619 EXPECT_FALSE(attempter_.waiting_for_scheduled_check_);
620 EXPECT_FALSE(attempter_.schedule_updates_called());
621 // Disable scheduling of subsequnet checks; we're using the DefaultPolicy in
622 // testing, which is more permissive than we want to handle here.
623 attempter_.DisableScheduleUpdates();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700624 loop_.PostTask(FROM_HERE,
625 base::Bind(&UpdateAttempterTest::PingOmahaTestStart,
626 base::Unretained(this)));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700627 brillo::MessageLoopRunMaxIterations(&loop_, 100);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700628 EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700629 EXPECT_TRUE(attempter_.schedule_updates_called());
Thieu Le116fda32011-04-19 11:01:54 -0700630}
631
Darin Petkov18c7bce2011-06-16 14:07:00 -0700632TEST_F(UpdateAttempterTest, CreatePendingErrorEventTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -0800633 MockAction action;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700634 const ErrorCode kCode = ErrorCode::kDownloadTransferError;
Darin Petkov18c7bce2011-06-16 14:07:00 -0700635 attempter_.CreatePendingErrorEvent(&action, kCode);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700636 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov18c7bce2011-06-16 14:07:00 -0700637 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
638 EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700639 EXPECT_EQ(
640 static_cast<ErrorCode>(static_cast<int>(kCode) |
641 static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
642 attempter_.error_event_->error_code);
Darin Petkov18c7bce2011-06-16 14:07:00 -0700643}
644
645TEST_F(UpdateAttempterTest, CreatePendingErrorEventResumedTest) {
646 OmahaResponseHandlerAction *response_action =
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700647 new OmahaResponseHandlerAction(&fake_system_state_);
Darin Petkov18c7bce2011-06-16 14:07:00 -0700648 response_action->install_plan_.is_resume = true;
649 attempter_.response_handler_action_.reset(response_action);
Alex Deymo8427b4a2014-11-05 14:00:32 -0800650 MockAction action;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700651 const ErrorCode kCode = ErrorCode::kInstallDeviceOpenError;
Darin Petkov18c7bce2011-06-16 14:07:00 -0700652 attempter_.CreatePendingErrorEvent(&action, kCode);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700653 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov18c7bce2011-06-16 14:07:00 -0700654 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
655 EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700656 EXPECT_EQ(
657 static_cast<ErrorCode>(
658 static_cast<int>(kCode) |
659 static_cast<int>(ErrorCode::kResumedFlag) |
660 static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
661 attempter_.error_event_->error_code);
Darin Petkov18c7bce2011-06-16 14:07:00 -0700662}
663
David Zeuthen8f191b22013-08-06 12:27:50 -0700664TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenNotEnabled) {
665 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700666 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700667 mock_p2p_manager.fake().SetP2PEnabled(false);
668 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
669 attempter_.UpdateEngineStarted();
670}
671
672TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenEnabledButNotSharing) {
673 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700674 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700675 mock_p2p_manager.fake().SetP2PEnabled(true);
676 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
677 attempter_.UpdateEngineStarted();
678}
679
680TEST_F(UpdateAttempterTest, P2PStartedAtStartupWhenEnabledAndSharing) {
681 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700682 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700683 mock_p2p_manager.fake().SetP2PEnabled(true);
684 mock_p2p_manager.fake().SetCountSharedFilesResult(1);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700685 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning());
David Zeuthen8f191b22013-08-06 12:27:50 -0700686 attempter_.UpdateEngineStarted();
687}
688
689TEST_F(UpdateAttempterTest, P2PNotEnabled) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700690 loop_.PostTask(FROM_HERE,
691 base::Bind(&UpdateAttempterTest::P2PNotEnabledStart,
692 base::Unretained(this)));
693 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700694}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700695
David Zeuthen8f191b22013-08-06 12:27:50 -0700696void UpdateAttempterTest::P2PNotEnabledStart() {
697 // If P2P is not enabled, check that we do not attempt housekeeping
698 // and do not convey that p2p is to be used.
699 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700700 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700701 mock_p2p_manager.fake().SetP2PEnabled(false);
702 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200703 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700704 EXPECT_FALSE(actual_using_p2p_for_downloading_);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700705 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700706 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700707}
708
709TEST_F(UpdateAttempterTest, P2PEnabledStartingFails) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700710 loop_.PostTask(FROM_HERE,
711 base::Bind(&UpdateAttempterTest::P2PEnabledStartingFailsStart,
712 base::Unretained(this)));
713 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700714}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700715
David Zeuthen8f191b22013-08-06 12:27:50 -0700716void UpdateAttempterTest::P2PEnabledStartingFailsStart() {
717 // If p2p is enabled, but starting it fails ensure we don't do
718 // any housekeeping and do not convey that p2p should be used.
719 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700720 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700721 mock_p2p_manager.fake().SetP2PEnabled(true);
722 mock_p2p_manager.fake().SetEnsureP2PRunningResult(false);
723 mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
724 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200725 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700726 EXPECT_FALSE(actual_using_p2p_for_downloading());
727 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700728 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700729}
730
731TEST_F(UpdateAttempterTest, P2PEnabledHousekeepingFails) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700732 loop_.PostTask(
733 FROM_HERE,
734 base::Bind(&UpdateAttempterTest::P2PEnabledHousekeepingFailsStart,
735 base::Unretained(this)));
736 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700737}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700738
David Zeuthen8f191b22013-08-06 12:27:50 -0700739void UpdateAttempterTest::P2PEnabledHousekeepingFailsStart() {
740 // If p2p is enabled, starting it works but housekeeping fails, ensure
741 // we do not convey p2p is to be used.
742 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700743 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700744 mock_p2p_manager.fake().SetP2PEnabled(true);
745 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
746 mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700747 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200748 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700749 EXPECT_FALSE(actual_using_p2p_for_downloading());
750 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700751 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700752}
753
754TEST_F(UpdateAttempterTest, P2PEnabled) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700755 loop_.PostTask(FROM_HERE,
756 base::Bind(&UpdateAttempterTest::P2PEnabledStart,
757 base::Unretained(this)));
758 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700759}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700760
David Zeuthen8f191b22013-08-06 12:27:50 -0700761void UpdateAttempterTest::P2PEnabledStart() {
762 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700763 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700764 // If P2P is enabled and starting it works, check that we performed
765 // housekeeping and that we convey p2p should be used.
766 mock_p2p_manager.fake().SetP2PEnabled(true);
767 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
768 mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700769 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200770 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700771 EXPECT_TRUE(actual_using_p2p_for_downloading());
772 EXPECT_TRUE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700773 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700774}
775
776TEST_F(UpdateAttempterTest, P2PEnabledInteractive) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700777 loop_.PostTask(FROM_HERE,
778 base::Bind(&UpdateAttempterTest::P2PEnabledInteractiveStart,
779 base::Unretained(this)));
780 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700781}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700782
David Zeuthen8f191b22013-08-06 12:27:50 -0700783void UpdateAttempterTest::P2PEnabledInteractiveStart() {
784 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700785 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700786 // For an interactive check, if P2P is enabled and starting it
787 // works, check that we performed housekeeping and that we convey
788 // p2p should be used for sharing but NOT for downloading.
789 mock_p2p_manager.fake().SetP2PEnabled(true);
790 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
791 mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700792 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200793 attempter_.Update("",
794 "",
795 "",
796 "",
797 false,
798 false,
799 /*interactive=*/true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700800 EXPECT_FALSE(actual_using_p2p_for_downloading());
801 EXPECT_TRUE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700802 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700803}
804
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700805TEST_F(UpdateAttempterTest, ReadScatterFactorFromPolicy) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700806 loop_.PostTask(
807 FROM_HERE,
808 base::Bind(&UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart,
809 base::Unretained(this)));
810 loop_.Run();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700811}
812
813// Tests that the scatter_factor_in_seconds value is properly fetched
814// from the device policy.
815void UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart() {
Ben Chan9abb7632014-08-07 00:10:53 -0700816 int64_t scatter_factor_in_seconds = 36000;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700817
Igor9fd76b62017-12-11 15:24:18 +0100818 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700819 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100820 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700821
822 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
823 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700824 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700825 Return(true)));
826
Igor9fd76b62017-12-11 15:24:18 +0100827 attempter_.policy_provider_.reset(
828 new policy::PolicyProvider(std::move(device_policy)));
829
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200830 attempter_.Update("", "", "", "", false, false, false);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700831 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
832
Alex Deymo60ca1a72015-06-18 18:19:15 -0700833 ScheduleQuitMainLoop();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700834}
835
836TEST_F(UpdateAttempterTest, DecrementUpdateCheckCountTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700837 loop_.PostTask(
838 FROM_HERE,
839 base::Bind(&UpdateAttempterTest::DecrementUpdateCheckCountTestStart,
840 base::Unretained(this)));
841 loop_.Run();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700842}
843
844void UpdateAttempterTest::DecrementUpdateCheckCountTestStart() {
845 // Tests that the scatter_factor_in_seconds value is properly fetched
846 // from the device policy and is decremented if value > 0.
Ben Chan9abb7632014-08-07 00:10:53 -0700847 int64_t initial_value = 5;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800848 FakePrefs fake_prefs;
849 attempter_.prefs_ = &fake_prefs;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700850
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700851 fake_system_state_.fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
Jay Srinivasan08fce042012-06-07 16:31:01 -0700852
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800853 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700854
Ben Chan9abb7632014-08-07 00:10:53 -0700855 int64_t scatter_factor_in_seconds = 10;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700856
Igor9fd76b62017-12-11 15:24:18 +0100857 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700858 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100859 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700860
861 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
862 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700863 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700864 Return(true)));
865
Igor9fd76b62017-12-11 15:24:18 +0100866 attempter_.policy_provider_.reset(
867 new policy::PolicyProvider(std::move(device_policy)));
868
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200869 attempter_.Update("", "", "", "", false, false, false);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700870 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
871
872 // Make sure the file still exists.
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800873 EXPECT_TRUE(fake_prefs.Exists(kPrefsUpdateCheckCount));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700874
Ben Chan9abb7632014-08-07 00:10:53 -0700875 int64_t new_value;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800876 EXPECT_TRUE(fake_prefs.GetInt64(kPrefsUpdateCheckCount, &new_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700877 EXPECT_EQ(initial_value - 1, new_value);
878
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700879 EXPECT_TRUE(
880 attempter_.omaha_request_params_->update_check_count_wait_enabled());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700881
882 // However, if the count is already 0, it's not decremented. Test that.
883 initial_value = 0;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800884 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200885 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800886 EXPECT_TRUE(fake_prefs.Exists(kPrefsUpdateCheckCount));
887 EXPECT_TRUE(fake_prefs.GetInt64(kPrefsUpdateCheckCount, &new_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700888 EXPECT_EQ(initial_value, new_value);
889
Alex Deymo60ca1a72015-06-18 18:19:15 -0700890 ScheduleQuitMainLoop();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700891}
892
Jay Srinivasan08fce042012-06-07 16:31:01 -0700893TEST_F(UpdateAttempterTest, NoScatteringDoneDuringManualUpdateTestStart) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700894 loop_.PostTask(FROM_HERE, base::Bind(
895 &UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart,
896 base::Unretained(this)));
897 loop_.Run();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700898}
899
900void UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart() {
901 // Tests that no scattering logic is enabled if the update check
902 // is manually done (as opposed to a scheduled update check)
Ben Chan9abb7632014-08-07 00:10:53 -0700903 int64_t initial_value = 8;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800904 FakePrefs fake_prefs;
905 attempter_.prefs_ = &fake_prefs;
Jay Srinivasan08fce042012-06-07 16:31:01 -0700906
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700907 fake_system_state_.fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800908 fake_system_state_.set_prefs(&fake_prefs);
Jay Srinivasan08fce042012-06-07 16:31:01 -0700909
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800910 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsWallClockWaitPeriod, initial_value));
911 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Jay Srinivasan08fce042012-06-07 16:31:01 -0700912
913 // make sure scatter_factor is non-zero as scattering is disabled
914 // otherwise.
Ben Chan9abb7632014-08-07 00:10:53 -0700915 int64_t scatter_factor_in_seconds = 50;
Jay Srinivasan08fce042012-06-07 16:31:01 -0700916
Igor9fd76b62017-12-11 15:24:18 +0100917 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700918 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100919 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan08fce042012-06-07 16:31:01 -0700920
921 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
922 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700923 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan08fce042012-06-07 16:31:01 -0700924 Return(true)));
925
Igor9fd76b62017-12-11 15:24:18 +0100926 attempter_.policy_provider_.reset(
927 new policy::PolicyProvider(std::move(device_policy)));
928
Gilad Arnoldb92f0df2013-01-10 16:32:45 -0800929 // Trigger an interactive check so we can test that scattering is disabled.
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200930 attempter_.Update("",
931 "",
932 "",
933 "",
934 false,
935 false,
936 /*interactive=*/true);
Jay Srinivasan08fce042012-06-07 16:31:01 -0700937 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
938
939 // Make sure scattering is disabled for manual (i.e. user initiated) update
Jay Srinivasan21be0752012-07-25 15:44:56 -0700940 // checks and all artifacts are removed.
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700941 EXPECT_FALSE(
942 attempter_.omaha_request_params_->wall_clock_based_wait_enabled());
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800943 EXPECT_FALSE(fake_prefs.Exists(kPrefsWallClockWaitPeriod));
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700944 EXPECT_EQ(0, attempter_.omaha_request_params_->waiting_period().InSeconds());
945 EXPECT_FALSE(
946 attempter_.omaha_request_params_->update_check_count_wait_enabled());
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800947 EXPECT_FALSE(fake_prefs.Exists(kPrefsUpdateCheckCount));
Jay Srinivasan08fce042012-06-07 16:31:01 -0700948
Alex Deymo60ca1a72015-06-18 18:19:15 -0700949 ScheduleQuitMainLoop();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700950}
951
David Zeuthen985b1122013-10-09 12:13:15 -0700952// Checks that we only report daily metrics at most every 24 hours.
953TEST_F(UpdateAttempterTest, ReportDailyMetrics) {
954 FakeClock fake_clock;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800955 FakePrefs fake_prefs;
David Zeuthen985b1122013-10-09 12:13:15 -0700956
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700957 fake_system_state_.set_clock(&fake_clock);
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800958 fake_system_state_.set_prefs(&fake_prefs);
David Zeuthen985b1122013-10-09 12:13:15 -0700959
960 Time epoch = Time::FromInternalValue(0);
961 fake_clock.SetWallclockTime(epoch);
962
963 // If there is no kPrefsDailyMetricsLastReportedAt state variable,
964 // we should report.
965 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
966 // We should not report again if no time has passed.
967 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
968
969 // We should not report if only 10 hours has passed.
970 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(10));
971 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
972
973 // We should not report if only 24 hours - 1 sec has passed.
974 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(24) -
975 TimeDelta::FromSeconds(1));
976 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
977
978 // We should report if 24 hours has passed.
979 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(24));
980 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
981
982 // But then we should not report again..
983 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
984
985 // .. until another 24 hours has passed
986 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(47));
987 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
988 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(48));
989 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
990 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
991
992 // .. and another 24 hours
993 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(71));
994 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
995 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(72));
996 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
997 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
998
999 // If the span between time of reporting and present time is
1000 // negative, we report. This is in order to reset the timestamp and
1001 // avoid an edge condition whereby a distant point in the future is
1002 // in the state variable resulting in us never ever reporting again.
1003 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(71));
1004 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
1005 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
1006
1007 // In this case we should not update until the clock reads 71 + 24 = 95.
1008 // Check that.
1009 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(94));
1010 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
1011 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(95));
1012 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
1013 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
David Zeuthen985b1122013-10-09 12:13:15 -07001014}
1015
David Zeuthen3c55abd2013-10-14 12:48:03 -07001016TEST_F(UpdateAttempterTest, BootTimeInUpdateMarkerFile) {
David Zeuthen3c55abd2013-10-14 12:48:03 -07001017 FakeClock fake_clock;
1018 fake_clock.SetBootTime(Time::FromTimeT(42));
Gilad Arnold5bb4c902014-04-10 12:32:13 -07001019 fake_system_state_.set_clock(&fake_clock);
Alex Deymo906191f2015-10-12 12:22:44 -07001020 FakePrefs fake_prefs;
1021 fake_system_state_.set_prefs(&fake_prefs);
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001022 attempter_.Init();
David Zeuthen3c55abd2013-10-14 12:48:03 -07001023
1024 Time boot_time;
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001025 EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(&boot_time));
David Zeuthen3c55abd2013-10-14 12:48:03 -07001026
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001027 attempter_.WriteUpdateCompletedMarker();
David Zeuthen3c55abd2013-10-14 12:48:03 -07001028
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001029 EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(&boot_time));
David Zeuthen3c55abd2013-10-14 12:48:03 -07001030 EXPECT_EQ(boot_time.ToTimeT(), 42);
1031}
1032
David Pursell02c18642014-11-06 11:26:11 -08001033TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedUnofficial) {
1034 fake_system_state_.fake_hardware()->SetIsOfficialBuild(false);
1035 EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
1036}
1037
1038TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedOfficialDevmode) {
1039 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001040 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(true);
David Pursell02c18642014-11-06 11:26:11 -08001041 EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
1042}
1043
1044TEST_F(UpdateAttempterTest, AnyUpdateSourceDisallowedOfficialNormal) {
1045 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001046 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
David Pursell02c18642014-11-06 11:26:11 -08001047 EXPECT_FALSE(attempter_.IsAnyUpdateSourceAllowed());
1048}
1049
1050TEST_F(UpdateAttempterTest, CheckForUpdateAUTest) {
1051 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001052 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
Aaron Wood081c0232017-10-19 17:14:58 -07001053 attempter_.CheckForUpdate("", "autest", UpdateAttemptFlags::kNone);
Alex Deymoac41a822015-09-15 20:52:53 -07001054 EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
David Pursell02c18642014-11-06 11:26:11 -08001055}
1056
1057TEST_F(UpdateAttempterTest, CheckForUpdateScheduledAUTest) {
1058 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001059 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
Aaron Wood081c0232017-10-19 17:14:58 -07001060 attempter_.CheckForUpdate("", "autest-scheduled", UpdateAttemptFlags::kNone);
Alex Deymoac41a822015-09-15 20:52:53 -07001061 EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
David Pursell02c18642014-11-06 11:26:11 -08001062}
1063
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001064TEST_F(UpdateAttempterTest, TargetVersionPrefixSetAndReset) {
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001065 attempter_.CalculateUpdateParams("", "", "", "1234", false, false, false);
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001066 EXPECT_EQ("1234",
1067 fake_system_state_.request_params()->target_version_prefix());
1068
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001069 attempter_.CalculateUpdateParams("", "", "", "", false, false, false);
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001070 EXPECT_TRUE(
1071 fake_system_state_.request_params()->target_version_prefix().empty());
1072}
1073
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001074TEST_F(UpdateAttempterTest, RollbackAllowedSetAndReset) {
1075 attempter_.CalculateUpdateParams("",
1076 "",
1077 "",
1078 "1234",
1079 /*rollback_allowed=*/true,
1080 false,
1081 false);
1082 EXPECT_TRUE(fake_system_state_.request_params()->rollback_allowed());
1083
1084 attempter_.CalculateUpdateParams("",
1085 "",
1086 "",
1087 "1234",
1088 /*rollback_allowed=*/false,
1089 false,
1090 false);
1091 EXPECT_FALSE(fake_system_state_.request_params()->rollback_allowed());
1092}
1093
Aaron Wood23bd3392017-10-06 14:48:25 -07001094TEST_F(UpdateAttempterTest, UpdateDeferredByPolicyTest) {
1095 // Construct an OmahaResponseHandlerAction that has processed an InstallPlan,
1096 // but the update is being deferred by the Policy.
1097 OmahaResponseHandlerAction* response_action =
1098 new OmahaResponseHandlerAction(&fake_system_state_);
1099 response_action->install_plan_.version = "a.b.c.d";
1100 response_action->install_plan_.system_version = "b.c.d.e";
1101 response_action->install_plan_.payloads.push_back(
1102 {.size = 1234ULL, .type = InstallPayloadType::kFull});
1103 attempter_.response_handler_action_.reset(response_action);
1104 // Inform the UpdateAttempter that the OmahaResponseHandlerAction has
1105 // completed, with the deferred-update error code.
1106 attempter_.ActionCompleted(
1107 nullptr, response_action, ErrorCode::kOmahaUpdateDeferredPerPolicy);
1108 {
1109 UpdateEngineStatus status;
1110 attempter_.GetStatus(&status);
1111 EXPECT_EQ(UpdateStatus::UPDATE_AVAILABLE, status.status);
1112 EXPECT_EQ(response_action->install_plan_.version, status.new_version);
1113 EXPECT_EQ(response_action->install_plan_.system_version,
1114 status.new_system_version);
1115 EXPECT_EQ(response_action->install_plan_.payloads[0].size,
1116 status.new_size_bytes);
1117 }
1118 // An "error" event should have been created to tell Omaha that the update is
1119 // being deferred.
1120 EXPECT_TRUE(nullptr != attempter_.error_event_);
1121 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
1122 EXPECT_EQ(OmahaEvent::kResultUpdateDeferred, attempter_.error_event_->result);
1123 ErrorCode expected_code = static_cast<ErrorCode>(
1124 static_cast<int>(ErrorCode::kOmahaUpdateDeferredPerPolicy) |
1125 static_cast<int>(ErrorCode::kTestOmahaUrlFlag));
1126 EXPECT_EQ(expected_code, attempter_.error_event_->error_code);
1127 // End the processing
1128 attempter_.ProcessingDone(nullptr, ErrorCode::kOmahaUpdateDeferredPerPolicy);
1129 // Validate the state of the attempter.
1130 {
1131 UpdateEngineStatus status;
1132 attempter_.GetStatus(&status);
1133 EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, status.status);
1134 EXPECT_EQ(response_action->install_plan_.version, status.new_version);
1135 EXPECT_EQ(response_action->install_plan_.system_version,
1136 status.new_system_version);
1137 EXPECT_EQ(response_action->install_plan_.payloads[0].size,
1138 status.new_size_bytes);
1139 }
1140}
1141
1142TEST_F(UpdateAttempterTest, UpdateIsNotRunningWhenUpdateAvailable) {
1143 EXPECT_FALSE(attempter_.IsUpdateRunningOrScheduled());
1144 // Verify in-progress update with UPDATE_AVAILABLE is running
1145 attempter_.status_ = UpdateStatus::UPDATE_AVAILABLE;
1146 EXPECT_TRUE(attempter_.IsUpdateRunningOrScheduled());
1147}
1148
Aaron Woodbf5a2522017-10-04 10:58:36 -07001149TEST_F(UpdateAttempterTest, UpdateAttemptFlagsCachedAtUpdateStart) {
1150 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kFlagRestrictDownload);
1151
1152 UpdateCheckParams params = {.updates_enabled = true};
1153 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1154
1155 EXPECT_EQ(UpdateAttemptFlags::kFlagRestrictDownload,
1156 attempter_.GetCurrentUpdateAttemptFlags());
1157}
1158
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001159TEST_F(UpdateAttempterTest, RollbackNotAllowed) {
1160 UpdateCheckParams params = {.updates_enabled = true,
1161 .rollback_allowed = false};
1162 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1163 EXPECT_FALSE(fake_system_state_.request_params()->rollback_allowed());
1164}
1165
1166TEST_F(UpdateAttempterTest, RollbackAllowed) {
1167 UpdateCheckParams params = {.updates_enabled = true,
1168 .rollback_allowed = true};
1169 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1170 EXPECT_TRUE(fake_system_state_.request_params()->rollback_allowed());
1171}
1172
Aaron Wood081c0232017-10-19 17:14:58 -07001173TEST_F(UpdateAttempterTest, InteractiveUpdateUsesPassedRestrictions) {
1174 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kFlagRestrictDownload);
1175
1176 attempter_.CheckForUpdate("", "", UpdateAttemptFlags::kNone);
1177 EXPECT_EQ(UpdateAttemptFlags::kNone,
1178 attempter_.GetCurrentUpdateAttemptFlags());
1179}
1180
1181TEST_F(UpdateAttempterTest, NonInteractiveUpdateUsesSetRestrictions) {
1182 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kNone);
1183
1184 // This tests that when CheckForUpdate() is called with the non-interactive
1185 // flag set, that it doesn't change the current UpdateAttemptFlags.
1186 attempter_.CheckForUpdate("",
1187 "",
1188 UpdateAttemptFlags::kFlagNonInteractive |
1189 UpdateAttemptFlags::kFlagRestrictDownload);
1190 EXPECT_EQ(UpdateAttemptFlags::kNone,
1191 attempter_.GetCurrentUpdateAttemptFlags());
1192}
1193
Marton Hunyadye58bddb2018-04-10 20:27:26 +02001194void UpdateAttempterTest::ResetRollbackHappenedStart(bool is_consumer,
1195 bool is_policy_loaded,
1196 bool expected_reset) {
1197 EXPECT_CALL(*fake_system_state_.mock_payload_state(), GetRollbackHappened())
1198 .WillRepeatedly(Return(true));
1199 auto mock_policy_provider =
1200 std::make_unique<NiceMock<policy::MockPolicyProvider>>();
1201 EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
1202 .WillRepeatedly(Return(is_consumer));
1203 EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
1204 .WillRepeatedly(Return(is_policy_loaded));
1205 const policy::MockDevicePolicy device_policy;
1206 EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
1207 .WillRepeatedly(ReturnRef(device_policy));
1208 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1209 SetRollbackHappened(false))
1210 .Times(expected_reset ? 1 : 0);
1211 attempter_.policy_provider_ = std::move(mock_policy_provider);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001212 attempter_.Update("", "", "", "", false, false, false);
Marton Hunyadye58bddb2018-04-10 20:27:26 +02001213 ScheduleQuitMainLoop();
1214}
1215
1216TEST_F(UpdateAttempterTest, ResetRollbackHappenedOobe) {
1217 loop_.PostTask(FROM_HERE,
1218 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1219 base::Unretained(this),
1220 /*is_consumer=*/false,
1221 /*is_policy_loaded=*/false,
1222 /*expected_reset=*/false));
1223 loop_.Run();
1224}
1225
1226TEST_F(UpdateAttempterTest, ResetRollbackHappenedConsumer) {
1227 loop_.PostTask(FROM_HERE,
1228 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1229 base::Unretained(this),
1230 /*is_consumer=*/true,
1231 /*is_policy_loaded=*/false,
1232 /*expected_reset=*/true));
1233 loop_.Run();
1234}
1235
1236TEST_F(UpdateAttempterTest, ResetRollbackHappenedEnterprise) {
1237 loop_.PostTask(FROM_HERE,
1238 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1239 base::Unretained(this),
1240 /*is_consumer=*/false,
1241 /*is_policy_loaded=*/true,
1242 /*expected_reset=*/true));
1243 loop_.Run();
1244}
1245
Marton Hunyady199152d2018-05-07 19:08:48 +02001246TEST_F(UpdateAttempterTest, SetRollbackHappenedRollback) {
1247 OmahaResponseHandlerAction* response_action =
1248 new OmahaResponseHandlerAction(&fake_system_state_);
1249 response_action->install_plan_.is_rollback = true;
1250 attempter_.response_handler_action_.reset(response_action);
1251
1252 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1253 SetRollbackHappened(true))
1254 .Times(1);
1255 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1256}
1257
1258TEST_F(UpdateAttempterTest, SetRollbackHappenedNotRollback) {
1259 OmahaResponseHandlerAction* response_action =
1260 new OmahaResponseHandlerAction(&fake_system_state_);
1261 response_action->install_plan_.is_rollback = false;
1262 attempter_.response_handler_action_.reset(response_action);
1263
1264 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1265 SetRollbackHappened(true))
1266 .Times(0);
1267 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1268}
1269
Darin Petkovf42cc1c2010-09-01 09:03:02 -07001270} // namespace chromeos_update_engine