commit 3a58bb9d57063456945172ae7d199a6308c5823e
author Vitaly Buka <vitalybuka@chromium.org> Wed Aug 05 23:16:13 2015 -0700
committer Vitaly Buka <vitalybuka@chromium.org> Sun Aug 09 03:20:19 2015 -0700
tree 65f568ab9ee452da55b0a80d6ff088f995dc8ada
parent bf1c5a71109f60588c683c533ca77716f5adbfa3

libweave: Suppress mock warnings

We had several unimportant warning about uninteresting calls.
Change added StrictMock and sets reasonable expectations.
Warning make harder to investigate real failures and changed locations
are simple enoug to maintain strict mocks.

BUG=none
TEST='FEATURES=test emerge-gizmo libweave'

Change-Id: Ic5faf8e30e8e78261ba66a4093a87e63bcf383ae
Reviewed-on: https://chromium-review.googlesource.com/291077
Commit-Ready: Vitaly Buka <vitalybuka@chromium.org>
Tested-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>

buffet/dbus_command_proxy_unittest.cc

diff --git a/buffet/dbus_command_proxy_unittest.cc b/buffet/dbus_command_proxy_unittest.cc
index 18dd8e0..298df23 100644
--- a/buffet/dbus_command_proxy_unittest.cc
+++ b/buffet/dbus_command_proxy_unittest.cc
@@ -24,10 +24,11 @@
 
 namespace buffet {
 
+using ::testing::_;
 using ::testing::AnyNumber;
 using ::testing::Return;
 using ::testing::ReturnRefOfCopy;
-using ::testing::_;
+using ::testing::StrictMock;
 
 using chromeos::VariantDictionary;
 using chromeos::dbus_utils::AsyncEventSequencer;
@@ -49,6 +50,8 @@
 class DBusCommandProxyTest : public ::testing::Test {
  public:
   void SetUp() override {
+    EXPECT_CALL(command_, AddObserver(_)).Times(1);
+    EXPECT_CALL(command_, RemoveObserver(_)).Times(1);
     // Set up a mock DBus bus object.
     dbus::Bus::Options options;
     options.bus_type = dbus::Bus::SYSTEM;
@@ -121,7 +124,7 @@
   scoped_refptr<dbus::MockExportedObject> mock_exported_object_command_;
   scoped_refptr<dbus::MockBus> bus_;
 
-  weave::unittests::MockCommand command_;
+  StrictMock<weave::unittests::MockCommand> command_;
   std::unique_ptr<DBusCommandProxy> proxy_;
 };