asoc: Ratelimit error logs to avoid excessive logging
Ratelimit error logs of boundary check conditions
in audio effects driver to avoid excessive logging.
CRs-Fixed: 2426159
Change-Id: Iaf10eee281389773a21340997e3ffbe88c6e79f6
Signed-off-by: Aditya Bavanari <abavanar@codeaurora.org>
diff --git a/asoc/msm-audio-effects-q6-v2.c b/asoc/msm-audio-effects-q6-v2.c
index 5bab856..c8532df 100644
--- a/asoc/msm-audio-effects-q6-v2.c
+++ b/asoc/msm-audio-effects-q6-v2.c
@@ -1,4 +1,4 @@
-/* Copyright (c) 2013-2017, The Linux Foundation. All rights reserved.
+/* Copyright (c) 2013-2017, 2019, The Linux Foundation. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 and
@@ -11,6 +11,7 @@
*/
#include <linux/slab.h>
+#include <linux/ratelimit.h>
#include <sound/compress_params.h>
#include <sound/devdep_params.h>
#include <dsp/apr_audio-v2.h>
@@ -22,7 +23,8 @@
#define GET_NEXT(ptr, upper_limit, rc) \
({ \
if (((ptr) + 1) > (upper_limit)) { \
- pr_err("%s: param list out of boundary\n", __func__); \
+ pr_err_ratelimited("%s: param list out of boundary\n", \
+ __func__); \
(rc) = -EINVAL; \
} \
((rc) == 0) ? *(ptr)++ : -EINVAL; \
@@ -31,7 +33,8 @@
#define CHECK_PARAM_LEN(len, max_len, tag, rc) \
do { \
if ((len) > (max_len)) { \
- pr_err("%s: params length overflows\n", (tag)); \
+ pr_err_ratelimited("%s: params length overflows\n", \
+ (tag)); \
(rc) = -EINVAL; \
} \
} while (0)
@@ -266,7 +269,8 @@
}
break;
default:
- pr_err("%s: Invalid command to set config\n", __func__);
+ pr_err_ratelimited("%s: Invalid command to set config\n",
+ __func__);
break;
}
}
@@ -747,7 +751,8 @@
}
break;
default:
- pr_err("%s: Invalid command to set config\n", __func__);
+ pr_err_ratelimited("%s: Invalid command to set config\n",
+ __func__);
break;
}
}
@@ -893,7 +898,8 @@
}
break;
default:
- pr_err("%s: Invalid command to set config\n", __func__);
+ pr_err_ratelimited("%s: Invalid command to set config\n",
+ __func__);
break;
}
}
@@ -1013,7 +1019,8 @@
}
break;
default:
- pr_err("%s: Invalid command to set config\n", __func__);
+ pr_err_ratelimited("%s: Invalid command to set config\n",
+ __func__);
break;
}
}
@@ -1254,7 +1261,8 @@
}
break;
default:
- pr_err("%s: Invalid command to set config\n", __func__);
+ pr_err_ratelimited("%s: Invalid command to set config\n",
+ __func__);
break;
}
}
@@ -1410,7 +1418,7 @@
}
break;
default:
- pr_err("%s: Invalid command id: %d to set config\n",
+ pr_err_ratelimited("%s: Invalid command id: %d to set config\n",
__func__, command_id);
break;
}