commit 15c6544892e469e6ea0008b5cbede1e0bbb24e4b
author Dundi Raviteja <dundi@codeaurora.org> Tue Sep 29 17:15:40 2020 +0530
committer Dundi Raviteja <dundi@codeaurora.org> Wed Oct 07 10:11:40 2020 +0530
tree 13693b602d57927c04b2799e82470819c010af51
parent aa17c3a01e26b93cd9b88a390d5fb42cc38bafc9

wlan: Move list deletion logic under spinlock

Data queue list_del can cause race condition while
adding to list with list_add.

To avoid this move list_del logic under spinlock.

Change-Id: I75f3b5767e861fb6c0212afd38230443ae346d69
CRs-Fixed: 2792376

CORE/WDI/TRP/CTS/src/wlan_qct_wdi_cts.c

diff --git a/CORE/WDI/TRP/CTS/src/wlan_qct_wdi_cts.c b/CORE/WDI/TRP/CTS/src/wlan_qct_wdi_cts.c
index df78b64..ff3abe2 100644
--- a/CORE/WDI/TRP/CTS/src/wlan_qct_wdi_cts.c
+++ b/CORE/WDI/TRP/CTS/src/wlan_qct_wdi_cts.c
@@ -253,8 +253,8 @@
 
       msg = list_first_entry(&pWCTSCb->wctsDataMsg.data_queue,
                              struct data_msg, list);
-      spin_unlock_irqrestore(&pWCTSCb->wctsDataMsg.data_queue_lock, flags);
       list_del(&msg->list);
+      spin_unlock_irqrestore(&pWCTSCb->wctsDataMsg.data_queue_lock, flags);
 
       buffer = msg->buffer;
       packet_size = msg->buf_len;