wlan: Remove redundant MTRACE logs
Currently few MTRACE logs captured repetitively which leads to
overwriting of other important MTRACE logs.
To avoid this,
1. Remove MTRACE logs which are seen repetitively in scan,
connect/disconnect path and few timer functions.
2. MTRACE log captured for few enums in both limProcessMessages() and
limProcessMlmReqMessages(). To avoid redundancy remove MTRACE in
limProcessMlmReqMessages() and add in limPostMlmMessage() for which
are not captured in limProcessMessages.
3. Similar way for limProcessSmeReqMessages() also, remove MTRACE in
limProcessSmeReqMessages() and add in limPostSmeMessage().
Change-Id: Ic722648695f036ea1efe50a07ca121dda9f2bcaa
CRs-Fixed: 855840
diff --git a/CORE/MAC/src/pe/include/limTrace.h b/CORE/MAC/src/pe/include/limTrace.h
index df234cb..13f1e26 100644
--- a/CORE/MAC/src/pe/include/limTrace.h
+++ b/CORE/MAC/src/pe/include/limTrace.h
@@ -81,7 +81,6 @@
TRACE_CODE_TX_CFG_MSG,
TRACE_CODE_RX_CFG_MSG,
TRACE_CODE_RX_MGMT_DROP,
- TRACE_CODE_RX_MGMT_PROCESS,
TRACE_CODE_TIMER_ACTIVATE,
TRACE_CODE_TIMER_DEACTIVATE,
diff --git a/CORE/MAC/src/pe/lim/limApi.c b/CORE/MAC/src/pe/lim/limApi.c
index dcc8f82..47158e0 100644
--- a/CORE/MAC/src/pe/lim/limApi.c
+++ b/CORE/MAC/src/pe/lim/limApi.c
@@ -1379,10 +1379,6 @@
FL ( "RxBd=%p mHdr=%p Type: %d Subtype: %d Sizes:FC%d Mgmt%d"),
pRxPacketInfo, mHdr, mHdr->fc.type, mHdr->fc.subType, sizeof(tSirMacFrameCtl), sizeof(tSirMacMgmtHdr) );)
- MTRACE(macTrace(pMac, TRACE_CODE_RX_MGMT, NO_SESSION,
- LIM_TRACE_MAKE_RXMGMT(mHdr->fc.subType,
- (tANI_U16) (((tANI_U16) (mHdr->seqControl.seqNumHi << 4)) | mHdr->seqControl.seqNumLo)));)
-
#ifdef WLAN_FEATURE_ROAM_SCAN_OFFLOAD
if (WDA_GET_ROAMCANDIDATEIND(pRxPacketInfo))
limLog(pMac, LOG1, FL("roamCandidateInd %d"),
diff --git a/CORE/MAC/src/pe/lim/limProcessMessageQueue.c b/CORE/MAC/src/pe/lim/limProcessMessageQueue.c
index 10c0a7b..70b4983 100644
--- a/CORE/MAC/src/pe/lim/limProcessMessageQueue.c
+++ b/CORE/MAC/src/pe/lim/limProcessMessageQueue.c
@@ -1287,7 +1287,16 @@
limMsgStr(limMsg->type), limSmeStateStr(pMac->lim.gLimSmeState),
limMlmStateStr(pMac->lim.gLimMlmState));)
- MTRACE(macTraceMsgRx(pMac, NO_SESSION, LIM_TRACE_MAKE_RXMSG(limMsg->type, LIM_MSG_PROCESSED));)
+ /* Omitting below message types as these are too frequent and when crash
+ * happens we loose critical trace logs if these are also logged
+ */
+ if (limMsg->type != SIR_LIM_MAX_CHANNEL_TIMEOUT &&
+ limMsg->type != SIR_LIM_MIN_CHANNEL_TIMEOUT &&
+ limMsg->type != SIR_LIM_PERIODIC_PROBE_REQ_TIMEOUT &&
+ limMsg->type != SIR_CFG_PARAM_UPDATE_IND &&
+ limMsg->type != SIR_BB_XPORT_MGMT_MSG)
+ MTRACE(macTraceMsgRx(pMac, NO_SESSION,
+ LIM_TRACE_MAKE_RXMSG(limMsg->type, LIM_MSG_PROCESSED));)
switch (limMsg->type)
{
@@ -1367,7 +1376,6 @@
vos_pkt_t *pVosPkt;
VOS_STATUS vosStatus;
tSirMsgQ limMsgNew;
- MTRACE(macTrace(pMac, TRACE_CODE_RX_MGMT_PROCESS, 0, 0 );)
/* The original limMsg which we were deferring have the
* bodyPointer point to 'BD' instead of 'Vos pkt'. If we don't make a copy
* of limMsg, then vos_pkt_peek_data will overwrite the limMsg->bodyPointer.
@@ -1435,14 +1443,11 @@
* Asumption here is when Rx mgmt frame processing is done,
* voss packet could be freed here.
*/
- MTRACE(macTrace(pMac, TRACE_CODE_RX_MGMT_PROCESS, 0, 3 );)
limDecrementPendingMgmtCount(pMac);
vos_pkt_return_packet(pVosPkt);
}
}
- MTRACE(macTrace(pMac, TRACE_CODE_RX_MGMT_PROCESS, 0, 4 );)
break;
-
case eWNI_SME_SCAN_REQ:
case eWNI_SME_REMAIN_ON_CHANNEL_REQ:
case eWNI_SME_DISASSOC_REQ:
diff --git a/CORE/MAC/src/pe/lim/limProcessMlmReqMessages.c b/CORE/MAC/src/pe/lim/limProcessMlmReqMessages.c
index 90aabe1..3f8ba9f 100644
--- a/CORE/MAC/src/pe/lim/limProcessMlmReqMessages.c
+++ b/CORE/MAC/src/pe/lim/limProcessMlmReqMessages.c
@@ -127,7 +127,6 @@
void
limProcessMlmReqMessages(tpAniSirGlobal pMac, tpSirMsgQ Msg)
{
- MTRACE(macTraceMsgRx(pMac, NO_SESSION, Msg->type));
switch (Msg->type)
{
case LIM_MLM_START_REQ: limProcessMlmStartReq(pMac, Msg->bodyptr); break;
@@ -495,9 +494,6 @@
*/
pMac->lim.limTimers.gLimMinChannelTimer.sessionId = sessionId;
#endif
-
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, NO_SESSION, eLIM_MIN_CHANNEL_TIMER));
-
if (tx_timer_activate(&pMac->lim.limTimers.gLimMinChannelTimer) != TX_SUCCESS)
{
limLog(pMac, LOGP, FL("could not start min channel timer"));
@@ -515,7 +511,6 @@
#endif
//No Need to start Min channel timer. Start Max Channel timer.
limDeactivateAndChangeTimer(pMac, eLIM_MAX_CHANNEL_TIMER);
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, pMac->lim.limTimers.gLimMaxChannelTimer.sessionId, eLIM_MAX_CHANNEL_TIMER));
if (tx_timer_activate(&pMac->lim.limTimers.gLimMaxChannelTimer)
== TX_TIMER_ERROR)
{
@@ -539,7 +534,6 @@
return;
}
periodicScanTimer->sessionId = channelNum;
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, periodicScanTimer->sessionId, eLIM_PERIODIC_PROBE_REQ_TIMER));
}
else
{
@@ -547,7 +541,6 @@
limLog(pMac, LOG1, FL("START PASSIVE Scan chan %d"), channelNum);
/// Passive Scanning. Activate maxChannelTimer
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, NO_SESSION, eLIM_MAX_CHANNEL_TIMER));
if (tx_timer_deactivate(&pMac->lim.limTimers.gLimMaxChannelTimer)
!= TX_SUCCESS)
{
@@ -596,7 +589,6 @@
#endif
//Pick the longer stay time
val = (val > val1) ? val : val1;
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, NO_SESSION, eLIM_MAX_CHANNEL_TIMER));
if (tx_timer_change(&pMac->lim.limTimers.gLimMaxChannelTimer,
val, 0) != TX_SUCCESS)
{
@@ -4064,7 +4056,6 @@
} while (i < pLimMlmScanReq->numSsid);
/* Activate timer again */
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, pPeriodicProbeReqTimer->sessionId, eLIM_PERIODIC_PROBE_REQ_TIMER));
if (tx_timer_activate(pPeriodicProbeReqTimer) != TX_SUCCESS)
{
limLog(pMac, LOGP, FL("could not start periodic probe"
diff --git a/CORE/MAC/src/pe/lim/limProcessSmeReqMessages.c b/CORE/MAC/src/pe/lim/limProcessSmeReqMessages.c
index 599ca66..7b5bef2 100644
--- a/CORE/MAC/src/pe/lim/limProcessSmeReqMessages.c
+++ b/CORE/MAC/src/pe/lim/limProcessSmeReqMessages.c
@@ -5490,7 +5490,6 @@
* want to insert NOA before processing those msgs. These msgs will be processed later when
* start event happens
*/
- MTRACE(macTraceMsgRx(pMac, NO_SESSION, pMsg->type));
switch (pMsg->type)
{
case eWNI_SME_SCAN_REQ:
diff --git a/CORE/MAC/src/pe/lim/limScanResultUtils.c b/CORE/MAC/src/pe/lim/limScanResultUtils.c
index 076cdd7..1768d66 100644
--- a/CORE/MAC/src/pe/lim/limScanResultUtils.c
+++ b/CORE/MAC/src/pe/lim/limScanResultUtils.c
@@ -79,7 +79,6 @@
*/
limDeactivateAndChangeTimer(pMac,eLIM_MIN_CHANNEL_TIMER);
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, NO_SESSION, eLIM_MAX_CHANNEL_TIMER));
if (tx_timer_activate(&pMac->lim.limTimers.gLimMaxChannelTimer)
== TX_TIMER_ERROR)
{
diff --git a/CORE/MAC/src/pe/lim/limTimerUtils.c b/CORE/MAC/src/pe/lim/limTimerUtils.c
index d94d8f1..5654a07 100644
--- a/CORE/MAC/src/pe/lim/limTimerUtils.c
+++ b/CORE/MAC/src/pe/lim/limTimerUtils.c
@@ -991,8 +991,6 @@
tANI_U32 val=0, val1=0;
tpPESession psessionEntry;
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, NO_SESSION, timerId));
-
switch (timerId)
{
case eLIM_ADDTS_RSP_TIMER:
@@ -1815,7 +1813,6 @@
return;
}
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, psessionEntry->peSessionId, eLIM_HEART_BEAT_TIMER));
#ifdef WLAN_ACTIVEMODE_OFFLOAD_FEATURE
if(IS_ACTIVEMODE_OFFLOAD_FEATURE_ENABLE)
return;
@@ -1889,7 +1886,6 @@
#endif
limHeartBeatDeactivateAndChangeTimer(pMac, psessionEntry);
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, psessionEntry->peSessionId, eLIM_HEART_BEAT_TIMER));
//only start the hearbeat-timer if the timeout value is non-zero
if(pMac->lim.limTimers.gLimHeartBeatTimer.initScheduleTimeInMsecs > 0)
@@ -2033,7 +2029,6 @@
limDeactivateAndChangePerStaIdTimer(tpAniSirGlobal pMac, tANI_U32 timerId, tANI_U16 staId)
{
tANI_U32 val;
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, NO_SESSION, timerId));
switch (timerId)
{
@@ -2144,7 +2139,6 @@
void limActivateCnfTimer(tpAniSirGlobal pMac, tANI_U16 staId, tpPESession psessionEntry)
{
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, psessionEntry->peSessionId, eLIM_CNF_WAIT_TIMER));
pMac->lim.limTimers.gpLimCnfWaitTimer[staId].sessionId = psessionEntry->peSessionId;
if (tx_timer_activate(&pMac->lim.limTimers.gpLimCnfWaitTimer[staId])
!= TX_SUCCESS)
@@ -2176,7 +2170,6 @@
void limActivateAuthRspTimer(tpAniSirGlobal pMac, tLimPreAuthNode *pAuthNode)
{
- MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, NO_SESSION, eLIM_AUTH_RESP_TIMER));
if (tx_timer_activate(&pAuthNode->timer) != TX_SUCCESS)
{
/// Could not activate auth rsp timer.
diff --git a/CORE/MAC/src/pe/lim/limTypes.h b/CORE/MAC/src/pe/lim/limTypes.h
index f3ee585..6efabdb 100644
--- a/CORE/MAC/src/pe/lim/limTypes.h
+++ b/CORE/MAC/src/pe/lim/limTypes.h
@@ -51,6 +51,7 @@
#include "limApi.h"
#include "limDebug.h"
+#include "limTrace.h"
#include "limSendSmeRspMessages.h"
#include "sysGlobal.h"
#include "dphGlobal.h"
@@ -907,7 +908,10 @@
msg.bodyptr = pMsgBuf;
msg.bodyval = 0;
if (msgType > eWNI_SME_MSG_TYPES_BEGIN)
+ {
+ MTRACE(macTrace(pMac, TRACE_CODE_TX_SME_MSG, NO_SESSION, msg.type));
limProcessSmeReqMessages(pMac, &msg);
+ }
else
limProcessMlmRspMessages(pMac, msgType, pMsgBuf);
} /*** end limPostSmeMessage() ***/
@@ -950,6 +954,7 @@
msg.type = (tANI_U16) msgType;
msg.bodyptr = pMsgBuf;
msg.bodyval = 0;
+ MTRACE(macTraceMsgRx(pMac, NO_SESSION, msg.type));
limProcessMlmReqMessages(pMac, &msg);
} /*** end limPostMlmMessage() ***/
diff --git a/CORE/MAC/src/pe/sch/schBeaconProcess.c b/CORE/MAC/src/pe/sch/schBeaconProcess.c
index 53944d4..727b06b 100644
--- a/CORE/MAC/src/pe/sch/schBeaconProcess.c
+++ b/CORE/MAC/src/pe/sch/schBeaconProcess.c
@@ -643,7 +643,6 @@
/* Obtain the Max Tx power for the current regulatory */
regMax = cfgGetRegulatoryMaxTransmitPower( pMac, psessionEntry->currentOperChannel );
#endif
- MTRACE(macTrace(pMac, TRACE_CODE_RX_MGMT_PROCESS, 0, 2 );)
#if defined WLAN_FEATURE_VOWIFI
{
tPowerdBm localRRMConstraint = 0;
@@ -748,7 +747,6 @@
return;
}
- MTRACE(macTrace(pMac, TRACE_CODE_RX_MGMT_PROCESS, 0, 1 );)
if (beaconStruct.ssidPresent)
{
beaconStruct.ssId.ssId[beaconStruct.ssId.length] = 0;
diff --git a/CORE/SME/src/sme_common/sme_Api.c b/CORE/SME/src/sme_common/sme_Api.c
index 443de97..a4a1674 100644
--- a/CORE/SME/src/sme_common/sme_Api.c
+++ b/CORE/SME/src/sme_common/sme_Api.c
@@ -3087,8 +3087,6 @@
tpAniSirGlobal pMac = PMAC_STRUCT( hHal );
tCsrScanResultInfo *pRet = NULL;
- MTRACE(vos_trace(VOS_MODULE_ID_SME ,
- TRACE_CODE_SME_RX_HDD_MSG_SCAN_RESULT_GETNEXT, NO_SESSION,0 ));
status = sme_AcquireGlobalLock( &pMac->sme );
if ( HAL_STATUS_SUCCESS( status ) )
{
diff --git a/CORE/TL/src/wlan_qct_tl.c b/CORE/TL/src/wlan_qct_tl.c
index 613ab3e..62381c7 100644
--- a/CORE/TL/src/wlan_qct_tl.c
+++ b/CORE/TL/src/wlan_qct_tl.c
@@ -2161,11 +2161,6 @@
vos_atomic_set_U8( &pClientSTA->ucPktPending, 1);
- MTRACE(vos_trace(VOS_MODULE_ID_TL, TRACE_CODE_TL_STA_PKT_PENDING, ucSTAId,
- (pTLCb->ucTxSuspended << 31) |
- ((pTLCb->uResCount >= WDA_TLI_MIN_RES_DATA) << 30) |
- pClientSTA->tlState));
-
/*------------------------------------------------------------------------
Check if there are enough resources for transmission and tx is not
suspended.