commit 4fed1e3859a493fdb45489e1d96d194bcf5972c7
author Sushant Kaushik <skaushik@qti.qualcomm.com> Sat Feb 21 12:43:46 2015 +0530
committer Satyanarayana Dash <c_sadash@qti.qualcomm.com> Tue Feb 24 23:29:54 2015 +0530
tree ed7c174ce05323d9a88be0798fb43288f9464f17
parent 4fb4da7ff7ed22e04aac93d460bfdf494528c403

wlan: Fix Static analysis error.

Currently in PopulateDot11fWscInProbeRes function, there are
many instances where for an array of size n, nth index is being
used. This result in array bound overflow. As a part of fix, make
sure that n-1th index is used to acess nth index of array.

Change-Id: I571b3dedf897e5ed2f1a11db911e95e34bdfb705
CRs-Fixed: 798564

CORE/SYS/legacy/src/utils/src/parserApi.c

diff --git a/CORE/SYS/legacy/src/utils/src/parserApi.c b/CORE/SYS/legacy/src/utils/src/parserApi.c
index 5732ce6..c3f7969 100644
--- a/CORE/SYS/legacy/src/utils/src/parserApi.c
+++ b/CORE/SYS/legacy/src/utils/src/parserApi.c
@@ -5023,7 +5023,7 @@
     else
     {
         pDot11f->Manufacturer.num_name = (tANI_U8) (cfgStrLen & 0x000000FF);
-        pDot11f->Manufacturer.name[cfgStrLen] = '\0';
+        pDot11f->Manufacturer.name[cfgStrLen - 1] = '\0';
     }
 
     pDot11f->ModelName.present = 1;
@@ -5039,7 +5039,7 @@
     else
     {
         pDot11f->ModelName.num_text = (tANI_U8) (cfgStrLen & 0x000000FF);
-        pDot11f->ModelName.text[cfgStrLen] = '\0';
+        pDot11f->ModelName.text[cfgStrLen - 1] = '\0';
     }
 
     pDot11f->ModelNumber.present = 1;
@@ -5055,7 +5055,7 @@
     else
     {
         pDot11f->ModelNumber.num_text = (tANI_U8) (cfgStrLen & 0x000000FF);
-        pDot11f->ModelNumber.text[cfgStrLen] = '\0';
+        pDot11f->ModelNumber.text[cfgStrLen - 1] = '\0';
     }
 
     pDot11f->SerialNumber.present = 1;
@@ -5071,7 +5071,7 @@
     else
     {
         pDot11f->SerialNumber.num_text = (tANI_U8) (cfgStrLen & 0x000000FF);
-        pDot11f->SerialNumber.text[cfgStrLen] = '\0';
+        pDot11f->SerialNumber.text[cfgStrLen - 1] = '\0';
     }
 
     pDot11f->PrimaryDeviceType.present = 1;
@@ -5115,7 +5115,7 @@
     else
     {
         pDot11f->DeviceName.num_text = (tANI_U8) (cfgStrLen & 0x000000FF);
-        pDot11f->DeviceName.text[cfgStrLen] = '\0';
+        pDot11f->DeviceName.text[cfgStrLen - 1] = '\0';
     }
 
     if (wlan_cfgGetInt(pMac,