commit 6804574fefd52095fe6bb0ae0e9968df2fbe60eb
author Yue Ma <yuem@qca.qualcomm.com> Wed Apr 17 10:48:13 2013 -0700
committer Gopichand Nakkala <gnakkala@qca.qualcomm.com> Wed Apr 24 22:18:19 2013 -0700
tree 5c6c38d1eef141091d9aa096020ce93f86a3c8d8
parent f2695c1d825e9a0129da338d928e1bc9ac82354c

wlan: Static source code analysis fixes for VOSS and WDI

Fix potential buffer index problems for WLAN host driver VOSS and WDI
modules based on the static source code analysis.

Change-Id: I9570abd9ce65991ad1fd6fc2b41d8b231e0fa7e0
CRs-fixed: 466197

CORE/VOSS/src/vos_trace.c

diff --git a/CORE/VOSS/src/vos_trace.c b/CORE/VOSS/src/vos_trace.c
index 13ffded..e1cff2a 100644
--- a/CORE/VOSS/src/vos_trace.c
+++ b/CORE/VOSS/src/vos_trace.c
@@ -269,7 +269,7 @@
                    (char *) gVosTraceInfo[ module ].moduleNameStr );
 
       // print the formatted log message after the prefix string.
-      if (n < VOS_TRACE_BUFFER_SIZE)
+      if ((n >= 0) && (n < VOS_TRACE_BUFFER_SIZE))
       {
          vsnprintf(strBuffer + n, VOS_TRACE_BUFFER_SIZE - n, strFormat, val );
          pr_err("%s\n", strBuffer);

CORE/WDI/WPAL/src/wlan_qct_pal_trace.c

diff --git a/CORE/WDI/WPAL/src/wlan_qct_pal_trace.c b/CORE/WDI/WPAL/src/wlan_qct_pal_trace.c
index 914e00f..e2c86ac 100644
--- a/CORE/WDI/WPAL/src/wlan_qct_pal_trace.c
+++ b/CORE/WDI/WPAL/src/wlan_qct_pal_trace.c
@@ -284,7 +284,7 @@
 
       // print the formatted log message after the prefix string.
       // note we reserve space for the terminating NUL
-      if (n < WPAL_TRACE_BUFFER_SIZE)
+      if ((n >= 0) && (n < WPAL_TRACE_BUFFER_SIZE))
       {
          vsnprintf(strBuffer + n, WPAL_TRACE_BUFFER_SIZE - n - 1, strFormat, val);
          wpalOutput(level, strBuffer);