Wlan: Remove unnecessary error logs
Remove frequently seen unnecessary error logs in kmesg from
driver.
Change-Id: I708c11fc40fc3e7ca7fb71bf83f994f08463108d
CRs-Fixed: 971507
diff --git a/CORE/HDD/src/wlan_hdd_main.c b/CORE/HDD/src/wlan_hdd_main.c
index d4bd35a..adc346b 100755
--- a/CORE/HDD/src/wlan_hdd_main.c
+++ b/CORE/HDD/src/wlan_hdd_main.c
@@ -4003,14 +4003,14 @@
}
else if (strncmp(command, "SCAN-ACTIVE", 11) == 0)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
- FL("making default scan to ACTIVE"));
+ hddLog(LOG1,
+ FL("making default scan to ACTIVE"));
pHddCtx->scan_info.scan_mode = eSIR_ACTIVE_SCAN;
}
else if (strncmp(command, "SCAN-PASSIVE", 12) == 0)
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
- FL("making default scan to PASSIVE"));
+ hddLog(LOG1,
+ FL("making default scan to PASSIVE"));
pHddCtx->scan_info.scan_mode = eSIR_PASSIVE_SCAN;
}
else if (strncmp(command, "GETDWELLTIME", 12) == 0)
diff --git a/CORE/HDD/src/wlan_hdd_tdls.c b/CORE/HDD/src/wlan_hdd_tdls.c
index f801520..a7512b3 100644
--- a/CORE/HDD/src/wlan_hdd_tdls.c
+++ b/CORE/HDD/src/wlan_hdd_tdls.c
@@ -1072,9 +1072,10 @@
if (test_bit(TDLS_INIT_DONE, &pAdapter->event_flags))
{
- VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
- "%s: TDLS INIT DONE set to 1, no point in re-init", __func__);
- return -EALREADY;
+ hddLog(LOG1,
+ FL("TDLS INIT DONE set to 1, no point in re-init"));
+ /* Return success as TDLS is already initialized */
+ return 0;
}
if ((FALSE == pHddCtx->cfg_ini->fEnableTDLSSupport) ||
@@ -2469,7 +2470,7 @@
if (0 != wlan_hdd_sta_tdls_init(pAdapter))
{
mutex_unlock(&pHddCtx->tdls_lock);
- hddLog(VOS_TRACE_LEVEL_ERROR,"%s: wlan_hdd_sta_tdls_init failed",__func__);
+ hddLog(LOGE, FL("wlan_hdd_sta_tdls_init failed"));
return;
}
diff --git a/CORE/HDD/src/wlan_hdd_wext.c b/CORE/HDD/src/wlan_hdd_wext.c
index f8a8090..1b3b71f 100644
--- a/CORE/HDD/src/wlan_hdd_wext.c
+++ b/CORE/HDD/src/wlan_hdd_wext.c
@@ -973,7 +973,7 @@
pHddCtx = WLAN_HDD_GET_CTX(pAdapter);
if (!pHddCtx->mgmt_frame_logging)
{
- hddLog(VOS_TRACE_LEVEL_ERROR,"%s: Frame Logging not init!", __func__);
+ hddLog(LOGW, FL("Frame Logging not init!"));
return VOS_STATUS_E_AGAIN;
}
@@ -4186,15 +4186,15 @@
}
else if (strcasecmp(cmd, "scan-active") == 0)
{
- hddLog(VOS_TRACE_LEVEL_ERROR,
- FL("making default scan to active"));
+ hddLog(LOG1,
+ FL("making default scan to active"));
pHddCtx->scan_info.scan_mode = eSIR_ACTIVE_SCAN;
ret = snprintf(cmd, cmd_len, "OK");
}
else if (strcasecmp(cmd, "scan-passive") == 0)
{
- hddLog(VOS_TRACE_LEVEL_ERROR,
- FL("making default scan to passive"));
+ hddLog(LOG1,
+ FL("making default scan to passive"));
pHddCtx->scan_info.scan_mode = eSIR_PASSIVE_SCAN;
ret = snprintf(cmd, cmd_len, "OK");
}
diff --git a/CORE/MAC/src/pe/lim/limProcessAssocRspFrame.c b/CORE/MAC/src/pe/lim/limProcessAssocRspFrame.c
index a3fdc35..fb8d7e4 100644
--- a/CORE/MAC/src/pe/lim/limProcessAssocRspFrame.c
+++ b/CORE/MAC/src/pe/lim/limProcessAssocRspFrame.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2012-2015 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2016 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@@ -504,7 +504,8 @@
}
if(pAssocRsp->ExtCap.present)
{
- limLog(pMac, LOGE, FL("Filling tdls prohibited in session entry"));
+ limLog(pMac, LOG1,
+ FL("Filling tdls prohibited in session entry"));
psessionEntry->tdlsChanSwitProhibited =
pAssocRsp->ExtCap.TDLSChanSwitProhibited ;
}
diff --git a/CORE/MAC/src/pe/lim/limUtils.c b/CORE/MAC/src/pe/lim/limUtils.c
index e27ebea..62905ed 100644
--- a/CORE/MAC/src/pe/lim/limUtils.c
+++ b/CORE/MAC/src/pe/lim/limUtils.c
@@ -5726,9 +5726,12 @@
if((eBA_DISABLE == pSta->tcCfg[tid].fUseBATx) &&
(pBaCandidate->baInfo[tid].fBaEnable))
{
- limLog(pMac, LOGE, FL("BA setup for staId = %d, TID: %d, SSN: %d"),
- pSta->staIndex, tid, pBaCandidate->baInfo[tid].startingSeqNum);
- limPostMlmAddBAReq(pMac, pSta, tid, pBaCandidate->baInfo[tid].startingSeqNum,psessionEntry);
+ limLog(pMac, LOG1,
+ FL("BA setup for staId = %d, TID: %d, SSN: %d"),
+ pSta->staIndex, tid,
+ pBaCandidate->baInfo[tid].startingSeqNum);
+ limPostMlmAddBAReq(pMac, pSta, tid,
+ pBaCandidate->baInfo[tid].startingSeqNum,psessionEntry);
}
}
}
diff --git a/CORE/SME/src/pmc/pmc.c b/CORE/SME/src/pmc/pmc.c
index 6aa3b8b..66474d7 100644
--- a/CORE/SME/src/pmc/pmc.c
+++ b/CORE/SME/src/pmc/pmc.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2012-2014 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2014, 2016 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@@ -663,7 +663,7 @@
{
if (!checkRoutine(pPowerSaveCheckEntry->checkContext))
{
- pmcLog(pMac, LOGE, FL("pmcPowerSaveCheck fail!"));
+ pmcLog(pMac, LOG1, FL("pmcPowerSaveCheck fail!"));
bResult = FALSE;
break;
}
@@ -1037,8 +1037,11 @@
}
else
{
- /*Some module voted against Power Save. So timer should be restarted again to retry BMPS */
- pmcLog(pMac, LOGE, FL("Power Save check failed. Retry BMPS again later"));
+ /*Some module voted against Power Save.
+ * So timer should be restarted again to retry BMPS
+ */
+ pmcLog(pMac, LOGW,
+ FL("Power Save check failed. Retry BMPS again later"));
//Since hTrafficTimer is a vos_timer now, we need to restart the timer here
vosStatus = vos_timer_start(&pMac->pmc.hTrafficTimer, pMac->pmc.bmpsConfig.trafficMeasurePeriod);
if ( !VOS_IS_STATUS_SUCCESS(vosStatus) && (VOS_STATUS_E_ALREADY != vosStatus) )
diff --git a/CORE/VOSS/src/vos_nvitem.c b/CORE/VOSS/src/vos_nvitem.c
index 3037a2f..d472889 100644
--- a/CORE/VOSS/src/vos_nvitem.c
+++ b/CORE/VOSS/src/vos_nvitem.c
@@ -3438,11 +3438,13 @@
if (REGDOMAIN_COUNT == temp_reg_domain) {
- /* the country was not found in the driver database */
- /* so we will return the REGDOMAIN_WORLD to SME/CSR */
+ /* the country was not found in the driver database
+ * so we will return the REGDOMAIN_WORLD to SME/CSR
+ */
- VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- ("Country does not map to any Regulatory domain"));
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_INFO,
+ ("Country %c%c does not map to any Regulatory domain"),
+ country_code[0], country_code[1]);
temp_reg_domain = REGDOMAIN_WORLD;
}
diff --git a/CORE/VOSS/src/vos_sched.c b/CORE/VOSS/src/vos_sched.c
index eb79167..51d7d62 100644
--- a/CORE/VOSS/src/vos_sched.c
+++ b/CORE/VOSS/src/vos_sched.c
@@ -852,6 +852,18 @@
clear_bit(WD_POST_EVENT_MASK, &pWdContext->wdEventFlag);
while(1)
{
+
+ /* Post Msg to detect thread stuck. */
+ if (test_and_clear_bit(WD_WLAN_DETECT_THREAD_STUCK_MASK,
+ &pWdContext->wdEventFlag))
+ {
+ vos_wd_detect_thread_stuck();
+ /*
+ * Process here and return without processing any SSR
+ * related logic.
+ */
+ break;
+ }
/* Check for any Active Entry Points
* If active, delay SSR until no entry point is active or
* delay until count is decremented to ZERO
@@ -943,12 +955,6 @@
pWdContext->resetInProgress = false;
complete(&pHddCtx->ssr_comp_var);
}
- /* Post Msg to detect thread stuck */
- else if(test_and_clear_bit(WD_WLAN_DETECT_THREAD_STUCK_MASK,
- &pWdContext->wdEventFlag))
- {
- vos_wd_detect_thread_stuck();
- }
else
{
//Unnecessary wakeup - Should never happen!!
diff --git a/CORE/WDI/CP/src/wlan_qct_wdi.c b/CORE/WDI/CP/src/wlan_qct_wdi.c
index 5a8779b..a8bdc42 100644
--- a/CORE/WDI/CP/src/wlan_qct_wdi.c
+++ b/CORE/WDI/CP/src/wlan_qct_wdi.c
@@ -16678,7 +16678,7 @@
WDI_ASSERT(0);
}
}
- else
+ else if (WDI_STATUS_SUCCESS != wdiStatus)
{
WPAL_TRACE(eWLAN_MODULE_DAL_CTRL, eWLAN_PAL_TRACE_LEVEL_ERROR,
"Error returned WDI_ProcessInitScanRspi:%d BMPS%d",