qcacld-3.0: Refine iw_get_oem_data_cap()
The current implementaton of iw_get_oem_data_cap() has a few issues:
- It has identifiers with mixed-case and Hungarian notation
- It performs an unnecessary data copy
So refine the function to address these issues.
Change-Id: I3d445ea4024e072d66c3d59e8773d0ad72eb6178
CRs-Fixed: 2413669
diff --git a/core/hdd/src/wlan_hdd_oemdata.c b/core/hdd/src/wlan_hdd_oemdata.c
index 409cb50..1b39e4f 100644
--- a/core/hdd/src/wlan_hdd_oemdata.c
+++ b/core/hdd/src/wlan_hdd_oemdata.c
@@ -146,29 +146,25 @@
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
{
- int status;
- struct oem_data_cap oemDataCap = { {0} };
- struct oem_data_cap *pHddOemDataCap;
- struct hdd_adapter *adapter = (netdev_priv(dev));
- struct hdd_context *pHddContext;
- int ret;
+ struct oem_data_cap *oem_data_cap = (void *)extra;
+ struct hdd_adapter *adapter = netdev_priv(dev);
+ struct hdd_context *hdd_ctx;
+ int errno;
hdd_enter();
- pHddContext = WLAN_HDD_GET_CTX(adapter);
- ret = wlan_hdd_validate_context(pHddContext);
- if (0 != ret)
- return ret;
+ hdd_ctx = WLAN_HDD_GET_CTX(adapter);
+ errno = wlan_hdd_validate_context(hdd_ctx);
+ if (errno)
+ return errno;
- status = populate_oem_data_cap(adapter, &oemDataCap);
- if (0 != status) {
+ qdf_mem_zero(oem_data_cap, sizeof(*oem_data_cap));
+ errno = populate_oem_data_cap(adapter, oem_data_cap);
+ if (errno) {
hdd_err("Failed to populate oem data capabilities");
- return status;
+ return errno;
}
- pHddOemDataCap = (struct oem_data_cap *) (extra);
- *pHddOemDataCap = oemDataCap;
-
hdd_exit();
return 0;
}