Make the Error class constructor protected
This is forcing to use Error::success(), which is in a wide majority
of cases a lot more readable.
Differential Revision: https://reviews.llvm.org/D26481
llvm-svn: 286561
diff --git a/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp b/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
index 82e45a5..7680dfe 100644
--- a/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
@@ -150,7 +150,7 @@
else
m_monitor->Resume(GetID(), m_resume_signo);
- return Error();
+ return Error::success();
}
bool ProcessFreeBSD::UpdateThreadList(ThreadList &old_thread_list,
diff --git a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
index 8494077..7a3696a 100644
--- a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
@@ -1364,13 +1364,13 @@
// If setting the breakpoint fails because next_pc is out of
// the address space, ignore it and let the debugee segfault.
if (error.GetError() == EIO || error.GetError() == EFAULT) {
- return Error();
+ return Error::success();
} else if (error.Fail())
return error;
m_threads_stepping_with_breakpoint.insert({thread.GetID(), next_pc});
- return Error();
+ return Error::success();
}
bool NativeProcessLinux::SupportHardwareSingleStepping() const {
@@ -1453,7 +1453,7 @@
}
}
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::Halt() {
@@ -1553,7 +1553,7 @@
StopRunningThreads(deferred_signal_thread_sp->GetID());
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::Kill() {
@@ -1677,7 +1677,7 @@
if (name)
memory_region_info.SetName(name);
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::GetMemoryRegionInfo(lldb::addr_t load_addr,
@@ -1841,7 +1841,7 @@
if (InferiorCallMmap(this, addr, 0, size, prot,
eMmapFlagsAnon | eMmapFlagsPrivate, -1, 0)) {
m_addr_to_mmap_size[addr] = size;
- return Error();
+ return Error::success();
} else {
addr = LLDB_INVALID_ADDRESS;
return Error("unable to allocate %" PRIu64
@@ -1886,11 +1886,11 @@
case llvm::Triple::x86:
case llvm::Triple::x86_64:
actual_opcode_size = static_cast<uint32_t>(sizeof(g_i386_opcode));
- return Error();
+ return Error::success();
case llvm::Triple::systemz:
actual_opcode_size = static_cast<uint32_t>(sizeof(g_s390x_opcode));
- return Error();
+ return Error::success();
case llvm::Triple::arm:
case llvm::Triple::aarch64:
@@ -1900,7 +1900,7 @@
case llvm::Triple::mipsel:
// On these architectures the PC don't get updated for breakpoint hits
actual_opcode_size = 0;
- return Error();
+ return Error::success();
default:
assert(false && "CPU type not supported!");
@@ -1935,18 +1935,18 @@
case llvm::Triple::aarch64:
trap_opcode_bytes = g_aarch64_opcode;
actual_opcode_size = sizeof(g_aarch64_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::arm:
switch (trap_opcode_size_hint) {
case 2:
trap_opcode_bytes = g_thumb_breakpoint_opcode;
actual_opcode_size = sizeof(g_thumb_breakpoint_opcode);
- return Error();
+ return Error::success();
case 4:
trap_opcode_bytes = g_arm_breakpoint_opcode;
actual_opcode_size = sizeof(g_arm_breakpoint_opcode);
- return Error();
+ return Error::success();
default:
assert(false && "Unrecognised trap opcode size hint!");
return Error("Unrecognised trap opcode size hint!");
@@ -1956,24 +1956,24 @@
case llvm::Triple::x86_64:
trap_opcode_bytes = g_i386_opcode;
actual_opcode_size = sizeof(g_i386_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::mips:
case llvm::Triple::mips64:
trap_opcode_bytes = g_mips64_opcode;
actual_opcode_size = sizeof(g_mips64_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::mipsel:
case llvm::Triple::mips64el:
trap_opcode_bytes = g_mips64el_opcode;
actual_opcode_size = sizeof(g_mips64el_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::systemz:
trap_opcode_bytes = g_s390x_opcode;
actual_opcode_size = sizeof(g_s390x_opcode);
- return Error();
+ return Error::success();
default:
assert(false && "CPU type not supported!");
@@ -2156,7 +2156,7 @@
success ? "Success" : strerror(errno));
if (success)
- return Error();
+ return Error::success();
// else
// the call failed for some reason, let's retry the read using ptrace
// api.
@@ -2207,7 +2207,7 @@
if (log)
ProcessPOSIXLog::DecNestLevel();
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::ReadMemoryWithoutTrap(lldb::addr_t addr, void *buf,
@@ -2303,7 +2303,7 @@
Error NativeProcessLinux::Detach(lldb::tid_t tid) {
if (tid == LLDB_INVALID_THREAD_ID)
- return Error();
+ return Error::success();
return PtraceWrapper(PTRACE_DETACH, tid);
}
@@ -2414,7 +2414,7 @@
"NativeProcessLinux::%s pid %" PRIu64
" no lldb breakpoint found at current pc with adjustment: 0x%" PRIx64,
__FUNCTION__, GetID(), breakpoint_addr);
- return Error();
+ return Error::success();
}
// If the breakpoint is not a software breakpoint, nothing to do.
@@ -2424,7 +2424,7 @@
" breakpoint found at 0x%" PRIx64
", not software, nothing to adjust",
__FUNCTION__, GetID(), breakpoint_addr);
- return Error();
+ return Error::success();
}
//
@@ -2440,7 +2440,7 @@
" breakpoint found at 0x%" PRIx64
", it is software, but the size is zero, nothing to do (unexpected)",
__FUNCTION__, GetID(), breakpoint_addr);
- return Error();
+ return Error::success();
}
// Change the program counter.
@@ -2488,7 +2488,7 @@
return Error("Module file (%s) not found in /proc/%" PRIu64 "/maps file!",
module_file_spec.GetFilename().AsCString(), GetID());
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::GetFileLoadAddress(const llvm::StringRef &file_name,
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
index 9e85713..4566493 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
@@ -263,7 +263,7 @@
if (error.Fail())
return error;
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized to be a GPR or an FPR, "
@@ -679,7 +679,7 @@
}
}
- return Error();
+ return Error::success();
}
uint32_t NativeRegisterContextLinux_arm::GetWatchpointSize(uint32_t wp_index) {
@@ -730,12 +730,12 @@
if (WatchpointIsEnabled(wp_index) && trap_addr >= watch_addr &&
trap_addr < watch_addr + watch_size) {
m_hwp_regs[wp_index].hit_addr = trap_addr;
- return Error();
+ return Error::success();
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
lldb::addr_t
@@ -774,7 +774,7 @@
Error error;
if (!m_refresh_hwdebug_info) {
- return Error();
+ return Error::success();
}
unsigned int cap_val;
@@ -862,7 +862,7 @@
return error;
value.SetUInt32(m_gpr_arm[offset / sizeof(uint32_t)]);
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_arm::DoWriteRegisterValue(
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
index cb0700d..c0fdb74 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
@@ -276,7 +276,7 @@
if (error.Fail())
return error;
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized to be a GPR or an FPR, "
@@ -671,7 +671,7 @@
}
}
- return Error();
+ return Error::success();
}
uint32_t
@@ -722,12 +722,12 @@
if (WatchpointIsEnabled(wp_index) && trap_addr >= watch_addr &&
trap_addr < watch_addr + watch_size) {
m_hwp_regs[wp_index].hit_addr = trap_addr;
- return Error();
+ return Error::success();
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
lldb::addr_t
@@ -764,7 +764,7 @@
Error NativeRegisterContextLinux_arm64::ReadHardwareDebugInfo() {
if (!m_refresh_hwdebug_info) {
- return Error();
+ return Error::success();
}
::pid_t tid = m_thread.GetID();
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
index c050a2e..bbd4578 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
@@ -932,7 +932,7 @@
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_mips64::IsWatchpointVacant(uint32_t wp_index,
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp
index 7ec4dc5..105fa9b 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp
@@ -222,7 +222,7 @@
assert(false && "Unhandled data size.");
return Error("unhandled byte size: %" PRIu32, reg_info->byte_size);
}
- return Error();
+ return Error::success();
}
if (IsFPR(reg)) {
@@ -245,7 +245,7 @@
assert(false && "Unhandled data size.");
return Error("unhandled byte size: %" PRIu32, reg_info->byte_size);
}
- return Error();
+ return Error::success();
}
if (reg == lldb_last_break_s390x) {
@@ -255,7 +255,7 @@
return error;
reg_value.SetUInt64(last_break);
- return Error();
+ return Error::success();
}
if (reg == lldb_system_call_s390x) {
@@ -265,7 +265,7 @@
return error;
reg_value.SetUInt32(system_call);
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized");
@@ -511,7 +511,7 @@
if (m_watchpoint_addr == LLDB_INVALID_ADDRESS) {
is_hit = false;
- return Error();
+ return Error::success();
}
Error error = PeekUserArea(offsetof(user_regs_struct, per_info.lowcore),
@@ -531,7 +531,7 @@
sizeof(per_lowcore));
}
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_s390x::GetWatchpointHitIndex(
@@ -548,7 +548,7 @@
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_s390x::IsWatchpointVacant(uint32_t wp_index,
@@ -558,7 +558,7 @@
is_vacant = m_watchpoint_addr == LLDB_INVALID_ADDRESS;
- return Error();
+ return Error::success();
}
bool NativeRegisterContextLinux_s390x::ClearHardwareWatchpoint(
@@ -589,7 +589,7 @@
Error NativeRegisterContextLinux_s390x::ClearAllHardwareWatchpoints() {
if (ClearHardwareWatchpoint(0))
- return Error();
+ return Error::success();
return Error("Clearing all hardware watchpoints failed.");
}
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
index 37e748d..e9bc296 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
@@ -626,7 +626,7 @@
if (!CopyMPXtoXSTATE(reg_index))
return Error("CopyMPXtoXSTATE() failed");
}
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized to be a GPR or an FPR, "
"write strategy unknown");
@@ -1035,7 +1035,7 @@
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_x86_64::IsWatchpointVacant(uint32_t wp_index,
diff --git a/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp b/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
index d18d3c1..6b4426b 100644
--- a/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
@@ -167,7 +167,7 @@
if (!hardware)
return Error("not implemented");
if (m_state == eStateLaunching)
- return Error();
+ return Error::success();
Error error = RemoveWatchpoint(addr);
if (error.Fail())
return error;
@@ -176,17 +176,17 @@
if (wp_index == LLDB_INVALID_INDEX32)
return Error("Setting hardware watchpoint failed.");
m_watchpoint_index_map.insert({addr, wp_index});
- return Error();
+ return Error::success();
}
Error NativeThreadLinux::RemoveWatchpoint(lldb::addr_t addr) {
auto wp = m_watchpoint_index_map.find(addr);
if (wp == m_watchpoint_index_map.end())
- return Error();
+ return Error::success();
uint32_t wp_index = wp->second;
m_watchpoint_index_map.erase(wp);
if (GetRegisterContext()->ClearHardwareWatchpoint(wp_index))
- return Error();
+ return Error::success();
return Error("Clearing hardware watchpoint failed.");
}
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
index 77b9fc8..2decd29 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
@@ -414,7 +414,7 @@
return m_dyld_ap.get();
}
-Error ProcessKDP::WillResume() { return Error(); }
+Error ProcessKDP::WillResume() { return Error::success(); }
Error ProcessKDP::DoResume() {
Error error;
diff --git a/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp b/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
index 7ddc586..8fe93fa 100644
--- a/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
+++ b/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
@@ -427,7 +427,7 @@
WINDOWS_LOG_PROCESS,
"DoDetach called while state = %u, but there is no active session.",
private_state);
- return Error();
+ return Error::success();
}
debugger_thread = m_session_data->m_debugger;
@@ -477,7 +477,7 @@
WINDOWS_LOG_PROCESS,
"DoDestroy called while state = %u, but there is no active session.",
private_state);
- return Error();
+ return Error::success();
}
debugger_thread = m_session_data->m_debugger;
diff --git a/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp b/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
index 128c4c1..5aaeb98 100644
--- a/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
+++ b/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
@@ -587,7 +587,7 @@
return m_impl_up->RefreshStateAfterStop();
}
-Error ProcessWinMiniDump::DoDestroy() { return Error(); }
+Error ProcessWinMiniDump::DoDestroy() { return Error::success(); }
bool ProcessWinMiniDump::IsAlive() { return true; }
diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
index 840a792..d9fa3f8 100644
--- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
+++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -258,7 +258,7 @@
void ProcessElfCore::RefreshStateAfterStop() {}
-Error ProcessElfCore::DoDestroy() { return Error(); }
+Error ProcessElfCore::DoDestroy() { return Error::success(); }
//------------------------------------------------------------------
// Process Queries
@@ -304,7 +304,7 @@
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
}
- return Error();
+ return Error::success();
}
region_info.GetRange().SetRangeBase(load_addr);
@@ -313,7 +313,7 @@
region_info.SetWritable(MemoryRegionInfo::eNo);
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
- return Error();
+ return Error::success();
}
size_t ProcessElfCore::DoReadMemory(lldb::addr_t addr, void *buf, size_t size,
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
index 49733a5..f0494a8 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -2672,7 +2672,7 @@
response.GetEscapedBinaryData(output);
if (command_output)
command_output->assign(output);
- return Error();
+ return Error::success();
}
return Error("unable to send packet");
}
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
index 0897611..440651f 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
@@ -197,13 +197,13 @@
__FUNCTION__);
m_process_launch_info.SetArguments(const_cast<const char **>(args), true);
- return Error();
+ return Error::success();
}
Error GDBRemoteCommunicationServerLLGS::SetLaunchFlags(
unsigned int launch_flags) {
m_process_launch_info.GetFlags().Set(launch_flags);
- return Error();
+ return Error::success();
}
Error GDBRemoteCommunicationServerLLGS::LaunchProcess() {
@@ -988,7 +988,7 @@
return error;
}
- return Error();
+ return Error::success();
}
void GDBRemoteCommunicationServerLLGS::StartSTDIOForwarding() {
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index c0fbccb..07d3080 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -1252,7 +1252,7 @@
m_continue_S_tids.clear();
m_jstopinfo_sp.reset();
m_jthreadsinfo_sp.reset();
- return Error();
+ return Error::success();
}
Error ProcessGDBRemote::DoResume() {
@@ -3246,7 +3246,7 @@
const ProcessInfo &process_info) {
// Make sure we aren't already connected?
if (m_gdb_comm.IsConnected())
- return Error();
+ return Error::success();
PlatformSP platform_sp(GetTarget().GetPlatform());
if (platform_sp && !platform_sp->IsHost())
@@ -4408,7 +4408,7 @@
XMLNode root_element = doc.GetRootElement("library-list-svr4");
if (!root_element)
- return Error();
+ return Error::success();
// main link map structure
llvm::StringRef main_lm = root_element.GetAttributeValue("main-lm");
@@ -4494,7 +4494,7 @@
XMLNode root_element = doc.GetRootElement("library-list");
if (!root_element)
- return Error();
+ return Error::success();
root_element.ForEachChildElementWithName(
"library", [log, &list](const XMLNode &library) -> bool {
@@ -4538,7 +4538,7 @@
return Error(0, ErrorType::eErrorTypeGeneric);
}
- return Error();
+ return Error::success();
}
lldb::ModuleSP ProcessGDBRemote::LoadModuleAtAddress(const FileSpec &file,
@@ -4662,7 +4662,7 @@
// The file is not loaded into the inferior
is_loaded = false;
load_addr = LLDB_INVALID_ADDRESS;
- return Error();
+ return Error::success();
}
return Error(
@@ -4672,7 +4672,7 @@
if (response.IsNormalResponse()) {
is_loaded = true;
load_addr = response.GetHexMaxU64(false, LLDB_INVALID_ADDRESS);
- return Error();
+ return Error::success();
}
return Error("Unknown error happened during sending the load address packet");
diff --git a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
index f83499c..1b32117 100644
--- a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
+++ b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
@@ -461,7 +461,7 @@
// SetThreadStopInfo (m_last_stop_packet);
}
-Error ProcessMachCore::DoDestroy() { return Error(); }
+Error ProcessMachCore::DoDestroy() { return Error::success(); }
//------------------------------------------------------------------
// Process Queries
@@ -564,7 +564,7 @@
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
}
- return Error();
+ return Error::success();
}
region_info.GetRange().SetRangeBase(load_addr);
@@ -573,7 +573,7 @@
region_info.SetWritable(MemoryRegionInfo::eNo);
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
- return Error();
+ return Error::success();
}
void ProcessMachCore::Clear() { m_thread_list.Clear(); }
diff --git a/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp b/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
index 46d8df8..5b390d8 100644
--- a/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
+++ b/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
@@ -133,7 +133,7 @@
uint32_t ProcessMinidump::GetPluginVersion() { return 1; }
-Error ProcessMinidump::DoDestroy() { return Error(); }
+Error ProcessMinidump::DoDestroy() { return Error::success(); }
void ProcessMinidump::RefreshStateAfterStop() {
if (!m_active_exception)