| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 1 | // RUN: %clang_cc1 -std=c++11 -triple=x86_64-pc-linux-gnu -fsyntax-only \ |
| 2 | // RUN: -verify=unsigned,unsigned-signed %s |
| 3 | // RUN: %clang_cc1 -std=c++11 -triple=x86_64-pc-win32 -fsyntax-only \ |
| 4 | // RUN: -verify=unsigned-signed %s |
| 5 | // RUN: %clang_cc1 -std=c++11 -triple=x86_64-pc-win32 -fsyntax-only \ |
| 6 | // RUN: -Wno-tautological-unsigned-enum-zero-compare \ |
| 7 | // RUN: -verify=silence %s |
| 8 | |
| 9 | // silence-no-diagnostics |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 10 | |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 11 | int main() { |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 12 | // On Windows, all enumerations have a fixed underlying type, which is 'int' |
| 13 | // if not otherwise specified, so A is identical to C on Windows. Otherwise, |
| 14 | // we follow the C++ rules, which say that the only valid values of A are 0 |
| 15 | // and 1. |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 16 | enum A { A_foo = 0, A_bar, }; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 17 | enum A a; |
| 18 | |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 19 | enum B : unsigned { B_foo = 0, B_bar, }; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 20 | enum B b; |
| 21 | |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 22 | enum C : signed { C_foo = 0, C_bar, }; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 23 | enum C c; |
| 24 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 25 | if (a < 0) // unsigned-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 26 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 27 | if (0 >= a) |
| 28 | return 0; |
| 29 | if (a > 0) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 30 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 31 | if (0 <= a) // unsigned-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 32 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 33 | if (a <= 0) |
| 34 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 35 | if (0 > a) // unsigned-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 36 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 37 | if (a >= 0) // unsigned-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 38 | return 0; |
| 39 | if (0 < a) |
| 40 | return 0; |
| 41 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 42 | // FIXME: As below, the issue here is that the enumeration is promoted to |
| 43 | // unsigned. |
| 44 | if (a < 0U) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 45 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 46 | if (0U >= a) |
| 47 | return 0; |
| 48 | if (a > 0U) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 49 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 50 | if (0U <= a) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 51 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 52 | if (a <= 0U) |
| 53 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 54 | if (0U > a) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 55 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 56 | if (a >= 0U) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 57 | return 0; |
| 58 | if (0U < a) |
| 59 | return 0; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 60 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 61 | if (b < 0) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 62 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 63 | if (0 >= b) |
| 64 | return 0; |
| 65 | if (b > 0) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 66 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 67 | if (0 <= b) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 68 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 69 | if (b <= 0) |
| 70 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 71 | if (0 > b) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 72 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 73 | if (b >= 0) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 74 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 75 | if (0 < b) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 76 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 77 | |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 78 | if (b < 0U) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 79 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 80 | if (0U >= b) |
| 81 | return 0; |
| 82 | if (b > 0U) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 83 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 84 | if (0U <= b) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 85 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 86 | if (b <= 0U) |
| 87 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 88 | if (0U > b) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 89 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 90 | if (b >= 0U) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 91 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 92 | if (0U < b) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 93 | return 0; |
| 94 | |
| 95 | if (c < 0) |
| 96 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 97 | if (0 >= c) |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 98 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 99 | if (c > 0) |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 100 | return 0; |
| 101 | if (0 <= c) |
| 102 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 103 | if (c <= 0) |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 104 | return 0; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 105 | if (0 > c) |
| 106 | return 0; |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 107 | if (c >= 0) |
| 108 | return 0; |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 109 | if (0 < c) |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 110 | return 0; |
| 111 | |
| Richard Smith | 371e9e8a | 2017-12-06 03:00:51 +0000 | [diff] [blame] | 112 | // FIXME: These diagnostics are terrible. The issue here is that the signed |
| 113 | // enumeration value was promoted to an unsigned type. |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 114 | if (c < 0U) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 115 | return 0; |
| 116 | if (0U >= c) |
| 117 | return 0; |
| 118 | if (c > 0U) |
| 119 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 120 | if (0U <= c) // unsigned-signed-warning {{comparison of 0 <= unsigned enum expression is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 121 | return 0; |
| 122 | if (c <= 0U) |
| 123 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 124 | if (0U > c) // unsigned-signed-warning {{comparison of 0 > unsigned enum expression is always false}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 125 | return 0; |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 126 | if (c >= 0U) // unsigned-signed-warning {{comparison of unsigned enum expression >= 0 is always true}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 127 | return 0; |
| 128 | if (0U < c) |
| 129 | return 0; |
| Roman Lebedev | 30d2608 | 2017-09-20 13:50:01 +0000 | [diff] [blame] | 130 | |
| 131 | return 1; |
| 132 | } |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 133 | |
| 134 | namespace crash_enum_zero_width { |
| 135 | int test() { |
| 136 | enum A : unsigned { |
| 137 | A_foo = 0 |
| 138 | }; |
| 139 | enum A a; |
| 140 | |
| 141 | // used to crash in llvm::APSInt::getMaxValue() |
| Hal Finkel | 05e4648 | 2017-12-16 02:23:22 +0000 | [diff] [blame^] | 142 | if (a < 0) // unsigned-signed-warning {{comparison of unsigned enum expression < 0 is always false}} |
| Roman Lebedev | ca1aaac | 2017-10-21 16:44:03 +0000 | [diff] [blame] | 143 | return 0; |
| 144 | |
| 145 | return 1; |
| 146 | } |
| 147 | } // namespace crash_enum_zero_width |