blob: bb451cc8af45aa7972b2ec921b0bbfd84f0651ca [file] [log] [blame]
George Karpenkov70c2ee32018-08-17 21:41:07 +00001//==-- RetainCountChecker.cpp - Checks for leaks and other issues -*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines the methods for RetainCountChecker, which implements
11// a reference count checker for Core Foundation and Cocoa on (Mac OS X).
12//
13//===----------------------------------------------------------------------===//
14
15#include "RetainCountChecker.h"
16
17using namespace clang;
18using namespace ento;
George Karpenkov70c2ee32018-08-17 21:41:07 +000019using namespace retaincountchecker;
20using llvm::StrInStrNoCase;
21
22REGISTER_MAP_WITH_PROGRAMSTATE(RefBindings, SymbolRef, RefVal)
23
24namespace clang {
25namespace ento {
26namespace retaincountchecker {
27
28const RefVal *getRefBinding(ProgramStateRef State, SymbolRef Sym) {
29 return State->get<RefBindings>(Sym);
30}
31
32ProgramStateRef setRefBinding(ProgramStateRef State, SymbolRef Sym,
33 RefVal Val) {
George Karpenkovd5ef0d22018-08-29 20:28:33 +000034 assert(Sym != nullptr);
George Karpenkov70c2ee32018-08-17 21:41:07 +000035 return State->set<RefBindings>(Sym, Val);
36}
37
38ProgramStateRef removeRefBinding(ProgramStateRef State, SymbolRef Sym) {
39 return State->remove<RefBindings>(Sym);
40}
41
42} // end namespace retaincountchecker
43} // end namespace ento
44} // end namespace clang
45
46void RefVal::print(raw_ostream &Out) const {
47 if (!T.isNull())
George Karpenkov081c4772018-10-23 23:11:50 +000048 Out << "Tracked " << T.getAsString() << " | ";
George Karpenkov70c2ee32018-08-17 21:41:07 +000049
50 switch (getKind()) {
51 default: llvm_unreachable("Invalid RefVal kind");
52 case Owned: {
53 Out << "Owned";
54 unsigned cnt = getCount();
55 if (cnt) Out << " (+ " << cnt << ")";
56 break;
57 }
58
59 case NotOwned: {
60 Out << "NotOwned";
61 unsigned cnt = getCount();
62 if (cnt) Out << " (+ " << cnt << ")";
63 break;
64 }
65
66 case ReturnedOwned: {
67 Out << "ReturnedOwned";
68 unsigned cnt = getCount();
69 if (cnt) Out << " (+ " << cnt << ")";
70 break;
71 }
72
73 case ReturnedNotOwned: {
74 Out << "ReturnedNotOwned";
75 unsigned cnt = getCount();
76 if (cnt) Out << " (+ " << cnt << ")";
77 break;
78 }
79
80 case Released:
81 Out << "Released";
82 break;
83
84 case ErrorDeallocNotOwned:
85 Out << "-dealloc (not-owned)";
86 break;
87
88 case ErrorLeak:
89 Out << "Leaked";
90 break;
91
92 case ErrorLeakReturned:
93 Out << "Leaked (Bad naming)";
94 break;
95
96 case ErrorUseAfterRelease:
97 Out << "Use-After-Release [ERROR]";
98 break;
99
100 case ErrorReleaseNotOwned:
101 Out << "Release of Not-Owned [ERROR]";
102 break;
103
104 case RefVal::ErrorOverAutorelease:
105 Out << "Over-autoreleased";
106 break;
107
108 case RefVal::ErrorReturnedNotOwned:
109 Out << "Non-owned object returned instead of owned";
110 break;
111 }
112
113 switch (getIvarAccessHistory()) {
114 case IvarAccessHistory::None:
115 break;
116 case IvarAccessHistory::AccessedDirectly:
117 Out << " [direct ivar access]";
118 break;
119 case IvarAccessHistory::ReleasedAfterDirectAccess:
120 Out << " [released after direct ivar access]";
121 }
122
123 if (ACnt) {
124 Out << " [autorelease -" << ACnt << ']';
125 }
126}
127
128namespace {
129class StopTrackingCallback final : public SymbolVisitor {
130 ProgramStateRef state;
131public:
132 StopTrackingCallback(ProgramStateRef st) : state(std::move(st)) {}
133 ProgramStateRef getState() const { return state; }
134
135 bool VisitSymbol(SymbolRef sym) override {
136 state = state->remove<RefBindings>(sym);
137 return true;
138 }
139};
140} // end anonymous namespace
141
142//===----------------------------------------------------------------------===//
143// Handle statements that may have an effect on refcounts.
144//===----------------------------------------------------------------------===//
145
146void RetainCountChecker::checkPostStmt(const BlockExpr *BE,
147 CheckerContext &C) const {
148
149 // Scan the BlockDecRefExprs for any object the retain count checker
150 // may be tracking.
151 if (!BE->getBlockDecl()->hasCaptures())
152 return;
153
154 ProgramStateRef state = C.getState();
155 auto *R = cast<BlockDataRegion>(C.getSVal(BE).getAsRegion());
156
157 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
158 E = R->referenced_vars_end();
159
160 if (I == E)
161 return;
162
163 // FIXME: For now we invalidate the tracking of all symbols passed to blocks
164 // via captured variables, even though captured variables result in a copy
165 // and in implicit increment/decrement of a retain count.
166 SmallVector<const MemRegion*, 10> Regions;
167 const LocationContext *LC = C.getLocationContext();
168 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
169
170 for ( ; I != E; ++I) {
171 const VarRegion *VR = I.getCapturedRegion();
172 if (VR->getSuperRegion() == R) {
173 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
174 }
175 Regions.push_back(VR);
176 }
177
178 state =
179 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
180 Regions.data() + Regions.size()).getState();
181 C.addTransition(state);
182}
183
184void RetainCountChecker::checkPostStmt(const CastExpr *CE,
185 CheckerContext &C) const {
186 const ObjCBridgedCastExpr *BE = dyn_cast<ObjCBridgedCastExpr>(CE);
187 if (!BE)
188 return;
189
190 ArgEffect AE = IncRef;
191
192 switch (BE->getBridgeKind()) {
193 case OBC_Bridge:
194 // Do nothing.
195 return;
196 case OBC_BridgeRetained:
197 AE = IncRef;
198 break;
199 case OBC_BridgeTransfer:
200 AE = DecRefBridgedTransferred;
201 break;
202 }
203
204 ProgramStateRef state = C.getState();
205 SymbolRef Sym = C.getSVal(CE).getAsLocSymbol();
206 if (!Sym)
207 return;
208 const RefVal* T = getRefBinding(state, Sym);
209 if (!T)
210 return;
211
212 RefVal::Kind hasErr = (RefVal::Kind) 0;
213 state = updateSymbol(state, Sym, *T, AE, hasErr, C);
214
215 if (hasErr) {
216 // FIXME: If we get an error during a bridge cast, should we report it?
217 return;
218 }
219
220 C.addTransition(state);
221}
222
223void RetainCountChecker::processObjCLiterals(CheckerContext &C,
224 const Expr *Ex) const {
225 ProgramStateRef state = C.getState();
226 const ExplodedNode *pred = C.getPredecessor();
227 for (const Stmt *Child : Ex->children()) {
228 SVal V = pred->getSVal(Child);
229 if (SymbolRef sym = V.getAsSymbol())
230 if (const RefVal* T = getRefBinding(state, sym)) {
231 RefVal::Kind hasErr = (RefVal::Kind) 0;
232 state = updateSymbol(state, sym, *T, MayEscape, hasErr, C);
233 if (hasErr) {
234 processNonLeakError(state, Child->getSourceRange(), hasErr, sym, C);
235 return;
236 }
237 }
238 }
239
240 // Return the object as autoreleased.
241 // RetEffect RE = RetEffect::MakeNotOwned(RetEffect::ObjC);
242 if (SymbolRef sym =
243 state->getSVal(Ex, pred->getLocationContext()).getAsSymbol()) {
244 QualType ResultTy = Ex->getType();
245 state = setRefBinding(state, sym,
246 RefVal::makeNotOwned(RetEffect::ObjC, ResultTy));
247 }
248
249 C.addTransition(state);
250}
251
252void RetainCountChecker::checkPostStmt(const ObjCArrayLiteral *AL,
253 CheckerContext &C) const {
254 // Apply the 'MayEscape' to all values.
255 processObjCLiterals(C, AL);
256}
257
258void RetainCountChecker::checkPostStmt(const ObjCDictionaryLiteral *DL,
259 CheckerContext &C) const {
260 // Apply the 'MayEscape' to all keys and values.
261 processObjCLiterals(C, DL);
262}
263
264void RetainCountChecker::checkPostStmt(const ObjCBoxedExpr *Ex,
265 CheckerContext &C) const {
266 const ExplodedNode *Pred = C.getPredecessor();
267 ProgramStateRef State = Pred->getState();
268
269 if (SymbolRef Sym = Pred->getSVal(Ex).getAsSymbol()) {
270 QualType ResultTy = Ex->getType();
271 State = setRefBinding(State, Sym,
272 RefVal::makeNotOwned(RetEffect::ObjC, ResultTy));
273 }
274
275 C.addTransition(State);
276}
277
278void RetainCountChecker::checkPostStmt(const ObjCIvarRefExpr *IRE,
279 CheckerContext &C) const {
280 Optional<Loc> IVarLoc = C.getSVal(IRE).getAs<Loc>();
281 if (!IVarLoc)
282 return;
283
284 ProgramStateRef State = C.getState();
285 SymbolRef Sym = State->getSVal(*IVarLoc).getAsSymbol();
286 if (!Sym || !dyn_cast_or_null<ObjCIvarRegion>(Sym->getOriginRegion()))
287 return;
288
289 // Accessing an ivar directly is unusual. If we've done that, be more
290 // forgiving about what the surrounding code is allowed to do.
291
292 QualType Ty = Sym->getType();
293 RetEffect::ObjKind Kind;
294 if (Ty->isObjCRetainableType())
295 Kind = RetEffect::ObjC;
296 else if (coreFoundation::isCFObjectRef(Ty))
297 Kind = RetEffect::CF;
298 else
299 return;
300
301 // If the value is already known to be nil, don't bother tracking it.
302 ConstraintManager &CMgr = State->getConstraintManager();
303 if (CMgr.isNull(State, Sym).isConstrainedTrue())
304 return;
305
306 if (const RefVal *RV = getRefBinding(State, Sym)) {
307 // If we've seen this symbol before, or we're only seeing it now because
308 // of something the analyzer has synthesized, don't do anything.
309 if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None ||
310 isSynthesizedAccessor(C.getStackFrame())) {
311 return;
312 }
313
314 // Note that this value has been loaded from an ivar.
315 C.addTransition(setRefBinding(State, Sym, RV->withIvarAccess()));
316 return;
317 }
318
319 RefVal PlusZero = RefVal::makeNotOwned(Kind, Ty);
320
321 // In a synthesized accessor, the effective retain count is +0.
322 if (isSynthesizedAccessor(C.getStackFrame())) {
323 C.addTransition(setRefBinding(State, Sym, PlusZero));
324 return;
325 }
326
327 State = setRefBinding(State, Sym, PlusZero.withIvarAccess());
328 C.addTransition(State);
329}
330
331void RetainCountChecker::checkPostCall(const CallEvent &Call,
332 CheckerContext &C) const {
333 RetainSummaryManager &Summaries = getSummaryManager(C);
George Karpenkovefef49c2018-08-21 03:09:02 +0000334
335 // Leave null if no receiver.
336 QualType ReceiverType;
337 if (const auto *MC = dyn_cast<ObjCMethodCall>(&Call)) {
338 if (MC->isInstanceMessage()) {
339 SVal ReceiverV = MC->getReceiverSVal();
340 if (SymbolRef Sym = ReceiverV.getAsLocSymbol())
341 if (const RefVal *T = getRefBinding(C.getState(), Sym))
342 ReceiverType = T->getType();
343 }
344 }
345
346 const RetainSummary *Summ = Summaries.getSummary(Call, ReceiverType);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000347
348 if (C.wasInlined) {
349 processSummaryOfInlined(*Summ, Call, C);
350 return;
351 }
352 checkSummary(*Summ, Call, C);
353}
354
355/// GetReturnType - Used to get the return type of a message expression or
356/// function call with the intention of affixing that type to a tracked symbol.
357/// While the return type can be queried directly from RetEx, when
358/// invoking class methods we augment to the return type to be that of
359/// a pointer to the class (as opposed it just being id).
360// FIXME: We may be able to do this with related result types instead.
361// This function is probably overestimating.
362static QualType GetReturnType(const Expr *RetE, ASTContext &Ctx) {
363 QualType RetTy = RetE->getType();
364 // If RetE is not a message expression just return its type.
365 // If RetE is a message expression, return its types if it is something
366 /// more specific than id.
367 if (const ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(RetE))
368 if (const ObjCObjectPointerType *PT = RetTy->getAs<ObjCObjectPointerType>())
369 if (PT->isObjCQualifiedIdType() || PT->isObjCIdType() ||
370 PT->isObjCClassType()) {
371 // At this point we know the return type of the message expression is
372 // id, id<...>, or Class. If we have an ObjCInterfaceDecl, we know this
373 // is a call to a class method whose type we can resolve. In such
374 // cases, promote the return type to XXX* (where XXX is the class).
375 const ObjCInterfaceDecl *D = ME->getReceiverInterface();
376 return !D ? RetTy :
377 Ctx.getObjCObjectPointerType(Ctx.getObjCInterfaceType(D));
378 }
379
380 return RetTy;
381}
382
George Karpenkov80c9e782018-08-22 01:16:49 +0000383static Optional<RefVal> refValFromRetEffect(RetEffect RE,
384 QualType ResultTy) {
385 if (RE.isOwned()) {
386 return RefVal::makeOwned(RE.getObjKind(), ResultTy);
387 } else if (RE.notOwned()) {
388 return RefVal::makeNotOwned(RE.getObjKind(), ResultTy);
389 }
390
391 return None;
392}
393
George Karpenkov70c2ee32018-08-17 21:41:07 +0000394// We don't always get the exact modeling of the function with regards to the
395// retain count checker even when the function is inlined. For example, we need
396// to stop tracking the symbols which were marked with StopTrackingHard.
397void RetainCountChecker::processSummaryOfInlined(const RetainSummary &Summ,
398 const CallEvent &CallOrMsg,
399 CheckerContext &C) const {
400 ProgramStateRef state = C.getState();
401
402 // Evaluate the effect of the arguments.
403 for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
404 if (Summ.getArg(idx) == StopTrackingHard) {
405 SVal V = CallOrMsg.getArgSVal(idx);
406 if (SymbolRef Sym = V.getAsLocSymbol()) {
407 state = removeRefBinding(state, Sym);
408 }
409 }
410 }
411
412 // Evaluate the effect on the message receiver.
George Karpenkov6e9fd132018-08-22 01:17:09 +0000413 if (const auto *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg)) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000414 if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
415 if (Summ.getReceiverEffect() == StopTrackingHard) {
416 state = removeRefBinding(state, Sym);
417 }
418 }
419 }
420
421 // Consult the summary for the return value.
422 RetEffect RE = Summ.getRetEffect();
George Karpenkov70c2ee32018-08-17 21:41:07 +0000423
George Karpenkovd5ef0d22018-08-29 20:28:33 +0000424 if (SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol()) {
425 if (const auto *MCall = dyn_cast<CXXMemberCall>(&CallOrMsg)) {
426 if (Optional<RefVal> updatedRefVal =
427 refValFromRetEffect(RE, MCall->getResultType())) {
428 state = setRefBinding(state, Sym, *updatedRefVal);
429 }
430 }
431
432 if (RE.getKind() == RetEffect::NoRetHard)
433 state = removeRefBinding(state, Sym);
434 }
George Karpenkovab0011e2018-08-23 00:26:59 +0000435
George Karpenkov70c2ee32018-08-17 21:41:07 +0000436 C.addTransition(state);
437}
438
439static ProgramStateRef updateOutParameter(ProgramStateRef State,
440 SVal ArgVal,
441 ArgEffect Effect) {
442 auto *ArgRegion = dyn_cast_or_null<TypedValueRegion>(ArgVal.getAsRegion());
443 if (!ArgRegion)
444 return State;
445
446 QualType PointeeTy = ArgRegion->getValueType();
447 if (!coreFoundation::isCFObjectRef(PointeeTy))
448 return State;
449
450 SVal PointeeVal = State->getSVal(ArgRegion);
451 SymbolRef Pointee = PointeeVal.getAsLocSymbol();
452 if (!Pointee)
453 return State;
454
455 switch (Effect) {
456 case UnretainedOutParameter:
457 State = setRefBinding(State, Pointee,
458 RefVal::makeNotOwned(RetEffect::CF, PointeeTy));
459 break;
460 case RetainedOutParameter:
461 // Do nothing. Retained out parameters will either point to a +1 reference
462 // or NULL, but the way you check for failure differs depending on the API.
463 // Consequently, we don't have a good way to track them yet.
464 break;
465
466 default:
467 llvm_unreachable("only for out parameters");
468 }
469
470 return State;
471}
472
473void RetainCountChecker::checkSummary(const RetainSummary &Summ,
474 const CallEvent &CallOrMsg,
475 CheckerContext &C) const {
476 ProgramStateRef state = C.getState();
477
478 // Evaluate the effect of the arguments.
479 RefVal::Kind hasErr = (RefVal::Kind) 0;
480 SourceRange ErrorRange;
481 SymbolRef ErrorSym = nullptr;
482
483 for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
484 SVal V = CallOrMsg.getArgSVal(idx);
485
486 ArgEffect Effect = Summ.getArg(idx);
487 if (Effect == RetainedOutParameter || Effect == UnretainedOutParameter) {
488 state = updateOutParameter(state, V, Effect);
489 } else if (SymbolRef Sym = V.getAsLocSymbol()) {
490 if (const RefVal *T = getRefBinding(state, Sym)) {
491 state = updateSymbol(state, Sym, *T, Effect, hasErr, C);
492 if (hasErr) {
493 ErrorRange = CallOrMsg.getArgSourceRange(idx);
494 ErrorSym = Sym;
495 break;
496 }
497 }
498 }
499 }
500
George Karpenkovab0011e2018-08-23 00:26:59 +0000501 // Evaluate the effect on the message receiver / `this` argument.
George Karpenkov70c2ee32018-08-17 21:41:07 +0000502 bool ReceiverIsTracked = false;
503 if (!hasErr) {
George Karpenkovab0011e2018-08-23 00:26:59 +0000504 if (const auto *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg)) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000505 if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
506 if (const RefVal *T = getRefBinding(state, Sym)) {
507 ReceiverIsTracked = true;
508 state = updateSymbol(state, Sym, *T, Summ.getReceiverEffect(),
509 hasErr, C);
510 if (hasErr) {
511 ErrorRange = MsgInvocation->getOriginExpr()->getReceiverRange();
512 ErrorSym = Sym;
513 }
514 }
515 }
George Karpenkovab0011e2018-08-23 00:26:59 +0000516 } else if (const auto *MCall = dyn_cast<CXXMemberCall>(&CallOrMsg)) {
517 if (SymbolRef Sym = MCall->getCXXThisVal().getAsLocSymbol()) {
518 if (const RefVal *T = getRefBinding(state, Sym)) {
519 state = updateSymbol(state, Sym, *T, Summ.getThisEffect(),
520 hasErr, C);
521 if (hasErr) {
522 ErrorRange = MCall->getOriginExpr()->getSourceRange();
523 ErrorSym = Sym;
524 }
525 }
526 }
George Karpenkov70c2ee32018-08-17 21:41:07 +0000527 }
528 }
529
530 // Process any errors.
531 if (hasErr) {
532 processNonLeakError(state, ErrorRange, hasErr, ErrorSym, C);
533 return;
534 }
535
536 // Consult the summary for the return value.
537 RetEffect RE = Summ.getRetEffect();
538
539 if (RE.getKind() == RetEffect::OwnedWhenTrackedReceiver) {
540 if (ReceiverIsTracked)
541 RE = getSummaryManager(C).getObjAllocRetEffect();
542 else
543 RE = RetEffect::MakeNoRet();
544 }
545
George Karpenkov80c9e782018-08-22 01:16:49 +0000546 if (SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol()) {
547 QualType ResultTy = CallOrMsg.getResultType();
548 if (RE.notOwned()) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000549 const Expr *Ex = CallOrMsg.getOriginExpr();
George Karpenkov70c2ee32018-08-17 21:41:07 +0000550 assert(Ex);
George Karpenkov80c9e782018-08-22 01:16:49 +0000551 ResultTy = GetReturnType(Ex, C.getASTContext());
George Karpenkov70c2ee32018-08-17 21:41:07 +0000552 }
George Karpenkov80c9e782018-08-22 01:16:49 +0000553 if (Optional<RefVal> updatedRefVal = refValFromRetEffect(RE, ResultTy))
554 state = setRefBinding(state, Sym, *updatedRefVal);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000555 }
556
557 // This check is actually necessary; otherwise the statement builder thinks
558 // we've hit a previously-found path.
559 // Normally addTransition takes care of this, but we want the node pointer.
560 ExplodedNode *NewNode;
561 if (state == C.getState()) {
562 NewNode = C.getPredecessor();
563 } else {
564 NewNode = C.addTransition(state);
565 }
566
567 // Annotate the node with summary we used.
568 if (NewNode) {
569 // FIXME: This is ugly. See checkEndAnalysis for why it's necessary.
570 if (ShouldResetSummaryLog) {
571 SummaryLog.clear();
572 ShouldResetSummaryLog = false;
573 }
574 SummaryLog[NewNode] = &Summ;
575 }
576}
577
578ProgramStateRef
579RetainCountChecker::updateSymbol(ProgramStateRef state, SymbolRef sym,
580 RefVal V, ArgEffect E, RefVal::Kind &hasErr,
581 CheckerContext &C) const {
582 bool IgnoreRetainMsg = (bool)C.getASTContext().getLangOpts().ObjCAutoRefCount;
583 switch (E) {
584 default:
585 break;
586 case IncRefMsg:
587 E = IgnoreRetainMsg ? DoNothing : IncRef;
588 break;
589 case DecRefMsg:
590 E = IgnoreRetainMsg ? DoNothing: DecRef;
591 break;
592 case DecRefMsgAndStopTrackingHard:
593 E = IgnoreRetainMsg ? StopTracking : DecRefAndStopTrackingHard;
594 break;
George Karpenkovbc0cddf2018-08-17 21:42:59 +0000595 case MakeCollectable:
596 E = DoNothing;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000597 }
598
599 // Handle all use-after-releases.
600 if (V.getKind() == RefVal::Released) {
601 V = V ^ RefVal::ErrorUseAfterRelease;
602 hasErr = V.getKind();
603 return setRefBinding(state, sym, V);
604 }
605
606 switch (E) {
607 case DecRefMsg:
608 case IncRefMsg:
George Karpenkovbc0cddf2018-08-17 21:42:59 +0000609 case MakeCollectable:
George Karpenkov70c2ee32018-08-17 21:41:07 +0000610 case DecRefMsgAndStopTrackingHard:
George Karpenkovbc0cddf2018-08-17 21:42:59 +0000611 llvm_unreachable("DecRefMsg/IncRefMsg/MakeCollectable already converted");
George Karpenkov70c2ee32018-08-17 21:41:07 +0000612
613 case UnretainedOutParameter:
614 case RetainedOutParameter:
615 llvm_unreachable("Applies to pointer-to-pointer parameters, which should "
616 "not have ref state.");
617
618 case Dealloc:
619 switch (V.getKind()) {
620 default:
621 llvm_unreachable("Invalid RefVal state for an explicit dealloc.");
622 case RefVal::Owned:
623 // The object immediately transitions to the released state.
624 V = V ^ RefVal::Released;
625 V.clearCounts();
626 return setRefBinding(state, sym, V);
627 case RefVal::NotOwned:
628 V = V ^ RefVal::ErrorDeallocNotOwned;
629 hasErr = V.getKind();
630 break;
631 }
632 break;
633
634 case MayEscape:
635 if (V.getKind() == RefVal::Owned) {
636 V = V ^ RefVal::NotOwned;
637 break;
638 }
639
640 // Fall-through.
641
642 case DoNothing:
643 return state;
644
645 case Autorelease:
646 // Update the autorelease counts.
647 V = V.autorelease();
648 break;
649
650 case StopTracking:
651 case StopTrackingHard:
652 return removeRefBinding(state, sym);
653
654 case IncRef:
655 switch (V.getKind()) {
656 default:
657 llvm_unreachable("Invalid RefVal state for a retain.");
658 case RefVal::Owned:
659 case RefVal::NotOwned:
660 V = V + 1;
661 break;
662 }
663 break;
664
665 case DecRef:
666 case DecRefBridgedTransferred:
667 case DecRefAndStopTrackingHard:
668 switch (V.getKind()) {
669 default:
670 // case 'RefVal::Released' handled above.
671 llvm_unreachable("Invalid RefVal state for a release.");
672
673 case RefVal::Owned:
674 assert(V.getCount() > 0);
675 if (V.getCount() == 1) {
676 if (E == DecRefBridgedTransferred ||
677 V.getIvarAccessHistory() ==
678 RefVal::IvarAccessHistory::AccessedDirectly)
679 V = V ^ RefVal::NotOwned;
680 else
681 V = V ^ RefVal::Released;
682 } else if (E == DecRefAndStopTrackingHard) {
683 return removeRefBinding(state, sym);
684 }
685
686 V = V - 1;
687 break;
688
689 case RefVal::NotOwned:
690 if (V.getCount() > 0) {
691 if (E == DecRefAndStopTrackingHard)
692 return removeRefBinding(state, sym);
693 V = V - 1;
694 } else if (V.getIvarAccessHistory() ==
695 RefVal::IvarAccessHistory::AccessedDirectly) {
696 // Assume that the instance variable was holding on the object at
697 // +1, and we just didn't know.
698 if (E == DecRefAndStopTrackingHard)
699 return removeRefBinding(state, sym);
700 V = V.releaseViaIvar() ^ RefVal::Released;
701 } else {
702 V = V ^ RefVal::ErrorReleaseNotOwned;
703 hasErr = V.getKind();
704 }
705 break;
706 }
707 break;
708 }
709 return setRefBinding(state, sym, V);
710}
711
712void RetainCountChecker::processNonLeakError(ProgramStateRef St,
713 SourceRange ErrorRange,
714 RefVal::Kind ErrorKind,
715 SymbolRef Sym,
716 CheckerContext &C) const {
717 // HACK: Ignore retain-count issues on values accessed through ivars,
718 // because of cases like this:
719 // [_contentView retain];
720 // [_contentView removeFromSuperview];
721 // [self addSubview:_contentView]; // invalidates 'self'
722 // [_contentView release];
723 if (const RefVal *RV = getRefBinding(St, Sym))
724 if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
725 return;
726
727 ExplodedNode *N = C.generateErrorNode(St);
728 if (!N)
729 return;
730
731 CFRefBug *BT;
732 switch (ErrorKind) {
733 default:
734 llvm_unreachable("Unhandled error.");
735 case RefVal::ErrorUseAfterRelease:
736 if (!useAfterRelease)
737 useAfterRelease.reset(new UseAfterRelease(this));
738 BT = useAfterRelease.get();
739 break;
740 case RefVal::ErrorReleaseNotOwned:
741 if (!releaseNotOwned)
742 releaseNotOwned.reset(new BadRelease(this));
743 BT = releaseNotOwned.get();
744 break;
745 case RefVal::ErrorDeallocNotOwned:
746 if (!deallocNotOwned)
747 deallocNotOwned.reset(new DeallocNotOwned(this));
748 BT = deallocNotOwned.get();
749 break;
750 }
751
752 assert(BT);
George Karpenkov6babf2a2018-09-21 20:36:21 +0000753 auto report = llvm::make_unique<CFRefReport>(
754 *BT, C.getASTContext().getLangOpts(), SummaryLog, N, Sym);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000755 report->addRange(ErrorRange);
756 C.emitReport(std::move(report));
757}
758
759//===----------------------------------------------------------------------===//
760// Handle the return values of retain-count-related functions.
761//===----------------------------------------------------------------------===//
762
763bool RetainCountChecker::evalCall(const CallExpr *CE, CheckerContext &C) const {
764 // Get the callee. We're only interested in simple C functions.
765 ProgramStateRef state = C.getState();
766 const FunctionDecl *FD = C.getCalleeDecl(CE);
767 if (!FD)
768 return false;
769
George Karpenkovc4d6b932018-08-17 21:42:05 +0000770 RetainSummaryManager &SmrMgr = getSummaryManager(C);
771 QualType ResultTy = CE->getCallReturnType(C.getASTContext());
George Karpenkov70c2ee32018-08-17 21:41:07 +0000772
George Karpenkov70c2ee32018-08-17 21:41:07 +0000773 // See if the function has 'rc_ownership_trusted_implementation'
774 // annotate attribute. If it does, we will not inline it.
775 bool hasTrustedImplementationAnnotation = false;
776
George Karpenkov41dc8de2018-10-11 22:59:16 +0000777 const LocationContext *LCtx = C.getLocationContext();
778
George Karpenkovc4d6b932018-08-17 21:42:05 +0000779 // See if it's one of the specific functions we know how to eval.
George Karpenkovb1b791b2018-08-17 21:43:27 +0000780 if (!SmrMgr.canEval(CE, FD, hasTrustedImplementationAnnotation))
George Karpenkov70c2ee32018-08-17 21:41:07 +0000781 return false;
782
783 // Bind the return value.
George Karpenkov48de5822018-10-23 23:11:30 +0000784 // For now, all the functions which we can evaluate and which take
785 // at least one argument are identities.
786 if (CE->getNumArgs() >= 1) {
787 SVal RetVal = state->getSVal(CE->getArg(0), LCtx);
788
George Karpenkov70c2ee32018-08-17 21:41:07 +0000789 // If the receiver is unknown or the function has
790 // 'rc_ownership_trusted_implementation' annotate attribute, conjure a
791 // return value.
George Karpenkov48de5822018-10-23 23:11:30 +0000792 if (RetVal.isUnknown() ||
793 (hasTrustedImplementationAnnotation && !ResultTy.isNull())) {
794 SValBuilder &SVB = C.getSValBuilder();
795 RetVal =
796 SVB.conjureSymbolVal(nullptr, CE, LCtx, ResultTy, C.blockCount());
797 }
798 state = state->BindExpr(CE, LCtx, RetVal, false);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000799 }
George Karpenkov70c2ee32018-08-17 21:41:07 +0000800
George Karpenkov70c2ee32018-08-17 21:41:07 +0000801 C.addTransition(state);
802 return true;
803}
804
George Karpenkov04553e52018-09-21 20:37:20 +0000805ExplodedNode * RetainCountChecker::processReturn(const ReturnStmt *S,
806 CheckerContext &C) const {
807 ExplodedNode *Pred = C.getPredecessor();
George Karpenkov70c2ee32018-08-17 21:41:07 +0000808
809 // Only adjust the reference count if this is the top-level call frame,
810 // and not the result of inlining. In the future, we should do
811 // better checking even for inlined calls, and see if they match
812 // with their expected semantics (e.g., the method should return a retained
813 // object, etc.).
814 if (!C.inTopFrame())
George Karpenkov04553e52018-09-21 20:37:20 +0000815 return Pred;
816
817 if (!S)
818 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000819
820 const Expr *RetE = S->getRetValue();
821 if (!RetE)
George Karpenkov04553e52018-09-21 20:37:20 +0000822 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000823
824 ProgramStateRef state = C.getState();
825 SymbolRef Sym =
826 state->getSValAsScalarOrLoc(RetE, C.getLocationContext()).getAsLocSymbol();
827 if (!Sym)
George Karpenkov04553e52018-09-21 20:37:20 +0000828 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000829
830 // Get the reference count binding (if any).
831 const RefVal *T = getRefBinding(state, Sym);
832 if (!T)
George Karpenkov04553e52018-09-21 20:37:20 +0000833 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000834
835 // Change the reference count.
836 RefVal X = *T;
837
838 switch (X.getKind()) {
839 case RefVal::Owned: {
840 unsigned cnt = X.getCount();
841 assert(cnt > 0);
842 X.setCount(cnt - 1);
843 X = X ^ RefVal::ReturnedOwned;
844 break;
845 }
846
847 case RefVal::NotOwned: {
848 unsigned cnt = X.getCount();
849 if (cnt) {
850 X.setCount(cnt - 1);
851 X = X ^ RefVal::ReturnedOwned;
George Karpenkov04553e52018-09-21 20:37:20 +0000852 } else {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000853 X = X ^ RefVal::ReturnedNotOwned;
854 }
855 break;
856 }
857
858 default:
George Karpenkov04553e52018-09-21 20:37:20 +0000859 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000860 }
861
862 // Update the binding.
863 state = setRefBinding(state, Sym, X);
George Karpenkov04553e52018-09-21 20:37:20 +0000864 Pred = C.addTransition(state);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000865
866 // At this point we have updated the state properly.
867 // Everything after this is merely checking to see if the return value has
868 // been over- or under-retained.
869
870 // Did we cache out?
871 if (!Pred)
George Karpenkov04553e52018-09-21 20:37:20 +0000872 return nullptr;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000873
874 // Update the autorelease counts.
875 static CheckerProgramPointTag AutoreleaseTag(this, "Autorelease");
George Karpenkov04553e52018-09-21 20:37:20 +0000876 state = handleAutoreleaseCounts(state, Pred, &AutoreleaseTag, C, Sym, X, S);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000877
George Karpenkov04553e52018-09-21 20:37:20 +0000878 // Have we generated a sink node?
George Karpenkov70c2ee32018-08-17 21:41:07 +0000879 if (!state)
George Karpenkov04553e52018-09-21 20:37:20 +0000880 return nullptr;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000881
882 // Get the updated binding.
883 T = getRefBinding(state, Sym);
884 assert(T);
885 X = *T;
886
887 // Consult the summary of the enclosing method.
888 RetainSummaryManager &Summaries = getSummaryManager(C);
889 const Decl *CD = &Pred->getCodeDecl();
890 RetEffect RE = RetEffect::MakeNoRet();
891
892 // FIXME: What is the convention for blocks? Is there one?
893 if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(CD)) {
894 const RetainSummary *Summ = Summaries.getMethodSummary(MD);
895 RE = Summ->getRetEffect();
896 } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(CD)) {
897 if (!isa<CXXMethodDecl>(FD)) {
898 const RetainSummary *Summ = Summaries.getFunctionSummary(FD);
899 RE = Summ->getRetEffect();
900 }
901 }
902
George Karpenkov04553e52018-09-21 20:37:20 +0000903 return checkReturnWithRetEffect(S, C, Pred, RE, X, Sym, state);
George Karpenkov70c2ee32018-08-17 21:41:07 +0000904}
905
George Karpenkov04553e52018-09-21 20:37:20 +0000906ExplodedNode * RetainCountChecker::checkReturnWithRetEffect(const ReturnStmt *S,
George Karpenkov70c2ee32018-08-17 21:41:07 +0000907 CheckerContext &C,
908 ExplodedNode *Pred,
909 RetEffect RE, RefVal X,
910 SymbolRef Sym,
911 ProgramStateRef state) const {
912 // HACK: Ignore retain-count issues on values accessed through ivars,
913 // because of cases like this:
914 // [_contentView retain];
915 // [_contentView removeFromSuperview];
916 // [self addSubview:_contentView]; // invalidates 'self'
917 // [_contentView release];
918 if (X.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
George Karpenkov04553e52018-09-21 20:37:20 +0000919 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000920
921 // Any leaks or other errors?
922 if (X.isReturnedOwned() && X.getCount() == 0) {
923 if (RE.getKind() != RetEffect::NoRet) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000924 if (!RE.isOwned()) {
George Karpenkov04553e52018-09-21 20:37:20 +0000925
George Karpenkov70c2ee32018-08-17 21:41:07 +0000926 // The returning type is a CF, we expect the enclosing method should
927 // return ownership.
George Karpenkov70c2ee32018-08-17 21:41:07 +0000928 X = X ^ RefVal::ErrorLeakReturned;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000929
George Karpenkov70c2ee32018-08-17 21:41:07 +0000930 // Generate an error node.
931 state = setRefBinding(state, Sym, X);
932
933 static CheckerProgramPointTag ReturnOwnLeakTag(this, "ReturnsOwnLeak");
934 ExplodedNode *N = C.addTransition(state, Pred, &ReturnOwnLeakTag);
935 if (N) {
936 const LangOptions &LOpts = C.getASTContext().getLangOpts();
George Karpenkov04553e52018-09-21 20:37:20 +0000937 auto R = llvm::make_unique<CFRefLeakReport>(
George Karpenkov6babf2a2018-09-21 20:36:21 +0000938 *getLeakAtReturnBug(LOpts), LOpts, SummaryLog, N, Sym, C,
George Karpenkov04553e52018-09-21 20:37:20 +0000939 IncludeAllocationLine);
940 C.emitReport(std::move(R));
George Karpenkov70c2ee32018-08-17 21:41:07 +0000941 }
George Karpenkov04553e52018-09-21 20:37:20 +0000942 return N;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000943 }
944 }
945 } else if (X.isReturnedNotOwned()) {
946 if (RE.isOwned()) {
947 if (X.getIvarAccessHistory() ==
948 RefVal::IvarAccessHistory::AccessedDirectly) {
949 // Assume the method was trying to transfer a +1 reference from a
950 // strong ivar to the caller.
951 state = setRefBinding(state, Sym,
952 X.releaseViaIvar() ^ RefVal::ReturnedOwned);
953 } else {
954 // Trying to return a not owned object to a caller expecting an
955 // owned object.
956 state = setRefBinding(state, Sym, X ^ RefVal::ErrorReturnedNotOwned);
957
958 static CheckerProgramPointTag
959 ReturnNotOwnedTag(this, "ReturnNotOwnedForOwned");
960
961 ExplodedNode *N = C.addTransition(state, Pred, &ReturnNotOwnedTag);
962 if (N) {
963 if (!returnNotOwnedForOwned)
964 returnNotOwnedForOwned.reset(new ReturnedNotOwnedForOwned(this));
965
George Karpenkov04553e52018-09-21 20:37:20 +0000966 auto R = llvm::make_unique<CFRefReport>(
George Karpenkov70c2ee32018-08-17 21:41:07 +0000967 *returnNotOwnedForOwned, C.getASTContext().getLangOpts(),
George Karpenkov04553e52018-09-21 20:37:20 +0000968 SummaryLog, N, Sym);
969 C.emitReport(std::move(R));
George Karpenkov70c2ee32018-08-17 21:41:07 +0000970 }
George Karpenkov04553e52018-09-21 20:37:20 +0000971 return N;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000972 }
973 }
974 }
George Karpenkov04553e52018-09-21 20:37:20 +0000975 return Pred;
George Karpenkov70c2ee32018-08-17 21:41:07 +0000976}
977
978//===----------------------------------------------------------------------===//
979// Check various ways a symbol can be invalidated.
980//===----------------------------------------------------------------------===//
981
982void RetainCountChecker::checkBind(SVal loc, SVal val, const Stmt *S,
983 CheckerContext &C) const {
984 // Are we storing to something that causes the value to "escape"?
985 bool escapes = true;
986
987 // A value escapes in three possible cases (this may change):
988 //
989 // (1) we are binding to something that is not a memory region.
990 // (2) we are binding to a memregion that does not have stack storage
991 // (3) we are binding to a memregion with stack storage that the store
992 // does not understand.
993 ProgramStateRef state = C.getState();
994
George Karpenkov6e9fd132018-08-22 01:17:09 +0000995 if (auto regionLoc = loc.getAs<loc::MemRegionVal>()) {
George Karpenkov70c2ee32018-08-17 21:41:07 +0000996 escapes = !regionLoc->getRegion()->hasStackStorage();
997
998 if (!escapes) {
999 // To test (3), generate a new state with the binding added. If it is
1000 // the same state, then it escapes (since the store cannot represent
1001 // the binding).
1002 // Do this only if we know that the store is not supposed to generate the
1003 // same state.
1004 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1005 if (StoredVal != val)
1006 escapes = (state == (state->bindLoc(*regionLoc, val, C.getLocationContext())));
1007 }
1008 if (!escapes) {
1009 // Case 4: We do not currently model what happens when a symbol is
1010 // assigned to a struct field, so be conservative here and let the symbol
1011 // go. TODO: This could definitely be improved upon.
1012 escapes = !isa<VarRegion>(regionLoc->getRegion());
1013 }
1014 }
1015
1016 // If we are storing the value into an auto function scope variable annotated
1017 // with (__attribute__((cleanup))), stop tracking the value to avoid leak
1018 // false positives.
George Karpenkov6e9fd132018-08-22 01:17:09 +00001019 if (const auto *LVR = dyn_cast_or_null<VarRegion>(loc.getAsRegion())) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001020 const VarDecl *VD = LVR->getDecl();
1021 if (VD->hasAttr<CleanupAttr>()) {
1022 escapes = true;
1023 }
1024 }
1025
1026 // If our store can represent the binding and we aren't storing to something
1027 // that doesn't have local storage then just return and have the simulation
1028 // state continue as is.
1029 if (!escapes)
1030 return;
1031
1032 // Otherwise, find all symbols referenced by 'val' that we are tracking
1033 // and stop tracking them.
1034 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1035 C.addTransition(state);
1036}
1037
1038ProgramStateRef RetainCountChecker::evalAssume(ProgramStateRef state,
George Karpenkov6e9fd132018-08-22 01:17:09 +00001039 SVal Cond,
1040 bool Assumption) const {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001041 // FIXME: We may add to the interface of evalAssume the list of symbols
1042 // whose assumptions have changed. For now we just iterate through the
1043 // bindings and check if any of the tracked symbols are NULL. This isn't
1044 // too bad since the number of symbols we will track in practice are
1045 // probably small and evalAssume is only called at branches and a few
1046 // other places.
1047 RefBindingsTy B = state->get<RefBindings>();
1048
1049 if (B.isEmpty())
1050 return state;
1051
1052 bool changed = false;
1053 RefBindingsTy::Factory &RefBFactory = state->get_context<RefBindings>();
1054
1055 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
1056 // Check if the symbol is null stop tracking the symbol.
1057 ConstraintManager &CMgr = state->getConstraintManager();
1058 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
1059 if (AllocFailed.isConstrainedTrue()) {
1060 changed = true;
1061 B = RefBFactory.remove(B, I.getKey());
1062 }
1063 }
1064
1065 if (changed)
1066 state = state->set<RefBindings>(B);
1067
1068 return state;
1069}
1070
1071ProgramStateRef
1072RetainCountChecker::checkRegionChanges(ProgramStateRef state,
1073 const InvalidatedSymbols *invalidated,
1074 ArrayRef<const MemRegion *> ExplicitRegions,
1075 ArrayRef<const MemRegion *> Regions,
1076 const LocationContext *LCtx,
1077 const CallEvent *Call) const {
1078 if (!invalidated)
1079 return state;
1080
1081 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
1082 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1083 E = ExplicitRegions.end(); I != E; ++I) {
1084 if (const SymbolicRegion *SR = (*I)->StripCasts()->getAs<SymbolicRegion>())
1085 WhitelistedSymbols.insert(SR->getSymbol());
1086 }
1087
1088 for (InvalidatedSymbols::const_iterator I=invalidated->begin(),
1089 E = invalidated->end(); I!=E; ++I) {
1090 SymbolRef sym = *I;
1091 if (WhitelistedSymbols.count(sym))
1092 continue;
1093 // Remove any existing reference-count binding.
1094 state = removeRefBinding(state, sym);
1095 }
1096 return state;
1097}
1098
George Karpenkov70c2ee32018-08-17 21:41:07 +00001099ProgramStateRef
1100RetainCountChecker::handleAutoreleaseCounts(ProgramStateRef state,
1101 ExplodedNode *Pred,
1102 const ProgramPointTag *Tag,
1103 CheckerContext &Ctx,
George Karpenkov04553e52018-09-21 20:37:20 +00001104 SymbolRef Sym,
1105 RefVal V,
1106 const ReturnStmt *S) const {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001107 unsigned ACnt = V.getAutoreleaseCount();
1108
1109 // No autorelease counts? Nothing to be done.
1110 if (!ACnt)
1111 return state;
1112
1113 unsigned Cnt = V.getCount();
1114
1115 // FIXME: Handle sending 'autorelease' to already released object.
1116
1117 if (V.getKind() == RefVal::ReturnedOwned)
1118 ++Cnt;
1119
1120 // If we would over-release here, but we know the value came from an ivar,
1121 // assume it was a strong ivar that's just been relinquished.
1122 if (ACnt > Cnt &&
1123 V.getIvarAccessHistory() == RefVal::IvarAccessHistory::AccessedDirectly) {
1124 V = V.releaseViaIvar();
1125 --ACnt;
1126 }
1127
1128 if (ACnt <= Cnt) {
1129 if (ACnt == Cnt) {
1130 V.clearCounts();
George Karpenkov04553e52018-09-21 20:37:20 +00001131 if (V.getKind() == RefVal::ReturnedOwned) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001132 V = V ^ RefVal::ReturnedNotOwned;
George Karpenkov04553e52018-09-21 20:37:20 +00001133 } else {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001134 V = V ^ RefVal::NotOwned;
George Karpenkov04553e52018-09-21 20:37:20 +00001135 }
George Karpenkov70c2ee32018-08-17 21:41:07 +00001136 } else {
1137 V.setCount(V.getCount() - ACnt);
1138 V.setAutoreleaseCount(0);
1139 }
1140 return setRefBinding(state, Sym, V);
1141 }
1142
1143 // HACK: Ignore retain-count issues on values accessed through ivars,
1144 // because of cases like this:
1145 // [_contentView retain];
1146 // [_contentView removeFromSuperview];
1147 // [self addSubview:_contentView]; // invalidates 'self'
1148 // [_contentView release];
1149 if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
1150 return state;
1151
1152 // Woah! More autorelease counts then retain counts left.
1153 // Emit hard error.
1154 V = V ^ RefVal::ErrorOverAutorelease;
1155 state = setRefBinding(state, Sym, V);
1156
1157 ExplodedNode *N = Ctx.generateSink(state, Pred, Tag);
1158 if (N) {
1159 SmallString<128> sbuf;
1160 llvm::raw_svector_ostream os(sbuf);
1161 os << "Object was autoreleased ";
1162 if (V.getAutoreleaseCount() > 1)
1163 os << V.getAutoreleaseCount() << " times but the object ";
1164 else
1165 os << "but ";
1166 os << "has a +" << V.getCount() << " retain count";
1167
1168 if (!overAutorelease)
1169 overAutorelease.reset(new OverAutorelease(this));
1170
1171 const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
George Karpenkov04553e52018-09-21 20:37:20 +00001172 auto R = llvm::make_unique<CFRefReport>(*overAutorelease, LOpts, SummaryLog,
1173 N, Sym, os.str());
1174 Ctx.emitReport(std::move(R));
George Karpenkov70c2ee32018-08-17 21:41:07 +00001175 }
1176
1177 return nullptr;
1178}
1179
1180ProgramStateRef
1181RetainCountChecker::handleSymbolDeath(ProgramStateRef state,
1182 SymbolRef sid, RefVal V,
1183 SmallVectorImpl<SymbolRef> &Leaked) const {
1184 bool hasLeak;
1185
1186 // HACK: Ignore retain-count issues on values accessed through ivars,
1187 // because of cases like this:
1188 // [_contentView retain];
1189 // [_contentView removeFromSuperview];
1190 // [self addSubview:_contentView]; // invalidates 'self'
1191 // [_contentView release];
1192 if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
1193 hasLeak = false;
1194 else if (V.isOwned())
1195 hasLeak = true;
1196 else if (V.isNotOwned() || V.isReturnedOwned())
1197 hasLeak = (V.getCount() > 0);
1198 else
1199 hasLeak = false;
1200
1201 if (!hasLeak)
1202 return removeRefBinding(state, sid);
1203
1204 Leaked.push_back(sid);
1205 return setRefBinding(state, sid, V ^ RefVal::ErrorLeak);
1206}
1207
1208ExplodedNode *
1209RetainCountChecker::processLeaks(ProgramStateRef state,
1210 SmallVectorImpl<SymbolRef> &Leaked,
1211 CheckerContext &Ctx,
1212 ExplodedNode *Pred) const {
1213 // Generate an intermediate node representing the leak point.
1214 ExplodedNode *N = Ctx.addTransition(state, Pred);
1215
1216 if (N) {
1217 for (SmallVectorImpl<SymbolRef>::iterator
1218 I = Leaked.begin(), E = Leaked.end(); I != E; ++I) {
1219
1220 const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
1221 CFRefBug *BT = Pred ? getLeakWithinFunctionBug(LOpts)
1222 : getLeakAtReturnBug(LOpts);
1223 assert(BT && "BugType not initialized.");
1224
George Karpenkov6babf2a2018-09-21 20:36:21 +00001225 Ctx.emitReport(llvm::make_unique<CFRefLeakReport>(
1226 *BT, LOpts, SummaryLog, N, *I, Ctx, IncludeAllocationLine));
George Karpenkov70c2ee32018-08-17 21:41:07 +00001227 }
1228 }
1229
1230 return N;
1231}
1232
George Karpenkovb1b791b2018-08-17 21:43:27 +00001233static bool isISLObjectRef(QualType Ty) {
1234 return StringRef(Ty.getAsString()).startswith("isl_");
George Karpenkov70c2ee32018-08-17 21:41:07 +00001235}
1236
1237void RetainCountChecker::checkBeginFunction(CheckerContext &Ctx) const {
1238 if (!Ctx.inTopFrame())
1239 return;
1240
George Karpenkovc4d6b932018-08-17 21:42:05 +00001241 RetainSummaryManager &SmrMgr = getSummaryManager(Ctx);
George Karpenkov70c2ee32018-08-17 21:41:07 +00001242 const LocationContext *LCtx = Ctx.getLocationContext();
1243 const FunctionDecl *FD = dyn_cast<FunctionDecl>(LCtx->getDecl());
1244
George Karpenkovc4d6b932018-08-17 21:42:05 +00001245 if (!FD || SmrMgr.isTrustedReferenceCountImplementation(FD))
George Karpenkov70c2ee32018-08-17 21:41:07 +00001246 return;
1247
1248 ProgramStateRef state = Ctx.getState();
George Karpenkovc4d6b932018-08-17 21:42:05 +00001249 const RetainSummary *FunctionSummary = SmrMgr.getFunctionSummary(FD);
George Karpenkov70c2ee32018-08-17 21:41:07 +00001250 ArgEffects CalleeSideArgEffects = FunctionSummary->getArgEffects();
1251
1252 for (unsigned idx = 0, e = FD->getNumParams(); idx != e; ++idx) {
1253 const ParmVarDecl *Param = FD->getParamDecl(idx);
1254 SymbolRef Sym = state->getSVal(state->getRegion(Param, LCtx)).getAsSymbol();
1255
1256 QualType Ty = Param->getType();
1257 const ArgEffect *AE = CalleeSideArgEffects.lookup(idx);
George Karpenkovb1b791b2018-08-17 21:43:27 +00001258 if (AE && *AE == DecRef && isISLObjectRef(Ty)) {
George Karpenkov6e9fd132018-08-22 01:17:09 +00001259 state = setRefBinding(
1260 state, Sym, RefVal::makeOwned(RetEffect::ObjKind::Generalized, Ty));
George Karpenkovb1b791b2018-08-17 21:43:27 +00001261 } else if (isISLObjectRef(Ty)) {
George Karpenkov70c2ee32018-08-17 21:41:07 +00001262 state = setRefBinding(
1263 state, Sym,
1264 RefVal::makeNotOwned(RetEffect::ObjKind::Generalized, Ty));
1265 }
1266 }
1267
1268 Ctx.addTransition(state);
1269}
1270
1271void RetainCountChecker::checkEndFunction(const ReturnStmt *RS,
1272 CheckerContext &Ctx) const {
George Karpenkov04553e52018-09-21 20:37:20 +00001273 ExplodedNode *Pred = processReturn(RS, Ctx);
1274
1275 // Created state cached out.
1276 if (!Pred) {
1277 return;
1278 }
1279
1280 ProgramStateRef state = Pred->getState();
George Karpenkov70c2ee32018-08-17 21:41:07 +00001281 RefBindingsTy B = state->get<RefBindings>();
George Karpenkov70c2ee32018-08-17 21:41:07 +00001282
1283 // Don't process anything within synthesized bodies.
1284 const LocationContext *LCtx = Pred->getLocationContext();
1285 if (LCtx->getAnalysisDeclContext()->isBodyAutosynthesized()) {
1286 assert(!LCtx->inTopFrame());
1287 return;
1288 }
1289
1290 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
1291 state = handleAutoreleaseCounts(state, Pred, /*Tag=*/nullptr, Ctx,
1292 I->first, I->second);
1293 if (!state)
1294 return;
1295 }
1296
1297 // If the current LocationContext has a parent, don't check for leaks.
1298 // We will do that later.
1299 // FIXME: we should instead check for imbalances of the retain/releases,
1300 // and suggest annotations.
1301 if (LCtx->getParent())
1302 return;
1303
1304 B = state->get<RefBindings>();
1305 SmallVector<SymbolRef, 10> Leaked;
1306
1307 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I)
1308 state = handleSymbolDeath(state, I->first, I->second, Leaked);
1309
1310 processLeaks(state, Leaked, Ctx, Pred);
1311}
1312
George Karpenkov70c2ee32018-08-17 21:41:07 +00001313void RetainCountChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1314 CheckerContext &C) const {
1315 ExplodedNode *Pred = C.getPredecessor();
1316
1317 ProgramStateRef state = C.getState();
1318 RefBindingsTy B = state->get<RefBindings>();
1319 SmallVector<SymbolRef, 10> Leaked;
1320
1321 // Update counts from autorelease pools
1322 for (SymbolReaper::dead_iterator I = SymReaper.dead_begin(),
1323 E = SymReaper.dead_end(); I != E; ++I) {
1324 SymbolRef Sym = *I;
1325 if (const RefVal *T = B.lookup(Sym)){
1326 // Use the symbol as the tag.
1327 // FIXME: This might not be as unique as we would like.
Artem Dergachev65b4d7d2018-10-15 17:47:56 +00001328 static CheckerProgramPointTag Tag(this, "DeadSymbolAutorelease");
1329 state = handleAutoreleaseCounts(state, Pred, &Tag, C, Sym, *T);
George Karpenkov70c2ee32018-08-17 21:41:07 +00001330 if (!state)
1331 return;
1332
1333 // Fetch the new reference count from the state, and use it to handle
1334 // this symbol.
1335 state = handleSymbolDeath(state, *I, *getRefBinding(state, Sym), Leaked);
1336 }
1337 }
1338
1339 if (Leaked.empty()) {
1340 C.addTransition(state);
1341 return;
1342 }
1343
1344 Pred = processLeaks(state, Leaked, C, Pred);
1345
1346 // Did we cache out?
1347 if (!Pred)
1348 return;
1349
1350 // Now generate a new node that nukes the old bindings.
1351 // The only bindings left at this point are the leaked symbols.
1352 RefBindingsTy::Factory &F = state->get_context<RefBindings>();
1353 B = state->get<RefBindings>();
1354
1355 for (SmallVectorImpl<SymbolRef>::iterator I = Leaked.begin(),
1356 E = Leaked.end();
1357 I != E; ++I)
1358 B = F.remove(B, *I);
1359
1360 state = state->set<RefBindings>(B);
1361 C.addTransition(state, Pred);
1362}
1363
1364void RetainCountChecker::printState(raw_ostream &Out, ProgramStateRef State,
1365 const char *NL, const char *Sep) const {
1366
1367 RefBindingsTy B = State->get<RefBindings>();
1368
1369 if (B.isEmpty())
1370 return;
1371
1372 Out << Sep << NL;
1373
1374 for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
1375 Out << I->first << " : ";
1376 I->second.print(Out);
1377 Out << NL;
1378 }
1379}
1380
1381//===----------------------------------------------------------------------===//
George Karpenkov70c2ee32018-08-17 21:41:07 +00001382// Checker registration.
1383//===----------------------------------------------------------------------===//
1384
1385void ento::registerRetainCountChecker(CheckerManager &Mgr) {
1386 Mgr.registerChecker<RetainCountChecker>(Mgr.getAnalyzerOptions());
1387}