blob: 0693bd6fd94df3ba24b3227730bf4a992f314095 [file] [log] [blame]
Anna Zakscc925212011-10-11 16:49:54 +00001//= CStringChecker.cpp - Checks calls to C string functions --------*- C++ -*-//
Jordy Rose134a2362010-07-06 23:11:01 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This defines CStringChecker, which is an assortment of checks on calls
11// to functions in <string.h>.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis2d3905f2011-02-15 21:25:03 +000015#include "ClangSACheckers.h"
Anna Zakse56167e2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Jordan Rose4938f272013-02-09 10:09:43 +000017#include "clang/Basic/CharInfo.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000018#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Argyrios Kyrtzidis6a5674f2011-03-01 01:16:21 +000019#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis507ff532011-02-17 21:39:17 +000020#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek001fd5b2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Benjamin Kramer3307c5082012-02-04 12:31:12 +000023#include "llvm/ADT/STLExtras.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000024#include "llvm/ADT/SmallString.h"
Jordy Rose134a2362010-07-06 23:11:01 +000025#include "llvm/ADT/StringSwitch.h"
Benjamin Kramer444a1302012-12-01 17:12:56 +000026#include "llvm/Support/raw_ostream.h"
Jordy Rose134a2362010-07-06 23:11:01 +000027
28using namespace clang;
Ted Kremenek98857c92010-12-23 07:20:52 +000029using namespace ento;
Jordy Rose134a2362010-07-06 23:11:01 +000030
31namespace {
Argyrios Kyrtzidis6a5674f2011-03-01 01:16:21 +000032class CStringChecker : public Checker< eval::Call,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000033 check::PreStmt<DeclStmt>,
34 check::LiveSymbols,
35 check::DeadSymbols,
36 check::RegionChanges
37 > {
Ahmed Charlesb8984322014-03-07 20:03:18 +000038 mutable std::unique_ptr<BugType> BT_Null, BT_Bounds, BT_Overlap,
39 BT_NotCString, BT_AdditionOverflow;
Anna Zakse0c7c272012-02-07 00:56:14 +000040
Jordy Rosedceb0cf2011-06-20 02:06:40 +000041 mutable const char *CurrentFunctionDescription;
42
Jordy Rose134a2362010-07-06 23:11:01 +000043public:
Anna Zakse0c7c272012-02-07 00:56:14 +000044 /// The filter is used to filter out the diagnostics which are not enabled by
45 /// the user.
46 struct CStringChecksFilter {
47 DefaultBool CheckCStringNullArg;
48 DefaultBool CheckCStringOutOfBounds;
49 DefaultBool CheckCStringBufferOverlap;
50 DefaultBool CheckCStringNotNullTerm;
Alexander Kornienko4aca9b12014-02-11 21:49:21 +000051
52 CheckName CheckNameCStringNullArg;
53 CheckName CheckNameCStringOutOfBounds;
54 CheckName CheckNameCStringBufferOverlap;
55 CheckName CheckNameCStringNotNullTerm;
Anna Zakse0c7c272012-02-07 00:56:14 +000056 };
57
58 CStringChecksFilter Filter;
59
Jordy Rose134a2362010-07-06 23:11:01 +000060 static void *getTag() { static int tag; return &tag; }
61
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000062 bool evalCall(const CallExpr *CE, CheckerContext &C) const;
63 void checkPreStmt(const DeclStmt *DS, CheckerContext &C) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +000064 void checkLiveSymbols(ProgramStateRef state, SymbolReaper &SR) const;
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000065 void checkDeadSymbols(SymbolReaper &SR, CheckerContext &C) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +000066 bool wantsRegionChangeUpdate(ProgramStateRef state) const;
Jordy Rose2a2e21c2010-08-14 21:02:52 +000067
Ted Kremenek49b1e382012-01-26 21:29:00 +000068 ProgramStateRef
69 checkRegionChanges(ProgramStateRef state,
Anna Zaksdc154152012-12-20 00:38:25 +000070 const InvalidatedSymbols *,
Jordy Rose1fad6632011-08-27 22:51:26 +000071 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks3d348342012-02-14 21:55:24 +000072 ArrayRef<const MemRegion *> Regions,
Jordan Rose742920c2012-07-02 19:27:35 +000073 const CallEvent *Call) const;
Jordy Rose134a2362010-07-06 23:11:01 +000074
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000075 typedef void (CStringChecker::*FnCheck)(CheckerContext &,
76 const CallExpr *) const;
Jordy Rose134a2362010-07-06 23:11:01 +000077
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000078 void evalMemcpy(CheckerContext &C, const CallExpr *CE) const;
Lenny Maiorani79d74142011-03-31 21:36:53 +000079 void evalMempcpy(CheckerContext &C, const CallExpr *CE) const;
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000080 void evalMemmove(CheckerContext &C, const CallExpr *CE) const;
81 void evalBcopy(CheckerContext &C, const CallExpr *CE) const;
Lenny Maiorani79d74142011-03-31 21:36:53 +000082 void evalCopyCommon(CheckerContext &C, const CallExpr *CE,
Ted Kremenek49b1e382012-01-26 21:29:00 +000083 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +000084 const Expr *Size,
85 const Expr *Source,
86 const Expr *Dest,
Lenny Maiorani79d74142011-03-31 21:36:53 +000087 bool Restricted = false,
88 bool IsMempcpy = false) const;
Jordy Rosed5d2e502010-07-08 23:57:29 +000089
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000090 void evalMemcmp(CheckerContext &C, const CallExpr *CE) const;
Jordy Rose134a2362010-07-06 23:11:01 +000091
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000092 void evalstrLength(CheckerContext &C, const CallExpr *CE) const;
93 void evalstrnLength(CheckerContext &C, const CallExpr *CE) const;
Ted Kremenek001fd5b2011-08-15 22:09:50 +000094 void evalstrLengthCommon(CheckerContext &C,
95 const CallExpr *CE,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000096 bool IsStrnlen = false) const;
Jordy Roseb052e8f2010-07-27 01:37:31 +000097
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +000098 void evalStrcpy(CheckerContext &C, const CallExpr *CE) const;
99 void evalStrncpy(CheckerContext &C, const CallExpr *CE) const;
100 void evalStpcpy(CheckerContext &C, const CallExpr *CE) const;
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000101 void evalStrcpyCommon(CheckerContext &C,
102 const CallExpr *CE,
103 bool returnEnd,
104 bool isBounded,
105 bool isAppending) const;
Lenny Maiorani467dbd52011-04-09 15:12:58 +0000106
107 void evalStrcat(CheckerContext &C, const CallExpr *CE) const;
108 void evalStrncat(CheckerContext &C, const CallExpr *CE) const;
Jordy Rose722f5582010-08-16 07:51:42 +0000109
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000110 void evalStrcmp(CheckerContext &C, const CallExpr *CE) const;
Lenny Maioranie553e402011-04-25 22:21:00 +0000111 void evalStrncmp(CheckerContext &C, const CallExpr *CE) const;
Lenny Maiorani4af23c82011-04-28 15:09:11 +0000112 void evalStrcasecmp(CheckerContext &C, const CallExpr *CE) const;
Lenny Maiorani0b510272011-05-02 19:05:49 +0000113 void evalStrncasecmp(CheckerContext &C, const CallExpr *CE) const;
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000114 void evalStrcmpCommon(CheckerContext &C,
115 const CallExpr *CE,
116 bool isBounded = false,
117 bool ignoreCase = false) const;
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000118
Jordan Rose6e3cf2b2013-04-22 23:18:42 +0000119 void evalStrsep(CheckerContext &C, const CallExpr *CE) const;
120
Jordy Rose134a2362010-07-06 23:11:01 +0000121 // Utility methods
Ted Kremenek49b1e382012-01-26 21:29:00 +0000122 std::pair<ProgramStateRef , ProgramStateRef >
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000123 static assumeZero(CheckerContext &C,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000124 ProgramStateRef state, SVal V, QualType Ty);
Jordy Rosed5d2e502010-07-08 23:57:29 +0000125
Ted Kremenek49b1e382012-01-26 21:29:00 +0000126 static ProgramStateRef setCStringLength(ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000127 const MemRegion *MR,
128 SVal strLength);
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000129 static SVal getCStringLengthForRegion(CheckerContext &C,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000130 ProgramStateRef &state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000131 const Expr *Ex,
132 const MemRegion *MR,
Jordy Rose634c12d2011-06-15 05:52:56 +0000133 bool hypothetical);
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000134 SVal getCStringLength(CheckerContext &C,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000135 ProgramStateRef &state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000136 const Expr *Ex,
137 SVal Buf,
Jordy Rose634c12d2011-06-15 05:52:56 +0000138 bool hypothetical = false) const;
Jordy Roseb052e8f2010-07-27 01:37:31 +0000139
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000140 const StringLiteral *getCStringLiteral(CheckerContext &C,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000141 ProgramStateRef &state,
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000142 const Expr *expr,
143 SVal val) const;
144
Ted Kremenek49b1e382012-01-26 21:29:00 +0000145 static ProgramStateRef InvalidateBuffer(CheckerContext &C,
Anton Yartsev968c60a2013-11-17 09:18:48 +0000146 ProgramStateRef state,
147 const Expr *Ex, SVal V,
148 bool IsSourceBuffer);
Jordy Rose722f5582010-08-16 07:51:42 +0000149
Ted Kremenek5ef32db2011-08-12 23:37:29 +0000150 static bool SummarizeRegion(raw_ostream &os, ASTContext &Ctx,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000151 const MemRegion *MR);
Jordy Roseb052e8f2010-07-27 01:37:31 +0000152
153 // Re-usable checks
Ted Kremenek49b1e382012-01-26 21:29:00 +0000154 ProgramStateRef checkNonNull(CheckerContext &C,
155 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000156 const Expr *S,
157 SVal l) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000158 ProgramStateRef CheckLocation(CheckerContext &C,
159 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000160 const Expr *S,
161 SVal l,
Craig Topper0dbb7832014-05-27 02:45:47 +0000162 const char *message = nullptr) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000163 ProgramStateRef CheckBufferAccess(CheckerContext &C,
164 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000165 const Expr *Size,
166 const Expr *FirstBuf,
167 const Expr *SecondBuf,
Craig Topper0dbb7832014-05-27 02:45:47 +0000168 const char *firstMessage = nullptr,
169 const char *secondMessage = nullptr,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000170 bool WarnAboutSize = false) const;
171
Ted Kremenek49b1e382012-01-26 21:29:00 +0000172 ProgramStateRef CheckBufferAccess(CheckerContext &C,
173 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000174 const Expr *Size,
175 const Expr *Buf,
Craig Topper0dbb7832014-05-27 02:45:47 +0000176 const char *message = nullptr,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000177 bool WarnAboutSize = false) const {
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000178 // This is a convenience override.
Craig Topper0dbb7832014-05-27 02:45:47 +0000179 return CheckBufferAccess(C, state, Size, Buf, nullptr, message, nullptr,
Jordy Rose328deee2011-06-20 03:49:16 +0000180 WarnAboutSize);
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000181 }
Ted Kremenek49b1e382012-01-26 21:29:00 +0000182 ProgramStateRef CheckOverlap(CheckerContext &C,
183 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000184 const Expr *Size,
185 const Expr *First,
186 const Expr *Second) const;
187 void emitOverlapBug(CheckerContext &C,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000188 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000189 const Stmt *First,
190 const Stmt *Second) const;
191
Ted Kremenek49b1e382012-01-26 21:29:00 +0000192 ProgramStateRef checkAdditionOverflow(CheckerContext &C,
193 ProgramStateRef state,
Ted Kremenek001fd5b2011-08-15 22:09:50 +0000194 NonLoc left,
195 NonLoc right) const;
Jordy Rose134a2362010-07-06 23:11:01 +0000196};
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000197
Jordy Rose134a2362010-07-06 23:11:01 +0000198} //end anonymous namespace
199
Jordan Rose0c153cb2012-11-02 01:54:06 +0000200REGISTER_MAP_WITH_PROGRAMSTATE(CStringLength, const MemRegion *, SVal)
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000201
Jordy Rosed5d2e502010-07-08 23:57:29 +0000202//===----------------------------------------------------------------------===//
203// Individual checks and utility methods.
204//===----------------------------------------------------------------------===//
205
Ted Kremenek49b1e382012-01-26 21:29:00 +0000206std::pair<ProgramStateRef , ProgramStateRef >
207CStringChecker::assumeZero(CheckerContext &C, ProgramStateRef state, SVal V,
Jordy Rosed5d2e502010-07-08 23:57:29 +0000208 QualType Ty) {
David Blaikie05785d12013-02-20 22:23:23 +0000209 Optional<DefinedSVal> val = V.getAs<DefinedSVal>();
Ted Kremenek90af9092010-12-02 07:49:45 +0000210 if (!val)
Ted Kremenek49b1e382012-01-26 21:29:00 +0000211 return std::pair<ProgramStateRef , ProgramStateRef >(state, state);
Jordy Rose33c829a2010-07-07 07:48:06 +0000212
Ted Kremenek90af9092010-12-02 07:49:45 +0000213 SValBuilder &svalBuilder = C.getSValBuilder();
214 DefinedOrUnknownSVal zero = svalBuilder.makeZeroVal(Ty);
215 return state->assume(svalBuilder.evalEQ(state, *val, zero));
Jordy Rosed5d2e502010-07-08 23:57:29 +0000216}
Jordy Rose33c829a2010-07-07 07:48:06 +0000217
Ted Kremenek49b1e382012-01-26 21:29:00 +0000218ProgramStateRef CStringChecker::checkNonNull(CheckerContext &C,
219 ProgramStateRef state,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000220 const Expr *S, SVal l) const {
Jordy Rosed5d2e502010-07-08 23:57:29 +0000221 // If a previous check has failed, propagate the failure.
222 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000223 return nullptr;
Jordy Rosed5d2e502010-07-08 23:57:29 +0000224
Ted Kremenek49b1e382012-01-26 21:29:00 +0000225 ProgramStateRef stateNull, stateNonNull;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +0000226 std::tie(stateNull, stateNonNull) = assumeZero(C, state, l, S->getType());
Jordy Rosed5d2e502010-07-08 23:57:29 +0000227
228 if (stateNull && !stateNonNull) {
Anna Zakse0c7c272012-02-07 00:56:14 +0000229 if (!Filter.CheckCStringNullArg)
Craig Topper0dbb7832014-05-27 02:45:47 +0000230 return nullptr;
Anna Zakse0c7c272012-02-07 00:56:14 +0000231
Ted Kremenek750b7ac2010-12-20 21:19:09 +0000232 ExplodedNode *N = C.generateSink(stateNull);
Jordy Rose33c829a2010-07-07 07:48:06 +0000233 if (!N)
Craig Topper0dbb7832014-05-27 02:45:47 +0000234 return nullptr;
Jordy Rose33c829a2010-07-07 07:48:06 +0000235
Jordy Rosed5d2e502010-07-08 23:57:29 +0000236 if (!BT_Null)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000237 BT_Null.reset(new BuiltinBug(
238 Filter.CheckNameCStringNullArg, categories::UnixAPI,
239 "Null pointer argument in call to byte string function"));
Jordy Rose33c829a2010-07-07 07:48:06 +0000240
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +0000241 SmallString<80> buf;
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000242 llvm::raw_svector_ostream os(buf);
243 assert(CurrentFunctionDescription);
244 os << "Null pointer argument in call to " << CurrentFunctionDescription;
245
Jordy Rose33c829a2010-07-07 07:48:06 +0000246 // Generate a report for this bug.
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000247 BuiltinBug *BT = static_cast<BuiltinBug*>(BT_Null.get());
Anna Zaks3a6bdf82011-08-17 23:00:25 +0000248 BugReport *report = new BugReport(*BT, os.str(), N);
Jordy Rose33c829a2010-07-07 07:48:06 +0000249
250 report->addRange(S->getSourceRange());
Jordan Rosea0f7d352012-08-28 00:50:51 +0000251 bugreporter::trackNullOrUndefValue(N, S, *report);
Jordan Rosee10d5a72012-11-02 01:53:40 +0000252 C.emitReport(report);
Craig Topper0dbb7832014-05-27 02:45:47 +0000253 return nullptr;
Jordy Rose33c829a2010-07-07 07:48:06 +0000254 }
255
256 // From here on, assume that the value is non-null.
Jordy Rosed5d2e502010-07-08 23:57:29 +0000257 assert(stateNonNull);
258 return stateNonNull;
Jordy Rose33c829a2010-07-07 07:48:06 +0000259}
260
Jordy Rose134a2362010-07-06 23:11:01 +0000261// FIXME: This was originally copied from ArrayBoundChecker.cpp. Refactor?
Ted Kremenek49b1e382012-01-26 21:29:00 +0000262ProgramStateRef CStringChecker::CheckLocation(CheckerContext &C,
263 ProgramStateRef state,
Jordy Rose722f5582010-08-16 07:51:42 +0000264 const Expr *S, SVal l,
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000265 const char *warningMsg) const {
Jordy Rosed5d2e502010-07-08 23:57:29 +0000266 // If a previous check has failed, propagate the failure.
267 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000268 return nullptr;
Jordy Rosed5d2e502010-07-08 23:57:29 +0000269
Jordy Rose134a2362010-07-06 23:11:01 +0000270 // Check for out of bound array element access.
271 const MemRegion *R = l.getAsRegion();
272 if (!R)
273 return state;
274
Jordy Rose134a2362010-07-06 23:11:01 +0000275 const ElementRegion *ER = dyn_cast<ElementRegion>(R);
276 if (!ER)
277 return state;
278
Zhongxing Xu8de0a3d2010-08-11 06:10:55 +0000279 assert(ER->getValueType() == C.getASTContext().CharTy &&
Jordy Rose134a2362010-07-06 23:11:01 +0000280 "CheckLocation should only be called with char* ElementRegions");
281
282 // Get the size of the array.
Ted Kremenek90af9092010-12-02 07:49:45 +0000283 const SubRegion *superReg = cast<SubRegion>(ER->getSuperRegion());
284 SValBuilder &svalBuilder = C.getSValBuilder();
Jordy Rose455bd582011-06-16 05:51:02 +0000285 SVal Extent =
286 svalBuilder.convertToArrayIndex(superReg->getExtent(svalBuilder));
David Blaikie2fdacbc2013-02-20 05:52:05 +0000287 DefinedOrUnknownSVal Size = Extent.castAs<DefinedOrUnknownSVal>();
Jordy Rose134a2362010-07-06 23:11:01 +0000288
289 // Get the index of the accessed element.
David Blaikie87396b92013-02-21 22:23:56 +0000290 DefinedOrUnknownSVal Idx = ER->getIndex().castAs<DefinedOrUnknownSVal>();
Jordy Rose134a2362010-07-06 23:11:01 +0000291
Ted Kremenek49b1e382012-01-26 21:29:00 +0000292 ProgramStateRef StInBound = state->assumeInBound(Idx, Size, true);
293 ProgramStateRef StOutBound = state->assumeInBound(Idx, Size, false);
Jordy Rose134a2362010-07-06 23:11:01 +0000294 if (StOutBound && !StInBound) {
Ted Kremenek750b7ac2010-12-20 21:19:09 +0000295 ExplodedNode *N = C.generateSink(StOutBound);
Jordy Rose134a2362010-07-06 23:11:01 +0000296 if (!N)
Craig Topper0dbb7832014-05-27 02:45:47 +0000297 return nullptr;
Jordy Rose134a2362010-07-06 23:11:01 +0000298
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000299 if (!BT_Bounds) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000300 BT_Bounds.reset(new BuiltinBug(
301 Filter.CheckNameCStringOutOfBounds, "Out-of-bound array access",
302 "Byte string function accesses out-of-bound array element"));
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000303 }
304 BuiltinBug *BT = static_cast<BuiltinBug*>(BT_Bounds.get());
305
306 // Generate a report for this bug.
Anna Zaks3a6bdf82011-08-17 23:00:25 +0000307 BugReport *report;
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000308 if (warningMsg) {
Anna Zaks3a6bdf82011-08-17 23:00:25 +0000309 report = new BugReport(*BT, warningMsg, N);
Jordy Rose722f5582010-08-16 07:51:42 +0000310 } else {
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000311 assert(CurrentFunctionDescription);
312 assert(CurrentFunctionDescription[0] != '\0');
313
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +0000314 SmallString<80> buf;
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000315 llvm::raw_svector_ostream os(buf);
Jordan Rose4938f272013-02-09 10:09:43 +0000316 os << toUppercase(CurrentFunctionDescription[0])
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000317 << &CurrentFunctionDescription[1]
318 << " accesses out-of-bound array element";
Anna Zaks3a6bdf82011-08-17 23:00:25 +0000319 report = new BugReport(*BT, os.str(), N);
Jordy Rose722f5582010-08-16 07:51:42 +0000320 }
Jordy Rose134a2362010-07-06 23:11:01 +0000321
322 // FIXME: It would be nice to eventually make this diagnostic more clear,
323 // e.g., by referencing the original declaration or by saying *why* this
324 // reference is outside the range.
325
Jordy Rose134a2362010-07-06 23:11:01 +0000326 report->addRange(S->getSourceRange());
Jordan Rosee10d5a72012-11-02 01:53:40 +0000327 C.emitReport(report);
Craig Topper0dbb7832014-05-27 02:45:47 +0000328 return nullptr;
Jordy Rose134a2362010-07-06 23:11:01 +0000329 }
330
331 // Array bound check succeeded. From this point forward the array bound
332 // should always succeed.
333 return StInBound;
334}
335
Ted Kremenek49b1e382012-01-26 21:29:00 +0000336ProgramStateRef CStringChecker::CheckBufferAccess(CheckerContext &C,
337 ProgramStateRef state,
Jordy Rose134a2362010-07-06 23:11:01 +0000338 const Expr *Size,
339 const Expr *FirstBuf,
Jordy Rose722f5582010-08-16 07:51:42 +0000340 const Expr *SecondBuf,
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000341 const char *firstMessage,
Jordy Rose328deee2011-06-20 03:49:16 +0000342 const char *secondMessage,
343 bool WarnAboutSize) const {
Jordy Rosed5d2e502010-07-08 23:57:29 +0000344 // If a previous check has failed, propagate the failure.
345 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000346 return nullptr;
Jordy Rosed5d2e502010-07-08 23:57:29 +0000347
Ted Kremenek90af9092010-12-02 07:49:45 +0000348 SValBuilder &svalBuilder = C.getSValBuilder();
Jordy Rose455bd582011-06-16 05:51:02 +0000349 ASTContext &Ctx = svalBuilder.getContext();
Ted Kremenek632e3b72012-01-06 22:09:28 +0000350 const LocationContext *LCtx = C.getLocationContext();
Jordy Rose134a2362010-07-06 23:11:01 +0000351
Ted Kremenek90af9092010-12-02 07:49:45 +0000352 QualType sizeTy = Size->getType();
Jordy Rose134a2362010-07-06 23:11:01 +0000353 QualType PtrTy = Ctx.getPointerType(Ctx.CharTy);
354
Jordy Rose33c829a2010-07-07 07:48:06 +0000355 // Check that the first buffer is non-null.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000356 SVal BufVal = state->getSVal(FirstBuf, LCtx);
Ted Kremenek90af9092010-12-02 07:49:45 +0000357 state = checkNonNull(C, state, FirstBuf, BufVal);
Jordy Rose33c829a2010-07-07 07:48:06 +0000358 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000359 return nullptr;
Jordy Rose33c829a2010-07-07 07:48:06 +0000360
Anna Zakse0c7c272012-02-07 00:56:14 +0000361 // If out-of-bounds checking is turned off, skip the rest.
362 if (!Filter.CheckCStringOutOfBounds)
363 return state;
364
Jordy Rosed5d2e502010-07-08 23:57:29 +0000365 // Get the access length and make sure it is known.
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000366 // FIXME: This assumes the caller has already checked that the access length
367 // is positive. And that it's unsigned.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000368 SVal LengthVal = state->getSVal(Size, LCtx);
David Blaikie05785d12013-02-20 22:23:23 +0000369 Optional<NonLoc> Length = LengthVal.getAs<NonLoc>();
Jordy Rosed5d2e502010-07-08 23:57:29 +0000370 if (!Length)
371 return state;
372
Jordy Rose134a2362010-07-06 23:11:01 +0000373 // Compute the offset of the last element to be accessed: size-1.
David Blaikie2fdacbc2013-02-20 05:52:05 +0000374 NonLoc One = svalBuilder.makeIntVal(1, sizeTy).castAs<NonLoc>();
375 NonLoc LastOffset = svalBuilder
376 .evalBinOpNN(state, BO_Sub, *Length, One, sizeTy).castAs<NonLoc>();
Jordy Rose134a2362010-07-06 23:11:01 +0000377
Chris Lattner57540c52011-04-15 05:22:18 +0000378 // Check that the first buffer is sufficiently long.
Ted Kremenek90af9092010-12-02 07:49:45 +0000379 SVal BufStart = svalBuilder.evalCast(BufVal, PtrTy, FirstBuf->getType());
David Blaikie05785d12013-02-20 22:23:23 +0000380 if (Optional<Loc> BufLoc = BufStart.getAs<Loc>()) {
Jordy Rose328deee2011-06-20 03:49:16 +0000381 const Expr *warningExpr = (WarnAboutSize ? Size : FirstBuf);
382
Ted Kremenek90af9092010-12-02 07:49:45 +0000383 SVal BufEnd = svalBuilder.evalBinOpLN(state, BO_Add, *BufLoc,
384 LastOffset, PtrTy);
Jordy Rose328deee2011-06-20 03:49:16 +0000385 state = CheckLocation(C, state, warningExpr, BufEnd, firstMessage);
Jordy Rose134a2362010-07-06 23:11:01 +0000386
Jordy Roseafdb0532010-08-05 23:11:30 +0000387 // If the buffer isn't large enough, abort.
388 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000389 return nullptr;
Jordy Roseafdb0532010-08-05 23:11:30 +0000390 }
Jordy Rose134a2362010-07-06 23:11:01 +0000391
392 // If there's a second buffer, check it as well.
393 if (SecondBuf) {
Ted Kremenek632e3b72012-01-06 22:09:28 +0000394 BufVal = state->getSVal(SecondBuf, LCtx);
Ted Kremenek90af9092010-12-02 07:49:45 +0000395 state = checkNonNull(C, state, SecondBuf, BufVal);
Jordy Rose33c829a2010-07-07 07:48:06 +0000396 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000397 return nullptr;
Jordy Rose33c829a2010-07-07 07:48:06 +0000398
Ted Kremenek90af9092010-12-02 07:49:45 +0000399 BufStart = svalBuilder.evalCast(BufVal, PtrTy, SecondBuf->getType());
David Blaikie05785d12013-02-20 22:23:23 +0000400 if (Optional<Loc> BufLoc = BufStart.getAs<Loc>()) {
Jordy Rose328deee2011-06-20 03:49:16 +0000401 const Expr *warningExpr = (WarnAboutSize ? Size : SecondBuf);
402
Ted Kremenek90af9092010-12-02 07:49:45 +0000403 SVal BufEnd = svalBuilder.evalBinOpLN(state, BO_Add, *BufLoc,
404 LastOffset, PtrTy);
Jordy Rose328deee2011-06-20 03:49:16 +0000405 state = CheckLocation(C, state, warningExpr, BufEnd, secondMessage);
Jordy Roseafdb0532010-08-05 23:11:30 +0000406 }
Jordy Rose134a2362010-07-06 23:11:01 +0000407 }
408
409 // Large enough or not, return this state!
410 return state;
411}
412
Ted Kremenek49b1e382012-01-26 21:29:00 +0000413ProgramStateRef CStringChecker::CheckOverlap(CheckerContext &C,
414 ProgramStateRef state,
Jordy Rosed5d2e502010-07-08 23:57:29 +0000415 const Expr *Size,
Jordy Rose134a2362010-07-06 23:11:01 +0000416 const Expr *First,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000417 const Expr *Second) const {
Anna Zakse0c7c272012-02-07 00:56:14 +0000418 if (!Filter.CheckCStringBufferOverlap)
419 return state;
420
Jordy Rose134a2362010-07-06 23:11:01 +0000421 // Do a simple check for overlap: if the two arguments are from the same
422 // buffer, see if the end of the first is greater than the start of the second
423 // or vice versa.
424
Jordy Rosed5d2e502010-07-08 23:57:29 +0000425 // If a previous check has failed, propagate the failure.
426 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000427 return nullptr;
Jordy Rosed5d2e502010-07-08 23:57:29 +0000428
Ted Kremenek49b1e382012-01-26 21:29:00 +0000429 ProgramStateRef stateTrue, stateFalse;
Jordy Rose134a2362010-07-06 23:11:01 +0000430
431 // Get the buffer values and make sure they're known locations.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000432 const LocationContext *LCtx = C.getLocationContext();
433 SVal firstVal = state->getSVal(First, LCtx);
434 SVal secondVal = state->getSVal(Second, LCtx);
Jordy Rose134a2362010-07-06 23:11:01 +0000435
David Blaikie05785d12013-02-20 22:23:23 +0000436 Optional<Loc> firstLoc = firstVal.getAs<Loc>();
Ted Kremenek90af9092010-12-02 07:49:45 +0000437 if (!firstLoc)
Jordy Rose134a2362010-07-06 23:11:01 +0000438 return state;
439
David Blaikie05785d12013-02-20 22:23:23 +0000440 Optional<Loc> secondLoc = secondVal.getAs<Loc>();
Ted Kremenek90af9092010-12-02 07:49:45 +0000441 if (!secondLoc)
Jordy Rose134a2362010-07-06 23:11:01 +0000442 return state;
443
444 // Are the two values the same?
Ted Kremenek90af9092010-12-02 07:49:45 +0000445 SValBuilder &svalBuilder = C.getSValBuilder();
Benjamin Kramer867ea1d2014-03-02 13:01:17 +0000446 std::tie(stateTrue, stateFalse) =
Ted Kremenek90af9092010-12-02 07:49:45 +0000447 state->assume(svalBuilder.evalEQ(state, *firstLoc, *secondLoc));
Jordy Rose134a2362010-07-06 23:11:01 +0000448
449 if (stateTrue && !stateFalse) {
450 // If the values are known to be equal, that's automatically an overlap.
Ted Kremenek90af9092010-12-02 07:49:45 +0000451 emitOverlapBug(C, stateTrue, First, Second);
Craig Topper0dbb7832014-05-27 02:45:47 +0000452 return nullptr;
Jordy Rose134a2362010-07-06 23:11:01 +0000453 }
454
Ted Kremenekc5bea1e2010-12-01 22:16:56 +0000455 // assume the two expressions are not equal.
Jordy Rose134a2362010-07-06 23:11:01 +0000456 assert(stateFalse);
457 state = stateFalse;
458
459 // Which value comes first?
Jordy Rose0585a612011-06-16 05:56:50 +0000460 QualType cmpTy = svalBuilder.getConditionType();
Ted Kremenek90af9092010-12-02 07:49:45 +0000461 SVal reverse = svalBuilder.evalBinOpLL(state, BO_GT,
462 *firstLoc, *secondLoc, cmpTy);
David Blaikie05785d12013-02-20 22:23:23 +0000463 Optional<DefinedOrUnknownSVal> reverseTest =
David Blaikie2fdacbc2013-02-20 05:52:05 +0000464 reverse.getAs<DefinedOrUnknownSVal>();
Ted Kremenek90af9092010-12-02 07:49:45 +0000465 if (!reverseTest)
Jordy Rose134a2362010-07-06 23:11:01 +0000466 return state;
467
Benjamin Kramer867ea1d2014-03-02 13:01:17 +0000468 std::tie(stateTrue, stateFalse) = state->assume(*reverseTest);
Jordy Rose134a2362010-07-06 23:11:01 +0000469 if (stateTrue) {
470 if (stateFalse) {
471 // If we don't know which one comes first, we can't perform this test.
472 return state;
473 } else {
Ted Kremenek90af9092010-12-02 07:49:45 +0000474 // Switch the values so that firstVal is before secondVal.
David Blaikie2fdacbc2013-02-20 05:52:05 +0000475 std::swap(firstLoc, secondLoc);
Jordy Rose134a2362010-07-06 23:11:01 +0000476
477 // Switch the Exprs as well, so that they still correspond.
David Blaikie2fdacbc2013-02-20 05:52:05 +0000478 std::swap(First, Second);
Jordy Rose134a2362010-07-06 23:11:01 +0000479 }
480 }
481
482 // Get the length, and make sure it too is known.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000483 SVal LengthVal = state->getSVal(Size, LCtx);
David Blaikie05785d12013-02-20 22:23:23 +0000484 Optional<NonLoc> Length = LengthVal.getAs<NonLoc>();
Jordy Rose134a2362010-07-06 23:11:01 +0000485 if (!Length)
486 return state;
487
488 // Convert the first buffer's start address to char*.
489 // Bail out if the cast fails.
Jordy Rose0585a612011-06-16 05:56:50 +0000490 ASTContext &Ctx = svalBuilder.getContext();
Jordy Rose134a2362010-07-06 23:11:01 +0000491 QualType CharPtrTy = Ctx.getPointerType(Ctx.CharTy);
Jordy Rose455bd582011-06-16 05:51:02 +0000492 SVal FirstStart = svalBuilder.evalCast(*firstLoc, CharPtrTy,
493 First->getType());
David Blaikie05785d12013-02-20 22:23:23 +0000494 Optional<Loc> FirstStartLoc = FirstStart.getAs<Loc>();
Jordy Rose134a2362010-07-06 23:11:01 +0000495 if (!FirstStartLoc)
496 return state;
497
498 // Compute the end of the first buffer. Bail out if THAT fails.
Ted Kremenek90af9092010-12-02 07:49:45 +0000499 SVal FirstEnd = svalBuilder.evalBinOpLN(state, BO_Add,
Jordy Rose134a2362010-07-06 23:11:01 +0000500 *FirstStartLoc, *Length, CharPtrTy);
David Blaikie05785d12013-02-20 22:23:23 +0000501 Optional<Loc> FirstEndLoc = FirstEnd.getAs<Loc>();
Jordy Rose134a2362010-07-06 23:11:01 +0000502 if (!FirstEndLoc)
503 return state;
504
505 // Is the end of the first buffer past the start of the second buffer?
Ted Kremenek90af9092010-12-02 07:49:45 +0000506 SVal Overlap = svalBuilder.evalBinOpLL(state, BO_GT,
507 *FirstEndLoc, *secondLoc, cmpTy);
David Blaikie05785d12013-02-20 22:23:23 +0000508 Optional<DefinedOrUnknownSVal> OverlapTest =
David Blaikie2fdacbc2013-02-20 05:52:05 +0000509 Overlap.getAs<DefinedOrUnknownSVal>();
Jordy Rose134a2362010-07-06 23:11:01 +0000510 if (!OverlapTest)
511 return state;
512
Benjamin Kramer867ea1d2014-03-02 13:01:17 +0000513 std::tie(stateTrue, stateFalse) = state->assume(*OverlapTest);
Jordy Rose134a2362010-07-06 23:11:01 +0000514
515 if (stateTrue && !stateFalse) {
516 // Overlap!
Ted Kremenek90af9092010-12-02 07:49:45 +0000517 emitOverlapBug(C, stateTrue, First, Second);
Craig Topper0dbb7832014-05-27 02:45:47 +0000518 return nullptr;
Jordy Rose134a2362010-07-06 23:11:01 +0000519 }
520
Ted Kremenekc5bea1e2010-12-01 22:16:56 +0000521 // assume the two expressions don't overlap.
Jordy Rose134a2362010-07-06 23:11:01 +0000522 assert(stateFalse);
523 return stateFalse;
524}
525
Ted Kremenek49b1e382012-01-26 21:29:00 +0000526void CStringChecker::emitOverlapBug(CheckerContext &C, ProgramStateRef state,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000527 const Stmt *First, const Stmt *Second) const {
Ted Kremenek750b7ac2010-12-20 21:19:09 +0000528 ExplodedNode *N = C.generateSink(state);
Jordy Rose134a2362010-07-06 23:11:01 +0000529 if (!N)
530 return;
531
532 if (!BT_Overlap)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000533 BT_Overlap.reset(new BugType(Filter.CheckNameCStringBufferOverlap,
534 categories::UnixAPI, "Improper arguments"));
Jordy Rose134a2362010-07-06 23:11:01 +0000535
536 // Generate a report for this bug.
Anna Zaks3a6bdf82011-08-17 23:00:25 +0000537 BugReport *report =
538 new BugReport(*BT_Overlap,
Jordy Rose134a2362010-07-06 23:11:01 +0000539 "Arguments must not be overlapping buffers", N);
540 report->addRange(First->getSourceRange());
541 report->addRange(Second->getSourceRange());
542
Jordan Rosee10d5a72012-11-02 01:53:40 +0000543 C.emitReport(report);
Jordy Rose134a2362010-07-06 23:11:01 +0000544}
545
Ted Kremenek49b1e382012-01-26 21:29:00 +0000546ProgramStateRef CStringChecker::checkAdditionOverflow(CheckerContext &C,
547 ProgramStateRef state,
Jordy Rose634c12d2011-06-15 05:52:56 +0000548 NonLoc left,
549 NonLoc right) const {
Anna Zakse0c7c272012-02-07 00:56:14 +0000550 // If out-of-bounds checking is turned off, skip the rest.
551 if (!Filter.CheckCStringOutOfBounds)
552 return state;
553
Jordy Rose634c12d2011-06-15 05:52:56 +0000554 // If a previous check has failed, propagate the failure.
555 if (!state)
Craig Topper0dbb7832014-05-27 02:45:47 +0000556 return nullptr;
Jordy Rose634c12d2011-06-15 05:52:56 +0000557
558 SValBuilder &svalBuilder = C.getSValBuilder();
559 BasicValueFactory &BVF = svalBuilder.getBasicValueFactory();
560
561 QualType sizeTy = svalBuilder.getContext().getSizeType();
562 const llvm::APSInt &maxValInt = BVF.getMaxValue(sizeTy);
563 NonLoc maxVal = svalBuilder.makeIntVal(maxValInt);
564
Anna Zaks7c96b7d2011-12-11 18:43:40 +0000565 SVal maxMinusRight;
David Blaikie2fdacbc2013-02-20 05:52:05 +0000566 if (right.getAs<nonloc::ConcreteInt>()) {
Anna Zaks7c96b7d2011-12-11 18:43:40 +0000567 maxMinusRight = svalBuilder.evalBinOpNN(state, BO_Sub, maxVal, right,
568 sizeTy);
569 } else {
Jordy Rose634c12d2011-06-15 05:52:56 +0000570 // Try switching the operands. (The order of these two assignments is
571 // important!)
572 maxMinusRight = svalBuilder.evalBinOpNN(state, BO_Sub, maxVal, left,
573 sizeTy);
574 left = right;
575 }
576
David Blaikie05785d12013-02-20 22:23:23 +0000577 if (Optional<NonLoc> maxMinusRightNL = maxMinusRight.getAs<NonLoc>()) {
Jordy Rose634c12d2011-06-15 05:52:56 +0000578 QualType cmpTy = svalBuilder.getConditionType();
579 // If left > max - right, we have an overflow.
580 SVal willOverflow = svalBuilder.evalBinOpNN(state, BO_GT, left,
581 *maxMinusRightNL, cmpTy);
582
Ted Kremenek49b1e382012-01-26 21:29:00 +0000583 ProgramStateRef stateOverflow, stateOkay;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +0000584 std::tie(stateOverflow, stateOkay) =
David Blaikie2fdacbc2013-02-20 05:52:05 +0000585 state->assume(willOverflow.castAs<DefinedOrUnknownSVal>());
Jordy Rose634c12d2011-06-15 05:52:56 +0000586
587 if (stateOverflow && !stateOkay) {
588 // We have an overflow. Emit a bug report.
589 ExplodedNode *N = C.generateSink(stateOverflow);
590 if (!N)
Craig Topper0dbb7832014-05-27 02:45:47 +0000591 return nullptr;
Jordy Rose634c12d2011-06-15 05:52:56 +0000592
593 if (!BT_AdditionOverflow)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000594 BT_AdditionOverflow.reset(
595 new BuiltinBug(Filter.CheckNameCStringOutOfBounds, "API",
596 "Sum of expressions causes overflow"));
Jordy Rose634c12d2011-06-15 05:52:56 +0000597
Jordy Rose634c12d2011-06-15 05:52:56 +0000598 // This isn't a great error message, but this should never occur in real
599 // code anyway -- you'd have to create a buffer longer than a size_t can
600 // represent, which is sort of a contradiction.
Jordy Rose789adbb2011-06-20 03:51:53 +0000601 const char *warning =
602 "This expression will create a string whose length is too big to "
603 "be represented as a size_t";
Jordy Rose634c12d2011-06-15 05:52:56 +0000604
605 // Generate a report for this bug.
Jordy Rose789adbb2011-06-20 03:51:53 +0000606 BugReport *report = new BugReport(*BT_AdditionOverflow, warning, N);
Jordan Rosee10d5a72012-11-02 01:53:40 +0000607 C.emitReport(report);
Jordy Rose634c12d2011-06-15 05:52:56 +0000608
Craig Topper0dbb7832014-05-27 02:45:47 +0000609 return nullptr;
Jordy Rose634c12d2011-06-15 05:52:56 +0000610 }
611
612 // From now on, assume an overflow didn't occur.
613 assert(stateOkay);
614 state = stateOkay;
615 }
616
617 return state;
618}
619
Ted Kremenek49b1e382012-01-26 21:29:00 +0000620ProgramStateRef CStringChecker::setCStringLength(ProgramStateRef state,
Jordy Rose722f5582010-08-16 07:51:42 +0000621 const MemRegion *MR,
Ted Kremenek90af9092010-12-02 07:49:45 +0000622 SVal strLength) {
623 assert(!strLength.isUndef() && "Attempt to set an undefined string length");
Jordy Rose722f5582010-08-16 07:51:42 +0000624
625 MR = MR->StripCasts();
626
627 switch (MR->getKind()) {
628 case MemRegion::StringRegionKind:
629 // FIXME: This can happen if we strcpy() into a string region. This is
630 // undefined [C99 6.4.5p6], but we should still warn about it.
631 return state;
632
633 case MemRegion::SymbolicRegionKind:
634 case MemRegion::AllocaRegionKind:
635 case MemRegion::VarRegionKind:
636 case MemRegion::FieldRegionKind:
637 case MemRegion::ObjCIvarRegionKind:
Jordy Rose0e9fb282011-06-15 05:14:03 +0000638 // These are the types we can currently track string lengths for.
639 break;
Jordy Rose722f5582010-08-16 07:51:42 +0000640
641 case MemRegion::ElementRegionKind:
642 // FIXME: Handle element regions by upper-bounding the parent region's
643 // string length.
644 return state;
645
646 default:
647 // Other regions (mostly non-data) can't have a reliable C string length.
648 // For now, just ignore the change.
649 // FIXME: These are rare but not impossible. We should output some kind of
650 // warning for things like strcpy((char[]){'a', 0}, "b");
651 return state;
652 }
Jordy Rose0e9fb282011-06-15 05:14:03 +0000653
654 if (strLength.isUnknown())
655 return state->remove<CStringLength>(MR);
656
657 return state->set<CStringLength>(MR, strLength);
Jordy Rose722f5582010-08-16 07:51:42 +0000658}
659
Ted Kremenek90af9092010-12-02 07:49:45 +0000660SVal CStringChecker::getCStringLengthForRegion(CheckerContext &C,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000661 ProgramStateRef &state,
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000662 const Expr *Ex,
Jordy Rose634c12d2011-06-15 05:52:56 +0000663 const MemRegion *MR,
664 bool hypothetical) {
665 if (!hypothetical) {
666 // If there's a recorded length, go ahead and return it.
667 const SVal *Recorded = state->get<CStringLength>(MR);
668 if (Recorded)
669 return *Recorded;
670 }
Jordan Rose60619a62013-08-19 16:27:34 +0000671
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000672 // Otherwise, get a new symbol and update the state.
Ted Kremenek90af9092010-12-02 07:49:45 +0000673 SValBuilder &svalBuilder = C.getSValBuilder();
674 QualType sizeTy = svalBuilder.getContext().getSizeType();
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +0000675 SVal strLength = svalBuilder.getMetadataSymbolVal(CStringChecker::getTag(),
Ted Kremenekd94854a2012-08-22 06:26:15 +0000676 MR, Ex, sizeTy,
677 C.blockCount());
Jordy Rose634c12d2011-06-15 05:52:56 +0000678
Jordan Rose60619a62013-08-19 16:27:34 +0000679 if (!hypothetical) {
680 if (Optional<NonLoc> strLn = strLength.getAs<NonLoc>()) {
681 // In case of unbounded calls strlen etc bound the range to SIZE_MAX/4
682 BasicValueFactory &BVF = svalBuilder.getBasicValueFactory();
683 const llvm::APSInt &maxValInt = BVF.getMaxValue(sizeTy);
684 llvm::APSInt fourInt = APSIntType(maxValInt).getValue(4);
685 const llvm::APSInt *maxLengthInt = BVF.evalAPSInt(BO_Div, maxValInt,
686 fourInt);
687 NonLoc maxLength = svalBuilder.makeIntVal(*maxLengthInt);
688 SVal evalLength = svalBuilder.evalBinOpNN(state, BO_LE, *strLn,
689 maxLength, sizeTy);
690 state = state->assume(evalLength.castAs<DefinedOrUnknownSVal>(), true);
691 }
Jordy Rose634c12d2011-06-15 05:52:56 +0000692 state = state->set<CStringLength>(MR, strLength);
Jordan Rose60619a62013-08-19 16:27:34 +0000693 }
Jordy Rose634c12d2011-06-15 05:52:56 +0000694
Ted Kremenek90af9092010-12-02 07:49:45 +0000695 return strLength;
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000696}
697
Ted Kremenek49b1e382012-01-26 21:29:00 +0000698SVal CStringChecker::getCStringLength(CheckerContext &C, ProgramStateRef &state,
Jordy Rose634c12d2011-06-15 05:52:56 +0000699 const Expr *Ex, SVal Buf,
700 bool hypothetical) const {
Jordy Roseb052e8f2010-07-27 01:37:31 +0000701 const MemRegion *MR = Buf.getAsRegion();
702 if (!MR) {
703 // If we can't get a region, see if it's something we /know/ isn't a
704 // C string. In the context of locations, the only time we can issue such
705 // a warning is for labels.
David Blaikie05785d12013-02-20 22:23:23 +0000706 if (Optional<loc::GotoLabel> Label = Buf.getAs<loc::GotoLabel>()) {
Anna Zakse0c7c272012-02-07 00:56:14 +0000707 if (!Filter.CheckCStringNotNullTerm)
708 return UndefinedVal();
709
Anna Zaksda4c8d62011-10-26 21:06:34 +0000710 if (ExplodedNode *N = C.addTransition(state)) {
Jordy Roseb052e8f2010-07-27 01:37:31 +0000711 if (!BT_NotCString)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000712 BT_NotCString.reset(new BuiltinBug(
713 Filter.CheckNameCStringNotNullTerm, categories::UnixAPI,
714 "Argument is not a null-terminated string."));
Jordy Roseb052e8f2010-07-27 01:37:31 +0000715
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +0000716 SmallString<120> buf;
Jordy Roseb052e8f2010-07-27 01:37:31 +0000717 llvm::raw_svector_ostream os(buf);
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000718 assert(CurrentFunctionDescription);
719 os << "Argument to " << CurrentFunctionDescription
720 << " is the address of the label '" << Label->getLabel()->getName()
Jordy Roseb052e8f2010-07-27 01:37:31 +0000721 << "', which is not a null-terminated string";
722
723 // Generate a report for this bug.
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000724 BugReport *report = new BugReport(*BT_NotCString, os.str(), N);
Jordy Roseb052e8f2010-07-27 01:37:31 +0000725
726 report->addRange(Ex->getSourceRange());
Jordan Rosee10d5a72012-11-02 01:53:40 +0000727 C.emitReport(report);
Jordy Roseb052e8f2010-07-27 01:37:31 +0000728 }
Jordy Roseb052e8f2010-07-27 01:37:31 +0000729 return UndefinedVal();
Anna Zakse0c7c272012-02-07 00:56:14 +0000730
Jordy Roseb052e8f2010-07-27 01:37:31 +0000731 }
732
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000733 // If it's not a region and not a label, give up.
734 return UnknownVal();
Jordy Roseb052e8f2010-07-27 01:37:31 +0000735 }
736
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000737 // If we have a region, strip casts from it and see if we can figure out
738 // its length. For anything we can't figure out, just return UnknownVal.
739 MR = MR->StripCasts();
740
741 switch (MR->getKind()) {
742 case MemRegion::StringRegionKind: {
743 // Modifying the contents of string regions is undefined [C99 6.4.5p6],
744 // so we can assume that the byte length is the correct C string length.
Ted Kremenek90af9092010-12-02 07:49:45 +0000745 SValBuilder &svalBuilder = C.getSValBuilder();
746 QualType sizeTy = svalBuilder.getContext().getSizeType();
747 const StringLiteral *strLit = cast<StringRegion>(MR)->getStringLiteral();
748 return svalBuilder.makeIntVal(strLit->getByteLength(), sizeTy);
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000749 }
750 case MemRegion::SymbolicRegionKind:
751 case MemRegion::AllocaRegionKind:
752 case MemRegion::VarRegionKind:
753 case MemRegion::FieldRegionKind:
754 case MemRegion::ObjCIvarRegionKind:
Jordy Rose634c12d2011-06-15 05:52:56 +0000755 return getCStringLengthForRegion(C, state, Ex, MR, hypothetical);
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000756 case MemRegion::CompoundLiteralRegionKind:
757 // FIXME: Can we track this? Is it necessary?
758 return UnknownVal();
759 case MemRegion::ElementRegionKind:
760 // FIXME: How can we handle this? It's not good enough to subtract the
761 // offset from the base string length; consider "123\x00567" and &a[5].
762 return UnknownVal();
763 default:
764 // Other regions (mostly non-data) can't have a reliable C string length.
765 // In this case, an error is emitted and UndefinedVal is returned.
766 // The caller should always be prepared to handle this case.
Anna Zakse0c7c272012-02-07 00:56:14 +0000767 if (!Filter.CheckCStringNotNullTerm)
768 return UndefinedVal();
769
Anna Zaksda4c8d62011-10-26 21:06:34 +0000770 if (ExplodedNode *N = C.addTransition(state)) {
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000771 if (!BT_NotCString)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000772 BT_NotCString.reset(new BuiltinBug(
773 Filter.CheckNameCStringNotNullTerm, categories::UnixAPI,
774 "Argument is not a null-terminated string."));
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000775
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +0000776 SmallString<120> buf;
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000777 llvm::raw_svector_ostream os(buf);
778
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000779 assert(CurrentFunctionDescription);
780 os << "Argument to " << CurrentFunctionDescription << " is ";
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000781
782 if (SummarizeRegion(os, C.getASTContext(), MR))
783 os << ", which is not a null-terminated string";
784 else
785 os << "not a null-terminated string";
786
787 // Generate a report for this bug.
Anna Zaks3a6bdf82011-08-17 23:00:25 +0000788 BugReport *report = new BugReport(*BT_NotCString,
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000789 os.str(), N);
790
791 report->addRange(Ex->getSourceRange());
Jordan Rosee10d5a72012-11-02 01:53:40 +0000792 C.emitReport(report);
Jordy Rose2a2e21c2010-08-14 21:02:52 +0000793 }
794
795 return UndefinedVal();
796 }
Jordy Roseb052e8f2010-07-27 01:37:31 +0000797}
798
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000799const StringLiteral *CStringChecker::getCStringLiteral(CheckerContext &C,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000800 ProgramStateRef &state, const Expr *expr, SVal val) const {
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000801
802 // Get the memory region pointed to by the val.
803 const MemRegion *bufRegion = val.getAsRegion();
804 if (!bufRegion)
Craig Topper0dbb7832014-05-27 02:45:47 +0000805 return nullptr;
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000806
807 // Strip casts off the memory region.
808 bufRegion = bufRegion->StripCasts();
809
810 // Cast the memory region to a string region.
811 const StringRegion *strRegion= dyn_cast<StringRegion>(bufRegion);
812 if (!strRegion)
Craig Topper0dbb7832014-05-27 02:45:47 +0000813 return nullptr;
Lenny Maioranif3539ad2011-04-12 17:08:43 +0000814
815 // Return the actual string in the string region.
816 return strRegion->getStringLiteral();
817}
818
Ted Kremenek49b1e382012-01-26 21:29:00 +0000819ProgramStateRef CStringChecker::InvalidateBuffer(CheckerContext &C,
Anton Yartsev968c60a2013-11-17 09:18:48 +0000820 ProgramStateRef state,
821 const Expr *E, SVal V,
822 bool IsSourceBuffer) {
David Blaikie05785d12013-02-20 22:23:23 +0000823 Optional<Loc> L = V.getAs<Loc>();
Jordy Rose722f5582010-08-16 07:51:42 +0000824 if (!L)
825 return state;
826
827 // FIXME: This is a simplified version of what's in CFRefCount.cpp -- it makes
828 // some assumptions about the value that CFRefCount can't. Even so, it should
829 // probably be refactored.
David Blaikie05785d12013-02-20 22:23:23 +0000830 if (Optional<loc::MemRegionVal> MR = L->getAs<loc::MemRegionVal>()) {
Jordy Rose722f5582010-08-16 07:51:42 +0000831 const MemRegion *R = MR->getRegion()->StripCasts();
832
833 // Are we dealing with an ElementRegion? If so, we should be invalidating
834 // the super-region.
835 if (const ElementRegion *ER = dyn_cast<ElementRegion>(R)) {
836 R = ER->getSuperRegion();
837 // FIXME: What about layers of ElementRegions?
838 }
839
840 // Invalidate this region.
Ted Kremenekd519cae2012-02-17 23:13:45 +0000841 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
Anton Yartsev968c60a2013-11-17 09:18:48 +0000842
843 bool CausesPointerEscape = false;
844 RegionAndSymbolInvalidationTraits ITraits;
845 // Invalidate and escape only indirect regions accessible through the source
846 // buffer.
847 if (IsSourceBuffer) {
848 ITraits.setTrait(R,
849 RegionAndSymbolInvalidationTraits::TK_PreserveContents);
850 ITraits.setTrait(R, RegionAndSymbolInvalidationTraits::TK_SuppressEscape);
851 CausesPointerEscape = true;
852 }
853
854 return state->invalidateRegions(R, E, C.blockCount(), LCtx,
Craig Topper0dbb7832014-05-27 02:45:47 +0000855 CausesPointerEscape, nullptr, nullptr,
856 &ITraits);
Jordy Rose722f5582010-08-16 07:51:42 +0000857 }
858
859 // If we have a non-region value by chance, just remove the binding.
860 // FIXME: is this necessary or correct? This handles the non-Region
861 // cases. Is it ever valid to store to these?
Ted Kremenek62698882012-08-22 06:37:46 +0000862 return state->killBinding(*L);
Jordy Rose722f5582010-08-16 07:51:42 +0000863}
864
Ted Kremenek5ef32db2011-08-12 23:37:29 +0000865bool CStringChecker::SummarizeRegion(raw_ostream &os, ASTContext &Ctx,
Jordy Roseb052e8f2010-07-27 01:37:31 +0000866 const MemRegion *MR) {
Ted Kremenek8df44b262011-08-12 20:02:48 +0000867 const TypedValueRegion *TVR = dyn_cast<TypedValueRegion>(MR);
Jordy Roseb052e8f2010-07-27 01:37:31 +0000868
Jordy Roseadd45b72011-08-12 21:41:07 +0000869 switch (MR->getKind()) {
Jordy Roseb052e8f2010-07-27 01:37:31 +0000870 case MemRegion::FunctionTextRegionKind: {
Anna Zaks42782342012-09-17 19:13:56 +0000871 const NamedDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
Jordy Roseb052e8f2010-07-27 01:37:31 +0000872 if (FD)
Benjamin Kramerb89514a2011-10-14 18:45:37 +0000873 os << "the address of the function '" << *FD << '\'';
Jordy Roseb052e8f2010-07-27 01:37:31 +0000874 else
875 os << "the address of a function";
876 return true;
877 }
878 case MemRegion::BlockTextRegionKind:
879 os << "block text";
880 return true;
881 case MemRegion::BlockDataRegionKind:
882 os << "a block";
883 return true;
884 case MemRegion::CXXThisRegionKind:
Zhongxing Xu03207162010-11-26 08:52:48 +0000885 case MemRegion::CXXTempObjectRegionKind:
Ted Kremenek8df44b262011-08-12 20:02:48 +0000886 os << "a C++ temp object of type " << TVR->getValueType().getAsString();
Jordy Roseb052e8f2010-07-27 01:37:31 +0000887 return true;
888 case MemRegion::VarRegionKind:
Ted Kremenek8df44b262011-08-12 20:02:48 +0000889 os << "a variable of type" << TVR->getValueType().getAsString();
Jordy Roseb052e8f2010-07-27 01:37:31 +0000890 return true;
891 case MemRegion::FieldRegionKind:
Ted Kremenek8df44b262011-08-12 20:02:48 +0000892 os << "a field of type " << TVR->getValueType().getAsString();
Jordy Roseb052e8f2010-07-27 01:37:31 +0000893 return true;
894 case MemRegion::ObjCIvarRegionKind:
Ted Kremenek8df44b262011-08-12 20:02:48 +0000895 os << "an instance variable of type " << TVR->getValueType().getAsString();
Jordy Roseb052e8f2010-07-27 01:37:31 +0000896 return true;
897 default:
898 return false;
899 }
900}
901
Jordy Rosed5d2e502010-07-08 23:57:29 +0000902//===----------------------------------------------------------------------===//
Ted Kremenekdc891422010-12-01 21:57:22 +0000903// evaluation of individual function calls.
Jordy Rosed5d2e502010-07-08 23:57:29 +0000904//===----------------------------------------------------------------------===//
905
Lenny Maiorani79d74142011-03-31 21:36:53 +0000906void CStringChecker::evalCopyCommon(CheckerContext &C,
907 const CallExpr *CE,
Ted Kremenek49b1e382012-01-26 21:29:00 +0000908 ProgramStateRef state,
Jordy Rosed5d2e502010-07-08 23:57:29 +0000909 const Expr *Size, const Expr *Dest,
Lenny Maiorani79d74142011-03-31 21:36:53 +0000910 const Expr *Source, bool Restricted,
911 bool IsMempcpy) const {
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000912 CurrentFunctionDescription = "memory copy function";
913
Jordy Rosed5d2e502010-07-08 23:57:29 +0000914 // See if the size argument is zero.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000915 const LocationContext *LCtx = C.getLocationContext();
916 SVal sizeVal = state->getSVal(Size, LCtx);
Ted Kremenek90af9092010-12-02 07:49:45 +0000917 QualType sizeTy = Size->getType();
Jordy Rosed5d2e502010-07-08 23:57:29 +0000918
Ted Kremenek49b1e382012-01-26 21:29:00 +0000919 ProgramStateRef stateZeroSize, stateNonZeroSize;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +0000920 std::tie(stateZeroSize, stateNonZeroSize) =
Jordy Rose455bd582011-06-16 05:51:02 +0000921 assumeZero(C, state, sizeVal, sizeTy);
Jordy Rosed5d2e502010-07-08 23:57:29 +0000922
Lenny Maiorani79d74142011-03-31 21:36:53 +0000923 // Get the value of the Dest.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000924 SVal destVal = state->getSVal(Dest, LCtx);
Lenny Maiorani79d74142011-03-31 21:36:53 +0000925
926 // If the size is zero, there won't be any actual memory access, so
927 // just bind the return value to the destination buffer and return.
Anna Zaksb3b56bb2012-05-03 18:21:28 +0000928 if (stateZeroSize && !stateNonZeroSize) {
Ted Kremenek632e3b72012-01-06 22:09:28 +0000929 stateZeroSize = stateZeroSize->BindExpr(CE, LCtx, destVal);
Anna Zaksda4c8d62011-10-26 21:06:34 +0000930 C.addTransition(stateZeroSize);
Anna Zaksb3b56bb2012-05-03 18:21:28 +0000931 return;
Lenny Maiorani79d74142011-03-31 21:36:53 +0000932 }
Jordy Rosed5d2e502010-07-08 23:57:29 +0000933
934 // If the size can be nonzero, we have to check the other arguments.
Ted Kremenek90af9092010-12-02 07:49:45 +0000935 if (stateNonZeroSize) {
Jordy Rose63b84be2011-06-04 00:04:22 +0000936 state = stateNonZeroSize;
Lenny Maiorani79d74142011-03-31 21:36:53 +0000937
938 // Ensure the destination is not null. If it is NULL there will be a
939 // NULL pointer dereference.
940 state = checkNonNull(C, state, Dest, destVal);
941 if (!state)
942 return;
943
944 // Get the value of the Src.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000945 SVal srcVal = state->getSVal(Source, LCtx);
Lenny Maiorani79d74142011-03-31 21:36:53 +0000946
947 // Ensure the source is not null. If it is NULL there will be a
948 // NULL pointer dereference.
949 state = checkNonNull(C, state, Source, srcVal);
950 if (!state)
951 return;
952
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000953 // Ensure the accesses are valid and that the buffers do not overlap.
Jordy Rosedceb0cf2011-06-20 02:06:40 +0000954 const char * const writeWarning =
955 "Memory copy function overflows destination buffer";
Jordy Rose722f5582010-08-16 07:51:42 +0000956 state = CheckBufferAccess(C, state, Size, Dest, Source,
Craig Topper0dbb7832014-05-27 02:45:47 +0000957 writeWarning, /* sourceWarning = */ nullptr);
Jordy Rosed5d2e502010-07-08 23:57:29 +0000958 if (Restricted)
959 state = CheckOverlap(C, state, Size, Dest, Source);
Jordy Rose722f5582010-08-16 07:51:42 +0000960
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000961 if (!state)
962 return;
Lenny Maiorani79d74142011-03-31 21:36:53 +0000963
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000964 // If this is mempcpy, get the byte after the last byte copied and
965 // bind the expr.
966 if (IsMempcpy) {
David Blaikie2fdacbc2013-02-20 05:52:05 +0000967 loc::MemRegionVal destRegVal = destVal.castAs<loc::MemRegionVal>();
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000968
969 // Get the length to copy.
David Blaikie05785d12013-02-20 22:23:23 +0000970 if (Optional<NonLoc> lenValNonLoc = sizeVal.getAs<NonLoc>()) {
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000971 // Get the byte after the last byte copied.
972 SVal lastElement = C.getSValBuilder().evalBinOpLN(state, BO_Add,
David Blaikie2fdacbc2013-02-20 05:52:05 +0000973 destRegVal,
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000974 *lenValNonLoc,
975 Dest->getType());
976
977 // The byte after the last byte copied is the return value.
Ted Kremenek632e3b72012-01-06 22:09:28 +0000978 state = state->BindExpr(CE, LCtx, lastElement);
Jordy Rose097c5392011-06-04 01:47:27 +0000979 } else {
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000980 // If we don't know how much we copied, we can at least
981 // conjure a return value for later.
Craig Topper0dbb7832014-05-27 02:45:47 +0000982 SVal result = C.getSValBuilder().conjureSymbolVal(nullptr, CE, LCtx,
Ted Kremenekd94854a2012-08-22 06:26:15 +0000983 C.blockCount());
Ted Kremenek632e3b72012-01-06 22:09:28 +0000984 state = state->BindExpr(CE, LCtx, result);
Lenny Maiorani79d74142011-03-31 21:36:53 +0000985 }
986
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000987 } else {
988 // All other copies return the destination buffer.
989 // (Well, bcopy() has a void return type, but this won't hurt.)
Ted Kremenek632e3b72012-01-06 22:09:28 +0000990 state = state->BindExpr(CE, LCtx, destVal);
Jordy Rose722f5582010-08-16 07:51:42 +0000991 }
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000992
Anton Yartsev968c60a2013-11-17 09:18:48 +0000993 // Invalidate the destination (regular invalidation without pointer-escaping
994 // the address of the top-level region).
Jordy Rosefb5e8c22011-06-04 01:50:25 +0000995 // FIXME: Even if we can't perfectly model the copy, we should see if we
996 // can use LazyCompoundVals to copy the source values into the destination.
997 // This would probably remove any existing bindings past the end of the
998 // copied region, but that's still an improvement over blank invalidation.
Anton Yartsev968c60a2013-11-17 09:18:48 +0000999 state = InvalidateBuffer(C, state, Dest, C.getSVal(Dest),
1000 /*IsSourceBuffer*/false);
1001
1002 // Invalidate the source (const-invalidation without const-pointer-escaping
1003 // the address of the top-level region).
1004 state = InvalidateBuffer(C, state, Source, C.getSVal(Source),
1005 /*IsSourceBuffer*/true);
1006
Anna Zaksda4c8d62011-10-26 21:06:34 +00001007 C.addTransition(state);
Jordy Rosed5d2e502010-07-08 23:57:29 +00001008 }
1009}
1010
1011
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001012void CStringChecker::evalMemcpy(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001013 if (CE->getNumArgs() < 3)
1014 return;
1015
Jordy Rose134a2362010-07-06 23:11:01 +00001016 // void *memcpy(void *restrict dst, const void *restrict src, size_t n);
Jordy Rose134a2362010-07-06 23:11:01 +00001017 // The return value is the address of the destination buffer.
Jordy Rosed5d2e502010-07-08 23:57:29 +00001018 const Expr *Dest = CE->getArg(0);
Ted Kremenek49b1e382012-01-26 21:29:00 +00001019 ProgramStateRef state = C.getState();
Jordy Rose097c5392011-06-04 01:47:27 +00001020
Lenny Maiorani79d74142011-03-31 21:36:53 +00001021 evalCopyCommon(C, CE, state, CE->getArg(2), Dest, CE->getArg(1), true);
1022}
1023
1024void CStringChecker::evalMempcpy(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001025 if (CE->getNumArgs() < 3)
1026 return;
1027
Lenny Maiorani79d74142011-03-31 21:36:53 +00001028 // void *mempcpy(void *restrict dst, const void *restrict src, size_t n);
1029 // The return value is a pointer to the byte following the last written byte.
1030 const Expr *Dest = CE->getArg(0);
Ted Kremenek49b1e382012-01-26 21:29:00 +00001031 ProgramStateRef state = C.getState();
Lenny Maiorani79d74142011-03-31 21:36:53 +00001032
1033 evalCopyCommon(C, CE, state, CE->getArg(2), Dest, CE->getArg(1), true, true);
Jordy Rose134a2362010-07-06 23:11:01 +00001034}
1035
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001036void CStringChecker::evalMemmove(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001037 if (CE->getNumArgs() < 3)
1038 return;
1039
Jordy Rosed5d2e502010-07-08 23:57:29 +00001040 // void *memmove(void *dst, const void *src, size_t n);
1041 // The return value is the address of the destination buffer.
1042 const Expr *Dest = CE->getArg(0);
Ted Kremenek49b1e382012-01-26 21:29:00 +00001043 ProgramStateRef state = C.getState();
Jordy Rose097c5392011-06-04 01:47:27 +00001044
Lenny Maiorani79d74142011-03-31 21:36:53 +00001045 evalCopyCommon(C, CE, state, CE->getArg(2), Dest, CE->getArg(1));
Jordy Rosed5d2e502010-07-08 23:57:29 +00001046}
1047
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001048void CStringChecker::evalBcopy(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001049 if (CE->getNumArgs() < 3)
1050 return;
1051
Jordy Rosed5d2e502010-07-08 23:57:29 +00001052 // void bcopy(const void *src, void *dst, size_t n);
Lenny Maiorani79d74142011-03-31 21:36:53 +00001053 evalCopyCommon(C, CE, C.getState(),
1054 CE->getArg(2), CE->getArg(1), CE->getArg(0));
Jordy Rosed5d2e502010-07-08 23:57:29 +00001055}
1056
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001057void CStringChecker::evalMemcmp(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001058 if (CE->getNumArgs() < 3)
1059 return;
1060
Jordy Rose65136fb2010-07-07 08:15:01 +00001061 // int memcmp(const void *s1, const void *s2, size_t n);
Jordy Rosedceb0cf2011-06-20 02:06:40 +00001062 CurrentFunctionDescription = "memory comparison function";
1063
Jordy Rose65136fb2010-07-07 08:15:01 +00001064 const Expr *Left = CE->getArg(0);
1065 const Expr *Right = CE->getArg(1);
1066 const Expr *Size = CE->getArg(2);
1067
Ted Kremenek49b1e382012-01-26 21:29:00 +00001068 ProgramStateRef state = C.getState();
Ted Kremenek90af9092010-12-02 07:49:45 +00001069 SValBuilder &svalBuilder = C.getSValBuilder();
Jordy Rose65136fb2010-07-07 08:15:01 +00001070
Jordy Rosed5d2e502010-07-08 23:57:29 +00001071 // See if the size argument is zero.
Ted Kremenek632e3b72012-01-06 22:09:28 +00001072 const LocationContext *LCtx = C.getLocationContext();
1073 SVal sizeVal = state->getSVal(Size, LCtx);
Ted Kremenek90af9092010-12-02 07:49:45 +00001074 QualType sizeTy = Size->getType();
Jordy Rose65136fb2010-07-07 08:15:01 +00001075
Ted Kremenek49b1e382012-01-26 21:29:00 +00001076 ProgramStateRef stateZeroSize, stateNonZeroSize;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001077 std::tie(stateZeroSize, stateNonZeroSize) =
Ted Kremenek90af9092010-12-02 07:49:45 +00001078 assumeZero(C, state, sizeVal, sizeTy);
Jordy Rose65136fb2010-07-07 08:15:01 +00001079
Jordy Rosed5d2e502010-07-08 23:57:29 +00001080 // If the size can be zero, the result will be 0 in that case, and we don't
1081 // have to check either of the buffers.
Ted Kremenek90af9092010-12-02 07:49:45 +00001082 if (stateZeroSize) {
1083 state = stateZeroSize;
Ted Kremenek632e3b72012-01-06 22:09:28 +00001084 state = state->BindExpr(CE, LCtx,
1085 svalBuilder.makeZeroVal(CE->getType()));
Anna Zaksda4c8d62011-10-26 21:06:34 +00001086 C.addTransition(state);
Jordy Rose65136fb2010-07-07 08:15:01 +00001087 }
1088
Jordy Rosed5d2e502010-07-08 23:57:29 +00001089 // If the size can be nonzero, we have to check the other arguments.
Ted Kremenek90af9092010-12-02 07:49:45 +00001090 if (stateNonZeroSize) {
1091 state = stateNonZeroSize;
Jordy Rosed5d2e502010-07-08 23:57:29 +00001092 // If we know the two buffers are the same, we know the result is 0.
1093 // First, get the two buffers' addresses. Another checker will have already
1094 // made sure they're not undefined.
Ted Kremenek632e3b72012-01-06 22:09:28 +00001095 DefinedOrUnknownSVal LV =
David Blaikie2fdacbc2013-02-20 05:52:05 +00001096 state->getSVal(Left, LCtx).castAs<DefinedOrUnknownSVal>();
Ted Kremenek632e3b72012-01-06 22:09:28 +00001097 DefinedOrUnknownSVal RV =
David Blaikie2fdacbc2013-02-20 05:52:05 +00001098 state->getSVal(Right, LCtx).castAs<DefinedOrUnknownSVal>();
Jordy Rose65136fb2010-07-07 08:15:01 +00001099
Jordy Rosed5d2e502010-07-08 23:57:29 +00001100 // See if they are the same.
Ted Kremenek90af9092010-12-02 07:49:45 +00001101 DefinedOrUnknownSVal SameBuf = svalBuilder.evalEQ(state, LV, RV);
Ted Kremenek49b1e382012-01-26 21:29:00 +00001102 ProgramStateRef StSameBuf, StNotSameBuf;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001103 std::tie(StSameBuf, StNotSameBuf) = state->assume(SameBuf);
Jordy Rosed5d2e502010-07-08 23:57:29 +00001104
Jordy Rose455bd582011-06-16 05:51:02 +00001105 // If the two arguments might be the same buffer, we know the result is 0,
Jordy Rosed5d2e502010-07-08 23:57:29 +00001106 // and we only need to check one size.
1107 if (StSameBuf) {
1108 state = StSameBuf;
1109 state = CheckBufferAccess(C, state, Size, Left);
1110 if (state) {
Ted Kremenek632e3b72012-01-06 22:09:28 +00001111 state = StSameBuf->BindExpr(CE, LCtx,
1112 svalBuilder.makeZeroVal(CE->getType()));
Anna Zaksda4c8d62011-10-26 21:06:34 +00001113 C.addTransition(state);
Jordy Rosed5d2e502010-07-08 23:57:29 +00001114 }
1115 }
1116
1117 // If the two arguments might be different buffers, we have to check the
1118 // size of both of them.
1119 if (StNotSameBuf) {
1120 state = StNotSameBuf;
1121 state = CheckBufferAccess(C, state, Size, Left, Right);
1122 if (state) {
1123 // The return value is the comparison result, which we don't know.
Craig Topper0dbb7832014-05-27 02:45:47 +00001124 SVal CmpV = svalBuilder.conjureSymbolVal(nullptr, CE, LCtx,
1125 C.blockCount());
Ted Kremenek632e3b72012-01-06 22:09:28 +00001126 state = state->BindExpr(CE, LCtx, CmpV);
Anna Zaksda4c8d62011-10-26 21:06:34 +00001127 C.addTransition(state);
Jordy Rosed5d2e502010-07-08 23:57:29 +00001128 }
1129 }
1130 }
Jordy Rose65136fb2010-07-07 08:15:01 +00001131}
1132
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001133void CStringChecker::evalstrLength(CheckerContext &C,
1134 const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001135 if (CE->getNumArgs() < 1)
1136 return;
1137
Jordy Roseb052e8f2010-07-27 01:37:31 +00001138 // size_t strlen(const char *s);
Ted Kremenek280a01f2011-02-22 04:55:05 +00001139 evalstrLengthCommon(C, CE, /* IsStrnlen = */ false);
1140}
1141
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001142void CStringChecker::evalstrnLength(CheckerContext &C,
1143 const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001144 if (CE->getNumArgs() < 2)
1145 return;
1146
Ted Kremenek280a01f2011-02-22 04:55:05 +00001147 // size_t strnlen(const char *s, size_t maxlen);
1148 evalstrLengthCommon(C, CE, /* IsStrnlen = */ true);
1149}
1150
1151void CStringChecker::evalstrLengthCommon(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001152 bool IsStrnlen) const {
Jordy Rosedceb0cf2011-06-20 02:06:40 +00001153 CurrentFunctionDescription = "string length function";
Ted Kremenek49b1e382012-01-26 21:29:00 +00001154 ProgramStateRef state = C.getState();
Ted Kremenek632e3b72012-01-06 22:09:28 +00001155 const LocationContext *LCtx = C.getLocationContext();
Jordy Rosed3592892011-06-14 01:15:31 +00001156
1157 if (IsStrnlen) {
1158 const Expr *maxlenExpr = CE->getArg(1);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001159 SVal maxlenVal = state->getSVal(maxlenExpr, LCtx);
Jordy Rosed3592892011-06-14 01:15:31 +00001160
Ted Kremenek49b1e382012-01-26 21:29:00 +00001161 ProgramStateRef stateZeroSize, stateNonZeroSize;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001162 std::tie(stateZeroSize, stateNonZeroSize) =
Jordy Rosed3592892011-06-14 01:15:31 +00001163 assumeZero(C, state, maxlenVal, maxlenExpr->getType());
1164
1165 // If the size can be zero, the result will be 0 in that case, and we don't
1166 // have to check the string itself.
1167 if (stateZeroSize) {
1168 SVal zero = C.getSValBuilder().makeZeroVal(CE->getType());
Ted Kremenek632e3b72012-01-06 22:09:28 +00001169 stateZeroSize = stateZeroSize->BindExpr(CE, LCtx, zero);
Anna Zaksda4c8d62011-10-26 21:06:34 +00001170 C.addTransition(stateZeroSize);
Jordy Rosed3592892011-06-14 01:15:31 +00001171 }
1172
1173 // If the size is GUARANTEED to be zero, we're done!
1174 if (!stateNonZeroSize)
1175 return;
1176
1177 // Otherwise, record the assumption that the size is nonzero.
1178 state = stateNonZeroSize;
1179 }
1180
1181 // Check that the string argument is non-null.
Jordy Roseb052e8f2010-07-27 01:37:31 +00001182 const Expr *Arg = CE->getArg(0);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001183 SVal ArgVal = state->getSVal(Arg, LCtx);
Jordy Roseb052e8f2010-07-27 01:37:31 +00001184
Ted Kremenek90af9092010-12-02 07:49:45 +00001185 state = checkNonNull(C, state, Arg, ArgVal);
Jordy Roseb052e8f2010-07-27 01:37:31 +00001186
Jordy Rose45d8c122011-06-14 01:26:48 +00001187 if (!state)
1188 return;
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001189
Jordy Rose45d8c122011-06-14 01:26:48 +00001190 SVal strLength = getCStringLength(C, state, Arg, ArgVal);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001191
Jordy Rose45d8c122011-06-14 01:26:48 +00001192 // If the argument isn't a valid C string, there's no valid state to
1193 // transition to.
1194 if (strLength.isUndef())
1195 return;
Jordy Rosed3592892011-06-14 01:15:31 +00001196
Jordy Rose45d8c122011-06-14 01:26:48 +00001197 DefinedOrUnknownSVal result = UnknownVal();
Jordy Rosed3592892011-06-14 01:15:31 +00001198
Jordy Rose45d8c122011-06-14 01:26:48 +00001199 // If the check is for strnlen() then bind the return value to no more than
1200 // the maxlen value.
1201 if (IsStrnlen) {
Jordy Rose0585a612011-06-16 05:56:50 +00001202 QualType cmpTy = C.getSValBuilder().getConditionType();
Jordy Rosed3592892011-06-14 01:15:31 +00001203
Jordy Rose45d8c122011-06-14 01:26:48 +00001204 // It's a little unfortunate to be getting this again,
1205 // but it's not that expensive...
1206 const Expr *maxlenExpr = CE->getArg(1);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001207 SVal maxlenVal = state->getSVal(maxlenExpr, LCtx);
Ted Kremenek280a01f2011-02-22 04:55:05 +00001208
David Blaikie05785d12013-02-20 22:23:23 +00001209 Optional<NonLoc> strLengthNL = strLength.getAs<NonLoc>();
1210 Optional<NonLoc> maxlenValNL = maxlenVal.getAs<NonLoc>();
Ted Kremenek280a01f2011-02-22 04:55:05 +00001211
Jordy Rose45d8c122011-06-14 01:26:48 +00001212 if (strLengthNL && maxlenValNL) {
Ted Kremenek49b1e382012-01-26 21:29:00 +00001213 ProgramStateRef stateStringTooLong, stateStringNotTooLong;
Jordy Rosed3592892011-06-14 01:15:31 +00001214
Jordy Rose45d8c122011-06-14 01:26:48 +00001215 // Check if the strLength is greater than the maxlen.
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001216 std::tie(stateStringTooLong, stateStringNotTooLong) = state->assume(
1217 C.getSValBuilder()
1218 .evalBinOpNN(state, BO_GT, *strLengthNL, *maxlenValNL, cmpTy)
1219 .castAs<DefinedOrUnknownSVal>());
Jordy Rosed3592892011-06-14 01:15:31 +00001220
Jordy Rose45d8c122011-06-14 01:26:48 +00001221 if (stateStringTooLong && !stateStringNotTooLong) {
1222 // If the string is longer than maxlen, return maxlen.
1223 result = *maxlenValNL;
1224 } else if (stateStringNotTooLong && !stateStringTooLong) {
1225 // If the string is shorter than maxlen, return its length.
1226 result = *strLengthNL;
Ted Kremenek280a01f2011-02-22 04:55:05 +00001227 }
1228 }
1229
Jordy Rose45d8c122011-06-14 01:26:48 +00001230 if (result.isUnknown()) {
1231 // If we don't have enough information for a comparison, there's
1232 // no guarantee the full string length will actually be returned.
1233 // All we know is the return value is the min of the string length
1234 // and the limit. This is better than nothing.
Craig Topper0dbb7832014-05-27 02:45:47 +00001235 result = C.getSValBuilder().conjureSymbolVal(nullptr, CE, LCtx,
1236 C.blockCount());
David Blaikie2fdacbc2013-02-20 05:52:05 +00001237 NonLoc resultNL = result.castAs<NonLoc>();
Jordy Rose45d8c122011-06-14 01:26:48 +00001238
1239 if (strLengthNL) {
David Blaikie2fdacbc2013-02-20 05:52:05 +00001240 state = state->assume(C.getSValBuilder().evalBinOpNN(
1241 state, BO_LE, resultNL, *strLengthNL, cmpTy)
1242 .castAs<DefinedOrUnknownSVal>(), true);
Jordy Rose45d8c122011-06-14 01:26:48 +00001243 }
1244
1245 if (maxlenValNL) {
David Blaikie2fdacbc2013-02-20 05:52:05 +00001246 state = state->assume(C.getSValBuilder().evalBinOpNN(
1247 state, BO_LE, resultNL, *maxlenValNL, cmpTy)
1248 .castAs<DefinedOrUnknownSVal>(), true);
Jordy Rose45d8c122011-06-14 01:26:48 +00001249 }
1250 }
1251
1252 } else {
1253 // This is a plain strlen(), not strnlen().
David Blaikie2fdacbc2013-02-20 05:52:05 +00001254 result = strLength.castAs<DefinedOrUnknownSVal>();
Jordy Rose45d8c122011-06-14 01:26:48 +00001255
1256 // If we don't know the length of the string, conjure a return
1257 // value, so it can be used in constraints, at least.
1258 if (result.isUnknown()) {
Craig Topper0dbb7832014-05-27 02:45:47 +00001259 result = C.getSValBuilder().conjureSymbolVal(nullptr, CE, LCtx,
1260 C.blockCount());
Jordy Rose45d8c122011-06-14 01:26:48 +00001261 }
Jordy Roseb052e8f2010-07-27 01:37:31 +00001262 }
Jordy Rose45d8c122011-06-14 01:26:48 +00001263
1264 // Bind the return value.
1265 assert(!result.isUnknown() && "Should have conjured a value by now");
Ted Kremenek632e3b72012-01-06 22:09:28 +00001266 state = state->BindExpr(CE, LCtx, result);
Anna Zaksda4c8d62011-10-26 21:06:34 +00001267 C.addTransition(state);
Jordy Roseb052e8f2010-07-27 01:37:31 +00001268}
1269
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001270void CStringChecker::evalStrcpy(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001271 if (CE->getNumArgs() < 2)
1272 return;
1273
Jordy Rose722f5582010-08-16 07:51:42 +00001274 // char *strcpy(char *restrict dst, const char *restrict src);
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001275 evalStrcpyCommon(C, CE,
1276 /* returnEnd = */ false,
1277 /* isBounded = */ false,
1278 /* isAppending = */ false);
Ted Kremenekfb1a79a2011-02-22 04:58:34 +00001279}
1280
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001281void CStringChecker::evalStrncpy(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001282 if (CE->getNumArgs() < 3)
1283 return;
1284
Jordy Rose4451cd42011-06-04 00:05:23 +00001285 // char *strncpy(char *restrict dst, const char *restrict src, size_t n);
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001286 evalStrcpyCommon(C, CE,
1287 /* returnEnd = */ false,
1288 /* isBounded = */ true,
1289 /* isAppending = */ false);
Jordy Rose722f5582010-08-16 07:51:42 +00001290}
1291
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001292void CStringChecker::evalStpcpy(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001293 if (CE->getNumArgs() < 2)
1294 return;
1295
Jordy Rose722f5582010-08-16 07:51:42 +00001296 // char *stpcpy(char *restrict dst, const char *restrict src);
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001297 evalStrcpyCommon(C, CE,
1298 /* returnEnd = */ true,
1299 /* isBounded = */ false,
1300 /* isAppending = */ false);
1301}
1302
1303void CStringChecker::evalStrcat(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001304 if (CE->getNumArgs() < 2)
1305 return;
1306
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001307 //char *strcat(char *restrict s1, const char *restrict s2);
1308 evalStrcpyCommon(C, CE,
1309 /* returnEnd = */ false,
1310 /* isBounded = */ false,
1311 /* isAppending = */ true);
1312}
1313
1314void CStringChecker::evalStrncat(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001315 if (CE->getNumArgs() < 3)
1316 return;
1317
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001318 //char *strncat(char *restrict s1, const char *restrict s2, size_t n);
1319 evalStrcpyCommon(C, CE,
1320 /* returnEnd = */ false,
1321 /* isBounded = */ true,
1322 /* isAppending = */ true);
Jordy Rose722f5582010-08-16 07:51:42 +00001323}
1324
Ted Kremenekdc891422010-12-01 21:57:22 +00001325void CStringChecker::evalStrcpyCommon(CheckerContext &C, const CallExpr *CE,
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001326 bool returnEnd, bool isBounded,
1327 bool isAppending) const {
Jordy Rosedceb0cf2011-06-20 02:06:40 +00001328 CurrentFunctionDescription = "string copy function";
Ted Kremenek49b1e382012-01-26 21:29:00 +00001329 ProgramStateRef state = C.getState();
Ted Kremenek632e3b72012-01-06 22:09:28 +00001330 const LocationContext *LCtx = C.getLocationContext();
Jordy Rose722f5582010-08-16 07:51:42 +00001331
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001332 // Check that the destination is non-null.
Jordy Rose722f5582010-08-16 07:51:42 +00001333 const Expr *Dst = CE->getArg(0);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001334 SVal DstVal = state->getSVal(Dst, LCtx);
Jordy Rose722f5582010-08-16 07:51:42 +00001335
Ted Kremenek90af9092010-12-02 07:49:45 +00001336 state = checkNonNull(C, state, Dst, DstVal);
Jordy Rose722f5582010-08-16 07:51:42 +00001337 if (!state)
1338 return;
1339
1340 // Check that the source is non-null.
Ted Kremenek90af9092010-12-02 07:49:45 +00001341 const Expr *srcExpr = CE->getArg(1);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001342 SVal srcVal = state->getSVal(srcExpr, LCtx);
Ted Kremenek90af9092010-12-02 07:49:45 +00001343 state = checkNonNull(C, state, srcExpr, srcVal);
Jordy Rose722f5582010-08-16 07:51:42 +00001344 if (!state)
1345 return;
1346
1347 // Get the string length of the source.
Ted Kremenek90af9092010-12-02 07:49:45 +00001348 SVal strLength = getCStringLength(C, state, srcExpr, srcVal);
Jordy Rose722f5582010-08-16 07:51:42 +00001349
1350 // If the source isn't a valid C string, give up.
Ted Kremenek90af9092010-12-02 07:49:45 +00001351 if (strLength.isUndef())
Jordy Rose722f5582010-08-16 07:51:42 +00001352 return;
1353
Jordy Rose634c12d2011-06-15 05:52:56 +00001354 SValBuilder &svalBuilder = C.getSValBuilder();
1355 QualType cmpTy = svalBuilder.getConditionType();
Jordy Roseb41f7c52011-06-20 21:55:40 +00001356 QualType sizeTy = svalBuilder.getContext().getSizeType();
Jordy Rose634c12d2011-06-15 05:52:56 +00001357
Jordy Roseb41f7c52011-06-20 21:55:40 +00001358 // These two values allow checking two kinds of errors:
1359 // - actual overflows caused by a source that doesn't fit in the destination
1360 // - potential overflows caused by a bound that could exceed the destination
Jordy Rose634c12d2011-06-15 05:52:56 +00001361 SVal amountCopied = UnknownVal();
Jordy Roseb41f7c52011-06-20 21:55:40 +00001362 SVal maxLastElementIndex = UnknownVal();
Craig Topper0dbb7832014-05-27 02:45:47 +00001363 const char *boundWarning = nullptr;
Jordy Rose634c12d2011-06-15 05:52:56 +00001364
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001365 // If the function is strncpy, strncat, etc... it is bounded.
1366 if (isBounded) {
1367 // Get the max number of characters to copy.
Ted Kremenekfb1a79a2011-02-22 04:58:34 +00001368 const Expr *lenExpr = CE->getArg(2);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001369 SVal lenVal = state->getSVal(lenExpr, LCtx);
Ted Kremenekfb1a79a2011-02-22 04:58:34 +00001370
Jordy Rose634c12d2011-06-15 05:52:56 +00001371 // Protect against misdeclared strncpy().
Jordy Roseb41f7c52011-06-20 21:55:40 +00001372 lenVal = svalBuilder.evalCast(lenVal, sizeTy, lenExpr->getType());
Jordy Rose634c12d2011-06-15 05:52:56 +00001373
David Blaikie05785d12013-02-20 22:23:23 +00001374 Optional<NonLoc> strLengthNL = strLength.getAs<NonLoc>();
1375 Optional<NonLoc> lenValNL = lenVal.getAs<NonLoc>();
Ted Kremenekfb1a79a2011-02-22 04:58:34 +00001376
Jordy Rose634c12d2011-06-15 05:52:56 +00001377 // If we know both values, we might be able to figure out how much
1378 // we're copying.
1379 if (strLengthNL && lenValNL) {
Ted Kremenek49b1e382012-01-26 21:29:00 +00001380 ProgramStateRef stateSourceTooLong, stateSourceNotTooLong;
Ted Kremenekfb1a79a2011-02-22 04:58:34 +00001381
Jordy Rose634c12d2011-06-15 05:52:56 +00001382 // Check if the max number to copy is less than the length of the src.
Jordy Roseb41f7c52011-06-20 21:55:40 +00001383 // If the bound is equal to the source length, strncpy won't null-
1384 // terminate the result!
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001385 std::tie(stateSourceTooLong, stateSourceNotTooLong) = state->assume(
David Blaikie2fdacbc2013-02-20 05:52:05 +00001386 svalBuilder.evalBinOpNN(state, BO_GE, *strLengthNL, *lenValNL, cmpTy)
1387 .castAs<DefinedOrUnknownSVal>());
Jordy Rose634c12d2011-06-15 05:52:56 +00001388
1389 if (stateSourceTooLong && !stateSourceNotTooLong) {
1390 // Max number to copy is less than the length of the src, so the actual
1391 // strLength copied is the max number arg.
1392 state = stateSourceTooLong;
1393 amountCopied = lenVal;
1394
1395 } else if (!stateSourceTooLong && stateSourceNotTooLong) {
1396 // The source buffer entirely fits in the bound.
1397 state = stateSourceNotTooLong;
1398 amountCopied = strLength;
1399 }
1400 }
1401
Jordy Rose328deee2011-06-20 03:49:16 +00001402 // We still want to know if the bound is known to be too large.
Jordy Roseb41f7c52011-06-20 21:55:40 +00001403 if (lenValNL) {
1404 if (isAppending) {
1405 // For strncat, the check is strlen(dst) + lenVal < sizeof(dst)
1406
1407 // Get the string length of the destination. If the destination is
1408 // memory that can't have a string length, we shouldn't be copying
1409 // into it anyway.
1410 SVal dstStrLength = getCStringLength(C, state, Dst, DstVal);
1411 if (dstStrLength.isUndef())
1412 return;
1413
David Blaikie05785d12013-02-20 22:23:23 +00001414 if (Optional<NonLoc> dstStrLengthNL = dstStrLength.getAs<NonLoc>()) {
Jordy Roseb41f7c52011-06-20 21:55:40 +00001415 maxLastElementIndex = svalBuilder.evalBinOpNN(state, BO_Add,
1416 *lenValNL,
1417 *dstStrLengthNL,
1418 sizeTy);
1419 boundWarning = "Size argument is greater than the free space in the "
1420 "destination buffer";
1421 }
1422
1423 } else {
1424 // For strncpy, this is just checking that lenVal <= sizeof(dst)
1425 // (Yes, strncpy and strncat differ in how they treat termination.
1426 // strncat ALWAYS terminates, but strncpy doesn't.)
Jordy Rose459d5f62012-05-14 17:58:35 +00001427
1428 // We need a special case for when the copy size is zero, in which
1429 // case strncpy will do no work at all. Our bounds check uses n-1
1430 // as the last element accessed, so n == 0 is problematic.
1431 ProgramStateRef StateZeroSize, StateNonZeroSize;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001432 std::tie(StateZeroSize, StateNonZeroSize) =
Jordy Rose459d5f62012-05-14 17:58:35 +00001433 assumeZero(C, state, *lenValNL, sizeTy);
1434
1435 // If the size is known to be zero, we're done.
1436 if (StateZeroSize && !StateNonZeroSize) {
1437 StateZeroSize = StateZeroSize->BindExpr(CE, LCtx, DstVal);
1438 C.addTransition(StateZeroSize);
1439 return;
1440 }
1441
1442 // Otherwise, go ahead and figure out the last element we'll touch.
1443 // We don't record the non-zero assumption here because we can't
1444 // be sure. We won't warn on a possible zero.
David Blaikie2fdacbc2013-02-20 05:52:05 +00001445 NonLoc one = svalBuilder.makeIntVal(1, sizeTy).castAs<NonLoc>();
Jordy Roseb41f7c52011-06-20 21:55:40 +00001446 maxLastElementIndex = svalBuilder.evalBinOpNN(state, BO_Sub, *lenValNL,
1447 one, sizeTy);
1448 boundWarning = "Size argument is greater than the length of the "
1449 "destination buffer";
1450 }
1451 }
Jordy Rose328deee2011-06-20 03:49:16 +00001452
Jordy Rose634c12d2011-06-15 05:52:56 +00001453 // If we couldn't pin down the copy length, at least bound it.
Jordy Roseb41f7c52011-06-20 21:55:40 +00001454 // FIXME: We should actually run this code path for append as well, but
1455 // right now it creates problems with constraints (since we can end up
1456 // trying to pass constraints from symbol to symbol).
1457 if (amountCopied.isUnknown() && !isAppending) {
Jordy Rose634c12d2011-06-15 05:52:56 +00001458 // Try to get a "hypothetical" string length symbol, which we can later
1459 // set as a real value if that turns out to be the case.
1460 amountCopied = getCStringLength(C, state, lenExpr, srcVal, true);
1461 assert(!amountCopied.isUndef());
1462
David Blaikie05785d12013-02-20 22:23:23 +00001463 if (Optional<NonLoc> amountCopiedNL = amountCopied.getAs<NonLoc>()) {
Jordy Rose634c12d2011-06-15 05:52:56 +00001464 if (lenValNL) {
1465 // amountCopied <= lenVal
1466 SVal copiedLessThanBound = svalBuilder.evalBinOpNN(state, BO_LE,
1467 *amountCopiedNL,
1468 *lenValNL,
1469 cmpTy);
David Blaikie2fdacbc2013-02-20 05:52:05 +00001470 state = state->assume(
1471 copiedLessThanBound.castAs<DefinedOrUnknownSVal>(), true);
Jordy Rose634c12d2011-06-15 05:52:56 +00001472 if (!state)
1473 return;
1474 }
1475
1476 if (strLengthNL) {
1477 // amountCopied <= strlen(source)
1478 SVal copiedLessThanSrc = svalBuilder.evalBinOpNN(state, BO_LE,
1479 *amountCopiedNL,
1480 *strLengthNL,
1481 cmpTy);
David Blaikie2fdacbc2013-02-20 05:52:05 +00001482 state = state->assume(
1483 copiedLessThanSrc.castAs<DefinedOrUnknownSVal>(), true);
Jordy Rose634c12d2011-06-15 05:52:56 +00001484 if (!state)
1485 return;
1486 }
1487 }
1488 }
1489
1490 } else {
1491 // The function isn't bounded. The amount copied should match the length
1492 // of the source buffer.
1493 amountCopied = strLength;
Ted Kremenekfb1a79a2011-02-22 04:58:34 +00001494 }
1495
Jordy Rose634c12d2011-06-15 05:52:56 +00001496 assert(state);
1497
1498 // This represents the number of characters copied into the destination
1499 // buffer. (It may not actually be the strlen if the destination buffer
1500 // is not terminated.)
1501 SVal finalStrLength = UnknownVal();
1502
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001503 // If this is an appending function (strcat, strncat...) then set the
1504 // string length to strlen(src) + strlen(dst) since the buffer will
1505 // ultimately contain both.
1506 if (isAppending) {
Jordy Rose455bd582011-06-16 05:51:02 +00001507 // Get the string length of the destination. If the destination is memory
1508 // that can't have a string length, we shouldn't be copying into it anyway.
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001509 SVal dstStrLength = getCStringLength(C, state, Dst, DstVal);
1510 if (dstStrLength.isUndef())
1511 return;
1512
David Blaikie05785d12013-02-20 22:23:23 +00001513 Optional<NonLoc> srcStrLengthNL = amountCopied.getAs<NonLoc>();
1514 Optional<NonLoc> dstStrLengthNL = dstStrLength.getAs<NonLoc>();
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001515
Jordy Rose634c12d2011-06-15 05:52:56 +00001516 // If we know both string lengths, we might know the final string length.
1517 if (srcStrLengthNL && dstStrLengthNL) {
1518 // Make sure the two lengths together don't overflow a size_t.
1519 state = checkAdditionOverflow(C, state, *srcStrLengthNL, *dstStrLengthNL);
1520 if (!state)
1521 return;
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001522
Jordy Rose634c12d2011-06-15 05:52:56 +00001523 finalStrLength = svalBuilder.evalBinOpNN(state, BO_Add, *srcStrLengthNL,
1524 *dstStrLengthNL, sizeTy);
1525 }
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001526
Jordy Rose634c12d2011-06-15 05:52:56 +00001527 // If we couldn't get a single value for the final string length,
1528 // we can at least bound it by the individual lengths.
1529 if (finalStrLength.isUnknown()) {
1530 // Try to get a "hypothetical" string length symbol, which we can later
1531 // set as a real value if that turns out to be the case.
1532 finalStrLength = getCStringLength(C, state, CE, DstVal, true);
1533 assert(!finalStrLength.isUndef());
1534
David Blaikie05785d12013-02-20 22:23:23 +00001535 if (Optional<NonLoc> finalStrLengthNL = finalStrLength.getAs<NonLoc>()) {
Jordy Rose634c12d2011-06-15 05:52:56 +00001536 if (srcStrLengthNL) {
1537 // finalStrLength >= srcStrLength
1538 SVal sourceInResult = svalBuilder.evalBinOpNN(state, BO_GE,
1539 *finalStrLengthNL,
1540 *srcStrLengthNL,
1541 cmpTy);
David Blaikie2fdacbc2013-02-20 05:52:05 +00001542 state = state->assume(sourceInResult.castAs<DefinedOrUnknownSVal>(),
Jordy Rose634c12d2011-06-15 05:52:56 +00001543 true);
1544 if (!state)
1545 return;
1546 }
1547
1548 if (dstStrLengthNL) {
1549 // finalStrLength >= dstStrLength
1550 SVal destInResult = svalBuilder.evalBinOpNN(state, BO_GE,
1551 *finalStrLengthNL,
1552 *dstStrLengthNL,
1553 cmpTy);
David Blaikie2fdacbc2013-02-20 05:52:05 +00001554 state =
1555 state->assume(destInResult.castAs<DefinedOrUnknownSVal>(), true);
Jordy Rose634c12d2011-06-15 05:52:56 +00001556 if (!state)
1557 return;
1558 }
1559 }
1560 }
1561
1562 } else {
1563 // Otherwise, this is a copy-over function (strcpy, strncpy, ...), and
1564 // the final string length will match the input string length.
1565 finalStrLength = amountCopied;
Lenny Maiorani467dbd52011-04-09 15:12:58 +00001566 }
1567
Jordy Rose634c12d2011-06-15 05:52:56 +00001568 // The final result of the function will either be a pointer past the last
1569 // copied element, or a pointer to the start of the destination buffer.
Ted Kremenek90af9092010-12-02 07:49:45 +00001570 SVal Result = (returnEnd ? UnknownVal() : DstVal);
Jordy Rose722f5582010-08-16 07:51:42 +00001571
Jordy Rose634c12d2011-06-15 05:52:56 +00001572 assert(state);
1573
Jordy Rose722f5582010-08-16 07:51:42 +00001574 // If the destination is a MemRegion, try to check for a buffer overflow and
1575 // record the new string length.
David Blaikie05785d12013-02-20 22:23:23 +00001576 if (Optional<loc::MemRegionVal> dstRegVal =
David Blaikie2fdacbc2013-02-20 05:52:05 +00001577 DstVal.getAs<loc::MemRegionVal>()) {
Jordy Roseb41f7c52011-06-20 21:55:40 +00001578 QualType ptrTy = Dst->getType();
1579
1580 // If we have an exact value on a bounded copy, use that to check for
1581 // overflows, rather than our estimate about how much is actually copied.
1582 if (boundWarning) {
David Blaikie05785d12013-02-20 22:23:23 +00001583 if (Optional<NonLoc> maxLastNL = maxLastElementIndex.getAs<NonLoc>()) {
Jordy Roseb41f7c52011-06-20 21:55:40 +00001584 SVal maxLastElement = svalBuilder.evalBinOpLN(state, BO_Add, *dstRegVal,
1585 *maxLastNL, ptrTy);
1586 state = CheckLocation(C, state, CE->getArg(2), maxLastElement,
1587 boundWarning);
1588 if (!state)
1589 return;
1590 }
1591 }
1592
1593 // Then, if the final length is known...
David Blaikie05785d12013-02-20 22:23:23 +00001594 if (Optional<NonLoc> knownStrLength = finalStrLength.getAs<NonLoc>()) {
Jordy Rose634c12d2011-06-15 05:52:56 +00001595 SVal lastElement = svalBuilder.evalBinOpLN(state, BO_Add, *dstRegVal,
Jordy Roseb41f7c52011-06-20 21:55:40 +00001596 *knownStrLength, ptrTy);
Jordy Rose722f5582010-08-16 07:51:42 +00001597
Jordy Roseb41f7c52011-06-20 21:55:40 +00001598 // ...and we haven't checked the bound, we'll check the actual copy.
1599 if (!boundWarning) {
1600 const char * const warningMsg =
1601 "String copy function overflows destination buffer";
1602 state = CheckLocation(C, state, Dst, lastElement, warningMsg);
1603 if (!state)
1604 return;
1605 }
Jordy Rose722f5582010-08-16 07:51:42 +00001606
1607 // If this is a stpcpy-style copy, the last element is the return value.
Ted Kremenek90af9092010-12-02 07:49:45 +00001608 if (returnEnd)
1609 Result = lastElement;
Jordy Rose722f5582010-08-16 07:51:42 +00001610 }
1611
Anton Yartsev968c60a2013-11-17 09:18:48 +00001612 // Invalidate the destination (regular invalidation without pointer-escaping
1613 // the address of the top-level region). This must happen before we set the
1614 // C string length because invalidation will clear the length.
Jordy Rose722f5582010-08-16 07:51:42 +00001615 // FIXME: Even if we can't perfectly model the copy, we should see if we
1616 // can use LazyCompoundVals to copy the source values into the destination.
1617 // This would probably remove any existing bindings past the end of the
1618 // string, but that's still an improvement over blank invalidation.
Anton Yartsev968c60a2013-11-17 09:18:48 +00001619 state = InvalidateBuffer(C, state, Dst, *dstRegVal,
1620 /*IsSourceBuffer*/false);
1621
1622 // Invalidate the source (const-invalidation without const-pointer-escaping
1623 // the address of the top-level region).
1624 state = InvalidateBuffer(C, state, srcExpr, srcVal, /*IsSourceBuffer*/true);
Jordy Rose722f5582010-08-16 07:51:42 +00001625
Jordy Rose328deee2011-06-20 03:49:16 +00001626 // Set the C string length of the destination, if we know it.
Jordy Roseb41f7c52011-06-20 21:55:40 +00001627 if (isBounded && !isAppending) {
1628 // strncpy is annoying in that it doesn't guarantee to null-terminate
1629 // the result string. If the original string didn't fit entirely inside
1630 // the bound (including the null-terminator), we don't know how long the
1631 // result is.
1632 if (amountCopied != strLength)
1633 finalStrLength = UnknownVal();
1634 }
1635 state = setCStringLength(state, dstRegVal->getRegion(), finalStrLength);
Jordy Rose722f5582010-08-16 07:51:42 +00001636 }
1637
Jordy Rose634c12d2011-06-15 05:52:56 +00001638 assert(state);
1639
Jordy Rose722f5582010-08-16 07:51:42 +00001640 // If this is a stpcpy-style copy, but we were unable to check for a buffer
1641 // overflow, we still need a result. Conjure a return value.
Ted Kremenek90af9092010-12-02 07:49:45 +00001642 if (returnEnd && Result.isUnknown()) {
Craig Topper0dbb7832014-05-27 02:45:47 +00001643 Result = svalBuilder.conjureSymbolVal(nullptr, CE, LCtx, C.blockCount());
Jordy Rose722f5582010-08-16 07:51:42 +00001644 }
1645
1646 // Set the return value.
Ted Kremenek632e3b72012-01-06 22:09:28 +00001647 state = state->BindExpr(CE, LCtx, Result);
Anna Zaksda4c8d62011-10-26 21:06:34 +00001648 C.addTransition(state);
Jordy Rose722f5582010-08-16 07:51:42 +00001649}
1650
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001651void CStringChecker::evalStrcmp(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001652 if (CE->getNumArgs() < 2)
1653 return;
1654
Jordy Rosec0263702011-06-16 07:13:34 +00001655 //int strcmp(const char *s1, const char *s2);
Lenny Maiorani4af23c82011-04-28 15:09:11 +00001656 evalStrcmpCommon(C, CE, /* isBounded = */ false, /* ignoreCase = */ false);
Lenny Maioranie553e402011-04-25 22:21:00 +00001657}
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001658
Lenny Maioranie553e402011-04-25 22:21:00 +00001659void CStringChecker::evalStrncmp(CheckerContext &C, const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001660 if (CE->getNumArgs() < 3)
1661 return;
1662
Jordy Rosec0263702011-06-16 07:13:34 +00001663 //int strncmp(const char *s1, const char *s2, size_t n);
Lenny Maiorani4af23c82011-04-28 15:09:11 +00001664 evalStrcmpCommon(C, CE, /* isBounded = */ true, /* ignoreCase = */ false);
1665}
1666
1667void CStringChecker::evalStrcasecmp(CheckerContext &C,
1668 const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001669 if (CE->getNumArgs() < 2)
1670 return;
1671
Jordy Rosec0263702011-06-16 07:13:34 +00001672 //int strcasecmp(const char *s1, const char *s2);
Lenny Maiorani4af23c82011-04-28 15:09:11 +00001673 evalStrcmpCommon(C, CE, /* isBounded = */ false, /* ignoreCase = */ true);
Lenny Maioranie553e402011-04-25 22:21:00 +00001674}
1675
Lenny Maiorani0b510272011-05-02 19:05:49 +00001676void CStringChecker::evalStrncasecmp(CheckerContext &C,
1677 const CallExpr *CE) const {
Anna Zaksb508d292012-04-10 23:41:11 +00001678 if (CE->getNumArgs() < 3)
1679 return;
1680
Jordy Rosec0263702011-06-16 07:13:34 +00001681 //int strncasecmp(const char *s1, const char *s2, size_t n);
Lenny Maiorani0b510272011-05-02 19:05:49 +00001682 evalStrcmpCommon(C, CE, /* isBounded = */ true, /* ignoreCase = */ true);
1683}
1684
Lenny Maioranie553e402011-04-25 22:21:00 +00001685void CStringChecker::evalStrcmpCommon(CheckerContext &C, const CallExpr *CE,
Lenny Maiorani4af23c82011-04-28 15:09:11 +00001686 bool isBounded, bool ignoreCase) const {
Jordy Rosedceb0cf2011-06-20 02:06:40 +00001687 CurrentFunctionDescription = "string comparison function";
Ted Kremenek49b1e382012-01-26 21:29:00 +00001688 ProgramStateRef state = C.getState();
Ted Kremenek632e3b72012-01-06 22:09:28 +00001689 const LocationContext *LCtx = C.getLocationContext();
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001690
1691 // Check that the first string is non-null
1692 const Expr *s1 = CE->getArg(0);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001693 SVal s1Val = state->getSVal(s1, LCtx);
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001694 state = checkNonNull(C, state, s1, s1Val);
1695 if (!state)
1696 return;
1697
1698 // Check that the second string is non-null.
1699 const Expr *s2 = CE->getArg(1);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001700 SVal s2Val = state->getSVal(s2, LCtx);
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001701 state = checkNonNull(C, state, s2, s2Val);
1702 if (!state)
1703 return;
1704
1705 // Get the string length of the first string or give up.
1706 SVal s1Length = getCStringLength(C, state, s1, s1Val);
1707 if (s1Length.isUndef())
1708 return;
1709
1710 // Get the string length of the second string or give up.
1711 SVal s2Length = getCStringLength(C, state, s2, s2Val);
1712 if (s2Length.isUndef())
1713 return;
1714
Jordy Rosec0263702011-06-16 07:13:34 +00001715 // If we know the two buffers are the same, we know the result is 0.
1716 // First, get the two buffers' addresses. Another checker will have already
1717 // made sure they're not undefined.
David Blaikie2fdacbc2013-02-20 05:52:05 +00001718 DefinedOrUnknownSVal LV = s1Val.castAs<DefinedOrUnknownSVal>();
1719 DefinedOrUnknownSVal RV = s2Val.castAs<DefinedOrUnknownSVal>();
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001720
Jordy Rosec0263702011-06-16 07:13:34 +00001721 // See if they are the same.
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001722 SValBuilder &svalBuilder = C.getSValBuilder();
Jordy Rosec0263702011-06-16 07:13:34 +00001723 DefinedOrUnknownSVal SameBuf = svalBuilder.evalEQ(state, LV, RV);
Ted Kremenek49b1e382012-01-26 21:29:00 +00001724 ProgramStateRef StSameBuf, StNotSameBuf;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001725 std::tie(StSameBuf, StNotSameBuf) = state->assume(SameBuf);
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001726
Jordy Rosec0263702011-06-16 07:13:34 +00001727 // If the two arguments might be the same buffer, we know the result is 0,
1728 // and we only need to check one size.
1729 if (StSameBuf) {
Ted Kremenek632e3b72012-01-06 22:09:28 +00001730 StSameBuf = StSameBuf->BindExpr(CE, LCtx,
1731 svalBuilder.makeZeroVal(CE->getType()));
Anna Zaksda4c8d62011-10-26 21:06:34 +00001732 C.addTransition(StSameBuf);
Jordy Rosec0263702011-06-16 07:13:34 +00001733
1734 // If the two arguments are GUARANTEED to be the same, we're done!
1735 if (!StNotSameBuf)
1736 return;
1737 }
1738
1739 assert(StNotSameBuf);
1740 state = StNotSameBuf;
1741
1742 // At this point we can go about comparing the two buffers.
1743 // For now, we only do this if they're both known string literals.
1744
1745 // Attempt to extract string literals from both expressions.
1746 const StringLiteral *s1StrLiteral = getCStringLiteral(C, state, s1, s1Val);
1747 const StringLiteral *s2StrLiteral = getCStringLiteral(C, state, s2, s2Val);
1748 bool canComputeResult = false;
1749
1750 if (s1StrLiteral && s2StrLiteral) {
Chris Lattner0e62c1c2011-07-23 10:55:15 +00001751 StringRef s1StrRef = s1StrLiteral->getString();
1752 StringRef s2StrRef = s2StrLiteral->getString();
Jordy Rosec0263702011-06-16 07:13:34 +00001753
1754 if (isBounded) {
1755 // Get the max number of characters to compare.
1756 const Expr *lenExpr = CE->getArg(2);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001757 SVal lenVal = state->getSVal(lenExpr, LCtx);
Jordy Rosec0263702011-06-16 07:13:34 +00001758
1759 // If the length is known, we can get the right substrings.
1760 if (const llvm::APSInt *len = svalBuilder.getKnownValue(state, lenVal)) {
1761 // Create substrings of each to compare the prefix.
1762 s1StrRef = s1StrRef.substr(0, (size_t)len->getZExtValue());
1763 s2StrRef = s2StrRef.substr(0, (size_t)len->getZExtValue());
1764 canComputeResult = true;
1765 }
1766 } else {
1767 // This is a normal, unbounded strcmp.
1768 canComputeResult = true;
1769 }
1770
1771 if (canComputeResult) {
1772 // Real strcmp stops at null characters.
1773 size_t s1Term = s1StrRef.find('\0');
Chris Lattner0e62c1c2011-07-23 10:55:15 +00001774 if (s1Term != StringRef::npos)
Jordy Rosec0263702011-06-16 07:13:34 +00001775 s1StrRef = s1StrRef.substr(0, s1Term);
1776
1777 size_t s2Term = s2StrRef.find('\0');
Chris Lattner0e62c1c2011-07-23 10:55:15 +00001778 if (s2Term != StringRef::npos)
Jordy Rosec0263702011-06-16 07:13:34 +00001779 s2StrRef = s2StrRef.substr(0, s2Term);
1780
1781 // Use StringRef's comparison methods to compute the actual result.
1782 int result;
1783
1784 if (ignoreCase) {
1785 // Compare string 1 to string 2 the same way strcasecmp() does.
1786 result = s1StrRef.compare_lower(s2StrRef);
1787 } else {
1788 // Compare string 1 to string 2 the same way strcmp() does.
1789 result = s1StrRef.compare(s2StrRef);
1790 }
1791
1792 // Build the SVal of the comparison and bind the return value.
1793 SVal resultVal = svalBuilder.makeIntVal(result, CE->getType());
Ted Kremenek632e3b72012-01-06 22:09:28 +00001794 state = state->BindExpr(CE, LCtx, resultVal);
Jordy Rosec0263702011-06-16 07:13:34 +00001795 }
1796 }
1797
1798 if (!canComputeResult) {
1799 // Conjure a symbolic value. It's the best we can do.
Craig Topper0dbb7832014-05-27 02:45:47 +00001800 SVal resultVal = svalBuilder.conjureSymbolVal(nullptr, CE, LCtx,
1801 C.blockCount());
Ted Kremenek632e3b72012-01-06 22:09:28 +00001802 state = state->BindExpr(CE, LCtx, resultVal);
Jordy Rosec0263702011-06-16 07:13:34 +00001803 }
1804
1805 // Record this as a possible path.
Anna Zaksda4c8d62011-10-26 21:06:34 +00001806 C.addTransition(state);
Lenny Maioranif3539ad2011-04-12 17:08:43 +00001807}
1808
Jordan Rose6e3cf2b2013-04-22 23:18:42 +00001809void CStringChecker::evalStrsep(CheckerContext &C, const CallExpr *CE) const {
1810 //char *strsep(char **stringp, const char *delim);
1811 if (CE->getNumArgs() < 2)
1812 return;
1813
1814 // Sanity: does the search string parameter match the return type?
1815 const Expr *SearchStrPtr = CE->getArg(0);
1816 QualType CharPtrTy = SearchStrPtr->getType()->getPointeeType();
1817 if (CharPtrTy.isNull() ||
1818 CE->getType().getUnqualifiedType() != CharPtrTy.getUnqualifiedType())
1819 return;
1820
1821 CurrentFunctionDescription = "strsep()";
1822 ProgramStateRef State = C.getState();
1823 const LocationContext *LCtx = C.getLocationContext();
1824
1825 // Check that the search string pointer is non-null (though it may point to
1826 // a null string).
1827 SVal SearchStrVal = State->getSVal(SearchStrPtr, LCtx);
1828 State = checkNonNull(C, State, SearchStrPtr, SearchStrVal);
1829 if (!State)
1830 return;
1831
1832 // Check that the delimiter string is non-null.
1833 const Expr *DelimStr = CE->getArg(1);
1834 SVal DelimStrVal = State->getSVal(DelimStr, LCtx);
1835 State = checkNonNull(C, State, DelimStr, DelimStrVal);
1836 if (!State)
1837 return;
1838
1839 SValBuilder &SVB = C.getSValBuilder();
1840 SVal Result;
1841 if (Optional<Loc> SearchStrLoc = SearchStrVal.getAs<Loc>()) {
1842 // Get the current value of the search string pointer, as a char*.
1843 Result = State->getSVal(*SearchStrLoc, CharPtrTy);
1844
1845 // Invalidate the search string, representing the change of one delimiter
1846 // character to NUL.
Anton Yartsev968c60a2013-11-17 09:18:48 +00001847 State = InvalidateBuffer(C, State, SearchStrPtr, Result,
1848 /*IsSourceBuffer*/false);
Jordan Rose6e3cf2b2013-04-22 23:18:42 +00001849
1850 // Overwrite the search string pointer. The new value is either an address
1851 // further along in the same string, or NULL if there are no more tokens.
1852 State = State->bindLoc(*SearchStrLoc,
1853 SVB.conjureSymbolVal(getTag(), CE, LCtx, CharPtrTy,
1854 C.blockCount()));
1855 } else {
1856 assert(SearchStrVal.isUnknown());
1857 // Conjure a symbolic value. It's the best we can do.
Craig Topper0dbb7832014-05-27 02:45:47 +00001858 Result = SVB.conjureSymbolVal(nullptr, CE, LCtx, C.blockCount());
Jordan Rose6e3cf2b2013-04-22 23:18:42 +00001859 }
1860
1861 // Set the return value, and finish.
1862 State = State->BindExpr(CE, LCtx, Result);
1863 C.addTransition(State);
1864}
1865
1866
Jordy Rosed5d2e502010-07-08 23:57:29 +00001867//===----------------------------------------------------------------------===//
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001868// The driver method, and other Checker callbacks.
Jordy Rosed5d2e502010-07-08 23:57:29 +00001869//===----------------------------------------------------------------------===//
Jordy Rose134a2362010-07-06 23:11:01 +00001870
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001871bool CStringChecker::evalCall(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks6348a812012-02-17 22:35:26 +00001872 const FunctionDecl *FDecl = C.getCalleeDecl(CE);
1873
1874 if (!FDecl)
Jordy Rose134a2362010-07-06 23:11:01 +00001875 return false;
Jordy Rose134a2362010-07-06 23:11:01 +00001876
Jordan Rose6e3cf2b2013-04-22 23:18:42 +00001877 // FIXME: Poorly-factored string switches are slow.
Craig Topper0dbb7832014-05-27 02:45:47 +00001878 FnCheck evalFunction = nullptr;
Anna Zaks6348a812012-02-17 22:35:26 +00001879 if (C.isCLibraryFunction(FDecl, "memcpy"))
1880 evalFunction = &CStringChecker::evalMemcpy;
1881 else if (C.isCLibraryFunction(FDecl, "mempcpy"))
1882 evalFunction = &CStringChecker::evalMempcpy;
1883 else if (C.isCLibraryFunction(FDecl, "memcmp"))
1884 evalFunction = &CStringChecker::evalMemcmp;
1885 else if (C.isCLibraryFunction(FDecl, "memmove"))
1886 evalFunction = &CStringChecker::evalMemmove;
1887 else if (C.isCLibraryFunction(FDecl, "strcpy"))
1888 evalFunction = &CStringChecker::evalStrcpy;
1889 else if (C.isCLibraryFunction(FDecl, "strncpy"))
1890 evalFunction = &CStringChecker::evalStrncpy;
1891 else if (C.isCLibraryFunction(FDecl, "stpcpy"))
1892 evalFunction = &CStringChecker::evalStpcpy;
1893 else if (C.isCLibraryFunction(FDecl, "strcat"))
1894 evalFunction = &CStringChecker::evalStrcat;
1895 else if (C.isCLibraryFunction(FDecl, "strncat"))
1896 evalFunction = &CStringChecker::evalStrncat;
1897 else if (C.isCLibraryFunction(FDecl, "strlen"))
1898 evalFunction = &CStringChecker::evalstrLength;
1899 else if (C.isCLibraryFunction(FDecl, "strnlen"))
1900 evalFunction = &CStringChecker::evalstrnLength;
1901 else if (C.isCLibraryFunction(FDecl, "strcmp"))
1902 evalFunction = &CStringChecker::evalStrcmp;
1903 else if (C.isCLibraryFunction(FDecl, "strncmp"))
1904 evalFunction = &CStringChecker::evalStrncmp;
1905 else if (C.isCLibraryFunction(FDecl, "strcasecmp"))
1906 evalFunction = &CStringChecker::evalStrcasecmp;
1907 else if (C.isCLibraryFunction(FDecl, "strncasecmp"))
1908 evalFunction = &CStringChecker::evalStrncasecmp;
Jordan Rose6e3cf2b2013-04-22 23:18:42 +00001909 else if (C.isCLibraryFunction(FDecl, "strsep"))
1910 evalFunction = &CStringChecker::evalStrsep;
Anna Zaks6348a812012-02-17 22:35:26 +00001911 else if (C.isCLibraryFunction(FDecl, "bcopy"))
1912 evalFunction = &CStringChecker::evalBcopy;
1913 else if (C.isCLibraryFunction(FDecl, "bcmp"))
1914 evalFunction = &CStringChecker::evalMemcmp;
1915
Jordy Rosed5d2e502010-07-08 23:57:29 +00001916 // If the callee isn't a string function, let another checker handle it.
Ted Kremenekdc891422010-12-01 21:57:22 +00001917 if (!evalFunction)
Jordy Rose134a2362010-07-06 23:11:01 +00001918 return false;
1919
Jordy Rosedceb0cf2011-06-20 02:06:40 +00001920 // Make sure each function sets its own description.
1921 // (But don't bother in a release build.)
Craig Topper0dbb7832014-05-27 02:45:47 +00001922 assert(!(CurrentFunctionDescription = nullptr));
Jordy Rosedceb0cf2011-06-20 02:06:40 +00001923
Jordy Rosed5d2e502010-07-08 23:57:29 +00001924 // Check and evaluate the call.
Ted Kremenekdc891422010-12-01 21:57:22 +00001925 (this->*evalFunction)(C, CE);
Anna Zakse0c7c272012-02-07 00:56:14 +00001926
1927 // If the evaluate call resulted in no change, chain to the next eval call
1928 // handler.
1929 // Note, the custom CString evaluation calls assume that basic safety
1930 // properties are held. However, if the user chooses to turn off some of these
1931 // checks, we ignore the issues and leave the call evaluation to a generic
1932 // handler.
1933 if (!C.isDifferent())
1934 return false;
1935
Jordy Rose134a2362010-07-06 23:11:01 +00001936 return true;
1937}
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001938
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00001939void CStringChecker::checkPreStmt(const DeclStmt *DS, CheckerContext &C) const {
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001940 // Record string length for char a[] = "abc";
Ted Kremenek49b1e382012-01-26 21:29:00 +00001941 ProgramStateRef state = C.getState();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001942
Aaron Ballman535bbcc2014-03-14 17:01:24 +00001943 for (const auto *I : DS->decls()) {
1944 const VarDecl *D = dyn_cast<VarDecl>(I);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001945 if (!D)
1946 continue;
1947
1948 // FIXME: Handle array fields of structs.
1949 if (!D->getType()->isArrayType())
1950 continue;
1951
1952 const Expr *Init = D->getInit();
1953 if (!Init)
1954 continue;
1955 if (!isa<StringLiteral>(Init))
1956 continue;
1957
Anna Zaksc9abbe22011-10-26 21:06:44 +00001958 Loc VarLoc = state->getLValue(D, C.getLocationContext());
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001959 const MemRegion *MR = VarLoc.getAsRegion();
1960 if (!MR)
1961 continue;
1962
Ted Kremenek632e3b72012-01-06 22:09:28 +00001963 SVal StrVal = state->getSVal(Init, C.getLocationContext());
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001964 assert(StrVal.isValid() && "Initializer string is unknown or undefined");
David Blaikie2fdacbc2013-02-20 05:52:05 +00001965 DefinedOrUnknownSVal strLength =
1966 getCStringLength(C, state, Init, StrVal).castAs<DefinedOrUnknownSVal>();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001967
Ted Kremenek90af9092010-12-02 07:49:45 +00001968 state = state->set<CStringLength>(MR, strLength);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001969 }
1970
Anna Zaksda4c8d62011-10-26 21:06:34 +00001971 C.addTransition(state);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001972}
1973
Ted Kremenek49b1e382012-01-26 21:29:00 +00001974bool CStringChecker::wantsRegionChangeUpdate(ProgramStateRef state) const {
Jordan Rose0c153cb2012-11-02 01:54:06 +00001975 CStringLengthTy Entries = state->get<CStringLength>();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001976 return !Entries.isEmpty();
1977}
1978
Ted Kremenek49b1e382012-01-26 21:29:00 +00001979ProgramStateRef
1980CStringChecker::checkRegionChanges(ProgramStateRef state,
Anna Zaksdc154152012-12-20 00:38:25 +00001981 const InvalidatedSymbols *,
Jordy Rose1fad6632011-08-27 22:51:26 +00001982 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks3d348342012-02-14 21:55:24 +00001983 ArrayRef<const MemRegion *> Regions,
Jordan Rose742920c2012-07-02 19:27:35 +00001984 const CallEvent *Call) const {
Jordan Rose0c153cb2012-11-02 01:54:06 +00001985 CStringLengthTy Entries = state->get<CStringLength>();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001986 if (Entries.isEmpty())
1987 return state;
1988
1989 llvm::SmallPtrSet<const MemRegion *, 8> Invalidated;
1990 llvm::SmallPtrSet<const MemRegion *, 32> SuperRegions;
1991
1992 // First build sets for the changed regions and their super-regions.
Jordy Rose1fad6632011-08-27 22:51:26 +00001993 for (ArrayRef<const MemRegion *>::iterator
1994 I = Regions.begin(), E = Regions.end(); I != E; ++I) {
1995 const MemRegion *MR = *I;
Jordy Rose2a2e21c2010-08-14 21:02:52 +00001996 Invalidated.insert(MR);
1997
1998 SuperRegions.insert(MR);
1999 while (const SubRegion *SR = dyn_cast<SubRegion>(MR)) {
2000 MR = SR->getSuperRegion();
2001 SuperRegions.insert(MR);
2002 }
2003 }
2004
Jordan Rose0c153cb2012-11-02 01:54:06 +00002005 CStringLengthTy::Factory &F = state->get_context<CStringLength>();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002006
2007 // Then loop over the entries in the current state.
Jordan Rose0c153cb2012-11-02 01:54:06 +00002008 for (CStringLengthTy::iterator I = Entries.begin(),
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002009 E = Entries.end(); I != E; ++I) {
2010 const MemRegion *MR = I.getKey();
2011
2012 // Is this entry for a super-region of a changed region?
2013 if (SuperRegions.count(MR)) {
Ted Kremenekb3b56c62010-11-24 00:54:37 +00002014 Entries = F.remove(Entries, MR);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002015 continue;
2016 }
2017
2018 // Is this entry for a sub-region of a changed region?
2019 const MemRegion *Super = MR;
2020 while (const SubRegion *SR = dyn_cast<SubRegion>(Super)) {
2021 Super = SR->getSuperRegion();
2022 if (Invalidated.count(Super)) {
Ted Kremenekb3b56c62010-11-24 00:54:37 +00002023 Entries = F.remove(Entries, MR);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002024 break;
2025 }
2026 }
2027 }
2028
2029 return state->set<CStringLength>(Entries);
2030}
2031
Ted Kremenek49b1e382012-01-26 21:29:00 +00002032void CStringChecker::checkLiveSymbols(ProgramStateRef state,
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00002033 SymbolReaper &SR) const {
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002034 // Mark all symbols in our string length map as valid.
Jordan Rose0c153cb2012-11-02 01:54:06 +00002035 CStringLengthTy Entries = state->get<CStringLength>();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002036
Jordan Rose0c153cb2012-11-02 01:54:06 +00002037 for (CStringLengthTy::iterator I = Entries.begin(), E = Entries.end();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002038 I != E; ++I) {
2039 SVal Len = I.getData();
Jordy Rose634c12d2011-06-15 05:52:56 +00002040
Anna Zaksee1a4352011-12-06 23:12:33 +00002041 for (SymExpr::symbol_iterator si = Len.symbol_begin(),
2042 se = Len.symbol_end(); si != se; ++si)
Jordy Rose634c12d2011-06-15 05:52:56 +00002043 SR.markInUse(*si);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002044 }
2045}
2046
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00002047void CStringChecker::checkDeadSymbols(SymbolReaper &SR,
2048 CheckerContext &C) const {
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002049 if (!SR.hasDeadSymbols())
2050 return;
2051
Ted Kremenek49b1e382012-01-26 21:29:00 +00002052 ProgramStateRef state = C.getState();
Jordan Rose0c153cb2012-11-02 01:54:06 +00002053 CStringLengthTy Entries = state->get<CStringLength>();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002054 if (Entries.isEmpty())
2055 return;
2056
Jordan Rose0c153cb2012-11-02 01:54:06 +00002057 CStringLengthTy::Factory &F = state->get_context<CStringLength>();
2058 for (CStringLengthTy::iterator I = Entries.begin(), E = Entries.end();
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002059 I != E; ++I) {
2060 SVal Len = I.getData();
2061 if (SymbolRef Sym = Len.getAsSymbol()) {
2062 if (SR.isDead(Sym))
Ted Kremenekb3b56c62010-11-24 00:54:37 +00002063 Entries = F.remove(Entries, I.getKey());
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002064 }
2065 }
2066
2067 state = state->set<CStringLength>(Entries);
Anna Zaksda4c8d62011-10-26 21:06:34 +00002068 C.addTransition(state);
Jordy Rose2a2e21c2010-08-14 21:02:52 +00002069}
Argyrios Kyrtzidisc26f15d2011-02-24 01:05:30 +00002070
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002071#define REGISTER_CHECKER(name) \
2072 void ento::register##name(CheckerManager &mgr) { \
2073 CStringChecker *checker = mgr.registerChecker<CStringChecker>(); \
2074 checker->Filter.Check##name = true; \
2075 checker->Filter.CheckName##name = mgr.getCurrentCheckName(); \
2076 }
Anna Zakse0c7c272012-02-07 00:56:14 +00002077
2078REGISTER_CHECKER(CStringNullArg)
2079REGISTER_CHECKER(CStringOutOfBounds)
2080REGISTER_CHECKER(CStringBufferOverlap)
2081REGISTER_CHECKER(CStringNotNullTerm)
Anna Zakse56167e2012-02-17 22:35:31 +00002082
2083void ento::registerCStringCheckerBasic(CheckerManager &Mgr) {
2084 registerCStringNullArg(Mgr);
2085}