blob: 03fd4872a0a1b3741f04b16fe588e4c4c208ff9e [file] [log] [blame]
Sebastian Pop41774802016-07-15 13:45:20 +00001//===- GVNHoist.cpp - Hoist scalar and load expressions -------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This pass hoists expressions from branches to a common dominator. It uses
11// GVN (global value numbering) to discover expressions computing the same
Aditya Kumarf24939b2016-08-13 11:56:50 +000012// values. The primary goals of code-hoisting are:
13// 1. To reduce the code size.
14// 2. In some cases reduce critical path (by exposing more ILP).
15//
Sebastian Pop41774802016-07-15 13:45:20 +000016// Hoisting may affect the performance in some cases. To mitigate that, hoisting
17// is disabled in the following cases.
18// 1. Scalars across calls.
19// 2. geps when corresponding load/store cannot be hoisted.
20//===----------------------------------------------------------------------===//
21
22#include "llvm/ADT/DenseMap.h"
23#include "llvm/ADT/SmallPtrSet.h"
24#include "llvm/ADT/Statistic.h"
25#include "llvm/Analysis/ValueTracking.h"
26#include "llvm/Transforms/Scalar.h"
27#include "llvm/Transforms/Scalar/GVN.h"
David Majnemer68623a02016-07-25 02:21:25 +000028#include "llvm/Transforms/Utils/Local.h"
Sebastian Pop41774802016-07-15 13:45:20 +000029#include "llvm/Transforms/Utils/MemorySSA.h"
30
31using namespace llvm;
32
33#define DEBUG_TYPE "gvn-hoist"
34
35STATISTIC(NumHoisted, "Number of instructions hoisted");
36STATISTIC(NumRemoved, "Number of instructions removed");
37STATISTIC(NumLoadsHoisted, "Number of loads hoisted");
38STATISTIC(NumLoadsRemoved, "Number of loads removed");
39STATISTIC(NumStoresHoisted, "Number of stores hoisted");
40STATISTIC(NumStoresRemoved, "Number of stores removed");
41STATISTIC(NumCallsHoisted, "Number of calls hoisted");
42STATISTIC(NumCallsRemoved, "Number of calls removed");
43
44static cl::opt<int>
45 MaxHoistedThreshold("gvn-max-hoisted", cl::Hidden, cl::init(-1),
46 cl::desc("Max number of instructions to hoist "
47 "(default unlimited = -1)"));
48static cl::opt<int> MaxNumberOfBBSInPath(
49 "gvn-hoist-max-bbs", cl::Hidden, cl::init(4),
50 cl::desc("Max number of basic blocks on the path between "
51 "hoisting locations (default = 4, unlimited = -1)"));
52
Sebastian Pop38422b12016-07-26 00:15:08 +000053static cl::opt<int> MaxDepthInBB(
54 "gvn-hoist-max-depth", cl::Hidden, cl::init(100),
55 cl::desc("Hoist instructions from the beginning of the BB up to the "
56 "maximum specified depth (default = 100, unlimited = -1)"));
57
Sebastian Pop2aadad72016-08-03 20:54:38 +000058static cl::opt<int> MaxChainLength(
59 "gvn-hoist-max-chain-length", cl::Hidden, cl::init(10),
60 cl::desc("Maximum length of dependent chains to hoist "
61 "(default = 10, unlimited = -1)"));
62
Sebastian Pop41774802016-07-15 13:45:20 +000063namespace {
64
65// Provides a sorting function based on the execution order of two instructions.
66struct SortByDFSIn {
67private:
Sebastian Pop91d4a302016-07-26 00:15:10 +000068 DenseMap<const Value *, unsigned> &DFSNumber;
Sebastian Pop41774802016-07-15 13:45:20 +000069
70public:
Sebastian Pop91d4a302016-07-26 00:15:10 +000071 SortByDFSIn(DenseMap<const Value *, unsigned> &D) : DFSNumber(D) {}
Sebastian Pop41774802016-07-15 13:45:20 +000072
73 // Returns true when A executes before B.
74 bool operator()(const Instruction *A, const Instruction *B) const {
75 // FIXME: libc++ has a std::sort() algorithm that will call the compare
76 // function on the same element. Once PR20837 is fixed and some more years
77 // pass by and all the buildbots have moved to a corrected std::sort(),
78 // enable the following assert:
79 //
80 // assert(A != B);
81
Sebastian Pop4ba7c882016-08-03 20:54:36 +000082 const BasicBlock *BA = A->getParent();
83 const BasicBlock *BB = B->getParent();
84 unsigned ADFS, BDFS;
85 if (BA == BB) {
86 ADFS = DFSNumber.lookup(A);
87 BDFS = DFSNumber.lookup(B);
88 } else {
89 ADFS = DFSNumber.lookup(BA);
90 BDFS = DFSNumber.lookup(BB);
91 }
George Burgess IV9cf05462016-07-27 06:34:53 +000092 assert (ADFS && BDFS);
Sebastian Pop91d4a302016-07-26 00:15:10 +000093 return ADFS < BDFS;
Sebastian Pop41774802016-07-15 13:45:20 +000094 }
95};
96
David Majnemer04c7c222016-07-18 06:11:37 +000097// A map from a pair of VNs to all the instructions with those VNs.
98typedef DenseMap<std::pair<unsigned, unsigned>, SmallVector<Instruction *, 4>>
99 VNtoInsns;
100// An invalid value number Used when inserting a single value number into
101// VNtoInsns.
Reid Kleckner3498ad12016-07-18 18:53:50 +0000102enum : unsigned { InvalidVN = ~2U };
Sebastian Pop41774802016-07-15 13:45:20 +0000103
104// Records all scalar instructions candidate for code hoisting.
105class InsnInfo {
106 VNtoInsns VNtoScalars;
107
108public:
109 // Inserts I and its value number in VNtoScalars.
110 void insert(Instruction *I, GVN::ValueTable &VN) {
111 // Scalar instruction.
112 unsigned V = VN.lookupOrAdd(I);
David Majnemer04c7c222016-07-18 06:11:37 +0000113 VNtoScalars[{V, InvalidVN}].push_back(I);
Sebastian Pop41774802016-07-15 13:45:20 +0000114 }
115
116 const VNtoInsns &getVNTable() const { return VNtoScalars; }
117};
118
119// Records all load instructions candidate for code hoisting.
120class LoadInfo {
121 VNtoInsns VNtoLoads;
122
123public:
124 // Insert Load and the value number of its memory address in VNtoLoads.
125 void insert(LoadInst *Load, GVN::ValueTable &VN) {
126 if (Load->isSimple()) {
127 unsigned V = VN.lookupOrAdd(Load->getPointerOperand());
David Majnemer04c7c222016-07-18 06:11:37 +0000128 VNtoLoads[{V, InvalidVN}].push_back(Load);
Sebastian Pop41774802016-07-15 13:45:20 +0000129 }
130 }
131
132 const VNtoInsns &getVNTable() const { return VNtoLoads; }
133};
134
135// Records all store instructions candidate for code hoisting.
136class StoreInfo {
137 VNtoInsns VNtoStores;
138
139public:
140 // Insert the Store and a hash number of the store address and the stored
141 // value in VNtoStores.
142 void insert(StoreInst *Store, GVN::ValueTable &VN) {
143 if (!Store->isSimple())
144 return;
145 // Hash the store address and the stored value.
146 Value *Ptr = Store->getPointerOperand();
147 Value *Val = Store->getValueOperand();
David Majnemer04c7c222016-07-18 06:11:37 +0000148 VNtoStores[{VN.lookupOrAdd(Ptr), VN.lookupOrAdd(Val)}].push_back(Store);
Sebastian Pop41774802016-07-15 13:45:20 +0000149 }
150
151 const VNtoInsns &getVNTable() const { return VNtoStores; }
152};
153
154// Records all call instructions candidate for code hoisting.
155class CallInfo {
156 VNtoInsns VNtoCallsScalars;
157 VNtoInsns VNtoCallsLoads;
158 VNtoInsns VNtoCallsStores;
159
160public:
161 // Insert Call and its value numbering in one of the VNtoCalls* containers.
162 void insert(CallInst *Call, GVN::ValueTable &VN) {
163 // A call that doesNotAccessMemory is handled as a Scalar,
164 // onlyReadsMemory will be handled as a Load instruction,
165 // all other calls will be handled as stores.
166 unsigned V = VN.lookupOrAdd(Call);
David Majnemer04c7c222016-07-18 06:11:37 +0000167 auto Entry = std::make_pair(V, InvalidVN);
Sebastian Pop41774802016-07-15 13:45:20 +0000168
169 if (Call->doesNotAccessMemory())
David Majnemer04c7c222016-07-18 06:11:37 +0000170 VNtoCallsScalars[Entry].push_back(Call);
Sebastian Pop41774802016-07-15 13:45:20 +0000171 else if (Call->onlyReadsMemory())
David Majnemer04c7c222016-07-18 06:11:37 +0000172 VNtoCallsLoads[Entry].push_back(Call);
Sebastian Pop41774802016-07-15 13:45:20 +0000173 else
David Majnemer04c7c222016-07-18 06:11:37 +0000174 VNtoCallsStores[Entry].push_back(Call);
Sebastian Pop41774802016-07-15 13:45:20 +0000175 }
176
177 const VNtoInsns &getScalarVNTable() const { return VNtoCallsScalars; }
178
179 const VNtoInsns &getLoadVNTable() const { return VNtoCallsLoads; }
180
181 const VNtoInsns &getStoreVNTable() const { return VNtoCallsStores; }
182};
183
184typedef DenseMap<const BasicBlock *, bool> BBSideEffectsSet;
185typedef SmallVector<Instruction *, 4> SmallVecInsn;
186typedef SmallVectorImpl<Instruction *> SmallVecImplInsn;
187
David Majnemer68623a02016-07-25 02:21:25 +0000188static void combineKnownMetadata(Instruction *ReplInst, Instruction *I) {
189 static const unsigned KnownIDs[] = {
190 LLVMContext::MD_tbaa, LLVMContext::MD_alias_scope,
191 LLVMContext::MD_noalias, LLVMContext::MD_range,
192 LLVMContext::MD_fpmath, LLVMContext::MD_invariant_load,
193 LLVMContext::MD_invariant_group};
194 combineMetadata(ReplInst, I, KnownIDs);
195}
196
Sebastian Pop41774802016-07-15 13:45:20 +0000197// This pass hoists common computations across branches sharing common
198// dominator. The primary goal is to reduce the code size, and in some
199// cases reduce critical path (by exposing more ILP).
200class GVNHoist {
201public:
Daniel Berlinea02eee2016-08-23 05:42:41 +0000202 GVNHoist(DominatorTree *DT, AliasAnalysis *AA, MemoryDependenceResults *MD,
203 MemorySSA *MSSA, bool OptForMinSize)
204 : DT(DT), AA(AA), MD(MD), MSSA(MSSA), OptForMinSize(OptForMinSize),
Sebastian Pop55c30072016-07-27 05:48:12 +0000205 HoistingGeps(OptForMinSize), HoistedCtr(0) {}
Daniel Berlin65af45d2016-07-25 17:24:22 +0000206 bool run(Function &F) {
207 VN.setDomTree(DT);
208 VN.setAliasAnalysis(AA);
209 VN.setMemDep(MD);
210 bool Res = false;
Sebastian Pop4ba7c882016-08-03 20:54:36 +0000211 // Perform DFS Numbering of instructions.
212 unsigned BBI = 0;
213 for (const BasicBlock *BB : depth_first(&F.getEntryBlock())) {
214 DFSNumber[BB] = ++BBI;
215 unsigned I = 0;
216 for (auto &Inst: *BB)
217 DFSNumber[&Inst] = ++I;
218 }
Daniel Berlin65af45d2016-07-25 17:24:22 +0000219
Sebastian Pop2aadad72016-08-03 20:54:38 +0000220 int ChainLength = 0;
221
Daniel Berlin65af45d2016-07-25 17:24:22 +0000222 // FIXME: use lazy evaluation of VN to avoid the fix-point computation.
223 while (1) {
Sebastian Pop2aadad72016-08-03 20:54:38 +0000224 if (MaxChainLength != -1 && ++ChainLength >= MaxChainLength)
225 return Res;
226
Daniel Berlin65af45d2016-07-25 17:24:22 +0000227 auto HoistStat = hoistExpressions(F);
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000228 if (HoistStat.first + HoistStat.second == 0)
Daniel Berlin65af45d2016-07-25 17:24:22 +0000229 return Res;
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000230
231 if (HoistStat.second > 0)
Daniel Berlin65af45d2016-07-25 17:24:22 +0000232 // To address a limitation of the current GVN, we need to rerun the
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000233 // hoisting after we hoisted loads or stores in order to be able to
234 // hoist all scalars dependent on the hoisted ld/st.
Daniel Berlin65af45d2016-07-25 17:24:22 +0000235 VN.clear();
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000236
Daniel Berlin65af45d2016-07-25 17:24:22 +0000237 Res = true;
238 }
239
240 return Res;
241 }
242private:
Sebastian Pop41774802016-07-15 13:45:20 +0000243 GVN::ValueTable VN;
244 DominatorTree *DT;
245 AliasAnalysis *AA;
246 MemoryDependenceResults *MD;
Daniel Berlinea02eee2016-08-23 05:42:41 +0000247 MemorySSA *MSSA;
Sebastian Pop41774802016-07-15 13:45:20 +0000248 const bool OptForMinSize;
Sebastian Pop55c30072016-07-27 05:48:12 +0000249 const bool HoistingGeps;
Sebastian Pop91d4a302016-07-26 00:15:10 +0000250 DenseMap<const Value *, unsigned> DFSNumber;
Sebastian Pop41774802016-07-15 13:45:20 +0000251 BBSideEffectsSet BBSideEffects;
David Majnemeraa241782016-07-18 00:35:01 +0000252 int HoistedCtr;
253
Sebastian Pop41774802016-07-15 13:45:20 +0000254 enum InsKind { Unknown, Scalar, Load, Store };
255
Sebastian Pop41774802016-07-15 13:45:20 +0000256 // Return true when there are exception handling in BB.
257 bool hasEH(const BasicBlock *BB) {
258 auto It = BBSideEffects.find(BB);
259 if (It != BBSideEffects.end())
260 return It->second;
261
262 if (BB->isEHPad() || BB->hasAddressTaken()) {
263 BBSideEffects[BB] = true;
264 return true;
265 }
266
267 if (BB->getTerminator()->mayThrow()) {
268 BBSideEffects[BB] = true;
269 return true;
270 }
271
272 BBSideEffects[BB] = false;
273 return false;
274 }
275
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000276 // Return true when a successor of BB dominates A.
277 bool successorDominate(const BasicBlock *BB, const BasicBlock *A) {
278 for (const BasicBlock *Succ : BB->getTerminator()->successors())
279 if (DT->dominates(Succ, A))
280 return true;
Sebastian Pop41774802016-07-15 13:45:20 +0000281
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000282 return false;
283 }
284
285 // Return true when all paths from HoistBB to the end of the function pass
286 // through one of the blocks in WL.
287 bool hoistingFromAllPaths(const BasicBlock *HoistBB,
288 SmallPtrSetImpl<const BasicBlock *> &WL) {
289
290 // Copy WL as the loop will remove elements from it.
291 SmallPtrSet<const BasicBlock *, 2> WorkList(WL.begin(), WL.end());
292
293 for (auto It = df_begin(HoistBB), E = df_end(HoistBB); It != E;) {
294 // There exists a path from HoistBB to the exit of the function if we are
295 // still iterating in DF traversal and we removed all instructions from
296 // the work list.
297 if (WorkList.empty())
Sebastian Pop41774802016-07-15 13:45:20 +0000298 return false;
299
300 const BasicBlock *BB = *It;
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000301 if (WorkList.erase(BB)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000302 // Stop DFS traversal when BB is in the work list.
303 It.skipChildren();
304 continue;
305 }
306
307 // Check for end of function, calls that do not return, etc.
308 if (!isGuaranteedToTransferExecutionToSuccessor(BB->getTerminator()))
309 return false;
310
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000311 // When reaching the back-edge of a loop, there may be a path through the
312 // loop that does not pass through B or C before exiting the loop.
313 if (successorDominate(BB, HoistBB))
314 return false;
315
Sebastian Pop41774802016-07-15 13:45:20 +0000316 // Increment DFS traversal when not skipping children.
317 ++It;
318 }
319
320 return true;
321 }
322
323 /* Return true when I1 appears before I2 in the instructions of BB. */
Sebastian Pop91d4a302016-07-26 00:15:10 +0000324 bool firstInBB(const Instruction *I1, const Instruction *I2) {
325 assert (I1->getParent() == I2->getParent());
326 unsigned I1DFS = DFSNumber.lookup(I1);
327 unsigned I2DFS = DFSNumber.lookup(I2);
328 assert (I1DFS && I2DFS);
329 return I1DFS < I2DFS;
Daniel Berlin40765a62016-07-25 18:19:49 +0000330 }
Sebastian Pop91d4a302016-07-26 00:15:10 +0000331
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000332 // Return true when there are memory uses of Def in BB.
333 bool hasMemoryUseOnPath(const Instruction *NewPt, MemoryDef *Def, const BasicBlock *BB) {
334 const Instruction *OldPt = Def->getMemoryInst();
Sebastian Pop41774802016-07-15 13:45:20 +0000335 const BasicBlock *OldBB = OldPt->getParent();
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000336 const BasicBlock *NewBB = NewPt->getParent();
Sebastian Pop41774802016-07-15 13:45:20 +0000337
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000338 bool ReachedNewPt = false;
339 MemoryLocation DefLoc = MemoryLocation::get(OldPt);
340 const MemorySSA::AccessList *Acc = MSSA->getBlockAccesses(BB);
Sebastian Pop1531f302016-09-22 17:22:58 +0000341 if (!Acc)
342 return false;
343
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000344 for (const MemoryAccess &MA : *Acc) {
345 auto *MU = dyn_cast<MemoryUse>(&MA);
346 if (!MU)
347 continue;
Sebastian Pop41774802016-07-15 13:45:20 +0000348
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000349 // Do not check whether MU aliases Def when MU occurs after OldPt.
350 if (BB == OldBB && firstInBB(OldPt, MU->getMemoryInst()))
351 break;
352
353 // Do not check whether MU aliases Def when MU occurs before NewPt.
354 if (BB == NewBB) {
355 if (!ReachedNewPt) {
356 if (firstInBB(MU->getMemoryInst(), NewPt))
357 continue;
358 ReachedNewPt = true;
Sebastian Pop41774802016-07-15 13:45:20 +0000359 }
Sebastian Pop41774802016-07-15 13:45:20 +0000360 }
361
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000362 if (!AA->isNoAlias(DefLoc, MemoryLocation::get(MU->getMemoryInst())))
363 return true;
364 }
365
Sebastian Pop41774802016-07-15 13:45:20 +0000366 return false;
367 }
368
369 // Return true when there are exception handling or loads of memory Def
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000370 // between Def and NewPt. This function is only called for stores: Def is
371 // the MemoryDef of the store to be hoisted.
Sebastian Pop41774802016-07-15 13:45:20 +0000372
373 // Decrement by 1 NBBsOnAllPaths for each block between HoistPt and BB, and
374 // return true when the counter NBBsOnAllPaths reaces 0, except when it is
375 // initialized to -1 which is unlimited.
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000376 bool hasEHOrLoadsOnPath(const Instruction *NewPt, MemoryDef *Def,
377 int &NBBsOnAllPaths) {
Sebastian Pop41774802016-07-15 13:45:20 +0000378 const BasicBlock *NewBB = NewPt->getParent();
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000379 const BasicBlock *OldBB = Def->getBlock();
Sebastian Pop41774802016-07-15 13:45:20 +0000380 assert(DT->dominates(NewBB, OldBB) && "invalid path");
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000381 assert(DT->dominates(Def->getDefiningAccess()->getBlock(), NewBB) &&
Sebastian Pop41774802016-07-15 13:45:20 +0000382 "def does not dominate new hoisting point");
383
384 // Walk all basic blocks reachable in depth-first iteration on the inverse
385 // CFG from OldBB to NewBB. These blocks are all the blocks that may be
386 // executed between the execution of NewBB and OldBB. Hoisting an expression
387 // from OldBB into NewBB has to be safe on all execution paths.
388 for (auto I = idf_begin(OldBB), E = idf_end(OldBB); I != E;) {
389 if (*I == NewBB) {
390 // Stop traversal when reaching HoistPt.
391 I.skipChildren();
392 continue;
393 }
394
395 // Impossible to hoist with exceptions on the path.
396 if (hasEH(*I))
397 return true;
398
399 // Check that we do not move a store past loads.
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000400 if (hasMemoryUseOnPath(NewPt, Def, *I))
Sebastian Pop41774802016-07-15 13:45:20 +0000401 return true;
402
403 // Stop walk once the limit is reached.
404 if (NBBsOnAllPaths == 0)
405 return true;
406
407 // -1 is unlimited number of blocks on all paths.
408 if (NBBsOnAllPaths != -1)
409 --NBBsOnAllPaths;
410
411 ++I;
412 }
413
414 return false;
415 }
416
417 // Return true when there are exception handling between HoistPt and BB.
418 // Decrement by 1 NBBsOnAllPaths for each block between HoistPt and BB, and
419 // return true when the counter NBBsOnAllPaths reaches 0, except when it is
420 // initialized to -1 which is unlimited.
421 bool hasEHOnPath(const BasicBlock *HoistPt, const BasicBlock *BB,
422 int &NBBsOnAllPaths) {
423 assert(DT->dominates(HoistPt, BB) && "Invalid path");
424
425 // Walk all basic blocks reachable in depth-first iteration on
426 // the inverse CFG from BBInsn to NewHoistPt. These blocks are all the
427 // blocks that may be executed between the execution of NewHoistPt and
428 // BBInsn. Hoisting an expression from BBInsn into NewHoistPt has to be safe
429 // on all execution paths.
430 for (auto I = idf_begin(BB), E = idf_end(BB); I != E;) {
431 if (*I == HoistPt) {
432 // Stop traversal when reaching NewHoistPt.
433 I.skipChildren();
434 continue;
435 }
436
437 // Impossible to hoist with exceptions on the path.
438 if (hasEH(*I))
439 return true;
440
441 // Stop walk once the limit is reached.
442 if (NBBsOnAllPaths == 0)
443 return true;
444
445 // -1 is unlimited number of blocks on all paths.
446 if (NBBsOnAllPaths != -1)
447 --NBBsOnAllPaths;
448
449 ++I;
450 }
451
452 return false;
453 }
454
455 // Return true when it is safe to hoist a memory load or store U from OldPt
456 // to NewPt.
457 bool safeToHoistLdSt(const Instruction *NewPt, const Instruction *OldPt,
458 MemoryUseOrDef *U, InsKind K, int &NBBsOnAllPaths) {
459
460 // In place hoisting is safe.
461 if (NewPt == OldPt)
462 return true;
463
464 const BasicBlock *NewBB = NewPt->getParent();
465 const BasicBlock *OldBB = OldPt->getParent();
466 const BasicBlock *UBB = U->getBlock();
467
468 // Check for dependences on the Memory SSA.
469 MemoryAccess *D = U->getDefiningAccess();
470 BasicBlock *DBB = D->getBlock();
471 if (DT->properlyDominates(NewBB, DBB))
472 // Cannot move the load or store to NewBB above its definition in DBB.
473 return false;
474
475 if (NewBB == DBB && !MSSA->isLiveOnEntryDef(D))
David Majnemer4c66a712016-07-18 00:34:58 +0000476 if (auto *UD = dyn_cast<MemoryUseOrDef>(D))
Sebastian Pop91d4a302016-07-26 00:15:10 +0000477 if (firstInBB(NewPt, UD->getMemoryInst()))
Sebastian Pop41774802016-07-15 13:45:20 +0000478 // Cannot move the load or store to NewPt above its definition in D.
479 return false;
480
481 // Check for unsafe hoistings due to side effects.
482 if (K == InsKind::Store) {
Sebastian Pop8e6e3312016-09-22 15:33:51 +0000483 if (hasEHOrLoadsOnPath(NewPt, dyn_cast<MemoryDef>(U), NBBsOnAllPaths))
Sebastian Pop41774802016-07-15 13:45:20 +0000484 return false;
485 } else if (hasEHOnPath(NewBB, OldBB, NBBsOnAllPaths))
486 return false;
487
488 if (UBB == NewBB) {
489 if (DT->properlyDominates(DBB, NewBB))
490 return true;
491 assert(UBB == DBB);
492 assert(MSSA->locallyDominates(D, U));
493 }
494
495 // No side effects: it is safe to hoist.
496 return true;
497 }
498
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000499 // Return true when it is safe to hoist scalar instructions from all blocks in
500 // WL to HoistBB.
501 bool safeToHoistScalar(const BasicBlock *HoistBB,
502 SmallPtrSetImpl<const BasicBlock *> &WL,
503 int &NBBsOnAllPaths) {
504 // Check that the hoisted expression is needed on all paths. Enable scalar
505 // hoisting at -Oz as it is safe to hoist scalars to a place where they are
506 // partially needed.
507 if (!OptForMinSize && !hoistingFromAllPaths(HoistBB, WL))
Sebastian Pop41774802016-07-15 13:45:20 +0000508 return false;
509
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000510 for (const BasicBlock *BB : WL)
511 if (hasEHOnPath(HoistBB, BB, NBBsOnAllPaths))
512 return false;
Sebastian Pop41774802016-07-15 13:45:20 +0000513
Sebastian Pop41774802016-07-15 13:45:20 +0000514 return true;
515 }
516
517 // Each element of a hoisting list contains the basic block where to hoist and
518 // a list of instructions to be hoisted.
519 typedef std::pair<BasicBlock *, SmallVecInsn> HoistingPointInfo;
520 typedef SmallVector<HoistingPointInfo, 4> HoistingPointList;
521
522 // Partition InstructionsToHoist into a set of candidates which can share a
523 // common hoisting point. The partitions are collected in HPL. IsScalar is
524 // true when the instructions in InstructionsToHoist are scalars. IsLoad is
525 // true when the InstructionsToHoist are loads, false when they are stores.
526 void partitionCandidates(SmallVecImplInsn &InstructionsToHoist,
527 HoistingPointList &HPL, InsKind K) {
528 // No need to sort for two instructions.
529 if (InstructionsToHoist.size() > 2) {
530 SortByDFSIn Pred(DFSNumber);
531 std::sort(InstructionsToHoist.begin(), InstructionsToHoist.end(), Pred);
532 }
533
534 int NBBsOnAllPaths = MaxNumberOfBBSInPath;
535
536 SmallVecImplInsn::iterator II = InstructionsToHoist.begin();
537 SmallVecImplInsn::iterator Start = II;
538 Instruction *HoistPt = *II;
539 BasicBlock *HoistBB = HoistPt->getParent();
540 MemoryUseOrDef *UD;
541 if (K != InsKind::Scalar)
542 UD = cast<MemoryUseOrDef>(MSSA->getMemoryAccess(HoistPt));
543
544 for (++II; II != InstructionsToHoist.end(); ++II) {
545 Instruction *Insn = *II;
546 BasicBlock *BB = Insn->getParent();
547 BasicBlock *NewHoistBB;
548 Instruction *NewHoistPt;
549
550 if (BB == HoistBB) {
551 NewHoistBB = HoistBB;
Sebastian Pop91d4a302016-07-26 00:15:10 +0000552 NewHoistPt = firstInBB(Insn, HoistPt) ? Insn : HoistPt;
Sebastian Pop41774802016-07-15 13:45:20 +0000553 } else {
554 NewHoistBB = DT->findNearestCommonDominator(HoistBB, BB);
555 if (NewHoistBB == BB)
556 NewHoistPt = Insn;
557 else if (NewHoistBB == HoistBB)
558 NewHoistPt = HoistPt;
559 else
560 NewHoistPt = NewHoistBB->getTerminator();
561 }
562
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000563 SmallPtrSet<const BasicBlock *, 2> WL;
564 WL.insert(HoistBB);
565 WL.insert(BB);
566
Sebastian Pop41774802016-07-15 13:45:20 +0000567 if (K == InsKind::Scalar) {
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000568 if (safeToHoistScalar(NewHoistBB, WL, NBBsOnAllPaths)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000569 // Extend HoistPt to NewHoistPt.
570 HoistPt = NewHoistPt;
571 HoistBB = NewHoistBB;
572 continue;
573 }
574 } else {
575 // When NewBB already contains an instruction to be hoisted, the
576 // expression is needed on all paths.
577 // Check that the hoisted expression is needed on all paths: it is
578 // unsafe to hoist loads to a place where there may be a path not
579 // loading from the same address: for instance there may be a branch on
580 // which the address of the load may not be initialized.
581 if ((HoistBB == NewHoistBB || BB == NewHoistBB ||
Sebastian Pop5f0d0e62016-08-25 11:55:47 +0000582 hoistingFromAllPaths(NewHoistBB, WL)) &&
Sebastian Pop41774802016-07-15 13:45:20 +0000583 // Also check that it is safe to move the load or store from HoistPt
584 // to NewHoistPt, and from Insn to NewHoistPt.
585 safeToHoistLdSt(NewHoistPt, HoistPt, UD, K, NBBsOnAllPaths) &&
586 safeToHoistLdSt(NewHoistPt, Insn,
587 cast<MemoryUseOrDef>(MSSA->getMemoryAccess(Insn)),
588 K, NBBsOnAllPaths)) {
589 // Extend HoistPt to NewHoistPt.
590 HoistPt = NewHoistPt;
591 HoistBB = NewHoistBB;
592 continue;
593 }
594 }
595
596 // At this point it is not safe to extend the current hoisting to
597 // NewHoistPt: save the hoisting list so far.
598 if (std::distance(Start, II) > 1)
David Majnemer4c66a712016-07-18 00:34:58 +0000599 HPL.push_back({HoistBB, SmallVecInsn(Start, II)});
Sebastian Pop41774802016-07-15 13:45:20 +0000600
601 // Start over from BB.
602 Start = II;
603 if (K != InsKind::Scalar)
604 UD = cast<MemoryUseOrDef>(MSSA->getMemoryAccess(*Start));
605 HoistPt = Insn;
606 HoistBB = BB;
607 NBBsOnAllPaths = MaxNumberOfBBSInPath;
608 }
609
610 // Save the last partition.
611 if (std::distance(Start, II) > 1)
David Majnemer4c66a712016-07-18 00:34:58 +0000612 HPL.push_back({HoistBB, SmallVecInsn(Start, II)});
Sebastian Pop41774802016-07-15 13:45:20 +0000613 }
614
615 // Initialize HPL from Map.
616 void computeInsertionPoints(const VNtoInsns &Map, HoistingPointList &HPL,
617 InsKind K) {
David Majnemer4c66a712016-07-18 00:34:58 +0000618 for (const auto &Entry : Map) {
Sebastian Pop41774802016-07-15 13:45:20 +0000619 if (MaxHoistedThreshold != -1 && ++HoistedCtr > MaxHoistedThreshold)
620 return;
621
David Majnemer4c66a712016-07-18 00:34:58 +0000622 const SmallVecInsn &V = Entry.second;
Sebastian Pop41774802016-07-15 13:45:20 +0000623 if (V.size() < 2)
624 continue;
625
626 // Compute the insertion point and the list of expressions to be hoisted.
627 SmallVecInsn InstructionsToHoist;
628 for (auto I : V)
629 if (!hasEH(I->getParent()))
630 InstructionsToHoist.push_back(I);
631
David Majnemer4c66a712016-07-18 00:34:58 +0000632 if (!InstructionsToHoist.empty())
Sebastian Pop41774802016-07-15 13:45:20 +0000633 partitionCandidates(InstructionsToHoist, HPL, K);
634 }
635 }
636
637 // Return true when all operands of Instr are available at insertion point
638 // HoistPt. When limiting the number of hoisted expressions, one could hoist
639 // a load without hoisting its access function. So before hoisting any
640 // expression, make sure that all its operands are available at insert point.
641 bool allOperandsAvailable(const Instruction *I,
642 const BasicBlock *HoistPt) const {
David Majnemer4c66a712016-07-18 00:34:58 +0000643 for (const Use &Op : I->operands())
644 if (const auto *Inst = dyn_cast<Instruction>(&Op))
645 if (!DT->dominates(Inst->getParent(), HoistPt))
646 return false;
Sebastian Pop41774802016-07-15 13:45:20 +0000647
648 return true;
649 }
650
Sebastian Pop55c30072016-07-27 05:48:12 +0000651 // Same as allOperandsAvailable with recursive check for GEP operands.
652 bool allGepOperandsAvailable(const Instruction *I,
653 const BasicBlock *HoistPt) const {
654 for (const Use &Op : I->operands())
655 if (const auto *Inst = dyn_cast<Instruction>(&Op))
656 if (!DT->dominates(Inst->getParent(), HoistPt)) {
657 if (const GetElementPtrInst *GepOp = dyn_cast<GetElementPtrInst>(Inst)) {
658 if (!allGepOperandsAvailable(GepOp, HoistPt))
659 return false;
660 // Gep is available if all operands of GepOp are available.
661 } else {
662 // Gep is not available if it has operands other than GEPs that are
663 // defined in blocks not dominating HoistPt.
664 return false;
665 }
666 }
667 return true;
668 }
669
670 // Make all operands of the GEP available.
671 void makeGepsAvailable(Instruction *Repl, BasicBlock *HoistPt,
672 const SmallVecInsn &InstructionsToHoist,
673 Instruction *Gep) const {
674 assert(allGepOperandsAvailable(Gep, HoistPt) && "GEP operands not available");
675
676 Instruction *ClonedGep = Gep->clone();
677 for (unsigned i = 0, e = Gep->getNumOperands(); i != e; ++i)
678 if (Instruction *Op = dyn_cast<Instruction>(Gep->getOperand(i))) {
679
680 // Check whether the operand is already available.
681 if (DT->dominates(Op->getParent(), HoistPt))
682 continue;
683
684 // As a GEP can refer to other GEPs, recursively make all the operands
685 // of this GEP available at HoistPt.
686 if (GetElementPtrInst *GepOp = dyn_cast<GetElementPtrInst>(Op))
687 makeGepsAvailable(ClonedGep, HoistPt, InstructionsToHoist, GepOp);
688 }
689
690 // Copy Gep and replace its uses in Repl with ClonedGep.
691 ClonedGep->insertBefore(HoistPt->getTerminator());
692
693 // Conservatively discard any optimization hints, they may differ on the
694 // other paths.
695 ClonedGep->dropUnknownNonDebugMetadata();
696
697 // If we have optimization hints which agree with each other along different
698 // paths, preserve them.
699 for (const Instruction *OtherInst : InstructionsToHoist) {
700 const GetElementPtrInst *OtherGep;
701 if (auto *OtherLd = dyn_cast<LoadInst>(OtherInst))
702 OtherGep = cast<GetElementPtrInst>(OtherLd->getPointerOperand());
703 else
704 OtherGep = cast<GetElementPtrInst>(
705 cast<StoreInst>(OtherInst)->getPointerOperand());
Peter Collingbourne8f1dd5c2016-09-07 23:39:04 +0000706 ClonedGep->andIRFlags(OtherGep);
Sebastian Pop55c30072016-07-27 05:48:12 +0000707 }
708
709 // Replace uses of Gep with ClonedGep in Repl.
710 Repl->replaceUsesOfWith(Gep, ClonedGep);
711 }
712
713 // In the case Repl is a load or a store, we make all their GEPs
714 // available: GEPs are not hoisted by default to avoid the address
715 // computations to be hoisted without the associated load or store.
716 bool makeGepOperandsAvailable(Instruction *Repl, BasicBlock *HoistPt,
717 const SmallVecInsn &InstructionsToHoist) const {
Sebastian Pop41774802016-07-15 13:45:20 +0000718 // Check whether the GEP of a ld/st can be synthesized at HoistPt.
David Majnemerbd210122016-07-20 21:05:01 +0000719 GetElementPtrInst *Gep = nullptr;
Sebastian Pop41774802016-07-15 13:45:20 +0000720 Instruction *Val = nullptr;
Sebastian Pop55c30072016-07-27 05:48:12 +0000721 if (auto *Ld = dyn_cast<LoadInst>(Repl)) {
David Majnemerbd210122016-07-20 21:05:01 +0000722 Gep = dyn_cast<GetElementPtrInst>(Ld->getPointerOperand());
Sebastian Pop55c30072016-07-27 05:48:12 +0000723 } else if (auto *St = dyn_cast<StoreInst>(Repl)) {
David Majnemerbd210122016-07-20 21:05:01 +0000724 Gep = dyn_cast<GetElementPtrInst>(St->getPointerOperand());
Sebastian Pop41774802016-07-15 13:45:20 +0000725 Val = dyn_cast<Instruction>(St->getValueOperand());
Sebastian Pop31fd5062016-07-21 23:22:10 +0000726 // Check that the stored value is available.
Sebastian Pop0e2cec02016-07-22 00:07:01 +0000727 if (Val) {
728 if (isa<GetElementPtrInst>(Val)) {
729 // Check whether we can compute the GEP at HoistPt.
Sebastian Pop55c30072016-07-27 05:48:12 +0000730 if (!allGepOperandsAvailable(Val, HoistPt))
Sebastian Pop0e2cec02016-07-22 00:07:01 +0000731 return false;
732 } else if (!DT->dominates(Val->getParent(), HoistPt))
733 return false;
734 }
Sebastian Pop41774802016-07-15 13:45:20 +0000735 }
736
Sebastian Pop41774802016-07-15 13:45:20 +0000737 // Check whether we can compute the Gep at HoistPt.
Sebastian Pop55c30072016-07-27 05:48:12 +0000738 if (!Gep || !allGepOperandsAvailable(Gep, HoistPt))
Sebastian Pop41774802016-07-15 13:45:20 +0000739 return false;
740
Sebastian Pop55c30072016-07-27 05:48:12 +0000741 makeGepsAvailable(Repl, HoistPt, InstructionsToHoist, Gep);
Sebastian Pop41774802016-07-15 13:45:20 +0000742
Sebastian Pop55c30072016-07-27 05:48:12 +0000743 if (Val && isa<GetElementPtrInst>(Val))
744 makeGepsAvailable(Repl, HoistPt, InstructionsToHoist, Val);
Sebastian Pop41774802016-07-15 13:45:20 +0000745
746 return true;
747 }
748
749 std::pair<unsigned, unsigned> hoist(HoistingPointList &HPL) {
750 unsigned NI = 0, NL = 0, NS = 0, NC = 0, NR = 0;
751 for (const HoistingPointInfo &HP : HPL) {
752 // Find out whether we already have one of the instructions in HoistPt,
753 // in which case we do not have to move it.
754 BasicBlock *HoistPt = HP.first;
755 const SmallVecInsn &InstructionsToHoist = HP.second;
756 Instruction *Repl = nullptr;
757 for (Instruction *I : InstructionsToHoist)
Sebastian Pop586d3ea2016-07-27 05:13:52 +0000758 if (I->getParent() == HoistPt)
Sebastian Pop41774802016-07-15 13:45:20 +0000759 // If there are two instructions in HoistPt to be hoisted in place:
760 // update Repl to be the first one, such that we can rename the uses
761 // of the second based on the first.
Sebastian Pop586d3ea2016-07-27 05:13:52 +0000762 if (!Repl || firstInBB(I, Repl))
763 Repl = I;
Sebastian Pop41774802016-07-15 13:45:20 +0000764
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000765 // Keep track of whether we moved the instruction so we know whether we
766 // should move the MemoryAccess.
767 bool MoveAccess = true;
Sebastian Pop41774802016-07-15 13:45:20 +0000768 if (Repl) {
769 // Repl is already in HoistPt: it remains in place.
770 assert(allOperandsAvailable(Repl, HoistPt) &&
771 "instruction depends on operands that are not available");
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000772 MoveAccess = false;
Sebastian Pop41774802016-07-15 13:45:20 +0000773 } else {
774 // When we do not find Repl in HoistPt, select the first in the list
775 // and move it to HoistPt.
776 Repl = InstructionsToHoist.front();
777
778 // We can move Repl in HoistPt only when all operands are available.
779 // The order in which hoistings are done may influence the availability
780 // of operands.
Sebastian Pop429740a2016-08-04 23:49:05 +0000781 if (!allOperandsAvailable(Repl, HoistPt)) {
782
783 // When HoistingGeps there is nothing more we can do to make the
784 // operands available: just continue.
785 if (HoistingGeps)
786 continue;
787
788 // When not HoistingGeps we need to copy the GEPs.
789 if (!makeGepOperandsAvailable(Repl, HoistPt, InstructionsToHoist))
790 continue;
791 }
Sebastian Pop55c30072016-07-27 05:48:12 +0000792
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000793 // Move the instruction at the end of HoistPt.
Sebastian Pop4ba7c882016-08-03 20:54:36 +0000794 Instruction *Last = HoistPt->getTerminator();
795 Repl->moveBefore(Last);
796
797 DFSNumber[Repl] = DFSNumber[Last]++;
Sebastian Pop41774802016-07-15 13:45:20 +0000798 }
799
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000800 MemoryAccess *NewMemAcc = MSSA->getMemoryAccess(Repl);
801
802 if (MoveAccess) {
803 if (MemoryUseOrDef *OldMemAcc =
804 dyn_cast_or_null<MemoryUseOrDef>(NewMemAcc)) {
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000805 // The definition of this ld/st will not change: ld/st hoisting is
806 // legal when the ld/st is not moved past its current definition.
807 MemoryAccess *Def = OldMemAcc->getDefiningAccess();
Daniel Berlinf75fd1b2016-08-11 20:32:43 +0000808 NewMemAcc =
809 MSSA->createMemoryAccessInBB(Repl, Def, HoistPt, MemorySSA::End);
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000810 OldMemAcc->replaceAllUsesWith(NewMemAcc);
811 MSSA->removeMemoryAccess(OldMemAcc);
812 }
813 }
814
Sebastian Pop41774802016-07-15 13:45:20 +0000815 if (isa<LoadInst>(Repl))
816 ++NL;
817 else if (isa<StoreInst>(Repl))
818 ++NS;
819 else if (isa<CallInst>(Repl))
820 ++NC;
821 else // Scalar
822 ++NI;
823
824 // Remove and rename all other instructions.
825 for (Instruction *I : InstructionsToHoist)
826 if (I != Repl) {
827 ++NR;
David Majnemer47285692016-07-25 02:21:23 +0000828 if (auto *ReplacementLoad = dyn_cast<LoadInst>(Repl)) {
829 ReplacementLoad->setAlignment(
830 std::min(ReplacementLoad->getAlignment(),
831 cast<LoadInst>(I)->getAlignment()));
Sebastian Pop41774802016-07-15 13:45:20 +0000832 ++NumLoadsRemoved;
David Majnemer47285692016-07-25 02:21:23 +0000833 } else if (auto *ReplacementStore = dyn_cast<StoreInst>(Repl)) {
834 ReplacementStore->setAlignment(
835 std::min(ReplacementStore->getAlignment(),
836 cast<StoreInst>(I)->getAlignment()));
Sebastian Pop41774802016-07-15 13:45:20 +0000837 ++NumStoresRemoved;
David Majnemer47285692016-07-25 02:21:23 +0000838 } else if (auto *ReplacementAlloca = dyn_cast<AllocaInst>(Repl)) {
839 ReplacementAlloca->setAlignment(
840 std::max(ReplacementAlloca->getAlignment(),
841 cast<AllocaInst>(I)->getAlignment()));
842 } else if (isa<CallInst>(Repl)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000843 ++NumCallsRemoved;
David Majnemer47285692016-07-25 02:21:23 +0000844 }
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000845
846 if (NewMemAcc) {
847 // Update the uses of the old MSSA access with NewMemAcc.
848 MemoryAccess *OldMA = MSSA->getMemoryAccess(I);
849 OldMA->replaceAllUsesWith(NewMemAcc);
850 MSSA->removeMemoryAccess(OldMA);
851 }
852
Peter Collingbourne8f1dd5c2016-09-07 23:39:04 +0000853 Repl->andIRFlags(I);
David Majnemer68623a02016-07-25 02:21:25 +0000854 combineKnownMetadata(Repl, I);
Sebastian Pop41774802016-07-15 13:45:20 +0000855 I->replaceAllUsesWith(Repl);
Sebastian Pop46601992016-08-27 02:48:41 +0000856 // Also invalidate the Alias Analysis cache.
857 MD->removeInstruction(I);
Sebastian Pop41774802016-07-15 13:45:20 +0000858 I->eraseFromParent();
859 }
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000860
861 // Remove MemorySSA phi nodes with the same arguments.
862 if (NewMemAcc) {
863 SmallPtrSet<MemoryPhi *, 4> UsePhis;
864 for (User *U : NewMemAcc->users())
865 if (MemoryPhi *Phi = dyn_cast<MemoryPhi>(U))
866 UsePhis.insert(Phi);
867
868 for (auto *Phi : UsePhis) {
869 auto In = Phi->incoming_values();
David Majnemer0a16c222016-08-11 21:15:00 +0000870 if (all_of(In, [&](Use &U) { return U == NewMemAcc; })) {
Sebastian Pop5d3822f2016-08-03 20:54:33 +0000871 Phi->replaceAllUsesWith(NewMemAcc);
872 MSSA->removeMemoryAccess(Phi);
873 }
874 }
875 }
Sebastian Pop41774802016-07-15 13:45:20 +0000876 }
877
878 NumHoisted += NL + NS + NC + NI;
879 NumRemoved += NR;
880 NumLoadsHoisted += NL;
881 NumStoresHoisted += NS;
882 NumCallsHoisted += NC;
883 return {NI, NL + NC + NS};
884 }
885
886 // Hoist all expressions. Returns Number of scalars hoisted
887 // and number of non-scalars hoisted.
888 std::pair<unsigned, unsigned> hoistExpressions(Function &F) {
889 InsnInfo II;
890 LoadInfo LI;
891 StoreInfo SI;
892 CallInfo CI;
893 for (BasicBlock *BB : depth_first(&F.getEntryBlock())) {
Sebastian Pop38422b12016-07-26 00:15:08 +0000894 int InstructionNb = 0;
Sebastian Pop41774802016-07-15 13:45:20 +0000895 for (Instruction &I1 : *BB) {
Sebastian Pop38422b12016-07-26 00:15:08 +0000896 // Only hoist the first instructions in BB up to MaxDepthInBB. Hoisting
897 // deeper may increase the register pressure and compilation time.
898 if (MaxDepthInBB != -1 && InstructionNb++ >= MaxDepthInBB)
899 break;
900
Sebastian Pop440f15b2016-09-22 14:45:40 +0000901 // Do not value number terminator instructions.
Sebastian Pop5d68aa72016-09-22 15:08:09 +0000902 if (isa<TerminatorInst>(&I1))
Sebastian Pop440f15b2016-09-22 14:45:40 +0000903 break;
904
David Majnemer4c66a712016-07-18 00:34:58 +0000905 if (auto *Load = dyn_cast<LoadInst>(&I1))
Sebastian Pop41774802016-07-15 13:45:20 +0000906 LI.insert(Load, VN);
David Majnemer4c66a712016-07-18 00:34:58 +0000907 else if (auto *Store = dyn_cast<StoreInst>(&I1))
Sebastian Pop41774802016-07-15 13:45:20 +0000908 SI.insert(Store, VN);
David Majnemer4c66a712016-07-18 00:34:58 +0000909 else if (auto *Call = dyn_cast<CallInst>(&I1)) {
910 if (auto *Intr = dyn_cast<IntrinsicInst>(Call)) {
Sebastian Pop41774802016-07-15 13:45:20 +0000911 if (isa<DbgInfoIntrinsic>(Intr) ||
912 Intr->getIntrinsicID() == Intrinsic::assume)
913 continue;
914 }
915 if (Call->mayHaveSideEffects()) {
916 if (!OptForMinSize)
917 break;
918 // We may continue hoisting across calls which write to memory.
919 if (Call->mayThrow())
920 break;
921 }
Matt Arsenault6ad97732016-08-04 20:52:57 +0000922
923 if (Call->isConvergent())
924 break;
925
Sebastian Pop41774802016-07-15 13:45:20 +0000926 CI.insert(Call, VN);
Sebastian Pop55c30072016-07-27 05:48:12 +0000927 } else if (HoistingGeps || !isa<GetElementPtrInst>(&I1))
Sebastian Pop41774802016-07-15 13:45:20 +0000928 // Do not hoist scalars past calls that may write to memory because
929 // that could result in spills later. geps are handled separately.
930 // TODO: We can relax this for targets like AArch64 as they have more
931 // registers than X86.
932 II.insert(&I1, VN);
933 }
934 }
935
936 HoistingPointList HPL;
937 computeInsertionPoints(II.getVNTable(), HPL, InsKind::Scalar);
938 computeInsertionPoints(LI.getVNTable(), HPL, InsKind::Load);
939 computeInsertionPoints(SI.getVNTable(), HPL, InsKind::Store);
940 computeInsertionPoints(CI.getScalarVNTable(), HPL, InsKind::Scalar);
941 computeInsertionPoints(CI.getLoadVNTable(), HPL, InsKind::Load);
942 computeInsertionPoints(CI.getStoreVNTable(), HPL, InsKind::Store);
943 return hoist(HPL);
944 }
Sebastian Pop41774802016-07-15 13:45:20 +0000945};
946
947class GVNHoistLegacyPass : public FunctionPass {
948public:
949 static char ID;
950
951 GVNHoistLegacyPass() : FunctionPass(ID) {
952 initializeGVNHoistLegacyPassPass(*PassRegistry::getPassRegistry());
953 }
954
955 bool runOnFunction(Function &F) override {
Paul Robinson2d23c022016-07-19 22:57:14 +0000956 if (skipFunction(F))
957 return false;
Sebastian Pop41774802016-07-15 13:45:20 +0000958 auto &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
959 auto &AA = getAnalysis<AAResultsWrapperPass>().getAAResults();
960 auto &MD = getAnalysis<MemoryDependenceWrapperPass>().getMemDep();
Daniel Berlinea02eee2016-08-23 05:42:41 +0000961 auto &MSSA = getAnalysis<MemorySSAWrapperPass>().getMSSA();
Sebastian Pop41774802016-07-15 13:45:20 +0000962
Daniel Berlinea02eee2016-08-23 05:42:41 +0000963 GVNHoist G(&DT, &AA, &MD, &MSSA, F.optForMinSize());
Sebastian Pop41774802016-07-15 13:45:20 +0000964 return G.run(F);
965 }
966
967 void getAnalysisUsage(AnalysisUsage &AU) const override {
968 AU.addRequired<DominatorTreeWrapperPass>();
969 AU.addRequired<AAResultsWrapperPass>();
970 AU.addRequired<MemoryDependenceWrapperPass>();
Daniel Berlinea02eee2016-08-23 05:42:41 +0000971 AU.addRequired<MemorySSAWrapperPass>();
Sebastian Pop41774802016-07-15 13:45:20 +0000972 AU.addPreserved<DominatorTreeWrapperPass>();
Daniel Berlinea02eee2016-08-23 05:42:41 +0000973 AU.addPreserved<MemorySSAWrapperPass>();
Sebastian Pop41774802016-07-15 13:45:20 +0000974 }
975};
976} // namespace
977
978PreservedAnalyses GVNHoistPass::run(Function &F,
Sean Silva36e0d012016-08-09 00:28:15 +0000979 FunctionAnalysisManager &AM) {
Sebastian Pop41774802016-07-15 13:45:20 +0000980 DominatorTree &DT = AM.getResult<DominatorTreeAnalysis>(F);
981 AliasAnalysis &AA = AM.getResult<AAManager>(F);
982 MemoryDependenceResults &MD = AM.getResult<MemoryDependenceAnalysis>(F);
Daniel Berlinea02eee2016-08-23 05:42:41 +0000983 MemorySSA &MSSA = AM.getResult<MemorySSAAnalysis>(F).getMSSA();
984 GVNHoist G(&DT, &AA, &MD, &MSSA, F.optForMinSize());
Sebastian Pop41774802016-07-15 13:45:20 +0000985 if (!G.run(F))
986 return PreservedAnalyses::all();
987
988 PreservedAnalyses PA;
989 PA.preserve<DominatorTreeAnalysis>();
Daniel Berlinea02eee2016-08-23 05:42:41 +0000990 PA.preserve<MemorySSAAnalysis>();
Sebastian Pop41774802016-07-15 13:45:20 +0000991 return PA;
992}
993
994char GVNHoistLegacyPass::ID = 0;
995INITIALIZE_PASS_BEGIN(GVNHoistLegacyPass, "gvn-hoist",
996 "Early GVN Hoisting of Expressions", false, false)
997INITIALIZE_PASS_DEPENDENCY(MemoryDependenceWrapperPass)
Daniel Berlinea02eee2016-08-23 05:42:41 +0000998INITIALIZE_PASS_DEPENDENCY(MemorySSAWrapperPass)
Sebastian Pop41774802016-07-15 13:45:20 +0000999INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
1000INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
1001INITIALIZE_PASS_END(GVNHoistLegacyPass, "gvn-hoist",
1002 "Early GVN Hoisting of Expressions", false, false)
1003
1004FunctionPass *llvm::createGVNHoistPass() { return new GVNHoistLegacyPass(); }