Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 1 | //===- SymbolTable.cpp ----------------------------------------------------===// |
| 2 | // |
Chandler Carruth | 2946cd7 | 2019-01-19 08:50:56 +0000 | [diff] [blame] | 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 6 | // |
| 7 | //===----------------------------------------------------------------------===// |
| 8 | |
| 9 | #include "SymbolTable.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 10 | #include "Config.h" |
Sam Clegg | 5fa274b | 2018-01-10 01:13:34 +0000 | [diff] [blame] | 11 | #include "InputChunks.h" |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 12 | #include "InputEvent.h" |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 13 | #include "InputGlobal.h" |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 14 | #include "WriterUtils.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 15 | #include "lld/Common/ErrorHandler.h" |
Rui Ueyama | 2017d52 | 2017-11-28 20:39:17 +0000 | [diff] [blame] | 16 | #include "lld/Common/Memory.h" |
Rui Ueyama | 7d67dd1 | 2018-02-13 22:30:52 +0000 | [diff] [blame] | 17 | #include "llvm/ADT/SetVector.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 18 | |
| 19 | #define DEBUG_TYPE "lld" |
| 20 | |
| 21 | using namespace llvm; |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 22 | using namespace llvm::wasm; |
Sam Clegg | 45218f4 | 2018-11-27 01:08:16 +0000 | [diff] [blame] | 23 | using namespace llvm::object; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 24 | |
Fangrui Song | 33c59ab | 2019-10-10 05:25:39 +0000 | [diff] [blame] | 25 | namespace lld { |
| 26 | namespace wasm { |
| 27 | SymbolTable *symtab; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 28 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 29 | void SymbolTable::addFile(InputFile *file) { |
| 30 | log("Processing: " + toString(file)); |
Sam Clegg | a282a61 | 2019-06-05 17:50:45 +0000 | [diff] [blame] | 31 | |
| 32 | // .a file |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 33 | if (auto *f = dyn_cast<ArchiveFile>(file)) { |
| 34 | f->parse(); |
Sam Clegg | a282a61 | 2019-06-05 17:50:45 +0000 | [diff] [blame] | 35 | return; |
| 36 | } |
| 37 | |
| 38 | // .so file |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 39 | if (auto *f = dyn_cast<SharedFile>(file)) { |
| 40 | sharedFiles.push_back(f); |
Sam Clegg | a282a61 | 2019-06-05 17:50:45 +0000 | [diff] [blame] | 41 | return; |
| 42 | } |
| 43 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 44 | if (config->trace) |
| 45 | message(toString(file)); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 46 | |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 47 | // LLVM bitcode file |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 48 | if (auto *f = dyn_cast<BitcodeFile>(file)) { |
| 49 | f->parse(); |
| 50 | bitcodeFiles.push_back(f); |
Sam Clegg | a282a61 | 2019-06-05 17:50:45 +0000 | [diff] [blame] | 51 | return; |
| 52 | } |
| 53 | |
| 54 | // Regular object file |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 55 | auto *f = cast<ObjFile>(file); |
| 56 | f->parse(false); |
| 57 | objectFiles.push_back(f); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 58 | } |
| 59 | |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 60 | // This function is where all the optimizations of link-time |
| 61 | // optimization happens. When LTO is in use, some input files are |
| 62 | // not in native object file format but in the LLVM bitcode format. |
| 63 | // This function compiles bitcode files into a few big native files |
| 64 | // using LLVM functions and replaces bitcode symbols with the results. |
| 65 | // Because all bitcode files that the program consists of are passed |
| 66 | // to the compiler at once, it can do whole-program optimization. |
| 67 | void SymbolTable::addCombinedLTOObject() { |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 68 | if (bitcodeFiles.empty()) |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 69 | return; |
| 70 | |
| 71 | // Compile bitcode files and replace bitcode symbols. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 72 | lto.reset(new BitcodeCompiler); |
| 73 | for (BitcodeFile *f : bitcodeFiles) |
| 74 | lto->add(*f); |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 75 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 76 | for (StringRef filename : lto->compile()) { |
| 77 | auto *obj = make<ObjFile>(MemoryBufferRef(filename, "lto.tmp"), ""); |
| 78 | obj->parse(true); |
| 79 | objectFiles.push_back(obj); |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 80 | } |
| 81 | } |
| 82 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 83 | Symbol *SymbolTable::find(StringRef name) { |
| 84 | auto it = symMap.find(CachedHashStringRef(name)); |
| 85 | if (it == symMap.end() || it->second == -1) |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 86 | return nullptr; |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 87 | return symVector[it->second]; |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 88 | } |
| 89 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 90 | void SymbolTable::replace(StringRef name, Symbol* sym) { |
| 91 | auto it = symMap.find(CachedHashStringRef(name)); |
| 92 | symVector[it->second] = sym; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 93 | } |
| 94 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 95 | std::pair<Symbol *, bool> SymbolTable::insertName(StringRef name) { |
| 96 | bool trace = false; |
| 97 | auto p = symMap.insert({CachedHashStringRef(name), (int)symVector.size()}); |
| 98 | int &symIndex = p.first->second; |
| 99 | bool isNew = p.second; |
| 100 | if (symIndex == -1) { |
| 101 | symIndex = symVector.size(); |
| 102 | trace = true; |
| 103 | isNew = true; |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 104 | } |
| 105 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 106 | if (!isNew) |
| 107 | return {symVector[symIndex], false}; |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 108 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 109 | Symbol *sym = reinterpret_cast<Symbol *>(make<SymbolUnion>()); |
| 110 | sym->isUsedInRegularObj = false; |
| 111 | sym->canInline = true; |
| 112 | sym->traced = trace; |
| 113 | symVector.emplace_back(sym); |
| 114 | return {sym, true}; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 115 | } |
| 116 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 117 | std::pair<Symbol *, bool> SymbolTable::insert(StringRef name, |
| 118 | const InputFile *file) { |
| 119 | Symbol *s; |
| 120 | bool wasInserted; |
| 121 | std::tie(s, wasInserted) = insertName(name); |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 122 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 123 | if (!file || file->kind() == InputFile::ObjectKind) |
| 124 | s->isUsedInRegularObj = true; |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 125 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 126 | return {s, wasInserted}; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 127 | } |
| 128 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 129 | static void reportTypeError(const Symbol *existing, const InputFile *file, |
| 130 | llvm::wasm::WasmSymbolType type) { |
| 131 | error("symbol type mismatch: " + toString(*existing) + "\n>>> defined as " + |
| 132 | toString(existing->getWasmType()) + " in " + |
| 133 | toString(existing->getFile()) + "\n>>> defined as " + toString(type) + |
| 134 | " in " + toString(file)); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 135 | } |
| 136 | |
Heejin Ahn | 6f4286f | 2018-11-19 23:31:28 +0000 | [diff] [blame] | 137 | // Check the type of new symbol matches that of the symbol is replacing. |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 138 | // Returns true if the function types match, false is there is a singature |
| 139 | // mismatch. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 140 | static bool signatureMatches(FunctionSymbol *existing, |
| 141 | const WasmSignature *newSig) { |
| 142 | const WasmSignature *oldSig = existing->signature; |
Sam Clegg | d506b0a | 2019-05-29 15:36:42 +0000 | [diff] [blame] | 143 | |
| 144 | // If either function is missing a signature (this happend for bitcode |
| 145 | // symbols) then assume they match. Any mismatch will be reported later |
| 146 | // when the LTO objects are added. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 147 | if (!newSig || !oldSig) |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 148 | return true; |
Sam Clegg | cefbf9a | 2018-06-28 16:53:53 +0000 | [diff] [blame] | 149 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 150 | return *newSig == *oldSig; |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 151 | } |
| 152 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 153 | static void checkGlobalType(const Symbol *existing, const InputFile *file, |
| 154 | const WasmGlobalType *newType) { |
| 155 | if (!isa<GlobalSymbol>(existing)) { |
| 156 | reportTypeError(existing, file, WASM_SYMBOL_TYPE_GLOBAL); |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 157 | return; |
| 158 | } |
| 159 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 160 | const WasmGlobalType *oldType = cast<GlobalSymbol>(existing)->getGlobalType(); |
| 161 | if (*newType != *oldType) { |
| 162 | error("Global type mismatch: " + existing->getName() + "\n>>> defined as " + |
| 163 | toString(*oldType) + " in " + toString(existing->getFile()) + |
| 164 | "\n>>> defined as " + toString(*newType) + " in " + toString(file)); |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 165 | } |
Sam Clegg | 24b3dcd | 2018-01-28 19:57:01 +0000 | [diff] [blame] | 166 | } |
| 167 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 168 | static void checkEventType(const Symbol *existing, const InputFile *file, |
| 169 | const WasmEventType *newType, |
| 170 | const WasmSignature *newSig) { |
| 171 | auto existingEvent = dyn_cast<EventSymbol>(existing); |
| 172 | if (!isa<EventSymbol>(existing)) { |
| 173 | reportTypeError(existing, file, WASM_SYMBOL_TYPE_EVENT); |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 174 | return; |
| 175 | } |
| 176 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 177 | const WasmEventType *oldType = cast<EventSymbol>(existing)->getEventType(); |
| 178 | const WasmSignature *oldSig = existingEvent->signature; |
| 179 | if (newType->Attribute != oldType->Attribute) |
| 180 | error("Event type mismatch: " + existing->getName() + "\n>>> defined as " + |
| 181 | toString(*oldType) + " in " + toString(existing->getFile()) + |
| 182 | "\n>>> defined as " + toString(*newType) + " in " + toString(file)); |
| 183 | if (*newSig != *oldSig) |
| 184 | warn("Event signature mismatch: " + existing->getName() + |
| 185 | "\n>>> defined as " + toString(*oldSig) + " in " + |
| 186 | toString(existing->getFile()) + "\n>>> defined as " + |
| 187 | toString(*newSig) + " in " + toString(file)); |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 188 | } |
| 189 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 190 | static void checkDataType(const Symbol *existing, const InputFile *file) { |
| 191 | if (!isa<DataSymbol>(existing)) |
| 192 | reportTypeError(existing, file, WASM_SYMBOL_TYPE_DATA); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 193 | } |
| 194 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 195 | DefinedFunction *SymbolTable::addSyntheticFunction(StringRef name, |
| 196 | uint32_t flags, |
| 197 | InputFunction *function) { |
| 198 | LLVM_DEBUG(dbgs() << "addSyntheticFunction: " << name << "\n"); |
| 199 | assert(!find(name)); |
| 200 | syntheticFunctions.emplace_back(function); |
| 201 | return replaceSymbol<DefinedFunction>(insertName(name).first, name, |
| 202 | flags, nullptr, function); |
Sam Clegg | 5068685 | 2018-01-12 18:35:13 +0000 | [diff] [blame] | 203 | } |
| 204 | |
Sam Clegg | 8e8ddaa | 2019-06-04 16:35:23 +0000 | [diff] [blame] | 205 | // Adds an optional, linker generated, data symbols. The symbol will only be |
Kazuaki Ishizaki | 7ae3d33 | 2020-01-06 10:21:05 -0800 | [diff] [blame] | 206 | // added if there is an undefine reference to it, or if it is explicitly |
| 207 | // exported via the --export flag. Otherwise we don't add the symbol and return |
| 208 | // nullptr. |
Sam Clegg | caa0db1 | 2019-08-08 16:58:36 +0000 | [diff] [blame] | 209 | DefinedData *SymbolTable::addOptionalDataSymbol(StringRef name, |
| 210 | uint32_t value) { |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 211 | Symbol *s = find(name); |
| 212 | if (!s && (config->exportAll || config->exportedSymbols.count(name) != 0)) |
| 213 | s = insertName(name).first; |
| 214 | else if (!s || s->isDefined()) |
Sam Clegg | 4bce63a | 2019-05-23 10:06:03 +0000 | [diff] [blame] | 215 | return nullptr; |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 216 | LLVM_DEBUG(dbgs() << "addOptionalDataSymbol: " << name << "\n"); |
Sam Clegg | caa0db1 | 2019-08-08 16:58:36 +0000 | [diff] [blame] | 217 | auto *rtn = replaceSymbol<DefinedData>(s, name, WASM_SYMBOL_VISIBILITY_HIDDEN); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 218 | rtn->setVirtualAddress(value); |
| 219 | rtn->referenced = true; |
Sam Clegg | 4bce63a | 2019-05-23 10:06:03 +0000 | [diff] [blame] | 220 | return rtn; |
| 221 | } |
| 222 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 223 | DefinedData *SymbolTable::addSyntheticDataSymbol(StringRef name, |
| 224 | uint32_t flags) { |
| 225 | LLVM_DEBUG(dbgs() << "addSyntheticDataSymbol: " << name << "\n"); |
| 226 | assert(!find(name)); |
| 227 | return replaceSymbol<DefinedData>(insertName(name).first, name, flags); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 228 | } |
| 229 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 230 | DefinedGlobal *SymbolTable::addSyntheticGlobal(StringRef name, uint32_t flags, |
| 231 | InputGlobal *global) { |
| 232 | LLVM_DEBUG(dbgs() << "addSyntheticGlobal: " << name << " -> " << global |
Nicola Zaghen | e7245b4 | 2018-05-15 13:36:20 +0000 | [diff] [blame] | 233 | << "\n"); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 234 | assert(!find(name)); |
| 235 | syntheticGlobals.emplace_back(global); |
| 236 | return replaceSymbol<DefinedGlobal>(insertName(name).first, name, flags, |
| 237 | nullptr, global); |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 238 | } |
| 239 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 240 | static bool shouldReplace(const Symbol *existing, InputFile *newFile, |
| 241 | uint32_t newFlags) { |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 242 | // If existing symbol is undefined, replace it. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 243 | if (!existing->isDefined()) { |
Nicola Zaghen | e7245b4 | 2018-05-15 13:36:20 +0000 | [diff] [blame] | 244 | LLVM_DEBUG(dbgs() << "resolving existing undefined symbol: " |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 245 | << existing->getName() << "\n"); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 246 | return true; |
| 247 | } |
| 248 | |
| 249 | // Now we have two defined symbols. If the new one is weak, we can ignore it. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 250 | if ((newFlags & WASM_SYMBOL_BINDING_MASK) == WASM_SYMBOL_BINDING_WEAK) { |
Nicola Zaghen | e7245b4 | 2018-05-15 13:36:20 +0000 | [diff] [blame] | 251 | LLVM_DEBUG(dbgs() << "existing symbol takes precedence\n"); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 252 | return false; |
| 253 | } |
| 254 | |
| 255 | // If the existing symbol is weak, we should replace it. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 256 | if (existing->isWeak()) { |
Nicola Zaghen | e7245b4 | 2018-05-15 13:36:20 +0000 | [diff] [blame] | 257 | LLVM_DEBUG(dbgs() << "replacing existing weak symbol\n"); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 258 | return true; |
| 259 | } |
| 260 | |
| 261 | // Neither symbol is week. They conflict. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 262 | error("duplicate symbol: " + toString(*existing) + "\n>>> defined in " + |
| 263 | toString(existing->getFile()) + "\n>>> defined in " + |
| 264 | toString(newFile)); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 265 | return true; |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 266 | } |
| 267 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 268 | Symbol *SymbolTable::addDefinedFunction(StringRef name, uint32_t flags, |
| 269 | InputFile *file, |
| 270 | InputFunction *function) { |
| 271 | LLVM_DEBUG(dbgs() << "addDefinedFunction: " << name << " [" |
| 272 | << (function ? toString(function->signature) : "none") |
Sam Clegg | 8b0b48f | 2018-09-28 16:50:14 +0000 | [diff] [blame] | 273 | << "]\n"); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 274 | Symbol *s; |
| 275 | bool wasInserted; |
| 276 | std::tie(s, wasInserted) = insert(name, file); |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 277 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 278 | auto replaceSym = [&](Symbol *sym) { |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 279 | // If the new defined function doesn't have signture (i.e. bitcode |
| 280 | // functions) but the old symbol does, then preserve the old signature |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 281 | const WasmSignature *oldSig = s->getSignature(); |
| 282 | auto* newSym = replaceSymbol<DefinedFunction>(sym, name, flags, file, function); |
| 283 | if (!newSym->signature) |
| 284 | newSym->signature = oldSig; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 285 | }; |
| 286 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 287 | if (wasInserted || s->isLazy()) { |
| 288 | replaceSym(s); |
| 289 | return s; |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 290 | } |
| 291 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 292 | auto existingFunction = dyn_cast<FunctionSymbol>(s); |
| 293 | if (!existingFunction) { |
| 294 | reportTypeError(s, file, WASM_SYMBOL_TYPE_FUNCTION); |
| 295 | return s; |
Sam Clegg | 8b0b48f | 2018-09-28 16:50:14 +0000 | [diff] [blame] | 296 | } |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 297 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 298 | bool checkSig = true; |
| 299 | if (auto ud = dyn_cast<UndefinedFunction>(existingFunction)) |
| 300 | checkSig = ud->isCalledDirectly; |
Sam Clegg | 59f959f | 2019-05-24 22:45:08 +0000 | [diff] [blame] | 301 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 302 | if (checkSig && function && !signatureMatches(existingFunction, &function->signature)) { |
| 303 | Symbol* variant; |
| 304 | if (getFunctionVariant(s, &function->signature, file, &variant)) |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 305 | // New variant, always replace |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 306 | replaceSym(variant); |
| 307 | else if (shouldReplace(s, file, flags)) |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 308 | // Variant already exists, replace it after checking shouldReplace |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 309 | replaceSym(variant); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 310 | |
| 311 | // This variant we found take the place in the symbol table as the primary |
| 312 | // variant. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 313 | replace(name, variant); |
| 314 | return variant; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 315 | } |
| 316 | |
| 317 | // Existing function with matching signature. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 318 | if (shouldReplace(s, file, flags)) |
| 319 | replaceSym(s); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 320 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 321 | return s; |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 322 | } |
| 323 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 324 | Symbol *SymbolTable::addDefinedData(StringRef name, uint32_t flags, |
| 325 | InputFile *file, InputSegment *segment, |
| 326 | uint32_t address, uint32_t size) { |
| 327 | LLVM_DEBUG(dbgs() << "addDefinedData:" << name << " addr:" << address |
Nicola Zaghen | e7245b4 | 2018-05-15 13:36:20 +0000 | [diff] [blame] | 328 | << "\n"); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 329 | Symbol *s; |
| 330 | bool wasInserted; |
| 331 | std::tie(s, wasInserted) = insert(name, file); |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 332 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 333 | auto replaceSym = [&]() { |
| 334 | replaceSymbol<DefinedData>(s, name, flags, file, segment, address, size); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 335 | }; |
| 336 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 337 | if (wasInserted || s->isLazy()) { |
| 338 | replaceSym(); |
| 339 | return s; |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 340 | } |
| 341 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 342 | checkDataType(s, file); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 343 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 344 | if (shouldReplace(s, file, flags)) |
| 345 | replaceSym(); |
| 346 | return s; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 347 | } |
| 348 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 349 | Symbol *SymbolTable::addDefinedGlobal(StringRef name, uint32_t flags, |
| 350 | InputFile *file, InputGlobal *global) { |
| 351 | LLVM_DEBUG(dbgs() << "addDefinedGlobal:" << name << "\n"); |
Sam Clegg | 4c2cbfe | 2018-08-02 20:39:19 +0000 | [diff] [blame] | 352 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 353 | Symbol *s; |
| 354 | bool wasInserted; |
| 355 | std::tie(s, wasInserted) = insert(name, file); |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 356 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 357 | auto replaceSym = [&]() { |
| 358 | replaceSymbol<DefinedGlobal>(s, name, flags, file, global); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 359 | }; |
| 360 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 361 | if (wasInserted || s->isLazy()) { |
| 362 | replaceSym(); |
| 363 | return s; |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 364 | } |
| 365 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 366 | checkGlobalType(s, file, &global->getType()); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 367 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 368 | if (shouldReplace(s, file, flags)) |
| 369 | replaceSym(); |
| 370 | return s; |
Sam Clegg | 9310297 | 2018-02-23 05:08:53 +0000 | [diff] [blame] | 371 | } |
| 372 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 373 | Symbol *SymbolTable::addDefinedEvent(StringRef name, uint32_t flags, |
| 374 | InputFile *file, InputEvent *event) { |
| 375 | LLVM_DEBUG(dbgs() << "addDefinedEvent:" << name << "\n"); |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 376 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 377 | Symbol *s; |
| 378 | bool wasInserted; |
| 379 | std::tie(s, wasInserted) = insert(name, file); |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 380 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 381 | auto replaceSym = [&]() { |
| 382 | replaceSymbol<DefinedEvent>(s, name, flags, file, event); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 383 | }; |
| 384 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 385 | if (wasInserted || s->isLazy()) { |
| 386 | replaceSym(); |
| 387 | return s; |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 388 | } |
| 389 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 390 | checkEventType(s, file, &event->getType(), &event->signature); |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 391 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 392 | if (shouldReplace(s, file, flags)) |
| 393 | replaceSym(); |
| 394 | return s; |
Heejin Ahn | e915a71 | 2018-12-08 06:17:43 +0000 | [diff] [blame] | 395 | } |
| 396 | |
Sam Clegg | 67b0558 | 2019-10-17 05:16:54 +0000 | [diff] [blame] | 397 | // This function get called when an undefined symbol is added, and there is |
| 398 | // already an existing one in the symbols table. In this case we check that |
| 399 | // custom 'import-module' and 'import-field' symbol attributes agree. |
Kazuaki Ishizaki | 7ae3d33 | 2020-01-06 10:21:05 -0800 | [diff] [blame] | 400 | // With LTO these attributes are not available when the bitcode is read and only |
Sam Clegg | 67b0558 | 2019-10-17 05:16:54 +0000 | [diff] [blame] | 401 | // become available when the LTO object is read. In this case we silently |
| 402 | // replace the empty attributes with the valid ones. |
| 403 | template <typename T> |
| 404 | static void setImportAttributes(T *existing, StringRef importName, |
| 405 | StringRef importModule, InputFile *file) { |
| 406 | if (!importName.empty()) { |
| 407 | if (existing->importName.empty()) |
| 408 | existing->importName = importName; |
| 409 | if (existing->importName != importName) |
| 410 | error("import name mismatch for symbol: " + toString(*existing) + |
| 411 | "\n>>> defined as " + existing->importName + " in " + |
| 412 | toString(existing->getFile()) + "\n>>> defined as " + importName + |
| 413 | " in " + toString(file)); |
| 414 | } |
| 415 | |
| 416 | if (!importModule.empty()) { |
| 417 | if (existing->importModule.empty()) |
| 418 | existing->importModule = importModule; |
| 419 | if (existing->importModule != importModule) |
| 420 | error("import module mismatch for symbol: " + toString(*existing) + |
| 421 | "\n>>> defined as " + existing->importModule + " in " + |
| 422 | toString(existing->getFile()) + "\n>>> defined as " + importModule + |
| 423 | " in " + toString(file)); |
| 424 | } |
| 425 | } |
| 426 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 427 | Symbol *SymbolTable::addUndefinedFunction(StringRef name, StringRef importName, |
| 428 | StringRef importModule, |
| 429 | uint32_t flags, InputFile *file, |
| 430 | const WasmSignature *sig, |
| 431 | bool isCalledDirectly) { |
| 432 | LLVM_DEBUG(dbgs() << "addUndefinedFunction: " << name << " [" |
| 433 | << (sig ? toString(*sig) : "none") |
| 434 | << "] IsCalledDirectly:" << isCalledDirectly << "\n"); |
Sam Clegg | f6f4b98 | 2019-09-23 21:28:29 +0000 | [diff] [blame] | 435 | assert(flags & WASM_SYMBOL_UNDEFINED); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 436 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 437 | Symbol *s; |
| 438 | bool wasInserted; |
| 439 | std::tie(s, wasInserted) = insert(name, file); |
| 440 | if (s->traced) |
| 441 | printTraceSymbolUndefined(name, file); |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 442 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 443 | auto replaceSym = [&]() { |
| 444 | replaceSymbol<UndefinedFunction>(s, name, importName, importModule, flags, |
| 445 | file, sig, isCalledDirectly); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 446 | }; |
| 447 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 448 | if (wasInserted) |
| 449 | replaceSym(); |
| 450 | else if (auto *lazy = dyn_cast<LazySymbol>(s)) |
| 451 | lazy->fetch(); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 452 | else { |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 453 | auto existingFunction = dyn_cast<FunctionSymbol>(s); |
| 454 | if (!existingFunction) { |
| 455 | reportTypeError(s, file, WASM_SYMBOL_TYPE_FUNCTION); |
| 456 | return s; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 457 | } |
Sam Clegg | 67b0558 | 2019-10-17 05:16:54 +0000 | [diff] [blame] | 458 | auto *existingUndefined = dyn_cast<UndefinedFunction>(existingFunction); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 459 | if (!existingFunction->signature && sig) |
| 460 | existingFunction->signature = sig; |
Sam Clegg | fecfc59 | 2019-08-30 19:50:59 +0000 | [diff] [blame] | 461 | if (isCalledDirectly && !signatureMatches(existingFunction, sig)) { |
Sam Clegg | fecfc59 | 2019-08-30 19:50:59 +0000 | [diff] [blame] | 462 | // If the existing undefined functions is not called direcltly then let |
| 463 | // this one take precedence. Otherwise the existing function is either |
| 464 | // direclty called or defined, in which case we need a function variant. |
| 465 | if (existingUndefined && !existingUndefined->isCalledDirectly) |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 466 | replaceSym(); |
Sam Clegg | fecfc59 | 2019-08-30 19:50:59 +0000 | [diff] [blame] | 467 | else if (getFunctionVariant(s, sig, file, &s)) |
| 468 | replaceSym(); |
| 469 | } |
Sam Clegg | 67b0558 | 2019-10-17 05:16:54 +0000 | [diff] [blame] | 470 | if (existingUndefined) |
| 471 | setImportAttributes(existingUndefined, importName, importModule, file); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 472 | } |
Sam Clegg | cefbf9a | 2018-06-28 16:53:53 +0000 | [diff] [blame] | 473 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 474 | return s; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 475 | } |
| 476 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 477 | Symbol *SymbolTable::addUndefinedData(StringRef name, uint32_t flags, |
| 478 | InputFile *file) { |
| 479 | LLVM_DEBUG(dbgs() << "addUndefinedData: " << name << "\n"); |
Sam Clegg | f6f4b98 | 2019-09-23 21:28:29 +0000 | [diff] [blame] | 480 | assert(flags & WASM_SYMBOL_UNDEFINED); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 481 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 482 | Symbol *s; |
| 483 | bool wasInserted; |
| 484 | std::tie(s, wasInserted) = insert(name, file); |
| 485 | if (s->traced) |
| 486 | printTraceSymbolUndefined(name, file); |
Sam Clegg | f989a92 | 2018-07-17 19:15:02 +0000 | [diff] [blame] | 487 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 488 | if (wasInserted) |
| 489 | replaceSymbol<UndefinedData>(s, name, flags, file); |
| 490 | else if (auto *lazy = dyn_cast<LazySymbol>(s)) |
| 491 | lazy->fetch(); |
| 492 | else if (s->isDefined()) |
| 493 | checkDataType(s, file); |
| 494 | return s; |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 495 | } |
| 496 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 497 | Symbol *SymbolTable::addUndefinedGlobal(StringRef name, StringRef importName, |
| 498 | StringRef importModule, uint32_t flags, |
| 499 | InputFile *file, |
| 500 | const WasmGlobalType *type) { |
| 501 | LLVM_DEBUG(dbgs() << "addUndefinedGlobal: " << name << "\n"); |
Sam Clegg | f6f4b98 | 2019-09-23 21:28:29 +0000 | [diff] [blame] | 502 | assert(flags & WASM_SYMBOL_UNDEFINED); |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 503 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 504 | Symbol *s; |
| 505 | bool wasInserted; |
| 506 | std::tie(s, wasInserted) = insert(name, file); |
| 507 | if (s->traced) |
| 508 | printTraceSymbolUndefined(name, file); |
Sam Clegg | c729c1b | 2018-05-30 18:07:52 +0000 | [diff] [blame] | 509 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 510 | if (wasInserted) |
| 511 | replaceSymbol<UndefinedGlobal>(s, name, importName, importModule, flags, |
| 512 | file, type); |
| 513 | else if (auto *lazy = dyn_cast<LazySymbol>(s)) |
| 514 | lazy->fetch(); |
| 515 | else if (s->isDefined()) |
| 516 | checkGlobalType(s, file, type); |
| 517 | return s; |
Rui Ueyama | e3498ec | 2018-02-28 00:09:22 +0000 | [diff] [blame] | 518 | } |
| 519 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 520 | void SymbolTable::addLazy(ArchiveFile *file, const Archive::Symbol *sym) { |
| 521 | LLVM_DEBUG(dbgs() << "addLazy: " << sym->getName() << "\n"); |
| 522 | StringRef name = sym->getName(); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 523 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 524 | Symbol *s; |
| 525 | bool wasInserted; |
| 526 | std::tie(s, wasInserted) = insertName(name); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 527 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 528 | if (wasInserted) { |
| 529 | replaceSymbol<LazySymbol>(s, name, 0, file, *sym); |
Rui Ueyama | c03c904 | 2018-02-20 21:08:47 +0000 | [diff] [blame] | 530 | return; |
| 531 | } |
| 532 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 533 | if (!s->isUndefined()) |
Sam Clegg | 37b4ee5 | 2019-01-29 22:26:31 +0000 | [diff] [blame] | 534 | return; |
| 535 | |
| 536 | // The existing symbol is undefined, load a new one from the archive, |
Kazuaki Ishizaki | 7ae3d33 | 2020-01-06 10:21:05 -0800 | [diff] [blame] | 537 | // unless the existing symbol is weak in which case replace the undefined |
Sam Clegg | 37b4ee5 | 2019-01-29 22:26:31 +0000 | [diff] [blame] | 538 | // symbols with a LazySymbol. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 539 | if (s->isWeak()) { |
| 540 | const WasmSignature *oldSig = nullptr; |
Sam Clegg | 37b4ee5 | 2019-01-29 22:26:31 +0000 | [diff] [blame] | 541 | // In the case of an UndefinedFunction we need to preserve the expected |
| 542 | // signature. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 543 | if (auto *f = dyn_cast<UndefinedFunction>(s)) |
| 544 | oldSig = f->signature; |
Sam Clegg | 37b4ee5 | 2019-01-29 22:26:31 +0000 | [diff] [blame] | 545 | LLVM_DEBUG(dbgs() << "replacing existing weak undefined symbol\n"); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 546 | auto newSym = replaceSymbol<LazySymbol>(s, name, WASM_SYMBOL_BINDING_WEAK, |
| 547 | file, *sym); |
| 548 | newSym->signature = oldSig; |
Sam Clegg | 37b4ee5 | 2019-01-29 22:26:31 +0000 | [diff] [blame] | 549 | return; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 550 | } |
Sam Clegg | 37b4ee5 | 2019-01-29 22:26:31 +0000 | [diff] [blame] | 551 | |
| 552 | LLVM_DEBUG(dbgs() << "replacing existing undefined\n"); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 553 | file->addMember(sym); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 554 | } |
Sam Clegg | e0f6fcd | 2018-01-12 22:25:17 +0000 | [diff] [blame] | 555 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 556 | bool SymbolTable::addComdat(StringRef name) { |
| 557 | return comdatGroups.insert(CachedHashStringRef(name)).second; |
Sam Clegg | e0f6fcd | 2018-01-12 22:25:17 +0000 | [diff] [blame] | 558 | } |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 559 | |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 560 | // The new signature doesn't match. Create a variant to the symbol with the |
| 561 | // signature encoded in the name and return that instead. These symbols are |
| 562 | // then unified later in handleSymbolVariants. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 563 | bool SymbolTable::getFunctionVariant(Symbol* sym, const WasmSignature *sig, |
| 564 | const InputFile *file, Symbol **out) { |
| 565 | LLVM_DEBUG(dbgs() << "getFunctionVariant: " << sym->getName() << " -> " |
| 566 | << " " << toString(*sig) << "\n"); |
| 567 | Symbol *variant = nullptr; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 568 | |
| 569 | // Linear search through symbol variants. Should never be more than two |
| 570 | // or three entries here. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 571 | auto &variants = symVariants[CachedHashStringRef(sym->getName())]; |
| 572 | if (variants.empty()) |
| 573 | variants.push_back(sym); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 574 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 575 | for (Symbol* v : variants) { |
| 576 | if (*v->getSignature() == *sig) { |
| 577 | variant = v; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 578 | break; |
| 579 | } |
| 580 | } |
| 581 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 582 | bool wasAdded = !variant; |
| 583 | if (wasAdded) { |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 584 | // Create a new variant; |
| 585 | LLVM_DEBUG(dbgs() << "added new variant\n"); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 586 | variant = reinterpret_cast<Symbol *>(make<SymbolUnion>()); |
| 587 | variants.push_back(variant); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 588 | } else { |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 589 | LLVM_DEBUG(dbgs() << "variant already exists: " << toString(*variant) << "\n"); |
| 590 | assert(*variant->getSignature() == *sig); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 591 | } |
| 592 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 593 | *out = variant; |
| 594 | return wasAdded; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 595 | } |
| 596 | |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 597 | // Set a flag for --trace-symbol so that we can print out a log message |
| 598 | // if a new symbol with the same name is inserted into the symbol table. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 599 | void SymbolTable::trace(StringRef name) { |
| 600 | symMap.insert({CachedHashStringRef(name), -1}); |
Sam Clegg | 1f3f774 | 2019-02-06 02:35:18 +0000 | [diff] [blame] | 601 | } |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 602 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 603 | void SymbolTable::wrap(Symbol *sym, Symbol *real, Symbol *wrap) { |
Sam Clegg | a5ca34e | 2019-05-24 14:14:25 +0000 | [diff] [blame] | 604 | // Swap symbols as instructed by -wrap. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 605 | int &origIdx = symMap[CachedHashStringRef(sym->getName())]; |
| 606 | int &realIdx= symMap[CachedHashStringRef(real->getName())]; |
| 607 | int &wrapIdx = symMap[CachedHashStringRef(wrap->getName())]; |
| 608 | LLVM_DEBUG(dbgs() << "wrap: " << sym->getName() << "\n"); |
Sam Clegg | a5ca34e | 2019-05-24 14:14:25 +0000 | [diff] [blame] | 609 | |
| 610 | // Anyone looking up __real symbols should get the original |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 611 | realIdx = origIdx; |
Sam Clegg | a5ca34e | 2019-05-24 14:14:25 +0000 | [diff] [blame] | 612 | // Anyone looking up the original should get the __wrap symbol |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 613 | origIdx = wrapIdx; |
Sam Clegg | a5ca34e | 2019-05-24 14:14:25 +0000 | [diff] [blame] | 614 | } |
| 615 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 616 | static const uint8_t unreachableFn[] = { |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 617 | 0x03 /* ULEB length */, 0x00 /* ULEB num locals */, |
| 618 | 0x00 /* opcode unreachable */, 0x0b /* opcode end */ |
| 619 | }; |
| 620 | |
| 621 | // Replace the given symbol body with an unreachable function. |
| 622 | // This is used by handleWeakUndefines in order to generate a callable |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 623 | // equivalent of an undefined function and also handleSymbolVariants for |
| 624 | // undefined functions that don't match the signature of the definition. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 625 | InputFunction *SymbolTable::replaceWithUnreachable(Symbol *sym, |
| 626 | const WasmSignature &sig, |
| 627 | StringRef debugName) { |
| 628 | auto *func = make<SyntheticFunction>(sig, sym->getName(), debugName); |
| 629 | func->setBody(unreachableFn); |
| 630 | syntheticFunctions.emplace_back(func); |
| 631 | replaceSymbol<DefinedFunction>(sym, sym->getName(), sym->getFlags(), nullptr, |
| 632 | func); |
| 633 | return func; |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 634 | } |
| 635 | |
| 636 | // For weak undefined functions, there may be "call" instructions that reference |
| 637 | // the symbol. In this case, we need to synthesise a dummy/stub function that |
| 638 | // will abort at runtime, so that relocations can still provided an operand to |
| 639 | // the call instruction that passes Wasm validation. |
| 640 | void SymbolTable::handleWeakUndefines() { |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 641 | for (Symbol *sym : getSymbols()) { |
| 642 | if (!sym->isUndefWeak()) |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 643 | continue; |
| 644 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 645 | const WasmSignature *sig = sym->getSignature(); |
| 646 | if (!sig) { |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 647 | // It is possible for undefined functions not to have a signature (eg. if |
| 648 | // added via "--undefined"), but weak undefined ones do have a signature. |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 649 | // Lazy symbols may not be functions and therefore Sig can still be null |
Kazuaki Ishizaki | 7ae3d33 | 2020-01-06 10:21:05 -0800 | [diff] [blame] | 650 | // in some circumstance. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 651 | assert(!isa<FunctionSymbol>(sym)); |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 652 | continue; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 653 | } |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 654 | |
| 655 | // Add a synthetic dummy for weak undefined functions. These dummies will |
| 656 | // be GC'd if not used as the target of any "call" instructions. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 657 | StringRef debugName = saver.save("undefined:" + toString(*sym)); |
| 658 | InputFunction* func = replaceWithUnreachable(sym, *sig, debugName); |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 659 | // Ensure it compares equal to the null pointer, and so that table relocs |
| 660 | // don't pull in the stub body (only call-operand relocs should do that). |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 661 | func->setTableIndex(0); |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 662 | // Hide our dummy to prevent export. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 663 | sym->setHidden(true); |
Sam Clegg | 230dc11 | 2019-02-07 22:42:16 +0000 | [diff] [blame] | 664 | } |
| 665 | } |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 666 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 667 | static void reportFunctionSignatureMismatch(StringRef symName, |
| 668 | FunctionSymbol *a, |
| 669 | FunctionSymbol *b, bool isError) { |
| 670 | std::string msg = ("function signature mismatch: " + symName + |
| 671 | "\n>>> defined as " + toString(*a->signature) + " in " + |
| 672 | toString(a->getFile()) + "\n>>> defined as " + |
| 673 | toString(*b->signature) + " in " + toString(b->getFile())) |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 674 | .str(); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 675 | if (isError) |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 676 | error(msg); |
| 677 | else |
| 678 | warn(msg); |
| 679 | } |
| 680 | |
| 681 | // Remove any variant symbols that were created due to function signature |
| 682 | // mismatches. |
| 683 | void SymbolTable::handleSymbolVariants() { |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 684 | for (auto pair : symVariants) { |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 685 | // Push the initial symbol onto the list of variants. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 686 | StringRef symName = pair.first.val(); |
| 687 | std::vector<Symbol *> &variants = pair.second; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 688 | |
| 689 | #ifndef NDEBUG |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 690 | LLVM_DEBUG(dbgs() << "symbol with (" << variants.size() |
| 691 | << ") variants: " << symName << "\n"); |
| 692 | for (auto *s: variants) { |
| 693 | auto *f = cast<FunctionSymbol>(s); |
| 694 | LLVM_DEBUG(dbgs() << " variant: " + f->getName() << " " |
| 695 | << toString(*f->signature) << "\n"); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 696 | } |
| 697 | #endif |
| 698 | |
| 699 | // Find the one definition. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 700 | DefinedFunction *defined = nullptr; |
| 701 | for (auto *symbol : variants) { |
| 702 | if (auto f = dyn_cast<DefinedFunction>(symbol)) { |
| 703 | defined = f; |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 704 | break; |
| 705 | } |
| 706 | } |
| 707 | |
| 708 | // If there are no definitions, and the undefined symbols disagree on |
| 709 | // the signature, there is not we can do since we don't know which one |
| 710 | // to use as the signature on the import. |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 711 | if (!defined) { |
| 712 | reportFunctionSignatureMismatch(symName, |
| 713 | cast<FunctionSymbol>(variants[0]), |
| 714 | cast<FunctionSymbol>(variants[1]), true); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 715 | return; |
| 716 | } |
| 717 | |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 718 | for (auto *symbol : variants) { |
| 719 | if (symbol != defined) { |
| 720 | auto *f = cast<FunctionSymbol>(symbol); |
| 721 | reportFunctionSignatureMismatch(symName, f, defined, false); |
Sam Clegg | 51b521c | 2020-01-16 14:36:44 -0800 | [diff] [blame] | 722 | StringRef debugName = saver.save("signature_mismatch:" + toString(*f)); |
Rui Ueyama | 136d27a | 2019-07-11 05:40:30 +0000 | [diff] [blame] | 723 | replaceWithUnreachable(f, *f->signature, debugName); |
Sam Clegg | 6540e57 | 2019-02-20 23:19:31 +0000 | [diff] [blame] | 724 | } |
| 725 | } |
| 726 | } |
| 727 | } |
Fangrui Song | 33c59ab | 2019-10-10 05:25:39 +0000 | [diff] [blame] | 728 | |
| 729 | } // namespace wasm |
| 730 | } // namespace lld |