Gabor Horvath | c23f924 | 2018-02-15 09:08:51 +0000 | [diff] [blame] | 1 | //===--- ThrowKeywordMissingCheck.cpp - clang-tidy-------------------------===// |
| 2 | // |
Chandler Carruth | 2946cd7 | 2019-01-19 08:50:56 +0000 | [diff] [blame] | 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
Gabor Horvath | c23f924 | 2018-02-15 09:08:51 +0000 | [diff] [blame] | 6 | // |
| 7 | //===----------------------------------------------------------------------===// |
| 8 | |
| 9 | #include "ThrowKeywordMissingCheck.h" |
| 10 | #include "clang/AST/ASTContext.h" |
| 11 | #include "clang/ASTMatchers/ASTMatchFinder.h" |
| 12 | |
| 13 | using namespace clang::ast_matchers; |
| 14 | |
| 15 | namespace clang { |
| 16 | namespace tidy { |
| 17 | namespace bugprone { |
| 18 | |
| 19 | void ThrowKeywordMissingCheck::registerMatchers(MatchFinder *Finder) { |
Gabor Horvath | c23f924 | 2018-02-15 09:08:51 +0000 | [diff] [blame] | 20 | auto CtorInitializerList = |
| 21 | cxxConstructorDecl(hasAnyConstructorInitializer(anything())); |
| 22 | |
| 23 | Finder->addMatcher( |
| 24 | expr(anyOf(cxxFunctionalCastExpr(), cxxBindTemporaryExpr(), |
| 25 | cxxTemporaryObjectExpr()), |
| 26 | hasType(cxxRecordDecl( |
| 27 | isSameOrDerivedFrom(matchesName("[Ee]xception|EXCEPTION")))), |
| 28 | unless(anyOf(hasAncestor(stmt( |
| 29 | anyOf(cxxThrowExpr(), callExpr(), returnStmt()))), |
| 30 | hasAncestor(varDecl()), |
| 31 | allOf(hasAncestor(CtorInitializerList), |
| 32 | unless(hasAncestor(cxxCatchStmt())))))) |
| 33 | .bind("temporary-exception-not-thrown"), |
| 34 | this); |
| 35 | } |
| 36 | |
| 37 | void ThrowKeywordMissingCheck::check(const MatchFinder::MatchResult &Result) { |
| 38 | const auto *TemporaryExpr = |
| 39 | Result.Nodes.getNodeAs<Expr>("temporary-exception-not-thrown"); |
| 40 | |
Stephen Kelly | 43465bf | 2018-08-09 22:42:26 +0000 | [diff] [blame] | 41 | diag(TemporaryExpr->getBeginLoc(), "suspicious exception object created but " |
Gabor Horvath | c23f924 | 2018-02-15 09:08:51 +0000 | [diff] [blame] | 42 | "not thrown; did you mean 'throw %0'?") |
| 43 | << TemporaryExpr->getType().getBaseTypeIdentifier()->getName(); |
| 44 | } |
| 45 | |
| 46 | } // namespace bugprone |
| 47 | } // namespace tidy |
| 48 | } // namespace clang |