blob: b73e481ecd171350fa1de32ebb5423288a3fd00e [file] [log] [blame]
Serge Guelton16228bc2019-01-03 15:44:24 +00001#!/usr/bin/env python
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00002
Sanjay Patelcae64a02017-06-12 17:44:30 +00003"""A script to generate FileCheck statements for 'opt' regression tests.
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00004
Sanjay Patelcae64a02017-06-12 17:44:30 +00005This script is a utility to update LLVM opt test cases with new
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00006FileCheck patterns. It can either update all of the tests in the file or
7a single test function.
Sanjay Patel40641582016-04-05 18:00:47 +00008
9Example usage:
Sanjay Patelcae64a02017-06-12 17:44:30 +000010$ update_test_checks.py --opt=../bin/opt test/foo.ll
Sanjay Patel40641582016-04-05 18:00:47 +000011
12Workflow:
131. Make a compiler patch that requires updating some number of FileCheck lines
14 in regression test files.
152. Save the patch and revert it from your local work area.
163. Update the RUN-lines in the affected regression tests to look canonical.
17 Example: "; RUN: opt < %s -instcombine -S | FileCheck %s"
184. Refresh the FileCheck lines for either the entire file or select functions by
19 running this script.
205. Commit the fresh baseline of checks.
216. Apply your patch from step 1 and rebuild your local binaries.
227. Re-run this script on affected regression tests.
238. Check the diffs to ensure the script has done something reasonable.
249. Submit a patch including the regression test diffs for review.
25
26A common pattern is to have the script insert complete checking of every
27instruction. Then, edit it down to only check the relevant instructions.
28The script is designed to make adding checks to a test case fast, it is *not*
29designed to be authoratitive about what constitutes a good test!
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000030"""
31
Serge Guelton4a274782019-01-03 14:11:33 +000032from __future__ import print_function
33
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000034import argparse
Simon Pilgrimf509fe42019-03-05 10:44:37 +000035import glob
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000036import itertools
37import os # Used to advertise this file's name ("autogenerated_note").
38import string
39import subprocess
40import sys
41import tempfile
42import re
43
Fangrui Songee4e2e72018-01-30 00:40:05 +000044from UpdateTestChecks import common
45
Sanjay Patel16be4df92016-04-05 19:50:21 +000046ADVERT = '; NOTE: Assertions have been autogenerated by '
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000047
48# RegEx: this is where the magic happens.
49
Sanjay Patele54e6f52016-03-25 17:00:12 +000050IR_FUNCTION_RE = re.compile('^\s*define\s+(?:internal\s+)?[^@]*@([\w-]+)\s*\(')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000051
52
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000053
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000054
55
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000056def main():
Sanjay Patel40641582016-04-05 18:00:47 +000057 from argparse import RawTextHelpFormatter
58 parser = argparse.ArgumentParser(description=__doc__, formatter_class=RawTextHelpFormatter)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000059 parser.add_argument('-v', '--verbose', action='store_true',
60 help='Show verbose output')
Sanjay Patelcae64a02017-06-12 17:44:30 +000061 parser.add_argument('--opt-binary', default='opt',
62 help='The opt binary used to generate the test case')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000063 parser.add_argument(
64 '--function', help='The function in the test file to update')
Philip Reames9bf59382019-08-05 18:25:08 +000065 parser.add_argument('--update-only', action='store_true',
66 help='Only update test if it was already autogened')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000067 parser.add_argument('tests', nargs='+')
68 args = parser.parse_args()
69
Sanjay Patel16be4df92016-04-05 19:50:21 +000070 autogenerated_note = (ADVERT + 'utils/' + os.path.basename(__file__))
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000071
Sanjay Patelcae64a02017-06-12 17:44:30 +000072 opt_basename = os.path.basename(args.opt_binary)
Fangrui Song91ab86f2019-05-12 04:55:09 +000073 if not re.match(r'^opt(-\d+)?$', opt_basename):
Serge Guelton4a274782019-01-03 14:11:33 +000074 print('ERROR: Unexpected opt name: ' + opt_basename, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000075 sys.exit(1)
Fangrui Song91ab86f2019-05-12 04:55:09 +000076 opt_basename = 'opt'
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000077
David Bolvanskyfcffa7c2019-07-11 20:14:22 +000078 test_paths = []
79 for test in args.tests:
80 if not glob.glob(test):
Fangrui Songd24e6d72019-08-06 09:42:00 +000081 print("WARNING: Test file '%s' was not found. Ignoring it." % (test,), file=sys.stderr)
David Bolvanskyfcffa7c2019-07-11 20:14:22 +000082 continue
83 test_paths.append(test)
84
Simon Pilgrimf509fe42019-03-05 10:44:37 +000085 for test in test_paths:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000086 if args.verbose:
Fangrui Songd24e6d72019-08-06 09:42:00 +000087 print('Scanning for RUN lines in test file: %s' + test, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000088 with open(test) as f:
89 input_lines = [l.rstrip() for l in f]
90
Philip Reames9bf59382019-08-05 18:25:08 +000091 if args.update_only:
92 if len(input_lines) == 0 or 'autogenerated' not in input_lines[0]:
Fangrui Songd24e6d72019-08-06 09:42:00 +000093 print("Skipping test which isn't autogenerated: " + test, file=sys.stderr)
94 continue
Philip Reames9bf59382019-08-05 18:25:08 +000095
Bryant Wong291264b2016-12-29 19:32:34 +000096 raw_lines = [m.group(1)
Fangrui Songee4e2e72018-01-30 00:40:05 +000097 for m in [common.RUN_LINE_RE.match(l) for l in input_lines] if m]
Bryant Wong291264b2016-12-29 19:32:34 +000098 run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []
99 for l in raw_lines[1:]:
Fangrui Songd24e6d72019-08-06 09:42:00 +0000100 if run_lines[-1].endswith('\\'):
101 run_lines[-1] = run_lines[-1].rstrip('\\') + ' ' + l
Bryant Wong507256b2016-12-29 20:05:51 +0000102 else:
103 run_lines.append(l)
Bryant Wong291264b2016-12-29 19:32:34 +0000104
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000105 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000106 print('Found %d RUN lines:' % (len(run_lines),), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000107 for l in run_lines:
Serge Guelton4a274782019-01-03 14:11:33 +0000108 print(' RUN: ' + l, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000109
110 prefix_list = []
111 for l in run_lines:
Philip Reames9bf59382019-08-05 18:25:08 +0000112 if '|' not in l:
Fangrui Songd24e6d72019-08-06 09:42:00 +0000113 print('WARNING: Skipping unparseable RUN line: ' + l, file=sys.stderr)
Philip Reames9bf59382019-08-05 18:25:08 +0000114 continue
Fangrui Songd24e6d72019-08-06 09:42:00 +0000115
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000116 (tool_cmd, filecheck_cmd) = tuple([cmd.strip() for cmd in l.split('|', 1)])
David Bolvansky45be5e42019-07-29 17:41:00 +0000117 common.verify_filecheck_prefixes(filecheck_cmd)
Sanjay Patelcae64a02017-06-12 17:44:30 +0000118 if not tool_cmd.startswith(opt_basename + ' '):
Serge Guelton4a274782019-01-03 14:11:33 +0000119 print('WARNING: Skipping non-%s RUN line: %s' % (opt_basename, l), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000120 continue
121
122 if not filecheck_cmd.startswith('FileCheck '):
Serge Guelton4a274782019-01-03 14:11:33 +0000123 print('WARNING: Skipping non-FileChecked RUN line: ' + l, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000124 continue
125
Sanjay Patelcae64a02017-06-12 17:44:30 +0000126 tool_cmd_args = tool_cmd[len(opt_basename):].strip()
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000127 tool_cmd_args = tool_cmd_args.replace('< %s', '').replace('%s', '').strip()
128
Fangrui Songee4e2e72018-01-30 00:40:05 +0000129 check_prefixes = [item for m in common.CHECK_PREFIX_RE.finditer(filecheck_cmd)
Nikolai Bozhenov33ee40e2017-01-14 09:39:35 +0000130 for item in m.group(1).split(',')]
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000131 if not check_prefixes:
132 check_prefixes = ['CHECK']
133
134 # FIXME: We should use multiple check prefixes to common check lines. For
135 # now, we just ignore all but the last.
136 prefix_list.append((check_prefixes, tool_cmd_args))
137
138 func_dict = {}
139 for prefixes, _ in prefix_list:
140 for prefix in prefixes:
141 func_dict.update({prefix: dict()})
Sanjay Patelcae64a02017-06-12 17:44:30 +0000142 for prefixes, opt_args in prefix_list:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000143 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000144 print('Extracted opt cmd: ' + opt_basename + ' ' + opt_args, file=sys.stderr)
145 print('Extracted FileCheck prefixes: ' + str(prefixes), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000146
Fangrui Songee4e2e72018-01-30 00:40:05 +0000147 raw_tool_output = common.invoke_tool(args.opt_binary, opt_args, test)
148 common.build_function_body_dictionary(
Fangrui Song4f0f4262018-02-10 05:01:33 +0000149 common.OPT_FUNCTION_RE, common.scrub_body, [],
150 raw_tool_output, prefixes, func_dict, args.verbose)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000151
152 is_in_function = False
153 is_in_function_start = False
154 prefix_set = set([prefix for prefixes, _ in prefix_list for prefix in prefixes])
155 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000156 print('Rewriting FileCheck prefixes: %s' % (prefix_set,), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000157 output_lines = []
158 output_lines.append(autogenerated_note)
159
160 for input_line in input_lines:
161 if is_in_function_start:
162 if input_line == '':
163 continue
164 if input_line.lstrip().startswith(';'):
Fangrui Songee4e2e72018-01-30 00:40:05 +0000165 m = common.CHECK_RE.match(input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000166 if not m or m.group(1) not in prefix_set:
167 output_lines.append(input_line)
168 continue
169
170 # Print out the various check lines here.
Simon Pilgrimabba0482018-04-05 09:30:42 +0000171 common.add_ir_checks(output_lines, ';', prefix_list, func_dict, func_name)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000172 is_in_function_start = False
173
174 if is_in_function:
Fangrui Songee4e2e72018-01-30 00:40:05 +0000175 if common.should_add_line_to_output(input_line, prefix_set):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000176 # This input line of the function body will go as-is into the output.
Sanjay Pateld8592712016-03-27 20:43:02 +0000177 # Except make leading whitespace uniform: 2 spaces.
Fangrui Songee4e2e72018-01-30 00:40:05 +0000178 input_line = common.SCRUB_LEADING_WHITESPACE_RE.sub(r' ', input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000179 output_lines.append(input_line)
180 else:
181 continue
182 if input_line.strip() == '}':
183 is_in_function = False
184 continue
185
Sanjay Patel16be4df92016-04-05 19:50:21 +0000186 # Discard any previous script advertising.
187 if input_line.startswith(ADVERT):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000188 continue
189
190 # If it's outside a function, it just gets copied to the output.
191 output_lines.append(input_line)
192
193 m = IR_FUNCTION_RE.match(input_line)
194 if not m:
195 continue
Fangrui Songee4e2e72018-01-30 00:40:05 +0000196 func_name = m.group(1)
197 if args.function is not None and func_name != args.function:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000198 # When filtering on a specific function, skip all others.
199 continue
200 is_in_function = is_in_function_start = True
201
202 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000203 print('Writing %d lines to %s...' % (len(output_lines), test), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000204
205 with open(test, 'wb') as f:
Simon Pilgrimd82bd4d2019-01-30 16:15:59 +0000206 f.writelines(['{}\n'.format(l).encode('utf-8') for l in output_lines])
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000207
208
209if __name__ == '__main__':
210 main()