blob: f878d47811499ef260aa20a94c1b0588b049a10e [file] [log] [blame]
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00001#!/usr/bin/env python2.7
2
Sanjay Patelcae64a02017-06-12 17:44:30 +00003"""A script to generate FileCheck statements for 'opt' regression tests.
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00004
Sanjay Patelcae64a02017-06-12 17:44:30 +00005This script is a utility to update LLVM opt test cases with new
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00006FileCheck patterns. It can either update all of the tests in the file or
7a single test function.
Sanjay Patel40641582016-04-05 18:00:47 +00008
9Example usage:
Sanjay Patelcae64a02017-06-12 17:44:30 +000010$ update_test_checks.py --opt=../bin/opt test/foo.ll
Sanjay Patel40641582016-04-05 18:00:47 +000011
12Workflow:
131. Make a compiler patch that requires updating some number of FileCheck lines
14 in regression test files.
152. Save the patch and revert it from your local work area.
163. Update the RUN-lines in the affected regression tests to look canonical.
17 Example: "; RUN: opt < %s -instcombine -S | FileCheck %s"
184. Refresh the FileCheck lines for either the entire file or select functions by
19 running this script.
205. Commit the fresh baseline of checks.
216. Apply your patch from step 1 and rebuild your local binaries.
227. Re-run this script on affected regression tests.
238. Check the diffs to ensure the script has done something reasonable.
249. Submit a patch including the regression test diffs for review.
25
26A common pattern is to have the script insert complete checking of every
27instruction. Then, edit it down to only check the relevant instructions.
28The script is designed to make adding checks to a test case fast, it is *not*
29designed to be authoratitive about what constitutes a good test!
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000030"""
31
Serge Guelton4a274782019-01-03 14:11:33 +000032from __future__ import print_function
33
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000034import argparse
35import itertools
36import os # Used to advertise this file's name ("autogenerated_note").
37import string
38import subprocess
39import sys
40import tempfile
41import re
42
Fangrui Songee4e2e72018-01-30 00:40:05 +000043from UpdateTestChecks import common
44
Sanjay Patel16be4df92016-04-05 19:50:21 +000045ADVERT = '; NOTE: Assertions have been autogenerated by '
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000046
47# RegEx: this is where the magic happens.
48
Sanjay Patele54e6f52016-03-25 17:00:12 +000049IR_FUNCTION_RE = re.compile('^\s*define\s+(?:internal\s+)?[^@]*@([\w-]+)\s*\(')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000050
51
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000052
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000053
54
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000055def main():
Sanjay Patel40641582016-04-05 18:00:47 +000056 from argparse import RawTextHelpFormatter
57 parser = argparse.ArgumentParser(description=__doc__, formatter_class=RawTextHelpFormatter)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000058 parser.add_argument('-v', '--verbose', action='store_true',
59 help='Show verbose output')
Sanjay Patelcae64a02017-06-12 17:44:30 +000060 parser.add_argument('--opt-binary', default='opt',
61 help='The opt binary used to generate the test case')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000062 parser.add_argument(
63 '--function', help='The function in the test file to update')
64 parser.add_argument('tests', nargs='+')
65 args = parser.parse_args()
66
Sanjay Patel16be4df92016-04-05 19:50:21 +000067 autogenerated_note = (ADVERT + 'utils/' + os.path.basename(__file__))
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000068
Sanjay Patelcae64a02017-06-12 17:44:30 +000069 opt_basename = os.path.basename(args.opt_binary)
70 if (opt_basename != "opt"):
Serge Guelton4a274782019-01-03 14:11:33 +000071 print('ERROR: Unexpected opt name: ' + opt_basename, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000072 sys.exit(1)
73
74 for test in args.tests:
75 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +000076 print('Scanning for RUN lines in test file: %s' % (test,), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000077 with open(test) as f:
78 input_lines = [l.rstrip() for l in f]
79
Bryant Wong291264b2016-12-29 19:32:34 +000080 raw_lines = [m.group(1)
Fangrui Songee4e2e72018-01-30 00:40:05 +000081 for m in [common.RUN_LINE_RE.match(l) for l in input_lines] if m]
Bryant Wong291264b2016-12-29 19:32:34 +000082 run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []
83 for l in raw_lines[1:]:
Bryant Wong507256b2016-12-29 20:05:51 +000084 if run_lines[-1].endswith("\\"):
85 run_lines[-1] = run_lines[-1].rstrip("\\") + " " + l
86 else:
87 run_lines.append(l)
Bryant Wong291264b2016-12-29 19:32:34 +000088
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000089 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +000090 print('Found %d RUN lines:' % (len(run_lines),), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000091 for l in run_lines:
Serge Guelton4a274782019-01-03 14:11:33 +000092 print(' RUN: ' + l, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000093
94 prefix_list = []
95 for l in run_lines:
96 (tool_cmd, filecheck_cmd) = tuple([cmd.strip() for cmd in l.split('|', 1)])
97
Sanjay Patelcae64a02017-06-12 17:44:30 +000098 if not tool_cmd.startswith(opt_basename + ' '):
Serge Guelton4a274782019-01-03 14:11:33 +000099 print('WARNING: Skipping non-%s RUN line: %s' % (opt_basename, l), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000100 continue
101
102 if not filecheck_cmd.startswith('FileCheck '):
Serge Guelton4a274782019-01-03 14:11:33 +0000103 print('WARNING: Skipping non-FileChecked RUN line: ' + l, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000104 continue
105
Sanjay Patelcae64a02017-06-12 17:44:30 +0000106 tool_cmd_args = tool_cmd[len(opt_basename):].strip()
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000107 tool_cmd_args = tool_cmd_args.replace('< %s', '').replace('%s', '').strip()
108
Fangrui Songee4e2e72018-01-30 00:40:05 +0000109 check_prefixes = [item for m in common.CHECK_PREFIX_RE.finditer(filecheck_cmd)
Nikolai Bozhenov33ee40e2017-01-14 09:39:35 +0000110 for item in m.group(1).split(',')]
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000111 if not check_prefixes:
112 check_prefixes = ['CHECK']
113
114 # FIXME: We should use multiple check prefixes to common check lines. For
115 # now, we just ignore all but the last.
116 prefix_list.append((check_prefixes, tool_cmd_args))
117
118 func_dict = {}
119 for prefixes, _ in prefix_list:
120 for prefix in prefixes:
121 func_dict.update({prefix: dict()})
Sanjay Patelcae64a02017-06-12 17:44:30 +0000122 for prefixes, opt_args in prefix_list:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000123 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000124 print('Extracted opt cmd: ' + opt_basename + ' ' + opt_args, file=sys.stderr)
125 print('Extracted FileCheck prefixes: ' + str(prefixes), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000126
Fangrui Songee4e2e72018-01-30 00:40:05 +0000127 raw_tool_output = common.invoke_tool(args.opt_binary, opt_args, test)
128 common.build_function_body_dictionary(
Fangrui Song4f0f4262018-02-10 05:01:33 +0000129 common.OPT_FUNCTION_RE, common.scrub_body, [],
130 raw_tool_output, prefixes, func_dict, args.verbose)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000131
132 is_in_function = False
133 is_in_function_start = False
134 prefix_set = set([prefix for prefixes, _ in prefix_list for prefix in prefixes])
135 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000136 print('Rewriting FileCheck prefixes: %s' % (prefix_set,), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000137 output_lines = []
138 output_lines.append(autogenerated_note)
139
140 for input_line in input_lines:
141 if is_in_function_start:
142 if input_line == '':
143 continue
144 if input_line.lstrip().startswith(';'):
Fangrui Songee4e2e72018-01-30 00:40:05 +0000145 m = common.CHECK_RE.match(input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000146 if not m or m.group(1) not in prefix_set:
147 output_lines.append(input_line)
148 continue
149
150 # Print out the various check lines here.
Simon Pilgrimabba0482018-04-05 09:30:42 +0000151 common.add_ir_checks(output_lines, ';', prefix_list, func_dict, func_name)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000152 is_in_function_start = False
153
154 if is_in_function:
Fangrui Songee4e2e72018-01-30 00:40:05 +0000155 if common.should_add_line_to_output(input_line, prefix_set):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000156 # This input line of the function body will go as-is into the output.
Sanjay Pateld8592712016-03-27 20:43:02 +0000157 # Except make leading whitespace uniform: 2 spaces.
Fangrui Songee4e2e72018-01-30 00:40:05 +0000158 input_line = common.SCRUB_LEADING_WHITESPACE_RE.sub(r' ', input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000159 output_lines.append(input_line)
160 else:
161 continue
162 if input_line.strip() == '}':
163 is_in_function = False
164 continue
165
Sanjay Patel16be4df92016-04-05 19:50:21 +0000166 # Discard any previous script advertising.
167 if input_line.startswith(ADVERT):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000168 continue
169
170 # If it's outside a function, it just gets copied to the output.
171 output_lines.append(input_line)
172
173 m = IR_FUNCTION_RE.match(input_line)
174 if not m:
175 continue
Fangrui Songee4e2e72018-01-30 00:40:05 +0000176 func_name = m.group(1)
177 if args.function is not None and func_name != args.function:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000178 # When filtering on a specific function, skip all others.
179 continue
180 is_in_function = is_in_function_start = True
181
182 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000183 print('Writing %d lines to %s...' % (len(output_lines), test), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000184
185 with open(test, 'wb') as f:
186 f.writelines([l + '\n' for l in output_lines])
187
188
189if __name__ == '__main__':
190 main()