Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 1 | //== GenericTaintChecker.cpp ----------------------------------- -*- C++ -*--=// |
| 2 | // |
Chandler Carruth | 2946cd7 | 2019-01-19 08:50:56 +0000 | [diff] [blame^] | 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 6 | // |
| 7 | //===----------------------------------------------------------------------===// |
| 8 | // |
| 9 | // This checker defines the attack surface for generic taint propagation. |
| 10 | // |
| 11 | // The taint information produced by it might be useful to other checkers. For |
| 12 | // example, checkers should report errors which involve tainted data more |
| 13 | // aggressively, even if the involved symbols are under constrained. |
| 14 | // |
| 15 | //===----------------------------------------------------------------------===// |
Kristof Umann | 76a2150 | 2018-12-15 16:23:51 +0000 | [diff] [blame] | 16 | #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 17 | #include "clang/AST/Attr.h" |
| 18 | #include "clang/Basic/Builtins.h" |
| 19 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/Checker.h" |
| 21 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 23 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 24 | #include <climits> |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 25 | |
| 26 | using namespace clang; |
| 27 | using namespace ento; |
| 28 | |
| 29 | namespace { |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 30 | class GenericTaintChecker |
| 31 | : public Checker<check::PostStmt<CallExpr>, check::PreStmt<CallExpr>> { |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 32 | public: |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 33 | static void *getTag() { |
| 34 | static int Tag; |
| 35 | return &Tag; |
| 36 | } |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 37 | |
| 38 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 39 | |
| 40 | void checkPreStmt(const CallExpr *CE, CheckerContext &C) const; |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 41 | |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 42 | private: |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 43 | static const unsigned InvalidArgIndex = UINT_MAX; |
| 44 | /// Denotes the return vale. |
| 45 | static const unsigned ReturnValueIndex = UINT_MAX - 1; |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 46 | |
Ahmed Charles | b898432 | 2014-03-07 20:03:18 +0000 | [diff] [blame] | 47 | mutable std::unique_ptr<BugType> BT; |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 48 | inline void initBugType() const { |
| 49 | if (!BT) |
Alexander Kornienko | 4aca9b1 | 2014-02-11 21:49:21 +0000 | [diff] [blame] | 50 | BT.reset(new BugType(this, "Use of Untrusted Data", "Untrusted Data")); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 51 | } |
Anna Zaks | 457c687 | 2011-11-18 02:26:36 +0000 | [diff] [blame] | 52 | |
Adrian Prantl | 9fc8faf | 2018-05-09 01:00:01 +0000 | [diff] [blame] | 53 | /// Catch taint related bugs. Check if tainted data is passed to a |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 54 | /// system call etc. |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 55 | bool checkPre(const CallExpr *CE, CheckerContext &C) const; |
| 56 | |
Adrian Prantl | 9fc8faf | 2018-05-09 01:00:01 +0000 | [diff] [blame] | 57 | /// Add taint sources on a pre-visit. |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 58 | void addSourcesPre(const CallExpr *CE, CheckerContext &C) const; |
| 59 | |
Adrian Prantl | 9fc8faf | 2018-05-09 01:00:01 +0000 | [diff] [blame] | 60 | /// Propagate taint generated at pre-visit. |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 61 | bool propagateFromPre(const CallExpr *CE, CheckerContext &C) const; |
| 62 | |
Adrian Prantl | 9fc8faf | 2018-05-09 01:00:01 +0000 | [diff] [blame] | 63 | /// Add taint sources on a post visit. |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 64 | void addSourcesPost(const CallExpr *CE, CheckerContext &C) const; |
| 65 | |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 66 | /// Check if the region the expression evaluates to is the standard input, |
| 67 | /// and thus, is tainted. |
| 68 | static bool isStdin(const Expr *E, CheckerContext &C); |
| 69 | |
Adrian Prantl | 9fc8faf | 2018-05-09 01:00:01 +0000 | [diff] [blame] | 70 | /// Given a pointer argument, return the value it points to. |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 71 | static Optional<SVal> getPointedToSVal(CheckerContext &C, const Expr *Arg); |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 72 | |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 73 | /// Functions defining the attack surface. |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 74 | typedef ProgramStateRef (GenericTaintChecker::*FnCheck)( |
| 75 | const CallExpr *, CheckerContext &C) const; |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 76 | ProgramStateRef postScanf(const CallExpr *CE, CheckerContext &C) const; |
| 77 | ProgramStateRef postSocket(const CallExpr *CE, CheckerContext &C) const; |
| 78 | ProgramStateRef postRetTaint(const CallExpr *CE, CheckerContext &C) const; |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 79 | |
| 80 | /// Taint the scanned input if the file is tainted. |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 81 | ProgramStateRef preFscanf(const CallExpr *CE, CheckerContext &C) const; |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 82 | |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 83 | /// Check for CWE-134: Uncontrolled Format String. |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 84 | static const char MsgUncontrolledFormatString[]; |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 85 | bool checkUncontrolledFormatString(const CallExpr *CE, |
| 86 | CheckerContext &C) const; |
| 87 | |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 88 | /// Check for: |
| 89 | /// CERT/STR02-C. "Sanitize data passed to complex subsystems" |
| 90 | /// CWE-78, "Failure to Sanitize Data into an OS Command" |
| 91 | static const char MsgSanitizeSystemArgs[]; |
| 92 | bool checkSystemCall(const CallExpr *CE, StringRef Name, |
| 93 | CheckerContext &C) const; |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 94 | |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 95 | /// Check if tainted data is used as a buffer size ins strn.. functions, |
| 96 | /// and allocators. |
| 97 | static const char MsgTaintedBufferSize[]; |
| 98 | bool checkTaintedBufferSize(const CallExpr *CE, const FunctionDecl *FDecl, |
| 99 | CheckerContext &C) const; |
| 100 | |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 101 | /// Generate a report if the expression is tainted or points to tainted data. |
| 102 | bool generateReportIfTainted(const Expr *E, const char Msg[], |
| 103 | CheckerContext &C) const; |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 104 | |
Dmitri Gribenko | f857950 | 2013-01-12 19:30:44 +0000 | [diff] [blame] | 105 | typedef SmallVector<unsigned, 2> ArgVector; |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 106 | |
Adrian Prantl | 9fc8faf | 2018-05-09 01:00:01 +0000 | [diff] [blame] | 107 | /// A struct used to specify taint propagation rules for a function. |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 108 | /// |
| 109 | /// If any of the possible taint source arguments is tainted, all of the |
| 110 | /// destination arguments should also be tainted. Use InvalidArgIndex in the |
| 111 | /// src list to specify that all of the arguments can introduce taint. Use |
| 112 | /// InvalidArgIndex in the dst arguments to signify that all the non-const |
| 113 | /// pointer and reference arguments might be tainted on return. If |
| 114 | /// ReturnValueIndex is added to the dst list, the return value will be |
| 115 | /// tainted. |
| 116 | struct TaintPropagationRule { |
| 117 | /// List of arguments which can be taint sources and should be checked. |
| 118 | ArgVector SrcArgs; |
| 119 | /// List of arguments which should be tainted on function return. |
| 120 | ArgVector DstArgs; |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 121 | // TODO: Check if using other data structures would be more optimal. |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 122 | |
| 123 | TaintPropagationRule() {} |
| 124 | |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 125 | TaintPropagationRule(unsigned SArg, unsigned DArg, bool TaintRet = false) { |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 126 | SrcArgs.push_back(SArg); |
| 127 | DstArgs.push_back(DArg); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 128 | if (TaintRet) |
| 129 | DstArgs.push_back(ReturnValueIndex); |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 130 | } |
| 131 | |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 132 | TaintPropagationRule(unsigned SArg1, unsigned SArg2, unsigned DArg, |
| 133 | bool TaintRet = false) { |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 134 | SrcArgs.push_back(SArg1); |
| 135 | SrcArgs.push_back(SArg2); |
| 136 | DstArgs.push_back(DArg); |
| 137 | if (TaintRet) |
| 138 | DstArgs.push_back(ReturnValueIndex); |
| 139 | } |
| 140 | |
| 141 | /// Get the propagation rule for a given function. |
| 142 | static TaintPropagationRule |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 143 | getTaintPropagationRule(const FunctionDecl *FDecl, StringRef Name, |
| 144 | CheckerContext &C); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 145 | |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 146 | inline void addSrcArg(unsigned A) { SrcArgs.push_back(A); } |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 147 | inline void addDstArg(unsigned A) { DstArgs.push_back(A); } |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 148 | |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 149 | inline bool isNull() const { return SrcArgs.empty(); } |
| 150 | |
| 151 | inline bool isDestinationArgument(unsigned ArgNum) const { |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 152 | return (std::find(DstArgs.begin(), DstArgs.end(), ArgNum) != |
| 153 | DstArgs.end()); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 154 | } |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 155 | |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 156 | static inline bool isTaintedOrPointsToTainted(const Expr *E, |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 157 | ProgramStateRef State, |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 158 | CheckerContext &C) { |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 159 | if (State->isTainted(E, C.getLocationContext()) || isStdin(E, C)) |
| 160 | return true; |
| 161 | |
| 162 | if (!E->getType().getTypePtr()->isPointerType()) |
| 163 | return false; |
| 164 | |
| 165 | Optional<SVal> V = getPointedToSVal(C, E); |
| 166 | return (V && State->isTainted(*V)); |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 167 | } |
| 168 | |
Adrian Prantl | 9fc8faf | 2018-05-09 01:00:01 +0000 | [diff] [blame] | 169 | /// Pre-process a function which propagates taint according to the |
Anna Zaks | 7f6a6b7 | 2012-01-18 02:45:13 +0000 | [diff] [blame] | 170 | /// taint rule. |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 171 | ProgramStateRef process(const CallExpr *CE, CheckerContext &C) const; |
Anna Zaks | 7f6a6b7 | 2012-01-18 02:45:13 +0000 | [diff] [blame] | 172 | }; |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 173 | }; |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 174 | |
| 175 | const unsigned GenericTaintChecker::ReturnValueIndex; |
| 176 | const unsigned GenericTaintChecker::InvalidArgIndex; |
| 177 | |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 178 | const char GenericTaintChecker::MsgUncontrolledFormatString[] = |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 179 | "Untrusted data is used as a format string " |
| 180 | "(CWE-134: Uncontrolled Format String)"; |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 181 | |
| 182 | const char GenericTaintChecker::MsgSanitizeSystemArgs[] = |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 183 | "Untrusted data is passed to a system call " |
| 184 | "(CERT/STR02-C. Sanitize data passed to complex subsystems)"; |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 185 | |
| 186 | const char GenericTaintChecker::MsgTaintedBufferSize[] = |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 187 | "Untrusted data is used to specify the buffer size " |
| 188 | "(CERT/STR31-C. Guarantee that storage for strings has sufficient space " |
| 189 | "for " |
| 190 | "character data and the null terminator)"; |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 191 | |
| 192 | } // end of anonymous namespace |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 193 | |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 194 | /// A set which is used to pass information from call pre-visit instruction |
| 195 | /// to the call post-visit. The values are unsigned integers, which are either |
| 196 | /// ReturnValueIndex, or indexes of the pointer/reference argument, which |
| 197 | /// points to data, which should be tainted on return. |
Jordan Rose | 0c153cb | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 198 | REGISTER_SET_WITH_PROGRAMSTATE(TaintArgsOnPostVisit, unsigned) |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 199 | |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 200 | GenericTaintChecker::TaintPropagationRule |
| 201 | GenericTaintChecker::TaintPropagationRule::getTaintPropagationRule( |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 202 | const FunctionDecl *FDecl, StringRef Name, CheckerContext &C) { |
Enrico Pertoso | 4432d87 | 2015-06-03 09:10:58 +0000 | [diff] [blame] | 203 | // TODO: Currently, we might lose precision here: we always mark a return |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 204 | // value as tainted even if it's just a pointer, pointing to tainted data. |
| 205 | |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 206 | // Check for exact name match for functions without builtin substitutes. |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 207 | TaintPropagationRule Rule = |
| 208 | llvm::StringSwitch<TaintPropagationRule>(Name) |
| 209 | .Case("atoi", TaintPropagationRule(0, ReturnValueIndex)) |
| 210 | .Case("atol", TaintPropagationRule(0, ReturnValueIndex)) |
| 211 | .Case("atoll", TaintPropagationRule(0, ReturnValueIndex)) |
| 212 | .Case("getc", TaintPropagationRule(0, ReturnValueIndex)) |
| 213 | .Case("fgetc", TaintPropagationRule(0, ReturnValueIndex)) |
| 214 | .Case("getc_unlocked", TaintPropagationRule(0, ReturnValueIndex)) |
| 215 | .Case("getw", TaintPropagationRule(0, ReturnValueIndex)) |
| 216 | .Case("toupper", TaintPropagationRule(0, ReturnValueIndex)) |
| 217 | .Case("tolower", TaintPropagationRule(0, ReturnValueIndex)) |
| 218 | .Case("strchr", TaintPropagationRule(0, ReturnValueIndex)) |
| 219 | .Case("strrchr", TaintPropagationRule(0, ReturnValueIndex)) |
| 220 | .Case("read", TaintPropagationRule(0, 2, 1, true)) |
| 221 | .Case("pread", TaintPropagationRule(InvalidArgIndex, 1, true)) |
| 222 | .Case("gets", TaintPropagationRule(InvalidArgIndex, 0, true)) |
| 223 | .Case("fgets", TaintPropagationRule(2, 0, true)) |
| 224 | .Case("getline", TaintPropagationRule(2, 0)) |
| 225 | .Case("getdelim", TaintPropagationRule(3, 0)) |
| 226 | .Case("fgetln", TaintPropagationRule(0, ReturnValueIndex)) |
| 227 | .Default(TaintPropagationRule()); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 228 | |
| 229 | if (!Rule.isNull()) |
| 230 | return Rule; |
| 231 | |
| 232 | // Check if it's one of the memory setting/copying functions. |
| 233 | // This check is specialized but faster then calling isCLibraryFunction. |
| 234 | unsigned BId = 0; |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 235 | if ((BId = FDecl->getMemoryFunctionKind())) |
| 236 | switch (BId) { |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 237 | case Builtin::BImemcpy: |
| 238 | case Builtin::BImemmove: |
| 239 | case Builtin::BIstrncpy: |
| 240 | case Builtin::BIstrncat: |
| 241 | return TaintPropagationRule(1, 2, 0, true); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 242 | case Builtin::BIstrlcpy: |
| 243 | case Builtin::BIstrlcat: |
| 244 | return TaintPropagationRule(1, 2, 0, false); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 245 | case Builtin::BIstrndup: |
| 246 | return TaintPropagationRule(0, 1, ReturnValueIndex); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 247 | |
| 248 | default: |
| 249 | break; |
| 250 | }; |
| 251 | |
| 252 | // Process all other functions which could be defined as builtins. |
| 253 | if (Rule.isNull()) { |
| 254 | if (C.isCLibraryFunction(FDecl, "snprintf") || |
| 255 | C.isCLibraryFunction(FDecl, "sprintf")) |
| 256 | return TaintPropagationRule(InvalidArgIndex, 0, true); |
| 257 | else if (C.isCLibraryFunction(FDecl, "strcpy") || |
| 258 | C.isCLibraryFunction(FDecl, "stpcpy") || |
| 259 | C.isCLibraryFunction(FDecl, "strcat")) |
| 260 | return TaintPropagationRule(1, 0, true); |
| 261 | else if (C.isCLibraryFunction(FDecl, "bcopy")) |
| 262 | return TaintPropagationRule(0, 2, 1, false); |
| 263 | else if (C.isCLibraryFunction(FDecl, "strdup") || |
| 264 | C.isCLibraryFunction(FDecl, "strdupa")) |
| 265 | return TaintPropagationRule(0, ReturnValueIndex); |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 266 | else if (C.isCLibraryFunction(FDecl, "wcsdup")) |
| 267 | return TaintPropagationRule(0, ReturnValueIndex); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 268 | } |
| 269 | |
| 270 | // Skipping the following functions, since they might be used for cleansing |
| 271 | // or smart memory copy: |
Benjamin Kramer | 474261a | 2012-06-02 10:20:41 +0000 | [diff] [blame] | 272 | // - memccpy - copying until hitting a special character. |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 273 | |
| 274 | return TaintPropagationRule(); |
Anna Zaks | 457c687 | 2011-11-18 02:26:36 +0000 | [diff] [blame] | 275 | } |
| 276 | |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 277 | void GenericTaintChecker::checkPreStmt(const CallExpr *CE, |
| 278 | CheckerContext &C) const { |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 279 | // Check for errors first. |
| 280 | if (checkPre(CE, C)) |
| 281 | return; |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 282 | |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 283 | // Add taint second. |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 284 | addSourcesPre(CE, C); |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 285 | } |
| 286 | |
| 287 | void GenericTaintChecker::checkPostStmt(const CallExpr *CE, |
| 288 | CheckerContext &C) const { |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 289 | if (propagateFromPre(CE, C)) |
| 290 | return; |
| 291 | addSourcesPost(CE, C); |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 292 | } |
| 293 | |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 294 | void GenericTaintChecker::addSourcesPre(const CallExpr *CE, |
| 295 | CheckerContext &C) const { |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 296 | ProgramStateRef State = nullptr; |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 297 | const FunctionDecl *FDecl = C.getCalleeDecl(CE); |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 298 | if (!FDecl || FDecl->getKind() != Decl::Function) |
| 299 | return; |
| 300 | |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 301 | StringRef Name = C.getCalleeName(FDecl); |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 302 | if (Name.empty()) |
| 303 | return; |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 304 | |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 305 | // First, try generating a propagation rule for this function. |
| 306 | TaintPropagationRule Rule = |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 307 | TaintPropagationRule::getTaintPropagationRule(FDecl, Name, C); |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 308 | if (!Rule.isNull()) { |
Anna Zaks | 7f6a6b7 | 2012-01-18 02:45:13 +0000 | [diff] [blame] | 309 | State = Rule.process(CE, C); |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 310 | if (!State) |
| 311 | return; |
| 312 | C.addTransition(State); |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 313 | return; |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 314 | } |
| 315 | |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 316 | // Otherwise, check if we have custom pre-processing implemented. |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 317 | FnCheck evalFunction = llvm::StringSwitch<FnCheck>(Name) |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 318 | .Case("fscanf", &GenericTaintChecker::preFscanf) |
| 319 | .Default(nullptr); |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 320 | // Check and evaluate the call. |
| 321 | if (evalFunction) |
| 322 | State = (this->*evalFunction)(CE, C); |
| 323 | if (!State) |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 324 | return; |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 325 | C.addTransition(State); |
| 326 | } |
| 327 | |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 328 | bool GenericTaintChecker::propagateFromPre(const CallExpr *CE, |
| 329 | CheckerContext &C) const { |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 330 | ProgramStateRef State = C.getState(); |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 331 | |
| 332 | // Depending on what was tainted at pre-visit, we determined a set of |
| 333 | // arguments which should be tainted after the function returns. These are |
| 334 | // stored in the state as TaintArgsOnPostVisit set. |
Jordan Rose | 0c153cb | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 335 | TaintArgsOnPostVisitTy TaintArgs = State->get<TaintArgsOnPostVisit>(); |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 336 | if (TaintArgs.isEmpty()) |
| 337 | return false; |
| 338 | |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 339 | for (llvm::ImmutableSet<unsigned>::iterator I = TaintArgs.begin(), |
| 340 | E = TaintArgs.end(); |
| 341 | I != E; ++I) { |
| 342 | unsigned ArgNum = *I; |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 343 | |
| 344 | // Special handling for the tainted return value. |
| 345 | if (ArgNum == ReturnValueIndex) { |
| 346 | State = State->addTaint(CE, C.getLocationContext()); |
| 347 | continue; |
| 348 | } |
| 349 | |
| 350 | // The arguments are pointer arguments. The data they are pointing at is |
| 351 | // tainted after the call. |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 352 | if (CE->getNumArgs() < (ArgNum + 1)) |
| 353 | return false; |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 354 | const Expr *Arg = CE->getArg(ArgNum); |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 355 | Optional<SVal> V = getPointedToSVal(C, Arg); |
| 356 | if (V) |
| 357 | State = State->addTaint(*V); |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 358 | } |
| 359 | |
| 360 | // Clear up the taint info from the state. |
| 361 | State = State->remove<TaintArgsOnPostVisit>(); |
| 362 | |
| 363 | if (State != C.getState()) { |
| 364 | C.addTransition(State); |
| 365 | return true; |
| 366 | } |
| 367 | return false; |
| 368 | } |
| 369 | |
| 370 | void GenericTaintChecker::addSourcesPost(const CallExpr *CE, |
| 371 | CheckerContext &C) const { |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 372 | // Define the attack surface. |
| 373 | // Set the evaluation function by switching on the callee name. |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 374 | const FunctionDecl *FDecl = C.getCalleeDecl(CE); |
| 375 | if (!FDecl || FDecl->getKind() != Decl::Function) |
| 376 | return; |
| 377 | |
| 378 | StringRef Name = C.getCalleeName(FDecl); |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 379 | if (Name.empty()) |
| 380 | return; |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 381 | FnCheck evalFunction = |
| 382 | llvm::StringSwitch<FnCheck>(Name) |
| 383 | .Case("scanf", &GenericTaintChecker::postScanf) |
| 384 | // TODO: Add support for vfscanf & family. |
| 385 | .Case("getchar", &GenericTaintChecker::postRetTaint) |
| 386 | .Case("getchar_unlocked", &GenericTaintChecker::postRetTaint) |
| 387 | .Case("getenv", &GenericTaintChecker::postRetTaint) |
| 388 | .Case("fopen", &GenericTaintChecker::postRetTaint) |
| 389 | .Case("fdopen", &GenericTaintChecker::postRetTaint) |
| 390 | .Case("freopen", &GenericTaintChecker::postRetTaint) |
| 391 | .Case("getch", &GenericTaintChecker::postRetTaint) |
| 392 | .Case("wgetch", &GenericTaintChecker::postRetTaint) |
| 393 | .Case("socket", &GenericTaintChecker::postSocket) |
| 394 | .Default(nullptr); |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 395 | |
| 396 | // If the callee isn't defined, it is not of security concern. |
| 397 | // Check and evaluate the call. |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 398 | ProgramStateRef State = nullptr; |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 399 | if (evalFunction) |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 400 | State = (this->*evalFunction)(CE, C); |
| 401 | if (!State) |
| 402 | return; |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 403 | |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 404 | C.addTransition(State); |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 405 | } |
Anna Zaks | 457c687 | 2011-11-18 02:26:36 +0000 | [diff] [blame] | 406 | |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 407 | bool GenericTaintChecker::checkPre(const CallExpr *CE, |
| 408 | CheckerContext &C) const { |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 409 | |
| 410 | if (checkUncontrolledFormatString(CE, C)) |
| 411 | return true; |
| 412 | |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 413 | const FunctionDecl *FDecl = C.getCalleeDecl(CE); |
Jordan Rose | 6cd16c5 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 414 | if (!FDecl || FDecl->getKind() != Decl::Function) |
| 415 | return false; |
| 416 | |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 417 | StringRef Name = C.getCalleeName(FDecl); |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 418 | if (Name.empty()) |
| 419 | return false; |
| 420 | |
| 421 | if (checkSystemCall(CE, Name, C)) |
| 422 | return true; |
| 423 | |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 424 | if (checkTaintedBufferSize(CE, FDecl, C)) |
| 425 | return true; |
| 426 | |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 427 | return false; |
| 428 | } |
| 429 | |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 430 | Optional<SVal> GenericTaintChecker::getPointedToSVal(CheckerContext &C, |
Artem Dergachev | 3ef5deb | 2017-12-12 02:27:55 +0000 | [diff] [blame] | 431 | const Expr *Arg) { |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 432 | ProgramStateRef State = C.getState(); |
George Karpenkov | d703ec9 | 2018-01-17 20:27:29 +0000 | [diff] [blame] | 433 | SVal AddrVal = C.getSVal(Arg->IgnoreParens()); |
Anna Zaks | e48ee50 | 2011-12-16 18:28:50 +0000 | [diff] [blame] | 434 | if (AddrVal.isUnknownOrUndef()) |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 435 | return None; |
Anna Zaks | 7c96b7d | 2011-12-11 18:43:40 +0000 | [diff] [blame] | 436 | |
David Blaikie | 05785d1 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 437 | Optional<Loc> AddrLoc = AddrVal.getAs<Loc>(); |
Anna Zaks | 7f6a6b7 | 2012-01-18 02:45:13 +0000 | [diff] [blame] | 438 | if (!AddrLoc) |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 439 | return None; |
Anna Zaks | 457c687 | 2011-11-18 02:26:36 +0000 | [diff] [blame] | 440 | |
Artem Dergachev | 3ef5deb | 2017-12-12 02:27:55 +0000 | [diff] [blame] | 441 | QualType ArgTy = Arg->getType().getCanonicalType(); |
| 442 | if (!ArgTy->isPointerType()) |
| 443 | return None; |
| 444 | |
| 445 | QualType ValTy = ArgTy->getPointeeType(); |
| 446 | |
| 447 | // Do not dereference void pointers. Treat them as byte pointers instead. |
| 448 | // FIXME: we might want to consider more than just the first byte. |
| 449 | if (ValTy->isVoidType()) |
| 450 | ValTy = C.getASTContext().CharTy; |
| 451 | |
| 452 | return State->getSVal(*AddrLoc, ValTy); |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 453 | } |
| 454 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 455 | ProgramStateRef |
Anna Zaks | 7f6a6b7 | 2012-01-18 02:45:13 +0000 | [diff] [blame] | 456 | GenericTaintChecker::TaintPropagationRule::process(const CallExpr *CE, |
| 457 | CheckerContext &C) const { |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 458 | ProgramStateRef State = C.getState(); |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 459 | |
| 460 | // Check for taint in arguments. |
| 461 | bool IsTainted = false; |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 462 | for (ArgVector::const_iterator I = SrcArgs.begin(), E = SrcArgs.end(); I != E; |
| 463 | ++I) { |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 464 | unsigned ArgNum = *I; |
| 465 | |
| 466 | if (ArgNum == InvalidArgIndex) { |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 467 | // Check if any of the arguments is tainted, but skip the |
| 468 | // destination arguments. |
| 469 | for (unsigned int i = 0; i < CE->getNumArgs(); ++i) { |
Anna Zaks | 7f6a6b7 | 2012-01-18 02:45:13 +0000 | [diff] [blame] | 470 | if (isDestinationArgument(i)) |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 471 | continue; |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 472 | if ((IsTainted = isTaintedOrPointsToTainted(CE->getArg(i), State, C))) |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 473 | break; |
Anna Zaks | 5d324e5 | 2012-01-18 02:45:07 +0000 | [diff] [blame] | 474 | } |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 475 | break; |
| 476 | } |
| 477 | |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 478 | if (CE->getNumArgs() < (ArgNum + 1)) |
| 479 | return State; |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 480 | if ((IsTainted = isTaintedOrPointsToTainted(CE->getArg(ArgNum), State, C))) |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 481 | break; |
| 482 | } |
| 483 | if (!IsTainted) |
| 484 | return State; |
| 485 | |
| 486 | // Mark the arguments which should be tainted after the function returns. |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 487 | for (ArgVector::const_iterator I = DstArgs.begin(), E = DstArgs.end(); I != E; |
| 488 | ++I) { |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 489 | unsigned ArgNum = *I; |
| 490 | |
| 491 | // Should we mark all arguments as tainted? |
| 492 | if (ArgNum == InvalidArgIndex) { |
| 493 | // For all pointer and references that were passed in: |
| 494 | // If they are not pointing to const data, mark data as tainted. |
| 495 | // TODO: So far we are just going one level down; ideally we'd need to |
| 496 | // recurse here. |
| 497 | for (unsigned int i = 0; i < CE->getNumArgs(); ++i) { |
| 498 | const Expr *Arg = CE->getArg(i); |
| 499 | // Process pointer argument. |
| 500 | const Type *ArgTy = Arg->getType().getTypePtr(); |
| 501 | QualType PType = ArgTy->getPointeeType(); |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 502 | if ((!PType.isNull() && !PType.isConstQualified()) || |
| 503 | (ArgTy->isReferenceType() && !Arg->getType().isConstQualified())) |
Anna Zaks | 3666d2c | 2012-01-17 00:37:02 +0000 | [diff] [blame] | 504 | State = State->add<TaintArgsOnPostVisit>(i); |
| 505 | } |
| 506 | continue; |
| 507 | } |
| 508 | |
| 509 | // Should mark the return value? |
| 510 | if (ArgNum == ReturnValueIndex) { |
| 511 | State = State->add<TaintArgsOnPostVisit>(ReturnValueIndex); |
| 512 | continue; |
| 513 | } |
| 514 | |
| 515 | // Mark the given argument. |
| 516 | assert(ArgNum < CE->getNumArgs()); |
| 517 | State = State->add<TaintArgsOnPostVisit>(ArgNum); |
| 518 | } |
| 519 | |
| 520 | return State; |
| 521 | } |
| 522 | |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 523 | // If argument 0 (file descriptor) is tainted, all arguments except for arg 0 |
| 524 | // and arg 1 should get taint. |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 525 | ProgramStateRef GenericTaintChecker::preFscanf(const CallExpr *CE, |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 526 | CheckerContext &C) const { |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 527 | assert(CE->getNumArgs() >= 2); |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 528 | ProgramStateRef State = C.getState(); |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 529 | |
| 530 | // Check is the file descriptor is tainted. |
Ted Kremenek | 632e3b7 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 531 | if (State->isTainted(CE->getArg(0), C.getLocationContext()) || |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 532 | isStdin(CE->getArg(0), C)) { |
| 533 | // All arguments except for the first two should get taint. |
| 534 | for (unsigned int i = 2; i < CE->getNumArgs(); ++i) |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 535 | State = State->add<TaintArgsOnPostVisit>(i); |
Anna Zaks | b3fa8d7 | 2012-01-12 02:22:34 +0000 | [diff] [blame] | 536 | return State; |
| 537 | } |
| 538 | |
Craig Topper | 0dbb783 | 2014-05-27 02:45:47 +0000 | [diff] [blame] | 539 | return nullptr; |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 540 | } |
| 541 | |
Anna Zaks | 3b754b2 | 2012-01-20 00:11:19 +0000 | [diff] [blame] | 542 | // If argument 0(protocol domain) is network, the return value should get taint. |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 543 | ProgramStateRef GenericTaintChecker::postSocket(const CallExpr *CE, |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 544 | CheckerContext &C) const { |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 545 | ProgramStateRef State = C.getState(); |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 546 | if (CE->getNumArgs() < 3) |
| 547 | return State; |
Anna Zaks | 3b754b2 | 2012-01-20 00:11:19 +0000 | [diff] [blame] | 548 | |
| 549 | SourceLocation DomLoc = CE->getArg(0)->getExprLoc(); |
| 550 | StringRef DomName = C.getMacroNameOrSpelling(DomLoc); |
| 551 | // White list the internal communication protocols. |
| 552 | if (DomName.equals("AF_SYSTEM") || DomName.equals("AF_LOCAL") || |
| 553 | DomName.equals("AF_UNIX") || DomName.equals("AF_RESERVED_36")) |
| 554 | return State; |
| 555 | State = State->addTaint(CE, C.getLocationContext()); |
| 556 | return State; |
| 557 | } |
| 558 | |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 559 | ProgramStateRef GenericTaintChecker::postScanf(const CallExpr *CE, |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 560 | CheckerContext &C) const { |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 561 | ProgramStateRef State = C.getState(); |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 562 | if (CE->getNumArgs() < 2) |
| 563 | return State; |
| 564 | |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 565 | // All arguments except for the very first one should get taint. |
| 566 | for (unsigned int i = 1; i < CE->getNumArgs(); ++i) { |
| 567 | // The arguments are pointer arguments. The data they are pointing at is |
| 568 | // tainted after the call. |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 569 | const Expr *Arg = CE->getArg(i); |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 570 | Optional<SVal> V = getPointedToSVal(C, Arg); |
| 571 | if (V) |
| 572 | State = State->addTaint(*V); |
Anna Zaks | eefc0e9 | 2011-12-14 00:56:02 +0000 | [diff] [blame] | 573 | } |
Anna Zaks | 3b0ab20 | 2011-12-17 00:26:34 +0000 | [diff] [blame] | 574 | return State; |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 575 | } |
| 576 | |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 577 | ProgramStateRef GenericTaintChecker::postRetTaint(const CallExpr *CE, |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 578 | CheckerContext &C) const { |
Ted Kremenek | 632e3b7 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 579 | return C.getState()->addTaint(CE, C.getLocationContext()); |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 580 | } |
| 581 | |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 582 | bool GenericTaintChecker::isStdin(const Expr *E, CheckerContext &C) { |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 583 | ProgramStateRef State = C.getState(); |
George Karpenkov | d703ec9 | 2018-01-17 20:27:29 +0000 | [diff] [blame] | 584 | SVal Val = C.getSVal(E); |
Anna Zaks | 099fe3f | 2011-12-14 00:56:18 +0000 | [diff] [blame] | 585 | |
Anna Zaks | e48ee50 | 2011-12-16 18:28:50 +0000 | [diff] [blame] | 586 | // stdin is a pointer, so it would be a region. |
| 587 | const MemRegion *MemReg = Val.getAsRegion(); |
| 588 | |
| 589 | // The region should be symbolic, we do not know it's value. |
| 590 | const SymbolicRegion *SymReg = dyn_cast_or_null<SymbolicRegion>(MemReg); |
| 591 | if (!SymReg) |
Anna Zaks | 099fe3f | 2011-12-14 00:56:18 +0000 | [diff] [blame] | 592 | return false; |
| 593 | |
Anna Zaks | e48ee50 | 2011-12-16 18:28:50 +0000 | [diff] [blame] | 594 | // Get it's symbol and find the declaration region it's pointing to. |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 595 | const SymbolRegionValue *Sm = |
| 596 | dyn_cast<SymbolRegionValue>(SymReg->getSymbol()); |
Anna Zaks | e48ee50 | 2011-12-16 18:28:50 +0000 | [diff] [blame] | 597 | if (!Sm) |
| 598 | return false; |
| 599 | const DeclRegion *DeclReg = dyn_cast_or_null<DeclRegion>(Sm->getRegion()); |
| 600 | if (!DeclReg) |
| 601 | return false; |
Anna Zaks | 099fe3f | 2011-12-14 00:56:18 +0000 | [diff] [blame] | 602 | |
Anna Zaks | e48ee50 | 2011-12-16 18:28:50 +0000 | [diff] [blame] | 603 | // This region corresponds to a declaration, find out if it's a global/extern |
| 604 | // variable named stdin with the proper type. |
| 605 | if (const VarDecl *D = dyn_cast_or_null<VarDecl>(DeclReg->getDecl())) { |
| 606 | D = D->getCanonicalDecl(); |
| 607 | if ((D->getName().find("stdin") != StringRef::npos) && D->isExternC()) |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 608 | if (const PointerType *PtrTy = |
Anna Zaks | e48ee50 | 2011-12-16 18:28:50 +0000 | [diff] [blame] | 609 | dyn_cast<PointerType>(D->getType().getTypePtr())) |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 610 | if (PtrTy->getPointeeType().getCanonicalType() == |
| 611 | C.getASTContext().getFILEType().getCanonicalType()) |
| 612 | return true; |
Anna Zaks | e48ee50 | 2011-12-16 18:28:50 +0000 | [diff] [blame] | 613 | } |
Anna Zaks | 099fe3f | 2011-12-14 00:56:18 +0000 | [diff] [blame] | 614 | return false; |
| 615 | } |
| 616 | |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 617 | static bool getPrintfFormatArgumentNum(const CallExpr *CE, |
| 618 | const CheckerContext &C, |
| 619 | unsigned int &ArgNum) { |
| 620 | // Find if the function contains a format string argument. |
| 621 | // Handles: fprintf, printf, sprintf, snprintf, vfprintf, vprintf, vsprintf, |
| 622 | // vsnprintf, syslog, custom annotated functions. |
| 623 | const FunctionDecl *FDecl = C.getCalleeDecl(CE); |
| 624 | if (!FDecl) |
| 625 | return false; |
Aaron Ballman | be22bcb | 2014-03-10 17:08:28 +0000 | [diff] [blame] | 626 | for (const auto *Format : FDecl->specific_attrs<FormatAttr>()) { |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 627 | ArgNum = Format->getFormatIdx() - 1; |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 628 | if ((Format->getType()->getName() == "printf") && CE->getNumArgs() > ArgNum) |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 629 | return true; |
| 630 | } |
| 631 | |
| 632 | // Or if a function is named setproctitle (this is a heuristic). |
| 633 | if (C.getCalleeName(CE).find("setproctitle") != StringRef::npos) { |
| 634 | ArgNum = 0; |
| 635 | return true; |
| 636 | } |
| 637 | |
| 638 | return false; |
| 639 | } |
| 640 | |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 641 | bool GenericTaintChecker::generateReportIfTainted(const Expr *E, |
| 642 | const char Msg[], |
| 643 | CheckerContext &C) const { |
| 644 | assert(E); |
| 645 | |
| 646 | // Check for taint. |
Ted Kremenek | 49b1e38 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 647 | ProgramStateRef State = C.getState(); |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 648 | Optional<SVal> PointedToSVal = getPointedToSVal(C, E); |
Anna Zaks | d4e43ae | 2017-03-09 00:01:07 +0000 | [diff] [blame] | 649 | SVal TaintedSVal; |
Artem Dergachev | eed7a31 | 2017-05-29 15:42:56 +0000 | [diff] [blame] | 650 | if (PointedToSVal && State->isTainted(*PointedToSVal)) |
| 651 | TaintedSVal = *PointedToSVal; |
Anna Zaks | d4e43ae | 2017-03-09 00:01:07 +0000 | [diff] [blame] | 652 | else if (State->isTainted(E, C.getLocationContext())) |
| 653 | TaintedSVal = C.getSVal(E); |
| 654 | else |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 655 | return false; |
| 656 | |
| 657 | // Generate diagnostic. |
Devin Coughlin | e39bd40 | 2015-09-16 22:03:05 +0000 | [diff] [blame] | 658 | if (ExplodedNode *N = C.generateNonFatalErrorNode()) { |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 659 | initBugType(); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 660 | auto report = llvm::make_unique<BugReport>(*BT, Msg, N); |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 661 | report->addRange(E->getSourceRange()); |
Anna Zaks | d4e43ae | 2017-03-09 00:01:07 +0000 | [diff] [blame] | 662 | report->addVisitor(llvm::make_unique<TaintBugVisitor>(TaintedSVal)); |
Aaron Ballman | 8d3a7a5 | 2015-06-23 13:15:32 +0000 | [diff] [blame] | 663 | C.emitReport(std::move(report)); |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 664 | return true; |
| 665 | } |
| 666 | return false; |
| 667 | } |
| 668 | |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 669 | bool GenericTaintChecker::checkUncontrolledFormatString( |
| 670 | const CallExpr *CE, CheckerContext &C) const { |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 671 | // Check if the function contains a format string argument. |
| 672 | unsigned int ArgNum = 0; |
| 673 | if (!getPrintfFormatArgumentNum(CE, C, ArgNum)) |
| 674 | return false; |
| 675 | |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 676 | // If either the format string content or the pointer itself are tainted, |
| 677 | // warn. |
Alexander Kornienko | 9c10490 | 2015-12-28 13:06:58 +0000 | [diff] [blame] | 678 | return generateReportIfTainted(CE->getArg(ArgNum), |
| 679 | MsgUncontrolledFormatString, C); |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 680 | } |
| 681 | |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 682 | bool GenericTaintChecker::checkSystemCall(const CallExpr *CE, StringRef Name, |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 683 | CheckerContext &C) const { |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 684 | // TODO: It might make sense to run this check on demand. In some cases, |
| 685 | // we should check if the environment has been cleansed here. We also might |
Anna Zaks | bf74051 | 2012-01-24 19:32:25 +0000 | [diff] [blame] | 686 | // need to know if the user was reset before these calls(seteuid). |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 687 | unsigned ArgNum = llvm::StringSwitch<unsigned>(Name) |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 688 | .Case("system", 0) |
| 689 | .Case("popen", 0) |
| 690 | .Case("execl", 0) |
| 691 | .Case("execle", 0) |
| 692 | .Case("execlp", 0) |
| 693 | .Case("execv", 0) |
| 694 | .Case("execvp", 0) |
| 695 | .Case("execvP", 0) |
| 696 | .Case("execve", 0) |
| 697 | .Case("dlopen", 0) |
| 698 | .Default(UINT_MAX); |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 699 | |
Anna Zaks | b508d29 | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 700 | if (ArgNum == UINT_MAX || CE->getNumArgs() < (ArgNum + 1)) |
Anna Zaks | 0244cd7 | 2012-01-14 02:48:40 +0000 | [diff] [blame] | 701 | return false; |
| 702 | |
Alexander Kornienko | 9c10490 | 2015-12-28 13:06:58 +0000 | [diff] [blame] | 703 | return generateReportIfTainted(CE->getArg(ArgNum), MsgSanitizeSystemArgs, C); |
Anna Zaks | 126a2ef | 2012-01-07 02:33:10 +0000 | [diff] [blame] | 704 | } |
| 705 | |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 706 | // TODO: Should this check be a part of the CString checker? |
| 707 | // If yes, should taint be a global setting? |
| 708 | bool GenericTaintChecker::checkTaintedBufferSize(const CallExpr *CE, |
| 709 | const FunctionDecl *FDecl, |
| 710 | CheckerContext &C) const { |
| 711 | // If the function has a buffer size argument, set ArgNum. |
| 712 | unsigned ArgNum = InvalidArgIndex; |
| 713 | unsigned BId = 0; |
Artem Dergachev | b68cb54 | 2018-12-19 23:35:08 +0000 | [diff] [blame] | 714 | if ((BId = FDecl->getMemoryFunctionKind())) |
| 715 | switch (BId) { |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 716 | case Builtin::BImemcpy: |
| 717 | case Builtin::BImemmove: |
| 718 | case Builtin::BIstrncpy: |
| 719 | ArgNum = 2; |
| 720 | break; |
| 721 | case Builtin::BIstrndup: |
| 722 | ArgNum = 1; |
| 723 | break; |
| 724 | default: |
| 725 | break; |
| 726 | }; |
| 727 | |
| 728 | if (ArgNum == InvalidArgIndex) { |
| 729 | if (C.isCLibraryFunction(FDecl, "malloc") || |
| 730 | C.isCLibraryFunction(FDecl, "calloc") || |
| 731 | C.isCLibraryFunction(FDecl, "alloca")) |
| 732 | ArgNum = 0; |
| 733 | else if (C.isCLibraryFunction(FDecl, "memccpy")) |
| 734 | ArgNum = 3; |
| 735 | else if (C.isCLibraryFunction(FDecl, "realloc")) |
| 736 | ArgNum = 1; |
| 737 | else if (C.isCLibraryFunction(FDecl, "bcopy")) |
| 738 | ArgNum = 2; |
| 739 | } |
| 740 | |
Alexander Kornienko | 9c10490 | 2015-12-28 13:06:58 +0000 | [diff] [blame] | 741 | return ArgNum != InvalidArgIndex && CE->getNumArgs() > ArgNum && |
| 742 | generateReportIfTainted(CE->getArg(ArgNum), MsgTaintedBufferSize, C); |
Anna Zaks | 560dbe9 | 2012-01-18 02:45:11 +0000 | [diff] [blame] | 743 | } |
| 744 | |
Anna Zaks | 5c5bf9b | 2011-11-16 19:58:13 +0000 | [diff] [blame] | 745 | void ento::registerGenericTaintChecker(CheckerManager &mgr) { |
| 746 | mgr.registerChecker<GenericTaintChecker>(); |
| 747 | } |