Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 1 | //===--- MacroUsageCheck.cpp - clang-tidy----------------------------------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | |
| 10 | #include "MacroUsageCheck.h" |
| 11 | #include "clang/Frontend/CompilerInstance.h" |
| 12 | #include "clang/Lex/PPCallbacks.h" |
| 13 | #include "llvm/ADT/STLExtras.h" |
| 14 | #include "llvm/Support/Regex.h" |
| 15 | #include <algorithm> |
Jonas Toth | 74f201c | 2018-10-22 20:29:15 +0000 | [diff] [blame] | 16 | #include <cctype> |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 17 | |
| 18 | namespace clang { |
| 19 | namespace tidy { |
| 20 | namespace cppcoreguidelines { |
| 21 | |
| 22 | namespace { |
| 23 | |
| 24 | bool isCapsOnly(StringRef Name) { |
| 25 | return std::all_of(Name.begin(), Name.end(), [](const char c) { |
| 26 | if (std::isupper(c) || std::isdigit(c) || c == '_') |
| 27 | return true; |
| 28 | return false; |
| 29 | }); |
| 30 | } |
| 31 | |
| 32 | class MacroUsageCallbacks : public PPCallbacks { |
| 33 | public: |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 34 | MacroUsageCallbacks(MacroUsageCheck *Check, const SourceManager &SM, |
| 35 | StringRef RegExp, bool CapsOnly, bool IgnoreCommandLine) |
| 36 | : Check(Check), SM(SM), RegExp(RegExp), CheckCapsOnly(CapsOnly), |
| 37 | IgnoreCommandLineMacros(IgnoreCommandLine) {} |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 38 | void MacroDefined(const Token &MacroNameTok, |
| 39 | const MacroDirective *MD) override { |
| 40 | if (MD->getMacroInfo()->isUsedForHeaderGuard() || |
| 41 | MD->getMacroInfo()->getNumTokens() == 0) |
| 42 | return; |
| 43 | |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 44 | if (IgnoreCommandLineMacros && |
| 45 | SM.isWrittenInCommandLineFile(MD->getLocation())) |
| 46 | return; |
| 47 | |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 48 | StringRef MacroName = MacroNameTok.getIdentifierInfo()->getName(); |
| 49 | if (!CheckCapsOnly && !llvm::Regex(RegExp).match(MacroName)) |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 50 | Check->warnMacro(MD, MacroName); |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 51 | |
| 52 | if (CheckCapsOnly && !isCapsOnly(MacroName)) |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 53 | Check->warnNaming(MD, MacroName); |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 54 | } |
| 55 | |
| 56 | private: |
| 57 | MacroUsageCheck *Check; |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 58 | const SourceManager &SM; |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 59 | StringRef RegExp; |
| 60 | bool CheckCapsOnly; |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 61 | bool IgnoreCommandLineMacros; |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 62 | }; |
| 63 | } // namespace |
| 64 | |
| 65 | void MacroUsageCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { |
| 66 | Options.store(Opts, "AllowedRegexp", AllowedRegexp); |
| 67 | Options.store(Opts, "CheckCapsOnly", CheckCapsOnly); |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 68 | Options.store(Opts, "IgnoreCommandLineMacros", IgnoreCommandLineMacros); |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 69 | } |
| 70 | |
| 71 | void MacroUsageCheck::registerPPCallbacks(CompilerInstance &Compiler) { |
| 72 | if (!getLangOpts().CPlusPlus11) |
| 73 | return; |
| 74 | |
| 75 | Compiler.getPreprocessor().addPPCallbacks( |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 76 | llvm::make_unique<MacroUsageCallbacks>(this, Compiler.getSourceManager(), |
| 77 | AllowedRegexp, CheckCapsOnly, |
| 78 | IgnoreCommandLineMacros)); |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 79 | } |
| 80 | |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 81 | void MacroUsageCheck::warnMacro(const MacroDirective *MD, StringRef MacroName) { |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 82 | StringRef Message = |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 83 | "macro '%0' used to declare a constant; consider using a 'constexpr' " |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 84 | "constant"; |
| 85 | |
| 86 | /// A variadic macro is function-like at the same time. Therefore variadic |
| 87 | /// macros are checked first and will be excluded for the function-like |
| 88 | /// diagnostic. |
| 89 | if (MD->getMacroInfo()->isVariadic()) |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 90 | Message = "variadic macro '%0' used; consider using a 'constexpr' " |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 91 | "variadic template function"; |
| 92 | else if (MD->getMacroInfo()->isFunctionLike()) |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 93 | Message = "function-like macro '%0' used; consider a 'constexpr' template " |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 94 | "function"; |
| 95 | |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 96 | diag(MD->getLocation(), Message) << MacroName; |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 97 | } |
| 98 | |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 99 | void MacroUsageCheck::warnNaming(const MacroDirective *MD, |
| 100 | StringRef MacroName) { |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 101 | diag(MD->getLocation(), "macro definition does not define the macro name " |
Roman Lebedev | c367ba1 | 2018-10-30 15:52:36 +0000 | [diff] [blame] | 102 | "'%0' using all uppercase characters") |
| 103 | << MacroName; |
Jonas Toth | 552b62e | 2018-10-22 19:20:01 +0000 | [diff] [blame] | 104 | } |
| 105 | |
| 106 | } // namespace cppcoreguidelines |
| 107 | } // namespace tidy |
| 108 | } // namespace clang |