blob: fd75c02bb1ed30650a8db0a2be200514659eee5b [file] [log] [blame]
Francois Pichet2731b7d2011-09-09 11:02:57 +00001//===--- JumpDiagnostics.cpp - Protected scope jump analysis ------*- C++ -*-=//
Chris Lattner1a1fdbd2009-04-19 04:46:21 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the JumpScopeChecker class, which is used to diagnose
Francois Pichet2731b7d2011-09-09 11:02:57 +000011// jumps that enter a protected scope in an invalid way.
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000012//
13//===----------------------------------------------------------------------===//
14
John McCall83024632010-08-25 22:03:47 +000015#include "clang/Sema/SemaInternal.h"
John McCall28a0cf72010-08-25 07:42:41 +000016#include "clang/AST/DeclCXX.h"
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000017#include "clang/AST/Expr.h"
Douglas Gregor27d0c442011-05-27 16:05:29 +000018#include "clang/AST/ExprCXX.h"
Sebastian Redl4de47b42009-04-27 20:27:31 +000019#include "clang/AST/StmtCXX.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000020#include "clang/AST/StmtObjC.h"
Douglas Gregorc3a6ade2010-08-12 20:07:10 +000021#include "llvm/ADT/BitVector.h"
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000022using namespace clang;
23
24namespace {
25
26/// JumpScopeChecker - This object is used by Sema to diagnose invalid jumps
27/// into VLA and other protected scopes. For example, this rejects:
28/// goto L;
29/// int a[n];
30/// L:
31///
32class JumpScopeChecker {
33 Sema &S;
Mike Stump11289f42009-09-09 15:08:12 +000034
Alp Tokere265cf12014-05-09 08:40:10 +000035 /// Permissive - True when recovering from errors, in which case precautions
36 /// are taken to handle incomplete scope information.
37 const bool Permissive;
38
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000039 /// GotoScope - This is a record that we use to keep track of all of the
40 /// scopes that are introduced by VLAs and other things that scope jumps like
41 /// gotos. This scope tree has nothing to do with the source scope tree,
42 /// because you can have multiple VLA scopes per compound statement, and most
43 /// compound statements don't introduce any scopes.
44 struct GotoScope {
45 /// ParentScope - The index in ScopeMap of the parent scope. This is 0 for
46 /// the parent scope is the function body.
47 unsigned ParentScope;
Mike Stump11289f42009-09-09 15:08:12 +000048
Richard Smithfe2750d2011-10-20 21:42:12 +000049 /// InDiag - The note to emit if there is a jump into this scope.
John McCallcf819ab2010-05-12 00:58:13 +000050 unsigned InDiag;
51
Richard Smithfe2750d2011-10-20 21:42:12 +000052 /// OutDiag - The note to emit if there is an indirect jump out
John McCallcf819ab2010-05-12 00:58:13 +000053 /// of this scope. Direct jumps always clean up their current scope
54 /// in an orderly way.
55 unsigned OutDiag;
Mike Stump11289f42009-09-09 15:08:12 +000056
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000057 /// Loc - Location to emit the diagnostic.
58 SourceLocation Loc;
Mike Stump11289f42009-09-09 15:08:12 +000059
John McCallcf819ab2010-05-12 00:58:13 +000060 GotoScope(unsigned parentScope, unsigned InDiag, unsigned OutDiag,
61 SourceLocation L)
62 : ParentScope(parentScope), InDiag(InDiag), OutDiag(OutDiag), Loc(L) {}
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000063 };
Mike Stump11289f42009-09-09 15:08:12 +000064
Chris Lattner0e62c1c2011-07-23 10:55:15 +000065 SmallVector<GotoScope, 48> Scopes;
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000066 llvm::DenseMap<Stmt*, unsigned> LabelAndGotoScopes;
Chris Lattner0e62c1c2011-07-23 10:55:15 +000067 SmallVector<Stmt*, 16> Jumps;
John McCallcf819ab2010-05-12 00:58:13 +000068
Chris Lattner0e62c1c2011-07-23 10:55:15 +000069 SmallVector<IndirectGotoStmt*, 4> IndirectJumps;
70 SmallVector<LabelDecl*, 4> IndirectJumpTargets;
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000071public:
72 JumpScopeChecker(Stmt *Body, Sema &S);
73private:
Douglas Gregor27b98ea2010-06-21 23:44:13 +000074 void BuildScopeInformation(Decl *D, unsigned &ParentScope);
Fariborz Jahanian256d39d2011-07-11 18:04:54 +000075 void BuildScopeInformation(VarDecl *D, const BlockDecl *BDecl,
76 unsigned &ParentScope);
77 void BuildScopeInformation(Stmt *S, unsigned &origParentScope);
78
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000079 void VerifyJumps();
John McCallcf819ab2010-05-12 00:58:13 +000080 void VerifyIndirectJumps();
Bill Wendling8ac06af2012-02-22 09:38:11 +000081 void NoteJumpIntoScopes(ArrayRef<unsigned> ToScopes);
John McCallcf819ab2010-05-12 00:58:13 +000082 void DiagnoseIndirectJump(IndirectGotoStmt *IG, unsigned IGScope,
Chris Lattnerc8e630e2011-02-17 07:39:24 +000083 LabelDecl *Target, unsigned TargetScope);
Francois Pichet051f5e52011-09-13 10:26:51 +000084 void CheckJump(Stmt *From, Stmt *To, SourceLocation DiagLoc,
Richard Smithfe2750d2011-10-20 21:42:12 +000085 unsigned JumpDiag, unsigned JumpDiagWarning,
86 unsigned JumpDiagCXX98Compat);
Ehsan Akhgari31097582014-09-22 02:21:54 +000087 void CheckGotoStmt(GotoStmt *GS);
John McCall42f9f1f2010-05-12 02:37:54 +000088
89 unsigned GetDeepestCommonScope(unsigned A, unsigned B);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000090};
91} // end anonymous namespace
92
Alp Tokere265cf12014-05-09 08:40:10 +000093#define CHECK_PERMISSIVE(x) (assert(Permissive || !(x)), (Permissive && (x)))
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000094
Alp Tokere265cf12014-05-09 08:40:10 +000095JumpScopeChecker::JumpScopeChecker(Stmt *Body, Sema &s)
96 : S(s), Permissive(s.hasAnyUnrecoverableErrorsInThisFunction()) {
Chris Lattner1a1fdbd2009-04-19 04:46:21 +000097 // Add a scope entry for function scope.
John McCallcf819ab2010-05-12 00:58:13 +000098 Scopes.push_back(GotoScope(~0U, ~0U, ~0U, SourceLocation()));
Mike Stump11289f42009-09-09 15:08:12 +000099
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000100 // Build information for the top level compound statement, so that we have a
101 // defined scope record for every "goto" and label.
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000102 unsigned BodyParentScope = 0;
103 BuildScopeInformation(Body, BodyParentScope);
Mike Stump11289f42009-09-09 15:08:12 +0000104
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000105 // Check that all jumps we saw are kosher.
106 VerifyJumps();
John McCallcf819ab2010-05-12 00:58:13 +0000107 VerifyIndirectJumps();
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000108}
Mike Stump11289f42009-09-09 15:08:12 +0000109
John McCall42f9f1f2010-05-12 02:37:54 +0000110/// GetDeepestCommonScope - Finds the innermost scope enclosing the
111/// two scopes.
112unsigned JumpScopeChecker::GetDeepestCommonScope(unsigned A, unsigned B) {
113 while (A != B) {
114 // Inner scopes are created after outer scopes and therefore have
115 // higher indices.
116 if (A < B) {
117 assert(Scopes[B].ParentScope < B);
118 B = Scopes[B].ParentScope;
119 } else {
120 assert(Scopes[A].ParentScope < A);
121 A = Scopes[A].ParentScope;
122 }
123 }
124 return A;
125}
126
John McCall31168b02011-06-15 23:02:42 +0000127typedef std::pair<unsigned,unsigned> ScopePair;
128
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000129/// GetDiagForGotoScopeDecl - If this decl induces a new goto scope, return a
130/// diagnostic that should be emitted if control goes over it. If not, return 0.
Richard Smithc934e4f2013-12-12 01:27:02 +0000131static ScopePair GetDiagForGotoScopeDecl(Sema &S, const Decl *D) {
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000132 if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
Rafael Espindola44938a72012-10-28 02:44:03 +0000133 unsigned InDiag = 0;
Richard Smithc934e4f2013-12-12 01:27:02 +0000134 unsigned OutDiag = 0;
135
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000136 if (VD->getType()->isVariablyModifiedType())
John McCallcf819ab2010-05-12 00:58:13 +0000137 InDiag = diag::note_protected_by_vla;
138
John McCall31168b02011-06-15 23:02:42 +0000139 if (VD->hasAttr<BlocksAttr>())
140 return ScopePair(diag::note_protected_by___block,
141 diag::note_exits___block);
142
143 if (VD->hasAttr<CleanupAttr>())
144 return ScopePair(diag::note_protected_by_cleanup,
145 diag::note_exits_cleanup);
146
Richard Smithc934e4f2013-12-12 01:27:02 +0000147 if (VD->hasLocalStorage()) {
148 switch (VD->getType().isDestructedType()) {
149 case QualType::DK_objc_strong_lifetime:
150 case QualType::DK_objc_weak_lifetime:
Argyrios Kyrtzidiscff00d92011-06-24 00:08:59 +0000151 return ScopePair(diag::note_protected_by_objc_ownership,
152 diag::note_exits_objc_ownership);
Richard Smithc934e4f2013-12-12 01:27:02 +0000153
154 case QualType::DK_cxx_destructor:
155 OutDiag = diag::note_exits_dtor;
156 break;
157
158 case QualType::DK_none:
159 break;
John McCall31168b02011-06-15 23:02:42 +0000160 }
161 }
162
Richard Smithc934e4f2013-12-12 01:27:02 +0000163 const Expr *Init = VD->getInit();
164 if (S.Context.getLangOpts().CPlusPlus && VD->hasLocalStorage() && Init) {
Richard Smithfe2750d2011-10-20 21:42:12 +0000165 // C++11 [stmt.dcl]p3:
John McCall31168b02011-06-15 23:02:42 +0000166 // A program that jumps from a point where a variable with automatic
167 // storage duration is not in scope to a point where it is in scope
168 // is ill-formed unless the variable has scalar type, class type with
169 // a trivial default constructor and a trivial destructor, a
170 // cv-qualified version of one of these types, or an array of one of
171 // the preceding types and is declared without an initializer.
172
173 // C++03 [stmt.dcl.p3:
174 // A program that jumps from a point where a local variable
175 // with automatic storage duration is not in scope to a point
176 // where it is in scope is ill-formed unless the variable has
177 // POD type and is declared without an initializer.
178
Richard Smithc934e4f2013-12-12 01:27:02 +0000179 InDiag = diag::note_protected_by_variable_init;
John McCall31168b02011-06-15 23:02:42 +0000180
Richard Smithc934e4f2013-12-12 01:27:02 +0000181 // For a variable of (array of) class type declared without an
182 // initializer, we will have call-style initialization and the initializer
183 // will be the CXXConstructExpr with no intervening nodes.
184 if (const CXXConstructExpr *CCE = dyn_cast<CXXConstructExpr>(Init)) {
185 const CXXConstructorDecl *Ctor = CCE->getConstructor();
186 if (Ctor->isTrivial() && Ctor->isDefaultConstructor() &&
187 VD->getInitStyle() == VarDecl::CallInit) {
Rafael Espindola44938a72012-10-28 02:44:03 +0000188 if (OutDiag)
189 InDiag = diag::note_protected_by_variable_nontriv_destructor;
Richard Smithc934e4f2013-12-12 01:27:02 +0000190 else if (!Ctor->getParent()->isPOD())
Rafael Espindola44938a72012-10-28 02:44:03 +0000191 InDiag = diag::note_protected_by_variable_non_pod;
Richard Smithc934e4f2013-12-12 01:27:02 +0000192 else
193 InDiag = 0;
Douglas Gregor27d0c442011-05-27 16:05:29 +0000194 }
Douglas Gregor5a5fcd82010-07-01 00:21:21 +0000195 }
John McCallcf819ab2010-05-12 00:58:13 +0000196 }
Rafael Espindola44938a72012-10-28 02:44:03 +0000197
Richard Smithc934e4f2013-12-12 01:27:02 +0000198 return ScopePair(InDiag, OutDiag);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000199 }
Mike Stump11289f42009-09-09 15:08:12 +0000200
Richard Smithc934e4f2013-12-12 01:27:02 +0000201 if (const TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(D)) {
John McCallcf819ab2010-05-12 00:58:13 +0000202 if (TD->getUnderlyingType()->isVariablyModifiedType())
Richard Smithc934e4f2013-12-12 01:27:02 +0000203 return ScopePair(isa<TypedefDecl>(TD)
204 ? diag::note_protected_by_vla_typedef
205 : diag::note_protected_by_vla_type_alias,
206 0);
Richard Smithdda56e42011-04-15 14:24:37 +0000207 }
208
John McCall31168b02011-06-15 23:02:42 +0000209 return ScopePair(0U, 0U);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000210}
211
Douglas Gregor27b98ea2010-06-21 23:44:13 +0000212/// \brief Build scope information for a declaration that is part of a DeclStmt.
213void JumpScopeChecker::BuildScopeInformation(Decl *D, unsigned &ParentScope) {
Douglas Gregor27b98ea2010-06-21 23:44:13 +0000214 // If this decl causes a new scope, push and switch to it.
Richard Smithc934e4f2013-12-12 01:27:02 +0000215 std::pair<unsigned,unsigned> Diags = GetDiagForGotoScopeDecl(S, D);
Douglas Gregor27b98ea2010-06-21 23:44:13 +0000216 if (Diags.first || Diags.second) {
217 Scopes.push_back(GotoScope(ParentScope, Diags.first, Diags.second,
218 D->getLocation()));
219 ParentScope = Scopes.size()-1;
220 }
221
222 // If the decl has an initializer, walk it with the potentially new
223 // scope we just installed.
224 if (VarDecl *VD = dyn_cast<VarDecl>(D))
225 if (Expr *Init = VD->getInit())
226 BuildScopeInformation(Init, ParentScope);
227}
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000228
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000229/// \brief Build scope information for a captured block literal variables.
230void JumpScopeChecker::BuildScopeInformation(VarDecl *D,
231 const BlockDecl *BDecl,
232 unsigned &ParentScope) {
233 // exclude captured __block variables; there's no destructor
234 // associated with the block literal for them.
235 if (D->hasAttr<BlocksAttr>())
236 return;
237 QualType T = D->getType();
238 QualType::DestructionKind destructKind = T.isDestructedType();
239 if (destructKind != QualType::DK_none) {
240 std::pair<unsigned,unsigned> Diags;
241 switch (destructKind) {
242 case QualType::DK_cxx_destructor:
243 Diags = ScopePair(diag::note_enters_block_captures_cxx_obj,
244 diag::note_exits_block_captures_cxx_obj);
245 break;
246 case QualType::DK_objc_strong_lifetime:
247 Diags = ScopePair(diag::note_enters_block_captures_strong,
248 diag::note_exits_block_captures_strong);
249 break;
250 case QualType::DK_objc_weak_lifetime:
251 Diags = ScopePair(diag::note_enters_block_captures_weak,
252 diag::note_exits_block_captures_weak);
253 break;
254 case QualType::DK_none:
Richard Smithfe2750d2011-10-20 21:42:12 +0000255 llvm_unreachable("non-lifetime captured variable");
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000256 }
257 SourceLocation Loc = D->getLocation();
258 if (Loc.isInvalid())
259 Loc = BDecl->getLocation();
260 Scopes.push_back(GotoScope(ParentScope,
261 Diags.first, Diags.second, Loc));
262 ParentScope = Scopes.size()-1;
263 }
264}
265
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000266/// BuildScopeInformation - The statements from CI to CE are known to form a
267/// coherent VLA scope with a specified parent node. Walk through the
268/// statements, adding any labels or gotos to LabelAndGotoScopes and recursively
269/// walking the AST as needed.
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000270void JumpScopeChecker::BuildScopeInformation(Stmt *S, unsigned &origParentScope) {
271 // If this is a statement, rather than an expression, scopes within it don't
272 // propagate out into the enclosing scope. Otherwise we have to worry
273 // about block literals, which have the lifetime of their enclosing statement.
274 unsigned independentParentScope = origParentScope;
275 unsigned &ParentScope = ((isa<Expr>(S) && !isa<StmtExpr>(S))
276 ? origParentScope : independentParentScope);
277
Douglas Gregor27b98ea2010-06-21 23:44:13 +0000278 bool SkipFirstSubStmt = false;
279
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000280 // If we found a label, remember that it is in ParentScope scope.
John McCallcf819ab2010-05-12 00:58:13 +0000281 switch (S->getStmtClass()) {
John McCallcf819ab2010-05-12 00:58:13 +0000282 case Stmt::AddrLabelExprClass:
283 IndirectJumpTargets.push_back(cast<AddrLabelExpr>(S)->getLabel());
284 break;
285
286 case Stmt::IndirectGotoStmtClass:
John McCall9de91602010-10-28 08:53:48 +0000287 // "goto *&&lbl;" is a special case which we treat as equivalent
288 // to a normal goto. In addition, we don't calculate scope in the
289 // operand (to avoid recording the address-of-label use), which
290 // works only because of the restricted set of expressions which
291 // we detect as constant targets.
292 if (cast<IndirectGotoStmt>(S)->getConstantTarget()) {
293 LabelAndGotoScopes[S] = ParentScope;
294 Jumps.push_back(S);
295 return;
296 }
297
John McCallcf819ab2010-05-12 00:58:13 +0000298 LabelAndGotoScopes[S] = ParentScope;
299 IndirectJumps.push_back(cast<IndirectGotoStmt>(S));
300 break;
301
John McCallcf819ab2010-05-12 00:58:13 +0000302 case Stmt::SwitchStmtClass:
Douglas Gregor27b98ea2010-06-21 23:44:13 +0000303 // Evaluate the condition variable before entering the scope of the switch
304 // statement.
305 if (VarDecl *Var = cast<SwitchStmt>(S)->getConditionVariable()) {
306 BuildScopeInformation(Var, ParentScope);
307 SkipFirstSubStmt = true;
308 }
309 // Fall through
310
311 case Stmt::GotoStmtClass:
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000312 // Remember both what scope a goto is in as well as the fact that we have
313 // it. This makes the second scan not have to walk the AST again.
314 LabelAndGotoScopes[S] = ParentScope;
315 Jumps.push_back(S);
John McCallcf819ab2010-05-12 00:58:13 +0000316 break;
317
Eli Friedman1e95d4b2012-10-31 23:55:28 +0000318 case Stmt::CXXTryStmtClass: {
319 CXXTryStmt *TS = cast<CXXTryStmt>(S);
320 unsigned newParentScope;
321 Scopes.push_back(GotoScope(ParentScope,
322 diag::note_protected_by_cxx_try,
323 diag::note_exits_cxx_try,
324 TS->getSourceRange().getBegin()));
325 if (Stmt *TryBlock = TS->getTryBlock())
326 BuildScopeInformation(TryBlock, (newParentScope = Scopes.size()-1));
327
328 // Jump from the catch into the try is not allowed either.
329 for (unsigned I = 0, E = TS->getNumHandlers(); I != E; ++I) {
330 CXXCatchStmt *CS = TS->getHandler(I);
331 Scopes.push_back(GotoScope(ParentScope,
332 diag::note_protected_by_cxx_catch,
333 diag::note_exits_cxx_catch,
334 CS->getSourceRange().getBegin()));
335 BuildScopeInformation(CS->getHandlerBlock(),
336 (newParentScope = Scopes.size()-1));
337 }
338 return;
339 }
340
John McCallcf819ab2010-05-12 00:58:13 +0000341 default:
342 break;
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000343 }
Mike Stump11289f42009-09-09 15:08:12 +0000344
John McCall8322c3a2011-02-13 04:07:26 +0000345 for (Stmt::child_range CI = S->children(); CI; ++CI) {
Douglas Gregor27b98ea2010-06-21 23:44:13 +0000346 if (SkipFirstSubStmt) {
347 SkipFirstSubStmt = false;
348 continue;
349 }
350
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000351 Stmt *SubStmt = *CI;
Craig Topperc3ec1492014-05-26 06:22:03 +0000352 if (!SubStmt) continue;
Mike Stump11289f42009-09-09 15:08:12 +0000353
John McCall4a33fa92010-08-02 23:33:14 +0000354 // Cases, labels, and defaults aren't "scope parents". It's also
355 // important to handle these iteratively instead of recursively in
356 // order to avoid blowing out the stack.
357 while (true) {
358 Stmt *Next;
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000359 if (CaseStmt *CS = dyn_cast<CaseStmt>(SubStmt))
360 Next = CS->getSubStmt();
361 else if (DefaultStmt *DS = dyn_cast<DefaultStmt>(SubStmt))
362 Next = DS->getSubStmt();
363 else if (LabelStmt *LS = dyn_cast<LabelStmt>(SubStmt))
364 Next = LS->getSubStmt();
John McCall4a33fa92010-08-02 23:33:14 +0000365 else
366 break;
367
368 LabelAndGotoScopes[SubStmt] = ParentScope;
369 SubStmt = Next;
370 }
371
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000372 // If this is a declstmt with a VLA definition, it defines a scope from here
373 // to the end of the containing context.
374 if (DeclStmt *DS = dyn_cast<DeclStmt>(SubStmt)) {
Chris Lattner30d0cfd2010-03-01 20:59:53 +0000375 // The decl statement creates a scope if any of the decls in it are VLAs
376 // or have the cleanup attribute.
Aaron Ballman535bbcc2014-03-14 17:01:24 +0000377 for (auto *I : DS->decls())
378 BuildScopeInformation(I, ParentScope);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000379 continue;
380 }
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000381 // Disallow jumps into any part of an @try statement by pushing a scope and
382 // walking all sub-stmts in that scope.
383 if (ObjCAtTryStmt *AT = dyn_cast<ObjCAtTryStmt>(SubStmt)) {
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000384 unsigned newParentScope;
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000385 // Recursively walk the AST for the @try part.
John McCallcf819ab2010-05-12 00:58:13 +0000386 Scopes.push_back(GotoScope(ParentScope,
387 diag::note_protected_by_objc_try,
388 diag::note_exits_objc_try,
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000389 AT->getAtTryLoc()));
390 if (Stmt *TryPart = AT->getTryBody())
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000391 BuildScopeInformation(TryPart, (newParentScope = Scopes.size()-1));
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000392
393 // Jump from the catch to the finally or try is not valid.
Douglas Gregor96c79492010-04-23 22:50:49 +0000394 for (unsigned I = 0, N = AT->getNumCatchStmts(); I != N; ++I) {
395 ObjCAtCatchStmt *AC = AT->getCatchStmt(I);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000396 Scopes.push_back(GotoScope(ParentScope,
397 diag::note_protected_by_objc_catch,
John McCallcf819ab2010-05-12 00:58:13 +0000398 diag::note_exits_objc_catch,
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000399 AC->getAtCatchLoc()));
Mike Stump11289f42009-09-09 15:08:12 +0000400 // @catches are nested and it isn't
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000401 BuildScopeInformation(AC->getCatchBody(),
402 (newParentScope = Scopes.size()-1));
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000403 }
Mike Stump11289f42009-09-09 15:08:12 +0000404
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000405 // Jump from the finally to the try or catch is not valid.
406 if (ObjCAtFinallyStmt *AF = AT->getFinallyStmt()) {
407 Scopes.push_back(GotoScope(ParentScope,
408 diag::note_protected_by_objc_finally,
John McCallcf819ab2010-05-12 00:58:13 +0000409 diag::note_exits_objc_finally,
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000410 AF->getAtFinallyLoc()));
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000411 BuildScopeInformation(AF, (newParentScope = Scopes.size()-1));
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000412 }
Mike Stump11289f42009-09-09 15:08:12 +0000413
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000414 continue;
415 }
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000416
417 unsigned newParentScope;
Chris Lattnerc70dd562009-04-21 06:01:00 +0000418 // Disallow jumps into the protected statement of an @synchronized, but
419 // allow jumps into the object expression it protects.
420 if (ObjCAtSynchronizedStmt *AS = dyn_cast<ObjCAtSynchronizedStmt>(SubStmt)){
421 // Recursively walk the AST for the @synchronized object expr, it is
422 // evaluated in the normal scope.
423 BuildScopeInformation(AS->getSynchExpr(), ParentScope);
Mike Stump11289f42009-09-09 15:08:12 +0000424
Chris Lattnerc70dd562009-04-21 06:01:00 +0000425 // Recursively walk the AST for the @synchronized part, protected by a new
426 // scope.
427 Scopes.push_back(GotoScope(ParentScope,
428 diag::note_protected_by_objc_synchronized,
John McCallcf819ab2010-05-12 00:58:13 +0000429 diag::note_exits_objc_synchronized,
Chris Lattnerc70dd562009-04-21 06:01:00 +0000430 AS->getAtSynchronizedLoc()));
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000431 BuildScopeInformation(AS->getSynchBody(),
432 (newParentScope = Scopes.size()-1));
Chris Lattnerc70dd562009-04-21 06:01:00 +0000433 continue;
434 }
Sebastian Redl4de47b42009-04-27 20:27:31 +0000435
John McCall31168b02011-06-15 23:02:42 +0000436 // Disallow jumps into the protected statement of an @autoreleasepool.
437 if (ObjCAutoreleasePoolStmt *AS = dyn_cast<ObjCAutoreleasePoolStmt>(SubStmt)){
438 // Recursively walk the AST for the @autoreleasepool part, protected by a new
439 // scope.
440 Scopes.push_back(GotoScope(ParentScope,
441 diag::note_protected_by_objc_autoreleasepool,
442 diag::note_exits_objc_autoreleasepool,
443 AS->getAtLoc()));
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000444 BuildScopeInformation(AS->getSubStmt(), (newParentScope = Scopes.size()-1));
John McCall31168b02011-06-15 23:02:42 +0000445 continue;
446 }
John McCallb0433ee2012-09-25 06:56:03 +0000447
448 // Disallow jumps past full-expressions that use blocks with
449 // non-trivial cleanups of their captures. This is theoretically
450 // implementable but a lot of work which we haven't felt up to doing.
451 if (ExprWithCleanups *EWC = dyn_cast<ExprWithCleanups>(SubStmt)) {
452 for (unsigned i = 0, e = EWC->getNumObjects(); i != e; ++i) {
453 const BlockDecl *BDecl = EWC->getObject(i);
Aaron Ballman9371dd22014-03-14 18:34:04 +0000454 for (const auto &CI : BDecl->captures()) {
455 VarDecl *variable = CI.getVariable();
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000456 BuildScopeInformation(variable, BDecl, ParentScope);
457 }
John McCallb0433ee2012-09-25 06:56:03 +0000458 }
Fariborz Jahanian256d39d2011-07-11 18:04:54 +0000459 }
Richard Smithc934e4f2013-12-12 01:27:02 +0000460
461 // Disallow jumps out of scopes containing temporaries lifetime-extended to
462 // automatic storage duration.
463 if (MaterializeTemporaryExpr *MTE =
464 dyn_cast<MaterializeTemporaryExpr>(SubStmt)) {
465 if (MTE->getStorageDuration() == SD_Automatic) {
466 SmallVector<const Expr *, 4> CommaLHS;
467 SmallVector<SubobjectAdjustment, 4> Adjustments;
468 const Expr *ExtendedObject =
469 MTE->GetTemporaryExpr()->skipRValueSubobjectAdjustments(
470 CommaLHS, Adjustments);
471 if (ExtendedObject->getType().isDestructedType()) {
472 Scopes.push_back(GotoScope(ParentScope, 0,
473 diag::note_exits_temporary_dtor,
474 ExtendedObject->getExprLoc()));
475 ParentScope = Scopes.size()-1;
476 }
477 }
478 }
479
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000480 // Recursively walk the AST.
481 BuildScopeInformation(SubStmt, ParentScope);
482 }
483}
484
485/// VerifyJumps - Verify each element of the Jumps array to see if they are
486/// valid, emitting diagnostics if not.
487void JumpScopeChecker::VerifyJumps() {
488 while (!Jumps.empty()) {
489 Stmt *Jump = Jumps.pop_back_val();
Mike Stump11289f42009-09-09 15:08:12 +0000490
491 // With a goto,
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000492 if (GotoStmt *GS = dyn_cast<GotoStmt>(Jump)) {
Ehsan Akhgari31097582014-09-22 02:21:54 +0000493 // The label may not have a statement if it's coming from inline MS ASM.
494 if (GS->getLabel()->getStmt()) {
495 CheckJump(GS, GS->getLabel()->getStmt(), GS->getGotoLoc(),
496 diag::err_goto_into_protected_scope,
497 diag::ext_goto_into_protected_scope,
498 diag::warn_cxx98_compat_goto_into_protected_scope);
499 }
500 CheckGotoStmt(GS);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000501 continue;
502 }
Mike Stump11289f42009-09-09 15:08:12 +0000503
John McCall9de91602010-10-28 08:53:48 +0000504 // We only get indirect gotos here when they have a constant target.
505 if (IndirectGotoStmt *IGS = dyn_cast<IndirectGotoStmt>(Jump)) {
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000506 LabelDecl *Target = IGS->getConstantTarget();
507 CheckJump(IGS, Target->getStmt(), IGS->getGotoLoc(),
Francois Pichet2f550192011-09-16 23:15:32 +0000508 diag::err_goto_into_protected_scope,
Richard Smith1b98ccc2014-07-19 01:39:17 +0000509 diag::ext_goto_into_protected_scope,
Richard Smithfe2750d2011-10-20 21:42:12 +0000510 diag::warn_cxx98_compat_goto_into_protected_scope);
John McCall9de91602010-10-28 08:53:48 +0000511 continue;
512 }
513
John McCallcf819ab2010-05-12 00:58:13 +0000514 SwitchStmt *SS = cast<SwitchStmt>(Jump);
515 for (SwitchCase *SC = SS->getSwitchCaseList(); SC;
516 SC = SC->getNextSwitchCase()) {
Alp Tokere265cf12014-05-09 08:40:10 +0000517 if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(SC)))
518 continue;
Erik Verbruggen11a2ecc2012-12-25 14:51:39 +0000519 SourceLocation Loc;
520 if (CaseStmt *CS = dyn_cast<CaseStmt>(SC))
521 Loc = CS->getLocStart();
522 else if (DefaultStmt *DS = dyn_cast<DefaultStmt>(SC))
523 Loc = DS->getLocStart();
524 else
525 Loc = SC->getLocStart();
526 CheckJump(SS, SC, Loc, diag::err_switch_into_protected_scope, 0,
Richard Smithfe2750d2011-10-20 21:42:12 +0000527 diag::warn_cxx98_compat_switch_into_protected_scope);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000528 }
529 }
530}
531
John McCall42f9f1f2010-05-12 02:37:54 +0000532/// VerifyIndirectJumps - Verify whether any possible indirect jump
533/// might cross a protection boundary. Unlike direct jumps, indirect
534/// jumps count cleanups as protection boundaries: since there's no
535/// way to know where the jump is going, we can't implicitly run the
536/// right cleanups the way we can with direct jumps.
John McCallcf819ab2010-05-12 00:58:13 +0000537///
John McCall42f9f1f2010-05-12 02:37:54 +0000538/// Thus, an indirect jump is "trivial" if it bypasses no
539/// initializations and no teardowns. More formally, an indirect jump
540/// from A to B is trivial if the path out from A to DCA(A,B) is
541/// trivial and the path in from DCA(A,B) to B is trivial, where
542/// DCA(A,B) is the deepest common ancestor of A and B.
543/// Jump-triviality is transitive but asymmetric.
544///
John McCallcf819ab2010-05-12 00:58:13 +0000545/// A path in is trivial if none of the entered scopes have an InDiag.
546/// A path out is trivial is none of the exited scopes have an OutDiag.
John McCall42f9f1f2010-05-12 02:37:54 +0000547///
548/// Under these definitions, this function checks that the indirect
549/// jump between A and B is trivial for every indirect goto statement A
550/// and every label B whose address was taken in the function.
John McCallcf819ab2010-05-12 00:58:13 +0000551void JumpScopeChecker::VerifyIndirectJumps() {
552 if (IndirectJumps.empty()) return;
553
554 // If there aren't any address-of-label expressions in this function,
555 // complain about the first indirect goto.
556 if (IndirectJumpTargets.empty()) {
557 S.Diag(IndirectJumps[0]->getGotoLoc(),
558 diag::err_indirect_goto_without_addrlabel);
559 return;
560 }
561
John McCall42f9f1f2010-05-12 02:37:54 +0000562 // Collect a single representative of every scope containing an
563 // indirect goto. For most code bases, this substantially cuts
564 // down on the number of jump sites we'll have to consider later.
John McCallcf819ab2010-05-12 00:58:13 +0000565 typedef std::pair<unsigned, IndirectGotoStmt*> JumpScope;
Chris Lattner0e62c1c2011-07-23 10:55:15 +0000566 SmallVector<JumpScope, 32> JumpScopes;
John McCallcf819ab2010-05-12 00:58:13 +0000567 {
568 llvm::DenseMap<unsigned, IndirectGotoStmt*> JumpScopesMap;
Chris Lattner0e62c1c2011-07-23 10:55:15 +0000569 for (SmallVectorImpl<IndirectGotoStmt*>::iterator
John McCallcf819ab2010-05-12 00:58:13 +0000570 I = IndirectJumps.begin(), E = IndirectJumps.end(); I != E; ++I) {
571 IndirectGotoStmt *IG = *I;
Alp Tokere265cf12014-05-09 08:40:10 +0000572 if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(IG)))
573 continue;
John McCallcf819ab2010-05-12 00:58:13 +0000574 unsigned IGScope = LabelAndGotoScopes[IG];
575 IndirectGotoStmt *&Entry = JumpScopesMap[IGScope];
576 if (!Entry) Entry = IG;
577 }
578 JumpScopes.reserve(JumpScopesMap.size());
579 for (llvm::DenseMap<unsigned, IndirectGotoStmt*>::iterator
580 I = JumpScopesMap.begin(), E = JumpScopesMap.end(); I != E; ++I)
581 JumpScopes.push_back(*I);
582 }
583
John McCall42f9f1f2010-05-12 02:37:54 +0000584 // Collect a single representative of every scope containing a
585 // label whose address was taken somewhere in the function.
586 // For most code bases, there will be only one such scope.
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000587 llvm::DenseMap<unsigned, LabelDecl*> TargetScopes;
Chris Lattner0e62c1c2011-07-23 10:55:15 +0000588 for (SmallVectorImpl<LabelDecl*>::iterator
John McCallcf819ab2010-05-12 00:58:13 +0000589 I = IndirectJumpTargets.begin(), E = IndirectJumpTargets.end();
590 I != E; ++I) {
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000591 LabelDecl *TheLabel = *I;
Alp Tokere265cf12014-05-09 08:40:10 +0000592 if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(TheLabel->getStmt())))
593 continue;
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000594 unsigned LabelScope = LabelAndGotoScopes[TheLabel->getStmt()];
595 LabelDecl *&Target = TargetScopes[LabelScope];
John McCallcf819ab2010-05-12 00:58:13 +0000596 if (!Target) Target = TheLabel;
597 }
598
John McCall42f9f1f2010-05-12 02:37:54 +0000599 // For each target scope, make sure it's trivially reachable from
600 // every scope containing a jump site.
601 //
602 // A path between scopes always consists of exitting zero or more
603 // scopes, then entering zero or more scopes. We build a set of
604 // of scopes S from which the target scope can be trivially
605 // entered, then verify that every jump scope can be trivially
606 // exitted to reach a scope in S.
John McCallcf819ab2010-05-12 00:58:13 +0000607 llvm::BitVector Reachable(Scopes.size(), false);
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000608 for (llvm::DenseMap<unsigned,LabelDecl*>::iterator
John McCallcf819ab2010-05-12 00:58:13 +0000609 TI = TargetScopes.begin(), TE = TargetScopes.end(); TI != TE; ++TI) {
610 unsigned TargetScope = TI->first;
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000611 LabelDecl *TargetLabel = TI->second;
John McCallcf819ab2010-05-12 00:58:13 +0000612
613 Reachable.reset();
614
615 // Mark all the enclosing scopes from which you can safely jump
John McCall42f9f1f2010-05-12 02:37:54 +0000616 // into the target scope. 'Min' will end up being the index of
617 // the shallowest such scope.
John McCallcf819ab2010-05-12 00:58:13 +0000618 unsigned Min = TargetScope;
619 while (true) {
620 Reachable.set(Min);
621
622 // Don't go beyond the outermost scope.
623 if (Min == 0) break;
624
John McCall42f9f1f2010-05-12 02:37:54 +0000625 // Stop if we can't trivially enter the current scope.
John McCallcf819ab2010-05-12 00:58:13 +0000626 if (Scopes[Min].InDiag) break;
627
628 Min = Scopes[Min].ParentScope;
629 }
630
631 // Walk through all the jump sites, checking that they can trivially
632 // reach this label scope.
Chris Lattner0e62c1c2011-07-23 10:55:15 +0000633 for (SmallVectorImpl<JumpScope>::iterator
John McCallcf819ab2010-05-12 00:58:13 +0000634 I = JumpScopes.begin(), E = JumpScopes.end(); I != E; ++I) {
635 unsigned Scope = I->first;
636
637 // Walk out the "scope chain" for this scope, looking for a scope
John McCall42f9f1f2010-05-12 02:37:54 +0000638 // we've marked reachable. For well-formed code this amortizes
639 // to O(JumpScopes.size() / Scopes.size()): we only iterate
640 // when we see something unmarked, and in well-formed code we
641 // mark everything we iterate past.
John McCallcf819ab2010-05-12 00:58:13 +0000642 bool IsReachable = false;
643 while (true) {
644 if (Reachable.test(Scope)) {
645 // If we find something reachable, mark all the scopes we just
646 // walked through as reachable.
647 for (unsigned S = I->first; S != Scope; S = Scopes[S].ParentScope)
648 Reachable.set(S);
649 IsReachable = true;
650 break;
651 }
652
653 // Don't walk out if we've reached the top-level scope or we've
654 // gotten shallower than the shallowest reachable scope.
655 if (Scope == 0 || Scope < Min) break;
656
657 // Don't walk out through an out-diagnostic.
658 if (Scopes[Scope].OutDiag) break;
659
660 Scope = Scopes[Scope].ParentScope;
661 }
662
663 // Only diagnose if we didn't find something.
664 if (IsReachable) continue;
665
666 DiagnoseIndirectJump(I->second, I->first, TargetLabel, TargetScope);
667 }
668 }
669}
670
Richard Smithfe2750d2011-10-20 21:42:12 +0000671/// Return true if a particular error+note combination must be downgraded to a
672/// warning in Microsoft mode.
673static bool IsMicrosoftJumpWarning(unsigned JumpDiag, unsigned InDiagNote) {
674 return (JumpDiag == diag::err_goto_into_protected_scope &&
675 (InDiagNote == diag::note_protected_by_variable_init ||
676 InDiagNote == diag::note_protected_by_variable_nontriv_destructor));
677}
678
679/// Return true if a particular note should be downgraded to a compatibility
680/// warning in C++11 mode.
681static bool IsCXX98CompatWarning(Sema &S, unsigned InDiagNote) {
Richard Smith2bf7fdb2013-01-02 11:42:31 +0000682 return S.getLangOpts().CPlusPlus11 &&
Richard Smithfe2750d2011-10-20 21:42:12 +0000683 InDiagNote == diag::note_protected_by_variable_non_pod;
684}
685
686/// Produce primary diagnostic for an indirect jump statement.
687static void DiagnoseIndirectJumpStmt(Sema &S, IndirectGotoStmt *Jump,
688 LabelDecl *Target, bool &Diagnosed) {
689 if (Diagnosed)
690 return;
691 S.Diag(Jump->getGotoLoc(), diag::err_indirect_goto_in_protected_scope);
692 S.Diag(Target->getStmt()->getIdentLoc(), diag::note_indirect_goto_target);
693 Diagnosed = true;
694}
695
696/// Produce note diagnostics for a jump into a protected scope.
Bill Wendling8ac06af2012-02-22 09:38:11 +0000697void JumpScopeChecker::NoteJumpIntoScopes(ArrayRef<unsigned> ToScopes) {
Alp Tokere265cf12014-05-09 08:40:10 +0000698 if (CHECK_PERMISSIVE(ToScopes.empty()))
699 return;
Richard Smithfe2750d2011-10-20 21:42:12 +0000700 for (unsigned I = 0, E = ToScopes.size(); I != E; ++I)
701 if (Scopes[ToScopes[I]].InDiag)
702 S.Diag(Scopes[ToScopes[I]].Loc, Scopes[ToScopes[I]].InDiag);
703}
704
John McCall42f9f1f2010-05-12 02:37:54 +0000705/// Diagnose an indirect jump which is known to cross scopes.
John McCallcf819ab2010-05-12 00:58:13 +0000706void JumpScopeChecker::DiagnoseIndirectJump(IndirectGotoStmt *Jump,
707 unsigned JumpScope,
Chris Lattnerc8e630e2011-02-17 07:39:24 +0000708 LabelDecl *Target,
John McCallcf819ab2010-05-12 00:58:13 +0000709 unsigned TargetScope) {
Alp Tokere265cf12014-05-09 08:40:10 +0000710 if (CHECK_PERMISSIVE(JumpScope == TargetScope))
711 return;
John McCallcf819ab2010-05-12 00:58:13 +0000712
John McCall42f9f1f2010-05-12 02:37:54 +0000713 unsigned Common = GetDeepestCommonScope(JumpScope, TargetScope);
Richard Smithfe2750d2011-10-20 21:42:12 +0000714 bool Diagnosed = false;
John McCallcf819ab2010-05-12 00:58:13 +0000715
John McCall42f9f1f2010-05-12 02:37:54 +0000716 // Walk out the scope chain until we reach the common ancestor.
717 for (unsigned I = JumpScope; I != Common; I = Scopes[I].ParentScope)
Richard Smithfe2750d2011-10-20 21:42:12 +0000718 if (Scopes[I].OutDiag) {
719 DiagnoseIndirectJumpStmt(S, Jump, Target, Diagnosed);
John McCall42f9f1f2010-05-12 02:37:54 +0000720 S.Diag(Scopes[I].Loc, Scopes[I].OutDiag);
Richard Smithfe2750d2011-10-20 21:42:12 +0000721 }
722
723 SmallVector<unsigned, 10> ToScopesCXX98Compat;
John McCallcf819ab2010-05-12 00:58:13 +0000724
725 // Now walk into the scopes containing the label whose address was taken.
John McCall42f9f1f2010-05-12 02:37:54 +0000726 for (unsigned I = TargetScope; I != Common; I = Scopes[I].ParentScope)
Richard Smithfe2750d2011-10-20 21:42:12 +0000727 if (IsCXX98CompatWarning(S, Scopes[I].InDiag))
728 ToScopesCXX98Compat.push_back(I);
729 else if (Scopes[I].InDiag) {
730 DiagnoseIndirectJumpStmt(S, Jump, Target, Diagnosed);
John McCall42f9f1f2010-05-12 02:37:54 +0000731 S.Diag(Scopes[I].Loc, Scopes[I].InDiag);
Richard Smithfe2750d2011-10-20 21:42:12 +0000732 }
John McCallcf819ab2010-05-12 00:58:13 +0000733
Richard Smithfe2750d2011-10-20 21:42:12 +0000734 // Diagnose this jump if it would be ill-formed in C++98.
735 if (!Diagnosed && !ToScopesCXX98Compat.empty()) {
736 S.Diag(Jump->getGotoLoc(),
737 diag::warn_cxx98_compat_indirect_goto_in_protected_scope);
738 S.Diag(Target->getStmt()->getIdentLoc(), diag::note_indirect_goto_target);
739 NoteJumpIntoScopes(ToScopesCXX98Compat);
740 }
Francois Pichet051f5e52011-09-13 10:26:51 +0000741}
742
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000743/// CheckJump - Validate that the specified jump statement is valid: that it is
744/// jumping within or out of its current scope, not into a deeper one.
Francois Pichet051f5e52011-09-13 10:26:51 +0000745void JumpScopeChecker::CheckJump(Stmt *From, Stmt *To, SourceLocation DiagLoc,
Richard Smithfe2750d2011-10-20 21:42:12 +0000746 unsigned JumpDiagError, unsigned JumpDiagWarning,
747 unsigned JumpDiagCXX98Compat) {
Alp Tokere265cf12014-05-09 08:40:10 +0000748 if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(From)))
749 return;
750 if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(To)))
751 return;
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000752
Alp Tokere265cf12014-05-09 08:40:10 +0000753 unsigned FromScope = LabelAndGotoScopes[From];
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000754 unsigned ToScope = LabelAndGotoScopes[To];
Mike Stump11289f42009-09-09 15:08:12 +0000755
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000756 // Common case: exactly the same scope, which is fine.
757 if (FromScope == ToScope) return;
Mike Stump11289f42009-09-09 15:08:12 +0000758
John McCall42f9f1f2010-05-12 02:37:54 +0000759 unsigned CommonScope = GetDeepestCommonScope(FromScope, ToScope);
Mike Stump11289f42009-09-09 15:08:12 +0000760
John McCall42f9f1f2010-05-12 02:37:54 +0000761 // It's okay to jump out from a nested scope.
762 if (CommonScope == ToScope) return;
Mike Stump11289f42009-09-09 15:08:12 +0000763
John McCall42f9f1f2010-05-12 02:37:54 +0000764 // Pull out (and reverse) any scopes we might need to diagnose skipping.
Richard Smithfe2750d2011-10-20 21:42:12 +0000765 SmallVector<unsigned, 10> ToScopesCXX98Compat;
Francois Pichet051f5e52011-09-13 10:26:51 +0000766 SmallVector<unsigned, 10> ToScopesError;
767 SmallVector<unsigned, 10> ToScopesWarning;
768 for (unsigned I = ToScope; I != CommonScope; I = Scopes[I].ParentScope) {
Alp Tokerbfa39342014-01-14 12:51:41 +0000769 if (S.getLangOpts().MSVCCompat && JumpDiagWarning != 0 &&
Francois Pichet051f5e52011-09-13 10:26:51 +0000770 IsMicrosoftJumpWarning(JumpDiagError, Scopes[I].InDiag))
771 ToScopesWarning.push_back(I);
Richard Smithfe2750d2011-10-20 21:42:12 +0000772 else if (IsCXX98CompatWarning(S, Scopes[I].InDiag))
773 ToScopesCXX98Compat.push_back(I);
Francois Pichet051f5e52011-09-13 10:26:51 +0000774 else if (Scopes[I].InDiag)
775 ToScopesError.push_back(I);
776 }
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000777
Francois Pichet051f5e52011-09-13 10:26:51 +0000778 // Handle warnings.
779 if (!ToScopesWarning.empty()) {
780 S.Diag(DiagLoc, JumpDiagWarning);
Richard Smithfe2750d2011-10-20 21:42:12 +0000781 NoteJumpIntoScopes(ToScopesWarning);
Francois Pichet051f5e52011-09-13 10:26:51 +0000782 }
John McCallcf819ab2010-05-12 00:58:13 +0000783
Francois Pichet051f5e52011-09-13 10:26:51 +0000784 // Handle errors.
785 if (!ToScopesError.empty()) {
786 S.Diag(DiagLoc, JumpDiagError);
Richard Smithfe2750d2011-10-20 21:42:12 +0000787 NoteJumpIntoScopes(ToScopesError);
788 }
789
790 // Handle -Wc++98-compat warnings if the jump is well-formed.
791 if (ToScopesError.empty() && !ToScopesCXX98Compat.empty()) {
792 S.Diag(DiagLoc, JumpDiagCXX98Compat);
793 NoteJumpIntoScopes(ToScopesCXX98Compat);
Francois Pichet051f5e52011-09-13 10:26:51 +0000794 }
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000795}
796
Ehsan Akhgari31097582014-09-22 02:21:54 +0000797void JumpScopeChecker::CheckGotoStmt(GotoStmt *GS) {
798 if (GS->getLabel()->isMSAsmLabel()) {
799 S.Diag(GS->getGotoLoc(), diag::err_goto_ms_asm_label)
800 << GS->getLabel()->getIdentifier();
801 S.Diag(GS->getLabel()->getLocation(), diag::note_goto_ms_asm_label)
802 << GS->getLabel()->getIdentifier();
803 }
804}
805
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000806void Sema::DiagnoseInvalidJumps(Stmt *Body) {
Douglas Gregor120f6a62009-11-17 06:14:37 +0000807 (void)JumpScopeChecker(Body, *this);
Chris Lattner1a1fdbd2009-04-19 04:46:21 +0000808}