blob: 0e7894788c87949a00e1e3f7ec8fce45da286f85 [file] [log] [blame]
Ted Kremenek18c7cee2009-11-03 08:03:59 +00001//=- NSAutoreleasePoolChecker.cpp --------------------------------*- C++ -*-==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines a NSAutoreleasePoolChecker, a small checker that warns
11// about subpar uses of NSAutoreleasePool. Note that while the check itself
Jordy Rose087611e2011-09-02 08:02:59 +000012// (in its current form) could be written as a flow-insensitive check, in
Ted Kremenek18c7cee2009-11-03 08:03:59 +000013// can be potentially enhanced in the future with flow-sensitive information.
Ted Kremenek3a0678e2015-09-08 03:50:52 +000014// It is also a good example of the CheckerVisitor interface.
Ted Kremenek18c7cee2009-11-03 08:03:59 +000015//
16//===----------------------------------------------------------------------===//
17
Argyrios Kyrtzidis9d4d4f92011-02-16 01:40:52 +000018#include "ClangSACheckers.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000019#include "clang/AST/Decl.h"
20#include "clang/AST/DeclObjC.h"
Ted Kremenekf8cbac42011-02-10 01:03:03 +000021#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
Anna Zaks6b1c2122011-10-26 21:06:39 +000022#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000023#include "clang/StaticAnalyzer/Core/Checker.h"
24#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Jordan Rose4f7df9b2012-07-26 21:39:41 +000025#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Jordy Rose087611e2011-09-02 08:02:59 +000026#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenekf8cbac42011-02-10 01:03:03 +000027#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
Ted Kremenek18c7cee2009-11-03 08:03:59 +000028
29using namespace clang;
Ted Kremenek98857c92010-12-23 07:20:52 +000030using namespace ento;
Ted Kremenek18c7cee2009-11-03 08:03:59 +000031
32namespace {
Kovarththanan Rajaratnam65c65662009-11-28 06:07:30 +000033class NSAutoreleasePoolChecker
Argyrios Kyrtzidis6a5674f2011-03-01 01:16:21 +000034 : public Checker<check::PreObjCMessage> {
Ahmed Charlesb8984322014-03-07 20:03:18 +000035 mutable std::unique_ptr<BugType> BT;
Argyrios Kyrtzidisaad83722011-02-23 07:19:18 +000036 mutable Selector releaseS;
Ted Kremenek18c7cee2009-11-03 08:03:59 +000037
38public:
Jordan Rose547060b2012-07-02 19:28:04 +000039 void checkPreObjCMessage(const ObjCMethodCall &msg, CheckerContext &C) const;
Ted Kremenek18c7cee2009-11-03 08:03:59 +000040};
41
42} // end anonymous namespace
43
Jordan Rose547060b2012-07-02 19:28:04 +000044void NSAutoreleasePoolChecker::checkPreObjCMessage(const ObjCMethodCall &msg,
Argyrios Kyrtzidisaad83722011-02-23 07:19:18 +000045 CheckerContext &C) const {
Jordan Rose547060b2012-07-02 19:28:04 +000046 if (!msg.isInstanceMessage())
Ted Kremenek18c7cee2009-11-03 08:03:59 +000047 return;
Jordan Rose547060b2012-07-02 19:28:04 +000048
49 const ObjCInterfaceDecl *OD = msg.getReceiverInterface();
Ted Kremenek18c7cee2009-11-03 08:03:59 +000050 if (!OD)
Ted Kremenek3a0678e2015-09-08 03:50:52 +000051 return;
Jordan Rose547060b2012-07-02 19:28:04 +000052 if (!OD->getIdentifier()->isStr("NSAutoreleasePool"))
Ted Kremenek18c7cee2009-11-03 08:03:59 +000053 return;
Argyrios Kyrtzidisaad83722011-02-23 07:19:18 +000054
55 if (releaseS.isNull())
56 releaseS = GetNullarySelector("release", C.getASTContext());
Ted Kremenek18c7cee2009-11-03 08:03:59 +000057 // Sending 'release' message?
Argyrios Kyrtzidis37ab7262011-01-25 00:03:53 +000058 if (msg.getSelector() != releaseS)
Ted Kremenek18c7cee2009-11-03 08:03:59 +000059 return;
Anna Zaks6b1c2122011-10-26 21:06:39 +000060
61 if (!BT)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +000062 BT.reset(new BugType(this, "Use -drain instead of -release",
Anna Zaks6b1c2122011-10-26 21:06:39 +000063 "API Upgrade (Apple)"));
64
Devin Coughline39bd402015-09-16 22:03:05 +000065 ExplodedNode *N = C.generateNonFatalErrorNode();
Anna Zaks6b1c2122011-10-26 21:06:39 +000066 if (!N) {
67 assert(0);
68 return;
69 }
70
Aaron Ballman8d3a7a52015-06-23 13:15:32 +000071 auto Report = llvm::make_unique<BugReport>(
72 *BT, "Use -drain instead of -release when using NSAutoreleasePool and "
73 "garbage collection", N);
Anna Zaks6b1c2122011-10-26 21:06:39 +000074 Report->addRange(msg.getSourceRange());
Aaron Ballman8d3a7a52015-06-23 13:15:32 +000075 C.emitReport(std::move(Report));
Ted Kremenek18c7cee2009-11-03 08:03:59 +000076}
Argyrios Kyrtzidisaad83722011-02-23 07:19:18 +000077
78void ento::registerNSAutoreleasePoolChecker(CheckerManager &mgr) {
David Blaikiebbafb8a2012-03-11 07:00:24 +000079 if (mgr.getLangOpts().getGC() != LangOptions::NonGC)
Argyrios Kyrtzidisaad83722011-02-23 07:19:18 +000080 mgr.registerChecker<NSAutoreleasePoolChecker>();
81}