blob: e06f05a2d9826da08ea3ed9464c2e993b65be64d [file] [log] [blame]
Sam Parker3828c6f2018-07-23 12:27:47 +00001//===----- ARMCodeGenPrepare.cpp ------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10/// \file
11/// This pass inserts intrinsics to handle small types that would otherwise be
12/// promoted during legalization. Here we can manually promote types or insert
13/// intrinsics which can handle narrow types that aren't supported by the
14/// register classes.
15//
16//===----------------------------------------------------------------------===//
17
18#include "ARM.h"
19#include "ARMSubtarget.h"
20#include "ARMTargetMachine.h"
21#include "llvm/ADT/StringRef.h"
22#include "llvm/CodeGen/Passes.h"
23#include "llvm/CodeGen/TargetPassConfig.h"
24#include "llvm/IR/Attributes.h"
25#include "llvm/IR/BasicBlock.h"
26#include "llvm/IR/IRBuilder.h"
27#include "llvm/IR/Constants.h"
28#include "llvm/IR/InstrTypes.h"
29#include "llvm/IR/Instruction.h"
30#include "llvm/IR/Instructions.h"
31#include "llvm/IR/IntrinsicInst.h"
32#include "llvm/IR/Intrinsics.h"
33#include "llvm/IR/Type.h"
34#include "llvm/IR/Value.h"
35#include "llvm/IR/Verifier.h"
36#include "llvm/Pass.h"
37#include "llvm/Support/Casting.h"
38#include "llvm/Support/CommandLine.h"
39
40#define DEBUG_TYPE "arm-codegenprepare"
41
42using namespace llvm;
43
44static cl::opt<bool>
Sam Parker945604d2018-09-11 12:45:43 +000045DisableCGP("arm-disable-cgp", cl::Hidden, cl::init(false),
Sam Parker3828c6f2018-07-23 12:27:47 +000046 cl::desc("Disable ARM specific CodeGenPrepare pass"));
47
48static cl::opt<bool>
49EnableDSP("arm-enable-scalar-dsp", cl::Hidden, cl::init(false),
50 cl::desc("Use DSP instructions for scalar operations"));
51
52static cl::opt<bool>
53EnableDSPWithImms("arm-enable-scalar-dsp-imms", cl::Hidden, cl::init(false),
54 cl::desc("Use DSP instructions for scalar operations\
55 with immediate operands"));
56
Sjoerd Meijer31239a42018-08-17 07:34:01 +000057// The goal of this pass is to enable more efficient code generation for
58// operations on narrow types (i.e. types with < 32-bits) and this is a
59// motivating IR code example:
60//
61// define hidden i32 @cmp(i8 zeroext) {
62// %2 = add i8 %0, -49
63// %3 = icmp ult i8 %2, 3
64// ..
65// }
66//
67// The issue here is that i8 is type-legalized to i32 because i8 is not a
68// legal type. Thus, arithmetic is done in integer-precision, but then the
69// byte value is masked out as follows:
70//
71// t19: i32 = add t4, Constant:i32<-49>
72// t24: i32 = and t19, Constant:i32<255>
73//
74// Consequently, we generate code like this:
75//
76// subs r0, #49
77// uxtb r1, r0
78// cmp r1, #3
79//
80// This shows that masking out the byte value results in generation of
81// the UXTB instruction. This is not optimal as r0 already contains the byte
82// value we need, and so instead we can just generate:
83//
84// sub.w r1, r0, #49
85// cmp r1, #3
86//
87// We achieve this by type promoting the IR to i32 like so for this example:
88//
89// define i32 @cmp(i8 zeroext %c) {
90// %0 = zext i8 %c to i32
91// %c.off = add i32 %0, -49
92// %1 = icmp ult i32 %c.off, 3
93// ..
94// }
95//
96// For this to be valid and legal, we need to prove that the i32 add is
97// producing the same value as the i8 addition, and that e.g. no overflow
98// happens.
99//
100// A brief sketch of the algorithm and some terminology.
101// We pattern match interesting IR patterns:
102// - which have "sources": instructions producing narrow values (i8, i16), and
103// - they have "sinks": instructions consuming these narrow values.
104//
105// We collect all instruction connecting sources and sinks in a worklist, so
106// that we can mutate these instruction and perform type promotion when it is
107// legal to do so.
Sam Parker3828c6f2018-07-23 12:27:47 +0000108
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000109namespace {
Sam Parker3828c6f2018-07-23 12:27:47 +0000110class IRPromoter {
111 SmallPtrSet<Value*, 8> NewInsts;
112 SmallVector<Instruction*, 4> InstsToRemove;
113 Module *M = nullptr;
114 LLVMContext &Ctx;
115
116public:
117 IRPromoter(Module *M) : M(M), Ctx(M->getContext()) { }
118
119 void Cleanup() {
120 for (auto *I : InstsToRemove) {
121 LLVM_DEBUG(dbgs() << "ARM CGP: Removing " << *I << "\n");
122 I->dropAllReferences();
123 I->eraseFromParent();
124 }
125 InstsToRemove.clear();
126 NewInsts.clear();
127 }
128
129 void Mutate(Type *OrigTy,
130 SmallPtrSetImpl<Value*> &Visited,
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000131 SmallPtrSetImpl<Value*> &Sources,
132 SmallPtrSetImpl<Instruction*> &Sinks);
Sam Parker3828c6f2018-07-23 12:27:47 +0000133};
134
135class ARMCodeGenPrepare : public FunctionPass {
136 const ARMSubtarget *ST = nullptr;
137 IRPromoter *Promoter = nullptr;
138 std::set<Value*> AllVisited;
Sam Parker3828c6f2018-07-23 12:27:47 +0000139
Sam Parker3828c6f2018-07-23 12:27:47 +0000140 bool isSupportedValue(Value *V);
141 bool isLegalToPromote(Value *V);
142 bool TryToPromote(Value *V);
143
144public:
145 static char ID;
Sam Parker8c4b9642018-08-10 13:57:13 +0000146 static unsigned TypeSize;
147 Type *OrigTy = nullptr;
Sam Parker3828c6f2018-07-23 12:27:47 +0000148
149 ARMCodeGenPrepare() : FunctionPass(ID) {}
150
Sam Parker3828c6f2018-07-23 12:27:47 +0000151 void getAnalysisUsage(AnalysisUsage &AU) const override {
152 AU.addRequired<TargetPassConfig>();
153 }
154
155 StringRef getPassName() const override { return "ARM IR optimizations"; }
156
157 bool doInitialization(Module &M) override;
158 bool runOnFunction(Function &F) override;
Matt Morehousea70685f2018-07-23 17:00:45 +0000159 bool doFinalization(Module &M) override;
Sam Parker3828c6f2018-07-23 12:27:47 +0000160};
161
162}
163
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000164static bool generateSignBits(Value *V) {
Sam Parker3828c6f2018-07-23 12:27:47 +0000165 if (!isa<Instruction>(V))
166 return false;
167
168 unsigned Opc = cast<Instruction>(V)->getOpcode();
169 return Opc == Instruction::AShr || Opc == Instruction::SDiv ||
170 Opc == Instruction::SRem;
171}
172
173/// Some instructions can use 8- and 16-bit operands, and we don't need to
174/// promote anything larger. We disallow booleans to make life easier when
175/// dealing with icmps but allow any other integer that is <= 16 bits. Void
176/// types are accepted so we can handle switches.
177static bool isSupportedType(Value *V) {
Sam Parker8c4b9642018-08-10 13:57:13 +0000178 Type *Ty = V->getType();
Sam Parker7def86b2018-08-15 07:52:35 +0000179
180 // Allow voids and pointers, these won't be promoted.
181 if (Ty->isVoidTy() || Ty->isPointerTy())
Sam Parker3828c6f2018-07-23 12:27:47 +0000182 return true;
183
Sam Parker8c4b9642018-08-10 13:57:13 +0000184 if (auto *Ld = dyn_cast<LoadInst>(V))
185 Ty = cast<PointerType>(Ld->getPointerOperandType())->getElementType();
186
187 const IntegerType *IntTy = dyn_cast<IntegerType>(Ty);
Sam Parkeraaec3c62018-09-13 15:14:12 +0000188 if (!IntTy)
Sam Parker3828c6f2018-07-23 12:27:47 +0000189 return false;
190
Sam Parker8c4b9642018-08-10 13:57:13 +0000191 return IntTy->getBitWidth() == ARMCodeGenPrepare::TypeSize;
192}
Sam Parker3828c6f2018-07-23 12:27:47 +0000193
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000194/// Return true if the given value is a source in the use-def chain, producing
Sam Parker8c4b9642018-08-10 13:57:13 +0000195/// a narrow (i8, i16) value. These values will be zext to start the promotion
196/// of the tree to i32. We guarantee that these won't populate the upper bits
197/// of the register. ZExt on the loads will be free, and the same for call
198/// return values because we only accept ones that guarantee a zeroext ret val.
199/// Many arguments will have the zeroext attribute too, so those would be free
200/// too.
201static bool isSource(Value *V) {
Sam Parker7def86b2018-08-15 07:52:35 +0000202 if (!isa<IntegerType>(V->getType()))
203 return false;
Sam Parkeraaec3c62018-09-13 15:14:12 +0000204 // TODO Allow zext to be sources.
Sam Parker8c4b9642018-08-10 13:57:13 +0000205 if (isa<Argument>(V))
206 return true;
207 else if (isa<LoadInst>(V))
208 return true;
Sam Parker569b2452018-09-12 09:11:48 +0000209 else if (isa<BitCastInst>(V))
210 return true;
Sam Parker8c4b9642018-08-10 13:57:13 +0000211 else if (auto *Call = dyn_cast<CallInst>(V))
212 return Call->hasRetAttr(Attribute::AttrKind::ZExt);
Sam Parkeraaec3c62018-09-13 15:14:12 +0000213 else if (auto *Trunc = dyn_cast<TruncInst>(V))
214 return isSupportedType(Trunc);
Sam Parker8c4b9642018-08-10 13:57:13 +0000215 return false;
Sam Parker3828c6f2018-07-23 12:27:47 +0000216}
217
218/// Return true if V will require any promoted values to be truncated for the
Sam Parker8c4b9642018-08-10 13:57:13 +0000219/// the IR to remain valid. We can't mutate the value type of these
220/// instructions.
Sam Parker3828c6f2018-07-23 12:27:47 +0000221static bool isSink(Value *V) {
Sam Parker8c4b9642018-08-10 13:57:13 +0000222 // TODO The truncate also isn't actually necessary because we would already
223 // proved that the data value is kept within the range of the original data
224 // type.
Sam Parker3828c6f2018-07-23 12:27:47 +0000225 auto UsesNarrowValue = [](Value *V) {
Sam Parker8c4b9642018-08-10 13:57:13 +0000226 return V->getType()->getScalarSizeInBits() == ARMCodeGenPrepare::TypeSize;
Sam Parker3828c6f2018-07-23 12:27:47 +0000227 };
228
229 if (auto *Store = dyn_cast<StoreInst>(V))
230 return UsesNarrowValue(Store->getValueOperand());
231 if (auto *Return = dyn_cast<ReturnInst>(V))
232 return UsesNarrowValue(Return->getReturnValue());
Sam Parker8c4b9642018-08-10 13:57:13 +0000233 if (auto *Trunc = dyn_cast<TruncInst>(V))
234 return UsesNarrowValue(Trunc->getOperand(0));
Sam Parker0e2f0bd2018-08-16 11:54:09 +0000235 if (auto *ZExt = dyn_cast<ZExtInst>(V))
236 return UsesNarrowValue(ZExt->getOperand(0));
Sam Parker13567db2018-08-16 10:05:39 +0000237 if (auto *ICmp = dyn_cast<ICmpInst>(V))
238 return ICmp->isSigned();
Sam Parker3828c6f2018-07-23 12:27:47 +0000239
240 return isa<CallInst>(V);
241}
242
Sam Parker3828c6f2018-07-23 12:27:47 +0000243/// Return whether the instruction can be promoted within any modifications to
244/// it's operands or result.
245static bool isSafeOverflow(Instruction *I) {
Sam Parker8c4b9642018-08-10 13:57:13 +0000246 // FIXME Do we need NSW too?
Sam Parker3828c6f2018-07-23 12:27:47 +0000247 if (isa<OverflowingBinaryOperator>(I) && I->hasNoUnsignedWrap())
248 return true;
249
250 unsigned Opc = I->getOpcode();
251 if (Opc == Instruction::Add || Opc == Instruction::Sub) {
252 // We don't care if the add or sub could wrap if the value is decreasing
253 // and is only being used by an unsigned compare.
254 if (!I->hasOneUse() ||
255 !isa<ICmpInst>(*I->user_begin()) ||
256 !isa<ConstantInt>(I->getOperand(1)))
257 return false;
258
259 auto *CI = cast<ICmpInst>(*I->user_begin());
260 if (CI->isSigned())
261 return false;
262
263 bool NegImm = cast<ConstantInt>(I->getOperand(1))->isNegative();
264 bool IsDecreasing = ((Opc == Instruction::Sub) && !NegImm) ||
265 ((Opc == Instruction::Add) && NegImm);
266 if (!IsDecreasing)
267 return false;
268
269 LLVM_DEBUG(dbgs() << "ARM CGP: Allowing safe overflow for " << *I << "\n");
270 return true;
271 }
272
Sam Parker3828c6f2018-07-23 12:27:47 +0000273 return false;
274}
275
276static bool shouldPromote(Value *V) {
Sam Parkeraaec3c62018-09-13 15:14:12 +0000277 if (!isa<IntegerType>(V->getType()) || isSink(V))
Sam Parker8c4b9642018-08-10 13:57:13 +0000278 return false;
279
280 if (isSource(V))
281 return true;
282
Sam Parker3828c6f2018-07-23 12:27:47 +0000283 auto *I = dyn_cast<Instruction>(V);
284 if (!I)
285 return false;
286
Sam Parker8c4b9642018-08-10 13:57:13 +0000287 if (isa<ICmpInst>(I))
Sam Parker3828c6f2018-07-23 12:27:47 +0000288 return false;
289
Sam Parker3828c6f2018-07-23 12:27:47 +0000290 return true;
291}
292
293/// Return whether we can safely mutate V's type to ExtTy without having to be
294/// concerned with zero extending or truncation.
295static bool isPromotedResultSafe(Value *V) {
296 if (!isa<Instruction>(V))
297 return true;
298
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000299 if (generateSignBits(V))
Sam Parker3828c6f2018-07-23 12:27:47 +0000300 return false;
301
302 // If I is only being used by something that will require its value to be
303 // truncated, then we don't care about the promoted result.
304 auto *I = cast<Instruction>(V);
305 if (I->hasOneUse() && isSink(*I->use_begin()))
306 return true;
307
308 if (isa<OverflowingBinaryOperator>(I))
309 return isSafeOverflow(I);
310 return true;
311}
312
313/// Return the intrinsic for the instruction that can perform the same
314/// operation but on a narrow type. This is using the parallel dsp intrinsics
315/// on scalar values.
Sam Parker8c4b9642018-08-10 13:57:13 +0000316static Intrinsic::ID getNarrowIntrinsic(Instruction *I) {
Sam Parker3828c6f2018-07-23 12:27:47 +0000317 // Whether we use the signed or unsigned versions of these intrinsics
318 // doesn't matter because we're not using the GE bits that they set in
319 // the APSR.
320 switch(I->getOpcode()) {
321 default:
322 break;
323 case Instruction::Add:
Sam Parker8c4b9642018-08-10 13:57:13 +0000324 return ARMCodeGenPrepare::TypeSize == 16 ? Intrinsic::arm_uadd16 :
Sam Parker3828c6f2018-07-23 12:27:47 +0000325 Intrinsic::arm_uadd8;
326 case Instruction::Sub:
Sam Parker8c4b9642018-08-10 13:57:13 +0000327 return ARMCodeGenPrepare::TypeSize == 16 ? Intrinsic::arm_usub16 :
Sam Parker3828c6f2018-07-23 12:27:47 +0000328 Intrinsic::arm_usub8;
329 }
330 llvm_unreachable("unhandled opcode for narrow intrinsic");
331}
332
333void IRPromoter::Mutate(Type *OrigTy,
334 SmallPtrSetImpl<Value*> &Visited,
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000335 SmallPtrSetImpl<Value*> &Sources,
336 SmallPtrSetImpl<Instruction*> &Sinks) {
Sam Parker3828c6f2018-07-23 12:27:47 +0000337 IRBuilder<> Builder{Ctx};
338 Type *ExtTy = Type::getInt32Ty(M->getContext());
Sam Parker3828c6f2018-07-23 12:27:47 +0000339 SmallPtrSet<Value*, 8> Promoted;
Sam Parker8c4b9642018-08-10 13:57:13 +0000340 LLVM_DEBUG(dbgs() << "ARM CGP: Promoting use-def chains to from "
341 << ARMCodeGenPrepare::TypeSize << " to 32-bits\n");
Sam Parker3828c6f2018-07-23 12:27:47 +0000342
Sam Parker13567db2018-08-16 10:05:39 +0000343 // Cache original types.
344 DenseMap<Value*, Type*> TruncTysMap;
345 for (auto *V : Visited)
346 TruncTysMap[V] = V->getType();
347
Sam Parker3828c6f2018-07-23 12:27:47 +0000348 auto ReplaceAllUsersOfWith = [&](Value *From, Value *To) {
349 SmallVector<Instruction*, 4> Users;
350 Instruction *InstTo = dyn_cast<Instruction>(To);
351 for (Use &U : From->uses()) {
352 auto *User = cast<Instruction>(U.getUser());
353 if (InstTo && User->isIdenticalTo(InstTo))
354 continue;
355 Users.push_back(User);
356 }
357
Sam Parkeraaec3c62018-09-13 15:14:12 +0000358 for (auto *U : Users)
Sam Parker3828c6f2018-07-23 12:27:47 +0000359 U->replaceUsesOfWith(From, To);
360 };
361
362 auto FixConst = [&](ConstantInt *Const, Instruction *I) {
Sam Parker96f77f12018-09-13 14:48:10 +0000363 Constant *NewConst = isSafeOverflow(I) && Const->isNegative() ?
364 ConstantExpr::getSExt(Const, ExtTy) :
365 ConstantExpr::getZExt(Const, ExtTy);
Sam Parker3828c6f2018-07-23 12:27:47 +0000366 I->replaceUsesOfWith(Const, NewConst);
367 };
368
369 auto InsertDSPIntrinsic = [&](Instruction *I) {
370 LLVM_DEBUG(dbgs() << "ARM CGP: Inserting DSP intrinsic for "
371 << *I << "\n");
372 Function *DSPInst =
Sam Parker8c4b9642018-08-10 13:57:13 +0000373 Intrinsic::getDeclaration(M, getNarrowIntrinsic(I));
Sam Parker3828c6f2018-07-23 12:27:47 +0000374 Builder.SetInsertPoint(I);
375 Builder.SetCurrentDebugLocation(I->getDebugLoc());
376 Value *Args[] = { I->getOperand(0), I->getOperand(1) };
377 CallInst *Call = Builder.CreateCall(DSPInst, Args);
378 ReplaceAllUsersOfWith(I, Call);
379 InstsToRemove.push_back(I);
380 NewInsts.insert(Call);
Sam Parker13567db2018-08-16 10:05:39 +0000381 TruncTysMap[Call] = OrigTy;
Sam Parker3828c6f2018-07-23 12:27:47 +0000382 };
383
384 auto InsertZExt = [&](Value *V, Instruction *InsertPt) {
385 LLVM_DEBUG(dbgs() << "ARM CGP: Inserting ZExt for " << *V << "\n");
386 Builder.SetInsertPoint(InsertPt);
387 if (auto *I = dyn_cast<Instruction>(V))
388 Builder.SetCurrentDebugLocation(I->getDebugLoc());
389 auto *ZExt = cast<Instruction>(Builder.CreateZExt(V, ExtTy));
390 if (isa<Argument>(V))
391 ZExt->moveBefore(InsertPt);
392 else
393 ZExt->moveAfter(InsertPt);
394 ReplaceAllUsersOfWith(V, ZExt);
395 NewInsts.insert(ZExt);
Sam Parker13567db2018-08-16 10:05:39 +0000396 TruncTysMap[ZExt] = TruncTysMap[V];
Sam Parker3828c6f2018-07-23 12:27:47 +0000397 };
398
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000399 // First, insert extending instructions between the sources and their users.
400 LLVM_DEBUG(dbgs() << "ARM CGP: Promoting sources:\n");
401 for (auto V : Sources) {
Sam Parker3828c6f2018-07-23 12:27:47 +0000402 LLVM_DEBUG(dbgs() << " - " << *V << "\n");
Sam Parker8c4b9642018-08-10 13:57:13 +0000403 if (auto *I = dyn_cast<Instruction>(V))
Sam Parker3828c6f2018-07-23 12:27:47 +0000404 InsertZExt(I, I);
405 else if (auto *Arg = dyn_cast<Argument>(V)) {
406 BasicBlock &BB = Arg->getParent()->front();
407 InsertZExt(Arg, &*BB.getFirstInsertionPt());
408 } else {
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000409 llvm_unreachable("unhandled source that needs extending");
Sam Parker3828c6f2018-07-23 12:27:47 +0000410 }
411 Promoted.insert(V);
412 }
413
414 LLVM_DEBUG(dbgs() << "ARM CGP: Mutating the tree..\n");
415 // Then mutate the types of the instructions within the tree. Here we handle
416 // constant operands.
417 for (auto *V : Visited) {
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000418 if (Sources.count(V))
Sam Parker3828c6f2018-07-23 12:27:47 +0000419 continue;
420
Sam Parker3828c6f2018-07-23 12:27:47 +0000421 auto *I = cast<Instruction>(V);
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000422 if (Sinks.count(I))
Sam Parker3828c6f2018-07-23 12:27:47 +0000423 continue;
424
Sam Parker7def86b2018-08-15 07:52:35 +0000425 for (unsigned i = 0, e = I->getNumOperands(); i < e; ++i) {
426 Value *Op = I->getOperand(i);
427 if ((Op->getType() == ExtTy) || !isa<IntegerType>(Op->getType()))
Sam Parker3828c6f2018-07-23 12:27:47 +0000428 continue;
429
Sam Parker7def86b2018-08-15 07:52:35 +0000430 if (auto *Const = dyn_cast<ConstantInt>(Op))
Sam Parker3828c6f2018-07-23 12:27:47 +0000431 FixConst(Const, I);
Sam Parker7def86b2018-08-15 07:52:35 +0000432 else if (isa<UndefValue>(Op))
433 I->setOperand(i, UndefValue::get(ExtTy));
Sam Parker3828c6f2018-07-23 12:27:47 +0000434 }
435
436 if (shouldPromote(I)) {
437 I->mutateType(ExtTy);
438 Promoted.insert(I);
439 }
440 }
441
442 // Now we need to remove any zexts that have become unnecessary, as well
443 // as insert any intrinsics.
444 for (auto *V : Visited) {
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000445 if (Sources.count(V))
Sam Parker3828c6f2018-07-23 12:27:47 +0000446 continue;
Sam Parker8c4b9642018-08-10 13:57:13 +0000447
Sam Parker3828c6f2018-07-23 12:27:47 +0000448 if (!shouldPromote(V) || isPromotedResultSafe(V))
449 continue;
450
451 // Replace unsafe instructions with appropriate intrinsic calls.
452 InsertDSPIntrinsic(cast<Instruction>(V));
453 }
454
Sam Parker13567db2018-08-16 10:05:39 +0000455 auto InsertTrunc = [&](Value *V) -> Instruction* {
456 if (!isa<Instruction>(V) || !isa<IntegerType>(V->getType()))
457 return nullptr;
458
Sam Parker0e2f0bd2018-08-16 11:54:09 +0000459 if ((!Promoted.count(V) && !NewInsts.count(V)) || !TruncTysMap.count(V) ||
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000460 Sources.count(V))
Sam Parker13567db2018-08-16 10:05:39 +0000461 return nullptr;
462
463 Type *TruncTy = TruncTysMap[V];
464 if (TruncTy == ExtTy)
465 return nullptr;
466
467 LLVM_DEBUG(dbgs() << "ARM CGP: Creating " << *TruncTy << " Trunc for "
468 << *V << "\n");
469 Builder.SetInsertPoint(cast<Instruction>(V));
470 auto *Trunc = cast<Instruction>(Builder.CreateTrunc(V, TruncTy));
471 NewInsts.insert(Trunc);
472 return Trunc;
473 };
474
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000475 LLVM_DEBUG(dbgs() << "ARM CGP: Fixing up the sinks:\n");
Sam Parker3828c6f2018-07-23 12:27:47 +0000476 // Fix up any stores or returns that use the results of the promoted
477 // chain.
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000478 for (auto I : Sinks) {
Sam Parker3828c6f2018-07-23 12:27:47 +0000479 LLVM_DEBUG(dbgs() << " - " << *I << "\n");
Sam Parker13567db2018-08-16 10:05:39 +0000480
481 // Handle calls separately as we need to iterate over arg operands.
482 if (auto *Call = dyn_cast<CallInst>(I)) {
483 for (unsigned i = 0; i < Call->getNumArgOperands(); ++i) {
484 Value *Arg = Call->getArgOperand(i);
485 if (Instruction *Trunc = InsertTrunc(Arg)) {
486 Trunc->moveBefore(Call);
487 Call->setArgOperand(i, Trunc);
488 }
489 }
490 continue;
Sam Parker3828c6f2018-07-23 12:27:47 +0000491 }
492
Sam Parker13567db2018-08-16 10:05:39 +0000493 // Now handle the others.
Sam Parker3828c6f2018-07-23 12:27:47 +0000494 for (unsigned i = 0; i < I->getNumOperands(); ++i) {
Sam Parker13567db2018-08-16 10:05:39 +0000495 if (Instruction *Trunc = InsertTrunc(I->getOperand(i))) {
496 Trunc->moveBefore(I);
497 I->setOperand(i, Trunc);
Sam Parker3828c6f2018-07-23 12:27:47 +0000498 }
499 }
500 }
Sam Parker0e2f0bd2018-08-16 11:54:09 +0000501 LLVM_DEBUG(dbgs() << "ARM CGP: Mutation complete:\n");
Sam Parkeraaec3c62018-09-13 15:14:12 +0000502 LLVM_DEBUG(dbgs();
503 for (auto *V : Sources)
504 V->dump();
505 for (auto *I : NewInsts)
506 I->dump();
507 for (auto *V : Visited) {
508 if (!Sources.count(V))
509 V->dump();
510 });
Sam Parker3828c6f2018-07-23 12:27:47 +0000511}
512
Sam Parker8c4b9642018-08-10 13:57:13 +0000513/// We accept most instructions, as well as Arguments and ConstantInsts. We
514/// Disallow casts other than zext and truncs and only allow calls if their
515/// return value is zeroext. We don't allow opcodes that can introduce sign
516/// bits.
517bool ARMCodeGenPrepare::isSupportedValue(Value *V) {
Sam Parker13567db2018-08-16 10:05:39 +0000518 if (isa<ICmpInst>(V))
519 return true;
Sam Parker8c4b9642018-08-10 13:57:13 +0000520
521 // Memory instructions
522 if (isa<StoreInst>(V) || isa<GetElementPtrInst>(V))
523 return true;
524
525 // Branches and targets.
526 if( isa<BranchInst>(V) || isa<SwitchInst>(V) || isa<BasicBlock>(V))
527 return true;
528
529 // Non-instruction values that we can handle.
Sam Parker7def86b2018-08-15 07:52:35 +0000530 if ((isa<Constant>(V) && !isa<ConstantExpr>(V)) || isa<Argument>(V))
Sam Parker8c4b9642018-08-10 13:57:13 +0000531 return isSupportedType(V);
532
533 if (isa<PHINode>(V) || isa<SelectInst>(V) || isa<ReturnInst>(V) ||
534 isa<LoadInst>(V))
535 return isSupportedType(V);
536
Sam Parkeraaec3c62018-09-13 15:14:12 +0000537 // Truncs can be either sources or sinks.
538 if (auto *Trunc = dyn_cast<TruncInst>(V))
539 return isSupportedType(Trunc) || isSupportedType(Trunc->getOperand(0));
540
541 if (isa<CastInst>(V) && !isa<SExtInst>(V))
Sam Parker569b2452018-09-12 09:11:48 +0000542 return isSupportedType(cast<CastInst>(V)->getOperand(0));
Sam Parker0e2f0bd2018-08-16 11:54:09 +0000543
Sam Parker8c4b9642018-08-10 13:57:13 +0000544 // Special cases for calls as we need to check for zeroext
545 // TODO We should accept calls even if they don't have zeroext, as they can
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000546 // still be sinks.
Sam Parker8c4b9642018-08-10 13:57:13 +0000547 if (auto *Call = dyn_cast<CallInst>(V))
548 return isSupportedType(Call) &&
549 Call->hasRetAttr(Attribute::AttrKind::ZExt);
550
Sam Parkeraaec3c62018-09-13 15:14:12 +0000551 if (!isa<BinaryOperator>(V))
Sam Parker8c4b9642018-08-10 13:57:13 +0000552 return false;
Sam Parkeraaec3c62018-09-13 15:14:12 +0000553
Sam Parker8c4b9642018-08-10 13:57:13 +0000554 if (!isSupportedType(V))
555 return false;
556
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000557 if (generateSignBits(V)) {
558 LLVM_DEBUG(dbgs() << "ARM CGP: No, instruction can generate sign bits.\n");
559 return false;
560 }
561 return true;
Sam Parker8c4b9642018-08-10 13:57:13 +0000562}
563
564/// Check that the type of V would be promoted and that the original type is
565/// smaller than the targeted promoted type. Check that we're not trying to
566/// promote something larger than our base 'TypeSize' type.
567bool ARMCodeGenPrepare::isLegalToPromote(Value *V) {
568 if (isPromotedResultSafe(V))
569 return true;
570
571 auto *I = dyn_cast<Instruction>(V);
572 if (!I)
573 return false;
574
575 // If promotion is not safe, can we use a DSP instruction to natively
576 // handle the narrow type?
Sam Parker3828c6f2018-07-23 12:27:47 +0000577 if (!ST->hasDSP() || !EnableDSP || !isSupportedType(I))
578 return false;
579
580 if (ST->isThumb() && !ST->hasThumb2())
581 return false;
582
583 if (I->getOpcode() != Instruction::Add && I->getOpcode() != Instruction::Sub)
584 return false;
585
586 // TODO
587 // Would it be profitable? For Thumb code, these parallel DSP instructions
588 // are only Thumb-2, so we wouldn't be able to dual issue on Cortex-M33. For
589 // Cortex-A, specifically Cortex-A72, the latency is double and throughput is
590 // halved. They also do not take immediates as operands.
591 for (auto &Op : I->operands()) {
592 if (isa<Constant>(Op)) {
593 if (!EnableDSPWithImms)
594 return false;
595 }
596 }
597 return true;
598}
599
Sam Parker3828c6f2018-07-23 12:27:47 +0000600bool ARMCodeGenPrepare::TryToPromote(Value *V) {
601 OrigTy = V->getType();
602 TypeSize = OrigTy->getPrimitiveSizeInBits();
Sam Parkerfabf7fe2018-08-15 13:29:50 +0000603 if (TypeSize > 16 || TypeSize < 8)
Sam Parker8c4b9642018-08-10 13:57:13 +0000604 return false;
Sam Parker3828c6f2018-07-23 12:27:47 +0000605
606 if (!isSupportedValue(V) || !shouldPromote(V) || !isLegalToPromote(V))
607 return false;
608
Sam Parker8c4b9642018-08-10 13:57:13 +0000609 LLVM_DEBUG(dbgs() << "ARM CGP: TryToPromote: " << *V << ", TypeSize = "
610 << TypeSize << "\n");
Sam Parker3828c6f2018-07-23 12:27:47 +0000611
612 SetVector<Value*> WorkList;
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000613 SmallPtrSet<Value*, 8> Sources;
614 SmallPtrSet<Instruction*, 4> Sinks;
Sam Parker3828c6f2018-07-23 12:27:47 +0000615 WorkList.insert(V);
616 SmallPtrSet<Value*, 16> CurrentVisited;
617 CurrentVisited.clear();
618
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000619 // Return true if V was added to the worklist as a supported instruction,
620 // if it was already visited, or if we don't need to explore it (e.g.
621 // pointer values and GEPs), and false otherwise.
Sam Parker3828c6f2018-07-23 12:27:47 +0000622 auto AddLegalInst = [&](Value *V) {
623 if (CurrentVisited.count(V))
624 return true;
625
Sam Parker0d511972018-08-16 12:24:40 +0000626 // Ignore GEPs because they don't need promoting and the constant indices
627 // will prevent the transformation.
628 if (isa<GetElementPtrInst>(V))
629 return true;
630
Sam Parker3828c6f2018-07-23 12:27:47 +0000631 if (!isSupportedValue(V) || (shouldPromote(V) && !isLegalToPromote(V))) {
632 LLVM_DEBUG(dbgs() << "ARM CGP: Can't handle: " << *V << "\n");
633 return false;
634 }
635
636 WorkList.insert(V);
637 return true;
638 };
639
640 // Iterate through, and add to, a tree of operands and users in the use-def.
641 while (!WorkList.empty()) {
642 Value *V = WorkList.back();
643 WorkList.pop_back();
644 if (CurrentVisited.count(V))
645 continue;
646
Sam Parker7def86b2018-08-15 07:52:35 +0000647 // Ignore non-instructions, other than arguments.
Sam Parker3828c6f2018-07-23 12:27:47 +0000648 if (!isa<Instruction>(V) && !isSource(V))
649 continue;
650
651 // If we've already visited this value from somewhere, bail now because
652 // the tree has already been explored.
653 // TODO: This could limit the transform, ie if we try to promote something
654 // from an i8 and fail first, before trying an i16.
Sam Parkeraaec3c62018-09-13 15:14:12 +0000655 if (AllVisited.count(V))
Sam Parker3828c6f2018-07-23 12:27:47 +0000656 return false;
Sam Parker3828c6f2018-07-23 12:27:47 +0000657
658 CurrentVisited.insert(V);
659 AllVisited.insert(V);
660
661 // Calls can be both sources and sinks.
662 if (isSink(V))
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000663 Sinks.insert(cast<Instruction>(V));
Sam Parker3828c6f2018-07-23 12:27:47 +0000664 if (isSource(V))
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000665 Sources.insert(V);
Sam Parker3828c6f2018-07-23 12:27:47 +0000666 else if (auto *I = dyn_cast<Instruction>(V)) {
667 // Visit operands of any instruction visited.
668 for (auto &U : I->operands()) {
669 if (!AddLegalInst(U))
670 return false;
671 }
672 }
673
674 // Don't visit users of a node which isn't going to be mutated unless its a
675 // source.
676 if (isSource(V) || shouldPromote(V)) {
677 for (Use &U : V->uses()) {
678 if (!AddLegalInst(U.getUser()))
679 return false;
680 }
681 }
682 }
683
Sam Parker3828c6f2018-07-23 12:27:47 +0000684 LLVM_DEBUG(dbgs() << "ARM CGP: Visited nodes:\n";
685 for (auto *I : CurrentVisited)
686 I->dump();
687 );
Sam Parker7def86b2018-08-15 07:52:35 +0000688 unsigned ToPromote = 0;
689 for (auto *V : CurrentVisited) {
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000690 if (Sources.count(V))
Sam Parker7def86b2018-08-15 07:52:35 +0000691 continue;
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000692 if (Sinks.count(cast<Instruction>(V)))
Sam Parker7def86b2018-08-15 07:52:35 +0000693 continue;
694 ++ToPromote;
695 }
696
697 if (ToPromote < 2)
698 return false;
Sam Parker3828c6f2018-07-23 12:27:47 +0000699
Sjoerd Meijer31239a42018-08-17 07:34:01 +0000700 Promoter->Mutate(OrigTy, CurrentVisited, Sources, Sinks);
Sam Parker3828c6f2018-07-23 12:27:47 +0000701 return true;
702}
703
704bool ARMCodeGenPrepare::doInitialization(Module &M) {
705 Promoter = new IRPromoter(&M);
706 return false;
707}
708
709bool ARMCodeGenPrepare::runOnFunction(Function &F) {
710 if (skipFunction(F) || DisableCGP)
711 return false;
712
713 auto *TPC = &getAnalysis<TargetPassConfig>();
714 if (!TPC)
715 return false;
716
717 const TargetMachine &TM = TPC->getTM<TargetMachine>();
718 ST = &TM.getSubtarget<ARMSubtarget>(F);
719 bool MadeChange = false;
720 LLVM_DEBUG(dbgs() << "ARM CGP: Running on " << F.getName() << "\n");
721
722 // Search up from icmps to try to promote their operands.
723 for (BasicBlock &BB : F) {
724 auto &Insts = BB.getInstList();
725 for (auto &I : Insts) {
726 if (AllVisited.count(&I))
727 continue;
728
729 if (isa<ICmpInst>(I)) {
730 auto &CI = cast<ICmpInst>(I);
731
732 // Skip signed or pointer compares
733 if (CI.isSigned() || !isa<IntegerType>(CI.getOperand(0)->getType()))
734 continue;
735
Sam Parker3828c6f2018-07-23 12:27:47 +0000736 for (auto &Op : CI.operands()) {
Sam Parker8c4b9642018-08-10 13:57:13 +0000737 if (auto *I = dyn_cast<Instruction>(Op))
738 MadeChange |= TryToPromote(I);
Sam Parker3828c6f2018-07-23 12:27:47 +0000739 }
740 }
741 }
742 Promoter->Cleanup();
743 LLVM_DEBUG(if (verifyFunction(F, &dbgs())) {
744 dbgs();
745 report_fatal_error("Broken function after type promotion");
746 });
747 }
748 if (MadeChange)
749 LLVM_DEBUG(dbgs() << "After ARMCodeGenPrepare: " << F << "\n");
750
751 return MadeChange;
752}
753
Matt Morehousea70685f2018-07-23 17:00:45 +0000754bool ARMCodeGenPrepare::doFinalization(Module &M) {
755 delete Promoter;
756 return false;
757}
758
Sam Parker3828c6f2018-07-23 12:27:47 +0000759INITIALIZE_PASS_BEGIN(ARMCodeGenPrepare, DEBUG_TYPE,
760 "ARM IR optimizations", false, false)
761INITIALIZE_PASS_END(ARMCodeGenPrepare, DEBUG_TYPE, "ARM IR optimizations",
762 false, false)
763
764char ARMCodeGenPrepare::ID = 0;
Sam Parker8c4b9642018-08-10 13:57:13 +0000765unsigned ARMCodeGenPrepare::TypeSize = 0;
Sam Parker3828c6f2018-07-23 12:27:47 +0000766
767FunctionPass *llvm::createARMCodeGenPreparePass() {
768 return new ARMCodeGenPrepare();
769}