Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python |
| 2 | |
| 3 | """ |
| 4 | Static Analyzer qualification infrastructure. |
| 5 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 6 | The goal is to test the analyzer against different projects, |
| 7 | check for failures, compare results, and measure performance. |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 8 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 9 | Repository Directory will contain sources of the projects as well as the |
| 10 | information on how to build them and the expected output. |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 11 | Repository Directory structure: |
| 12 | - ProjectMap file |
| 13 | - Historical Performance Data |
| 14 | - Project Dir1 |
| 15 | - ReferenceOutput |
| 16 | - Project Dir2 |
| 17 | - ReferenceOutput |
| 18 | .. |
Gabor Horvath | c3177f2 | 2015-07-08 18:39:31 +0000 | [diff] [blame] | 19 | Note that the build tree must be inside the project dir. |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 20 | |
| 21 | To test the build of the analyzer one would: |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 22 | - Copy over a copy of the Repository Directory. (TODO: Prefer to ensure that |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 23 | the build directory does not pollute the repository to min network |
| 24 | traffic). |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 25 | - Build all projects, until error. Produce logs to report errors. |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 26 | - Compare results. |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 27 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 28 | The files which should be kept around for failure investigations: |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 29 | RepositoryCopy/Project DirI/ScanBuildResults |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 30 | RepositoryCopy/Project DirI/run_static_analyzer.log |
| 31 | |
| 32 | Assumptions (TODO: shouldn't need to assume these.): |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 33 | The script is being run from the Repository Directory. |
Anna Zaks | 42a4463 | 2011-11-02 20:46:50 +0000 | [diff] [blame] | 34 | The compiler for scan-build and scan-build are in the PATH. |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 35 | export PATH=/Users/zaks/workspace/c2llvm/build/Release+Asserts/bin:$PATH |
| 36 | |
| 37 | For more logging, set the env variables: |
| 38 | zaks:TI zaks$ export CCC_ANALYZER_LOG=1 |
| 39 | zaks:TI zaks$ export CCC_ANALYZER_VERBOSE=1 |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 40 | |
Gabor Horvath | da32a86 | 2015-08-20 22:59:49 +0000 | [diff] [blame] | 41 | The list of checkers tested are hardcoded in the Checkers variable. |
| 42 | For testing additional checkers, use the SA_ADDITIONAL_CHECKERS environment |
| 43 | variable. It should contain a comma separated list. |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 44 | """ |
| 45 | import CmpRuns |
George Karpenkov | bf92c44 | 2017-10-24 23:52:48 +0000 | [diff] [blame] | 46 | import SATestUtils |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 47 | |
Gabor Horvath | 93fde94 | 2015-06-30 15:31:17 +0000 | [diff] [blame] | 48 | import argparse |
George Karpenkov | f37d3a5 | 2018-02-08 21:22:42 +0000 | [diff] [blame] | 49 | import csv |
| 50 | import glob |
| 51 | import logging |
| 52 | import math |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 53 | import multiprocessing |
George Karpenkov | f37d3a5 | 2018-02-08 21:22:42 +0000 | [diff] [blame] | 54 | import os |
| 55 | import plistlib |
| 56 | import shutil |
| 57 | import sys |
| 58 | import threading |
| 59 | import time |
Artem Dergachev | 1a3b801 | 2020-05-15 14:27:30 +0300 | [diff] [blame] | 60 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 61 | from queue import Queue |
| 62 | from subprocess import CalledProcessError, check_call |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 63 | from typing import (cast, Dict, Iterable, IO, List, NamedTuple, Optional, |
| 64 | Tuple, TYPE_CHECKING) |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 65 | |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 66 | |
George Karpenkov | 13d3748 | 2018-07-30 23:01:20 +0000 | [diff] [blame] | 67 | ############################################################################### |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 68 | # Helper functions. |
George Karpenkov | 13d3748 | 2018-07-30 23:01:20 +0000 | [diff] [blame] | 69 | ############################################################################### |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 70 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 71 | LOCAL = threading.local() |
| 72 | LOCAL.stdout = sys.stdout |
| 73 | LOCAL.stderr = sys.stderr |
| 74 | |
| 75 | |
| 76 | def stderr(message: str): |
| 77 | LOCAL.stderr.write(message) |
| 78 | |
| 79 | |
| 80 | def stdout(message: str): |
| 81 | LOCAL.stdout.write(message) |
| 82 | |
| 83 | |
George Karpenkov | f37d3a5 | 2018-02-08 21:22:42 +0000 | [diff] [blame] | 84 | logging.basicConfig( |
| 85 | level=logging.DEBUG, |
| 86 | format='%(asctime)s:%(levelname)s:%(name)s: %(message)s') |
Ted Kremenek | f9a539d | 2012-08-28 20:40:04 +0000 | [diff] [blame] | 87 | |
Valeriy Savchenko | c98872e | 2020-05-14 13:31:01 +0300 | [diff] [blame] | 88 | |
George Karpenkov | 13d3748 | 2018-07-30 23:01:20 +0000 | [diff] [blame] | 89 | ############################################################################### |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 90 | # Configuration setup. |
George Karpenkov | 13d3748 | 2018-07-30 23:01:20 +0000 | [diff] [blame] | 91 | ############################################################################### |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 92 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 93 | |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 94 | # Find Clang for static analysis. |
George Karpenkov | be6c329 | 2017-09-21 22:12:49 +0000 | [diff] [blame] | 95 | if 'CC' in os.environ: |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 96 | cc_candidate: Optional[str] = os.environ['CC'] |
George Karpenkov | be6c329 | 2017-09-21 22:12:49 +0000 | [diff] [blame] | 97 | else: |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 98 | cc_candidate = SATestUtils.which("clang", os.environ['PATH']) |
| 99 | if not cc_candidate: |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 100 | stderr("Error: cannot find 'clang' in PATH") |
George Karpenkov | 65839bd | 2017-10-26 01:13:22 +0000 | [diff] [blame] | 101 | sys.exit(1) |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 102 | |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 103 | CLANG = cc_candidate |
| 104 | |
Ted Kremenek | f9a539d | 2012-08-28 20:40:04 +0000 | [diff] [blame] | 105 | # Number of jobs. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 106 | MAX_JOBS = int(math.ceil(multiprocessing.cpu_count() * 0.75)) |
Ted Kremenek | f9a539d | 2012-08-28 20:40:04 +0000 | [diff] [blame] | 107 | |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 108 | # Project map stores info about all the "registered" projects. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 109 | PROJECT_MAP_FILE = "projectMap.csv" |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 110 | |
| 111 | # Names of the project specific scripts. |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 112 | # The script that downloads the project. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 113 | DOWNLOAD_SCRIPT = "download_project.sh" |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 114 | # The script that needs to be executed before the build can start. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 115 | CLEANUP_SCRIPT = "cleanup_run_static_analyzer.sh" |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 116 | # This is a file containing commands for scan-build. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 117 | BUILD_SCRIPT = "run_static_analyzer.cmd" |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 118 | |
George Karpenkov | 5c23d6a | 2018-06-29 22:05:32 +0000 | [diff] [blame] | 119 | # A comment in a build script which disables wrapping. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 120 | NO_PREFIX_CMD = "#NOPREFIX" |
George Karpenkov | 5c23d6a | 2018-06-29 22:05:32 +0000 | [diff] [blame] | 121 | |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 122 | # The log file name. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 123 | LOG_DIR_NAME = "Logs" |
| 124 | BUILD_LOG_NAME = "run_static_analyzer.log" |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 125 | # Summary file - contains the summary of the failures. Ex: This info can be be |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 126 | # displayed when buildbot detects a build failure. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 127 | NUM_OF_FAILURES_IN_SUMMARY = 10 |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 128 | |
| 129 | # The scan-build result directory. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 130 | OUTPUT_DIR_NAME = "ScanBuildResults" |
| 131 | REF_PREFIX = "Ref" |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 132 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 133 | # The name of the directory storing the cached project source. If this |
| 134 | # directory does not exist, the download script will be executed. |
| 135 | # That script should create the "CachedSource" directory and download the |
| 136 | # project source into it. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 137 | CACHED_SOURCE_DIR_NAME = "CachedSource" |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 138 | |
| 139 | # The name of the directory containing the source code that will be analyzed. |
| 140 | # Each time a project is analyzed, a fresh copy of its CachedSource directory |
| 141 | # will be copied to the PatchedSource directory and then the local patches |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 142 | # in PATCHFILE_NAME will be applied (if PATCHFILE_NAME exists). |
| 143 | PATCHED_SOURCE_DIR_NAME = "PatchedSource" |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 144 | |
| 145 | # The name of the patchfile specifying any changes that should be applied |
| 146 | # to the CachedSource before analyzing. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 147 | PATCHFILE_NAME = "changes_for_analyzer.patch" |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 148 | |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 149 | # The list of checkers used during analyzes. |
Alp Toker | d473363 | 2013-12-05 04:47:09 +0000 | [diff] [blame] | 150 | # Currently, consists of all the non-experimental checkers, plus a few alpha |
Jordan Rose | 10ad081 | 2013-04-05 17:55:07 +0000 | [diff] [blame] | 151 | # checkers we don't want to regress on. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 152 | CHECKERS = ",".join([ |
George Karpenkov | af76b4a | 2017-09-30 00:05:24 +0000 | [diff] [blame] | 153 | "alpha.unix.SimpleStream", |
| 154 | "alpha.security.taint", |
| 155 | "cplusplus.NewDeleteLeaks", |
| 156 | "core", |
| 157 | "cplusplus", |
| 158 | "deadcode", |
| 159 | "security", |
| 160 | "unix", |
| 161 | "osx", |
| 162 | "nullability" |
| 163 | ]) |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 164 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 165 | VERBOSE = 0 |
| 166 | |
| 167 | |
| 168 | class StreamToLogger: |
| 169 | def __init__(self, logger: logging.Logger, |
| 170 | log_level: int = logging.INFO): |
| 171 | self.logger = logger |
| 172 | self.log_level = log_level |
| 173 | |
| 174 | def write(self, message: str): |
| 175 | # Rstrip in order not to write an extra newline. |
| 176 | self.logger.log(self.log_level, message.rstrip()) |
| 177 | |
| 178 | def flush(self): |
| 179 | pass |
| 180 | |
| 181 | def fileno(self) -> int: |
| 182 | return 0 |
| 183 | |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 184 | |
George Karpenkov | 13d3748 | 2018-07-30 23:01:20 +0000 | [diff] [blame] | 185 | ############################################################################### |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 186 | # Test harness logic. |
George Karpenkov | 13d3748 | 2018-07-30 23:01:20 +0000 | [diff] [blame] | 187 | ############################################################################### |
Ted Kremenek | 42c1442 | 2012-08-28 20:40:02 +0000 | [diff] [blame] | 188 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 189 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 190 | def get_project_map_path(should_exist: bool = True) -> str: |
| 191 | project_map_path = os.path.join(os.path.abspath(os.curdir), |
| 192 | PROJECT_MAP_FILE) |
| 193 | |
| 194 | if should_exist and not os.path.exists(project_map_path): |
| 195 | stderr(f"Error: Cannot find the project map file {project_map_path}" |
| 196 | f"\nRunning script for the wrong directory?\n") |
| 197 | sys.exit(1) |
| 198 | |
| 199 | return project_map_path |
| 200 | |
| 201 | |
| 202 | def run_cleanup_script(directory: str, build_log_file: IO): |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 203 | """ |
| 204 | Run pre-processing script if any. |
| 205 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 206 | cwd = os.path.join(directory, PATCHED_SOURCE_DIR_NAME) |
| 207 | script_path = os.path.join(directory, CLEANUP_SCRIPT) |
| 208 | |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 209 | SATestUtils.run_script(script_path, build_log_file, cwd, |
| 210 | out=LOCAL.stdout, err=LOCAL.stderr, |
| 211 | verbose=VERBOSE) |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 212 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 213 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 214 | def download_and_patch(directory: str, build_log_file: IO): |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 215 | """ |
| 216 | Download the project and apply the local patchfile if it exists. |
| 217 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 218 | cached_source = os.path.join(directory, CACHED_SOURCE_DIR_NAME) |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 219 | |
| 220 | # If the we don't already have the cached source, run the project's |
| 221 | # download script to download it. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 222 | if not os.path.exists(cached_source): |
| 223 | download(directory, build_log_file) |
| 224 | if not os.path.exists(cached_source): |
| 225 | stderr(f"Error: '{cached_source}' not found after download.\n") |
George Karpenkov | 65839bd | 2017-10-26 01:13:22 +0000 | [diff] [blame] | 226 | exit(1) |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 227 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 228 | patched_source = os.path.join(directory, PATCHED_SOURCE_DIR_NAME) |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 229 | |
| 230 | # Remove potentially stale patched source. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 231 | if os.path.exists(patched_source): |
| 232 | shutil.rmtree(patched_source) |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 233 | |
| 234 | # Copy the cached source and apply any patches to the copy. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 235 | shutil.copytree(cached_source, patched_source, symlinks=True) |
| 236 | apply_patch(directory, build_log_file) |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 237 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 238 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 239 | def download(directory: str, build_log_file: IO): |
| 240 | """ |
| 241 | Run the script to download the project, if it exists. |
| 242 | """ |
| 243 | script_path = os.path.join(directory, DOWNLOAD_SCRIPT) |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 244 | SATestUtils.run_script(script_path, build_log_file, directory, |
| 245 | out=LOCAL.stdout, err=LOCAL.stderr, |
| 246 | verbose=VERBOSE) |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 247 | |
| 248 | |
| 249 | def apply_patch(directory: str, build_log_file: IO): |
| 250 | patchfile_path = os.path.join(directory, PATCHFILE_NAME) |
| 251 | patched_source = os.path.join(directory, PATCHED_SOURCE_DIR_NAME) |
| 252 | |
| 253 | if not os.path.exists(patchfile_path): |
| 254 | stdout(" No local patches.\n") |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 255 | return |
| 256 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 257 | stdout(" Applying patch.\n") |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 258 | try: |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 259 | check_call(f"patch -p1 < '{patchfile_path}'", |
| 260 | cwd=patched_source, |
| 261 | stderr=build_log_file, |
| 262 | stdout=build_log_file, |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 263 | shell=True) |
Devin Coughlin | 2cb767d | 2015-11-07 18:27:35 +0000 | [diff] [blame] | 264 | |
George Karpenkov | e58044d | 2017-10-27 22:39:54 +0000 | [diff] [blame] | 265 | except CalledProcessError: |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 266 | stderr(f"Error: Patch failed. " |
| 267 | f"See {build_log_file.name} for details.\n") |
George Karpenkov | e58044d | 2017-10-27 22:39:54 +0000 | [diff] [blame] | 268 | sys.exit(1) |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 269 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 270 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 271 | class ProjectInfo(NamedTuple): |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 272 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 273 | Information about a project and settings for its analysis. |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 274 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 275 | name: str |
| 276 | build_mode: int |
| 277 | override_compiler: bool = False |
| 278 | extra_analyzer_config: str = "" |
| 279 | is_reference_build: bool = False |
| 280 | strictness: int = 0 |
Anna Zaks | 4720a73 | 2011-11-05 05:20:48 +0000 | [diff] [blame] | 281 | |
Devin Coughlin | bace032 | 2015-09-14 21:22:24 +0000 | [diff] [blame] | 282 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 283 | # typing package doesn't have a separate type for Queue, but has a generic stub |
| 284 | # We still want to have a type-safe checked project queue, for this reason, |
| 285 | # we specify generic type for mypy. |
| 286 | # |
| 287 | # It is a common workaround for this situation: |
| 288 | # https://mypy.readthedocs.io/en/stable/common_issues.html#using-classes-that-are-generic-in-stubs-but-not-at-runtime |
| 289 | if TYPE_CHECKING: |
| 290 | ProjectQueue = Queue[ProjectInfo] # this is only processed by mypy |
| 291 | else: |
| 292 | ProjectQueue = Queue # this will be executed at runtime |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 293 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 294 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 295 | class RegressionTester: |
| 296 | """ |
| 297 | A component aggregating all of the project testing. |
| 298 | """ |
| 299 | def __init__(self, jobs: int, override_compiler: bool, |
| 300 | extra_analyzer_config: str, regenerate: bool, |
| 301 | strictness: bool): |
| 302 | self.jobs = jobs |
| 303 | self.override_compiler = override_compiler |
| 304 | self.extra_analyzer_config = extra_analyzer_config |
| 305 | self.regenerate = regenerate |
| 306 | self.strictness = strictness |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 307 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 308 | def test_all(self) -> bool: |
| 309 | projects_to_test: List[ProjectInfo] = [] |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 310 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 311 | with open(get_project_map_path(), "r") as map_file: |
| 312 | validate_project_file(map_file) |
| 313 | |
| 314 | # Test the projects. |
| 315 | for proj_name, proj_build_mode in get_projects(map_file): |
| 316 | projects_to_test.append( |
| 317 | ProjectInfo(proj_name, int(proj_build_mode), |
| 318 | self.override_compiler, |
| 319 | self.extra_analyzer_config, |
| 320 | self.regenerate, self.strictness)) |
| 321 | if self.jobs <= 1: |
| 322 | return self._single_threaded_test_all(projects_to_test) |
| 323 | else: |
| 324 | return self._multi_threaded_test_all(projects_to_test) |
| 325 | |
| 326 | def _single_threaded_test_all(self, |
| 327 | projects_to_test: List[ProjectInfo]) -> bool: |
| 328 | """ |
| 329 | Run all projects. |
| 330 | :return: whether tests have passed. |
| 331 | """ |
| 332 | success = True |
| 333 | for project_info in projects_to_test: |
| 334 | tester = ProjectTester(project_info) |
| 335 | success &= tester.test() |
| 336 | return success |
| 337 | |
| 338 | def _multi_threaded_test_all(self, |
| 339 | projects_to_test: List[ProjectInfo]) -> bool: |
| 340 | """ |
| 341 | Run each project in a separate thread. |
| 342 | |
| 343 | This is OK despite GIL, as testing is blocked |
| 344 | on launching external processes. |
| 345 | |
| 346 | :return: whether tests have passed. |
| 347 | """ |
| 348 | tasks_queue = ProjectQueue() |
| 349 | |
| 350 | for project_info in projects_to_test: |
| 351 | tasks_queue.put(project_info) |
| 352 | |
| 353 | results_differ = threading.Event() |
| 354 | failure_flag = threading.Event() |
| 355 | |
| 356 | for _ in range(self.jobs): |
| 357 | T = TestProjectThread(tasks_queue, results_differ, failure_flag) |
| 358 | T.start() |
| 359 | |
| 360 | # Required to handle Ctrl-C gracefully. |
| 361 | while tasks_queue.unfinished_tasks: |
| 362 | time.sleep(0.1) # Seconds. |
| 363 | if failure_flag.is_set(): |
| 364 | stderr("Test runner crashed\n") |
| 365 | sys.exit(1) |
| 366 | return not results_differ.is_set() |
| 367 | |
| 368 | |
| 369 | class ProjectTester: |
| 370 | """ |
| 371 | A component aggregating testing for one project. |
| 372 | """ |
| 373 | def __init__(self, project_info: ProjectInfo): |
| 374 | self.project_name = project_info.name |
| 375 | self.build_mode = project_info.build_mode |
| 376 | self.override_compiler = project_info.override_compiler |
| 377 | self.extra_analyzer_config = project_info.extra_analyzer_config |
| 378 | self.is_reference_build = project_info.is_reference_build |
| 379 | self.strictness = project_info.strictness |
| 380 | |
| 381 | def test(self) -> bool: |
| 382 | """ |
| 383 | Test a given project. |
| 384 | :return tests_passed: Whether tests have passed according |
| 385 | to the :param strictness: criteria. |
| 386 | """ |
| 387 | stdout(f" \n\n--- Building project {self.project_name}\n") |
| 388 | |
| 389 | start_time = time.time() |
| 390 | |
| 391 | project_dir = self.get_project_dir() |
| 392 | if VERBOSE == 1: |
| 393 | stdout(f" Build directory: {project_dir}.\n") |
| 394 | |
| 395 | # Set the build results directory. |
| 396 | output_dir = self.get_output_dir() |
| 397 | output_dir = os.path.join(project_dir, output_dir) |
| 398 | |
| 399 | self.build(project_dir, output_dir) |
| 400 | check_build(output_dir) |
| 401 | |
| 402 | if self.is_reference_build: |
| 403 | cleanup_reference_results(output_dir) |
| 404 | passed = True |
| 405 | else: |
| 406 | passed = run_cmp_results(project_dir, self.strictness) |
| 407 | |
| 408 | stdout(f"Completed tests for project {self.project_name} " |
| 409 | f"(time: {time.time() - start_time:.2f}).\n") |
| 410 | |
| 411 | return passed |
| 412 | |
| 413 | def get_project_dir(self) -> str: |
| 414 | return os.path.join(os.path.abspath(os.curdir), self.project_name) |
| 415 | |
| 416 | def get_output_dir(self) -> str: |
| 417 | if self.is_reference_build: |
| 418 | return REF_PREFIX + OUTPUT_DIR_NAME |
| 419 | else: |
| 420 | return OUTPUT_DIR_NAME |
| 421 | |
| 422 | def build(self, directory: str, output_dir: str): |
| 423 | time_start = time.time() |
| 424 | |
| 425 | build_log_path = get_build_log_path(output_dir) |
| 426 | |
| 427 | stdout(f"Log file: {build_log_path}\n") |
| 428 | stdout(f"Output directory: {output_dir}\n") |
| 429 | |
| 430 | remove_log_file(output_dir) |
| 431 | |
| 432 | # Clean up scan build results. |
| 433 | if os.path.exists(output_dir): |
| 434 | if VERBOSE == 1: |
| 435 | stdout(f" Removing old results: {output_dir}\n") |
| 436 | |
| 437 | shutil.rmtree(output_dir) |
| 438 | |
| 439 | assert(not os.path.exists(output_dir)) |
| 440 | os.makedirs(os.path.join(output_dir, LOG_DIR_NAME)) |
| 441 | |
| 442 | # Build and analyze the project. |
| 443 | with open(build_log_path, "w+") as build_log_file: |
| 444 | if self.build_mode == 1: |
| 445 | download_and_patch(directory, build_log_file) |
| 446 | run_cleanup_script(directory, build_log_file) |
| 447 | self.scan_build(directory, output_dir, build_log_file) |
| 448 | else: |
| 449 | self.analyze_preprocessed(directory, output_dir) |
| 450 | |
| 451 | if self.is_reference_build: |
| 452 | run_cleanup_script(directory, build_log_file) |
| 453 | normalize_reference_results(directory, output_dir, |
| 454 | self.build_mode) |
| 455 | |
| 456 | stdout(f"Build complete (time: {time.time() - time_start:.2f}). " |
| 457 | f"See the log for more details: {build_log_path}\n") |
| 458 | |
| 459 | def scan_build(self, directory: str, output_dir: str, build_log_file: IO): |
| 460 | """ |
| 461 | Build the project with scan-build by reading in the commands and |
| 462 | prefixing them with the scan-build options. |
| 463 | """ |
| 464 | build_script_path = os.path.join(directory, BUILD_SCRIPT) |
| 465 | if not os.path.exists(build_script_path): |
| 466 | stderr(f"Error: build script is not defined: " |
| 467 | f"{build_script_path}\n") |
| 468 | sys.exit(1) |
| 469 | |
| 470 | all_checkers = CHECKERS |
| 471 | if 'SA_ADDITIONAL_CHECKERS' in os.environ: |
| 472 | all_checkers = (all_checkers + ',' + |
| 473 | os.environ['SA_ADDITIONAL_CHECKERS']) |
| 474 | |
| 475 | # Run scan-build from within the patched source directory. |
| 476 | cwd = os.path.join(directory, PATCHED_SOURCE_DIR_NAME) |
| 477 | |
| 478 | options = f"--use-analyzer '{CLANG}' " |
| 479 | options += f"-plist-html -o '{output_dir}' " |
| 480 | options += f"-enable-checker {all_checkers} " |
| 481 | options += "--keep-empty " |
| 482 | options += f"-analyzer-config '{self.generate_config()}' " |
| 483 | |
| 484 | if self.override_compiler: |
| 485 | options += "--override-compiler " |
| 486 | |
| 487 | extra_env: Dict[str, str] = {} |
| 488 | try: |
| 489 | command_file = open(build_script_path, "r") |
| 490 | command_prefix = "scan-build " + options + " " |
| 491 | |
| 492 | for command in command_file: |
| 493 | command = command.strip() |
| 494 | |
| 495 | if len(command) == 0: |
| 496 | continue |
| 497 | |
| 498 | # Custom analyzer invocation specified by project. |
| 499 | # Communicate required information using environment variables |
| 500 | # instead. |
| 501 | if command == NO_PREFIX_CMD: |
| 502 | command_prefix = "" |
| 503 | extra_env['OUTPUT'] = output_dir |
| 504 | extra_env['CC'] = CLANG |
| 505 | extra_env['ANALYZER_CONFIG'] = self.generate_config() |
| 506 | continue |
| 507 | |
| 508 | if command.startswith("#"): |
| 509 | continue |
| 510 | |
| 511 | # If using 'make', auto imply a -jX argument |
| 512 | # to speed up analysis. xcodebuild will |
| 513 | # automatically use the maximum number of cores. |
| 514 | if (command.startswith("make ") or command == "make") and \ |
| 515 | "-j" not in command: |
| 516 | command += f" -j{MAX_JOBS}" |
| 517 | |
| 518 | command_to_run = command_prefix + command |
| 519 | |
| 520 | if VERBOSE == 1: |
| 521 | stdout(f" Executing: {command_to_run}\n") |
| 522 | |
| 523 | check_call(command_to_run, cwd=cwd, |
| 524 | stderr=build_log_file, |
| 525 | stdout=build_log_file, |
| 526 | env=dict(os.environ, **extra_env), |
| 527 | shell=True) |
| 528 | |
| 529 | except CalledProcessError: |
| 530 | stderr("Error: scan-build failed. Its output was: \n") |
| 531 | build_log_file.seek(0) |
| 532 | shutil.copyfileobj(build_log_file, LOCAL.stderr) |
| 533 | sys.exit(1) |
| 534 | |
| 535 | def analyze_preprocessed(self, directory: str, output_dir: str): |
| 536 | """ |
| 537 | Run analysis on a set of preprocessed files. |
| 538 | """ |
| 539 | if os.path.exists(os.path.join(directory, BUILD_SCRIPT)): |
| 540 | stderr(f"Error: The preprocessed files project " |
| 541 | f"should not contain {BUILD_SCRIPT}\n") |
Anna Zaks | 4720a73 | 2011-11-05 05:20:48 +0000 | [diff] [blame] | 542 | raise Exception() |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 543 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 544 | prefix = CLANG + " --analyze " |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 545 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 546 | prefix += "--analyzer-output plist " |
| 547 | prefix += " -Xclang -analyzer-checker=" + CHECKERS |
| 548 | prefix += " -fcxx-exceptions -fblocks " |
| 549 | prefix += " -Xclang -analyzer-config " |
| 550 | prefix += f"-Xclang {self.generate_config()} " |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 551 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 552 | if self.build_mode == 2: |
| 553 | prefix += "-std=c++11 " |
Anna Zaks | 4720a73 | 2011-11-05 05:20:48 +0000 | [diff] [blame] | 554 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 555 | plist_path = os.path.join(directory, output_dir, "date") |
| 556 | fail_path = os.path.join(plist_path, "failures") |
| 557 | os.makedirs(fail_path) |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 558 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 559 | for full_file_name in glob.glob(directory + "/*"): |
| 560 | file_name = os.path.basename(full_file_name) |
| 561 | failed = False |
Devin Coughlin | 9ea8033 | 2016-01-23 01:09:07 +0000 | [diff] [blame] | 562 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 563 | # Only run the analyzes on supported files. |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 564 | if SATestUtils.has_no_extension(file_name): |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 565 | continue |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 566 | if not SATestUtils.is_valid_single_input_file(file_name): |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 567 | stderr(f"Error: Invalid single input file {full_file_name}.\n") |
| 568 | raise Exception() |
George Karpenkov | 318cd1f | 2017-10-24 23:52:46 +0000 | [diff] [blame] | 569 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 570 | # Build and call the analyzer command. |
| 571 | plist_basename = os.path.join(plist_path, file_name) |
| 572 | output_option = f"-o '{plist_basename}.plist' " |
| 573 | command = f"{prefix}{output_option}'{file_name}'" |
George Karpenkov | 318cd1f | 2017-10-24 23:52:46 +0000 | [diff] [blame] | 574 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 575 | log_path = os.path.join(fail_path, file_name + ".stderr.txt") |
| 576 | with open(log_path, "w+") as log_file: |
| 577 | try: |
| 578 | if VERBOSE == 1: |
| 579 | stdout(f" Executing: {command}\n") |
| 580 | |
| 581 | check_call(command, cwd=directory, stderr=log_file, |
| 582 | stdout=log_file, shell=True) |
| 583 | |
| 584 | except CalledProcessError as e: |
| 585 | stderr(f"Error: Analyzes of {full_file_name} failed. " |
| 586 | f"See {log_file.name} for details. " |
| 587 | f"Error code {e.returncode}.\n") |
| 588 | failed = True |
| 589 | |
| 590 | # If command did not fail, erase the log file. |
| 591 | if not failed: |
| 592 | os.remove(log_file.name) |
| 593 | |
| 594 | def generate_config(self) -> str: |
| 595 | out = "serialize-stats=true,stable-report-filename=true" |
| 596 | |
| 597 | if self.extra_analyzer_config: |
| 598 | out += "," + self.extra_analyzer_config |
| 599 | |
| 600 | return out |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 601 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 602 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 603 | class TestProjectThread(threading.Thread): |
| 604 | def __init__(self, tasks_queue: ProjectQueue, |
| 605 | results_differ: threading.Event, |
| 606 | failure_flag: threading.Event): |
| 607 | """ |
| 608 | :param results_differ: Used to signify that results differ from |
| 609 | the canonical ones. |
| 610 | :param failure_flag: Used to signify a failure during the run. |
| 611 | """ |
| 612 | self.args = args |
| 613 | self.tasks_queue = tasks_queue |
| 614 | self.results_differ = results_differ |
| 615 | self.failure_flag = failure_flag |
| 616 | super().__init__() |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 617 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 618 | # Needed to gracefully handle interrupts with Ctrl-C |
| 619 | self.daemon = True |
| 620 | |
| 621 | def run(self): |
| 622 | while not self.tasks_queue.empty(): |
| 623 | try: |
| 624 | project_info = self.tasks_queue.get() |
| 625 | |
| 626 | Logger = logging.getLogger(project_info.name) |
| 627 | LOCAL.stdout = StreamToLogger(Logger, logging.INFO) |
| 628 | LOCAL.stderr = StreamToLogger(Logger, logging.ERROR) |
| 629 | |
| 630 | tester = ProjectTester(project_info) |
| 631 | if not tester.test(): |
| 632 | self.results_differ.set() |
| 633 | |
| 634 | self.tasks_queue.task_done() |
| 635 | |
| 636 | except CalledProcessError: |
| 637 | self.failure_flag.set() |
| 638 | raise |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 639 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 640 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 641 | ############################################################################### |
| 642 | # Utility functions. |
| 643 | ############################################################################### |
George Karpenkov | 3c128cb | 2017-10-30 19:40:33 +0000 | [diff] [blame] | 644 | |
| 645 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 646 | def check_build(output_dir: str): |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 647 | """ |
| 648 | Given the scan-build output directory, checks if the build failed |
| 649 | (by searching for the failures directories). If there are failures, it |
| 650 | creates a summary file in the output directory. |
| 651 | |
| 652 | """ |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 653 | # Check if there are failures. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 654 | failures = glob.glob(output_dir + "/*/failures/*.stderr.txt") |
| 655 | total_failed = len(failures) |
| 656 | |
| 657 | if total_failed == 0: |
| 658 | clean_up_empty_plists(output_dir) |
| 659 | clean_up_empty_folders(output_dir) |
| 660 | |
| 661 | plists = glob.glob(output_dir + "/*/*.plist") |
| 662 | stdout(f"Number of bug reports " |
| 663 | f"(non-empty plist files) produced: {len(plists)}\n") |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 664 | return |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 665 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 666 | stderr("Error: analysis failed.\n") |
| 667 | stderr(f"Total of {total_failed} failures discovered.\n") |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 668 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 669 | if total_failed > NUM_OF_FAILURES_IN_SUMMARY: |
| 670 | stderr(f"See the first {NUM_OF_FAILURES_IN_SUMMARY} below.\n") |
| 671 | |
| 672 | for index, failed_log_path in enumerate(failures, start=1): |
| 673 | if index >= NUM_OF_FAILURES_IN_SUMMARY: |
George Karpenkov | ff555ce | 2017-10-26 19:00:22 +0000 | [diff] [blame] | 674 | break |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 675 | |
| 676 | stderr(f"\n-- Error #{index} -----------\n") |
| 677 | |
| 678 | with open(failed_log_path, "r") as failed_log: |
| 679 | shutil.copyfileobj(failed_log, LOCAL.stdout) |
| 680 | |
| 681 | if total_failed > NUM_OF_FAILURES_IN_SUMMARY: |
| 682 | stderr("See the results folder for more.") |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 683 | |
George Karpenkov | 65839bd | 2017-10-26 01:13:22 +0000 | [diff] [blame] | 684 | sys.exit(1) |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 685 | |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 686 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 687 | def cleanup_reference_results(output_dir: str): |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 688 | """ |
| 689 | Delete html, css, and js files from reference results. These can |
| 690 | include multiple copies of the benchmark source and so get very large. |
| 691 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 692 | extensions = ["html", "css", "js"] |
| 693 | |
| 694 | for extension in extensions: |
| 695 | for file_to_rm in glob.glob(f"{output_dir}/*/*.{extension}"): |
| 696 | file_to_rm = os.path.join(output_dir, file_to_rm) |
| 697 | os.remove(file_to_rm) |
Devin Coughlin | 9ea8033 | 2016-01-23 01:09:07 +0000 | [diff] [blame] | 698 | |
| 699 | # Remove the log file. It leaks absolute path names. |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 700 | remove_log_file(output_dir) |
Devin Coughlin | 9ea8033 | 2016-01-23 01:09:07 +0000 | [diff] [blame] | 701 | |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 702 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 703 | def run_cmp_results(directory: str, strictness: int = 0) -> bool: |
George Karpenkov | 1b51cbd | 2017-10-05 17:32:06 +0000 | [diff] [blame] | 704 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 705 | Compare the warnings produced by scan-build. |
| 706 | strictness defines the success criteria for the test: |
| 707 | 0 - success if there are no crashes or analyzer failure. |
| 708 | 1 - success if there are no difference in the number of reported bugs. |
| 709 | 2 - success if all the bug reports are identical. |
| 710 | |
| 711 | :return success: Whether tests pass according to the strictness |
| 712 | criteria. |
George Karpenkov | 1b51cbd | 2017-10-05 17:32:06 +0000 | [diff] [blame] | 713 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 714 | tests_passed = True |
| 715 | start_time = time.time() |
Anna Zaks | 4720a73 | 2011-11-05 05:20:48 +0000 | [diff] [blame] | 716 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 717 | ref_dir = os.path.join(directory, REF_PREFIX + OUTPUT_DIR_NAME) |
| 718 | new_dir = os.path.join(directory, OUTPUT_DIR_NAME) |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 719 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 720 | # We have to go one level down the directory tree. |
| 721 | ref_list = glob.glob(ref_dir + "/*") |
| 722 | new_list = glob.glob(new_dir + "/*") |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 723 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 724 | # Log folders are also located in the results dir, so ignore them. |
| 725 | ref_log_dir = os.path.join(ref_dir, LOG_DIR_NAME) |
| 726 | if ref_log_dir in ref_list: |
| 727 | ref_list.remove(ref_log_dir) |
| 728 | new_list.remove(os.path.join(new_dir, LOG_DIR_NAME)) |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 729 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 730 | if len(ref_list) != len(new_list): |
| 731 | stderr(f"Mismatch in number of results folders: " |
| 732 | f"{ref_list} vs {new_list}") |
| 733 | sys.exit(1) |
Anna Zaks | f0c4116 | 2011-10-06 23:26:27 +0000 | [diff] [blame] | 734 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 735 | # There might be more then one folder underneath - one per each scan-build |
| 736 | # command (Ex: one for configure and one for make). |
| 737 | if len(ref_list) > 1: |
| 738 | # Assume that the corresponding folders have the same names. |
| 739 | ref_list.sort() |
| 740 | new_list.sort() |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 741 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 742 | # Iterate and find the differences. |
| 743 | num_diffs = 0 |
| 744 | for ref_dir, new_dir in zip(ref_list, new_list): |
| 745 | assert(ref_dir != new_dir) |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 746 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 747 | if VERBOSE == 1: |
| 748 | stdout(f" Comparing Results: {ref_dir} {new_dir}\n") |
| 749 | |
| 750 | patched_source = os.path.join(directory, PATCHED_SOURCE_DIR_NAME) |
| 751 | |
| 752 | # TODO: get rid of option parser invocation here |
| 753 | opts, args = CmpRuns.generate_option_parser().parse_args( |
| 754 | ["--rootA", "", "--rootB", patched_source]) |
| 755 | # Scan the results, delete empty plist files. |
| 756 | num_diffs, reports_in_ref, reports_in_new = \ |
| 757 | CmpRuns.dumpScanBuildResultsDiff(ref_dir, new_dir, opts, |
| 758 | deleteEmpty=False, |
| 759 | Stdout=LOCAL.stdout) |
| 760 | |
| 761 | if num_diffs > 0: |
| 762 | stdout(f"Warning: {num_diffs} differences in diagnostics.\n") |
| 763 | |
| 764 | if strictness >= 2 and num_diffs > 0: |
| 765 | stdout("Error: Diffs found in strict mode (2).\n") |
| 766 | tests_passed = False |
| 767 | |
| 768 | elif strictness >= 1 and reports_in_ref != reports_in_new: |
| 769 | stdout("Error: The number of results are different " |
| 770 | " strict mode (1).\n") |
| 771 | tests_passed = False |
| 772 | |
| 773 | stdout(f"Diagnostic comparison complete " |
| 774 | f"(time: {time.time() - start_time:.2f}).\n") |
| 775 | |
| 776 | return tests_passed |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 777 | |
Ted Kremenek | 3a0678e | 2015-09-08 03:50:52 +0000 | [diff] [blame] | 778 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 779 | def normalize_reference_results(directory: str, output_dir: str, |
| 780 | build_mode: int): |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 781 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 782 | Make the absolute paths relative in the reference results. |
| 783 | """ |
| 784 | for dir_path, _, filenames in os.walk(output_dir): |
| 785 | for filename in filenames: |
| 786 | if not filename.endswith('plist'): |
| 787 | continue |
| 788 | |
| 789 | plist = os.path.join(dir_path, filename) |
| 790 | data = plistlib.readPlist(plist) |
| 791 | path_prefix = directory |
| 792 | |
| 793 | if build_mode == 1: |
| 794 | path_prefix = os.path.join(directory, PATCHED_SOURCE_DIR_NAME) |
| 795 | |
| 796 | paths = [source[len(path_prefix) + 1:] |
| 797 | if source.startswith(path_prefix) else source |
| 798 | for source in data['files']] |
| 799 | data['files'] = paths |
| 800 | |
| 801 | # Remove transient fields which change from run to run. |
| 802 | for diagnostic in data['diagnostics']: |
| 803 | if 'HTMLDiagnostics_files' in diagnostic: |
| 804 | diagnostic.pop('HTMLDiagnostics_files') |
| 805 | |
| 806 | if 'clang_version' in data: |
| 807 | data.pop('clang_version') |
| 808 | |
| 809 | plistlib.writePlist(data, plist) |
| 810 | |
| 811 | |
| 812 | def get_build_log_path(output_dir: str) -> str: |
| 813 | return os.path.join(output_dir, LOG_DIR_NAME, BUILD_LOG_NAME) |
| 814 | |
| 815 | |
| 816 | def remove_log_file(output_dir: str): |
| 817 | build_log_path = get_build_log_path(output_dir) |
| 818 | |
| 819 | # Clean up the log file. |
| 820 | if os.path.exists(build_log_path): |
| 821 | if VERBOSE == 1: |
| 822 | stdout(f" Removing log file: {build_log_path}\n") |
| 823 | |
| 824 | os.remove(build_log_path) |
| 825 | |
| 826 | |
| 827 | def clean_up_empty_plists(output_dir: str): |
| 828 | """ |
| 829 | A plist file is created for each call to the analyzer(each source file). |
| 830 | We are only interested on the once that have bug reports, |
| 831 | so delete the rest. |
| 832 | """ |
| 833 | for plist in glob.glob(output_dir + "/*/*.plist"): |
| 834 | plist = os.path.join(output_dir, plist) |
| 835 | |
| 836 | try: |
| 837 | data = plistlib.readPlist(plist) |
| 838 | # Delete empty reports. |
| 839 | if not data['files']: |
| 840 | os.remove(plist) |
| 841 | continue |
| 842 | |
| 843 | except plistlib.InvalidFileException as e: |
| 844 | stderr(f"Error parsing plist file {plist}: {str(e)}") |
| 845 | continue |
| 846 | |
| 847 | |
| 848 | def clean_up_empty_folders(output_dir: str): |
| 849 | """ |
| 850 | Remove empty folders from results, as git would not store them. |
| 851 | """ |
| 852 | subdirs = glob.glob(output_dir + "/*") |
| 853 | for subdir in subdirs: |
| 854 | if not os.listdir(subdir): |
| 855 | os.removedirs(subdir) |
| 856 | |
| 857 | |
| 858 | def get_projects(map_file: IO) -> Iterable[Tuple[str, str]]: |
| 859 | """ |
| 860 | Iterate over all projects defined in the project file handler `map_file` |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 861 | from the start. |
| 862 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 863 | map_file.seek(0) |
| 864 | # TODO: csv format is not very readable, change it to JSON |
| 865 | for project_info in csv.reader(map_file): |
Valeriy Savchenko | 7cebfa4 | 2020-05-22 11:59:39 +0300 | [diff] [blame^] | 866 | if SATestUtils.is_comment_csv_line(project_info): |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 867 | continue |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 868 | # suppress mypy error |
| 869 | yield cast(Tuple[str, str], project_info) |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 870 | |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 871 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 872 | def validate_project_file(map_file: IO): |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 873 | """ |
| 874 | Validate project file. |
| 875 | """ |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 876 | for project_info in get_projects(map_file): |
| 877 | if len(project_info) != 2: |
| 878 | stderr("Error: Rows in the project map file " |
| 879 | "should have 2 entries.") |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 880 | raise Exception() |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 881 | |
| 882 | if project_info[1] not in ('0', '1', '2'): |
| 883 | stderr("Error: Second entry in the project map file should be 0" |
| 884 | " (single file), 1 (project), or 2(single file c++11).") |
George Karpenkov | 3abfc3b | 2017-09-22 01:41:16 +0000 | [diff] [blame] | 885 | raise Exception() |
| 886 | |
Valeriy Savchenko | c98872e | 2020-05-14 13:31:01 +0300 | [diff] [blame] | 887 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 888 | if __name__ == "__main__": |
Gabor Horvath | 93fde94 | 2015-06-30 15:31:17 +0000 | [diff] [blame] | 889 | # Parse command line arguments. |
George Karpenkov | a807660 | 2017-10-02 17:59:12 +0000 | [diff] [blame] | 890 | Parser = argparse.ArgumentParser( |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 891 | description="Test the Clang Static Analyzer.") |
| 892 | |
| 893 | Parser.add_argument("--strictness", dest="strictness", type=int, default=0, |
| 894 | help="0 to fail on runtime errors, 1 to fail when the " |
| 895 | "number of found bugs are different from the " |
| 896 | "reference, 2 to fail on any difference from the " |
| 897 | "reference. Default is 0.") |
| 898 | Parser.add_argument("-r", dest="regenerate", action="store_true", |
| 899 | default=False, help="Regenerate reference output.") |
| 900 | Parser.add_argument("--override-compiler", action="store_true", |
| 901 | default=False, help="Call scan-build with " |
| 902 | "--override-compiler option.") |
| 903 | Parser.add_argument("-j", "--jobs", dest="jobs", type=int, |
George Karpenkov | f37d3a5 | 2018-02-08 21:22:42 +0000 | [diff] [blame] | 904 | default=0, |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 905 | help="Number of projects to test concurrently") |
| 906 | Parser.add_argument("--extra-analyzer-config", |
| 907 | dest="extra_analyzer_config", type=str, |
George Karpenkov | ac98683 | 2018-10-02 21:19:23 +0000 | [diff] [blame] | 908 | default="", |
| 909 | help="Arguments passed to to -analyzer-config") |
Gabor Horvath | 93fde94 | 2015-06-30 15:31:17 +0000 | [diff] [blame] | 910 | |
Valeriy Savchenko | 4902ca6 | 2020-05-21 18:28:36 +0300 | [diff] [blame] | 911 | args = Parser.parse_args() |
| 912 | |
| 913 | tester = RegressionTester(args.jobs, args.override_compiler, |
| 914 | args.extra_analyzer_config, args.regenerate, |
| 915 | args.strictness) |
| 916 | tests_passed = tester.test_all() |
| 917 | |
| 918 | if not tests_passed: |
| 919 | stderr("ERROR: Tests failed.") |
George Karpenkov | 65839bd | 2017-10-26 01:13:22 +0000 | [diff] [blame] | 920 | sys.exit(42) |