Ted Kremenek | 7296de9 | 2010-02-23 02:39:16 +0000 | [diff] [blame] | 1 | //=- ReachableCodePathInsensitive.cpp ---------------------------*- C++ --*-==// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file implements a flow-sensitive, path-insensitive analysis of |
| 11 | // determining reachable blocks within a CFG. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 15 | #include "clang/Analysis/Analyses/ReachableCode.h" |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 16 | #include "clang/AST/Expr.h" |
| 17 | #include "clang/AST/ExprCXX.h" |
John McCall | 31168b0 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 18 | #include "clang/AST/ExprObjC.h" |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 19 | #include "clang/AST/StmtCXX.h" |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 20 | #include "clang/Analysis/AnalysisContext.h" |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 21 | #include "clang/Analysis/CFG.h" |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 22 | #include "clang/Basic/SourceManager.h" |
Chandler Carruth | 3a02247 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 23 | #include "llvm/ADT/BitVector.h" |
| 24 | #include "llvm/ADT/SmallVector.h" |
Ted Kremenek | 7296de9 | 2010-02-23 02:39:16 +0000 | [diff] [blame] | 25 | |
| 26 | using namespace clang; |
| 27 | |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 28 | namespace { |
| 29 | class DeadCodeScan { |
| 30 | llvm::BitVector Visited; |
| 31 | llvm::BitVector &Reachable; |
Dmitri Gribenko | f857950 | 2013-01-12 19:30:44 +0000 | [diff] [blame] | 32 | SmallVector<const CFGBlock *, 10> WorkList; |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 33 | |
Dmitri Gribenko | f857950 | 2013-01-12 19:30:44 +0000 | [diff] [blame] | 34 | typedef SmallVector<std::pair<const CFGBlock *, const Stmt *>, 12> |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 35 | DeferredLocsTy; |
| 36 | |
| 37 | DeferredLocsTy DeferredLocs; |
| 38 | |
| 39 | public: |
| 40 | DeadCodeScan(llvm::BitVector &reachable) |
| 41 | : Visited(reachable.size()), |
| 42 | Reachable(reachable) {} |
| 43 | |
| 44 | void enqueue(const CFGBlock *block); |
| 45 | unsigned scanBackwards(const CFGBlock *Start, |
| 46 | clang::reachable_code::Callback &CB); |
| 47 | |
| 48 | bool isDeadCodeRoot(const CFGBlock *Block); |
| 49 | |
| 50 | const Stmt *findDeadCode(const CFGBlock *Block); |
| 51 | |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 52 | void reportDeadCode(const CFGBlock *B, |
| 53 | const Stmt *S, |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 54 | clang::reachable_code::Callback &CB); |
| 55 | }; |
| 56 | } |
| 57 | |
| 58 | void DeadCodeScan::enqueue(const CFGBlock *block) { |
| 59 | unsigned blockID = block->getBlockID(); |
| 60 | if (Reachable[blockID] || Visited[blockID]) |
| 61 | return; |
| 62 | Visited[blockID] = true; |
| 63 | WorkList.push_back(block); |
| 64 | } |
| 65 | |
| 66 | bool DeadCodeScan::isDeadCodeRoot(const clang::CFGBlock *Block) { |
| 67 | bool isDeadRoot = true; |
| 68 | |
| 69 | for (CFGBlock::const_pred_iterator I = Block->pred_begin(), |
| 70 | E = Block->pred_end(); I != E; ++I) { |
| 71 | if (const CFGBlock *PredBlock = *I) { |
| 72 | unsigned blockID = PredBlock->getBlockID(); |
| 73 | if (Visited[blockID]) { |
| 74 | isDeadRoot = false; |
| 75 | continue; |
| 76 | } |
| 77 | if (!Reachable[blockID]) { |
| 78 | isDeadRoot = false; |
| 79 | Visited[blockID] = true; |
| 80 | WorkList.push_back(PredBlock); |
| 81 | continue; |
| 82 | } |
| 83 | } |
| 84 | } |
| 85 | |
| 86 | return isDeadRoot; |
| 87 | } |
| 88 | |
| 89 | static bool isValidDeadStmt(const Stmt *S) { |
Ted Kremenek | 1b7f49c | 2011-08-25 19:28:55 +0000 | [diff] [blame] | 90 | if (S->getLocStart().isInvalid()) |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 91 | return false; |
Ted Kremenek | 1b7f49c | 2011-08-25 19:28:55 +0000 | [diff] [blame] | 92 | if (const BinaryOperator *BO = dyn_cast<BinaryOperator>(S)) |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 93 | return BO->getOpcode() != BO_Comma; |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 94 | return true; |
| 95 | } |
| 96 | |
| 97 | const Stmt *DeadCodeScan::findDeadCode(const clang::CFGBlock *Block) { |
| 98 | for (CFGBlock::const_iterator I = Block->begin(), E = Block->end(); I!=E; ++I) |
David Blaikie | 00be69a | 2013-02-23 00:29:34 +0000 | [diff] [blame] | 99 | if (Optional<CFGStmt> CS = I->getAs<CFGStmt>()) { |
| 100 | const Stmt *S = CS->getStmt(); |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 101 | if (isValidDeadStmt(S)) |
| 102 | return S; |
| 103 | } |
| 104 | |
| 105 | if (CFGTerminator T = Block->getTerminator()) { |
| 106 | const Stmt *S = T.getStmt(); |
| 107 | if (isValidDeadStmt(S)) |
| 108 | return S; |
| 109 | } |
| 110 | |
| 111 | return 0; |
| 112 | } |
| 113 | |
Benjamin Kramer | 04bf187 | 2013-09-22 14:10:29 +0000 | [diff] [blame] | 114 | static int SrcCmp(const std::pair<const CFGBlock *, const Stmt *> *p1, |
| 115 | const std::pair<const CFGBlock *, const Stmt *> *p2) { |
Benjamin Kramer | b8f33f1 | 2013-09-22 15:02:02 +0000 | [diff] [blame] | 116 | if (p1->second->getLocStart() < p2->second->getLocStart()) |
| 117 | return -1; |
| 118 | if (p2->second->getLocStart() < p1->second->getLocStart()) |
| 119 | return 1; |
| 120 | return 0; |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 121 | } |
| 122 | |
| 123 | unsigned DeadCodeScan::scanBackwards(const clang::CFGBlock *Start, |
| 124 | clang::reachable_code::Callback &CB) { |
| 125 | |
| 126 | unsigned count = 0; |
| 127 | enqueue(Start); |
| 128 | |
| 129 | while (!WorkList.empty()) { |
| 130 | const CFGBlock *Block = WorkList.pop_back_val(); |
| 131 | |
| 132 | // It is possible that this block has been marked reachable after |
| 133 | // it was enqueued. |
| 134 | if (Reachable[Block->getBlockID()]) |
| 135 | continue; |
| 136 | |
| 137 | // Look for any dead code within the block. |
| 138 | const Stmt *S = findDeadCode(Block); |
| 139 | |
| 140 | if (!S) { |
| 141 | // No dead code. Possibly an empty block. Look at dead predecessors. |
| 142 | for (CFGBlock::const_pred_iterator I = Block->pred_begin(), |
| 143 | E = Block->pred_end(); I != E; ++I) { |
| 144 | if (const CFGBlock *predBlock = *I) |
| 145 | enqueue(predBlock); |
| 146 | } |
| 147 | continue; |
| 148 | } |
Ted Kremenek | 1b7f49c | 2011-08-25 19:28:55 +0000 | [diff] [blame] | 149 | |
| 150 | // Specially handle macro-expanded code. |
| 151 | if (S->getLocStart().isMacroID()) { |
| 152 | count += clang::reachable_code::ScanReachableFromBlock(Block, Reachable); |
| 153 | continue; |
| 154 | } |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 155 | |
| 156 | if (isDeadCodeRoot(Block)) { |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 157 | reportDeadCode(Block, S, CB); |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 158 | count += clang::reachable_code::ScanReachableFromBlock(Block, Reachable); |
| 159 | } |
| 160 | else { |
| 161 | // Record this statement as the possibly best location in a |
| 162 | // strongly-connected component of dead code for emitting a |
| 163 | // warning. |
| 164 | DeferredLocs.push_back(std::make_pair(Block, S)); |
| 165 | } |
| 166 | } |
| 167 | |
| 168 | // If we didn't find a dead root, then report the dead code with the |
| 169 | // earliest location. |
| 170 | if (!DeferredLocs.empty()) { |
| 171 | llvm::array_pod_sort(DeferredLocs.begin(), DeferredLocs.end(), SrcCmp); |
| 172 | for (DeferredLocsTy::iterator I = DeferredLocs.begin(), |
| 173 | E = DeferredLocs.end(); I != E; ++I) { |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 174 | const CFGBlock *Block = I->first; |
| 175 | if (Reachable[Block->getBlockID()]) |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 176 | continue; |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 177 | reportDeadCode(Block, I->second, CB); |
| 178 | count += clang::reachable_code::ScanReachableFromBlock(Block, Reachable); |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 179 | } |
| 180 | } |
| 181 | |
| 182 | return count; |
| 183 | } |
| 184 | |
| 185 | static SourceLocation GetUnreachableLoc(const Stmt *S, |
| 186 | SourceRange &R1, |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 187 | SourceRange &R2) { |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 188 | R1 = R2 = SourceRange(); |
| 189 | |
Ted Kremenek | 8219b82 | 2010-12-16 07:46:53 +0000 | [diff] [blame] | 190 | if (const Expr *Ex = dyn_cast<Expr>(S)) |
| 191 | S = Ex->IgnoreParenImpCasts(); |
| 192 | |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 193 | switch (S->getStmtClass()) { |
| 194 | case Expr::BinaryOperatorClass: { |
| 195 | const BinaryOperator *BO = cast<BinaryOperator>(S); |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 196 | return BO->getOperatorLoc(); |
| 197 | } |
| 198 | case Expr::UnaryOperatorClass: { |
| 199 | const UnaryOperator *UO = cast<UnaryOperator>(S); |
| 200 | R1 = UO->getSubExpr()->getSourceRange(); |
| 201 | return UO->getOperatorLoc(); |
| 202 | } |
| 203 | case Expr::CompoundAssignOperatorClass: { |
| 204 | const CompoundAssignOperator *CAO = cast<CompoundAssignOperator>(S); |
| 205 | R1 = CAO->getLHS()->getSourceRange(); |
| 206 | R2 = CAO->getRHS()->getSourceRange(); |
| 207 | return CAO->getOperatorLoc(); |
| 208 | } |
John McCall | c07a0c7 | 2011-02-17 10:25:35 +0000 | [diff] [blame] | 209 | case Expr::BinaryConditionalOperatorClass: |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 210 | case Expr::ConditionalOperatorClass: { |
John McCall | c07a0c7 | 2011-02-17 10:25:35 +0000 | [diff] [blame] | 211 | const AbstractConditionalOperator *CO = |
| 212 | cast<AbstractConditionalOperator>(S); |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 213 | return CO->getQuestionLoc(); |
| 214 | } |
| 215 | case Expr::MemberExprClass: { |
| 216 | const MemberExpr *ME = cast<MemberExpr>(S); |
| 217 | R1 = ME->getSourceRange(); |
| 218 | return ME->getMemberLoc(); |
| 219 | } |
| 220 | case Expr::ArraySubscriptExprClass: { |
| 221 | const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(S); |
| 222 | R1 = ASE->getLHS()->getSourceRange(); |
| 223 | R2 = ASE->getRHS()->getSourceRange(); |
| 224 | return ASE->getRBracketLoc(); |
| 225 | } |
| 226 | case Expr::CStyleCastExprClass: { |
| 227 | const CStyleCastExpr *CSC = cast<CStyleCastExpr>(S); |
| 228 | R1 = CSC->getSubExpr()->getSourceRange(); |
| 229 | return CSC->getLParenLoc(); |
| 230 | } |
| 231 | case Expr::CXXFunctionalCastExprClass: { |
| 232 | const CXXFunctionalCastExpr *CE = cast <CXXFunctionalCastExpr>(S); |
| 233 | R1 = CE->getSubExpr()->getSourceRange(); |
Eli Friedman | 89fe0d5 | 2013-08-15 22:02:56 +0000 | [diff] [blame] | 234 | return CE->getLocStart(); |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 235 | } |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 236 | case Stmt::CXXTryStmtClass: { |
| 237 | return cast<CXXTryStmt>(S)->getHandler(0)->getCatchLoc(); |
| 238 | } |
John McCall | 31168b0 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 239 | case Expr::ObjCBridgedCastExprClass: { |
| 240 | const ObjCBridgedCastExpr *CSC = cast<ObjCBridgedCastExpr>(S); |
| 241 | R1 = CSC->getSubExpr()->getSourceRange(); |
| 242 | return CSC->getLParenLoc(); |
| 243 | } |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 244 | default: ; |
| 245 | } |
| 246 | R1 = S->getSourceRange(); |
| 247 | return S->getLocStart(); |
| 248 | } |
| 249 | |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 250 | static bool bodyEndsWithNoReturn(const CFGBlock *B) { |
| 251 | for (CFGBlock::const_reverse_iterator I = B->rbegin(), E = B->rend(); |
| 252 | I != E; ++I) { |
| 253 | if (Optional<CFGStmt> CS = I->getAs<CFGStmt>()) { |
Ted Kremenek | ec2dc73 | 2014-03-06 06:50:46 +0000 | [diff] [blame] | 254 | const Stmt *S = CS->getStmt(); |
| 255 | if (const ExprWithCleanups *EWC = dyn_cast<ExprWithCleanups>(S)) |
| 256 | S = EWC->getSubExpr(); |
| 257 | if (const CallExpr *CE = dyn_cast<CallExpr>(S)) { |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 258 | QualType CalleeType = CE->getCallee()->getType(); |
| 259 | if (getFunctionExtInfo(*CalleeType).getNoReturn()) |
| 260 | return true; |
| 261 | } |
| 262 | break; |
| 263 | } |
| 264 | } |
| 265 | return false; |
| 266 | } |
| 267 | |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 268 | static bool bodyEndsWithNoReturn(const CFGBlock::AdjacentBlock &AB) { |
Ted Kremenek | eb86284 | 2014-03-04 21:41:38 +0000 | [diff] [blame] | 269 | // If the predecessor is a normal CFG edge, then by definition |
| 270 | // the predecessor did not end with a 'noreturn'. |
| 271 | if (AB.getReachableBlock()) |
| 272 | return false; |
| 273 | |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 274 | const CFGBlock *Pred = AB.getPossiblyUnreachableBlock(); |
| 275 | assert(!AB.isReachable() && Pred); |
| 276 | return bodyEndsWithNoReturn(Pred); |
| 277 | } |
| 278 | |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 279 | static bool isBreakPrecededByNoReturn(const CFGBlock *B, |
| 280 | const Stmt *S) { |
| 281 | if (!isa<BreakStmt>(S) || B->pred_empty()) |
| 282 | return false; |
| 283 | |
| 284 | assert(B->empty()); |
| 285 | assert(B->pred_size() == 1); |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 286 | return bodyEndsWithNoReturn(*B->pred_begin()); |
| 287 | } |
| 288 | |
| 289 | static bool isEnumConstant(const Expr *Ex) { |
| 290 | const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Ex); |
| 291 | if (!DR) |
| 292 | return false; |
| 293 | return isa<EnumConstantDecl>(DR->getDecl()); |
| 294 | } |
| 295 | |
Ted Kremenek | ec2dc73 | 2014-03-06 06:50:46 +0000 | [diff] [blame] | 296 | static const Expr *stripStdStringCtor(const Expr *Ex) { |
| 297 | // Go crazy pattern matching an implicit construction of std::string(""). |
| 298 | const ExprWithCleanups *EWC = dyn_cast<ExprWithCleanups>(Ex); |
| 299 | if (!EWC) |
| 300 | return 0; |
| 301 | const CXXConstructExpr *CCE = dyn_cast<CXXConstructExpr>(EWC->getSubExpr()); |
| 302 | if (!CCE) |
| 303 | return 0; |
| 304 | QualType Ty = CCE->getType(); |
| 305 | if (const ElaboratedType *ET = dyn_cast<ElaboratedType>(Ty)) |
| 306 | Ty = ET->getNamedType(); |
| 307 | const TypedefType *TT = dyn_cast<TypedefType>(Ty); |
| 308 | StringRef Name = TT->getDecl()->getName(); |
| 309 | if (Name != "string") |
| 310 | return 0; |
| 311 | if (CCE->getNumArgs() != 1) |
| 312 | return 0; |
| 313 | const MaterializeTemporaryExpr *MTE = |
| 314 | dyn_cast<MaterializeTemporaryExpr>(CCE->getArg(0)); |
| 315 | if (!MTE) |
| 316 | return 0; |
| 317 | CXXBindTemporaryExpr *CBT = |
| 318 | dyn_cast<CXXBindTemporaryExpr>(MTE->GetTemporaryExpr()->IgnoreParenCasts()); |
| 319 | if (!CBT) |
| 320 | return 0; |
| 321 | Ex = CBT->getSubExpr()->IgnoreParenCasts(); |
| 322 | CCE = dyn_cast<CXXConstructExpr>(Ex); |
| 323 | if (!CCE) |
| 324 | return 0; |
| 325 | if (CCE->getNumArgs() != 1) |
| 326 | return 0; |
| 327 | return dyn_cast<StringLiteral>(CCE->getArg(0)->IgnoreParenCasts()); |
| 328 | } |
| 329 | |
| 330 | /// Strip away "sugar" around trivial expressions that are for the |
| 331 | /// purpose of this analysis considered uninteresting for dead code warnings. |
| 332 | static const Expr *stripExprSugar(const Expr *Ex) { |
| 333 | Ex = Ex->IgnoreParenCasts(); |
| 334 | // If 'Ex' is a constructor for a std::string, strip that |
| 335 | // away. We can only get here if the trivial expression was |
| 336 | // something like a C string literal, with the std::string |
| 337 | // just wrapping that value. |
| 338 | if (const Expr *StdStringVal = stripStdStringCtor(Ex)) |
| 339 | return StdStringVal; |
| 340 | return Ex; |
| 341 | } |
| 342 | |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 343 | static bool isTrivialExpression(const Expr *Ex) { |
Ted Kremenek | 0a69cab | 2014-03-05 23:46:07 +0000 | [diff] [blame] | 344 | Ex = Ex->IgnoreParenCasts(); |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 345 | return isa<IntegerLiteral>(Ex) || isa<StringLiteral>(Ex) || |
Ted Kremenek | c10830b | 2014-03-07 02:25:50 +0000 | [diff] [blame] | 346 | isa<CXXBoolLiteralExpr>(Ex) || isa<ObjCBoolLiteralExpr>(Ex) || |
| 347 | isa<CharacterLiteral>(Ex) || |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 348 | isEnumConstant(Ex); |
| 349 | } |
| 350 | |
Ted Kremenek | 1de2e14 | 2014-03-06 00:17:44 +0000 | [diff] [blame] | 351 | static bool isTrivialReturnOrDoWhile(const CFGBlock *B, const Stmt *S) { |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 352 | const Expr *Ex = dyn_cast<Expr>(S); |
| 353 | if (!Ex) |
| 354 | return false; |
| 355 | |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 356 | if (!isTrivialExpression(Ex)) |
| 357 | return false; |
| 358 | |
Ted Kremenek | 1de2e14 | 2014-03-06 00:17:44 +0000 | [diff] [blame] | 359 | // Check if the block ends with a do...while() and see if 'S' is the |
| 360 | // condition. |
| 361 | if (const Stmt *Term = B->getTerminator()) { |
| 362 | if (const DoStmt *DS = dyn_cast<DoStmt>(Term)) |
| 363 | if (DS->getCond() == S) |
| 364 | return true; |
| 365 | } |
| 366 | |
Ted Kremenek | 7549f0f | 2014-03-06 01:09:45 +0000 | [diff] [blame] | 367 | if (B->pred_size() != 1) |
| 368 | return false; |
Ted Kremenek | 1de2e14 | 2014-03-06 00:17:44 +0000 | [diff] [blame] | 369 | |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 370 | // Look to see if the block ends with a 'return', and see if 'S' |
| 371 | // is a substatement. The 'return' may not be the last element in |
| 372 | // the block because of destructors. |
| 373 | assert(!B->empty()); |
| 374 | for (CFGBlock::const_reverse_iterator I = B->rbegin(), E = B->rend(); |
| 375 | I != E; ++I) { |
| 376 | if (Optional<CFGStmt> CS = I->getAs<CFGStmt>()) { |
| 377 | if (const ReturnStmt *RS = dyn_cast<ReturnStmt>(CS->getStmt())) { |
| 378 | const Expr *RE = RS->getRetValue(); |
Ted Kremenek | ec2dc73 | 2014-03-06 06:50:46 +0000 | [diff] [blame] | 379 | if (RE && stripExprSugar(RE->IgnoreParenCasts()) == Ex) |
Ted Kremenek | 7549f0f | 2014-03-06 01:09:45 +0000 | [diff] [blame] | 380 | return bodyEndsWithNoReturn(*B->pred_begin()); |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 381 | } |
Ted Kremenek | 7549f0f | 2014-03-06 01:09:45 +0000 | [diff] [blame] | 382 | break; |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 383 | } |
| 384 | } |
Ted Kremenek | 0a69cab | 2014-03-05 23:46:07 +0000 | [diff] [blame] | 385 | return false; |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 386 | } |
| 387 | |
| 388 | void DeadCodeScan::reportDeadCode(const CFGBlock *B, |
| 389 | const Stmt *S, |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 390 | clang::reachable_code::Callback &CB) { |
Ted Kremenek | cc89338 | 2014-02-27 00:24:08 +0000 | [diff] [blame] | 391 | // Suppress idiomatic cases of calling a noreturn function just |
| 392 | // before executing a 'break'. If there is other code after the 'break' |
| 393 | // in the block then don't suppress the warning. |
| 394 | if (isBreakPrecededByNoReturn(B, S)) |
| 395 | return; |
| 396 | |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 397 | // Suppress trivial 'return' statements that are dead. |
Ted Kremenek | 1de2e14 | 2014-03-06 00:17:44 +0000 | [diff] [blame] | 398 | if (isTrivialReturnOrDoWhile(B, S)) |
Ted Kremenek | 5441c18 | 2014-02-27 06:32:32 +0000 | [diff] [blame] | 399 | return; |
| 400 | |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 401 | SourceRange R1, R2; |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 402 | SourceLocation Loc = GetUnreachableLoc(S, R1, R2); |
| 403 | CB.HandleUnreachable(Loc, R1, R2); |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 404 | } |
| 405 | |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 406 | namespace clang { namespace reachable_code { |
David Blaikie | 68e081d | 2011-12-20 02:48:34 +0000 | [diff] [blame] | 407 | |
| 408 | void Callback::anchor() { } |
| 409 | |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 410 | /// Returns true if the statement is expanded from a configuration macro. |
| 411 | static bool isExpandedFromConfigurationMacro(const Stmt *S) { |
| 412 | // FIXME: This is not very precise. Here we just check to see if the |
| 413 | // value comes from a macro, but we can do much better. This is likely |
| 414 | // to be over conservative. This logic is factored into a separate function |
| 415 | // so that we can refine it later. |
| 416 | SourceLocation L = S->getLocStart(); |
| 417 | return L.isMacroID(); |
| 418 | } |
| 419 | |
| 420 | /// Returns true if the statement represents a configuration value. |
| 421 | /// |
| 422 | /// A configuration value is something usually determined at compile-time |
| 423 | /// to conditionally always execute some branch. Such guards are for |
| 424 | /// "sometimes unreachable" code. Such code is usually not interesting |
| 425 | /// to report as unreachable, and may mask truly unreachable code within |
| 426 | /// those blocks. |
| 427 | static bool isConfigurationValue(const Stmt *S) { |
| 428 | if (!S) |
| 429 | return false; |
| 430 | |
| 431 | if (const Expr *Ex = dyn_cast<Expr>(S)) |
| 432 | S = Ex->IgnoreParenCasts(); |
| 433 | |
| 434 | switch (S->getStmtClass()) { |
Ted Kremenek | 01a39b6 | 2014-03-05 23:38:41 +0000 | [diff] [blame] | 435 | case Stmt::DeclRefExprClass: { |
| 436 | const DeclRefExpr *DR = cast<DeclRefExpr>(S); |
| 437 | const EnumConstantDecl *ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); |
| 438 | return ED ? isConfigurationValue(ED->getInitExpr()) : false; |
| 439 | } |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 440 | case Stmt::IntegerLiteralClass: |
| 441 | return isExpandedFromConfigurationMacro(S); |
| 442 | case Stmt::UnaryExprOrTypeTraitExprClass: |
| 443 | return true; |
| 444 | case Stmt::BinaryOperatorClass: { |
| 445 | const BinaryOperator *B = cast<BinaryOperator>(S); |
Ted Kremenek | 3cdbc39 | 2014-03-05 22:32:39 +0000 | [diff] [blame] | 446 | return (B->isLogicalOp() || B->isComparisonOp()) && |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 447 | (isConfigurationValue(B->getLHS()) || |
| 448 | isConfigurationValue(B->getRHS())); |
| 449 | } |
| 450 | case Stmt::UnaryOperatorClass: { |
| 451 | const UnaryOperator *UO = cast<UnaryOperator>(S); |
| 452 | return UO->getOpcode() == UO_LNot && |
| 453 | isConfigurationValue(UO->getSubExpr()); |
| 454 | } |
| 455 | default: |
| 456 | return false; |
| 457 | } |
| 458 | } |
| 459 | |
| 460 | /// Returns true if we should always explore all successors of a block. |
| 461 | static bool shouldTreatSuccessorsAsReachable(const CFGBlock *B) { |
Ted Kremenek | 782f003 | 2014-03-07 02:25:53 +0000 | [diff] [blame] | 462 | if (const Stmt *Term = B->getTerminator()) { |
Ted Kremenek | 6999d02 | 2014-03-06 08:09:00 +0000 | [diff] [blame] | 463 | if (isa<SwitchStmt>(Term)) |
| 464 | return true; |
Ted Kremenek | 782f003 | 2014-03-07 02:25:53 +0000 | [diff] [blame] | 465 | // Specially handle '||' and '&&'. |
| 466 | if (isa<BinaryOperator>(Term)) |
| 467 | return isConfigurationValue(Term); |
| 468 | } |
Ted Kremenek | 6999d02 | 2014-03-06 08:09:00 +0000 | [diff] [blame] | 469 | |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 470 | return isConfigurationValue(B->getTerminatorCondition()); |
| 471 | } |
| 472 | |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 473 | unsigned ScanReachableFromBlock(const CFGBlock *Start, |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 474 | llvm::BitVector &Reachable) { |
| 475 | unsigned count = 0; |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 476 | |
Nico Weber | cc2b871 | 2011-04-02 19:45:15 +0000 | [diff] [blame] | 477 | // Prep work queue |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 478 | SmallVector<const CFGBlock*, 32> WL; |
| 479 | |
| 480 | // The entry block may have already been marked reachable |
| 481 | // by the caller. |
| 482 | if (!Reachable[Start->getBlockID()]) { |
| 483 | ++count; |
| 484 | Reachable[Start->getBlockID()] = true; |
| 485 | } |
| 486 | |
| 487 | WL.push_back(Start); |
| 488 | |
Ted Kremenek | f2b0a1b | 2010-09-09 00:06:10 +0000 | [diff] [blame] | 489 | // Find the reachable blocks from 'Start'. |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 490 | while (!WL.empty()) { |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 491 | const CFGBlock *item = WL.pop_back_val(); |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 492 | |
| 493 | // There are cases where we want to treat all successors as reachable. |
| 494 | // The idea is that some "sometimes unreachable" code is not interesting, |
| 495 | // and that we should forge ahead and explore those branches anyway. |
| 496 | // This allows us to potentially uncover some "always unreachable" code |
| 497 | // within the "sometimes unreachable" code. |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 498 | // Look at the successors and mark then reachable. |
Ted Kremenek | 782f003 | 2014-03-07 02:25:53 +0000 | [diff] [blame] | 499 | Optional<bool> TreatAllSuccessorsAsReachable; |
| 500 | |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 501 | for (CFGBlock::const_succ_iterator I = item->succ_begin(), |
Ted Kremenek | 08da978 | 2014-02-27 21:56:47 +0000 | [diff] [blame] | 502 | E = item->succ_end(); I != E; ++I) { |
| 503 | const CFGBlock *B = *I; |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 504 | if (!B) do { |
| 505 | const CFGBlock *UB = I->getPossiblyUnreachableBlock(); |
| 506 | if (!UB) |
| 507 | break; |
| 508 | |
Ted Kremenek | 782f003 | 2014-03-07 02:25:53 +0000 | [diff] [blame] | 509 | if (!TreatAllSuccessorsAsReachable.hasValue()) |
| 510 | TreatAllSuccessorsAsReachable = |
| 511 | shouldTreatSuccessorsAsReachable(item); |
| 512 | |
| 513 | if (TreatAllSuccessorsAsReachable.getValue()) { |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 514 | B = UB; |
| 515 | break; |
| 516 | } |
Ted Kremenek | 08da978 | 2014-02-27 21:56:47 +0000 | [diff] [blame] | 517 | } |
Ted Kremenek | 6d9bb56 | 2014-03-05 00:01:17 +0000 | [diff] [blame] | 518 | while (false); |
| 519 | |
Ted Kremenek | 08da978 | 2014-02-27 21:56:47 +0000 | [diff] [blame] | 520 | if (B) { |
Ted Kremenek | 7296de9 | 2010-02-23 02:39:16 +0000 | [diff] [blame] | 521 | unsigned blockID = B->getBlockID(); |
| 522 | if (!Reachable[blockID]) { |
| 523 | Reachable.set(blockID); |
Ted Kremenek | 7296de9 | 2010-02-23 02:39:16 +0000 | [diff] [blame] | 524 | WL.push_back(B); |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 525 | ++count; |
Ted Kremenek | 7296de9 | 2010-02-23 02:39:16 +0000 | [diff] [blame] | 526 | } |
| 527 | } |
Ted Kremenek | 08da978 | 2014-02-27 21:56:47 +0000 | [diff] [blame] | 528 | } |
Ted Kremenek | 7296de9 | 2010-02-23 02:39:16 +0000 | [diff] [blame] | 529 | } |
| 530 | return count; |
| 531 | } |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 532 | |
Ted Kremenek | 81ce1c8 | 2011-10-24 01:32:45 +0000 | [diff] [blame] | 533 | void FindUnreachableCode(AnalysisDeclContext &AC, Callback &CB) { |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 534 | CFG *cfg = AC.getCFG(); |
| 535 | if (!cfg) |
| 536 | return; |
| 537 | |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 538 | // Scan for reachable blocks from the entrance of the CFG. |
| 539 | // If there are no unreachable blocks, we're done. |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 540 | llvm::BitVector reachable(cfg->getNumBlockIDs()); |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 541 | unsigned numReachable = ScanReachableFromBlock(&cfg->getEntry(), reachable); |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 542 | if (numReachable == cfg->getNumBlockIDs()) |
| 543 | return; |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 544 | |
| 545 | // If there aren't explicit EH edges, we should include the 'try' dispatch |
| 546 | // blocks as roots. |
| 547 | if (!AC.getCFGBuildOptions().AddEHEdges) { |
| 548 | for (CFG::try_block_iterator I = cfg->try_blocks_begin(), |
| 549 | E = cfg->try_blocks_end() ; I != E; ++I) { |
| 550 | numReachable += ScanReachableFromBlock(*I, reachable); |
| 551 | } |
| 552 | if (numReachable == cfg->getNumBlockIDs()) |
| 553 | return; |
| 554 | } |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 555 | |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 556 | // There are some unreachable blocks. We need to find the root blocks that |
| 557 | // contain code that should be considered unreachable. |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 558 | for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) { |
Ted Kremenek | bd91371 | 2011-08-23 23:05:11 +0000 | [diff] [blame] | 559 | const CFGBlock *block = *I; |
| 560 | // A block may have been marked reachable during this loop. |
| 561 | if (reachable[block->getBlockID()]) |
| 562 | continue; |
| 563 | |
| 564 | DeadCodeScan DS(reachable); |
| 565 | numReachable += DS.scanBackwards(block, CB); |
| 566 | |
| 567 | if (numReachable == cfg->getNumBlockIDs()) |
| 568 | return; |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 569 | } |
Ted Kremenek | 552eeaa | 2010-02-23 05:59:20 +0000 | [diff] [blame] | 570 | } |
| 571 | |
| 572 | }} // end namespace clang::reachable_code |