blob: 739fe045835a67ecdd7a34b07b2c10caa13205ad [file] [log] [blame]
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00001#!/usr/bin/env python2.7
2
Sanjay Patelcae64a02017-06-12 17:44:30 +00003"""A script to generate FileCheck statements for 'opt' regression tests.
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00004
Sanjay Patelcae64a02017-06-12 17:44:30 +00005This script is a utility to update LLVM opt test cases with new
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00006FileCheck patterns. It can either update all of the tests in the file or
7a single test function.
Sanjay Patel40641582016-04-05 18:00:47 +00008
9Example usage:
Sanjay Patelcae64a02017-06-12 17:44:30 +000010$ update_test_checks.py --opt=../bin/opt test/foo.ll
Sanjay Patel40641582016-04-05 18:00:47 +000011
12Workflow:
131. Make a compiler patch that requires updating some number of FileCheck lines
14 in regression test files.
152. Save the patch and revert it from your local work area.
163. Update the RUN-lines in the affected regression tests to look canonical.
17 Example: "; RUN: opt < %s -instcombine -S | FileCheck %s"
184. Refresh the FileCheck lines for either the entire file or select functions by
19 running this script.
205. Commit the fresh baseline of checks.
216. Apply your patch from step 1 and rebuild your local binaries.
227. Re-run this script on affected regression tests.
238. Check the diffs to ensure the script has done something reasonable.
249. Submit a patch including the regression test diffs for review.
25
26A common pattern is to have the script insert complete checking of every
27instruction. Then, edit it down to only check the relevant instructions.
28The script is designed to make adding checks to a test case fast, it is *not*
29designed to be authoratitive about what constitutes a good test!
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000030"""
31
32import argparse
33import itertools
34import os # Used to advertise this file's name ("autogenerated_note").
35import string
36import subprocess
37import sys
38import tempfile
39import re
40
Fangrui Songee4e2e72018-01-30 00:40:05 +000041from UpdateTestChecks import common
42
Sanjay Patel16be4df92016-04-05 19:50:21 +000043ADVERT = '; NOTE: Assertions have been autogenerated by '
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000044
45# RegEx: this is where the magic happens.
46
Sanjay Patele54e6f52016-03-25 17:00:12 +000047IR_FUNCTION_RE = re.compile('^\s*define\s+(?:internal\s+)?[^@]*@([\w-]+)\s*\(')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000048
49
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000050
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000051
52
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000053def main():
Sanjay Patel40641582016-04-05 18:00:47 +000054 from argparse import RawTextHelpFormatter
55 parser = argparse.ArgumentParser(description=__doc__, formatter_class=RawTextHelpFormatter)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000056 parser.add_argument('-v', '--verbose', action='store_true',
57 help='Show verbose output')
Sanjay Patelcae64a02017-06-12 17:44:30 +000058 parser.add_argument('--opt-binary', default='opt',
59 help='The opt binary used to generate the test case')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000060 parser.add_argument(
61 '--function', help='The function in the test file to update')
62 parser.add_argument('tests', nargs='+')
63 args = parser.parse_args()
64
Sanjay Patel16be4df92016-04-05 19:50:21 +000065 autogenerated_note = (ADVERT + 'utils/' + os.path.basename(__file__))
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000066
Sanjay Patelcae64a02017-06-12 17:44:30 +000067 opt_basename = os.path.basename(args.opt_binary)
68 if (opt_basename != "opt"):
69 print >>sys.stderr, 'ERROR: Unexpected opt name: ' + opt_basename
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000070 sys.exit(1)
71
72 for test in args.tests:
73 if args.verbose:
74 print >>sys.stderr, 'Scanning for RUN lines in test file: %s' % (test,)
75 with open(test) as f:
76 input_lines = [l.rstrip() for l in f]
77
Bryant Wong291264b2016-12-29 19:32:34 +000078 raw_lines = [m.group(1)
Fangrui Songee4e2e72018-01-30 00:40:05 +000079 for m in [common.RUN_LINE_RE.match(l) for l in input_lines] if m]
Bryant Wong291264b2016-12-29 19:32:34 +000080 run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []
81 for l in raw_lines[1:]:
Bryant Wong507256b2016-12-29 20:05:51 +000082 if run_lines[-1].endswith("\\"):
83 run_lines[-1] = run_lines[-1].rstrip("\\") + " " + l
84 else:
85 run_lines.append(l)
Bryant Wong291264b2016-12-29 19:32:34 +000086
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000087 if args.verbose:
88 print >>sys.stderr, 'Found %d RUN lines:' % (len(run_lines),)
89 for l in run_lines:
90 print >>sys.stderr, ' RUN: ' + l
91
92 prefix_list = []
93 for l in run_lines:
94 (tool_cmd, filecheck_cmd) = tuple([cmd.strip() for cmd in l.split('|', 1)])
95
Sanjay Patelcae64a02017-06-12 17:44:30 +000096 if not tool_cmd.startswith(opt_basename + ' '):
97 print >>sys.stderr, 'WARNING: Skipping non-%s RUN line: %s' % (opt_basename, l)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000098 continue
99
100 if not filecheck_cmd.startswith('FileCheck '):
101 print >>sys.stderr, 'WARNING: Skipping non-FileChecked RUN line: ' + l
102 continue
103
Sanjay Patelcae64a02017-06-12 17:44:30 +0000104 tool_cmd_args = tool_cmd[len(opt_basename):].strip()
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000105 tool_cmd_args = tool_cmd_args.replace('< %s', '').replace('%s', '').strip()
106
Fangrui Songee4e2e72018-01-30 00:40:05 +0000107 check_prefixes = [item for m in common.CHECK_PREFIX_RE.finditer(filecheck_cmd)
Nikolai Bozhenov33ee40e2017-01-14 09:39:35 +0000108 for item in m.group(1).split(',')]
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000109 if not check_prefixes:
110 check_prefixes = ['CHECK']
111
112 # FIXME: We should use multiple check prefixes to common check lines. For
113 # now, we just ignore all but the last.
114 prefix_list.append((check_prefixes, tool_cmd_args))
115
116 func_dict = {}
117 for prefixes, _ in prefix_list:
118 for prefix in prefixes:
119 func_dict.update({prefix: dict()})
Sanjay Patelcae64a02017-06-12 17:44:30 +0000120 for prefixes, opt_args in prefix_list:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000121 if args.verbose:
Sanjay Patelcae64a02017-06-12 17:44:30 +0000122 print >>sys.stderr, 'Extracted opt cmd: ' + opt_basename + ' ' + opt_args
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000123 print >>sys.stderr, 'Extracted FileCheck prefixes: ' + str(prefixes)
124
Fangrui Songee4e2e72018-01-30 00:40:05 +0000125 raw_tool_output = common.invoke_tool(args.opt_binary, opt_args, test)
126 common.build_function_body_dictionary(
Fangrui Song4f0f4262018-02-10 05:01:33 +0000127 common.OPT_FUNCTION_RE, common.scrub_body, [],
128 raw_tool_output, prefixes, func_dict, args.verbose)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000129
130 is_in_function = False
131 is_in_function_start = False
132 prefix_set = set([prefix for prefixes, _ in prefix_list for prefix in prefixes])
133 if args.verbose:
134 print >>sys.stderr, 'Rewriting FileCheck prefixes: %s' % (prefix_set,)
135 output_lines = []
136 output_lines.append(autogenerated_note)
137
138 for input_line in input_lines:
139 if is_in_function_start:
140 if input_line == '':
141 continue
142 if input_line.lstrip().startswith(';'):
Fangrui Songee4e2e72018-01-30 00:40:05 +0000143 m = common.CHECK_RE.match(input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000144 if not m or m.group(1) not in prefix_set:
145 output_lines.append(input_line)
146 continue
147
148 # Print out the various check lines here.
Simon Pilgrimabba0482018-04-05 09:30:42 +0000149 common.add_ir_checks(output_lines, ';', prefix_list, func_dict, func_name)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000150 is_in_function_start = False
151
152 if is_in_function:
Fangrui Songee4e2e72018-01-30 00:40:05 +0000153 if common.should_add_line_to_output(input_line, prefix_set):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000154 # This input line of the function body will go as-is into the output.
Sanjay Pateld8592712016-03-27 20:43:02 +0000155 # Except make leading whitespace uniform: 2 spaces.
Fangrui Songee4e2e72018-01-30 00:40:05 +0000156 input_line = common.SCRUB_LEADING_WHITESPACE_RE.sub(r' ', input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000157 output_lines.append(input_line)
158 else:
159 continue
160 if input_line.strip() == '}':
161 is_in_function = False
162 continue
163
Sanjay Patel16be4df92016-04-05 19:50:21 +0000164 # Discard any previous script advertising.
165 if input_line.startswith(ADVERT):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000166 continue
167
168 # If it's outside a function, it just gets copied to the output.
169 output_lines.append(input_line)
170
171 m = IR_FUNCTION_RE.match(input_line)
172 if not m:
173 continue
Fangrui Songee4e2e72018-01-30 00:40:05 +0000174 func_name = m.group(1)
175 if args.function is not None and func_name != args.function:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000176 # When filtering on a specific function, skip all others.
177 continue
178 is_in_function = is_in_function_start = True
179
180 if args.verbose:
181 print>>sys.stderr, 'Writing %d lines to %s...' % (len(output_lines), test)
182
183 with open(test, 'wb') as f:
184 f.writelines([l + '\n' for l in output_lines])
185
186
187if __name__ == '__main__':
188 main()