Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 1 | //===-- CodeCompleteTests.cpp -----------------------------------*- C++ -*-===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
Eric Liu | 6f648df | 2017-12-19 16:50:37 +0000 | [diff] [blame] | 9 | |
Sam McCall | 328cbdb | 2017-12-20 16:06:05 +0000 | [diff] [blame] | 10 | #include "Annotations.h" |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 11 | #include "ClangdServer.h" |
Sam McCall | 328cbdb | 2017-12-20 16:06:05 +0000 | [diff] [blame] | 12 | #include "CodeComplete.h" |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 13 | #include "Compiler.h" |
Ilya Biryukov | 5a85b8e | 2017-12-13 12:53:16 +0000 | [diff] [blame] | 14 | #include "Matchers.h" |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 15 | #include "Protocol.h" |
Sam McCall | b536a2a | 2017-12-19 12:23:48 +0000 | [diff] [blame] | 16 | #include "SourceCode.h" |
Ilya Biryukov | cd5eb00 | 2018-02-12 11:37:28 +0000 | [diff] [blame] | 17 | #include "SyncAPI.h" |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 18 | #include "TestFS.h" |
Eric Liu | 6f648df | 2017-12-19 16:50:37 +0000 | [diff] [blame] | 19 | #include "index/MemIndex.h" |
Ilya Biryukov | be0eb8f | 2018-05-24 14:49:23 +0000 | [diff] [blame] | 20 | #include "llvm/Support/Error.h" |
Ilya Biryukov | 981a35d | 2018-05-28 12:11:37 +0000 | [diff] [blame] | 21 | #include "llvm/Testing/Support/Error.h" |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 22 | #include "gmock/gmock.h" |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 23 | #include "gtest/gtest.h" |
| 24 | |
| 25 | namespace clang { |
| 26 | namespace clangd { |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 27 | |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 28 | namespace { |
| 29 | using namespace llvm; |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 30 | using ::testing::AllOf; |
| 31 | using ::testing::Contains; |
Ilya Biryukov | 5a5e1ca | 2017-12-29 14:59:22 +0000 | [diff] [blame] | 32 | using ::testing::Each; |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 33 | using ::testing::ElementsAre; |
Ilya Biryukov | 71028b8 | 2018-03-12 15:28:22 +0000 | [diff] [blame] | 34 | using ::testing::Field; |
Sam McCall | c18c280 | 2018-06-15 11:06:29 +0000 | [diff] [blame^] | 35 | using ::testing::HasSubstr; |
Marc-Andre Laperle | 945b5a3 | 2018-06-05 14:01:40 +0000 | [diff] [blame] | 36 | using ::testing::IsEmpty; |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 37 | using ::testing::Not; |
Sam McCall | 3d139c5 | 2018-01-12 18:30:08 +0000 | [diff] [blame] | 38 | using ::testing::UnorderedElementsAre; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 39 | |
| 40 | class IgnoreDiagnostics : public DiagnosticsConsumer { |
Ilya Biryukov | 71028b8 | 2018-03-12 15:28:22 +0000 | [diff] [blame] | 41 | void onDiagnosticsReady(PathRef File, |
Sam McCall | a7bb0cc | 2018-03-12 23:22:35 +0000 | [diff] [blame] | 42 | std::vector<Diag> Diagnostics) override {} |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 43 | }; |
| 44 | |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 45 | // GMock helpers for matching completion items. |
| 46 | MATCHER_P(Named, Name, "") { return arg.insertText == Name; } |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 47 | MATCHER_P(Labeled, Label, "") { return arg.label == Label; } |
| 48 | MATCHER_P(Kind, K, "") { return arg.kind == K; } |
Eric Liu | 6f648df | 2017-12-19 16:50:37 +0000 | [diff] [blame] | 49 | MATCHER_P(Filter, F, "") { return arg.filterText == F; } |
Eric Liu | 76f6b44 | 2018-01-09 17:32:00 +0000 | [diff] [blame] | 50 | MATCHER_P(Doc, D, "") { return arg.documentation == D; } |
| 51 | MATCHER_P(Detail, D, "") { return arg.detail == D; } |
Eric Liu | 63f419a | 2018-05-15 15:29:32 +0000 | [diff] [blame] | 52 | MATCHER_P(InsertInclude, IncludeHeader, "") { |
| 53 | if (arg.additionalTextEdits.size() != 1) |
| 54 | return false; |
| 55 | const auto &Edit = arg.additionalTextEdits[0]; |
| 56 | if (Edit.range.start != Edit.range.end) |
| 57 | return false; |
| 58 | SmallVector<StringRef, 2> Matches; |
| 59 | llvm::Regex RE(R"(#include[ ]*(["<][^">]*[">]))"); |
| 60 | return RE.match(Edit.newText, &Matches) && Matches[1] == IncludeHeader; |
| 61 | } |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 62 | MATCHER_P(PlainText, Text, "") { |
| 63 | return arg.insertTextFormat == clangd::InsertTextFormat::PlainText && |
| 64 | arg.insertText == Text; |
| 65 | } |
| 66 | MATCHER_P(Snippet, Text, "") { |
| 67 | return arg.insertTextFormat == clangd::InsertTextFormat::Snippet && |
| 68 | arg.insertText == Text; |
| 69 | } |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 70 | MATCHER(NameContainsFilter, "") { |
Ilya Biryukov | 5a5e1ca | 2017-12-29 14:59:22 +0000 | [diff] [blame] | 71 | if (arg.filterText.empty()) |
| 72 | return true; |
| 73 | return llvm::StringRef(arg.insertText).contains(arg.filterText); |
| 74 | } |
Eric Liu | 63f419a | 2018-05-15 15:29:32 +0000 | [diff] [blame] | 75 | MATCHER(HasAdditionalEdits, "") { return !arg.additionalTextEdits.empty(); } |
| 76 | |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 77 | // Shorthand for Contains(Named(Name)). |
| 78 | Matcher<const std::vector<CompletionItem> &> Has(std::string Name) { |
| 79 | return Contains(Named(std::move(Name))); |
| 80 | } |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 81 | Matcher<const std::vector<CompletionItem> &> Has(std::string Name, |
| 82 | CompletionItemKind K) { |
| 83 | return Contains(AllOf(Named(std::move(Name)), Kind(K))); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 84 | } |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 85 | MATCHER(IsDocumented, "") { return !arg.documentation.empty(); } |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 86 | |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 87 | std::unique_ptr<SymbolIndex> memIndex(std::vector<Symbol> Symbols) { |
| 88 | SymbolSlab::Builder Slab; |
| 89 | for (const auto &Sym : Symbols) |
| 90 | Slab.insert(Sym); |
| 91 | return MemIndex::build(std::move(Slab).build()); |
| 92 | } |
| 93 | |
Eric Liu | 63f419a | 2018-05-15 15:29:32 +0000 | [diff] [blame] | 94 | CompletionList completions(ClangdServer &Server, StringRef Text, |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 95 | std::vector<Symbol> IndexSymbols = {}, |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 96 | clangd::CodeCompleteOptions Opts = {}) { |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 97 | std::unique_ptr<SymbolIndex> OverrideIndex; |
| 98 | if (!IndexSymbols.empty()) { |
| 99 | assert(!Opts.Index && "both Index and IndexSymbols given!"); |
| 100 | OverrideIndex = memIndex(std::move(IndexSymbols)); |
| 101 | Opts.Index = OverrideIndex.get(); |
| 102 | } |
| 103 | |
Sam McCall | c156806 | 2018-02-16 09:41:43 +0000 | [diff] [blame] | 104 | auto File = testPath("foo.cpp"); |
Sam McCall | 328cbdb | 2017-12-20 16:06:05 +0000 | [diff] [blame] | 105 | Annotations Test(Text); |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 106 | runAddDocument(Server, File, Test.code()); |
Sam McCall | a7bb0cc | 2018-03-12 23:22:35 +0000 | [diff] [blame] | 107 | auto CompletionList = |
| 108 | cantFail(runCodeComplete(Server, File, Test.point(), Opts)); |
Ilya Biryukov | 5a5e1ca | 2017-12-29 14:59:22 +0000 | [diff] [blame] | 109 | // Sanity-check that filterText is valid. |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 110 | EXPECT_THAT(CompletionList.items, Each(NameContainsFilter())); |
Ilya Biryukov | 5a5e1ca | 2017-12-29 14:59:22 +0000 | [diff] [blame] | 111 | return CompletionList; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 112 | } |
| 113 | |
Eric Liu | 63f419a | 2018-05-15 15:29:32 +0000 | [diff] [blame] | 114 | // Builds a server and runs code completion. |
| 115 | // If IndexSymbols is non-empty, an index will be built and passed to opts. |
| 116 | CompletionList completions(StringRef Text, |
| 117 | std::vector<Symbol> IndexSymbols = {}, |
| 118 | clangd::CodeCompleteOptions Opts = {}) { |
| 119 | MockFSProvider FS; |
| 120 | MockCompilationDatabase CDB; |
| 121 | IgnoreDiagnostics DiagConsumer; |
| 122 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
| 123 | return completions(Server, Text, std::move(IndexSymbols), std::move(Opts)); |
| 124 | } |
| 125 | |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 126 | std::string replace(StringRef Haystack, StringRef Needle, StringRef Repl) { |
| 127 | std::string Result; |
| 128 | raw_string_ostream OS(Result); |
| 129 | std::pair<StringRef, StringRef> Split; |
| 130 | for (Split = Haystack.split(Needle); !Split.second.empty(); |
| 131 | Split = Split.first.split(Needle)) |
| 132 | OS << Split.first << Repl; |
| 133 | Result += Split.first; |
| 134 | OS.flush(); |
| 135 | return Result; |
| 136 | } |
| 137 | |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 138 | // Helpers to produce fake index symbols for memIndex() or completions(). |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 139 | // USRFormat is a regex replacement string for the unqualified part of the USR. |
| 140 | Symbol sym(StringRef QName, index::SymbolKind Kind, StringRef USRFormat) { |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 141 | Symbol Sym; |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 142 | std::string USR = "c:"; // We synthesize a few simple cases of USRs by hand! |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 143 | size_t Pos = QName.rfind("::"); |
| 144 | if (Pos == llvm::StringRef::npos) { |
| 145 | Sym.Name = QName; |
| 146 | Sym.Scope = ""; |
| 147 | } else { |
| 148 | Sym.Name = QName.substr(Pos + 2); |
Sam McCall | 8b2faee | 2018-01-19 22:18:21 +0000 | [diff] [blame] | 149 | Sym.Scope = QName.substr(0, Pos + 2); |
| 150 | USR += "@N@" + replace(QName.substr(0, Pos), "::", "@N@"); // ns:: -> @N@ns |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 151 | } |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 152 | USR += Regex("^.*$").sub(USRFormat, Sym.Name); // e.g. func -> @F@func# |
| 153 | Sym.ID = SymbolID(USR); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 154 | Sym.CompletionPlainInsertText = Sym.Name; |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 155 | Sym.CompletionSnippetInsertText = Sym.Name; |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 156 | Sym.CompletionLabel = Sym.Name; |
| 157 | Sym.SymInfo.Kind = Kind; |
Marc-Andre Laperle | 945b5a3 | 2018-06-05 14:01:40 +0000 | [diff] [blame] | 158 | Sym.IsIndexedForCodeCompletion = true; |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 159 | return Sym; |
| 160 | } |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 161 | Symbol func(StringRef Name) { // Assumes the function has no args. |
| 162 | return sym(Name, index::SymbolKind::Function, "@F@\\0#"); // no args |
| 163 | } |
| 164 | Symbol cls(StringRef Name) { |
Eric Liu | 9b3cba7 | 2018-05-30 09:03:39 +0000 | [diff] [blame] | 165 | return sym(Name, index::SymbolKind::Class, "@S@\\0"); |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 166 | } |
| 167 | Symbol var(StringRef Name) { |
| 168 | return sym(Name, index::SymbolKind::Variable, "@\\0"); |
| 169 | } |
Sam McCall | dc8abc4 | 2018-05-03 14:53:02 +0000 | [diff] [blame] | 170 | Symbol ns(StringRef Name) { |
| 171 | return sym(Name, index::SymbolKind::Namespace, "@N@\\0"); |
| 172 | } |
| 173 | Symbol withReferences(int N, Symbol S) { |
| 174 | S.References = N; |
| 175 | return S; |
| 176 | } |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 177 | |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 178 | TEST(CompletionTest, Limit) { |
| 179 | clangd::CodeCompleteOptions Opts; |
| 180 | Opts.Limit = 2; |
| 181 | auto Results = completions(R"cpp( |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 182 | struct ClassWithMembers { |
| 183 | int AAA(); |
| 184 | int BBB(); |
| 185 | int CCC(); |
| 186 | } |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 187 | int main() { ClassWithMembers().^ } |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 188 | )cpp", |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 189 | /*IndexSymbols=*/{}, Opts); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 190 | |
| 191 | EXPECT_TRUE(Results.isIncomplete); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 192 | EXPECT_THAT(Results.items, ElementsAre(Named("AAA"), Named("BBB"))); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 193 | } |
| 194 | |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 195 | TEST(CompletionTest, Filter) { |
| 196 | std::string Body = R"cpp( |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 197 | #define MotorCar |
| 198 | int Car; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 199 | struct S { |
| 200 | int FooBar; |
| 201 | int FooBaz; |
| 202 | int Qux; |
| 203 | }; |
| 204 | )cpp"; |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 205 | |
| 206 | // Only items matching the fuzzy query are returned. |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 207 | EXPECT_THAT(completions(Body + "int main() { S().Foba^ }").items, |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 208 | AllOf(Has("FooBar"), Has("FooBaz"), Not(Has("Qux")))); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 209 | |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 210 | // Macros require prefix match. |
| 211 | EXPECT_THAT(completions(Body + "int main() { C^ }").items, |
| 212 | AllOf(Has("Car"), Not(Has("MotorCar")))); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 213 | } |
| 214 | |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 215 | void TestAfterDotCompletion(clangd::CodeCompleteOptions Opts) { |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 216 | auto Results = completions( |
| 217 | R"cpp( |
| 218 | #define MACRO X |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 219 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 220 | int global_var; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 221 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 222 | int global_func(); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 223 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 224 | struct GlobalClass {}; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 225 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 226 | struct ClassWithMembers { |
| 227 | /// Doc for method. |
| 228 | int method(); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 229 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 230 | int field; |
| 231 | private: |
| 232 | int private_field; |
| 233 | }; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 234 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 235 | int test() { |
| 236 | struct LocalClass {}; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 237 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 238 | /// Doc for local_var. |
| 239 | int local_var; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 240 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 241 | ClassWithMembers().^ |
| 242 | } |
| 243 | )cpp", |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 244 | {cls("IndexClass"), var("index_var"), func("index_func")}, Opts); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 245 | |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 246 | // Class members. The only items that must be present in after-dot |
| 247 | // completion. |
Sam McCall | 4caa851 | 2018-06-07 12:49:17 +0000 | [diff] [blame] | 248 | EXPECT_THAT(Results.items, |
| 249 | AllOf(Has(Opts.EnableSnippets ? "method()" : "method"), |
| 250 | Has("field"), Not(Has("ClassWithMembers")), |
| 251 | Not(Has("operator=")), Not(Has("~ClassWithMembers")))); |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 252 | EXPECT_IFF(Opts.IncludeIneligibleResults, Results.items, |
| 253 | Has("private_field")); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 254 | // Global items. |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 255 | EXPECT_THAT( |
| 256 | Results.items, |
| 257 | Not(AnyOf(Has("global_var"), Has("index_var"), Has("global_func"), |
| 258 | Has("global_func()"), Has("index_func"), Has("GlobalClass"), |
| 259 | Has("IndexClass"), Has("MACRO"), Has("LocalClass")))); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 260 | // There should be no code patterns (aka snippets) in after-dot |
| 261 | // completion. At least there aren't any we're aware of. |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 262 | EXPECT_THAT(Results.items, Not(Contains(Kind(CompletionItemKind::Snippet)))); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 263 | // Check documentation. |
Ilya Biryukov | 4371450 | 2018-05-16 12:32:44 +0000 | [diff] [blame] | 264 | EXPECT_IFF(Opts.IncludeComments, Results.items, Contains(IsDocumented())); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 265 | } |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 266 | |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 267 | void TestGlobalScopeCompletion(clangd::CodeCompleteOptions Opts) { |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 268 | auto Results = completions( |
| 269 | R"cpp( |
| 270 | #define MACRO X |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 271 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 272 | int global_var; |
| 273 | int global_func(); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 274 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 275 | struct GlobalClass {}; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 276 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 277 | struct ClassWithMembers { |
| 278 | /// Doc for method. |
| 279 | int method(); |
| 280 | }; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 281 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 282 | int test() { |
| 283 | struct LocalClass {}; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 284 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 285 | /// Doc for local_var. |
| 286 | int local_var; |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 287 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 288 | ^ |
| 289 | } |
| 290 | )cpp", |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 291 | {cls("IndexClass"), var("index_var"), func("index_func")}, Opts); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 292 | |
| 293 | // Class members. Should never be present in global completions. |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 294 | EXPECT_THAT(Results.items, |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 295 | Not(AnyOf(Has("method"), Has("method()"), Has("field")))); |
| 296 | // Global items. |
Sam McCall | d8169a8 | 2018-01-18 15:31:30 +0000 | [diff] [blame] | 297 | EXPECT_THAT(Results.items, |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 298 | AllOf(Has("global_var"), Has("index_var"), |
Sam McCall | d8169a8 | 2018-01-18 15:31:30 +0000 | [diff] [blame] | 299 | Has(Opts.EnableSnippets ? "global_func()" : "global_func"), |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 300 | Has("index_func" /* our fake symbol doesn't include () */), |
| 301 | Has("GlobalClass"), Has("IndexClass"))); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 302 | // A macro. |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 303 | EXPECT_IFF(Opts.IncludeMacros, Results.items, Has("MACRO")); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 304 | // Local items. Must be present always. |
Ilya Biryukov | 9b5ffc2 | 2017-12-12 12:56:46 +0000 | [diff] [blame] | 305 | EXPECT_THAT(Results.items, |
| 306 | AllOf(Has("local_var"), Has("LocalClass"), |
| 307 | Contains(Kind(CompletionItemKind::Snippet)))); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 308 | // Check documentation. |
Ilya Biryukov | 4371450 | 2018-05-16 12:32:44 +0000 | [diff] [blame] | 309 | EXPECT_IFF(Opts.IncludeComments, Results.items, Contains(IsDocumented())); |
Sam McCall | f6ae323 | 2017-12-05 20:11:29 +0000 | [diff] [blame] | 310 | } |
| 311 | |
| 312 | TEST(CompletionTest, CompletionOptions) { |
Sam McCall | 2c3849a | 2018-01-16 12:21:24 +0000 | [diff] [blame] | 313 | auto Test = [&](const clangd::CodeCompleteOptions &Opts) { |
| 314 | TestAfterDotCompletion(Opts); |
| 315 | TestGlobalScopeCompletion(Opts); |
| 316 | }; |
| 317 | // We used to test every combination of options, but that got too slow (2^N). |
| 318 | auto Flags = { |
Ilya Biryukov | 71028b8 | 2018-03-12 15:28:22 +0000 | [diff] [blame] | 319 | &clangd::CodeCompleteOptions::IncludeMacros, |
Ilya Biryukov | 4371450 | 2018-05-16 12:32:44 +0000 | [diff] [blame] | 320 | &clangd::CodeCompleteOptions::IncludeComments, |
Ilya Biryukov | 71028b8 | 2018-03-12 15:28:22 +0000 | [diff] [blame] | 321 | &clangd::CodeCompleteOptions::EnableSnippets, |
| 322 | &clangd::CodeCompleteOptions::IncludeCodePatterns, |
| 323 | &clangd::CodeCompleteOptions::IncludeIneligibleResults, |
Sam McCall | 2c3849a | 2018-01-16 12:21:24 +0000 | [diff] [blame] | 324 | }; |
| 325 | // Test default options. |
| 326 | Test({}); |
| 327 | // Test with one flag flipped. |
| 328 | for (auto &F : Flags) { |
| 329 | clangd::CodeCompleteOptions O; |
| 330 | O.*F ^= true; |
| 331 | Test(O); |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 332 | } |
| 333 | } |
| 334 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 335 | TEST(CompletionTest, Priorities) { |
| 336 | auto Internal = completions(R"cpp( |
| 337 | class Foo { |
| 338 | public: void pub(); |
| 339 | protected: void prot(); |
| 340 | private: void priv(); |
| 341 | }; |
| 342 | void Foo::pub() { this->^ } |
| 343 | )cpp"); |
| 344 | EXPECT_THAT(Internal.items, |
| 345 | HasSubsequence(Named("priv"), Named("prot"), Named("pub"))); |
| 346 | |
| 347 | auto External = completions(R"cpp( |
| 348 | class Foo { |
| 349 | public: void pub(); |
| 350 | protected: void prot(); |
| 351 | private: void priv(); |
| 352 | }; |
| 353 | void test() { |
| 354 | Foo F; |
| 355 | F.^ |
| 356 | } |
| 357 | )cpp"); |
| 358 | EXPECT_THAT(External.items, |
| 359 | AllOf(Has("pub"), Not(Has("prot")), Not(Has("priv")))); |
| 360 | } |
| 361 | |
| 362 | TEST(CompletionTest, Qualifiers) { |
| 363 | auto Results = completions(R"cpp( |
| 364 | class Foo { |
| 365 | public: int foo() const; |
| 366 | int bar() const; |
| 367 | }; |
| 368 | class Bar : public Foo { |
| 369 | int foo() const; |
| 370 | }; |
| 371 | void test() { Bar().^ } |
| 372 | )cpp"); |
| 373 | EXPECT_THAT(Results.items, HasSubsequence(Labeled("bar() const"), |
| 374 | Labeled("Foo::foo() const"))); |
| 375 | EXPECT_THAT(Results.items, Not(Contains(Labeled("foo() const")))); // private |
| 376 | } |
| 377 | |
Sam McCall | 4caa851 | 2018-06-07 12:49:17 +0000 | [diff] [blame] | 378 | TEST(CompletionTest, InjectedTypename) { |
| 379 | // These are suppressed when accessed as a member... |
| 380 | EXPECT_THAT(completions("struct X{}; void foo(){ X().^ }").items, |
| 381 | Not(Has("X"))); |
| 382 | EXPECT_THAT(completions("struct X{ void foo(){ this->^ } };").items, |
| 383 | Not(Has("X"))); |
| 384 | // ...but accessible in other, more useful cases. |
| 385 | EXPECT_THAT(completions("struct X{ void foo(){ ^ } };").items, Has("X")); |
| 386 | EXPECT_THAT(completions("struct Y{}; struct X:Y{ void foo(){ ^ } };").items, |
| 387 | Has("Y")); |
| 388 | EXPECT_THAT( |
| 389 | completions( |
| 390 | "template<class> struct Y{}; struct X:Y<int>{ void foo(){ ^ } };") |
| 391 | .items, |
| 392 | Has("Y")); |
| 393 | // This case is marginal (`using X::X` is useful), we allow it for now. |
| 394 | EXPECT_THAT(completions("struct X{}; void foo(){ X::^ }").items, Has("X")); |
| 395 | } |
| 396 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 397 | TEST(CompletionTest, Snippets) { |
| 398 | clangd::CodeCompleteOptions Opts; |
| 399 | Opts.EnableSnippets = true; |
| 400 | auto Results = completions( |
| 401 | R"cpp( |
| 402 | struct fake { |
| 403 | int a; |
| 404 | int f(int i, const float f) const; |
| 405 | }; |
| 406 | int main() { |
| 407 | fake f; |
| 408 | f.^ |
| 409 | } |
| 410 | )cpp", |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 411 | /*IndexSymbols=*/{}, Opts); |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 412 | EXPECT_THAT(Results.items, |
Eric Liu | 63696e1 | 2017-12-20 17:24:31 +0000 | [diff] [blame] | 413 | HasSubsequence(Snippet("a"), |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 414 | Snippet("f(${1:int i}, ${2:const float f})"))); |
| 415 | } |
| 416 | |
| 417 | TEST(CompletionTest, Kinds) { |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 418 | auto Results = completions( |
| 419 | R"cpp( |
| 420 | #define MACRO X |
| 421 | int variable; |
| 422 | struct Struct {}; |
| 423 | int function(); |
| 424 | int X = ^ |
| 425 | )cpp", |
| 426 | {func("indexFunction"), var("indexVariable"), cls("indexClass")}); |
| 427 | EXPECT_THAT(Results.items, |
| 428 | AllOf(Has("function", CompletionItemKind::Function), |
| 429 | Has("variable", CompletionItemKind::Variable), |
| 430 | Has("int", CompletionItemKind::Keyword), |
| 431 | Has("Struct", CompletionItemKind::Class), |
| 432 | Has("MACRO", CompletionItemKind::Text), |
| 433 | Has("indexFunction", CompletionItemKind::Function), |
| 434 | Has("indexVariable", CompletionItemKind::Variable), |
| 435 | Has("indexClass", CompletionItemKind::Class))); |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 436 | |
Sam McCall | 44fdcec2 | 2017-12-08 15:00:59 +0000 | [diff] [blame] | 437 | Results = completions("nam^"); |
| 438 | EXPECT_THAT(Results.items, Has("namespace", CompletionItemKind::Snippet)); |
| 439 | } |
| 440 | |
Sam McCall | 84652cc | 2018-01-12 16:16:09 +0000 | [diff] [blame] | 441 | TEST(CompletionTest, NoDuplicates) { |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 442 | auto Results = completions( |
| 443 | R"cpp( |
| 444 | class Adapter { |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 445 | }; |
Sam McCall | 84652cc | 2018-01-12 16:16:09 +0000 | [diff] [blame] | 446 | |
Eric Liu | 9b3cba7 | 2018-05-30 09:03:39 +0000 | [diff] [blame] | 447 | void f() { |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 448 | Adapter^ |
| 449 | } |
| 450 | )cpp", |
| 451 | {cls("Adapter")}); |
Sam McCall | 84652cc | 2018-01-12 16:16:09 +0000 | [diff] [blame] | 452 | |
| 453 | // Make sure there are no duplicate entries of 'Adapter'. |
Sam McCall | d2a9592 | 2018-01-22 21:05:00 +0000 | [diff] [blame] | 454 | EXPECT_THAT(Results.items, ElementsAre(Named("Adapter"))); |
Sam McCall | 84652cc | 2018-01-12 16:16:09 +0000 | [diff] [blame] | 455 | } |
| 456 | |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 457 | TEST(CompletionTest, ScopedNoIndex) { |
| 458 | auto Results = completions( |
| 459 | R"cpp( |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 460 | namespace fake { int BigBang, Babble, Box; }; |
| 461 | int main() { fake::ba^ } |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 462 | ")cpp"); |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 463 | // Babble is a better match than BigBang. Box doesn't match at all. |
| 464 | EXPECT_THAT(Results.items, ElementsAre(Named("Babble"), Named("BigBang"))); |
Sam McCall | 84652cc | 2018-01-12 16:16:09 +0000 | [diff] [blame] | 465 | } |
| 466 | |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 467 | TEST(CompletionTest, Scoped) { |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 468 | auto Results = completions( |
| 469 | R"cpp( |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 470 | namespace fake { int Babble, Box; }; |
| 471 | int main() { fake::ba^ } |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 472 | ")cpp", |
| 473 | {var("fake::BigBang")}); |
Sam McCall | 8b2dcc1 | 2018-06-14 13:50:30 +0000 | [diff] [blame] | 474 | EXPECT_THAT(Results.items, ElementsAre(Named("Babble"), Named("BigBang"))); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 475 | } |
| 476 | |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 477 | TEST(CompletionTest, ScopedWithFilter) { |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 478 | auto Results = completions( |
| 479 | R"cpp( |
| 480 | void f() { ns::x^ } |
| 481 | )cpp", |
| 482 | {cls("ns::XYZ"), func("ns::foo")}); |
| 483 | EXPECT_THAT(Results.items, |
| 484 | UnorderedElementsAre(AllOf(Named("XYZ"), Filter("XYZ")))); |
| 485 | } |
| 486 | |
Sam McCall | dc8abc4 | 2018-05-03 14:53:02 +0000 | [diff] [blame] | 487 | TEST(CompletionTest, ReferencesAffectRanking) { |
| 488 | auto Results = completions("int main() { abs^ }", {ns("absl"), func("abs")}); |
| 489 | EXPECT_THAT(Results.items, HasSubsequence(Named("abs"), Named("absl"))); |
| 490 | Results = completions("int main() { abs^ }", |
| 491 | {withReferences(10000, ns("absl")), func("abs")}); |
| 492 | EXPECT_THAT(Results.items, HasSubsequence(Named("absl"), Named("abs"))); |
| 493 | } |
| 494 | |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 495 | TEST(CompletionTest, GlobalQualified) { |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 496 | auto Results = completions( |
| 497 | R"cpp( |
| 498 | void f() { ::^ } |
| 499 | )cpp", |
| 500 | {cls("XYZ")}); |
| 501 | EXPECT_THAT(Results.items, AllOf(Has("XYZ", CompletionItemKind::Class), |
| 502 | Has("f", CompletionItemKind::Function))); |
| 503 | } |
| 504 | |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 505 | TEST(CompletionTest, FullyQualified) { |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 506 | auto Results = completions( |
| 507 | R"cpp( |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 508 | namespace ns { void bar(); } |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 509 | void f() { ::ns::^ } |
| 510 | )cpp", |
| 511 | {cls("ns::XYZ")}); |
Sam McCall | 545a20d | 2018-01-19 14:34:02 +0000 | [diff] [blame] | 512 | EXPECT_THAT(Results.items, AllOf(Has("XYZ", CompletionItemKind::Class), |
| 513 | Has("bar", CompletionItemKind::Function))); |
| 514 | } |
| 515 | |
| 516 | TEST(CompletionTest, SemaIndexMerge) { |
| 517 | auto Results = completions( |
| 518 | R"cpp( |
| 519 | namespace ns { int local; void both(); } |
| 520 | void f() { ::ns::^ } |
| 521 | )cpp", |
| 522 | {func("ns::both"), cls("ns::Index")}); |
| 523 | // We get results from both index and sema, with no duplicates. |
| 524 | EXPECT_THAT( |
| 525 | Results.items, |
| 526 | UnorderedElementsAre(Named("local"), Named("Index"), Named("both"))); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 527 | } |
| 528 | |
Haojian Wu | 48b4865 | 2018-01-25 09:20:09 +0000 | [diff] [blame] | 529 | TEST(CompletionTest, SemaIndexMergeWithLimit) { |
| 530 | clangd::CodeCompleteOptions Opts; |
| 531 | Opts.Limit = 1; |
| 532 | auto Results = completions( |
| 533 | R"cpp( |
| 534 | namespace ns { int local; void both(); } |
| 535 | void f() { ::ns::^ } |
| 536 | )cpp", |
| 537 | {func("ns::both"), cls("ns::Index")}, Opts); |
| 538 | EXPECT_EQ(Results.items.size(), Opts.Limit); |
| 539 | EXPECT_TRUE(Results.isIncomplete); |
| 540 | } |
| 541 | |
Eric Liu | 63f419a | 2018-05-15 15:29:32 +0000 | [diff] [blame] | 542 | TEST(CompletionTest, IncludeInsertionPreprocessorIntegrationTests) { |
| 543 | MockFSProvider FS; |
| 544 | MockCompilationDatabase CDB; |
| 545 | std::string Subdir = testPath("sub"); |
| 546 | std::string SearchDirArg = (llvm::Twine("-I") + Subdir).str(); |
| 547 | CDB.ExtraClangFlags = {SearchDirArg.c_str()}; |
| 548 | std::string BarHeader = testPath("sub/bar.h"); |
| 549 | FS.Files[BarHeader] = ""; |
| 550 | |
| 551 | IgnoreDiagnostics DiagConsumer; |
| 552 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
| 553 | Symbol::Details Scratch; |
| 554 | auto BarURI = URI::createFile(BarHeader).toString(); |
| 555 | Symbol Sym = cls("ns::X"); |
| 556 | Sym.CanonicalDeclaration.FileURI = BarURI; |
| 557 | Scratch.IncludeHeader = BarURI; |
| 558 | Sym.Detail = &Scratch; |
| 559 | // Shoten include path based on search dirctory and insert. |
| 560 | auto Results = completions(Server, |
| 561 | R"cpp( |
| 562 | int main() { ns::^ } |
| 563 | )cpp", |
| 564 | {Sym}); |
| 565 | EXPECT_THAT(Results.items, |
| 566 | ElementsAre(AllOf(Named("X"), InsertInclude("\"bar.h\"")))); |
| 567 | // Duplicate based on inclusions in preamble. |
| 568 | Results = completions(Server, |
| 569 | R"cpp( |
| 570 | #include "sub/bar.h" // not shortest, so should only match resolved. |
| 571 | int main() { ns::^ } |
| 572 | )cpp", |
| 573 | {Sym}); |
| 574 | EXPECT_THAT(Results.items, |
| 575 | ElementsAre(AllOf(Named("X"), Not(HasAdditionalEdits())))); |
| 576 | } |
| 577 | |
Eric Liu | 9b3cba7 | 2018-05-30 09:03:39 +0000 | [diff] [blame] | 578 | TEST(CompletionTest, NoIncludeInsertionWhenDeclFoundInFile) { |
| 579 | MockFSProvider FS; |
| 580 | MockCompilationDatabase CDB; |
| 581 | |
| 582 | IgnoreDiagnostics DiagConsumer; |
| 583 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
| 584 | Symbol::Details Scratch; |
| 585 | Symbol SymX = cls("ns::X"); |
| 586 | Symbol SymY = cls("ns::Y"); |
| 587 | std::string BarHeader = testPath("bar.h"); |
| 588 | auto BarURI = URI::createFile(BarHeader).toString(); |
| 589 | SymX.CanonicalDeclaration.FileURI = BarURI; |
| 590 | SymY.CanonicalDeclaration.FileURI = BarURI; |
| 591 | Scratch.IncludeHeader = "<bar>"; |
| 592 | SymX.Detail = &Scratch; |
| 593 | SymY.Detail = &Scratch; |
| 594 | // Shoten include path based on search dirctory and insert. |
| 595 | auto Results = completions(Server, |
| 596 | R"cpp( |
| 597 | namespace ns { |
| 598 | class X; |
| 599 | class Y {} |
| 600 | } |
| 601 | int main() { ns::^ } |
| 602 | )cpp", |
| 603 | {SymX, SymY}); |
| 604 | EXPECT_THAT(Results.items, |
| 605 | ElementsAre(AllOf(Named("X"), Not(HasAdditionalEdits())), |
| 606 | AllOf(Named("Y"), Not(HasAdditionalEdits())))); |
| 607 | } |
| 608 | |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 609 | TEST(CompletionTest, IndexSuppressesPreambleCompletions) { |
| 610 | MockFSProvider FS; |
| 611 | MockCompilationDatabase CDB; |
| 612 | IgnoreDiagnostics DiagConsumer; |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 613 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 614 | |
Sam McCall | c156806 | 2018-02-16 09:41:43 +0000 | [diff] [blame] | 615 | FS.Files[testPath("bar.h")] = |
Sam McCall | d5ea3e3 | 2018-01-24 17:53:32 +0000 | [diff] [blame] | 616 | R"cpp(namespace ns { struct preamble { int member; }; })cpp"; |
Sam McCall | c156806 | 2018-02-16 09:41:43 +0000 | [diff] [blame] | 617 | auto File = testPath("foo.cpp"); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 618 | Annotations Test(R"cpp( |
| 619 | #include "bar.h" |
| 620 | namespace ns { int local; } |
Sam McCall | d5ea3e3 | 2018-01-24 17:53:32 +0000 | [diff] [blame] | 621 | void f() { ns::^; } |
| 622 | void f() { ns::preamble().$2^; } |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 623 | )cpp"); |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 624 | runAddDocument(Server, File, Test.code()); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 625 | clangd::CodeCompleteOptions Opts = {}; |
| 626 | |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 627 | auto I = memIndex({var("ns::index")}); |
| 628 | Opts.Index = I.get(); |
Sam McCall | a7bb0cc | 2018-03-12 23:22:35 +0000 | [diff] [blame] | 629 | auto WithIndex = cantFail(runCodeComplete(Server, File, Test.point(), Opts)); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 630 | EXPECT_THAT(WithIndex.items, |
| 631 | UnorderedElementsAre(Named("local"), Named("index"))); |
Sam McCall | d5ea3e3 | 2018-01-24 17:53:32 +0000 | [diff] [blame] | 632 | auto ClassFromPreamble = |
Sam McCall | a7bb0cc | 2018-03-12 23:22:35 +0000 | [diff] [blame] | 633 | cantFail(runCodeComplete(Server, File, Test.point("2"), Opts)); |
Sam McCall | d5ea3e3 | 2018-01-24 17:53:32 +0000 | [diff] [blame] | 634 | EXPECT_THAT(ClassFromPreamble.items, Contains(Named("member"))); |
Sam McCall | 0bb24cd | 2018-02-13 08:59:23 +0000 | [diff] [blame] | 635 | |
| 636 | Opts.Index = nullptr; |
Sam McCall | a7bb0cc | 2018-03-12 23:22:35 +0000 | [diff] [blame] | 637 | auto WithoutIndex = |
| 638 | cantFail(runCodeComplete(Server, File, Test.point(), Opts)); |
Sam McCall | 0bb24cd | 2018-02-13 08:59:23 +0000 | [diff] [blame] | 639 | EXPECT_THAT(WithoutIndex.items, |
| 640 | UnorderedElementsAre(Named("local"), Named("preamble"))); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 641 | } |
| 642 | |
| 643 | TEST(CompletionTest, DynamicIndexMultiFile) { |
| 644 | MockFSProvider FS; |
| 645 | MockCompilationDatabase CDB; |
| 646 | IgnoreDiagnostics DiagConsumer; |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 647 | auto Opts = ClangdServer::optsForTest(); |
| 648 | Opts.BuildDynamicSymbolIndex = true; |
| 649 | ClangdServer Server(CDB, FS, DiagConsumer, Opts); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 650 | |
Eric Liu | 709bde8 | 2018-02-19 18:48:44 +0000 | [diff] [blame] | 651 | FS.Files[testPath("foo.h")] = R"cpp( |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 652 | namespace ns { class XYZ {}; void foo(int x) {} } |
Eric Liu | 709bde8 | 2018-02-19 18:48:44 +0000 | [diff] [blame] | 653 | )cpp"; |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 654 | runAddDocument(Server, testPath("foo.cpp"), R"cpp( |
Eric Liu | 709bde8 | 2018-02-19 18:48:44 +0000 | [diff] [blame] | 655 | #include "foo.h" |
Sam McCall | 0bb24cd | 2018-02-13 08:59:23 +0000 | [diff] [blame] | 656 | )cpp"); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 657 | |
Sam McCall | c156806 | 2018-02-16 09:41:43 +0000 | [diff] [blame] | 658 | auto File = testPath("bar.cpp"); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 659 | Annotations Test(R"cpp( |
| 660 | namespace ns { |
| 661 | class XXX {}; |
| 662 | /// Doooc |
| 663 | void fooooo() {} |
| 664 | } |
| 665 | void f() { ns::^ } |
| 666 | )cpp"); |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 667 | runAddDocument(Server, File, Test.code()); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 668 | |
Sam McCall | a7bb0cc | 2018-03-12 23:22:35 +0000 | [diff] [blame] | 669 | auto Results = cantFail(runCodeComplete(Server, File, Test.point(), {})); |
Sam McCall | a15c2d6 | 2018-01-18 09:27:56 +0000 | [diff] [blame] | 670 | // "XYZ" and "foo" are not included in the file being completed but are still |
| 671 | // visible through the index. |
| 672 | EXPECT_THAT(Results.items, Has("XYZ", CompletionItemKind::Class)); |
| 673 | EXPECT_THAT(Results.items, Has("foo", CompletionItemKind::Function)); |
| 674 | EXPECT_THAT(Results.items, Has("XXX", CompletionItemKind::Class)); |
| 675 | EXPECT_THAT(Results.items, Contains(AllOf(Named("fooooo"), Filter("fooooo"), |
| 676 | Kind(CompletionItemKind::Function), |
| 677 | Doc("Doooc"), Detail("void")))); |
| 678 | } |
| 679 | |
Ilya Biryukov | c22d344 | 2018-05-16 12:32:49 +0000 | [diff] [blame] | 680 | TEST(CompletionTest, Documentation) { |
| 681 | auto Results = completions( |
| 682 | R"cpp( |
| 683 | // Non-doxygen comment. |
| 684 | int foo(); |
| 685 | /// Doxygen comment. |
| 686 | /// \param int a |
| 687 | int bar(int a); |
| 688 | /* Multi-line |
| 689 | block comment |
| 690 | */ |
| 691 | int baz(); |
| 692 | |
| 693 | int x = ^ |
| 694 | )cpp"); |
| 695 | EXPECT_THAT(Results.items, |
| 696 | Contains(AllOf(Named("foo"), Doc("Non-doxygen comment.")))); |
| 697 | EXPECT_THAT( |
| 698 | Results.items, |
| 699 | Contains(AllOf(Named("bar"), Doc("Doxygen comment.\n\\param int a")))); |
| 700 | EXPECT_THAT(Results.items, |
| 701 | Contains(AllOf(Named("baz"), Doc("Multi-line\nblock comment")))); |
| 702 | } |
| 703 | |
Marc-Andre Laperle | 945b5a3 | 2018-06-05 14:01:40 +0000 | [diff] [blame] | 704 | TEST(CompletionTest, GlobalCompletionFiltering) { |
| 705 | |
| 706 | Symbol Class = cls("XYZ"); |
| 707 | Class.IsIndexedForCodeCompletion = false; |
| 708 | Symbol Func = func("XYZ::foooo"); |
| 709 | Func.IsIndexedForCodeCompletion = false; |
| 710 | |
| 711 | auto Results = completions(R"(// void f() { |
| 712 | XYZ::foooo^ |
| 713 | })", |
| 714 | {Class, Func}); |
| 715 | EXPECT_THAT(Results.items, IsEmpty()); |
| 716 | } |
| 717 | |
Haojian Wu | 58d208d | 2018-01-25 09:44:06 +0000 | [diff] [blame] | 718 | TEST(CodeCompleteTest, DisableTypoCorrection) { |
| 719 | auto Results = completions(R"cpp( |
| 720 | namespace clang { int v; } |
| 721 | void f() { clangd::^ |
| 722 | )cpp"); |
| 723 | EXPECT_TRUE(Results.items.empty()); |
| 724 | } |
| 725 | |
Ilya Biryukov | 53d6d93 | 2018-03-06 16:45:21 +0000 | [diff] [blame] | 726 | TEST(CodeCompleteTest, NoColonColonAtTheEnd) { |
| 727 | auto Results = completions(R"cpp( |
| 728 | namespace clang { } |
| 729 | void f() { |
| 730 | clan^ |
| 731 | } |
| 732 | )cpp"); |
| 733 | |
| 734 | EXPECT_THAT(Results.items, Contains(Labeled("clang"))); |
| 735 | EXPECT_THAT(Results.items, Not(Contains(Labeled("clang::")))); |
| 736 | } |
| 737 | |
Ilya Biryukov | 94da7bd | 2018-03-16 15:23:44 +0000 | [diff] [blame] | 738 | TEST(CompletionTest, BacktrackCrashes) { |
| 739 | // Sema calls code completion callbacks twice in these cases. |
| 740 | auto Results = completions(R"cpp( |
| 741 | namespace ns { |
| 742 | struct FooBarBaz {}; |
| 743 | } // namespace ns |
| 744 | |
| 745 | int foo(ns::FooBar^ |
| 746 | )cpp"); |
| 747 | |
| 748 | EXPECT_THAT(Results.items, ElementsAre(Labeled("FooBarBaz"))); |
| 749 | |
| 750 | // Check we don't crash in that case too. |
| 751 | completions(R"cpp( |
| 752 | struct FooBarBaz {}; |
| 753 | void test() { |
| 754 | if (FooBarBaz * x^) {} |
| 755 | } |
| 756 | )cpp"); |
| 757 | } |
| 758 | |
Eric Liu | 42abe41 | 2018-05-24 11:20:19 +0000 | [diff] [blame] | 759 | TEST(CompletionTest, CompleteInMacroWithStringification) { |
| 760 | auto Results = completions(R"cpp( |
| 761 | void f(const char *, int x); |
| 762 | #define F(x) f(#x, x) |
| 763 | |
| 764 | namespace ns { |
| 765 | int X; |
| 766 | int Y; |
| 767 | } // namespace ns |
| 768 | |
| 769 | int f(int input_num) { |
| 770 | F(ns::^) |
| 771 | } |
| 772 | )cpp"); |
| 773 | |
| 774 | EXPECT_THAT(Results.items, |
| 775 | UnorderedElementsAre(Named("X"), Named("Y"))); |
| 776 | } |
| 777 | |
| 778 | TEST(CompletionTest, CompleteInMacroAndNamespaceWithStringification) { |
| 779 | auto Results = completions(R"cpp( |
| 780 | void f(const char *, int x); |
| 781 | #define F(x) f(#x, x) |
| 782 | |
| 783 | namespace ns { |
| 784 | int X; |
| 785 | |
| 786 | int f(int input_num) { |
| 787 | F(^) |
| 788 | } |
| 789 | } // namespace ns |
| 790 | )cpp"); |
| 791 | |
| 792 | EXPECT_THAT(Results.items, Contains(Named("X"))); |
| 793 | } |
| 794 | |
Ilya Biryukov | 94da7bd | 2018-03-16 15:23:44 +0000 | [diff] [blame] | 795 | TEST(CompletionTest, CompleteInExcludedPPBranch) { |
| 796 | auto Results = completions(R"cpp( |
| 797 | int bar(int param_in_bar) { |
| 798 | } |
| 799 | |
| 800 | int foo(int param_in_foo) { |
| 801 | #if 0 |
| 802 | par^ |
| 803 | #endif |
| 804 | } |
| 805 | )cpp"); |
| 806 | |
| 807 | EXPECT_THAT(Results.items, Contains(Labeled("param_in_foo"))); |
| 808 | EXPECT_THAT(Results.items, Not(Contains(Labeled("param_in_bar")))); |
| 809 | } |
| 810 | |
Sam McCall | 800d437 | 2017-12-19 10:29:27 +0000 | [diff] [blame] | 811 | SignatureHelp signatures(StringRef Text) { |
| 812 | MockFSProvider FS; |
| 813 | MockCompilationDatabase CDB; |
| 814 | IgnoreDiagnostics DiagConsumer; |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 815 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
Sam McCall | c156806 | 2018-02-16 09:41:43 +0000 | [diff] [blame] | 816 | auto File = testPath("foo.cpp"); |
Sam McCall | 328cbdb | 2017-12-20 16:06:05 +0000 | [diff] [blame] | 817 | Annotations Test(Text); |
Sam McCall | 7363a2f | 2018-03-05 17:28:54 +0000 | [diff] [blame] | 818 | runAddDocument(Server, File, Test.code()); |
Sam McCall | a7bb0cc | 2018-03-12 23:22:35 +0000 | [diff] [blame] | 819 | return cantFail(runSignatureHelp(Server, File, Test.point())); |
Sam McCall | 800d437 | 2017-12-19 10:29:27 +0000 | [diff] [blame] | 820 | } |
| 821 | |
| 822 | MATCHER_P(ParamsAre, P, "") { |
| 823 | if (P.size() != arg.parameters.size()) |
| 824 | return false; |
| 825 | for (unsigned I = 0; I < P.size(); ++I) |
| 826 | if (P[I] != arg.parameters[I].label) |
| 827 | return false; |
| 828 | return true; |
| 829 | } |
| 830 | |
| 831 | Matcher<SignatureInformation> Sig(std::string Label, |
| 832 | std::vector<std::string> Params) { |
| 833 | return AllOf(Labeled(Label), ParamsAre(Params)); |
| 834 | } |
| 835 | |
| 836 | TEST(SignatureHelpTest, Overloads) { |
| 837 | auto Results = signatures(R"cpp( |
| 838 | void foo(int x, int y); |
| 839 | void foo(int x, float y); |
| 840 | void foo(float x, int y); |
| 841 | void foo(float x, float y); |
| 842 | void bar(int x, int y = 0); |
| 843 | int main() { foo(^); } |
| 844 | )cpp"); |
| 845 | EXPECT_THAT(Results.signatures, |
| 846 | UnorderedElementsAre( |
| 847 | Sig("foo(float x, float y) -> void", {"float x", "float y"}), |
| 848 | Sig("foo(float x, int y) -> void", {"float x", "int y"}), |
| 849 | Sig("foo(int x, float y) -> void", {"int x", "float y"}), |
| 850 | Sig("foo(int x, int y) -> void", {"int x", "int y"}))); |
| 851 | // We always prefer the first signature. |
| 852 | EXPECT_EQ(0, Results.activeSignature); |
| 853 | EXPECT_EQ(0, Results.activeParameter); |
| 854 | } |
| 855 | |
| 856 | TEST(SignatureHelpTest, DefaultArgs) { |
| 857 | auto Results = signatures(R"cpp( |
| 858 | void bar(int x, int y = 0); |
| 859 | void bar(float x = 0, int y = 42); |
| 860 | int main() { bar(^ |
| 861 | )cpp"); |
| 862 | EXPECT_THAT(Results.signatures, |
| 863 | UnorderedElementsAre( |
| 864 | Sig("bar(int x, int y = 0) -> void", {"int x", "int y = 0"}), |
| 865 | Sig("bar(float x = 0, int y = 42) -> void", |
| 866 | {"float x = 0", "int y = 42"}))); |
| 867 | EXPECT_EQ(0, Results.activeSignature); |
| 868 | EXPECT_EQ(0, Results.activeParameter); |
| 869 | } |
| 870 | |
| 871 | TEST(SignatureHelpTest, ActiveArg) { |
| 872 | auto Results = signatures(R"cpp( |
| 873 | int baz(int a, int b, int c); |
| 874 | int main() { baz(baz(1,2,3), ^); } |
| 875 | )cpp"); |
| 876 | EXPECT_THAT(Results.signatures, |
| 877 | ElementsAre(Sig("baz(int a, int b, int c) -> int", |
| 878 | {"int a", "int b", "int c"}))); |
| 879 | EXPECT_EQ(0, Results.activeSignature); |
| 880 | EXPECT_EQ(1, Results.activeParameter); |
| 881 | } |
| 882 | |
Haojian Wu | 061c73e | 2018-01-23 11:37:26 +0000 | [diff] [blame] | 883 | class IndexRequestCollector : public SymbolIndex { |
| 884 | public: |
| 885 | bool |
Sam McCall | d1a7a37 | 2018-01-31 13:40:48 +0000 | [diff] [blame] | 886 | fuzzyFind(const FuzzyFindRequest &Req, |
Haojian Wu | 061c73e | 2018-01-23 11:37:26 +0000 | [diff] [blame] | 887 | llvm::function_ref<void(const Symbol &)> Callback) const override { |
| 888 | Requests.push_back(Req); |
Sam McCall | ab8e393 | 2018-02-19 13:04:41 +0000 | [diff] [blame] | 889 | return true; |
Haojian Wu | 061c73e | 2018-01-23 11:37:26 +0000 | [diff] [blame] | 890 | } |
| 891 | |
Eric Liu | 9ec459f | 2018-03-14 09:48:05 +0000 | [diff] [blame] | 892 | void lookup(const LookupRequest &, |
| 893 | llvm::function_ref<void(const Symbol &)>) const override {} |
| 894 | |
Haojian Wu | 061c73e | 2018-01-23 11:37:26 +0000 | [diff] [blame] | 895 | const std::vector<FuzzyFindRequest> allRequests() const { return Requests; } |
| 896 | |
| 897 | private: |
| 898 | mutable std::vector<FuzzyFindRequest> Requests; |
| 899 | }; |
| 900 | |
| 901 | std::vector<FuzzyFindRequest> captureIndexRequests(llvm::StringRef Code) { |
| 902 | clangd::CodeCompleteOptions Opts; |
| 903 | IndexRequestCollector Requests; |
| 904 | Opts.Index = &Requests; |
| 905 | completions(Code, {}, Opts); |
| 906 | return Requests.allRequests(); |
| 907 | } |
| 908 | |
| 909 | TEST(CompletionTest, UnqualifiedIdQuery) { |
| 910 | auto Requests = captureIndexRequests(R"cpp( |
| 911 | namespace std {} |
| 912 | using namespace std; |
| 913 | namespace ns { |
| 914 | void f() { |
| 915 | vec^ |
| 916 | } |
| 917 | } |
| 918 | )cpp"); |
| 919 | |
| 920 | EXPECT_THAT(Requests, |
| 921 | ElementsAre(Field(&FuzzyFindRequest::Scopes, |
| 922 | UnorderedElementsAre("", "ns::", "std::")))); |
| 923 | } |
| 924 | |
| 925 | TEST(CompletionTest, ResolvedQualifiedIdQuery) { |
| 926 | auto Requests = captureIndexRequests(R"cpp( |
| 927 | namespace ns1 {} |
| 928 | namespace ns2 {} // ignore |
| 929 | namespace ns3 { namespace nns3 {} } |
| 930 | namespace foo { |
| 931 | using namespace ns1; |
| 932 | using namespace ns3::nns3; |
| 933 | } |
| 934 | namespace ns { |
| 935 | void f() { |
| 936 | foo::^ |
| 937 | } |
| 938 | } |
| 939 | )cpp"); |
| 940 | |
| 941 | EXPECT_THAT(Requests, |
| 942 | ElementsAre(Field( |
| 943 | &FuzzyFindRequest::Scopes, |
| 944 | UnorderedElementsAre("foo::", "ns1::", "ns3::nns3::")))); |
| 945 | } |
| 946 | |
| 947 | TEST(CompletionTest, UnresolvedQualifierIdQuery) { |
| 948 | auto Requests = captureIndexRequests(R"cpp( |
| 949 | namespace a {} |
| 950 | using namespace a; |
| 951 | namespace ns { |
| 952 | void f() { |
| 953 | bar::^ |
| 954 | } |
| 955 | } // namespace ns |
| 956 | )cpp"); |
| 957 | |
| 958 | EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, |
| 959 | UnorderedElementsAre("bar::")))); |
| 960 | } |
| 961 | |
| 962 | TEST(CompletionTest, UnresolvedNestedQualifierIdQuery) { |
| 963 | auto Requests = captureIndexRequests(R"cpp( |
| 964 | namespace a {} |
| 965 | using namespace a; |
| 966 | namespace ns { |
| 967 | void f() { |
| 968 | ::a::bar::^ |
| 969 | } |
| 970 | } // namespace ns |
| 971 | )cpp"); |
| 972 | |
| 973 | EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, |
| 974 | UnorderedElementsAre("a::bar::")))); |
| 975 | } |
| 976 | |
| 977 | TEST(CompletionTest, EmptyQualifiedQuery) { |
| 978 | auto Requests = captureIndexRequests(R"cpp( |
| 979 | namespace ns { |
| 980 | void f() { |
| 981 | ^ |
| 982 | } |
| 983 | } // namespace ns |
| 984 | )cpp"); |
| 985 | |
| 986 | EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, |
| 987 | UnorderedElementsAre("", "ns::")))); |
| 988 | } |
| 989 | |
| 990 | TEST(CompletionTest, GlobalQualifiedQuery) { |
| 991 | auto Requests = captureIndexRequests(R"cpp( |
| 992 | namespace ns { |
| 993 | void f() { |
| 994 | ::^ |
| 995 | } |
| 996 | } // namespace ns |
| 997 | )cpp"); |
| 998 | |
| 999 | EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, |
| 1000 | UnorderedElementsAre("")))); |
| 1001 | } |
| 1002 | |
Ilya Biryukov | a907ba4 | 2018-05-14 10:50:04 +0000 | [diff] [blame] | 1003 | TEST(CompletionTest, NoIndexCompletionsInsideClasses) { |
| 1004 | auto Completions = completions( |
| 1005 | R"cpp( |
| 1006 | struct Foo { |
| 1007 | int SomeNameOfField; |
| 1008 | typedef int SomeNameOfTypedefField; |
| 1009 | }; |
| 1010 | |
| 1011 | Foo::^)cpp", |
| 1012 | {func("::SomeNameInTheIndex"), func("::Foo::SomeNameInTheIndex")}); |
| 1013 | |
| 1014 | EXPECT_THAT(Completions.items, |
| 1015 | AllOf(Contains(Labeled("SomeNameOfField")), |
| 1016 | Contains(Labeled("SomeNameOfTypedefField")), |
| 1017 | Not(Contains(Labeled("SomeNameInTheIndex"))))); |
| 1018 | } |
| 1019 | |
| 1020 | TEST(CompletionTest, NoIndexCompletionsInsideDependentCode) { |
| 1021 | { |
| 1022 | auto Completions = completions( |
| 1023 | R"cpp( |
| 1024 | template <class T> |
| 1025 | void foo() { |
| 1026 | T::^ |
| 1027 | } |
| 1028 | )cpp", |
| 1029 | {func("::SomeNameInTheIndex")}); |
| 1030 | |
| 1031 | EXPECT_THAT(Completions.items, |
| 1032 | Not(Contains(Labeled("SomeNameInTheIndex")))); |
| 1033 | } |
| 1034 | |
| 1035 | { |
| 1036 | auto Completions = completions( |
| 1037 | R"cpp( |
| 1038 | template <class T> |
| 1039 | void foo() { |
| 1040 | T::template Y<int>::^ |
| 1041 | } |
| 1042 | )cpp", |
| 1043 | {func("::SomeNameInTheIndex")}); |
| 1044 | |
| 1045 | EXPECT_THAT(Completions.items, |
| 1046 | Not(Contains(Labeled("SomeNameInTheIndex")))); |
| 1047 | } |
| 1048 | |
| 1049 | { |
| 1050 | auto Completions = completions( |
| 1051 | R"cpp( |
| 1052 | template <class T> |
| 1053 | void foo() { |
| 1054 | T::foo::^ |
| 1055 | } |
| 1056 | )cpp", |
| 1057 | {func("::SomeNameInTheIndex")}); |
| 1058 | |
| 1059 | EXPECT_THAT(Completions.items, |
| 1060 | Not(Contains(Labeled("SomeNameInTheIndex")))); |
| 1061 | } |
| 1062 | } |
| 1063 | |
Sam McCall | c18c280 | 2018-06-15 11:06:29 +0000 | [diff] [blame^] | 1064 | TEST(CompletionTest, OverloadBundling) { |
| 1065 | clangd::CodeCompleteOptions Opts; |
| 1066 | Opts.BundleOverloads = true; |
| 1067 | |
| 1068 | std::string Context = R"cpp( |
| 1069 | struct X { |
| 1070 | // Overload with int |
| 1071 | int a(int); |
| 1072 | // Overload with bool |
| 1073 | int a(bool); |
| 1074 | int b(float); |
| 1075 | }; |
| 1076 | int GFuncC(int); |
| 1077 | int GFuncD(int); |
| 1078 | )cpp"; |
| 1079 | |
| 1080 | // Member completions are bundled. |
| 1081 | EXPECT_THAT(completions(Context + "int y = X().^", {}, Opts).items, |
| 1082 | UnorderedElementsAre(Labeled("a(…)"), Labeled("b(float)"))); |
| 1083 | |
| 1084 | // Non-member completions are bundled, including index+sema. |
| 1085 | Symbol NoArgsGFunc = func("GFuncC"); |
| 1086 | EXPECT_THAT( |
| 1087 | completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).items, |
| 1088 | UnorderedElementsAre(Labeled("GFuncC(…)"), Labeled("GFuncD(int)"))); |
| 1089 | |
| 1090 | // Differences in header-to-insert suppress bundling. |
| 1091 | Symbol::Details Detail; |
| 1092 | std::string DeclFile = URI::createFile(testPath("foo")).toString(); |
| 1093 | NoArgsGFunc.CanonicalDeclaration.FileURI = DeclFile; |
| 1094 | Detail.IncludeHeader = "<foo>"; |
| 1095 | NoArgsGFunc.Detail = &Detail; |
| 1096 | EXPECT_THAT( |
| 1097 | completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).items, |
| 1098 | UnorderedElementsAre(AllOf(Named("GFuncC"), InsertInclude("<foo>")), |
| 1099 | Labeled("GFuncC(int)"), Labeled("GFuncD(int)"))); |
| 1100 | |
| 1101 | // Examine a bundled completion in detail. |
| 1102 | auto A = completions(Context + "int y = X().a^", {}, Opts).items.front(); |
| 1103 | EXPECT_EQ(A.label, "a(…)"); |
| 1104 | EXPECT_EQ(A.detail, "[2 overloads]"); |
| 1105 | EXPECT_EQ(A.insertText, "a"); |
| 1106 | EXPECT_EQ(A.kind, CompletionItemKind::Method); |
| 1107 | // For now we just return one of the doc strings arbitrarily. |
| 1108 | EXPECT_THAT(A.documentation, AnyOf(HasSubstr("Overload with int"), |
| 1109 | HasSubstr("Overload with bool"))); |
| 1110 | Opts.EnableSnippets = true; |
| 1111 | A = completions(Context + "int y = X().a^", {}, Opts).items.front(); |
| 1112 | EXPECT_EQ(A.insertText, "a(${0})"); |
| 1113 | } |
| 1114 | |
Ilya Biryukov | 30b04b1 | 2018-05-28 09:54:51 +0000 | [diff] [blame] | 1115 | TEST(CompletionTest, DocumentationFromChangedFileCrash) { |
Ilya Biryukov | be0eb8f | 2018-05-24 14:49:23 +0000 | [diff] [blame] | 1116 | MockFSProvider FS; |
| 1117 | auto FooH = testPath("foo.h"); |
| 1118 | auto FooCpp = testPath("foo.cpp"); |
| 1119 | FS.Files[FooH] = R"cpp( |
| 1120 | // this is my documentation comment. |
| 1121 | int func(); |
| 1122 | )cpp"; |
| 1123 | FS.Files[FooCpp] = ""; |
| 1124 | |
| 1125 | MockCompilationDatabase CDB; |
| 1126 | IgnoreDiagnostics DiagConsumer; |
| 1127 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
| 1128 | |
| 1129 | Annotations Source(R"cpp( |
| 1130 | #include "foo.h" |
| 1131 | int func() { |
| 1132 | // This makes sure we have func from header in the AST. |
| 1133 | } |
| 1134 | int a = fun^ |
| 1135 | )cpp"); |
| 1136 | Server.addDocument(FooCpp, Source.code(), WantDiagnostics::Yes); |
| 1137 | // We need to wait for preamble to build. |
| 1138 | ASSERT_TRUE(Server.blockUntilIdleForTest()); |
| 1139 | |
| 1140 | // Change the header file. Completion will reuse the old preamble! |
| 1141 | FS.Files[FooH] = R"cpp( |
| 1142 | int func(); |
| 1143 | )cpp"; |
| 1144 | |
| 1145 | clangd::CodeCompleteOptions Opts; |
| 1146 | Opts.IncludeComments = true; |
| 1147 | CompletionList Completions = |
| 1148 | cantFail(runCodeComplete(Server, FooCpp, Source.point(), Opts)); |
| 1149 | // We shouldn't crash. Unfortunately, current workaround is to not produce |
| 1150 | // comments for symbols from headers. |
| 1151 | EXPECT_THAT(Completions.items, |
| 1152 | Contains(AllOf(Not(IsDocumented()), Named("func")))); |
| 1153 | } |
| 1154 | |
Ilya Biryukov | 89fcf6b | 2018-06-15 08:31:17 +0000 | [diff] [blame] | 1155 | TEST(CompletionTest, NonDocComments) { |
| 1156 | MockFSProvider FS; |
| 1157 | auto FooCpp = testPath("foo.cpp"); |
| 1158 | FS.Files[FooCpp] = ""; |
| 1159 | |
| 1160 | MockCompilationDatabase CDB; |
| 1161 | IgnoreDiagnostics DiagConsumer; |
| 1162 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
| 1163 | |
| 1164 | Annotations Source(R"cpp( |
| 1165 | // ------------------ |
| 1166 | int comments_foo(); |
| 1167 | |
| 1168 | // A comment and a decl are separated by newlines. |
| 1169 | // Therefore, the comment shouldn't show up as doc comment. |
| 1170 | |
| 1171 | int comments_bar(); |
| 1172 | |
| 1173 | // this comment should be in the results. |
| 1174 | int comments_baz(); |
| 1175 | |
| 1176 | |
| 1177 | template <class T> |
| 1178 | struct Struct { |
| 1179 | int comments_qux(); |
| 1180 | int comments_quux(); |
| 1181 | }; |
| 1182 | |
| 1183 | |
| 1184 | // This comment should not be there. |
| 1185 | |
| 1186 | template <class T> |
| 1187 | int Struct<T>::comments_qux() { |
| 1188 | } |
| 1189 | |
| 1190 | // This comment **should** be in results. |
| 1191 | template <class T> |
| 1192 | int Struct<T>::comments_quux() { |
| 1193 | int a = comments^; |
| 1194 | } |
| 1195 | )cpp"); |
| 1196 | Server.addDocument(FooCpp, Source.code(), WantDiagnostics::Yes); |
| 1197 | CompletionList Completions = cantFail(runCodeComplete( |
| 1198 | Server, FooCpp, Source.point(), clangd::CodeCompleteOptions())); |
| 1199 | |
| 1200 | // We should not get any of those comments in completion. |
| 1201 | EXPECT_THAT( |
| 1202 | Completions.items, |
| 1203 | UnorderedElementsAre(AllOf(Not(IsDocumented()), Named("comments_foo")), |
| 1204 | AllOf(IsDocumented(), Named("comments_baz")), |
| 1205 | AllOf(IsDocumented(), Named("comments_quux")), |
| 1206 | // FIXME(ibiryukov): the following items should have |
| 1207 | // empty documentation, since they are separated from |
| 1208 | // a comment with an empty line. Unfortunately, I |
| 1209 | // couldn't make Sema tests pass if we ignore those. |
| 1210 | AllOf(IsDocumented(), Named("comments_bar")), |
| 1211 | AllOf(IsDocumented(), Named("comments_qux")))); |
| 1212 | } |
| 1213 | |
Ilya Biryukov | 981a35d | 2018-05-28 12:11:37 +0000 | [diff] [blame] | 1214 | TEST(CompletionTest, CompleteOnInvalidLine) { |
| 1215 | auto FooCpp = testPath("foo.cpp"); |
| 1216 | |
| 1217 | MockCompilationDatabase CDB; |
| 1218 | IgnoreDiagnostics DiagConsumer; |
| 1219 | MockFSProvider FS; |
| 1220 | FS.Files[FooCpp] = "// empty file"; |
| 1221 | |
| 1222 | ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest()); |
| 1223 | // Run completion outside the file range. |
| 1224 | Position Pos; |
| 1225 | Pos.line = 100; |
| 1226 | Pos.character = 0; |
| 1227 | EXPECT_THAT_EXPECTED( |
| 1228 | runCodeComplete(Server, FooCpp, Pos, clangd::CodeCompleteOptions()), |
| 1229 | Failed()); |
| 1230 | } |
| 1231 | |
| 1232 | |
Sam McCall | 9aad25f | 2017-12-05 07:20:26 +0000 | [diff] [blame] | 1233 | } // namespace |
| 1234 | } // namespace clangd |
| 1235 | } // namespace clang |