blob: 67081b5e260357fc6fb77bc8e5469bd763733363 [file] [log] [blame]
Daniel Dunbar8fbe78f2009-12-15 20:14:24 +00001// RUN: %clang_cc1 -fsyntax-only -verify -Wformat-nonliteral %s
Chris Lattnerb87b1b32007-08-10 20:18:51 +00002
Chris Lattnerb87b1b32007-08-10 20:18:51 +00003#include <stdarg.h>
Daniel Dunbarfeedba62009-11-17 08:57:36 +00004typedef __typeof(sizeof(int)) size_t;
5typedef struct _FILE FILE;
6int fprintf(FILE *, const char *restrict, ...);
7int printf(const char *restrict, ...);
8int snprintf(char *restrict, size_t, const char *restrict, ...);
9int sprintf(char *restrict, const char *restrict, ...);
10int vasprintf(char **, const char *, va_list);
11int vfprintf(FILE *, const char *restrict, va_list);
12int vprintf(const char *restrict, va_list);
13int vsnprintf(char *, size_t, const char *, va_list);
14int vsprintf(char *restrict, const char *restrict, va_list);
Chris Lattnerb87b1b32007-08-10 20:18:51 +000015
Ted Kremenek3fbeaea2007-12-17 19:03:13 +000016char * global_fmt;
17
Chris Lattnerb87b1b32007-08-10 20:18:51 +000018void check_string_literal( FILE* fp, const char* s, char *buf, ... ) {
19
20 char * b;
21 va_list ap;
22 va_start(ap,buf);
23
24 printf(s); // expected-warning {{format string is not a string literal}}
Ted Kremenek3fbeaea2007-12-17 19:03:13 +000025 vprintf(s,ap); // // no-warning
Chris Lattnerb87b1b32007-08-10 20:18:51 +000026 fprintf(fp,s); // expected-warning {{format string is not a string literal}}
Ted Kremenek3fbeaea2007-12-17 19:03:13 +000027 vfprintf(fp,s,ap); // no-warning
Chris Lattnerb87b1b32007-08-10 20:18:51 +000028 asprintf(&b,s); // expected-warning {{format string is not a string lit}}
Ted Kremenek3fbeaea2007-12-17 19:03:13 +000029 vasprintf(&b,s,ap); // no-warning
Chris Lattnerb87b1b32007-08-10 20:18:51 +000030 sprintf(buf,s); // expected-warning {{format string is not a string literal}}
31 snprintf(buf,2,s); // expected-warning {{format string is not a string lit}}
Daniel Dunbardd9b2d12008-10-02 18:44:07 +000032 __builtin___sprintf_chk(buf,0,-1,s); // expected-warning {{format string is not a string literal}}
33 __builtin___snprintf_chk(buf,2,0,-1,s); // expected-warning {{format string is not a string lit}}
Ted Kremenek3fbeaea2007-12-17 19:03:13 +000034 vsprintf(buf,s,ap); // no-warning
35 vsnprintf(buf,2,s,ap); // no-warning
36 vsnprintf(buf,2,global_fmt,ap); // expected-warning {{format string is not a string literal}}
Daniel Dunbardd9b2d12008-10-02 18:44:07 +000037 __builtin___vsnprintf_chk(buf,2,0,-1,s,ap); // no-warning
38 __builtin___vsnprintf_chk(buf,2,0,-1,global_fmt,ap); // expected-warning {{format string is not a string literal}}
Chris Lattnerdf18c6a2009-02-18 18:25:31 +000039
Chris Lattnerf638b972009-02-18 18:34:12 +000040 // rdar://6079877
41 printf("abc"
42 "%*d", (unsigned) 1, 1); // expected-warning {{field width should have type 'int'}}
43 printf("abc\
44def"
45 "%*d", (unsigned) 1, 1); // expected-warning {{field width should have type 'int'}}
46
Chris Lattnerb87b1b32007-08-10 20:18:51 +000047}
48
Ted Kremenek6dfeb552009-01-12 23:09:09 +000049void check_conditional_literal(const char* s, int i) {
50 printf(i == 1 ? "yes" : "no"); // no-warning
51 printf(i == 0 ? (i == 1 ? "yes" : "no") : "dont know"); // no-warning
Ted Kremenek94a5f6f2009-01-12 23:09:55 +000052 printf(i == 0 ? (i == 1 ? s : "no") : "dont know"); // expected-warning{{format string is not a string literal}}
Chris Lattnerd806cbc2009-12-22 06:00:13 +000053 printf("yes" ?: "no %d", 1); // expected-warning{{more data arguments than '%' conversions}}
Ted Kremenek6dfeb552009-01-12 23:09:09 +000054}
55
Ted Kremeneke68f1aa2007-08-14 17:39:48 +000056void check_writeback_specifier()
57{
58 int x;
59 char *b;
60
61 printf("%n",&x); // expected-warning {{'%n' in format string discouraged}}
62 sprintf(b,"%d%%%n",1, &x); // expected-warning {{'%n' in format string dis}}
63}
64
65void check_invalid_specifier(FILE* fp, char *buf)
66{
67 printf("%s%lb%d","unix",10,20); // expected-warning {{lid conversion '%lb'}}
68 fprintf(fp,"%%%l"); // expected-warning {{lid conversion '%l'}}
69 sprintf(buf,"%%%%%ld%d%d", 1, 2, 3); // no-warning
70 snprintf(buf, 2, "%%%%%ld%;%d", 1, 2, 3); // expected-warning {{sion '%;'}}
71}
72
73void check_null_char_string(char* b)
74{
75 printf("\0this is bogus%d",1); // expected-warning {{string contains '\0'}}
76 snprintf(b,10,"%%%%%d\0%d",1,2); // expected-warning {{string contains '\0'}}
77 printf("%\0d",1); // expected-warning {{string contains '\0'}}
78}
79
Anders Carlsson431ef632007-10-12 17:48:41 +000080void check_empty_format_string(char* buf, ...)
Ted Kremeneke68f1aa2007-08-14 17:39:48 +000081{
82 va_list ap;
83 va_start(ap,buf);
84 vprintf("",ap); // expected-warning {{format string is empty}}
85 sprintf(buf,""); // expected-warning {{format string is empty}}
86}
87
Anders Carlsson431ef632007-10-12 17:48:41 +000088void check_wide_string(char* b, ...)
Ted Kremeneke68f1aa2007-08-14 17:39:48 +000089{
Ted Kremeneke68f1aa2007-08-14 17:39:48 +000090 va_list ap;
91 va_start(ap,b);
92
Daniel Dunbar81f7f292008-08-05 00:07:51 +000093 printf(L"foo %d",2); // expected-warning {{incompatible pointer types}}, expected-warning {{should not be a wide string}}
John Thompsone413e882009-10-29 00:10:42 +000094 vsprintf(b,L"bar %d",ap); // expected-warning {{incompatible pointer types}}, expected-warning {{should not be a wide string}}
Ted Kremeneke68f1aa2007-08-14 17:39:48 +000095}
Ted Kremenek41362ce2007-10-12 20:51:52 +000096
97void check_asterisk_precision_width(int x) {
98 printf("%*d"); // expected-warning {{'*' specified field width is missing a matching 'int' argument}}
99 printf("%.*d"); // expected-warning {{'.*' specified field precision is missing a matching 'int' argument}}
100 printf("%*d",12,x); // no-warning
101 printf("%*d","foo",x); // expected-warning {{field width should have type 'int', but argument has type 'char *'}}
102 printf("%.*d","foo",x); // expected-warning {{field precision should have type 'int', but argument has type 'char *'}}
Daniel Dunbar81f7f292008-08-05 00:07:51 +0000103}
Douglas Gregore711f702009-02-14 18:57:46 +0000104
105void __attribute__((format(printf,1,3))) myprintf(const char*, int blah, ...);
106
107void test_myprintf() {
108 myprintf("%d", 17, 18); // okay
109}
Ted Kremenekdfd72c22009-03-20 21:35:28 +0000110
111void test_constant_bindings(void) {
112 const char * const s1 = "hello";
113 const char s2[] = "hello";
114 const char *s3 = "hello";
115 char * const s4 = "hello";
116 extern const char s5[];
117
118 printf(s1); // no-warning
119 printf(s2); // no-warning
120 printf(s3); // expected-warning{{not a string literal}}
121 printf(s4); // expected-warning{{not a string literal}}
122 printf(s5); // expected-warning{{not a string literal}}
123}
Chris Lattnercc5d1c22009-04-29 04:59:47 +0000124
125
126// Test what happens when -Wformat-security only.
127#pragma GCC diagnostic ignored "-Wformat-nonliteral"
128#pragma GCC diagnostic warning "-Wformat-security"
129
130void test9(char *P) {
131 int x;
132 printf(P); // expected-warning {{format string is not a string literal (potentially insecure)}}
133 printf(P, 42);
134 printf("%n", &x); // expected-warning {{use of '%n' in format string discouraged }}
135}
Ted Kremenek4554f9b2009-05-13 16:06:05 +0000136
137void torture(va_list v8) {
138 vprintf ("%*.*d", v8); // no-warning
139}
140